From patchwork Fri Oct 13 00:01:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harsha Sharma X-Patchwork-Id: 825167 X-Patchwork-Delegate: pablo@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netfilter-devel-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="PBYFkGa7"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yCnyF2ZZKz9s7c for ; Fri, 13 Oct 2017 11:04:21 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757389AbdJMAET (ORCPT ); Thu, 12 Oct 2017 20:04:19 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:56351 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757374AbdJMAES (ORCPT ); Thu, 12 Oct 2017 20:04:18 -0400 Received: by mail-pf0-f196.google.com with SMTP id b85so7228279pfj.13 for ; Thu, 12 Oct 2017 17:04:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=O+u1Ci2orjzS6WiUzK1pdagWasxZ0U9ydEX3f0YDJ1c=; b=PBYFkGa7lOntXMzbU+IXZs24/x3ayITbkirVECvPkZa+IN28JAUnAhJzjHWhJjxV/R adbBYn2XHxcta8MegbK4uEXAF0AX0dYwWASY8o7h7O+Q1ClgO/20Qz+tYVAQiWZslkjm XGh7mEAt1GA+Rwhi8/V6Wwq+AaZrXAZm3v++LNXyw68sM4+00Ot9dR1h8CWomyJvHUoV 1DCUcIp01wD6cxir+PZT7U0gJCfuElkNAVi9h9wJyEjZrAbrqX/NhaWEbUdGFGC7c1EZ KFOjGiODwDdvKU+/OBdBd9Uw+iXthn5NKfe6ggOaglcSDh6WquxwnyBNj6NozPzY/rPn RbuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=O+u1Ci2orjzS6WiUzK1pdagWasxZ0U9ydEX3f0YDJ1c=; b=qHm2JdzecSV3iMZVExIfSJfg45iQa0kEJJL/zSRc3afNgcyVA3jHmGDzDvcLEUn5sQ PfU/1hhgqi+Qr2Te0N7tA3FwNaU722aBP3eRkn4z+ztxU04XXWMYBZz30PLHkV08V4F4 CE+MnNyi0sfA+/igCQkFmAoUigOxEVOSbCgKRHaOl/zbtO4DahL2VQ04/VQnA9te3FKI +Qs6mbkBCgt9J0UKvfnJixrcOYnvNDPFF6SVbrKq8S/b0lL4SfF9tkdH7fJUTRc+mzw9 29DT53/9JT0P0vnLbv9CVgv0nklUD4sehzWdCEX9SZi4qj8tErddXayWTurQx/jovPoZ xqBw== X-Gm-Message-State: AMCzsaUGQrd0Qs4NNNvY8UcGOhPmqmEepjeJEOfzZFSV6oDhsCQNcPVc CGD6CB/1UovBv5yVf5m6i0U= X-Google-Smtp-Source: AOwi7QDz6Ma7/WhaHqCFATek6w+jb/Aa/gk2VaqUY43HasNSTkdpLee1A0zuyhuAwLmtE9CcyDE5SA== X-Received: by 10.84.138.1 with SMTP id 1mr1534196plo.404.1507853057887; Thu, 12 Oct 2017 17:04:17 -0700 (PDT) Received: from localhost.localdomain ([103.37.201.27]) by smtp.gmail.com with ESMTPSA id x79sm12894424pfa.156.2017.10.12.17.04.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Oct 2017 17:04:17 -0700 (PDT) From: Harsha Sharma To: pablo@netfilter.org Cc: netfilter-devel@vger.kernel.org, outreachy-kernel@googlegroups.com, Harsha Sharma Subject: [PATCH] src: Remove unnecessary cast on void pointer Date: Fri, 13 Oct 2017 05:31:16 +0530 Message-Id: <20171013000116.20107-1-harshasharmaiitr@gmail.com> X-Mailer: git-send-email 2.11.0 Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Done with following coccinelle patch @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: Harsha Sharma --- src/netlink.c | 2 +- src/tcpopt.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/netlink.c b/src/netlink.c index d5d410a..3a7ae62 100644 --- a/src/netlink.c +++ b/src/netlink.c @@ -2941,7 +2941,7 @@ static int netlink_events_cb(const struct nlmsghdr *nlh, void *data) { int ret = MNL_CB_OK; uint16_t type = NFNL_MSG_TYPE(nlh->nlmsg_type); - struct netlink_mon_handler *monh = (struct netlink_mon_handler *)data; + struct netlink_mon_handler *monh = data; netlink_events_debug(type, monh->debug_mask); netlink_events_cache_update(monh, nlh, type); diff --git a/src/tcpopt.c b/src/tcpopt.c index 7c6c255..c37c9d5 100644 --- a/src/tcpopt.c +++ b/src/tcpopt.c @@ -86,7 +86,7 @@ static const struct exthdr_desc tcpopt_timestamp = { }; #undef PHT -#define TCPOPT_OBSOLETE ((struct exthdr_desc *)NULL) +#define TCPOPT_OBSOLETE (NULL) #define TCPOPT_ECHO 6 #define TCPOPT_ECHO_REPLY 7 static const struct exthdr_desc *tcpopt_protocols[] = {