From patchwork Sun Nov 18 14:39:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taehee Yoo X-Patchwork-Id: 999498 X-Patchwork-Delegate: pablo@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netfilter-devel-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="CKuNZSXu"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42yZNg5nJBz9s3q for ; Mon, 19 Nov 2018 01:39:15 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727502AbeKSA7m (ORCPT ); Sun, 18 Nov 2018 19:59:42 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:39374 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726844AbeKSA7m (ORCPT ); Sun, 18 Nov 2018 19:59:42 -0500 Received: by mail-pf1-f194.google.com with SMTP id c72so8901447pfc.6 for ; Sun, 18 Nov 2018 06:39:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=JNs5z77nhHsCCduQjMJwIqFw8Wl8rjfQGcfY/8Bz47c=; b=CKuNZSXuX+QOzRpc7DG1/GCyxbXs+xjRs+uBDEncGMcn1orZdh4EKNg1zkW9D4Zhu1 eoDz3H+ssUUTFxtpG01EsqXRIVm+Yh0hKzkhSl3auiWjGJfcuLPt0m42BWJsRLMJreTi YyntFlsnC0nFpi2hstMqNFSwLPnjROEYlIzUQgOGckmHDn5VtEzHvdpPLARZdcMrAijQ 7I6d12Hf2Ov8C9LEwKzOJfc12IhOV0vxZBxIhwTOEb/Hw4G6Mjd3zW27c64plPLv+gyi n9E/el5RJ5dGHX1qeGuvKN+YxhX8viuyjoJZxRg2gr8bZzHjZV+5K+lX36QjSGzLAT+2 8DWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=JNs5z77nhHsCCduQjMJwIqFw8Wl8rjfQGcfY/8Bz47c=; b=tAG+E0Ys5KnogzZLW/JsDu9+bLYIZ+2Na4jb2UVghFqdoxInTnM5PpLkBIPWIcbSzE 7CB5HB+9l2UxfatbAujW+diwqNMq2G1yXzXsHdfX2wgqoUYOJbqqW19kQxeRMn7g8CxZ zf2q15ox4xpB2fXQCn8ruIfwPk8hJXwAhjyMLQifb9DC3zdIRMchiLBCj+VIUd7c4TFG KM77Ay6Tz0MCLA37hu0JPlm/uZoEXlvhECfmIWHhl5Kh414sXPye01+Cd8oVvI8ICFXi 1Zizrz5rVPDDFb6y76tgltOe4fzSB0YYS3vCnIFdKTYWX+E+PdHZgSSz6jcCFXTP6zX6 +iDQ== X-Gm-Message-State: AGRZ1gLct2DX3GSJhb8gAi/fLR64yZUDkeAwFmE1p0a5/r2qMIqMBoSL HeSx+SaASTY1oe5yzxDlNSs= X-Google-Smtp-Source: AJdET5fm6MbUrMusbw06KJpwh7Q/8AWkku4WHcmxCdxhTooJvLXZdtTV3vv9ZWuL6KBpxX9VR8eGtQ== X-Received: by 2002:a63:dc0c:: with SMTP id s12mr16938964pgg.398.1542551952959; Sun, 18 Nov 2018 06:39:12 -0800 (PST) Received: from ap-To-be-filled-by-O-E-M.8.8.8.8 ([14.33.120.60]) by smtp.gmail.com with ESMTPSA id 73-v6sm48114531pfl.142.2018.11.18.06.39.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Nov 2018 06:39:12 -0800 (PST) From: Taehee Yoo To: pablo@netfilter.org, netfilter-devel@vger.kernel.org Cc: ap420073@gmail.com, rdunlap@infradead.org, sfr@canb.auug.org.au, ecklm94@gmail.com, arnd@arndb.de Subject: [PATCH nf] netfilter: xt_TEE: fix build failure Date: Sun, 18 Nov 2018 23:39:03 +0900 Message-Id: <20181118143903.22008-1-ap420073@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org xt_TEE.c needs nf_dup_ipv6.c to support ipv6 packet duplication. So that if xt_TEE is enabled, nf_dup_ipv6 will be automatically selected. But there is build failure scenario. test config: CONFIG_NETFILTER_XT_TARGET_TEE=y CONFIG_NF_DUP_IPV6=m compile result: net/netfilter/xt_TEE.o: In function `tee_tg6': net/netfilter/xt_TEE.c:57: undefined reference to `nf_dup_ipv6' This patch forces to avoid above config. Fixes: 5d400a4933e8 ("netfilter: Kconfig: Change select IPv6 dependencies") Reported-by: Randy Dunlap Reported-by: Reported-by: Stephen Rothwell Signed-off-by: Taehee Yoo Acked-by: Randy Dunlap --- net/netfilter/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig index 2ab870ef233a..a0c2712290ea 100644 --- a/net/netfilter/Kconfig +++ b/net/netfilter/Kconfig @@ -1011,7 +1011,7 @@ config NETFILTER_XT_TARGET_TEE depends on IPV6 || IPV6=n depends on !NF_CONNTRACK || NF_CONNTRACK select NF_DUP_IPV4 - select NF_DUP_IPV6 if IP6_NF_IPTABLES + select NF_DUP_IPV6 if IP6_NF_IPTABLES != n ---help--- This option adds a "TEE" target with which a packet can be cloned and this clone be rerouted to another nexthop.