From patchwork Fri Nov 16 17:25:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Pfaff X-Patchwork-Id: 999101 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ovn.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42xQ9K3TXTz9s7T for ; Sat, 17 Nov 2018 04:25:23 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 2F135B01; Fri, 16 Nov 2018 17:25:21 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 89AB09FA for ; Fri, 16 Nov 2018 17:25:19 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 9C424829 for ; Fri, 16 Nov 2018 17:25:18 +0000 (UTC) Received: from sigabrt.benpfaff.org (unknown [208.91.3.26]) (Authenticated sender: blp@ovn.org) by relay10.mail.gandi.net (Postfix) with ESMTPSA id E68AE24000A; Fri, 16 Nov 2018 17:25:14 +0000 (UTC) From: Ben Pfaff To: dev@openvswitch.org Date: Fri, 16 Nov 2018 09:25:11 -0800 Message-Id: <20181116172511.7908-1-blp@ovn.org> X-Mailer: git-send-email 2.16.1 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Simon Horman , Ben Pfaff Subject: [ovs-dev] [PATCH] pcap-file: Correctly format enum type. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org The underlying type for an enum is somewhat unpredictable in that the compiler and the ABI influence it. The format specifier I used here was apparently correct for i386 on Linux but wrong for x86-64. It's better to just use a cast. Reported-by: Simon Horman Signed-off-by: Ben Pfaff Reviewed-by: Simon Horman --- lib/pcap-file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/pcap-file.c b/lib/pcap-file.c index 863a9a6c7bf2..e4e92b8c20ef 100644 --- a/lib/pcap-file.c +++ b/lib/pcap-file.c @@ -153,8 +153,8 @@ ovs_pcap_read_header(struct pcap_file *p_file) p_file->network = byte_swap ? uint32_byteswap(ph.network) : ph.network; if (p_file->network != PCAP_ETHERNET && p_file->network != PCAP_LINUX_SLL) { - VLOG_WARN("unknown network type %"PRIu16" reading pcap file", - p_file->network); + VLOG_WARN("unknown network type %u reading pcap file", + (unsigned int) p_file->network); return EPROTO; } return 0;