From patchwork Thu Oct 11 16:15:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Douglas X-Patchwork-Id: 982596 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=cadence.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=cadence.com header.i=@cadence.com header.b="olCMmp5G"; dkim=pass (1024-bit key; unprotected) header.d=cadence.com header.i=@cadence.com header.b="ir069EYE"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42WGL14tX4z9s7T for ; Fri, 12 Oct 2018 03:16:09 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729751AbeJKXoC (ORCPT ); Thu, 11 Oct 2018 19:44:02 -0400 Received: from mx0a-0014ca01.pphosted.com ([208.84.65.235]:34718 "EHLO mx0a-0014ca01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726700AbeJKXoC (ORCPT ); Thu, 11 Oct 2018 19:44:02 -0400 Received: from pps.filterd (m0042385.ppops.net [127.0.0.1]) by mx0a-0014ca01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w9BGDg7s005455; Thu, 11 Oct 2018 09:15:54 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cadence.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=proofpoint; bh=PJhYcJ/ddHYKnYRVJ+q7hPi/qb4fVDn8zbgDl04xfQc=; b=olCMmp5GOTdqva9lOGHwbyNDLyM+nXOz0m40hMhUsDG2UpC4FpJX52YC5dxzYPpTY3eK ThULILkY+Tks74AU6dIbsrpYaNgeUTKpuY/GF3HwNIYB94+SyNtw/Y6gy1jWzRG3EKZ9 GzFUcgbJQY6PAvkydV3jQeUCf+MMftOjH0iyKTKNQrWSizbLC20OSOLb/TocOK3L+6WX DVbAqZhQmapOhFTwhsJvOHASPfnusrDM6pTqjbhq8zsxs/lOLbXN5ZJJXfRHVOSbtYob 7NMMRG4mqvWoTeTG0FOntrw6h2CXypxHnbc8j6j7gXzXcItmLvkOwN9CSsZ15+vsVTkA Gw== Authentication-Results: cadence.com; spf=pass smtp.mailfrom=adouglas@cadence.com Received: from nam04-sn1-obe.outbound.protection.outlook.com (mail-sn1nam04lp0083.outbound.protection.outlook.com [216.32.180.83]) by mx0a-0014ca01.pphosted.com with ESMTP id 2mxuwx7qhs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 11 Oct 2018 09:15:54 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cadence.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PJhYcJ/ddHYKnYRVJ+q7hPi/qb4fVDn8zbgDl04xfQc=; b=ir069EYE9ClrpMW2o51Wmon0SptCodhKDc3IgAOF8B8GoJ1c7uweIyfR4hqeF5V/QYEMgy6nwz+HdFnTuoVwUTEkSbudo5bOYPUA1/x5QGH8UmF3QEYPCXaBUv5865fB6+cszNpAUwl2g6xZ5vjtXwVw8JvuOxwQ148a/wacrgU= Received: from BYAPR07CA0007.namprd07.prod.outlook.com (2603:10b6:a02:bc::20) by CO2PR07MB697.namprd07.prod.outlook.com (2a01:111:e400:141f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.24; Thu, 11 Oct 2018 16:15:51 +0000 Received: from CO1NAM05FT044.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e50::204) by BYAPR07CA0007.outlook.office365.com (2603:10b6:a02:bc::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1122.15 via Frontend Transport; Thu, 11 Oct 2018 16:15:51 +0000 Received-SPF: SoftFail (protection.outlook.com: domain of transitioning cadence.com discourages use of 158.140.1.28 as permitted sender) Received: from sjmaillnx2.cadence.com (158.140.1.28) by CO1NAM05FT044.mail.protection.outlook.com (10.152.96.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1250.2 via Frontend Transport; Thu, 11 Oct 2018 16:15:50 +0000 Received: from maileu3.global.cadence.com (maileu3.cadence.com [10.160.88.99]) by sjmaillnx2.cadence.com (8.14.4/8.14.4) with ESMTP id w9BGFmPC028960 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 11 Oct 2018 09:15:49 -0700 X-CrossPremisesHeadersFilteredBySendConnector: maileu3.global.cadence.com Received: from maileu3.global.cadence.com (10.160.88.99) by maileu3.global.cadence.com (10.160.88.99) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 11 Oct 2018 18:15:54 +0200 Received: from lvloginb.cadence.com (10.165.177.11) by maileu3.global.cadence.com (10.160.88.99) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Thu, 11 Oct 2018 18:15:54 +0200 Received: from lvloginb.cadence.com (localhost [127.0.0.1]) by lvloginb.cadence.com (8.14.4/8.14.4) with ESMTP id w9BGFlnb032082; Thu, 11 Oct 2018 17:15:47 +0100 Received: (from adouglas@localhost) by lvloginb.cadence.com (8.14.4/8.14.4/Submit) id w9BGFl08032081; Thu, 11 Oct 2018 17:15:47 +0100 From: Alan Douglas To: CC: , , , , , Alan Douglas Subject: [PATCH v4 1/4] PCI: cadence: Use AXI region 0 to signal interrupts from EP Date: Thu, 11 Oct 2018 17:15:43 +0100 Message-ID: <1539274543-31946-1-git-send-email-adouglas@cadence.com> X-Mailer: git-send-email 1.9.0 MIME-Version: 1.0 X-OrganizationHeadersPreserved: maileu3.global.cadence.com X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:158.140.1.28; IPV:CAL; SCL:-1; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(376002)(396003)(136003)(346002)(39860400002)(2980300002)(36092001)(199004)(189003)(4326008)(7636002)(5660300001)(246002)(478600001)(87636003)(26826003)(14444005)(186003)(6916009)(486006)(336012)(36756003)(54906003)(26005)(47776003)(2906002)(2616005)(86362001)(50226002)(126002)(476003)(426003)(8676002)(51416003)(8936002)(50466002)(42186006)(48376002)(356004)(6666004)(107886003)(305945005)(105596002)(106466001)(2351001)(316002)(16586007); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR07MB697; H:sjmaillnx2.cadence.com; FPR:; SPF:SoftFail; LANG:en; PTR:corp.cadence.com; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; CO1NAM05FT044; 1:V7rCiQGNkcpUQeaIQxUegFfod4Xz2/U+Pz7//V+E+S83Mixb43mQfo8Y92bueGBdQzBq5FBGAPbs2t1kWtg9MzZbtD5ozczAu5qaFTFzpr+DWPyIMHjWTB0i+MOTMXQT X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a85bed70-4d70-42b4-2709-08d62f94d005 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060); SRVR:CO2PR07MB697; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB697; 3:qYqtGLneLykHJTFko6BGto8OdvrPILgAQBSSKboYvvWwOg9074WoDTuUwdaNUnYzrECASgWboHncBQipWk8WPu7QGXJ3zoIE7dWRdpRrYu0n8aLQRafvEijtJ8eVW5g0JAk3bTA53DrubA8fmOeNx+qFzwsSPMiem96w3Xhk6tZnF746BdKAEhDq/Z6HIh2S/S45QaIbJ3jhRIc91nxFnyTxRgNrvc+yPpQsVaUg5x6VY7M8+VLJ3GUyjsAUNJM/LfkrePEdteGkNnRAiALOOQTw+QBGkzW1ovBqvPOh61O+Btgos6ESJoDXF87dzrRvO/NsRg4GWvSdDY+XgPlI6yBD8qdo9REjzMal2E7LW/g=; 25:jLKq8MSXGMD8gEqP9B6Jb7M1J3RVrUAMqMzxySQwlgF7MHAudhxpJm6HDH0mOhZR/k5yNfxKBpGqxIkRmpOeKqXnscNKe6RDI32gVWty9Kq4+l7i1V0LNKJK5Or7ckA+Z7sp9UVs5Gb8Ga69u65JkA4idwgioE7VuIsPrDuy1eJuNjsWv/RMgtYG9T7Z+Hy2PSusxO8UQH5JGGWt6e3k4fgQRRauZKV4Mwzif1mmFgdevg9OdEBKJ5b+U3PSlecH1OS3D8o3eQrISqkpxW4DqxyEplSd1OGdTstt2RCL1taEcbPcbReAQsa+HaPRFQOut9tD0Q1OzBCzfkjIIMeoZPKS1qMYKZIIsBNIhjiPZ6g= X-MS-TrafficTypeDiagnostic: CO2PR07MB697: X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB697; 31:XHOUGc02gTEQCbtferLKPY3BRtjs6wZFkuuQV4D/tIar5tcWkYTX41zCDUSQ1BPRa2hIwU+G7Pxos889zo9Cnp1SI0sOb3tFyMemHwDzILZNJ3+Z57CTH6PGTgfkun3psLglfFFO9ST/711Ez13Nrs+u4xtcDl4EIOWoRGRpOYcGuUJsDmwWe+C/QPTiIzWoNMtVUr3p1qOgk1X9ZHySitkjSInj+Q+YBoFqlqf0NkY=; 20:MdgGEWJhTuVFDPGxjYgib5lvQ7z6ouSQ05vdo57rwCgzDQ9WMZbIAbk0sfr+9x3hj2dzTMXuKf9J4SmmtQJX7TqezHFAqqP9AdIxHnGx8tvq0+H3txyeemc5+xXcV+izXzKT+xiQ2aFHv4W4f8rjrzYa4U7gEF+6Z4CxF5pFBtlNqMxJdmFsUgo/w0wvlTqMo90f2pIx3kgOi1w+4ZVNRBnET68fRad7NFhmEY8EcvcReDXKH8KV+o3ke8zsYIPsokN9QyKM/KEnDetIiIXIYUiW3V90o93XgQ4pR5haKmL/ZgNmzgJXYAU1v273P4AC1S4h8KobcZ1qtOsaqJvmNWZODlOMzBZO9j0OCgCp9btuiHa+RPmFGDoQ5MR4SdTVZFlYZJ5vgiiq03RQbXrTCP2kse3iPGe6fXDYuyBj3dGbG876vnxxW5XBd2XwvtBmqXmhCVAKW8H1hmNQevl5G6hOCJv1ZpKefB/c6aJi3+xbPy25Y64XCBbN6A8AbttV X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(72806322054110); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(3002001)(10201501046)(93006095)(93003095)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123560045)(20161123558120)(201708071742011)(7699051); SRVR:CO2PR07MB697; BCL:0; PCL:0; RULEID:; SRVR:CO2PR07MB697; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB697; 4:7jIIbanCT3AF+LG1dX9Rn4OvFV+kKkRjUlQzC4I5CFBUpZlwipXU6kBWvb0WWFGUnmceXzU0N4mN/MLa4DwaAZjTjL9aC4B2Yxy9TxcnvloIU7Vjee0X+JVTQm8uRyp+EUsn0MANLb5fzUzQxbbyuheqH45/ToAEY0C3FxK1zRx2LWMT8HUmkvpDwgZOrlr0BJIOVJjy2bcyd9zLmAqj230h0Fv8Thj8JsXIaD8b0ibol0oBexfgBjeFGCdvv1g+FBkg2iFQm0fTiqdjfrWUtJYlX2Dte+XCbmFx72qCVnHQScYjc8lm03VG0lLDZcON X-Forefront-PRVS: 08220FA8D6 X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB697; 23:6YJ5BDxUH3nUtOwsUiRn+jiMbAkWD1nwNhfRb5glsx2uYYJPfyh6oNtQsMdbESWOKiDwgMVtCo9zXNctOeOjWqdGgg88XyIsr50vCEMItJtCrflKdPzMJsWEtNM7KZZ38CJB44l728TNA9zyOVznoBN9VEMHVcGC36oS+CNX12ItCoxRBsIUNzc83eK8lZUOBn/mV3l+smEZTl9xL4/2/Ar1G47HY61+AAVybF4mFtzhFL/kOwb78SM0n/uqEyMrWUC0IOY3Pt4UIX3f/g0NYFsWfHnWOMoRNWLQ27huqYos/ZpzvJLMlNTdIJZ6UWDPllD+vkp4dXT6US6ZRr1gPE5loqYPmdebd6KAvjaMHqxtIoSpOIp3goE0YBze/aAwA+8B8ecyI6iihvdePxs0TWSeyqEibct/dsuWBR99P2w27jRq21b0ZTVf713eMMrDKfwZLK14+rKukC627MsoQb/tbCVLBzK6fpdoISQJYtij06cEvedyoOVawcuS2lnChDks0DEzJ4bW33yctisB3py9fHbJnCvhV1KIvDFk7QwUH/g+NelrGX/TJY23peptem8JdlhUaO8d3gsRJlp6W+uH6K+yHaIQ3eL7J4fRO9vRwpHovF0QDIotM/pfV6/F9zVD+MuospW7GkAwga82KZrwidFnElxzo79MhfbdVRmd7cKTY/rh4ZvLZqRMumliceroQ5NJc/Ql6XdMorAhk0kUfGvhYSEAUekMNyYokz1RXpU2oAjYemWdnS3D9eo56Qale/GDBXaMkzt5fWd8A5ABnFxDj/dBbfZ3Ho5C225BK7yJLi0c81EY7uNcw7zy8VAlUZ2ly5XdYXPhmrUS4c1t6u+RqrbiClSbYD96ER/iqrhspA61XlvhOfLc7POshvqYWpwMve/+ZXEaB+secgx9KV153uDgXv1y2wmw0JZwQj5ByYxsW4oqRF0s1tz/g6TbL5h5fIvM5QPWi0giBynLSPndSTh27eBvt2u1F9uSjHAzAVL9BWJyY1irKna+vy1L4P/oo7S/lms4xa14sxmWHgwYUH73DLrS18c/00Q= X-Microsoft-Antispam-Message-Info: fSen4zO0QR9I60G6Ucko3yF1z9W5EY8dCh5gu5bzfrKuIxzsneiTidlhNDH+wDrqjIHMGFkgiAWSZY+vU9u5ru+ESAfA/UqMKqDfruQmQyHEbLEXZWXdffJXTbqHNSaN2pZNnFDWW88bIN2WdAXfTGjDI9hSh6cwKPYL62zJAXyZM8wbBazGfHh5pJjyFZPGy/oKOI2eQswxDqtR5YnyRKlax56pX61zwgu+zuchckNt5Mvi5KB+TTC4A2JfZffTemziFhjaytRUi6H2KQLXeRxjFFV6Iu8TSHqx2WoPrIPKseGEKUqh5CPvF7DP9hkPhh7WZmNCObghJELHd/vOYQQrbe4TGjcWulypQEb52cunVse2hTRXdEpKkBQQgUA5AqvXneguN8mpIeET9sOXqg== X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB697; 6:kCdLUVEbmda8waRICkVxC38iToRmFjOfgWS61AL+QX0JBPlx9tJrNEtxrXi4in52oiMDZVp6xOLGdKromDlWPKh7O0rz0ErPiZ1ak4MgQ0l5qgmikoQGcPVbRQzC7in3YrerFaQXlw8D3Uo2PziEWAhVLwtUEvX1xXJzUGuhBF8QN8lz9eesze17gvg4Xg2JZbpUG3ZzzTv8ieZFxRCCbv2ybocyjB0KaQgV3qfR11vwftEPGz2E7/RkZHSM8WuUwFuTI76ZE3NrUOW8ZEB818N7c9i/Z0DTGwcylN5bqqFCiLwYqgE54PQS7IcQIhV8VlocxLqo26RFU2tCte7mKyQYPkVkQkvgDXr2wSuD/Wx14JOJpIOWv8bVU726LCoRlA9T4QPCejMBBqJ634tZld633eSNJCy1qFGNicL/pa/wRzJN9syZ7fu79E3E4xgZaPv+JKgO1dVK5ISQDtrKRA==; 5:3nj4DlvU48fvEyxUuwZWoeCtsEEiWTg4z0KLJ6OOysmQddJ1/CG+Xh2MaH0eiXbgeArlCh8WX5lWKjtkkddtYlEcSIbrb91zIxxZjgZ5oRP3fLfCpQp5w9DuuVrkMdWYMRbZd0Lhn0Hi2FgFdbCz6GaQygdrJD+WctkYjfIYxRA=; 7:PLRFgqSl/HOrKH8DP4MPdZNZ5/BBE+6VgOVVHnO7AjnsBJGKeP9naL94S3YZS9a+NWPPg6svye2prvgJDvTkA0+g9qMOyusEDtyzYYTzggOGcwMKuSngzuRAWXCumcLOhzQhmmUT35GtG6x8xdQ82i2PYu2d5Ql8r2TJfTvXg0X0bhGPcV9qcSQyQXxIAxmxajClqsUadC6MqwBJpI5fWz5VRSnN0O3a1vIszH+UlzNXJYDEY8Wec4g8el4E/n5Q SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB697; 20:1xY6EzBnfbvznMXPTZ0lQ68B2ngNiNb4gfFWnpO+ycgR9vMcuQmwqLt0xNtSnSTVj16k6qqdq34KMVHCcQg+jvd5DFl9/F4+Bq3bqZWxLz9yMHw+PHfLKht4MsFY7bmMGO/HpSVGilI7J8U26cckqSo3+2kS+XYUrexmtRMPGCn08a4oprEBqQDGOb1zTyHw+cdr8qOyMjceOfzSVj7zxWPTRuuew7+RG+BnzozZaUGyhB90PNS6J5oAmiQ3IoEQ X-OriginatorOrg: cadence.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2018 16:15:50.8980 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a85bed70-4d70-42b4-2709-08d62f94d005 X-MS-Exchange-CrossTenant-Id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=d36035c5-6ce6-4662-a3dc-e762e61ae4c9; Ip=[158.140.1.28]; Helo=[sjmaillnx2.cadence.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB697 X-Proofpoint-SPF-Result: pass X-Proofpoint-SPF-Record: v=spf1 a:mx-sanjose2.Cadence.COM a:mx-sanjose4.Cadence.COM a:mx-sanjose5.Cadence.COM include:mktomail.com include:spf-0014ca01.pphosted.com include:spf.protection.outlook.com include:auth.msgapp.com include:spf.mandrillapp.com ~all X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-10-11_07:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 priorityscore=1501 malwarescore=0 suspectscore=3 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=659 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810110156 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org The IRQ physical address is allocated from region 0, rather than the highest region. Update the driver to reserve this region in the bitmap, and to use region 0 for all types of interrupt. This corrects a problem which prevents the interrupt being signalled correctly if using the first address in the AXI region, since an offset of zero will always be mapped to region 0. Fixes: 37dddf14f1ae ("PCI: cadence: Add EndPoint Controller driver for Cadence PCIe controller") Signed-off-by: Alan Douglas --- drivers/pci/controller/pcie-cadence-ep.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/pci/controller/pcie-cadence-ep.c b/drivers/pci/controller/pcie-cadence-ep.c index 9e87dd7..6692654 100644 --- a/drivers/pci/controller/pcie-cadence-ep.c +++ b/drivers/pci/controller/pcie-cadence-ep.c @@ -258,7 +258,6 @@ static void cdns_pcie_ep_assert_intx(struct cdns_pcie_ep *ep, u8 fn, u8 intx, bool is_asserted) { struct cdns_pcie *pcie = &ep->pcie; - u32 r = ep->max_regions - 1; u32 offset; u16 status; u8 msg_code; @@ -268,8 +267,8 @@ static void cdns_pcie_ep_assert_intx(struct cdns_pcie_ep *ep, u8 fn, /* Set the outbound region if needed. */ if (unlikely(ep->irq_pci_addr != CDNS_PCIE_EP_IRQ_PCI_ADDR_LEGACY || ep->irq_pci_fn != fn)) { - /* Last region was reserved for IRQ writes. */ - cdns_pcie_set_outbound_region_for_normal_msg(pcie, fn, r, + /* First region was reserved for IRQ writes. */ + cdns_pcie_set_outbound_region_for_normal_msg(pcie, fn, 0, ep->irq_phys_addr); ep->irq_pci_addr = CDNS_PCIE_EP_IRQ_PCI_ADDR_LEGACY; ep->irq_pci_fn = fn; @@ -347,8 +346,8 @@ static int cdns_pcie_ep_send_msi_irq(struct cdns_pcie_ep *ep, u8 fn, /* Set the outbound region if needed. */ if (unlikely(ep->irq_pci_addr != (pci_addr & ~pci_addr_mask) || ep->irq_pci_fn != fn)) { - /* Last region was reserved for IRQ writes. */ - cdns_pcie_set_outbound_region(pcie, fn, ep->max_regions - 1, + /* First region was reserved for IRQ writes. */ + cdns_pcie_set_outbound_region(pcie, fn, 0, false, ep->irq_phys_addr, pci_addr & ~pci_addr_mask, @@ -517,6 +516,8 @@ static int cdns_pcie_ep_probe(struct platform_device *pdev) goto free_epc_mem; } ep->irq_pci_addr = CDNS_PCIE_EP_IRQ_PCI_ADDR_NONE; + /* Reserve region 0 for IRQs */ + set_bit(0, &ep->ob_region_map); return 0; From patchwork Thu Oct 11 16:15:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Douglas X-Patchwork-Id: 982597 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=cadence.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=cadence.com header.i=@cadence.com header.b="soxFUwGJ"; dkim=pass (1024-bit key; unprotected) header.d=cadence.com header.i=@cadence.com header.b="SJxYQYfH"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42WGLJ1pXKz9s7T for ; Fri, 12 Oct 2018 03:16:24 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728553AbeJKXoR (ORCPT ); Thu, 11 Oct 2018 19:44:17 -0400 Received: from mx0a-0014ca01.pphosted.com ([208.84.65.235]:34840 "EHLO mx0a-0014ca01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726700AbeJKXoR (ORCPT ); Thu, 11 Oct 2018 19:44:17 -0400 Received: from pps.filterd (m0042385.ppops.net [127.0.0.1]) by mx0a-0014ca01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w9BGDejp005443; Thu, 11 Oct 2018 09:16:11 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cadence.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=proofpoint; bh=zdoICzqt+/BwVeoq1sZW3/Zqfm0BXrQWMZFt8Y7LdIw=; b=soxFUwGJKhXwpxdIcCJ6UJHdvZLBtE9puZB//I+ln/bDqGfH9gDwb8Lml3weQOSiios+ q2brY3HDyBipuLQ0t7qtV7iYX6GLSg2LrwJxhET7CqNkG4GrreR3Kd5uphC7f1pDlVNK QCt4CFcgH7a+bSGYTVc1beXqtXDs5IR316xxqUfS9pJaylVxv21FSRnp1QM3Bqze8mfK 73WnOEtVR2P/phLiKl7VIWeyssHosAYxHs3gFNrfM2v98hKE5r7ifpKfNpnziKty0uix ZLv8CaCkNMyJ2LR1D0ywrTY3MCHI9HK74qnrhmhBChQItRM5hhCmeJIP8x591tfL/rL8 tQ== Authentication-Results: cadence.com; spf=pass smtp.mailfrom=adouglas@cadence.com Received: from nam01-bn3-obe.outbound.protection.outlook.com (mail-bn3nam01lp0180.outbound.protection.outlook.com [216.32.180.180]) by mx0a-0014ca01.pphosted.com with ESMTP id 2mxuwx7qk5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 11 Oct 2018 09:16:11 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cadence.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zdoICzqt+/BwVeoq1sZW3/Zqfm0BXrQWMZFt8Y7LdIw=; b=SJxYQYfH5ajnNyLqFAA0kwT3XvfldAKacuJ1R4joZnFBP3CUlbHwvQVMb3Lv3UgQoXu3KSQQaNlBDfKjaZQEMhvYXL4ZGGhbdoo8blGyFyyUA1eq0oDU+x8YpGOXQs0HP6Z3o4hBaCePu5T3ni+YtnYqp8RPK+JICjq5DPegDAY= Received: from DM5PR07CA0109.namprd07.prod.outlook.com (2603:10b6:4:ae::38) by BLUPR0701MB1825.namprd07.prod.outlook.com (2a01:111:e400:5164::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.25; Thu, 11 Oct 2018 16:16:09 +0000 Received: from BY2NAM05FT036.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e52::202) by DM5PR07CA0109.outlook.office365.com (2603:10b6:4:ae::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1164.22 via Frontend Transport; Thu, 11 Oct 2018 16:16:08 +0000 Received-SPF: SoftFail (protection.outlook.com: domain of transitioning cadence.com discourages use of 158.140.1.28 as permitted sender) Received: from sjmaillnx1.cadence.com (158.140.1.28) by BY2NAM05FT036.mail.protection.outlook.com (10.152.100.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1250.2 via Frontend Transport; Thu, 11 Oct 2018 16:16:08 +0000 Received: from maileu3.global.cadence.com (maileu3.cadence.com [10.160.88.99]) by sjmaillnx1.cadence.com (8.14.4/8.14.4) with ESMTP id w9BGG6TM031333 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 11 Oct 2018 09:16:07 -0700 X-CrossPremisesHeadersFilteredBySendConnector: maileu3.global.cadence.com Received: from maileu3.global.cadence.com (10.160.88.99) by maileu3.global.cadence.com (10.160.88.99) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 11 Oct 2018 18:16:12 +0200 Received: from lvloginb.cadence.com (10.165.177.11) by maileu3.global.cadence.com (10.160.88.99) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Thu, 11 Oct 2018 18:16:12 +0200 Received: from lvloginb.cadence.com (localhost [127.0.0.1]) by lvloginb.cadence.com (8.14.4/8.14.4) with ESMTP id w9BGG5pN000395; Thu, 11 Oct 2018 17:16:05 +0100 Received: (from adouglas@localhost) by lvloginb.cadence.com (8.14.4/8.14.4/Submit) id w9BGG5dh000392; Thu, 11 Oct 2018 17:16:05 +0100 From: Alan Douglas To: CC: , , , , , Alan Douglas Subject: [PATCH v4 2/4] PCI: cadence: Write MSI data with 32bits Date: Thu, 11 Oct 2018 17:15:54 +0100 Message-ID: <1539274554-32252-1-git-send-email-adouglas@cadence.com> X-Mailer: git-send-email 1.9.0 MIME-Version: 1.0 X-OrganizationHeadersPreserved: maileu3.global.cadence.com X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:158.140.1.28; IPV:CAL; SCL:-1; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39860400002)(136003)(396003)(376002)(346002)(2980300002)(36092001)(199004)(189003)(86362001)(5660300001)(105596002)(106466001)(305945005)(2906002)(50466002)(126002)(7636002)(2616005)(2351001)(476003)(51416003)(54906003)(356004)(6666004)(36756003)(47776003)(478600001)(6916009)(50226002)(8936002)(8676002)(246002)(26826003)(4326008)(87636003)(14444005)(107886003)(186003)(48376002)(486006)(336012)(16586007)(42186006)(316002)(26005)(426003); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1825; H:sjmaillnx1.cadence.com; FPR:; SPF:SoftFail; LANG:en; PTR:corp.cadence.com; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; BY2NAM05FT036; 1:LDdaLBGzb8WS9A0puU4fhiXjRF32iC1bU5FanvI0s9Yxpe10uWDXfVfovI9geWf/U6X3qSQBqq2T1DF8dr1MwFgZG/RXgEiAWNK4TIaV37Ydw4J3rrkz2D0ZKgBLOiD2 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fe8a1262-62bc-482c-f31a-08d62f94da4f X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060); SRVR:BLUPR0701MB1825; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1825; 3:XRzn2RgpeBLnVbKrQltcuNtp2PiwD0DqiqN7D8l1c/QGbvaYnErfVzOiSOWe1ODvJAWgRgFzEhO830gv7EXlrnPpP5YCJscCMyiSoRylffXJhhdeaVy4ezgIsEYKlERQxtkIU7/AzilqJbAALIeHJpnEvMSTQyy/YTxAArWeF8LhHZgsOw4XkKY/58HlODMAkKXi9XKckkf9xzMqmbzo8ddCIrxV4HzoMyfC5/qyRUSe8ux8/fIQAnK7UffRypZYytcYhL7Mr88jrV93ehMHO1t2hhElAwQvnQOkYqZbKE0oVRoXZnZ2OMzc/YCKQVlJQiFnuzDvOMEMT2pIVJfM5ZhFVFw998PKvKiU06cyzmA=; 25:zwyrY+LRgFsR++qi7bSbBAHTVGnwYolu9fqNrbSfGXHk3fCSl7KyPLfyUpe4A6ronuj0MzPD/M92Pive9wLboOs5W2sj0lbeGkoE83oRaSQnf0nofYOEeC+eHt204MpddrUpo7zdn+1HLeAvYcKQm4HVxZTjIyEkT9KaedM6qWfxAcK05f2nyUC7QOSfo1MH2iUcGGc/bWcxbnWvmbPKR/82v2eyHmnq79zg1z2ZlArbNbxI8A6upfgMjBAuIuausteZFoa0/zlp8QUGenV3N2CV+VIfUs+yJF7d054zN3dOivQp1fXBQ3OPOTpc4fTLATuSVP7RmxRFK7RSsTBzchKNptCbcVMM6MNIx+BEGpY= X-MS-TrafficTypeDiagnostic: BLUPR0701MB1825: X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1825; 31:7Jvv+4f+vfZq05BxnarticCBFVuoeD6Cb/qt5K+lL+pHrIAbWvt3rWVpmgoyh9h0FZVbeD3KBTEH/Bkf5UA3wn7KR7f8hrgiK3EPfc+d/Bl4LaET4tsy2woGycDqWuG8JQZO/lHc55gwjU3kWKdYtRUZsFW3YFZp5cZ3eeQWWNXSRqLQZyWiwutLNTPZHY48lEcw9idZ9JH9VFoCfEs9U9A1Qwdt0vfdRLK1Lmr9F+8=; 20:tgSkV1XFACb36eIzXulyAftzZ/9FLIyiyt4ANTkGkbMhg7tTb61lQM3LuZ0KDVJKv2/39P4MEwXtpjrqD9OZ/1eBF+JLHUVwxuLj5Nq+vHItHZf8N/eo3CkCTRnhIXmjtwhNvPPvp9yZI0YR76pD2rr7NC+1aHbiAK5lw58p34ytRG0v+lYZ2rdgwXLXOSgS0oGKCd88Ikk/VVhqpQ1L24wL68Y+8cVzH25AK4nIqeUSywaVlwx2WHAP9OzEAhmZiG2jHHoUy3k8zkcMSJj4PjEXXPvwt9ed302W9eD0rDV2MML1lpuBbKd9xadRxpZL7DIv6XmcGDMfweljipqSf0Yjp78sW9QoVlfigPWEm2L0l7iJb2+FL63ZZZUk2iLFhdzJGHh1WFxgfHgEDrN0/GrHaeGy6bIWvahOtQy19BjinX0A7UwsEU+cECNRmJUrtDbR60vfEGhZYZ5PH+SFxvOqTyg6xRic9rECM2zAKp2VkY7ZHUqDVeDaM1gQbXME X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(72806322054110); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231355)(944501410)(52105095)(3002001)(93006095)(93003095)(10201501046)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123562045)(20161123558120)(201708071742011)(7699051); SRVR:BLUPR0701MB1825; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1825; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1825; 4:4EbiSsoAPT0jQPr7bKJAvqxyiXkjtobLXbrj5q4Ibze1B0S8DdEB/rgOWi50utwkjQupre2A0Ln9NfDaw+T2+zL1c8fAi9yicxb16mKe8GgQ0AdCQbb+bPQQUhLwiG97EfbExseceQ6T3Bo8Hy2ZEw9F63Hiz+XukjsAue9QZbDBY2N1kKJ73/9IuV5WMBAp4N3BG+ukStSoAybOO/dkXuj/9okKORNHSOR6Q2rZN9v0AzOskwtOF+INMbrMro9dWOw1GYJpxOOQ0yyhUUMjJQvyP4yCMCgMKoXtE8SfVuoe59uXnWUanskRnX1I6ss/ X-Forefront-PRVS: 08220FA8D6 X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1825; 23:UPCSdinf5qfTs8sQBqcZVqfKoxIVxUWZCic//5JqIqz/FZ3fMEXUvk+ZeymKksloVwjbtqtw9jvMynFEGTVFfJ1rlSbNU7mcpiPDjrVsepOFOxdp75DisHXWeEzAp+rNd93/r69xTPm4m1dSGe7DOPWU0LRmTwIw4GS5PxfPxZ8Uj1JEaDCKJJoGaFXEj82nF2EY9nHCWh1GyETYm1M+dhuF/sDGWY5xVa4DhoyFRdqmDrcEbImAHPPZL9uV90mXMiPOIVHNP0tImUPSr76CIIAdKRzntFdbEaQf7RpnIRR80/eLQoJelT5q06awuu3/P5cM0lmGz1HJ+t0ePI9rSPLoPu+fHjeJ5FxEXiTQ/MZA7UcXl3l7B6Gvb9HK9ZHCjydmamQ5SZ6O0u8nJPIlbeOWpM2VQJ6eqSqlu79HJHuqGNvgplIEzvUjFwA3GrQKCj3rzjX8oBXSlXkBQKKLxonMZ8HfsqIpOQ9WpXiFqISkjBjFJw1J9lCaj6btyP5Dwcmov2iF1GBfAsHmCQqOxHbv84HlI3pgGzma+O02l8tsWyKtS5pm35MqqD3d/fXXDuJvVs/5EwtIzeIVXI9Z78RMOn/RXyGmh5xqJNc5EdkPvPTMah62wGZH9M52d/7SDPUKWqYimFa/BRM2QS6wIZZDF2DtzM5Yth70HPr8NyDo2GoMf3ix8tKLTcssGEj9ePFVij8QQK7yR9Lux/1NSwBclRLg2107Z+AWfX7Vd5dPulMXb+o0q91UxARg4kJBOVL348KQihhIdKE/Ye4kmAGKJS0KIL3hwGx3kEC7Iy91B/gb9E+cvUpJvhR24qmEiNx5vtHqURjfZABF8oNqOezFIvadDbb0EWUMGsmIcxU2hPyNMFhDrSIlLg6E3QWdqtbLN7uzvWDp5FxGDU42toa82RvC29Erd1CR3jktQfllwftC7slUBZBuMyHx/BIvvLCFqTMiHvTU4bz5WSz87J2B+ZwfVvmOUNVWm6KNacwidqo6WLHELNRfHxgbNreurNf6oj+A+Cv7+tipqLPss3wIaYNu06sZS8UlKz9F4yM= X-Microsoft-Antispam-Message-Info: ZyJ5TWWfZiSl9cbvINIq4AIJOy/ubrIXPtTR7X3aITWMH25/sBdyPy5i53ZlLA1oZEWSEk/ttYQ5vf1FwcfYmhA5pZPYy/ebPfjdDEMhzKt7gO3fxuZa8T7W1R1ttThUjchUkYiVGrWLQ6Wfla6ZUvf2frd9yaZnG9A52l3Nm+fa3/rXBNTzg984OTl1KQVn7ji9d587LmSwaoY0LPsSqmiomGScEGKAtkOQOF2cUzn/FFsiMcmCu072VkrJzsSh/+0mclEbOJbRctNd+WbBqpRGGYg8hKHhzErMIvLvKcWTGVooomE5uW30wcsxRGC/hMVro8WMxv92VFl3n/Ap0FvLlxfaNJ2YVFAHC1+fBHXficyiF8e539Q5NSv1Mf9d0VIzTPmTX6hPN6//bWdPGQ== X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1825; 6:UaREEP3bNVPV5P98pxXOPDmq/vF6DH5MLgv9/Sg/HjrHihU/l4FfaAgEbqpMMhnyxJu1KyZHZqJZWj6vwedqCpiAJWlJ8B7c/tx7Dg2845p0T05RNH9GUqCy8LeWmdm2l2b1JskdnzEPvDTAHsBiUTLcRQMWeQOQqtllfMbQq23M7ZRr8SHSLURqMMP6JBXwMBIcCLzF18uhh5rkQNqOApKRexDi92KQYvKDZip2T1HGmVCEnCb6qVwPqMw3c4OazpC9Df9fKR0pNOLaFSZDPpjHdoE+KBfV8aRR1ugwlBlLqGydVITwqcONxBOENpLla2Qu83hpyT0LhEARyuCnpYubBIA8QXX+E1SrtoIl6XKp93XYwP6/3ALirqcfF8hZ13KG34I7JhRAhkjySwD440lODx+7F5qF96FVPw5wuFKetoJNqhCfBQ20eqWdtswslUMr4vz65qCO9vnGITlErg==; 5:AXG7b6HLD1HJoZU/MbRFXbzhwHZ5DwWZr5hPFiY9EtbnhgNc81BMIzmGkKizhc1Pypb/Uyr/5nXppSP8iixO0CZMI/HXNqqVLPjcQxB5gMA+Nr+50Y2w0KqaL7dRaB5VdfotmEtx4TJEBkshYutm7WGY1o8BR9szsMri6NhvSnw=; 7:5jpiip01VzPzBYf69iRjTjuJN3MN4ewjTMLWJJd88gx/skT4KhwmrDoDjOJluNC79nWyxAhaPyokdXbZn7uK0IvQ05GZcZV7aaHD0Fnh3gutdao5qsGQ7091NfrrOs5LX6GSgI7upV3u7/mlZn6sW2aMpIpUtCmnhkdvBueudI79swj7atDA+PQ8jlnXyRbpUDmn8Z0skQoqyPer8fKXDDPtDsoX/gdPl3jJLImWJtwHg0W7DmFFmXjF2MIhlSFo SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1825; 20:lrOmc7EkQPutA6I9vfFAw7uzIDX6X9Kg42wqP5BL9SBjmjden08ECDZucUdYWEITAxVcTMjkKDWXQuRm4CCpMYMelVeEOCmRHtNzGHFbHN1YQQue1EJRyK1ZeYq1k9GLCekJgSlq73dtonjXZX3pYsacJqgwZO0eu07q/gtnIlext0R0aYYKaVrPtWKG6MYoyH07qu5iQlhP2tD0iXqEhPFkb1Z5y0yAA0LrEmGgYbC+ABtFKfCcXwL/P3YJaAKW X-OriginatorOrg: cadence.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2018 16:16:08.3216 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fe8a1262-62bc-482c-f31a-08d62f94da4f X-MS-Exchange-CrossTenant-Id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=d36035c5-6ce6-4662-a3dc-e762e61ae4c9; Ip=[158.140.1.28]; Helo=[sjmaillnx1.cadence.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1825 X-Proofpoint-SPF-Result: pass X-Proofpoint-SPF-Record: v=spf1 a:mx-sanjose2.Cadence.COM a:mx-sanjose4.Cadence.COM a:mx-sanjose5.Cadence.COM include:mktomail.com include:spf-0014ca01.pphosted.com include:spf.protection.outlook.com include:auth.msgapp.com include:spf.mandrillapp.com ~all X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-10-11_07:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=798 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810110156 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org According to the PCIe specification, although the MSI data is only 16bits, the upper 16bits should be written as 0. Use writel instead of writew when writing the MSI data to the host. Fixes: 37dddf14f1ae ("PCI: cadence: Add EndPoint Controller driver for Cadence PCIe controller") Signed-off-by: Alan Douglas --- drivers/pci/controller/pcie-cadence-ep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-cadence-ep.c b/drivers/pci/controller/pcie-cadence-ep.c index 6692654..c3a0889 100644 --- a/drivers/pci/controller/pcie-cadence-ep.c +++ b/drivers/pci/controller/pcie-cadence-ep.c @@ -355,7 +355,7 @@ static int cdns_pcie_ep_send_msi_irq(struct cdns_pcie_ep *ep, u8 fn, ep->irq_pci_addr = (pci_addr & ~pci_addr_mask); ep->irq_pci_fn = fn; } - writew(data, ep->irq_cpu_addr + (pci_addr & pci_addr_mask)); + writel(data, ep->irq_cpu_addr + (pci_addr & pci_addr_mask)); return 0; } From patchwork Thu Oct 11 16:16:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Douglas X-Patchwork-Id: 982598 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=cadence.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=cadence.com header.i=@cadence.com header.b="UC5WpdtH"; dkim=pass (1024-bit key; unprotected) header.d=cadence.com header.i=@cadence.com header.b="nRE5WZAx"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42WGLy05FTz9s7T for ; Fri, 12 Oct 2018 03:16:58 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728601AbeJKXov (ORCPT ); Thu, 11 Oct 2018 19:44:51 -0400 Received: from mx0a-0014ca01.pphosted.com ([208.84.65.235]:35114 "EHLO mx0a-0014ca01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726700AbeJKXou (ORCPT ); Thu, 11 Oct 2018 19:44:50 -0400 Received: from pps.filterd (m0042385.ppops.net [127.0.0.1]) by mx0a-0014ca01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w9BGDg86005455; Thu, 11 Oct 2018 09:16:45 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cadence.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=proofpoint; bh=Ve3R3U1YAq4KUrFu/cOQlMnj9haRusdzqs2UVSldV3A=; b=UC5WpdtHrN+I4nGmche8Qlnr1kBn7/Hn0VVQT0jbdIS1BoRRfQgZ0UDss/DL/eihKprO 0r4YEJbj/89tveOqrIJm+WW1M4ItI4dkS78tev57FDRi9rPgSOZ6wPFx5dleJyL9eXnj SPBhOJDdmw0QILi/GvY1OZ7l2VlsPPtjpEtxpSOrEVfrGg/8mjCf1GJ/u8S2mYbSRxOG 7piJRnUNxvx2mgGaJDsGO7IDAsaFenukFxuW3ZGP+6+F3vi2VV9MvmPXgtkQmhlSfoZg 6fMtNRQXF2voxFISX/6rtglLSIf6VliXC+NidNyOjitS0La8B9iCmbJ7pn3Yzgacm1vs qQ== Authentication-Results: cadence.com; spf=pass smtp.mailfrom=adouglas@cadence.com Received: from nam03-dm3-obe.outbound.protection.outlook.com (mail-dm3nam03lp0022.outbound.protection.outlook.com [207.46.163.22]) by mx0a-0014ca01.pphosted.com with ESMTP id 2mxuwx7qpu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 11 Oct 2018 09:16:44 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cadence.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ve3R3U1YAq4KUrFu/cOQlMnj9haRusdzqs2UVSldV3A=; b=nRE5WZAxvTMNKo0gxaJ6RyLCXw4kH6TE4RCtMEtkrEDoz+h+E+7Q7hjSwWwpG4bqzPU/9MG1LVhJAmYfZbSaCrkUBnwAU4I+7Nw5Uqb5+TMKshtNJrFyo7EuuJZbmj/zJHahjG5KyhYB38kDwTHDxcaRZMdhk0UzJlL1hnUzWTU= Received: from SN4PR0701CA0010.namprd07.prod.outlook.com (2603:10b6:803:28::20) by BY2PR07MB693.namprd07.prod.outlook.com (2a01:111:e400:2c52::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.28; Thu, 11 Oct 2018 16:16:41 +0000 Received: from CO1NAM05FT018.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e50::204) by SN4PR0701CA0010.outlook.office365.com (2603:10b6:803:28::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1228.23 via Frontend Transport; Thu, 11 Oct 2018 16:16:40 +0000 Received-SPF: SoftFail (protection.outlook.com: domain of transitioning cadence.com discourages use of 158.140.1.28 as permitted sender) Received: from sjmaillnx1.cadence.com (158.140.1.28) by CO1NAM05FT018.mail.protection.outlook.com (10.152.96.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1250.2 via Frontend Transport; Thu, 11 Oct 2018 16:16:40 +0000 Received: from maileu3.global.cadence.com (maileu3.cadence.com [10.160.88.99]) by sjmaillnx1.cadence.com (8.14.4/8.14.4) with ESMTP id w9BGGbTS031357 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 11 Oct 2018 09:16:39 -0700 X-CrossPremisesHeadersFilteredBySendConnector: maileu3.global.cadence.com Received: from maileu3.global.cadence.com (10.160.88.99) by maileu3.global.cadence.com (10.160.88.99) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 11 Oct 2018 18:16:43 +0200 Received: from lvloginb.cadence.com (10.165.177.11) by maileu3.global.cadence.com (10.160.88.99) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Thu, 11 Oct 2018 18:16:43 +0200 Received: from lvloginb.cadence.com (localhost [127.0.0.1]) by lvloginb.cadence.com (8.14.4/8.14.4) with ESMTP id w9BGGbmF001171; Thu, 11 Oct 2018 17:16:37 +0100 Received: (from adouglas@localhost) by lvloginb.cadence.com (8.14.4/8.14.4/Submit) id w9BGGaKN001166; Thu, 11 Oct 2018 17:16:36 +0100 From: Alan Douglas To: CC: , , , , , Alan Douglas Subject: [PATCH v4 3/4] PCI: cadence: Check whether MSI is masked before sending it Date: Thu, 11 Oct 2018 17:16:11 +0100 Message-ID: <1539274571-545-1-git-send-email-adouglas@cadence.com> X-Mailer: git-send-email 1.9.0 MIME-Version: 1.0 X-OrganizationHeadersPreserved: maileu3.global.cadence.com X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:158.140.1.28; IPV:CAL; SCL:-1; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(136003)(376002)(396003)(39860400002)(346002)(2980300002)(189003)(199004)(36092001)(4326008)(2906002)(26826003)(2351001)(42186006)(87636003)(16586007)(305945005)(478600001)(2616005)(86362001)(476003)(126002)(486006)(336012)(246002)(106466001)(316002)(107886003)(426003)(105596002)(54906003)(186003)(47776003)(8936002)(5660300001)(51416003)(26005)(50466002)(48376002)(7636002)(50226002)(6916009)(6666004)(8676002)(36756003)(356004); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR07MB693; H:sjmaillnx1.cadence.com; FPR:; SPF:SoftFail; LANG:en; PTR:corp.cadence.com; MX:1; A:1; X-Microsoft-Exchange-Diagnostics: 1; CO1NAM05FT018; 1:6Zi/Y78DyPRU0kcfUujyCfGpkkuP676foaB7tfE6yfBS+ADA/mtGTodwC2eqsE3wp1urc2dGULKMW2kCER5w6lvKK3mtSwGfq/L8Uu86Fh7Udat+RalngnSoXjlDEg+x X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 468ca420-7f8a-471d-a974-08d62f94ed65 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060); SRVR:BY2PR07MB693; X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB693; 3:ewWGNajMMGZZFJJuNiRIbhqx2Ha7GtM826Yt0ec2ZM/Tlxx4p9lmjRd7LpZRRUVB7karFjtOGVT8Gd6A9XpcDujf7ANR5hz0chT3tjyEoSUnPX3Y1LxUte6k5E7UfAz4afGltp7ZE5H6mS4Tk2nhBdP2wDA0vM6+zAxHcj7897gOS0gN4v9dISdqQbqpHdTGV/TXIQBBAYXI+HFy2I3SGdTUsq3oUbmPK6uK7zM/p8ouimmuIh8/r5WBsU/C/U2aOe+kTZvl8iS01nJDxaLM+rjhJoKiKZT5mjuAnIIkWMQExR+aFAl28mvYnIN3MREsScfU6wTXr8fiNKjBo4fGUuL60OWAbnhXBs4Ty/Pdvr8=; 25:vxLfPhZwFHSrsvRZuhIAelHqAf+Ve/ALlvB/LkLOoAUOoRzgEN0EVbF/LnGJL0s0iY9TzTf1A6jal3GwRZW/5+12mPRihaRmvS7stktRTHFRuY8PiIjHFwrhNsQ/8Zo5KyB30CN88hJaarWolp9BxGk/2sKC/PW+p7ah926lft2HwU5JLeByUTVjKSZOUl/cnWTX9aI8z+BZk+5e18QUMMwvcOm+/z9k/9S2miUK0ZBxKgD0pi42/bHzXTf7cZs5aKX/QatmWvIj8ri/DHhZyqYOm+QG2xhRmml5cP66VYkgZYgeb39CxlsgZKmvZOQdQs0r3CsfdG+kJXDSLQ9QEA== X-MS-TrafficTypeDiagnostic: BY2PR07MB693: X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB693; 31:MIYWFvQcEnFqY4a+yZRRdo9quU4DSdAe2VbtW3f4G2gVqVoqUP19VCK6sBt0yb0faEUSyMwFDurP4c7efYgdemgeD83qvxI82AnugyUCFvIQDz3KlRn3RCCBFY59miREsmSIOz0NT8xb3TFC5rtZ7kOFXrAdtZDaPwol5pr4WFVhVJ0zboyfsQV1as9vSoRKpNsgKUKZ5iTCBkcw4ycVtcsUcGMqF9sfdtPmPll3jAM=; 20:cJbm0ebAk0kkgIGESqN+dUg40jdMyDaUC+JhwBn1+ANdT4L9rQ6yw0inKhUJyieBXC8ur5Ex81OZ61HQYXkd6N2IgvhelPV1zSEpqx6eQRdWzdvgJy5pf1fB+tzBYR0sJbtGBEHI4LX5blnkI3/15oNXo1Vlj6a4x3sPglI1ma4hOdSDa2/tCTJq4cwdrs9t1RykYnrEDnGg8IHpYAFlr+pj173bqnCmf7m4NMBSGTqhP8L81yAe8gze7zg/pthRIcg5sUqOwNaVirBh/A87n3OSEQCVl2AGTXlcBQNwbf8TPhifZHK/ECs/oY5S/zjQNX/w0AFvHypFhKWEyHHgAKycBL4YpOId7HiJ/MS51Wbs8lx2RTfWTh/y7qluyIlMjGuxQaP2Pl0iDez25yVOAzqH33O22ARkFDmv+sk9ce2lY9vGUChV0lF3HCgWpVQvs7FgaGqFtj43fG9JGKSUyA1cz0ulzkZgOdV00ZnQmP2wDUfWF2kS0mT0p0brkJ+g X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(72806322054110); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93003095)(10201501046)(3002001)(3231355)(944501410)(52105095)(149066)(150057)(6041310)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(201708071742011)(7699051); SRVR:BY2PR07MB693; BCL:0; PCL:0; RULEID:; SRVR:BY2PR07MB693; X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB693; 4:rsyBXa6kXaEXFTK2Qhr7S/R2uPr5SZkpSs5vZvodApFcI5jBIhmLn4Zjfc8b9DPiQm/Hkil74QuDHPqn4JIrDv2IkYz5izOzn6/AhVnR522vNUcvHYUPKXNIurE6+vGk4C9WyTHor+a3lk56+Qhrz8owTgtlRHPa7OFLpGrMQ9FFSbXQt5hqDPH0AbdKT8+eaomOfdLMpJ5Mm6WYXSCqaY5W9YXvluTFsp7YYOA5NuL8xpqndeBTgn8WCqvPq5E4JL3y4vP2mDhYc+eK4gc5TFSBmDVf8QX7iwym1v9obmngQB20oy/5/58x1pj1wtNO X-Forefront-PRVS: 08220FA8D6 X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB693; 23:YP952DoTGkJ7YgqsbMKJtjovx+woQjUhLs5H/UBf55xwVc0nVYFd4ltaUAqhDwodjnwis8pJN4gN66ImmmRSAcErxpiWXQ17lLzaA6WISmIgLZ1MwMsgP/P3bRqkyTNaYbxh0hDIIvKcqxClXe9+Dx2wR/DiX+5mVN+CXltQjHxdki4iBEjCJJEEVQW/d5PbAXncxf6VbC+kXB8GkTCu49sU3PsZG6JH0FvAYPVD/mm2v8bwdinmcMUVGp+y5dZOO4BwBE+6BpPVzNDZquwWPPdVqV3hGprshvRFMfXUoqJsQc0scUDfjgKfAlRzRbxa+AB2BPYdRqbYoANoeBeo3e65+NxIUi5H05XzYXKXAU5JIeiHqmL4DRI0npFSFdkpKOMlVciCK0G9XiF8gg110Rwb8UmQzdjgPSbZF6IyZnu2WFxWRsO4oYxdwMdrJeu7lEejTNlRoEK+pkZKP53BxRuAW2hXeuIUvfrdLulsLMTUTBkXabMLP2iyiB/sUrMacQ0OLPOtDvieCKrpmRJo/AUMq2/3i6sgiPKo3gKI87zblsCpnckhtsBObOjI8PoQWjh7mCoac6ydOZE8t3Xl0qMTXOn5iU6tfbaq4slnqHPH2/uTE1725MDsSV0i4orzRZxolzKXsAkLHy7tNXoMR8FLE4jw1kDSppNROMFdB72b0mR+JCv/6BxrPkjKkk64UonsfhSJ8WhBtlHpnp16sbkFIrXlHG6MlVVyViDiuqrtcbGi0Pl7KwyW/+MkjHl7JzAffGf+u+gAmwI44xuxR7bwHmuB32xdTIqH3/78uk0/j/AAanWlLfSOvQMqoYgEvw5mzGLTp7tq9eGB/9/M7S+JLmiq+PbWQ9j5Zi+2H6UOGbrXlw6zmRgxLNvSSnsuXQnWzLcD/nJnnFUK4kBoYX7eFXLrq1TW4KinRonRV19MmFVFYGg7/6y/+5Z+JfzmtcjWJxzK48n+FGgFnEYWcjXUfLFpWnYnIuzMKiBTxaWVJWlmuU2wXzNTFCGAmTJM3hDVz0q5IJ8GfSKXggFsRA== X-Microsoft-Antispam-Message-Info: oq33+SnDMZr1/M3Ld12YlSLz/VNzQ2At8vYJzC8k/8iqVCXOxCaDChaHd6erpjdQmNUeR03MZ9VG8GRo7AOXcl1vfj47cnTJ3PXp/0y0uP4AmzJ1RDd8Ty5fRi7/X7zkDSyP7ChekA3B6yTY9VR0EFy5pPQaNVE0flCHRJOaS1ADLHQmrFnon+/7Dy7lhwTlOc1Q6pcsjLcWPvdYYlvnbcDHpjhKZhsqt1kNA+BX//LcWPiBhOFo5YdkHnBeqeEqHpkijeZ4/fRrFf6xEgpT0YhrE4mm8yIshI9RV4tvWBTp/z/Ts4si51vyTz7OLFHQ+za6FrOBABGW69bSY/hIVMSw0zXANfw+igO6QYhvsKAttNlYVYHhjHXhMvRfsfnVzl0/lxEo575Q1awuzvvQsg== X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB693; 6:A/eXtzQpRIv60o4GlvWHdp50sYytC+ndyyXm8DXBgCKT8FGrSqKh3fwMY3MJ6ImD2hwaii4QArB3Cw3NCTpSPMTqJMXDCSOCIfE3l+7YLdunwWm9Om+MhB3OWixkX6Q24+pl1ua3Yym/wcjPStkeqqMzQox6v553MNzxcgwVErRAC6sdw0J3flIN76UJHJrCzYj2PpESL9qRGImhixiFKxM/6XmEr+9fy0LHuBsvc2b4kEyQQ5r/UPtiHPri4+Zcuym7RoZwqUU7R6e74xTAS8QRdQ6CpfVM15I+mI+3acnQZ3flzzIz7T/fta3EJAi3OB5s+fQeC+V4+kvGfRP9tiTaViMLzDrplInarlUQEbBRPLYWhwdnZ7+EAIYGG2VjOhK5tM0peYLeeZ9zeBMCyTL+ZrRlvH6sGQzi7tZaqI5Ube37yZKi6jCE0sF5Tca9fRNDtLAxqs5ZYx+AIeVH4Q==; 5:eTTbmTjCi95butJJW77lPZ7AH+WjMM/SG8FLsnc00od20aqgYPkfhWD4N904K1+fDD4OQrq5VSha/0OPVJYkMFsSwJB7fT5RCC75+YSCPLIPdB4uQHGkhBdbqNvjgKu85RG/jISmVF7iZhD6PhZi1oG8di1WPcxQ+hP6ITVjOuY=; 7:fgIWPwtnoAptwP5LTMu31nlCu4OAjJWvKjpJqsFpFeH3+68peYU2BblXboJwqMMwr3KbrADDyOZALXwtmJS+J2DMjnwAutnRWH5UO0t6gpEGNzwueZQrY47D6kRhKsz9qlpItnCv62d8w5n6vr/ElOZxmcgLNZ9m6NYRh4hZdLMyRIlW6kbHxNCszKLTmiEduPK96LUcHQeaS+mwhewhQytD2yg10wc9z3XIlOkdQ2nDCohcckI5pTlAkz4zT9Po SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB693; 20:a74QWuQE6YbCfbK5QexZzAIv3qS9IJR8AT36cztSUi2ViROdIcZqHfcrx/I8veViK9bLJ3N8I+lYNqE28/o1XR46OkA8E/hf0ud9guq1idwdWiK1mRmaOVK2vfZ3HpEwxFc/8dNgMQLC87O5qDCO1+MnoKI8FVtQL2yWj7rgMUAEsYX4/91zN+Koo1HDdRjAdMrehB9gYpsMbwhFZAklHn2dEBV3AefH4s9sLvUibSYLr9zCj+gJcNyJ4ILtV3XR X-OriginatorOrg: cadence.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2018 16:16:40.1688 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 468ca420-7f8a-471d-a974-08d62f94ed65 X-MS-Exchange-CrossTenant-Id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=d36035c5-6ce6-4662-a3dc-e762e61ae4c9; Ip=[158.140.1.28]; Helo=[sjmaillnx1.cadence.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR07MB693 X-Proofpoint-SPF-Result: pass X-Proofpoint-SPF-Record: v=spf1 a:mx-sanjose2.Cadence.COM a:mx-sanjose4.Cadence.COM a:mx-sanjose5.Cadence.COM include:mktomail.com include:spf-0014ca01.pphosted.com include:spf.protection.outlook.com include:auth.msgapp.com include:spf.mandrillapp.com ~all X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-10-11_07:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=379 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810110156 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org The EP driver did not check the mask bit for each MSI before sending it in raise_irq. This is now checked, and -EINVAL is returned if masked. Fixes: 37dddf14f1ae ("PCI: cadence: Add EndPoint Controller driver for Cadence PCIe controller") Signed-off-by: Alan Douglas --- drivers/pci/controller/pcie-cadence-ep.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/pci/controller/pcie-cadence-ep.c b/drivers/pci/controller/pcie-cadence-ep.c index c3a0889..b762214 100644 --- a/drivers/pci/controller/pcie-cadence-ep.c +++ b/drivers/pci/controller/pcie-cadence-ep.c @@ -332,6 +332,11 @@ static int cdns_pcie_ep_send_msi_irq(struct cdns_pcie_ep *ep, u8 fn, if (!interrupt_num || interrupt_num > msi_count) return -EINVAL; + /* Check whether MSI is masked */ + data = cdns_pcie_ep_fn_readw(pcie, fn, cap + PCI_MSI_MASK_64); + if (data & (1 << (interrupt_num - 1))) + return -EINVAL; + /* Compute the data value to be written. */ data_mask = msi_count - 1; data = cdns_pcie_ep_fn_readw(pcie, fn, cap + PCI_MSI_DATA_64); From patchwork Thu Oct 11 16:16:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Douglas X-Patchwork-Id: 982599 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=cadence.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=cadence.com header.i=@cadence.com header.b="P5rGolHv"; dkim=pass (1024-bit key; unprotected) header.d=cadence.com header.i=@cadence.com header.b="SVPsOqed"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42WGMK68dDz9s7T for ; Fri, 12 Oct 2018 03:17:17 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728718AbeJKXpK (ORCPT ); Thu, 11 Oct 2018 19:45:10 -0400 Received: from mx0b-0014ca01.pphosted.com ([208.86.201.193]:41590 "EHLO mx0a-0014ca01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726700AbeJKXpK (ORCPT ); Thu, 11 Oct 2018 19:45:10 -0400 Received: from pps.filterd (m0042333.ppops.net [127.0.0.1]) by mx0b-0014ca01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w9BGDV6w012875; Thu, 11 Oct 2018 09:17:06 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cadence.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=proofpoint; bh=ULjH+o7v2qLfCEDLFrt2x29GI6ZHtRFyETH3SqqNqsg=; b=P5rGolHvE7e+Hj62Zd100Wl1j5vu5xwbpMgFrviZAkOz+Rp4UmmhF7NE+wKa+t1dhNGh 5hrpL3VpsN3gFwfpfkSMJGsX+Ufsj42NKslqSXFgsM+0Fqb3xVFY8RtuhnRsPSCAa5h5 diBuvpyWkfNHNWhN76mcD6puSvrI4Zfr+4yvB3QwlRtI+g/4VJCNjXD1l6eZjixwjQbg t7G85UWI8s+waiJ3wMfBKG7gEoiSlp2dFBJNaFGb4DkOSYQh9ktr5wKF+K3KxGCMgzpm yHdqc5HgrwLauwsHXOQE1sgvq8vEg21Nm95Oa56iaFm9erU9NOQV8w+e07lRCt3+UFCm 7A== Authentication-Results: cadence.com; spf=pass smtp.mailfrom=adouglas@cadence.com Received: from nam01-bn3-obe.outbound.protection.outlook.com (mail-bn3nam01lp0184.outbound.protection.outlook.com [216.32.180.184]) by mx0b-0014ca01.pphosted.com with ESMTP id 2n156fhmp5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 11 Oct 2018 09:17:05 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cadence.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ULjH+o7v2qLfCEDLFrt2x29GI6ZHtRFyETH3SqqNqsg=; b=SVPsOqed0nCKfV7aUQG+WzeMX+lRI9ZuLbI6iZ6cIc15ZdW/dxpW8Q0ehlCnn8J7M5ps9wsI6wMM6EnoWLfuKHy4OMe6Oibf0dmsyL+3XiByGwV9u9ArcWiLRAm9dka5B68TQvIqhgDeBKT5Dw6valwq7LiSY69J4bUrwLRMn68= Received: from BYAPR07CA0035.namprd07.prod.outlook.com (2603:10b6:a02:bc::48) by BLUPR07MB692.namprd07.prod.outlook.com (2a01:111:e400:8a0::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.28; Thu, 11 Oct 2018 16:17:03 +0000 Received: from CO1NAM05FT029.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e50::203) by BYAPR07CA0035.outlook.office365.com (2603:10b6:a02:bc::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1080.15 via Frontend Transport; Thu, 11 Oct 2018 16:17:02 +0000 Received-SPF: SoftFail (protection.outlook.com: domain of transitioning cadence.com discourages use of 158.140.1.28 as permitted sender) Received: from sjmaillnx2.cadence.com (158.140.1.28) by CO1NAM05FT029.mail.protection.outlook.com (10.152.96.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1250.2 via Frontend Transport; Thu, 11 Oct 2018 16:17:02 +0000 Received: from maileu3.global.cadence.com (maileu3.cadence.com [10.160.88.99]) by sjmaillnx2.cadence.com (8.14.4/8.14.4) with ESMTP id w9BGGxiF029100 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 11 Oct 2018 09:17:01 -0700 X-CrossPremisesHeadersFilteredBySendConnector: maileu3.global.cadence.com Received: from maileu3.global.cadence.com (10.160.88.99) by maileu3.global.cadence.com (10.160.88.99) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 11 Oct 2018 18:17:05 +0200 Received: from lvloginb.cadence.com (10.165.177.11) by maileu3.global.cadence.com (10.160.88.99) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Thu, 11 Oct 2018 18:17:05 +0200 Received: from lvloginb.cadence.com (localhost [127.0.0.1]) by lvloginb.cadence.com (8.14.4/8.14.4) with ESMTP id w9BGGxt4001745; Thu, 11 Oct 2018 17:16:59 +0100 Received: (from adouglas@localhost) by lvloginb.cadence.com (8.14.4/8.14.4/Submit) id w9BGGwYa001741; Thu, 11 Oct 2018 17:16:58 +0100 From: Alan Douglas To: CC: , , , , , Alan Douglas Subject: [PATCH v4 4/4] PCI: cadence: Check link is up before sending IRQ from EP Date: Thu, 11 Oct 2018 17:16:57 +0100 Message-ID: <1539274617-1661-1-git-send-email-adouglas@cadence.com> X-Mailer: git-send-email 1.9.0 MIME-Version: 1.0 X-OrganizationHeadersPreserved: maileu3.global.cadence.com X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:158.140.1.28; IPV:CAL; SCL:-1; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(396003)(136003)(376002)(39860400002)(346002)(2980300002)(36092001)(199004)(189003)(4326008)(478600001)(87636003)(86362001)(54906003)(476003)(50466002)(126002)(2906002)(336012)(36756003)(26005)(356004)(186003)(47776003)(48376002)(26826003)(426003)(2616005)(486006)(51416003)(105596002)(305945005)(7636002)(16586007)(316002)(106466001)(2351001)(246002)(107886003)(42186006)(6916009)(5660300001)(8676002)(8936002)(50226002); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR07MB692; H:sjmaillnx2.cadence.com; FPR:; SPF:SoftFail; LANG:en; PTR:corp.cadence.com; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; CO1NAM05FT029; 1:W871CluzlNhalKzqz8GfcaGiJjsSSIf+feKzGsQP+prTxUMQkM2NMi+eL3lUrLELg12noYt4PwPLgjS9+tMTHr6216veisDwKyIbF0MUTQ7/nNR23kdRxzOM5tFgRiFD X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8ee8aee3-02e0-4f2a-9375-08d62f94fa97 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060); SRVR:BLUPR07MB692; X-Microsoft-Exchange-Diagnostics: 1; BLUPR07MB692; 3:aOE+u3EX0Tk7IRAqnko9C0cyh2cdiWNnijmSbOxKzHLtwc27Bqo/vXCqE6bCTo73HH/1LfVdu8Gz6PWtiBsYF4KIYQAWjUxnvNoeLml68iECRsG+Urmq8UcEBTkpfOQWXZ9VHlf6Rt5gpHB7rV3W0D5TqUw61/Bqf3ugRmq6fytJgAOdd2mCl+VKP6OEwgZxSiyZOzn1vhyJBZqbyOadAWaPS+W07+jmPTV/MGqQKSH/UccJTqBIayZmh1MUM4Oab3hnmU8H4IPURon4VvOiTrkwXL46uuHPu1j4EhUFYyB5mm8zK33+ppA6uyJJiI7bvM6/BdreZRWcczoxZ6f0i8jHGQrfWL/R5upAHezE/Uw=; 25:rNnCA5EsuyxcN9+nVFPpJG8z3MkXqxbdufZoP90H7aLEkGbN8Yrs5fbkih9jR04cSvldhsnDe2tUkjsEHcw/5UFbUE66zREgK//jeu3yFGgbUZF8smXf+ghHi6N8iJNulg3+cKdCtZmkioNiYyDQe27KYuV6VbK3Pfgsl9NGZjn9q3Pylwqgqjh7pSZ4otujzaVxjyLeKqzHKiTzjYzU5M7Ih6MzMawEdHgqssfZ9kJNO+TYz6wim1a4wabwKnS2Rsh11zO2vKUS6tUQezZ7jyuZCGtbtd0sWPzo/VB7xQ9woc7mAl2T9WSgafmOW0SgD70t8nMragLwNE9lUixEZQ== X-MS-TrafficTypeDiagnostic: BLUPR07MB692: X-Microsoft-Exchange-Diagnostics: 1; BLUPR07MB692; 31:Wgant1PijK/FE/OFlKc/UqG3FipKUS9eNxR/VN5P8pJl52w8LIXawM9lHUPKI1N4+8WZZRGWl6IV/c8pv4ImKKgjVjnw+E2wEBNl67CSLVopQ5vGgyYez+fVAx+oD6k2RVf5jSRUZM4SQNVhXP++GsOX6c2v8pT/k5PzNc4eyTUTV5XyhhtQX2KXkwScXBvg1bEs2uVbY9jxelCl3qxqbQlAGvg6VKNPak7yAt8cDQ4=; 20:Pl9ezcXn5DBZJfL9EYGi6xLKzqbZTNr9MZVdxMDZDyDesHQ8Yhc52S94YcqAolH4FmTqnbUs5imRpbS1jMU71d5n3dX9PQ8tgk3XHXnhogVhvR5jwIUAJguW/+N9yCh3plAOZEoh8nGO5vzFPlUsfQvXfOWGXRnPQjAtH1HgJZszQjZ4+ej2SZuY98vC+zq73UpdKSOfjYQM6rA360GDm/c70SeTJPBKV+jbvjLRypNtEaXBhr2KfLGpJTGjWbyjpgU8Ns0y759OWCS+GAnWyBeeHRZxPmTZsKxfOTFUsKEVwwgwkIoUzI5koF6PrW869hQAoHfoU++Fm3LdmaMWb/5pbQWrqmc4l8btOtaEBWGxdNK4qh2smO0vMzKyB+8dGxiREzBVmdpzHsWD4fmf4lRuIfnHErxBAPmQ9uDHtcRdZq9YhPdjxBPIhXJcGDmi5EEVBeWJrWqfSNxbwBVYmrDVgPMZoaiD2UFYiW2OfIjZeOXvZQPOSl8ZYiEXsh3e X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(72806322054110); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93003095)(10201501046)(3002001)(3231355)(944501410)(52105095)(149066)(150057)(6041310)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051); SRVR:BLUPR07MB692; BCL:0; PCL:0; RULEID:; SRVR:BLUPR07MB692; X-Microsoft-Exchange-Diagnostics: 1; BLUPR07MB692; 4:t/woUMWT04NwMDuxk4zBvDOFkUhIOEQ4/kFIydtWYeCtDLoyLtGiX+oRc52z22Zj+LRZWPSh5lEXj54cJXc38ymuxbxq7ajQVNFpv3r1tR0wTqsjns3gKN357wfZFid69Ndk+Uraz0JNyYT6w9GoXuHL81ym4pTqZQb+NWOR2ts+NxwnjnZHZ+9dC6Tjf5bu19hPaDWPv8Ox6txuFIfr8w4TKttil9BcEoCqbdauYTQ+G8DnPqwu2nO3XWV5q89k68Z8pmkMZ4bQXs4dkUG0lyTi5V07qPFzwZOcSst+TwA7y6kfV0z/UJef57uXQ2cD X-Forefront-PRVS: 08220FA8D6 X-Microsoft-Exchange-Diagnostics: 1; BLUPR07MB692; 23:k5y78K5WvmRzUK5M1VGHxb/UuDdcPHB2u7xKWhxYnNlZnmElEAYTAeUnqS20pealBPyzfLX9G1wpaAfpyznKMsuRLu9Dqey+ti/58G5ztxlU/JmchCmReCrqey3dXmpasB65wAM8gT0Acq6MRgwHB2CVuYGyz9uLZ1+kZdHrusMcNTP/jDF+xjBW6o1Jl5F1V+Q0LquqLrVusgVgbJugK86TTuzY/S3psVWHzkx1hPe2Rl08sidCunMHEmle2Va1i11S/db4Cb+lg+z7Klnu4IovF8Kvl6B0LHkJslrz+B/F8ffAG+yzlZ70IRL9rBX0bl62YAOJoHeDNdLBNi2HcbWhCIvtOIapJZwwUK1+VGhXB6xsbsdfFhgDNc6+xkEugVSfdziyP1ubKgKlfLkHW+osAj3/1hy+1qW5daFSN9xDNiBdTX6GxUADySx7T00dyMHBQtLfOZPsJsfWFmF/fu0xjq/SUcJW7YVeVtUk1AnH88gjULab6B2iSFvNAEy+pofLnc1kbSbPs9DBaXwC1JHLfCjFmw5mrUOQlI62ce92qnzmYXbOjfKFQuBkgWBJYdVIi+zCX+4ODtRt43nLQnz5XwkSoH/lGWbbruirdbjq4wgvcziPa3RMku/vQgZkWyP5nzCBstG7IDi6kfSNopUXKXcnRZlvHFA3twNnlyxRAPc0k+9uAj1HpIKUExgD8LdKZyb9xP30p276orEHppFh1DJ48ugESGYGaVpqo3/9PaYf/HrUnmBplHJVpZajC5b+NB/pmckyJ71ioRrlWQGs82vcSzoxSNf9eHhWuHAqz/bfUVB7rW2JbCK6SydRyQ89LsYDv/CH0u36T5kbADCvy0bvu3HLf6SkzxqizW++AVUfdHBjfXxLiO1OmO+FnU3Ink2ZsrpxGJjqPdsU1GXY5IQwU4oIW4ZnmOoxywuxjV/etY7rci22slfN3sZGaK8h5hopj0tkZauEdVeEkD4i+hs6D8i7S16tAUkQB0ynZ2ePaFHhiNrfrvXg3hVr X-Microsoft-Antispam-Message-Info: 3BkBA1aPnnyV8ElnYiqUxKZ2hL4Zr0JAmBY5OrHf+ql4SGI63uREDkPt1w1Ezvz3SP7hWeLQX4in6sORjH/0B6EmwRxx6LMehrU191h7/72PMgk8py6reF9GxbFzpXoAyQGXHqm0vaSzqfWtCHM+P4BSaMMQlcFaYPh1HZ1iOkPm9p0+P1CZrVpMcPhq5KlFm9VXc66Zwqba9cwZfdkVT40NGhfiloPwA/1E8iYcB5YBXUedUCfY64YqNsXOo99XQWz4aIRa32L+Vs1gQnJF5brxojEZGF1aT/YRwtI6a8ailbCpwU7IV+IRvqVOJVjEcOKNGqcN6JgIB19sAi8wJ9uwkNI8F89WsB657lCkdQuItOFvD2oIjaty4KNecgw1n7GoDtU28Pw1QDm8P7duJg== X-Microsoft-Exchange-Diagnostics: 1; BLUPR07MB692; 6:wrZCS8+xdRXubYTZl8mBzUFOugsnh2xbT+e5sbDdIJUA+hTU9aEgIIVbGIPYqCPpg4wsbmoUYA0j00KjXDuueDpNE6f17L7lzxOBZ9N5mT2ZNG0zTLanbvSzANxbicmUm+QeU/cgYF6yiPz32HDncPHe5PmY68LTugivLWx7s5SgLLiwrpwLix1L+d62rp4ELkx8NpFILN25hDgNp7R41JjjU0BFaW5mW0hZKUeLyA9IhcJFch34MIDzynlLItb57esHuD4WzXmN14khAeu6OlAop/AWR21I4z6gwjKAjUlza3NuqBmn39uK99NvNEKSwsSI8S1stkPapqQQZpJa8SFMHucaN9XmIjEhx9zcHoJoS+MSlK6cDmEZxnWFBOrmswyBf5yAItMYaYwnVlqB2rAssPMwIQiJuNkGmzzBLaro9BUEtrmUvU3ibITuZ+JGZYg5M8TylE1vGALuy9ctAQ==; 5:5l9J+GTHeWKZB0pMnQ6JTcj5aTJ/GKmu4e5gC0MeWSD8AvtD6bzTqMMoFnfLFBZKVjV6IonYZQUmeQSO1ejpHUaJwHErgQaY3PGIFBCzOgjW0SLm86qSG4FlQrGjQmviyjWyl9nbOAeVhWlS1aXYyqCm1kHkAxHrmMgdAi4RK2Y=; 7:Dns2acQqsMSOzuzpEzdR8ijfmmKlCVglOPHmun6OJfNVaRPbUuZumkPks9ZtSHL3qN1CBi7gSBbNyckaYgU/D8ZprjUkYW1Pk7orvD/YJxceCe2aKllX0563c5tVMr4IQegV2t8Qv+q9119RNDEqoC/sHSgcgZJVjUd/+ilpw0iopsJRqchzVVj+s7A2wqEWHvh4gQ3Giul5eu508cVakpZrPsEER59/QBX4u6LWQLAa/ZFU3JzYdJQ2xnw/sr6M SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR07MB692; 20:cAW2ZRFR4mtx6Ben8axLpJkzWIQtcjDmo3cLkGy3SoKbDOJ5kvkGRAwMWbB2PCxg+oQhK7rpgjdWRHoAhqVcZShN+13Pd9hMNEkgtt08dqADAN8633lDbZmchApzokqkW+4KGnCDI3QkGHs3EKSY0/GykUWYkOvSPgI6H9PUc4QITMZQsuzZ4wZBE6h82JiXUD4S3/suCZI8VZVwrVXsuXRH7umFxOFCxUdf2Mn3A70G1bWoBDw6uzIODVRdDSwb X-OriginatorOrg: cadence.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2018 16:17:02.2906 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8ee8aee3-02e0-4f2a-9375-08d62f94fa97 X-MS-Exchange-CrossTenant-Id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=d36035c5-6ce6-4662-a3dc-e762e61ae4c9; Ip=[158.140.1.28]; Helo=[sjmaillnx2.cadence.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR07MB692 X-Proofpoint-SPF-Result: pass X-Proofpoint-SPF-Record: v=spf1 a:mx-sanjose2.Cadence.COM a:mx-sanjose4.Cadence.COM a:mx-sanjose5.Cadence.COM include:mktomail.com include:spf-0014ca01.pphosted.com include:spf.protection.outlook.com include:auth.msgapp.com include:spf.mandrillapp.com ~all X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-10-11_07:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=371 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810110156 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org If EP attempts to send an IRQ (legacy, MSI or MSI-X) while the link is not up, return -EINVAL Fixes: 37dddf14f1ae ("PCI: cadence: Add EndPoint Controller driver for Cadence PCIe controller") Signed-off-by: Alan Douglas --- drivers/pci/controller/pcie-cadence-ep.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/pci/controller/pcie-cadence-ep.c b/drivers/pci/controller/pcie-cadence-ep.c index b762214..3667d70 100644 --- a/drivers/pci/controller/pcie-cadence-ep.c +++ b/drivers/pci/controller/pcie-cadence-ep.c @@ -370,6 +370,12 @@ static int cdns_pcie_ep_raise_irq(struct pci_epc *epc, u8 fn, u16 interrupt_num) { struct cdns_pcie_ep *ep = epc_get_drvdata(epc); + u32 link_status; + + /* Can't send an IRQ if the link is down. */ + link_status = cdns_pcie_readl(&ep->pcie, CDNS_PCIE_LM_BASE); + if (!(link_status & 0x1)) + return -EINVAL; switch (type) { case PCI_EPC_IRQ_LEGACY: