From patchwork Thu Sep 13 20:16:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve French X-Patchwork-Id: 969524 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-cifs-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YnA9/mXK"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42B9096PF9z9s9N for ; Fri, 14 Sep 2018 06:16:25 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727825AbeINB10 (ORCPT ); Thu, 13 Sep 2018 21:27:26 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:38463 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727231AbeINB10 (ORCPT ); Thu, 13 Sep 2018 21:27:26 -0400 Received: by mail-pf1-f193.google.com with SMTP id x17-v6so3178138pfh.5 for ; Thu, 13 Sep 2018 13:16:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=BVNd8uoyDVqNzyOIi1+vM5Nl/8Aw8edxxA9u4SPWnxA=; b=YnA9/mXKpyHrdHOwXORtIu63Zy1r2jj9LIsn7ZAjmyEMf1E88ZT7l6bx+hvyoAumdm d7NVWdocaALkE7ddP7+HGJ8G3ihANdtN4vmDDwZM0s4IiM/KRFlgjCDK89hVpsRyNaPB MSMYJtzhImpZ5dE6JxpkVTdR8efI07zk4/BkdoU79kgaE8Sc53DdB3eSBHg1J9P0SQci +hRgNHBkldpmYIDu6/UtiFUFIXkt1cuX6R71yH3M0HIUEUs7FHJUHcIlP+vglUTRPpBa 1w8W8BShfv2TLQFyqq7zHJk79oOVYri7ibA9GHlIFTuO+Zu9ccQAvh1EK/Noo63sYQ0I PRMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=BVNd8uoyDVqNzyOIi1+vM5Nl/8Aw8edxxA9u4SPWnxA=; b=Eg2SdVxZamtJny1t0HdV/1LPq2aXPUD/7mRcsCtZRBWY7dWCnCUs1Pw2eYTTjnoy+f jJhdhGlKuIOyJuj5immaVxpxLp+y62z+jra5S3ScsymqR3tQhMSGFxcHcwEBWLdfc1/Y CLhcZyKm5vRNFFBpsBXuUAZmNgi0z3v0OFjsLoEjVmF3IVFeoe2XKsyURxol2rHdOEWh JAGZxL3iG4ptkH7pR5Upor5m2ScQB7jtvmdzKsJPsAoLKR2hvADxSFJHExrcqHIsIavN 1aBhKKrMpAnFb5Fz7fE3C9fEOP4tKL5EVIHtZqk2YK0S+SjYeyjPWwSRn0mViF7LYsnb 0KIA== X-Gm-Message-State: APzg51Dnhk/38DCZPjpsE3KHZoRfi/kswafDIXgLXRb1GUqDk4FLz6pG T5+H6XsgixZRe/WH/SIqufO6EKsQSnLCc24HYHrzSDDX X-Google-Smtp-Source: ANB0VdZMKdGboUu0fjg+O1wxGJnX687uycdwoclbexaFYGcg4YRDlseCo5V7fQrLqjutNr+dWIZh2KKCNmgx2EU+ycI= X-Received: by 2002:a63:6b86:: with SMTP id g128-v6mr8473092pgc.344.1536869783403; Thu, 13 Sep 2018 13:16:23 -0700 (PDT) MIME-Version: 1.0 From: Steve French Date: Thu, 13 Sep 2018 15:16:11 -0500 Message-ID: Subject: [PATCH] smb3: do not display confusing message on mount to Azure servers To: CIFS Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Some servers (e.g. Azure) return "STATUS_NOT_IMPLEMENTED" rather than "STATUS_INVALID_DEVICE_REQUEST" on query network interface info at mount. This shouldn't cause us to log a warning message automatically but does because we were not checking for ENOSYS. According to checkpatch we shouldn't be using ENOSYS for this in any case so fix it by mappoing to EOPNOTSUPP so we don't log this unless noisier cifsFYI is enabled. Signed-off-by: Steve French fs/cifs/smb2maperror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) {STATUS_ACCESS_VIOLATION, -EACCES, "STATUS_ACCESS_VIOLATION"}, Reviewed-by: Ronnie Sahlberg From 9c382451081aa0e4f5a146cebe6696b019bb962b Mon Sep 17 00:00:00 2001 From: Steve French Date: Thu, 13 Sep 2018 15:12:34 -0500 Subject: [PATCH] smb3: do not display confusing message on mount to Azure servers Some servers (e.g. Azure) return "STATUS_NOT_IMPLEMENTED" rather than "STATUS_INVALID_DEVICE_REQUEST" on query network interface info at mount. This shouldn't cause us to log a warning message automatically. Don't log this unless noisier cifsFYI is enabled. Signed-off-by: Steve French --- fs/cifs/smb2maperror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/smb2maperror.c b/fs/cifs/smb2maperror.c index 20a2d304c603..d47b7f5dfa6c 100644 --- a/fs/cifs/smb2maperror.c +++ b/fs/cifs/smb2maperror.c @@ -288,7 +288,7 @@ static const struct status_to_posix_error smb2_error_map_table[] = { {STATUS_FLT_BUFFER_TOO_SMALL, -ENOBUFS, "STATUS_FLT_BUFFER_TOO_SMALL"}, {STATUS_FVE_PARTIAL_METADATA, -EIO, "STATUS_FVE_PARTIAL_METADATA"}, {STATUS_UNSUCCESSFUL, -EIO, "STATUS_UNSUCCESSFUL"}, - {STATUS_NOT_IMPLEMENTED, -ENOSYS, "STATUS_NOT_IMPLEMENTED"}, + {STATUS_NOT_IMPLEMENTED, -EOPNOTSUPP, "STATUS_NOT_IMPLEMENTED"}, {STATUS_INVALID_INFO_CLASS, -EIO, "STATUS_INVALID_INFO_CLASS"}, {STATUS_INFO_LENGTH_MISMATCH, -EIO, "STATUS_INFO_LENGTH_MISMATCH"}, {STATUS_ACCESS_VIOLATION, -EACCES, "STATUS_ACCESS_VIOLATION"}, -- 2.17.1