From patchwork Wed Sep 5 13:26:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Louis Peens X-Patchwork-Id: 966394 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=netronome.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="FuOvynXv"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4254HB4H91z9sCt for ; Wed, 5 Sep 2018 23:26:45 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 4D399EA5; Wed, 5 Sep 2018 13:26:42 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 9FA57D65 for ; Wed, 5 Sep 2018 13:26:41 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 1BA298B for ; Wed, 5 Sep 2018 13:26:41 +0000 (UTC) Received: by mail-wm0-f47.google.com with SMTP id y139-v6so7936015wmc.2 for ; Wed, 05 Sep 2018 06:26:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=oL5fiCQQXAd3oJnxzDARhLX44uJvQRlu+nysImZ+7Vs=; b=FuOvynXvCS8gAltdPca0LQv2cuPM79OkWDlXNs1lL8tX8XrQJ6WgYbp+3FgBwyw4v4 Cv2lMe4+fHzpvCDK1xdenzcfwG78I3yni5hXLVq0J/m608Ay2YnX5bPyNYNSevwFvG35 OHFhlfFIVVRwwl/oipNq+Z62REHLaG046nS+cg8hvV7pnBFG7pfBdr8gkTNSdXOzxIWF Gl8Qulb0Wb2lslFzX2A9c4C5pOSe7fp99ItlM/l/0y5OzC4C21zy0X/1uty1dKDl5sC8 5dAQpYQDVy1yN0adBl3NYMDhxjJAS8258J2fRi5kcr+p9wmxUJu2R2TxfCA/kP8kUd7d dLfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=oL5fiCQQXAd3oJnxzDARhLX44uJvQRlu+nysImZ+7Vs=; b=KY1T2HwWsOOSh/c51VzD8FzO4Ryj/6dnOIeQj6y09dKtw+KUfcVc5n/rGenBPZz8JX x6DD2LQGuLG1yKdcWYNsxniyMl/LZchRFfIFSsoOt2WdcAq3Sv2ivlwqYazlQ0lERRAT g6m2W/zbABIDrX8QS9Hf31k0Kwcq2cufygbsn4+Gu34lh4KpGU+FlXb5q6X5lrEaV9Rb GmG29y47FpnfAwvUCgI2j9MY/EZ9ePrZzN2kED7aCHqpWYRDGOJNZ01j8TYZpZd6qhC5 Wains4MEklhxFKJmd3GwQl5LicmYnIhHZhhdKzy9kBHq6kFAY6BtW1AfpsSDUNtlJG4D 5tww== X-Gm-Message-State: APzg51DgnVkUB7/wEJsJfCX9q3mMOrgoMEIyAFj9ZMuZbR5kaKsEpk07 O/sSwftEJfTtfZ5J7iX0vbBJuWfhbbo6Rw== X-Google-Smtp-Source: ANB0VdadeYOqbFID5olHOSTC+LijV3I/gUelDsoVUWfxAIjbMw++oCOyfIpAHfZt94Ne230vtM7NGg== X-Received: by 2002:a1c:65c5:: with SMTP id z188-v6mr244633wmb.57.1536153999584; Wed, 05 Sep 2018 06:26:39 -0700 (PDT) Received: from macuntu.za.netronome.com ([105.22.41.74]) by smtp.gmail.com with ESMTPSA id o14-v6sm1212379wrp.57.2018.09.05.06.26.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 05 Sep 2018 06:26:38 -0700 (PDT) From: Louis Peens To: dev@openvswitch.org Date: Wed, 5 Sep 2018 15:26:24 +0200 Message-Id: <1536153984-16529-1-git-send-email-louis.peens@netronome.com> X-Mailer: git-send-email 2.7.4 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: simon.horman@netronome.com, Louis Peens Subject: [ovs-dev] [PATCH ovs] lib/tc: reject offloading of non-Ethernet packets X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org When a packet is marked with the special ethtype of OFP_DL_TYPE_NOT_ETH_TYPE it got wrongly installed into tc datapath as a match on a packet with that ethtype. This prevents that from happening. Signed-off-by: Louis Peens Reviewed-by: Pieter Jansen van Vuuren Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc-offloads.c index 7bc745e..ccf6d6b 100644 --- a/lib/netdev-tc-offloads.c +++ b/lib/netdev-tc-offloads.c @@ -918,6 +918,10 @@ test_key_and_mask(struct match *match) "offloading attribute icmp_code isn't supported"); return EOPNOTSUPP; } + } else if (key->dl_type == htons(OFP_DL_TYPE_NOT_ETH_TYPE)) { + VLOG_DBG_RL(&rl, + "offloading of non-ethernet packets isn't supported"); + return EOPNOTSUPP; } if (!is_all_zeros(mask, sizeof *mask)) {