From patchwork Tue Sep 4 02:44:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965681 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NkGlnHpR"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="tVA03VPo"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B5p2NLnz9s3l for ; Tue, 4 Sep 2018 12:45:34 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=czxoOAgpYyt35dQHilhmdUz4mXhilV/BOUHUTvxKwzk=; b=NkGlnHpRVMdIBK6h58rEsmNoxO CJOgOocIxxHqVK/UO8t71yefPk4ayaYWjkJnBJuKmo7GICeBJkaiE9PUGXgWV+yZgdA7UvhbJdTnh 22D7L1iE5pBz5dJBwEg3bejDQutMfoXBeGN9w2B1TNBM4cNClB4zo8JVb0lbObNDJgws96uFsdtFZ 9UMU7r4jiTIZYZ05xABMOfAf6cawJ7a9BM0wn2qu6X+g29i3LwEUzCZRqoJ0ujLu4M+8JZZ6qdWNd ZyBMLxa3/HJ1y2RCKxnke+mIcSKxmZff81Duxy+HJ88jux2ptZR1WHZQr2HS7webHX+RaccYHBR6n NxOUeX2A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1LE-0005FT-Ou; Tue, 04 Sep 2018 02:45:20 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1LA-00046G-RI for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:45:18 +0000 Received: by mail-pg1-x542.google.com with SMTP id r1-v6so872599pgp.11 for ; Mon, 03 Sep 2018 19:45:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=0GxHfpXfEOk9XYTLZ+H5qwUF7ZNphH1CAsEDqllzqo4=; b=tVA03VPo7j3sVSscYTpVEeHmPevVxEsFXiCSw5Mnv0/iyykkV0CYzP7CjEdED8YAUT tvz132dLLZLXDkGnaZUOrXER24+hL6KKk6wiwu9DmPcaYeWbdN79jerVRpqXuSwY+e7z t01Xd4KhXs7tun7SiSM+IbULs8ypyeo+7JOEjSFjbMz0XSoewATUmJvY4GgnilINu2Zn 4GxLs8xfJ+Vau5f7kn8MKBV8dDXFihoGNe8/fA6DcfP+ZYKzs4k9njJ1QgAl0yRoyJUX wEV43MsOSsyaOqCabINkG7mX2la1PWjPxWFoZG7pNhOO+O9dncJxgFNQcWPPP3juSRAj iAdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=0GxHfpXfEOk9XYTLZ+H5qwUF7ZNphH1CAsEDqllzqo4=; b=VZKMIK3jgUllVvpBTgTTGorMRIkEJ9IPX9GFjyxMUvxXvThD1ZiCWBMjHnpd1pmPl6 CRId2tY5ESZlqKqWbqi2nerQcSFTkSWcp/haBBxgGQLAUBDW2IXP9zff5BtCHyhcGI3K jHn3D1uT4p3zVHEMoS/WnMPB9iVVm5W1aZm4eVEFLW1pdZV54s2belHOqh+hNVPnSde4 lCzsFCwypq+8hTjGffil2piNENhHUkjzAQFPriHuh7YZD77C9ci8j91cEU6djOfcGdNu U98I+CxbXc8TglSaDJB3kaXkxtVEhSYaGWeuKEboTIGq7jOIZGH9EXGf5nYA7RBg7x52 XzHQ== X-Gm-Message-State: APzg51DwmsI9IE4Gnw2E6zQxM8bd/h3jrAhLt8JrjQlBZqv3ua18Wair nmADs2a0Vxpft05AE3WJXNxeez8D X-Google-Smtp-Source: ANB0VdYMoqLb/evAfeLiGb4LA0wUP6Kr4PZ9D+BeNrRRhwerJ+ChrZIwKifFRbtqIy9QW3nBIxcTQg== X-Received: by 2002:a63:8c0b:: with SMTP id m11-v6mr28828698pgd.372.1536029105898; Mon, 03 Sep 2018 19:45:05 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.45.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:45:05 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/25] tty: Change return type to void Date: Tue, 4 Sep 2018 11:44:27 +0900 Message-Id: <1536029091-4426-2-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194516_895378_66A3FBE7 X-CRM114-Status: GOOD ( 13.87 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:542 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Many drivers with tty use the tty_stand_install(). But, there is no need to handle the error, since it always returns 0. So, change the return type of tty_standard_install() and tty_port_install() to void type and remove unnecessary exception handling where we use these functions. Signed-off-by: Jaejoong Kim --- drivers/tty/tty_io.c | 10 ++++++---- drivers/tty/tty_port.c | 4 ++-- include/linux/tty.h | 4 ++-- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index 32bc3e3..b01cec8 100644 --- a/drivers/tty/tty_io.c +++ b/drivers/tty/tty_io.c @@ -1196,13 +1196,12 @@ void tty_init_termios(struct tty_struct *tty) } EXPORT_SYMBOL_GPL(tty_init_termios); -int tty_standard_install(struct tty_driver *driver, struct tty_struct *tty) +void tty_standard_install(struct tty_driver *driver, struct tty_struct *tty) { tty_init_termios(tty); tty_driver_kref_get(driver); tty->count++; driver->ttys[tty->index] = tty; - return 0; } EXPORT_SYMBOL_GPL(tty_standard_install); @@ -1221,8 +1220,11 @@ EXPORT_SYMBOL_GPL(tty_standard_install); static int tty_driver_install_tty(struct tty_driver *driver, struct tty_struct *tty) { - return driver->ops->install ? driver->ops->install(driver, tty) : - tty_standard_install(driver, tty); + if (driver->ops->install) + return driver->ops->install(driver, tty); + + tty_standard_install(driver, tty); + return 0; } /** diff --git a/drivers/tty/tty_port.c b/drivers/tty/tty_port.c index 25d7368..fd8d40d 100644 --- a/drivers/tty/tty_port.c +++ b/drivers/tty/tty_port.c @@ -656,11 +656,11 @@ EXPORT_SYMBOL(tty_port_close); * to a concrete tty specified by @tty. Use this or tty_port_register_device * (or both). Call tty_port_link_device as a last resort. */ -int tty_port_install(struct tty_port *port, struct tty_driver *driver, +void tty_port_install(struct tty_port *port, struct tty_driver *driver, struct tty_struct *tty) { tty->port = port; - return tty_standard_install(driver, tty); + tty_standard_install(driver, tty); } EXPORT_SYMBOL_GPL(tty_port_install); diff --git a/include/linux/tty.h b/include/linux/tty.h index c56e397..63cdac1 100644 --- a/include/linux/tty.h +++ b/include/linux/tty.h @@ -556,7 +556,7 @@ extern struct tty_struct *tty_init_dev(struct tty_driver *driver, int idx); extern void tty_release_struct(struct tty_struct *tty, int idx); extern int tty_release(struct inode *inode, struct file *filp); extern void tty_init_termios(struct tty_struct *tty); -extern int tty_standard_install(struct tty_driver *driver, +extern void tty_standard_install(struct tty_driver *driver, struct tty_struct *tty); extern struct mutex tty_mutex; @@ -688,7 +688,7 @@ extern int tty_port_close_start(struct tty_port *port, extern void tty_port_close_end(struct tty_port *port, struct tty_struct *tty); extern void tty_port_close(struct tty_port *port, struct tty_struct *tty, struct file *filp); -extern int tty_port_install(struct tty_port *port, struct tty_driver *driver, +extern void tty_port_install(struct tty_port *port, struct tty_driver *driver, struct tty_struct *tty); extern int tty_port_open(struct tty_port *port, struct tty_struct *tty, struct file *filp); From patchwork Tue Sep 4 02:44:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965675 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="reflyRoj"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="KxounjR/"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B5c5YrDz9s3x for ; Tue, 4 Sep 2018 12:45:24 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=DYbHD3iAE7Ho+hbY1MNJCEMLtVfPPfIIzfYRvPHwhus=; b=reflyRoj9bGRsNnxbfwJaurGdc r0qgciskBclOyzc6r1x9o6msxzQLEQZtR3raPCU+FQggDEglzHkDoniQbi4Zn7BcAhm5IcmPVOJL+ 4HBhQR1kR/+2GdQPAOJC4jHLoV+PDeyu6PcrxmHy5ADLl9VCkkuf7oyGsVSsqSqZtIRL2JpH/87a7 iio70KHR6YNSfQEPf3cQJA6iBUH2bDlwkLUN/bvpPCOg6LpxX31zG2V1N0eRXV56L8m4Ii8bNdlpo jSKKye2TzqMvT1+apLe7m/MnPa1mRRbNkYC+4IhbIIDRoItu5BEWxKGTc6TNdDVyXz8YkhfukpSY4 +4nEjZKA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1LB-00051S-2e; Tue, 04 Sep 2018 02:45:17 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1L6-0004Dt-Q4 for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:45:14 +0000 Received: by mail-pl1-x642.google.com with SMTP id e11-v6so895265plb.3 for ; Mon, 03 Sep 2018 19:45:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Cdxdf1nldZEi8RFCj/e5+/wKGAi8Yvs7ozh1di1NMpo=; b=KxounjR/JZhvaF6qG4+wwjyny2S175AVYEOKwqlvVqOSceE1lDEHish/yEn6xJWOuR nRdSShqUEIefZGOlsW+rf1scndPm3AIFIjVEl4Xj/6FW+LN4yCGb/C1qKogP25wLzB5T MQSnSjXoqxwzF24ZIeu3hD9EiqPi7tD6GK/SFksbYf0VCDnPTQvMlmc/jn5llW2vF17q nrN0Z1YIjztsSFstU2ZkMbuRL9iW1/ej0CJ09DupJxc6aF1kz2GNOI4GLUMyj2i3G7ZR n1CqNysGqlAGfIXJpiyHCBVEp04yj7t9s2QlNN9/zuxSHsHPweFRyGfpMCJ8XeyCoU2a 7w6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Cdxdf1nldZEi8RFCj/e5+/wKGAi8Yvs7ozh1di1NMpo=; b=onXtGgg6RdnJG26aDdIcqnQZFW0hm3JODjDppu+ZYAPFILNg5jl7+/lqN+nI0NBCNA 2u+9dofWzZRjTpqi+E2h8qvow3Wko0AeqWT/ZkokYZMg0U/lzP/X9A37s12b9ztsTs/R LNj8TDLfzWJqR4P3OsDx/MQIHvmicd+LtNt/8jaJB3uNT0TKmwWLsxRLCb3ep9DZDPfj gJRJegtCye7JBCUWD5A7RaMT5kS82b4cRv9fo6E6qw5L/LUFdAagZUJCed4I5QV8C68L 43mUYHHsbFc7FjB2YZxCILZhan7C47Bn5TjILKF4BnVlSso9zwJR0AuPHe+jCcz10RDC 5TMQ== X-Gm-Message-State: APzg51B+rPYe4mOazQwll648DlkIidDg7IXEsSRsB9oy3VpEcOtZU/1k J4MQnvBs6EFaxfUdyGbmuOV6wzZH X-Google-Smtp-Source: ANB0VdbN8FZcq3Z2mFtnAJPf/iOgVpWnqizHc8ffHszeHAoQKhBevaIn/eL/Dxx5QH6nAsbg8ERTZw== X-Received: by 2002:a17:902:981:: with SMTP id 1-v6mr26346204pln.60.1536029109928; Mon, 03 Sep 2018 19:45:09 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.45.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:45:09 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 02/25] isdn: i4l: isdn_tty: Change return type to void Date: Tue, 4 Sep 2018 11:44:28 +0900 Message-Id: <1536029091-4426-3-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194512_856399_71168098 X-CRM114-Status: GOOD ( 12.39 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:642 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_port_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/isdn/i4l/isdn_tty.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/isdn/i4l/isdn_tty.c b/drivers/isdn/i4l/isdn_tty.c index b730037..3d6b24e 100644 --- a/drivers/isdn/i4l/isdn_tty.c +++ b/drivers/isdn/i4l/isdn_tty.c @@ -1481,8 +1481,9 @@ static int isdn_tty_install(struct tty_driver *driver, struct tty_struct *tty) return -ENODEV; tty->driver_data = info; + tty_port_install(&info->port, driver, tty); - return tty_port_install(&info->port, driver, tty); + return 0; } /* From patchwork Tue Sep 4 02:44:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965680 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V6KoOfu0"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="bcmdTC4I"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B5p3dV3z9s3x for ; Tue, 4 Sep 2018 12:45:34 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=A3wTZ/8Cg+i6JrO/IGeRrnrXsWYeDrn1by5eEH0VSYQ=; b=V6KoOfu0U8/Shod46yJpWzJy9V u5GwnfUh47e86bkwW7A9LsBot3/7dUpfs1t7naie9N2mCaEQkoeL/ebitND+3uTSY4shpfgsqQrnc JKiW+d3S+GqQFR8PfqdlVWTNlFRzHOldipIcvn70nS20PULWrRvcdLt/wfcX8NAYKvwVU8nB6Raqj a8/JgIMBrpPfL407OrWhaMMfgGEZz6Ig7Zgai9E5bxuY6LSSEX1J66HnBcfpt65DjhS3DfUkPviMy L2Ped90xZ/FaOXf9NdAuflcMUBWXpRUk8gTreFcCxpbTl63ima6uitN193bPcrvI7j4MLodZpdMsf 0Wrcw1fQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1LL-0005Hh-V4; Tue, 04 Sep 2018 02:45:27 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1LJ-0004jJ-CC for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:45:26 +0000 Received: by mail-pf1-x444.google.com with SMTP id k21-v6so894917pff.11 for ; Mon, 03 Sep 2018 19:45:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=QKXT0IAdiXGunM0h8TcwlUcNbYTcAP1VBYf+0K34IOw=; b=bcmdTC4IFRlkcnu8u5M3hslCsrGt3xtnfwLmuDwqml+VgFsLScxRsX69Z1WHq4kc/F 7kOOGpZVzNBqUlLfNCs6h4N3vT57A4SMcoD0/LoJ85+okOM8C6uWDUm3nbAM82/n1FLh tc19OURIJS64bFCfl5XVccjOqxgGBbwBH8RBgK4o7puXJRGfZFeyjATTcm/rfzvsxRJi EImZoqDjUmyiBKtKyAlgBe+BYfWQA7JVEY1eZnNcvnEBeA4jIoHwOpDyTdTAgZsf/X/B Ng7O+h1OHgnw7JBoRQNg54u/dkDSQP1afDCKoL5yrkEXdSDdtSIe4/elSPza0sn8cWS8 NNbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=QKXT0IAdiXGunM0h8TcwlUcNbYTcAP1VBYf+0K34IOw=; b=lytIJnMt+aaSWJc+RQcjFeYGBqlqKygreJQdGQzjX8qympzqE2hZPIbZUSm/iX5HpH nFYE9IEV8JEfnUV7JaKgGGzKFQMhnZVde/yivyVNez5l26qJuhfM44GlafFa4BqkSJws h63ofM6B7dC5MyhMdUFc0JxO9WTNOFvwWxoi2l7NjxyQapYJ655nue7eDa0sljgvAzkh ggEct3DKJ0pj4gngK6Ur1Exih7Eh/HwoDDgv4IbAyW484UTEerNewelSJpLdkTEeo80h fcAJSl8Z5g02puUU8NeknGyMYyluv9xRy3MKPQey9yenCqe8iM3zvSYBabPlM8xplcai avPg== X-Gm-Message-State: APzg51A+3hvJF3di6fmFReTNyGmG5wGz/6VbXLsKF2B8i0sg4oyLcVFa bv6noKdvI8aFaHzNuj0XxU3NDW2s X-Google-Smtp-Source: ANB0VdYezC4JAodZd+e37kZ7Y2b8TpdNW+oJVm7jwyD2eR4ESWNi9ENUOHoDLCeUFD0/JsJRlCKvRQ== X-Received: by 2002:a63:f54c:: with SMTP id e12-v6mr29197845pgk.286.1536029114284; Mon, 03 Sep 2018 19:45:14 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.45.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:45:13 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/25] s390: char: con3215: Change return type to void Date: Tue, 4 Sep 2018 11:44:29 +0900 Message-Id: <1536029091-4426-4-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194525_416143_0750ECE6 X-CRM114-Status: GOOD ( 12.39 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_port_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/s390/char/con3215.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/s390/char/con3215.c b/drivers/s390/char/con3215.c index 8c9d412..6a9f6d9 100644 --- a/drivers/s390/char/con3215.c +++ b/drivers/s390/char/con3215.c @@ -965,8 +965,9 @@ static int tty3215_install(struct tty_driver *driver, struct tty_struct *tty) return -ENODEV; tty->driver_data = raw; + tty_port_install(&raw->port, driver, tty); - return tty_port_install(&raw->port, driver, tty); + return 0; } /* From patchwork Tue Sep 4 02:44:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965683 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Tv2isFGh"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="AiTY2J0y"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B5w2QVWz9s3l for ; Tue, 4 Sep 2018 12:45:40 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=jMyH0yOyhvxf/YG6EJtGBEspaGzUfBT1sXCmfAEMfss=; b=Tv2isFGh6I9NDZskfB5CXIjwHk YUATnTlarrLiHsTN9jm5AI69q5YRdl2FY5UmE7tpal6qXmJfklA4E6JgvaAZZ7RkQg939pHg6x87A R1AtPWA57T+hMQCR9mYoyGzfuNXHF+GxD99193vJZxpe5jU5Dtt9u4zXiRr7gWkFFlKKzVZOIN7I1 i1/Ha+Usx8BNwTsvybZghNUkOpPC8zwoADHNouVbsmy1eXr6daGOCO7VHoDJ3AGm43tC1o0GyVQCE e4nyPCBAXM8qG4VvCg8YpG71ZZiZeJdHW+5J8dobdqM5gtnw+M65+XCYVEIAke3675I14llGjYt9w fSvJdwMA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1LQ-0005JM-46; Tue, 04 Sep 2018 02:45:32 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1LN-0005B1-1J for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:45:30 +0000 Received: by mail-pl1-x642.google.com with SMTP id s17-v6so884944plp.7 for ; Mon, 03 Sep 2018 19:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ds3q9KD+4bwv6Be443Dyi9iiaHrBZT5yxhOOYzF9crg=; b=AiTY2J0yecEktVfXFRlwiIiAAy2sWRdA1OtLSTHDNtoNB4eYZFTegALMENThQPbch5 rbiqZQQ3uBr9KDT7V5ymtK//+E35Tb5nksA3XhKCJsfkhZzhU2/rodIqHj/6ZR5O0l+O +j74wmpJB7AObwSbunt+cLYm2ltgK8PzOWntFlKfqriFhuvl24R7ifmAH7EwVRHH86qZ +Qx1+Da5S84kBucqunCfaOlNQE+nsevi7O0i77UCmr9IJsTaQ3Ml/tf+H1T33LtOyf4O DVKR6e6GA5xHYaUk9MWB7x14M/2HSncWv6KiHgAA14538CUldZZCk21Z49CO4rsrfTf8 sV+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ds3q9KD+4bwv6Be443Dyi9iiaHrBZT5yxhOOYzF9crg=; b=PZ9KVZJo9x5Lzg0SBvFMyrfOlAvDXcH4YUBHCoalgyjNVifkvTY8bu4DskMCvf1OaI nZMAauqpUYFQgHVXI12GsyPOr8lnUxYveOPVSezmhL1U5Ls77yaVYOb4j/TjBP8cuFZn B75vh4yaWDbdgakLkMcd50Yl2ZiQqSWNvIIe560ANIXyE7pj0DjgLC2w4M1T3Admqh5w lb56og2uQWFhc/k7T3CybD/mQyWIyctdGgcfIqLNOhASbz+dmIx+868NuVDFW8GmM+W1 4IIK0W7V+PTBNdr+bLTGrofBO2yCExRvcR8rWwFlCJD7XZUdvqRiu3leYI35tOmO6StO qzUA== X-Gm-Message-State: APzg51DQEetvoe94nu177GSnudBvqBMRdr5PZSGhojb1lxZBTmyTxGuR VOx9FKQqmo5KOQGxsfCtlNF8HT4W X-Google-Smtp-Source: ANB0VdbBD8lSu0DKmafc+1B+HkvsKNZjsz3hST7COXm+YnNHboqI1PyturbOWyhIOIXz1rsoS383Dg== X-Received: by 2002:a17:902:2804:: with SMTP id e4-v6mr31226863plb.327.1536029118457; Mon, 03 Sep 2018 19:45:18 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.45.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:45:17 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 04/25] s390: char: tty3270: Change return type to void Date: Tue, 4 Sep 2018 11:44:30 +0900 Message-Id: <1536029091-4426-5-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194529_089289_76EB1DB0 X-CRM114-Status: GOOD ( 11.55 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:642 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_port_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/s390/char/tty3270.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/s390/char/tty3270.c b/drivers/s390/char/tty3270.c index 5b8af27..2915f95 100644 --- a/drivers/s390/char/tty3270.c +++ b/drivers/s390/char/tty3270.c @@ -1017,12 +1017,7 @@ static int tty3270_install(struct tty_driver *driver, struct tty_struct *tty) raw3270_activate_view(&tp->view); port_install: - rc = tty_port_install(&tp->port, driver, tty); - if (rc) { - raw3270_put_view(&tp->view); - return rc; - } - + tty_port_install(&tp->port, driver, tty); tty->driver_data = tp; return 0; From patchwork Tue Sep 4 02:44:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965684 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FXglXWIU"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="VCPVzREE"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B604ztRz9s1x for ; Tue, 4 Sep 2018 12:45:44 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=hxDDKt7bTBx/vR3YXfexySyr40eMY+gVI3l3dtAKCug=; b=FXglXWIUXo0xJzPMy+c+p/ayQj vjozPt85Jo8eGiolNch+mHxTmp8cLZY5e8cneJtwbTSI3+GR6/CbeIZlRazjNkn/xtNxmtWhuBHqh BjDAL3g10Ky963CjMX0hn3b41bE1TaLp0RM3DM8KGi2QPO6shZ6eKei7vVaprXoSWZx93Xfn6wn0b FNNjGTE/A1CRcLfopyDpyqBSCYpohNj5BKF/AdcCf5w70JBwXcdK6iJ9aalUGGTThfZo7AE+YgSIT ZUA3+KGJOYMJJ6FwGIL+E8VK3YO26JMrA7ffvD9nWJAFDQ5pizUWDPjJSQvxOemFIwE71yXGkkPai n8FKki3g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1LV-0005La-95; Tue, 04 Sep 2018 02:45:37 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1LR-0005GC-Nf for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:45:35 +0000 Received: by mail-pf1-x443.google.com with SMTP id x17-v6so910752pfh.5 for ; Mon, 03 Sep 2018 19:45:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3hQFNTER0lszd0kvVWEV9kMR5sWuq9dK2/YVDi+Idr8=; b=VCPVzREENBfb8A3S3qPc2w/U09HYMnR5XjohbR7s87xH2founlXnJ7O2LxYkSefiuq KsuC0X422xiff0z0Rlrk4+ofOXd4g1EIaYHnlxpKKNux/l7AB3XHg9KKsOkO4P07Rws7 hJqi7OObHxBUF2Mb0q1XpiUSrvJegONnM4mZZULdG//xUDPAczorNWMFdhEoAN8mkd5r FXPlZvM7PP2RPTnM19wOnLaGM3+bSK/bN3CM40wstgm9dcjsSGP2xDJoovFMHtcNciL2 nPsZIRvd8rg0a4e6qnnO4JXKdGmmAlU++jWLQRlXmfQntrU61+HuBTGxUIK1fUCwTDtz RVng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3hQFNTER0lszd0kvVWEV9kMR5sWuq9dK2/YVDi+Idr8=; b=JyGfGYGXRwrjgnL/PKQTC3WCPzxb5z+wP7CrrOBt2WD3BR4FT9QKdhhrv6fKiVMGcv aJV2oqJSOIAG9Ky0upJND6x72S8f3rhCGa9HHUTrmkjRTNGeTjuCj/wEUoFRrvz6EOp6 VQ/JT/PT7xaYYUTePekgiWGSvgiu0oii7ubC6lmPuRXUXO1qkQPYYc196xxykUkzKd6I e85IbMw6J97lnUUtTcjLaxRh7JY1SxepE9S06k072egxOTnDjMHlh7en5tMf0+MyUArX cC4TA2yMGpjJSANiPtKXgeG7rdgAuwjGWslEpDXt65YsRSFX7vY5gxfiYw7yFTDAw7TQ ZqZA== X-Gm-Message-State: APzg51Dr+SZoPNLJJgX0Ew77cMPNR+4dNsw0ZlM2f/kc0Iu6OUFz9VUB DBZcGbtFQ8kMdCHuUuz8ak88Y/B4 X-Google-Smtp-Source: ANB0VdZGhGrOBh/Fz1lvUWCqJiTMNZnM5DkgqzgQGJrQBIlWSPsVG9V2HnHzIfB07WhBfG8nk/v2/w== X-Received: by 2002:a62:6003:: with SMTP id u3-v6mr32916616pfb.114.1536029123060; Mon, 03 Sep 2018 19:45:23 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.45.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:45:22 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 05/25] tty: hvc: hvc_console: Change return type to void Date: Tue, 4 Sep 2018 11:44:31 +0900 Message-Id: <1536029091-4426-6-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194533_809938_FFD1D92A X-CRM114-Status: GOOD ( 12.94 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_port_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/tty/hvc/hvc_console.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c index 5414c4a..13fad62 100644 --- a/drivers/tty/hvc/hvc_console.c +++ b/drivers/tty/hvc/hvc_console.c @@ -329,7 +329,6 @@ static void hvc_unthrottle(struct tty_struct *tty) static int hvc_install(struct tty_driver *driver, struct tty_struct *tty) { struct hvc_struct *hp; - int rc; /* Auto increments kref reference if found. */ hp = hvc_get_by_index(tty->index); @@ -337,11 +336,9 @@ static int hvc_install(struct tty_driver *driver, struct tty_struct *tty) return -ENODEV; tty->driver_data = hp; + tty_port_install(&hp->port, driver, tty); - rc = tty_port_install(&hp->port, driver, tty); - if (rc) - tty_port_put(&hp->port); - return rc; + return 0; } /* From patchwork Tue Sep 4 02:44:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965688 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bIm7qUHq"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Lbkt1Plx"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B6D2Qcpz9s47 for ; Tue, 4 Sep 2018 12:45:56 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=9hc1ExoF1KE6ccwTRByzNcyZTGaQNkZEJ8eTWLuMy4I=; b=bIm7qUHq66/g19JRhc5NbIO1Bo AOOcEoQUWtWVGsL03Xo2pHSwmEJLMcvoQmPv06V7kDwS1x7erPEfs0wXucGAGFlz1eHMgbEiG4sBj +wkmIM2xeq4l1U5hU0Yu+C8Td1yklnrNZTVgb2UezbjnbXJZVHJjFf8Cfq1xvViOoKZXuENo98V45 BaCSUeCX9OyBNuO5s9SXe5waqJ5gen0w7ltnEfyYV4lCfLFEsdPzHCxKmzg7rYRmboWOWpHTY0JR2 h/eJUMpVuB6UWGSBqmq18lJQpbZgzVpG/+IAPux5AfuZftYRopqIAwEJPtV9y4nc6iz854+RYhJyw lcqTgGJg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1LY-0005Mm-VQ; Tue, 04 Sep 2018 02:45:40 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1LV-0005Ha-VB for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:45:39 +0000 Received: by mail-pg1-x544.google.com with SMTP id y4-v6so879694pgp.9 for ; Mon, 03 Sep 2018 19:45:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tRdeqz+78ESzrb/nXjyBB6nqAAwIdJ3C0aGuFwzfOGg=; b=Lbkt1PlxVxfnVteEhPuZCMen61t/VT9dOcKgDaqKWjZ9uaMuAeJC1g2S72yEPZThiH jn/XI/ZimRlTHJ5JUCrUuzijODGVRgV7RwSfAuAuAn3cCwi0OXJSK+bZzA3MhA3ue3oY ykaxoEFwTzDAJQ+wAkTnPJvHL+0BRCoP5pq858TSLFDRjcfTbqFlgsLWvKmQM+HQwnQ7 Xehsi9XWThKKXhu/+NOcW2UJyNcJHzOhtB3OTO4mYsfsIPC/Rpe1cpr8st02yfxnYAyT yHPCG7i0rrekINkocDYZ180/nHSZDNCnJK6kxoFz/n+zpvk8K6uyyOrTGHsQyR+nM5qu ul7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tRdeqz+78ESzrb/nXjyBB6nqAAwIdJ3C0aGuFwzfOGg=; b=BLWb6DextHy5TOl5lFnLqUfck4+51YGs2BTd0nTEX2i2Bq1+HG7xPDL5KcyuGE+rtA RyXf2i45b+5bkot3vcxWsyw+wnYTCiYCoFpeuAi0L2LOWDq72/b0oETlXE+j52Dj3Q6d YDRujeVW/G0U+wWlXUE2cGlpoquEaDn2Fy/BK0YBkJLfWRDCTvSSIybl8nzDXIrdNGcr qo3inGAVrtd+II+z6RzfzIL+IFJcyI9p0oGdS7fO79BDNJCdJRLRTEFufLBfiBK38hBC IjtZRqURPL4WlYSVEe2F0rcQvtwIxo6S+sB+hZkf0ZTPYqGEBppZhBvpi1qHDRdIE6PJ vVPQ== X-Gm-Message-State: APzg51DKXbNMPKvMpTJ83LsCuo4tJjTExNCYVV1QKMnSLkYC05Qw1Iu/ 0YjCxGYm5jDUrVlCGOppMHVychMc X-Google-Smtp-Source: ANB0VdZxoeKVSzXKlsmQQoJgCTH/oH+q/pdwXVf1VJP0KvD27gLq8E/VdhUMgirGPdI+/A3Z958PYA== X-Received: by 2002:a63:e647:: with SMTP id p7-v6mr28111566pgj.218.1536029127255; Mon, 03 Sep 2018 19:45:27 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.45.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:45:26 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/25] tty: hvc: hvcs: Change return type to void Date: Tue, 4 Sep 2018 11:44:32 +0900 Message-Id: <1536029091-4426-7-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194538_061648_A7BB673A X-CRM114-Status: GOOD ( 12.23 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:544 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_port_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/tty/hvc/hvcs.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/tty/hvc/hvcs.c b/drivers/tty/hvc/hvcs.c index cb4db1b..4dfa70c 100644 --- a/drivers/tty/hvc/hvcs.c +++ b/drivers/tty/hvc/hvcs.c @@ -1140,16 +1140,10 @@ static int hvcs_install(struct tty_driver *driver, struct tty_struct *tty) goto err_put; } - retval = tty_port_install(&hvcsd->port, driver, tty); - if (retval) - goto err_irq; + tty_port_install(&hvcsd->port, driver, tty); return 0; -err_irq: - spin_lock_irqsave(&hvcsd->lock, flags); - vio_disable_interrupts(hvcsd->vdev); - spin_unlock_irqrestore(&hvcsd->lock, flags); - free_irq(irq, hvcsd); + err_put: tty_port_put(&hvcsd->port); From patchwork Tue Sep 4 02:44:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965687 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sUekxxSb"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="mlTOXR/F"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B686Vyhz9s3x for ; Tue, 4 Sep 2018 12:45:52 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Lh6YgaYR8oDWRmqDPr6IrQQdTGe5qox1b39Fmbbuc8E=; b=sUekxxSbmS+ADizcd5qQgRi8sB VKbmBEIgXaeJ3tZQMSDm9VivpnKMrkjN6YTu/tq6YUFALyWx3M6Bu4ZuB7bHOnooEss1yjdOSsTgX ZGvW/wS2re6u28TVICFOv1pfuewNOmGTYLrY26QnKIM+IBKImwaiD96opishNOWZgcTUJoaHHe/co V+MDfkGJc3THdUO7wBTb2BDKDls6sJGp/ZkxTRd026BLP4X2OHj5MLUKXj8kW+odJ2Oi2RoHog7mO cMaHBzwsC2fA3NYLFjQRBXIw2AvNPCD4aGcjCyFmRM9Tc6ODAS+DaKpbUSAhXRQdpzE9yhOMDz15i +3kwUZYg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1LV-0005Lg-Oy; Tue, 04 Sep 2018 02:45:37 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1LR-0005JX-Ng for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:45:35 +0000 Received: by mail-pf1-x443.google.com with SMTP id h69-v6so913264pfd.4 for ; Mon, 03 Sep 2018 19:45:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=d4uMapg7a40FZXgMObYbX05m8ShQ3XMWRXAdF2pRRos=; b=mlTOXR/F7P7ZYpJ8D5PgWw4Ka1zwBvryxWCinCn6sxgLAIkfesdqWDo+cYzqycpsBi a+X11KpVCq5BahL9+w9dhLIOXr9gKGs17WwbcCdjDxhEYR2S0yCpAq6jSFnENmvrxNEw l5BVnllMMsS0KQpS2OXNmJXrzgYGjclZqEZq4gaA/z3HraWoU2hpFsVSqoFBo4wJ0PqN 3KHsZ8sOgXjSAoaL2rEe1iVlIaP5J8QdbJBQLMTyebGyb4eLeyIRTaVMLwCVk8XxKERo bahqBiiYOODVAWzNKCqfnKD6OAc6hB38q6qVLBFedb6hBv4+u0Hl2rGYaP2Gvd7jWqBm UrZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=d4uMapg7a40FZXgMObYbX05m8ShQ3XMWRXAdF2pRRos=; b=jw2jK9V4q5XW6BPMzILF383UVffBqmdRVMHXTq7UVBFgx8Qyap+20bM5uQoXGRJrBc vCY2dmeHzrfE6WwaYVN221oNRJpi/eA+KIcmK7DbgVxHzw/8aGGguShDRwVowxaWD/hk xIP5Amk1qOolnLRTdTJA+OlnmD19eWdWwnxbUvUP5NsS0eJ2tk05VSepDMQs7DN8jD+A dS6S5ULb3pJ//ZGN5KuZmZeInAAE8ALgpEy9FPEdIJOl+rbhqrE/DgF4P0g1LnsAuIgf HwscfHQmDNKg0uTBudZZziU59o2yLdPXzmhJV0MbsBmCpVfE4WJnRtdJ2KfWjtl1ZELt LK8A== X-Gm-Message-State: APzg51ClbpM8BqlKbdFwggM1snu1RKCcbZcEXTNvsWOj4hbTFb4/UFFI 1qHVXYJgo1xlgPCAaHTxnxzZwDkh X-Google-Smtp-Source: ANB0VdYCjVJ7rPwK9bG8dXzZHAlvxl563unPs9NV910s0sktizLeMEaQiAlOvxWJ4/oEOQhEk/2E4A== X-Received: by 2002:a63:f26:: with SMTP id e38-v6mr28423403pgl.354.1536029131838; Mon, 03 Sep 2018 19:45:31 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.45.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:45:31 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 07/25] tty: mips_ejtag_fdc: Change return type to void Date: Tue, 4 Sep 2018 11:44:33 +0900 Message-Id: <1536029091-4426-8-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194533_805930_153E142E X-CRM114-Status: GOOD ( 11.88 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_port_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/tty/mips_ejtag_fdc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/tty/mips_ejtag_fdc.c b/drivers/tty/mips_ejtag_fdc.c index 4c1cd49..33e06b4 100644 --- a/drivers/tty/mips_ejtag_fdc.c +++ b/drivers/tty/mips_ejtag_fdc.c @@ -763,7 +763,9 @@ static int mips_ejtag_fdc_tty_install(struct tty_driver *driver, struct mips_ejtag_fdc_tty *priv = driver->driver_state; tty->driver_data = &priv->ports[tty->index]; - return tty_port_install(&priv->ports[tty->index].port, driver, tty); + tty_port_install(&priv->ports[tty->index].port, driver, tty); + + return 0; } static int mips_ejtag_fdc_tty_open(struct tty_struct *tty, struct file *filp) From patchwork Tue Sep 4 02:44:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965690 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KnWexuAD"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="LSyhtXkG"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B6D6lr4z9s4Z for ; Tue, 4 Sep 2018 12:45:56 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=XRlBu359RTyJ9+yEwj9k+gItadesZOdb8o7hvnZBc4U=; b=KnWexuADrjUyhFhcee0koevWEO Fy30n2LtXNtzBGBDVeI8jEg1mbjROwa+rSnMvZWXVUER71gEom/ipwVrU1+TRRibdDplS5K2rA7g6 ZPBwfWAG197c1lTWM30swcVUMpYjb0zQ5wzvoDxUwHOHF7R1MUC8mZYHNY5kMJt3FWGWg9uUzwKIs oLtRRmqDwWLRkMnoC2jXFd6VMmBOmBqGev6KnPgt1WBfR365NO9vFn22ZCWbcjGA5nnj7YAl2BV87 b/zvI8E2fczN3MqOr+4N+NELGVdHRnaeWOeR78oIrwDTSCoxfs3rUUzC7qPFoV4Ah10I0hvXfL1w7 9AeWDmvQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Li-0005Pz-7u; Tue, 04 Sep 2018 02:45:50 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Lf-0005LF-2c for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:45:48 +0000 Received: by mail-pl1-x641.google.com with SMTP id d9-v6so899383plr.2 for ; Mon, 03 Sep 2018 19:45:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5dM0xQ787rzw6bkqyfUjT3zjhB0YPJAJ51j5bAjS2T8=; b=LSyhtXkGxa0FU0fVjsQpau0if65BJFmvzTCCED/yoMtBCsWTOnczf44bQOG4WVD3fk bT5CCAsnyu0hAMzH85mdtgxH14TdL6PUQ1zver7BZy05sFf+wiPf/8I+q/7zE38P/9Jd IhyNrZV6oM9k8dcP2bJRKaTsooiRxqt9q7/8AgVMWoxqLoV/Hz8djpSqpBqpqZJmvQxQ 3FrLn2wBuQCXyxmN+IqBghprw+qPZeipg8ugBJVDSlOIm3/nRW0IkuAg8ycUsP8MrpIX TqWth4eQahCzAXARFo70j1Tvdj5cgsBSWRmX6jbV1gMaL44/FiWoFnrJSyklXMgO4wkq QXBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5dM0xQ787rzw6bkqyfUjT3zjhB0YPJAJ51j5bAjS2T8=; b=lEf/Y/CBqAavLqiAuCZi1lHn6/qqSUnSh0slh165lzx4p0N2iySksjEN34VilHDK7l J6DHq/okhAKb3/kNk1NcFp4PzdwoIpPN74DnrOAGwrdBLE6i1GUsnn4pZiD589XxvZMM 7+LsIrSEn0i2NiyI7h+qR/fqmN61G4Wf55YqCaqDGrFkuru7Sd497axl2mar+T5Pdjda gnAidTZKJNZiMaSqP/LGTj61EjMbQ+vXjtIxu9FdiNoQyh5VSfi+ZkNeUJbKfzP11ZPP idOljPHPXME+v52wXvEux0cU8Xk8aEV6m7yL/J7CXgJ5XOqfuefUPPLZJWv3luUkRJJ/ NKpA== X-Gm-Message-State: APzg51Cr3B73KB4um04xy22LD8HgVsDT2PrehZHGv7zSgcrNG1efwlvZ CvAJ5nO8Z4zb2IbUznPp3am0DKXQ X-Google-Smtp-Source: ANB0Vda07x392kbhxT9E/C+zoKxcW85Bqrj63tRUL/LAuoI3BB2I0JaA0GyiQM4GxiYzWJUg3ATX1g== X-Received: by 2002:a17:902:b68d:: with SMTP id c13-v6mr26735699pls.139.1536029136410; Mon, 03 Sep 2018 19:45:36 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.45.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:45:35 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/25] tty: n_gsm: Change return type to void Date: Tue, 4 Sep 2018 11:44:34 +0900 Message-Id: <1536029091-4426-9-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194547_122133_58CE87DC X-CRM114-Status: GOOD ( 12.95 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:641 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_port_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/tty/n_gsm.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c index 86b7e20..c52fa2d 100644 --- a/drivers/tty/n_gsm.c +++ b/drivers/tty/n_gsm.c @@ -2917,7 +2917,6 @@ static int gsmtty_install(struct tty_driver *driver, struct tty_struct *tty) unsigned int line = tty->index; unsigned int mux = line >> 6; bool alloc = false; - int ret; line = line & 0x3F; @@ -2949,14 +2948,8 @@ static int gsmtty_install(struct tty_driver *driver, struct tty_struct *tty) mutex_unlock(&gsm->mutex); return -ENOMEM; } - ret = tty_port_install(&dlci->port, driver, tty); - if (ret) { - if (alloc) - dlci_put(dlci); - mutex_unlock(&gsm->mutex); - return ret; - } + tty_port_install(&dlci->port, driver, tty); dlci_get(dlci); dlci_get(gsm->dlci[0]); mux_get(gsm); From patchwork Tue Sep 4 02:44:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965694 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ABKcFTJM"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="QhfZggvx"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B6N4YMYz9s4s for ; Tue, 4 Sep 2018 12:46:04 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=RX4oBINa6YofGmmtoPx57URVdVot7gF5yUY+5/vPK2c=; b=ABKcFTJMQV5L8IrPIwzAImlssZ QTsAK8LPxgI/l3Jiko22S9tnUCg4DP2BlfdQlWshprtB/WUP+g54S1npKE9+VEcJpgiAnqZsu4E7t YU+jIGQrViKes8MF41Kq85aQXwXcagWkQO0qYsI7v3WHoWvx9nRT4VEhCzpt3oU59oCZuH6tVbQa5 dzLcL9yspH4SIkLNfJB6ri0ujiKO93b+M4OBr+iL/bdGCH5FzDacV/ooIC1FIlIStngycvME/eHz9 ZFWtmhxolxrl+aM8xudUu2fWHCqYYSDGvJGyKYAG5lR0Kwc8nhW94oUAO37h5MxX7I+eMSaUU0lAf sluyt50A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Ln-0005Rz-EY; Tue, 04 Sep 2018 02:45:55 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Lj-0005N3-NT for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:45:53 +0000 Received: by mail-pg1-x542.google.com with SMTP id i190-v6so889210pgc.6 for ; Mon, 03 Sep 2018 19:45:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=dyMlBOGeR+D0F4OT1Om3Yr3zP9Ae/55Ycb8svx7U5Mg=; b=QhfZggvx83W0O89c3yAbEiVMTTX22/0zyGMRqaMmINsTlxO+cP0mDSJvTqhJWWs8Uc PgNeg0xfs8gRwIOvLy7yuiFv93VFaQhjvfqZjWv1dwM1zErUvPvlFN3Bbs1g2hjjXJAQ rDynjHDzeg32MCnqCx+yXuGdPnu5bQSQ+RfVAGyS+1q8KhF+gHg6lEQcJfUgW07HMeNI jReihwOr5iC432Htt06o1rVB4BgD6Kj0BPRlbZig+YBxuAjnWo3gwcF8J/J7nkNkamr+ yPAia5tAa2lSHd6yLaYHwOYf9Lmr537UREYwR+wVU5WdfFdrEnN9Jpi7hJOAWOdlwJFQ XKQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=dyMlBOGeR+D0F4OT1Om3Yr3zP9Ae/55Ycb8svx7U5Mg=; b=Z3YxBEBNEN/NJvc0CSBZFBYWzktxMYau1O3VVDg1YcnBQ8FhKRpJCpmd6waymYOZ53 QUG3zEN7Qcvd6orQO62pkopFADFA+76g429Y0XabapQN5kOPBo+vjvzGuFOmv4bjfk08 s7tltdX98ewhXk3RDFU4MkdD5C/SFrwBIw0PP8no1xE1eJH6614Lt26sA5exKw9sFAK3 uo6BJuStSewb4CCHs/LiWW2DkUqriUPX3wFx2nAk/NTeKEpzCWJ6koJhY59skPGnzzUj Lc68825cbC2OvQmI4pt1rrYVc/1KeOQURZf89FD1tS3ztWFbQ3U5bxoyuR5wIdZgDNOi caVA== X-Gm-Message-State: APzg51CYy81IZPKd01u6PFgJ5jV/SlACx8xaRQmW9WTtmGFrnUQ5N8ka Yyf2v+PGRhLJvvtfQEMjR5dHehj9 X-Google-Smtp-Source: ANB0VdbBB27REFELXmkSR3Ls51IBSoxSFVaXs34gzAubu6s7F3RUZ7R/r+859kfbcPLm7bwqyj9HKw== X-Received: by 2002:a62:3545:: with SMTP id c66-v6mr32459487pfa.63.1536029141033; Mon, 03 Sep 2018 19:45:41 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.45.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:45:40 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/25] tty: serial: kgdb_nmi: Change return type to void Date: Tue, 4 Sep 2018 11:44:35 +0900 Message-Id: <1536029091-4426-10-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194551_762059_73BA17D8 X-CRM114-Status: GOOD ( 13.54 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:542 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_port_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/tty/serial/kgdb_nmi.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/tty/serial/kgdb_nmi.c b/drivers/tty/serial/kgdb_nmi.c index 4029272..ed8f806 100644 --- a/drivers/tty/serial/kgdb_nmi.c +++ b/drivers/tty/serial/kgdb_nmi.c @@ -234,7 +234,6 @@ static const struct tty_port_operations kgdb_nmi_tty_port_ops = { static int kgdb_nmi_tty_install(struct tty_driver *drv, struct tty_struct *tty) { struct kgdb_nmi_tty_priv *priv; - int ret; priv = kzalloc(sizeof(*priv), GFP_KERNEL); if (!priv) @@ -245,17 +244,9 @@ static int kgdb_nmi_tty_install(struct tty_driver *drv, struct tty_struct *tty) tty_port_init(&priv->port); priv->port.ops = &kgdb_nmi_tty_port_ops; tty->driver_data = priv; + tty_port_install(&priv->port, drv, tty); - ret = tty_port_install(&priv->port, drv, tty); - if (ret) { - pr_err("%s: can't install tty port: %d\n", __func__, ret); - goto err; - } return 0; -err: - tty_port_destroy(&priv->port); - kfree(priv); - return ret; } static void kgdb_nmi_tty_cleanup(struct tty_struct *tty) From patchwork Tue Sep 4 02:44:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965695 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RVzu+v/q"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="bnO4l0Fl"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B6Q3YxLz9s1x for ; Tue, 4 Sep 2018 12:46:06 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=bra6tEXwPFa9epjnABSQqlRKBtlF187SRj7Po3kTO9A=; b=RVzu+v/qpvVLU8ADTWtW+PRul6 N8Pu48uX9GIacN0jwPLKjokutz0q8KLvJYX7ALMG9zmuFCitmhzP63uqrTlpW2a4MtgYjx9sxeEv0 9fdPwnKT9QwfGRgFCasgWw/Pr6vK2VDQP8HnQu1P/ocxWyDBzT+kiKCIPKAka7N87TZ2zn38dJG08 QcRMiOfnMfoADmFw/wsLza414IICHR5EKjrO9AXQUdjsJd7vIocFX7F+lmtfrn0qav+S7DuCyyy3I 8XhKug7fnOW9mGzHyru6knLaIb+sCjD1mRZWCUN/In9BUfy4hsi3QmayWPTNzXDP1wUBglUmbyMeY o/stTVzQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Lr-0005Ti-J6; Tue, 04 Sep 2018 02:45:59 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Lo-0005Oj-Qf for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:45:58 +0000 Received: by mail-pl1-x643.google.com with SMTP id x6-v6so878544plv.10 for ; Mon, 03 Sep 2018 19:45:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=qchqH0U+NKnSgzy5OmR5JDqm4OjRzNr3FPKLhiuVQoE=; b=bnO4l0FlSd3A2icpo/kTlsTkWn/ZlEY4nhsjN5kMBX2M35z1GeH3Fp8gMMCrc7CRGH s1H7IryVse3PMjNmL1Iag8RPmsg4h3/E3gN+ORMU6kg4aZ1zfhvSmKSUSkx+dCv0IXRS d9pksj15ontYb+Ah92cmixiRXepDQc7ZqXTkeT8Ti1iNM7nYPkyBWHR9HvDrlslI+If4 kqWTy+Zksdap9rZmRhg/Ti0hIBXf+V/cTZhk6dZDQnUbKt7XwDUzyknQIdMgcrnxvoMP 2OrcwxGD9OtsfeQtduZVeYQXCwlFhxm42afiy2TvOriuKLYx3YYzmlBk6rAPS4QGXKkA mx1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=qchqH0U+NKnSgzy5OmR5JDqm4OjRzNr3FPKLhiuVQoE=; b=Tpi2CMDXRTU3PWwk/Rdq13Q186+P40fYznol5agQC+3Pds934R5i2uoBshWqE1KDxz pewZaqmJbim1E0l1OMgq8gqjaQW8fknEIDNQ+emU2HvwEy1Hcwdeg6kcxiTqydBAs+q8 XuUiGuDQLTsvTWcTnnvWTHJhT52qyWCDx4YuMeiONILh0P8y8KaeUj00IDL2jmGiLvo2 +QBH06Zv4Ipg5KKEwgwRo1Gkcsj824vF9rlfEogA5gcb20KMrsZfRSB5UCrCUESMNplm vFNLgd2H4hl+sPfm3jk3TBLXFig++2qf/ezE02DsO0ROxMbc84TnyxQ2UEkJffO3djpw uFqg== X-Gm-Message-State: APzg51C900DWIHCUiWYY2KaMR3xqrJQ8Xe6N2e3AYoZOh+wBvrEhpUqb MrP6DMXNVeKriy2najbP1hGD3tlw X-Google-Smtp-Source: ANB0Vdayc89WAx5QvMYalBWiFf+hwaCiCP1x/b4rIi5gy3mles9JXL3EltbI3lYc1LsQREQWAmowtA== X-Received: by 2002:a17:902:5a02:: with SMTP id q2-v6mr31533319pli.253.1536029145329; Mon, 03 Sep 2018 19:45:45 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.45.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:45:44 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 10/25] tty: synclink: Change return type to void Date: Tue, 4 Sep 2018 11:44:36 +0900 Message-Id: <1536029091-4426-11-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194556_890218_0308B2BA X-CRM114-Status: GOOD ( 12.39 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:643 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_port_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/tty/synclink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/synclink.c b/drivers/tty/synclink.c index fbdf4d0..6e7e4d6 100644 --- a/drivers/tty/synclink.c +++ b/drivers/tty/synclink.c @@ -3355,8 +3355,9 @@ static int mgsl_install(struct tty_driver *driver, struct tty_struct *tty) if (mgsl_paranoia_check(info, tty->name, "mgsl_open")) return -ENODEV; tty->driver_data = info; + tty_port_install(&info->port, driver, tty); - return tty_port_install(&info->port, driver, tty); + return 0; } /* mgsl_open() From patchwork Tue Sep 4 02:44:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965699 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lddBZ/Q1"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="KPzUgfkz"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B6W5nnGz9s4V for ; Tue, 4 Sep 2018 12:46:11 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=HOw6CXCprMXTRD5K2txBdTmw6ZyUFUZ9TxYSSAgc1r0=; b=lddBZ/Q1/F29OaaofBdExfCKZ7 GuT/yHLrPeJM1lUa45zxSxGIEOgHY/Cp7mpXrpQqPHYzIQGrZg9XPxjioTGvqsI+lDv5FgJlFWzqk Q2jajD3F/uhFwibSHJxgkDq8X2Eun2DhEKQKV+Tqk4BMjKD+/IPjSR1tOUQGeiNfL4Y1j5W5woOEc VjlWR/s/Ekf8rXs9AALGOIC7TaHSiu55zKG3IqusvptChnvkZ9ke3aUmJNgi8WGKkzcz0CYfDz3sb cFHtV29RB8r+P0kI2KmzP4+CewhoLexW5pZfgf9Ztne4GvZy6KCfWzLnYuXUyWBKG8cMLuObKhek1 Wars0Fjw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Lw-0005Vd-5c; Tue, 04 Sep 2018 02:46:04 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Ls-0005Py-H7 for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:46:02 +0000 Received: by mail-pg1-x541.google.com with SMTP id 2-v6so893260pgo.4 for ; Mon, 03 Sep 2018 19:45:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Rc/M0zTwkM5DtzotXjyB3OA+o8WtWUoAU9ZFvniXG20=; b=KPzUgfkzoUz0PqjZeY1nZEB9kP+7qnTDhqdQ7uP1OYJIguHxB1gC4fz8odMm8vs7fq gyCDeZUYvFDOiLyW4PEfyXHRZMHeG9G4SB0KmWOBMnaz9Bkzwyc/sUw+D+6CeCnWUlkD ZDrmCfFV1MnGRCwMGuFDkXCYPW23nq+/pdXfY/DAa3k7qIxEQkK4Pgyjf1ZnCM3r7/OF OoFM6/cEUnSuJ3hyHurRehpkJkLXZ001Jfe05fh0pTHig+mdgw0ihtuiEUQJrWl9I+7f OgXG/Tf0Iw5l/WD63ZYzSZIDEcmsPxt7VZTbzZ7/R24CbhAxTnZyTvohKrJu870O8J01 SbIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Rc/M0zTwkM5DtzotXjyB3OA+o8WtWUoAU9ZFvniXG20=; b=Ve7p2DWmE8heM2Xy6xDv0K3JtN2rP3pvjpYpa7GWhDX6CM9U0rkrBoo3rxmvJqRO0b LiX645iO4kkF/W0JArjGmiMFyxvv/8/PbrrNO70wARjKvS/dHdbUImAhph2D0ba0J1BB /k5wiCDlTY/MPulGGk0FSPsfSmGNoMXsz1wiL5WSR7hpVU01nl/nXPMTmLTIa6hTJlUH Ndgmf+jL6oUATgmf7ZvV1Gj+3VU5j7PMRznHEOBrHtyMRH0PX7F8kZKok1ifSibQ+i8l VHjscfblZDbKCTYJko4KolEX5V5CemcqLSbW2dZIVYRzq0GQILsH3QVGH68BHuToYwEA xtZw== X-Gm-Message-State: APzg51CnY57wtQMzhHo+s49aUpRtpKHqrDfh6YCoIc1ThXkFNyh7d+g0 98COeKL5O8ptDnk4Lk5aw+yoB0Hc X-Google-Smtp-Source: ANB0VdZRuilWHvSCLGZGpfFX+Bw85dsSGFudReDzlQqdW+R9VzYYy23UMe3/xdiQ/g/NoJOsHg+bDw== X-Received: by 2002:a62:4299:: with SMTP id h25-v6mr27083940pfd.73.1536029149780; Mon, 03 Sep 2018 19:45:49 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.45.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:45:49 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 11/25] tty: synclinkmp: Change return type to void Date: Tue, 4 Sep 2018 11:44:37 +0900 Message-Id: <1536029091-4426-12-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194600_599594_C363F6F6 X-CRM114-Status: GOOD ( 12.45 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:541 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_port_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/tty/synclinkmp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/synclinkmp.c b/drivers/tty/synclinkmp.c index 1e4d5b9..2d99a5b 100644 --- a/drivers/tty/synclinkmp.c +++ b/drivers/tty/synclinkmp.c @@ -734,8 +734,9 @@ static int install(struct tty_driver *driver, struct tty_struct *tty) } tty->driver_data = info; + tty_port_install(&info->port, driver, tty); - return tty_port_install(&info->port, driver, tty); + return 0; } /* Called when a port is opened. Init and enable port. From patchwork Tue Sep 4 02:44:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965702 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="f/o8JRtN"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="KsA9keTe"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B6c5ZrDz9s1x for ; Tue, 4 Sep 2018 12:46:16 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=7MAKE+OfWZaAXK6Csb2l0jCiImEpFekabaihbFaGqFQ=; b=f/o8JRtNh6O9faEoKsLcosFdrE 33Oxqx58F6pDkryZdVzPXiK5h+2SUeYkZyduhpAqRzDBpue/QIq1tbZAT6q+B8i7bhwV2D8hAkcdA swZCufwtkFbGo1KQQ8qNEmp2jEim6F+brS5nfFOUrBaHrmuM7c/Xe7p6lzGrlbHnenFbsdi1oLpEz C4U6zNu9sgjqvnlTKUwpVUf1mK9nMXQy0d/bDyb3/knPbLux9WYBYFkQbblJAoSPYJKfLWsVOPpi4 yTUW/1rFsH0MHctwQOpADckxsGjgGYHU6nqRZcNrk8QwktchgDaaZGU+cbO97vHgmNgAnI+p6kwR6 bpnwxJ6w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1M1-0005Xt-IO; Tue, 04 Sep 2018 02:46:09 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Lx-0005Rv-8j for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:46:06 +0000 Received: by mail-pf1-x443.google.com with SMTP id k21-v6so895605pff.11 for ; Mon, 03 Sep 2018 19:45:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sBHYUYXanNFuc3sJAGyPoTQKmVfJwobdSV5M3vVBguw=; b=KsA9keTen4eBHIGRYysr/wKT6/LJFm9JqHY9ek6MGQzsHg0AGki2RmYG7mpAnnmqk9 XtL/JoDJHeIdS0L68xXxLOQvjjmAUff7norRMYp13oHhmQSvZMa0RzSNUy7oGt4w7Oqe eKE7Bx1OXTvm8NERoDDZ2ws5e95ecu9kizSTm5t19pj48+cD7hKBS/FTTRWdTGCbbqHQ 6p2QyPAO+MJmFAzQd7ovr+LZ9QM1fkma9y134UacD/JHly7d085juVVGcyJ2f6/cJiY1 9ozc0uEX4kSQixpnxh+R194lLrXPtRqJNZFYnIqW1yMYcfULQsSw+ZCvOviNN+N+ejK8 lPIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=sBHYUYXanNFuc3sJAGyPoTQKmVfJwobdSV5M3vVBguw=; b=oJYIsco81jQOMRzZxFCLRODVBK17Sm7e+YlMw59m3qkoktzc+iAquW5xELYXpkloDF bEPghdmgmDeeNveB4wcJ7/f7ueunQuep3z1WhsfmnivmYMAue/OJ3lGrepTfQVeQPyaz fA2t4LXRGR8LbXRi7zEhhnm8LGHirUQ5k1gxTwKOlEdiedObDW8Yibl0yFLIP8mROgy/ qAxOHnax6Ibd9Il7ZWILL6CNMiftLA7afxT3iHm5A7oDnleqq1Kv42xeXmPgw3LBCDFE qHQ/o3agojE2uZXcvURuMgFh1wy8216ft7UIYvma+gSa0yJ4ZxY0cfYtb4P9zmEz/hFv 7QCQ== X-Gm-Message-State: APzg51Bh8UGqhGKrAQQvzPj8h5JQH7Oks1ZmZwoW8LmmabcmH71RRIh3 wFbrsx2Su4aqle/Gh+/JLpk1x/wN X-Google-Smtp-Source: ANB0VdYzCBWMVILtFi+R/GhzoXAy2DyPqeF+LZTCXH2uzP/uxpeLVWyVk2MZU2LfTeQYPdksyl0FSQ== X-Received: by 2002:a62:219b:: with SMTP id o27-v6mr32386618pfj.235.1536029154665; Mon, 03 Sep 2018 19:45:54 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.45.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:45:54 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 12/25] tty: vt: Change return type to void Date: Tue, 4 Sep 2018 11:44:38 +0900 Message-Id: <1536029091-4426-13-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194605_348822_9F724EED X-CRM114-Status: GOOD ( 12.25 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_port_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/tty/vt/vt.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c index 5f1183b..cc72254 100644 --- a/drivers/tty/vt/vt.c +++ b/drivers/tty/vt/vt.c @@ -3222,10 +3222,7 @@ static int con_install(struct tty_driver *driver, struct tty_struct *tty) goto unlock; } - ret = tty_port_install(&vc->port, driver, tty); - if (ret) - goto unlock; - + tty_port_install(&vc->port, driver, tty); tty->driver_data = vc; vc->port.tty = tty; From patchwork Tue Sep 4 02:44:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965697 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ybjn1+Tl"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="kXis77Ik"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B6V08p9z9s4s for ; Tue, 4 Sep 2018 12:46:10 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=wjQE7a5jRZbCFzfEAxatPtV0W4yoXP+YVNO544h9mfE=; b=Ybjn1+Tlde6BrydFYL1vF79no1 hX5fHYsJEAR4Z0W3qVIpOTS3u2qRxcPzt44kNiWPKbxK1ujRzD/BULtbRSCrVcI3Z1h+H8/VjOYI9 sxUsBWy5vSUAnVLSFwakidgYRrtUEh03qhdRY2v6vaonEaAN09f/Bvxv8G/Fr+jrGwDlsAUEr8tNK SUUYXNNUi7YeNSb3947xNo3c/DDaXXaX7LntWH5V0g/oZqZzVCyq1LdWELNwLW6s6+IGkaHhrniXO V8IJJWfThg9eskNmL1+CG5EPrXeFTxqMjE2e2ZoA7Vdsct0wkAzRH84+t53cj7ZzzUtxdJaFhrmn6 qHGhpJVw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Lv-0005VT-PT; Tue, 04 Sep 2018 02:46:03 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Ls-0005Ts-Gj for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:46:02 +0000 Received: by mail-pg1-x541.google.com with SMTP id x26-v6so872682pge.12 for ; Mon, 03 Sep 2018 19:46:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=gCk8mWHnhtx2R8v563AkPHm/bECb7B3+8+2bdvc1AQI=; b=kXis77IkUUCXLOartff6QRvsXnQ25XPDuUeq4NLa6kShitU3rTg1KXOS5kIBcHGdV3 uIPgk8c/PB3YkO1Yk+rSkISlsX9/dTP8O06eM9sApMgdu58f5XRJG3xvL+L6d7soywPY 72fk5vXI37rdGTXiYZdeztpglI9VKOrLLnUk3PFIbv/8SwC7sUBTdFQBeL8rDQtnu5fK Uu0/mvPRWnLCKqSe3fH5G0mLiAGDWJsZrKK4F57wQ7ExDL6RboOqWrjBD7Hg0q1I9sg8 1kRmSrUyAckcgyhDfS8K1JjHLLq4YLW+s/d7YZecVUSl57pUVNDHcwXG/gCbNr0Wg6Du nWYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=gCk8mWHnhtx2R8v563AkPHm/bECb7B3+8+2bdvc1AQI=; b=l2/266E/9Y521tk4MZR8N/jQLNvOipiwBpleKYx8zTBqlg4dT6sLz87S37GgEZZK2l XmSiCGe8Sypj3g9XS53wFeMivNyLVSJ8V8B5251wP9BtSCGLzwdl0Z6NFJhrjDNX5zRa dKIcsqBJfsVm3KUle+DzXD6qyzO7B/41+QffICQAEKEze4pJZRWNDv3WziG0To32E4Eh eL9B4jYKDFkl2mMOYiJ+pKhkOZoK52g3ccGSmLhbBeUaOfWRHZPd6tpF4MgBBFESZrNR t2NTsbR3gESu/qERpzPRifc8IKX0WgUAbDpDc5mckIrAdl54g1Kef3X8ad908oklWMUp Gw5w== X-Gm-Message-State: APzg51ANkiWPD+Cu0NmO/UASJxMly/PftrBUvqVa1GhPXQmGTl5KUonv 2J7Ijua4j/ZkphSZKvBRYhXJ6Udm X-Google-Smtp-Source: ANB0VdZB7tSPhGLbAj1h6wk3kMlbEmfk2KzDAPBLyJSrvvV8C6RnkBEc3JPAd3M798RwB4lO7UbXSg== X-Received: by 2002:a62:3241:: with SMTP id y62-v6mr32586471pfy.4.1536029159358; Mon, 03 Sep 2018 19:45:59 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.45.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:45:58 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 13/25] usb: xhci: dbc: Change return type to void Date: Tue, 4 Sep 2018 11:44:39 +0900 Message-Id: <1536029091-4426-14-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194600_584754_C77A6BB1 X-CRM114-Status: GOOD ( 12.49 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:541 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_port_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/usb/host/xhci-dbgtty.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-dbgtty.c b/drivers/usb/host/xhci-dbgtty.c index aff79ff..18d661c 100644 --- a/drivers/usb/host/xhci-dbgtty.c +++ b/drivers/usb/host/xhci-dbgtty.c @@ -174,8 +174,9 @@ static int dbc_tty_install(struct tty_driver *driver, struct tty_struct *tty) struct dbc_port *port = driver->driver_state; tty->driver_data = port; + tty_port_install(&port->port, driver, tty); - return tty_port_install(&port->port, driver, tty); + return 0; } static int dbc_tty_open(struct tty_struct *tty, struct file *file) From patchwork Tue Sep 4 02:44:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965707 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uQJtD9wt"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="QaY3Jg+L"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B6m57Vsz9s4Z for ; Tue, 4 Sep 2018 12:46:24 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=y/lqw4vt2PGQHHWUGFKCNP+K/NQB7NTwUhUJeVDUAEY=; b=uQJtD9wtt30l06iXk1IZ3O0PDL d97SpDmL3hK9C8gTF97rRqEr45cpft6gMw+QCynwAxujEPhFVbBWB9yyeiuGvGLYi6ysV/n/nHfO5 BZSMLgon9em+LHYbr/GpV9dpoVJ83G+I2KWmZKLmrPEEpxxD+DwfyWZMXdImvf1aP7TG87sNh/kHB aolrfSmTTOivs3Z4FnW5HvmG6QvahnvlZoY4CvBxheeaLQ0AsRA/pC49Vc6a4UFDL2vW7OfRj7VIy aPQcInJnWl/ju0Wb2m8jMuGg6hJh05Y6FfP37onHg0OSvOOXfeW63dv8e/KD++LEZUGrDywnEQLol 7icsHd1Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1M9-0005aF-7g; Tue, 04 Sep 2018 02:46:17 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1M6-0005Vh-AN for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:46:15 +0000 Received: by mail-pf1-x444.google.com with SMTP id k21-v6so895751pff.11 for ; Mon, 03 Sep 2018 19:46:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=HF0PCC9uCoqxnQ9gpvOU6TDEMKqHeKkM4XeDXQDJXAM=; b=QaY3Jg+LUbi6LQ/aa33tuRoTX/1JjEd63W8B2TSxWEL5lJ9KIpQD5gqrtHlt3vxnMO dkDNbosJk4FTRKImHBopXlCVuo0WJhPiGAkd9j1VhVNi3nt70gqrZUygbygxT9dPsOE8 6gkWuI0CAvYU1CE4NUzK4cQLbqNzFZiojdzR4JvhQP51Mw+r/t0E5Xl4UPJqz1pTmvqM /m/RFtkfGSGGIFDNDtJZGrb2yWWCVsUNCoC/ZJ8bQj/KAafbDyDVZ8olNfuy9viHt5/7 QQU/z+5fQ/Cjh2wSF2XGIU5fNMiSfnvKrM49z4nu5uXu6WCrztkdaQFUQ1LMGwW2dOxc RyxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=HF0PCC9uCoqxnQ9gpvOU6TDEMKqHeKkM4XeDXQDJXAM=; b=fhXn9v3Hzp0pu2drIqbR3LhGNB4JtpjzPlxFqj/CT9k8/ZS1pYcPlNIwMeMBNENapC EAg6OrKAT3kg8PYok+9e+r4+gBtvIeH35uw420JfNIHospoWMRuzqcbSUV3izCjZxqX1 rVCy+8xCGbZdZMuDiwYCCl08Sn/J3rlb8vLwdPSBDgdzP5UiF29ZJeiWFcRs9V1gMHne yXkyFpf5HBevhyiXJ/nKssc6vjv1w4uQ1K5FYBM7ja0W8MWGRm/f+SY6Ys/yanT45FBb acw3GGRwu7epi+7Q0tOzEtHRdKKvs9ntM0ifOgp4xG/YOVZv65CAZu9qtjIFo28cFBOS d5Pw== X-Gm-Message-State: APzg51BX030WVXP3OhjhFMMip4t3K/XY7kpg7RVq4+HBmHmDjv+DJM2p cuBBbv2BTTBhVXPDbNwOalOQvk6H X-Google-Smtp-Source: ANB0VdZfRaC9KxMLpiDu8nDLsh6bt+ua/83a4QRnKvVM2G1JGINXIqflEQa52rywQJCcHrRJRVjZMQ== X-Received: by 2002:a62:7a01:: with SMTP id v1-v6mr32385003pfc.153.1536029163682; Mon, 03 Sep 2018 19:46:03 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.45.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:46:03 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 14/25] Bluetooth: Change return type to void Date: Tue, 4 Sep 2018 11:44:40 +0900 Message-Id: <1536029091-4426-15-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194614_376928_C982824F X-CRM114-Status: GOOD ( 12.60 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_port_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- net/bluetooth/rfcomm/tty.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/net/bluetooth/rfcomm/tty.c b/net/bluetooth/rfcomm/tty.c index 5e44d84..b654420 100644 --- a/net/bluetooth/rfcomm/tty.c +++ b/net/bluetooth/rfcomm/tty.c @@ -710,7 +710,6 @@ static int rfcomm_tty_install(struct tty_driver *driver, struct tty_struct *tty) { struct rfcomm_dev *dev; struct rfcomm_dlc *dlc; - int err; dev = rfcomm_dev_get(tty->index); if (!dev) @@ -725,11 +724,7 @@ static int rfcomm_tty_install(struct tty_driver *driver, struct tty_struct *tty) set_bit(RFCOMM_TTY_ATTACHED, &dev->flags); /* install the tty_port */ - err = tty_port_install(&dev->port, driver, tty); - if (err) { - rfcomm_tty_cleanup(tty); - return err; - } + tty_port_install(&dev->port, driver, tty); /* take over the tty_port reference if the port was created with the * flag RFCOMM_RELEASE_ONHUP. This will force the release of the port From patchwork Tue Sep 4 02:44:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965706 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RRRkkhvM"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="PXyyYhk3"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B6m0swlz9s3x for ; Tue, 4 Sep 2018 12:46:24 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=fxzDw0W6OxKhLfbYIIgJG7aCuXg/7XPOEMigpIYZYLU=; b=RRRkkhvMevE0AtsKPskySeySmQ B1N162Xqgt4AaVFFeLNvETPac5LSjjIYh6jIFmCHppfFN0KfUu8xHhjQDLxiA7c6CqxVLpoJ0YIxi sZQ2KjHt7271yDHghPIc4FOGKH6zigKbr+7tPeap7b+V0cZh/2PfR1ekmbd5I8y0wqRqVxoXj35SZ pv7y9vrCdwZXqMC3KrZwDRMmNKzx7mevYK0iRXYCZj4U66n3eVK1o9tAOb4R3Xxq3hN4JOt3OhCla fUUra2ZF97Q1EFRQL357GvDxEXDuBoo6vjvohQ4861pbwBmnVptheFou1E7lTfpAPyXnFMRlrffTv BU3KNOfw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1M8-0005a8-UH; Tue, 04 Sep 2018 02:46:16 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1M6-0005Xl-AA for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:46:15 +0000 Received: by mail-pf1-x444.google.com with SMTP id b11-v6so916392pfo.3 for ; Mon, 03 Sep 2018 19:46:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=u9q+PugGhdQhGarX8q9kMwfv+0Mo7mXRGcKR8a2BaTY=; b=PXyyYhk33i805zIS2aA59nRTGDtwF+CDarkOC9F4jkZYmUKdYi3GgXqdykMhJORpnx 1PuOviGt94zEDjZwLHox2pgql6mjOuAamxup/lk1vHjIh6KQlPtx9gJTcrzNTfDMhaV3 oaJg4n05S4mifCF+h8YtbxMDK3NsEiPNSRxRcQJXsY4diejj2ZI2T99BJZOPLcpcfxnO Wals1yRiAB2so+4HbbhrTpEtpNfcLYZ/cfkQw1CUZrq5xlZGYq6p+fOp/Chx0vOYCbCg D709/UnvKJvNeIw5bWlOGlGuiHFvpLRhg024l6wHctO6rXG6ZqtjE1JVPIkC92gj1/Ea Rq6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=u9q+PugGhdQhGarX8q9kMwfv+0Mo7mXRGcKR8a2BaTY=; b=OhNi3vb6SYWPI9uLvrFNPrctfS31RwYxJlPYcKXgTx+NLMA/qpeWSVGoxPWk8yCPJQ luAROzmJcLiRTEFvidYeowK0s5xeUQ5HlulWAWFl+086DUITsyJwpV1aQRivVaLYAHAs 7HlX/5TEhwuLa5+ZoJ8kk6I86iMvfd/mivo7pD0x25v5dcZqmnj724zA/4/YtyJSh093 r9PSxj/rR8VTZv2vZ0roeHdqp4lIn1aUKK0Cpzm4yRRXcMSKTCr0FKvkigr08giWKh23 QN+6cp6XfBFCkjOohcluinALPHgvEGMv2GFhvx8v/vsHx7Iq1zrz6YP2U9m2XfzMhzSn Ok/w== X-Gm-Message-State: APzg51AxVON5cFBd6SMa/eKA4jiwbrrSQHVupf4wIpY6JpQV+Z23pMs4 s0AjZgCpdDyOm49wr4HwWX1SivNg X-Google-Smtp-Source: ANB0VdbsLJ9z5I32SoZw2TFN21sIPiArDJxjlR6vvLE40oQnc0l5LaGiT8TkNtPPo/MJ5vP+6ePh4g== X-Received: by 2002:aa7:818f:: with SMTP id g15-v6mr32498472pfi.71.1536029168566; Mon, 03 Sep 2018 19:46:08 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.46.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:46:08 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 15/25] um: Change return type to void Date: Tue, 4 Sep 2018 11:44:41 +0900 Message-Id: <1536029091-4426-16-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194614_376473_D447E88F X-CRM114-Status: GOOD ( 11.76 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_standard_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- arch/um/drivers/line.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/arch/um/drivers/line.c b/arch/um/drivers/line.c index 8d80b27..47058cf 100644 --- a/arch/um/drivers/line.c +++ b/arch/um/drivers/line.c @@ -338,12 +338,7 @@ int line_open(struct tty_struct *tty, struct file *filp) int line_install(struct tty_driver *driver, struct tty_struct *tty, struct line *line) { - int ret; - - ret = tty_standard_install(driver, tty); - if (ret) - return ret; - + tty_standard_install(driver, tty); tty->driver_data = line; return 0; From patchwork Tue Sep 4 02:44:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965712 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ejFwSDyf"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="aNi0e2LW"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B6x07cXz9s3x for ; Tue, 4 Sep 2018 12:46:33 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=4EgphAq9K5hpe+qYjWQBeJzhOixSqW2ENb86WruXEL4=; b=ejFwSDyfvJrRYWkNb4SCP7zI0s ua/S1dfjreZcfHLy0btL5LbiDEvt4ybDRPOGbbh7mKkUpTfAKbwZ42hUeM0NMF9+O6V76b4BH0qA/ B3oBIoSVyw5uEABiZNdmS1VCpAyrnO0ebPzPUGClUmJeyNFto63WSbLJh2t/mAtnddnCNljrY2qdN byo4QMsFr7LoOw3Vix7+GW61kvtWgtw1Ga2Y/wus+ntlPaCVUAi6pPGsleJdMhbfiV0rtdnevwqW5 cZ9SoG4g2MN1DDQZJVMDAJeE/5neJfSZFzL8wgegtB+O0gJJ79jk8lNYB+I+Wo222wk7B9euFZX9+ y1qXF4JA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1MI-0005dO-HQ; Tue, 04 Sep 2018 02:46:26 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1MF-0005Z5-Cf for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:46:24 +0000 Received: by mail-pl1-x641.google.com with SMTP id s17-v6so885868plp.7 for ; Mon, 03 Sep 2018 19:46:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cFthBZpqEg0o3AkyH/cDmTIfBXszV9IUyle8uuggvS8=; b=aNi0e2LWGTCNFKhvBzvp9RSWI4K8sFoCffRPjC6GBPC60fswx+xdzp5nYULURssfvj AcmU73szVeL9Yon04e+s1hDKOPu5H/yUiF8WMigIbAUSITUPXobWi2u9ie2USkPGiiYc VUzPOBfIqQ5XQNwR0AhTNcVqTJZFUh6UhEHjYY3PiywCRjwuBQiSdtgm9JQu3C0ufaNX G1PG9H8xMEiBCz8nXOTVrK9HJs+g9QiNC9Zp97wshBBijnkkdgio1vJyJ3IF6Koh4Bjg V366MG8eIOzCyof4CbYJjsswUYUnO8dewNQk1eqNtvCNS6eZUsOw0G8HxTX+cdLTAnGp 3jsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cFthBZpqEg0o3AkyH/cDmTIfBXszV9IUyle8uuggvS8=; b=tPTEFZ4qSg2np7aD1vVKtXsEgEMmLhFzI3FPec0uBZTwCAkuXEkozmMIX7HeWiXSKE 5yhdu0E4LoHvjjaHGmB9aIBwVzM1gRuZEkwXYhO2tYV2T2PynNOIOqRyoCWShT3bfjQz 0246r7lU8tT8LtjkBKDWuzHf3RAWz1MBBODFG/Ws0jSd3gPiQVHKWJ3hMqQvWy4tFU4O jHPcORV34W/zrr26E0y9cwh5omvj0Elkh9nzDTeux3aUjWgKCy38u8eWVN/nYLXLvye5 4daGgG33qZNUK6FZD5RrRrjQ+R97JSAcSu8HZ2TveUSj6+UFbeJNTAdZwhJjCdSBt3zo n9/g== X-Gm-Message-State: APzg51CUSVOVS6hyxyutgMZI8g1uoXjVO8TVYTWb5KvNYgFii7fnXWee 3Q6p8XH67ZbNyID0UQ/f5GLeuXmd X-Google-Smtp-Source: ANB0Vdb/WRa4NVDIg3GfWcusn9xJSZ0Ijn/aDoPmw+y9Ebo2U5QHHaSskgvFPR6GkxGhJ7z7pDh+Cw== X-Received: by 2002:a17:902:8a8e:: with SMTP id p14-v6mr31457955plo.213.1536029172827; Mon, 03 Sep 2018 19:46:12 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.46.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:46:12 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 16/25] isdn: capi: Change return type to void Date: Tue, 4 Sep 2018 11:44:42 +0900 Message-Id: <1536029091-4426-17-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194623_445414_A876D177 X-CRM114-Status: GOOD ( 12.87 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:641 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_standard_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/isdn/capi/capi.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/isdn/capi/capi.c b/drivers/isdn/capi/capi.c index ef5560b..08daf3a 100644 --- a/drivers/isdn/capi/capi.c +++ b/drivers/isdn/capi/capi.c @@ -999,13 +999,11 @@ static int capinc_tty_install(struct tty_driver *driver, struct tty_struct *tty) { struct capiminor *mp = capiminor_get(tty->index); - int ret = tty_standard_install(driver, tty); - if (ret == 0) - tty->driver_data = mp; - else - capiminor_put(mp); - return ret; + tty_standard_install(driver, tty); + tty->driver_data = mp; + + return 0; } static void capinc_tty_cleanup(struct tty_struct *tty) From patchwork Tue Sep 4 02:44:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965713 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jveXi1mi"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="PoR1kxUT"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B7219v7z9s3l for ; Tue, 4 Sep 2018 12:46:38 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=sz+Gcix5iRAEfNRduS5rNmtt0GZy+HStXtIw3x2PjcA=; b=jveXi1mifuPlsQM9z4DxvgMoYp jIfpd31AWt15Sg/iXxsNGzIGU7+lwuMclZdAuM+L/QJNlD9IhXZPXGjOi674RCvHhOodrQ+BjICbR Cot2mGK+rb+z+bJM7thhG3ygkXaKDNNGL5VCVfzEPd9A+aeH/tjBJO9h1oDz271YdQt20sw1wDZXw d0vYKAwvl/ELggi+KkOUDLQy+bfW+idVv9An5spXW3CRv+LntLyMYmHDAVbETvScGBdjuZOMJBPaH Byz6h3TX+N5eD2qv8ZfbukfoXnCdElhfQTbohvzjq4T6wHcs9kTgfAceAw9IMRLgJW6+sPtN3D6ms gnqFeBOQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1MN-0005fl-LY; Tue, 04 Sep 2018 02:46:31 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1MK-0005aT-8V for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:46:29 +0000 Received: by mail-pg1-x543.google.com with SMTP id 7-v6so898655pgf.2 for ; Mon, 03 Sep 2018 19:46:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=frF0BaIgA9XPi5C/PpMcQkh6hQWXokybPdUOPQVwUvU=; b=PoR1kxUTkBYKfsf8gjErzPf/Pu9K2R/qFm+Lzt77zWDG+DvqiU2rxda1FCFeqcahbh m0jLednzMRN07iUV8PGaIwSV9FAzhfwPKdipmaYJXZrdYQkOdOApGMlUsaMqDQIL7NYX jVKdLi2XBl1gTkYRnD6+N8gmvRwlJfcwHav4N8LJVd/qNZI91tQ/nV2xafSDJDbDkD9j fidWF4JoyEg6Bq5uCvd/LMqrt55Mdb3b93CEmp2wOIV2z8lcdcfTVqzK+y40tJN77Y74 wD14J21mjlA112sf+3U5cxwvo+Hko8n1PWSAjRIo8lYiDiNGTITnlhl4IH0OEvihrRwT 13pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=frF0BaIgA9XPi5C/PpMcQkh6hQWXokybPdUOPQVwUvU=; b=G/vx8c/ONq3lfTJg/u35ucjOwhbaWJF1hNgSbwMKxqHOqbhqZUO6BLZp2OeEYAyT35 sUOwa0R8AL+5PfT3vY4DMzhhMMVSzDtqQTvR/i93dWBQbOPYWg1Wx0a9O8G3wfMsPA/K +XWX+G6Fg9bbLQ7QC10QLAdlq+8LsdRQPXWxhRKqDGkftawRk5iSujPYGM1hawWOX4a5 OWKs7F6QvCo2TLXXZAEo6hs4TwwJjA8PZfls0oMqa3kALu+sCe8oIWYfPvsCCOULik6Z G3f23hC+66gBS2X1TRTihtwUO6A2hrtYf/w0OoCQGvs7MBr+A+UQaxEEUBOveLlOi3/Y bgYg== X-Gm-Message-State: APzg51A2LrbxnFKaGgN2mszeoPpl9qC3aauTcMV/g1BQIqm+y/2hurvO a1ZLx7WomiUY1g3Gtv+4oAPY616A X-Google-Smtp-Source: ANB0VdYwJILszk8CVOneCeT5Z5FD7aPcC3d5ENYis8nsMPxIL+h3VVc2CwriUnl9EXedOjNXcieVrQ== X-Received: by 2002:a63:e443:: with SMTP id i3-v6mr29624135pgk.381.1536029177486; Mon, 03 Sep 2018 19:46:17 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.46.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:46:16 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 17/25] misc: pti: Change return type to void Date: Tue, 4 Sep 2018 11:44:43 +0900 Message-Id: <1536029091-4426-18-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194628_339595_7A9B7B7D X-CRM114-Status: GOOD ( 13.22 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:543 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_standard_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/misc/pti.c | 28 +++++++++++++--------------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/drivers/misc/pti.c b/drivers/misc/pti.c index 41f2a9f..5c885a1 100644 --- a/drivers/misc/pti.c +++ b/drivers/misc/pti.c @@ -462,26 +462,24 @@ static int pti_tty_install(struct tty_driver *driver, struct tty_struct *tty) { int idx = tty->index; struct pti_tty *pti_tty_data; - int ret = tty_standard_install(driver, tty); - if (ret == 0) { - pti_tty_data = kmalloc(sizeof(struct pti_tty), GFP_KERNEL); - if (pti_tty_data == NULL) - return -ENOMEM; + tty_standard_install(driver, tty); + pti_tty_data = kmalloc(sizeof(struct pti_tty), GFP_KERNEL); + if (pti_tty_data == NULL) + return -ENOMEM; - if (idx == PTITTY_MINOR_START) - pti_tty_data->mc = pti_request_masterchannel(0, NULL); - else - pti_tty_data->mc = pti_request_masterchannel(2, NULL); + if (idx == PTITTY_MINOR_START) + pti_tty_data->mc = pti_request_masterchannel(0, NULL); + else + pti_tty_data->mc = pti_request_masterchannel(2, NULL); - if (pti_tty_data->mc == NULL) { - kfree(pti_tty_data); - return -ENXIO; - } - tty->driver_data = pti_tty_data; + if (pti_tty_data->mc == NULL) { + kfree(pti_tty_data); + return -ENXIO; } + tty->driver_data = pti_tty_data; - return ret; + return 0; } /** From patchwork Tue Sep 4 02:44:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965716 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XYzDs4ZV"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="RZRQSv09"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B760K7Mz9s1x for ; Tue, 4 Sep 2018 12:46:42 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=bR1YPguMBxvkOmFF7d/hxfbVT691Z01Dr0sTgMHfp/U=; b=XYzDs4ZVGdgfIQbAjs75a6BI3b cQMqRIg4AnLGjQE4m95u3gUAcOFGSSrpBl8HfPjaxcJofoTVQitcw+dMqIY96eSgURF/xO0j8Y1WW 5db8ekHLoD/MP6JaQCjRbzlUqxe53BQF6i7CSunLgncQN82Hcc9I6oCByF7wPZXBxTSxT4g1BwcJ4 0wn7JAsQP+oMdHM3qSA9M3VNibbFxLb+TZEByjnfyegGrZQoo2NmfeLo/1iv3NU+xuDRCTb2/ODKd +zXIAGVyET+gLu5tzRygYbCiqP03g02tkVDvK4f7e/t5P9K1Qk0Nk0rgh7+IxDiwL2lNDK/rPKprw CxYMYN+A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1MQ-0005hW-Tl; Tue, 04 Sep 2018 02:46:34 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1MO-0005cK-MG for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:46:34 +0000 Received: by mail-pl1-x642.google.com with SMTP id u11-v6so890607plq.5 for ; Mon, 03 Sep 2018 19:46:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xyGQJoxJuf80yEKrzQZlMJDHZF2IdzTQKqa/0pjxKR0=; b=RZRQSv09uLpehuYeYRJL6n4Q+9TLDbL6dSMtuVoLpRQUlGaoKC3kWqooJlxuODUJWT EfjyJ3kJ60G5cT8s9NZDTPSizeufFEfjWlruXgokm32X0iCT3eu9lIo5jqhhH5+ttbeO GR3j2lN9B0dHCi0a56lQOyIemsWoT6FS3ziU66qQQnWt5CxPVv+CRiwV8/5xjBAfCN+8 XKr1tmgwZrB3BOblVlZXxLpY9jNPvVjHjOMnJxXeoFtqkuPtIlfPB6dJ0/Ha+jz2RNed 0qisgumt35KtA3dl7ef1Qhb7b3sUxCto3o2Q/KnL9k+Z5JRMzfkUcFPyurjUKkr1etDU 5blw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xyGQJoxJuf80yEKrzQZlMJDHZF2IdzTQKqa/0pjxKR0=; b=lbip7ID7GE8wmlpliU7IqXRnBw9AiGdFN69VaMrunWA56DBwPiU9CMNqTmml4xbyxi UKQU/nDgEMlCoB0qgVmvJrQIy1I2GUPWLupTEMhr+jNoGoQkDGCyv3ZrhzCOmfwsr/4D GOJY3tDVqhOfTln84TYLLwOaLIAUARbpZ9D1H8RgFJXmLV0NgxQW3seUTZkPfEjQoMU+ d7UHzHwCxpusgITwsafky3sQ7/8YPnWiXWlDCOaoIHuQ63AzKSmeBCDPZK/oVwfFPJdF NnIWssMs2Qn/XKvP8zaet/RetyPhi0vaR/6rjF/sIX8UWEEwPOErqWoBcBt/IU4Sj/6W Mo8A== X-Gm-Message-State: APzg51AFRv2Ef9BRPWzPRV1yyoByvurQkNdpZ+IwGmE/3KEzqyv2suJ3 SKHjiVBVw3IiVX+sS6zj8AnqDTvs X-Google-Smtp-Source: ANB0VdZmMidsyx2NWPQtHr5RHUY52+IJB6tCqYbLEiuS9YcnTq+cf27rQdkbGX1mUppJOaCVTPM1HQ== X-Received: by 2002:a17:902:7d83:: with SMTP id a3-v6mr31483472plm.0.1536029182110; Mon, 03 Sep 2018 19:46:22 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.46.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:46:21 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 18/25] mmc: core: sdio_uart: Change return type to void Date: Tue, 4 Sep 2018 11:44:44 +0900 Message-Id: <1536029091-4426-19-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194632_770575_77CC5B70 X-CRM114-Status: GOOD ( 13.02 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:642 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_standard_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/mmc/core/sdio_uart.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/mmc/core/sdio_uart.c b/drivers/mmc/core/sdio_uart.c index 25e1130..b727186 100644 --- a/drivers/mmc/core/sdio_uart.c +++ b/drivers/mmc/core/sdio_uart.c @@ -731,14 +731,11 @@ static int sdio_uart_install(struct tty_driver *driver, struct tty_struct *tty) { int idx = tty->index; struct sdio_uart_port *port = sdio_uart_port_get(idx); - int ret = tty_standard_install(driver, tty); - if (ret == 0) - /* This is the ref sdio_uart_port get provided */ - tty->driver_data = port; - else - sdio_uart_port_put(port); - return ret; + tty_standard_install(driver, tty); + tty->driver_data = port; + + return 0; } /** From patchwork Tue Sep 4 02:44:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965721 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lA9Yu3tq"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="i5E4+keX"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B7J6ljmz9s47 for ; Tue, 4 Sep 2018 12:46:52 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Ox0t32ABFlh8Dx1tPK6NVCJrEezTU/XDAjeFAP/IXZo=; b=lA9Yu3tqE7tqr1AEvNkFYt7Eky l2h8Xn3NwmCHuwfp1p51EUP9tPUpqlXFhX9xt4tqHwLw6JgD7Xxw2MiWTR61Vq2ZMZmh0tT8aUaAy o1AkfXZtKpxlDOwkVxum4kF7sI7B9o4Gk7nWNBSnoJtAYiA35CevkNBNQIXwRCL75pGDdFGmlYJKd b+qPFhTLoEGo5JLZ8LWWle7Q1MP4oq7OFNh+tBxapmO+qVwEUNRVUSiutc09E1Azs8NVtAzpNM7y6 DrXRfWAhWoJNczQAetYejWrEtzJvRSLFl8P3zKIoDfNkzkmi6Da663U2pqO7E1xvqpmYxfeKJ47Jw nQYGbT7g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1MW-0005j2-2o; Tue, 04 Sep 2018 02:46:40 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1MT-0005dr-JH for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:46:39 +0000 Received: by mail-pg1-x542.google.com with SMTP id r1-v6so874004pgp.11 for ; Mon, 03 Sep 2018 19:46:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=oYYQC2lkr9IQJTqeFD66xCNBcnWgOnsYuLXK//u2PDE=; b=i5E4+keXmQBCY2tQQzXatN2SdOHTlREsIC2+XC3mh7qBzlx2WNNYNE0ijaHVZFriGl 88IRFrIVlEnSux5+Mv5/5qPauDnpX0snK9IXMtVXPruvoRDXOmSI7A3u2//m6KrAmc+G CTa1NBlfR1of5pEi57kQcdEalChJGL//o8ka4X+7sh0RdNWrNhi2++Trmp0jDYrr/CgZ NkCKhgr2M/5Ec/n/10/ThXf0vIpkSHtsXVOB4oObVNNfAujltW+5vbvG/UreNjb4uGRa YvIMOQegFuZlBA59IKqnuJisn/u2nWiEKUHLcqGNye2/jpRawhFV6Mhv41E/55XdW98F FkVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=oYYQC2lkr9IQJTqeFD66xCNBcnWgOnsYuLXK//u2PDE=; b=h5qISvUStq0xLL0Ibj+Kr4+KPaXwdcNH+kr0aFvQxb8axwVgqz1V4hxa5b1arjN1UQ Uo23G16jX9v0FiSccJ/UfPL1Uf9n+9wjVGXjpqfZI8lerunelZ8stLxhukM9LIkfRZBZ cWYab7HZKHEiFpTxGlzPMlM8l0kyqdkWf7CPt6fTEpFhObpwe0DgebVo1syhxx70dN4R LOR3E8lsurJe3MCVOs53Yex9zAsgjuUEr1LKoMq3E9NJT1WF8C0ya3+5OGMoqd9HoYWr eV1El+y1hgPOc1JD2HjDxBOD7JrhwRZ9WCS/IIHgSQp2g+B6Ao8QGERe39kQoovIU6qR P/jw== X-Gm-Message-State: APzg51CRUtSH4IS3+KFRwLLhvK0XIho2g1pMNvPp6qA4jEICvlLUBBIC G4p5wAZBp9pfd5U37Sa51YsBHGKq X-Google-Smtp-Source: ANB0VdaNzGMOvVi3szbnsElEHKQPH9pVeEOdXYDACzRxdD45PWZHuufItLDCgqLmRipNRGy8vt2iog== X-Received: by 2002:a63:df4e:: with SMTP id h14-v6mr29246819pgj.300.1536029186942; Mon, 03 Sep 2018 19:46:26 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.46.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:46:26 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 19/25] staging: fwserial: Change return type to void Date: Tue, 4 Sep 2018 11:44:45 +0900 Message-Id: <1536029091-4426-20-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194637_647585_CCBD0A18 X-CRM114-Status: GOOD ( 12.39 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:542 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_standard_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/staging/fwserial/fwserial.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c index fa0dd42..5134019 100644 --- a/drivers/staging/fwserial/fwserial.c +++ b/drivers/staging/fwserial/fwserial.c @@ -1064,27 +1064,21 @@ static void fwtty_cleanup(struct tty_struct *tty) static int fwtty_install(struct tty_driver *driver, struct tty_struct *tty) { struct fwtty_port *port = fwtty_port_get(tty->index); - int err; - err = tty_standard_install(driver, tty); - if (!err) - tty->driver_data = port; - else - fwtty_port_put(port); - return err; + tty_standard_install(driver, tty); + tty->driver_data = port; + + return 0; } static int fwloop_install(struct tty_driver *driver, struct tty_struct *tty) { struct fwtty_port *port = fwtty_port_get(table_idx(tty->index)); - int err; - err = tty_standard_install(driver, tty); - if (!err) - tty->driver_data = port; - else - fwtty_port_put(port); - return err; + tty_standard_install(driver, tty); + tty->driver_data = port; + + return 0; } static int fwtty_write(struct tty_struct *tty, const unsigned char *buf, int c) From patchwork Tue Sep 4 02:44:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965720 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="awfw3bfh"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="FXSpGv6Q"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B7J0TJSz9s3x for ; Tue, 4 Sep 2018 12:46:52 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=hGXuPqwhzY4UcCkpUqJ35O9zGFpXiUoRn+fdTSHF32M=; b=awfw3bfhUK8yocE7/jCVpg5TUP YMdNNi6xTEZPsnS41NdPLIM38gJGraR0w6VUMbJGP3eUxBvtC1fv7eLIdj9Lw3WWgu6irvbCfvfdD WukoAF9a/FOz+aOIs5U7kTxwvzUW6veAe2/WMxLGe0xzDRgn3W02POfZPOMPJOJ72d2OzGfu8ohte orVlSpqeAEUqYPrdvA2TQ8FMDYfsoFBvN8Ltr8tBWXN2EmKqeZERcxQYcAwkuw/AN+wcxnWxZ0sw5 lpANpctdPrHmlIWl69mxAqakB6ipm3k/uJn1UUSmULCLVMr1/1PFyqYuLfxysvXx7ttgIYHUy9JxW k7mzawlQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Mb-0005kS-8X; Tue, 04 Sep 2018 02:46:45 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1MY-0005fz-Dx for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:46:43 +0000 Received: by mail-pf1-x442.google.com with SMTP id b11-v6so916750pfo.3 for ; Mon, 03 Sep 2018 19:46:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=fA2ErCgkNSVCLrHl8v8rTEOByo32QmaLjON3C67ERi8=; b=FXSpGv6Q+gVKqqkcRWl2vNMAOcNEdvYrXJL3ksktI+W6kt6ISgNAG0igOutTk5HyXJ ZW575WBe+/s6WfKUy1k5kv7a6ENWwjFJoQ9fdqllgGaI1ZW6hqIZexvnZGKjyrfTOBVK YIjINe7bm7REInnq72i6mTEg2qR8TTIZXXJxqa3Qfg6WC5fv5dBKcvNTUhSDQUkEe1xo 5TKXGWS0vbp7Jy8sTD1RMiWAJ+otJSs+jBmy80tDyPO+7f/qiiXN+af1OgfhydXSP0dh FnComxuodg8phvHHndO7CBd+/+rlGF5KWvW8iYXGhnLEbZjYK3tbI7nxzb+lHQGKlXyk 8Y+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=fA2ErCgkNSVCLrHl8v8rTEOByo32QmaLjON3C67ERi8=; b=bi7fnCk1X4YDw+IlcDKW5b6XcVxLCMgwxy80uIm86a8UmkkgkBEOwpzcM4pwuRRv0f hvy7hcy5ibLu/S3ocQ5d1zmVO7YdbJ2TPxY0fmxK7l/k3bx/68m1hK9CbQ1fPsKBANYj uEa/0brf6pIaoub/xq+vSRekOZD2G7nkxFPv13cJHzb8d7BdA5mWPl/HdWAtqtI2LyXj USH+8o9jrOP/nPA8C/YOtR2TW5A3/Dc8+s9ECVNN3jfeIeAJQl46r68aO2VO80M8D55x yYbaWl24CMxTDIPecTPXzU4F8g8t4cYJQTY0iJWwvU22AAedPuQgc6luLiGwX81rag6W qPcg== X-Gm-Message-State: APzg51A17Ov47twfHMg514V3qXocEhqVpiG/PKlylJ/kTdb6RPxpZZPP 6gf431wWKxjnmXGgCAj6axbHAx1r X-Google-Smtp-Source: ANB0VdbpNOEuUanWj5bVqUTmDeWxbrNm+KLWHG/fYkXr3pvSIbXucixHajRhrYWyzCbEeM2pBhP+MA== X-Received: by 2002:a63:4f14:: with SMTP id d20-v6mr29062720pgb.121.1536029191652; Mon, 03 Sep 2018 19:46:31 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.46.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:46:31 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 20/25] staging: gdm724x: gdm_tty: Change return type to void Date: Tue, 4 Sep 2018 11:44:46 +0900 Message-Id: <1536029091-4426-21-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194642_493531_C2427FC6 X-CRM114-Status: GOOD ( 12.68 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_standard_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/staging/gdm724x/gdm_tty.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c index 6e81369..d6348df 100644 --- a/drivers/staging/gdm724x/gdm_tty.c +++ b/drivers/staging/gdm724x/gdm_tty.c @@ -62,6 +62,7 @@ static int gdm_tty_install(struct tty_driver *driver, struct tty_struct *tty) return -ENODEV; mutex_lock(&gdm_table_lock); + gdm = gdm_table[ret][tty->index]; if (!gdm) { mutex_unlock(&gdm_table_lock); @@ -69,15 +70,9 @@ static int gdm_tty_install(struct tty_driver *driver, struct tty_struct *tty) } tty_port_get(&gdm->port); - - ret = tty_standard_install(driver, tty); - if (ret) { - tty_port_put(&gdm->port); - mutex_unlock(&gdm_table_lock); - return ret; - } - + tty_standard_install(driver, tty); tty->driver_data = gdm; + mutex_unlock(&gdm_table_lock); return 0; From patchwork Tue Sep 4 02:44:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965722 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IVW/3Im6"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="qiVcnF+y"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B7P1PVjz9s1x for ; Tue, 4 Sep 2018 12:46:57 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=gKw9X0dbHS1nx7aBJrRDN1G+iEW22o1keCr4HNcJsFU=; b=IVW/3Im6VfMsrtZ8919MjYxWiZ esdCUPbVCBplkb9nUpu1wSusTDuh4jlbmvOu10fZ3eFCx/v+FE/wKtnwMYXq6TMWi7NkuVKqBKd5e U7Mepz1GcIqJkMqp8CGoVVwZqtEvYKjA6vN9JKv7FR9NOQNfhpvqNGffS6osLmlVcjlHvUrkmGGrT wPSzh+r31Ul9BCX7qcXWDHI1OPEmJK2nZhZDjN1lP5/AJGl965C9MSRenHUljEGGuTvkpruvQs0pc fqKXpPCEaHFg1Fj5kPPWgYowFOEyfFrMnIqnjFo0HIF3hv/wvVIyhpX8y5USKtfzN6W+zTlAxbuuM 4wCsoUNg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Mg-0005mQ-GZ; Tue, 04 Sep 2018 02:46:50 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Md-0005i7-8Z for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:46:48 +0000 Received: by mail-pl1-x644.google.com with SMTP id g23-v6so879438plq.9 for ; Mon, 03 Sep 2018 19:46:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7uAJRAvdTqzcpqqjK5tzDqg/rePnC+seodc9IPByu00=; b=qiVcnF+ySqN7ITShcOwC3qNgjM3JKqbmljNdAqNdyllcVbWnPz6Itm2idIo9p42Alj ZDYiIJ4rn2N8ntUIdVqN8hSr5A1K1mpp6RdMU3r84HK8i+aR7AI5/sQaaOwGMNqVjI+D BMwJD+42vq3QBhEBzU6McJeKTvsUUtgKV1JtMnmR6dwEAKtiGteyxjsVyP3/xVfuCKrk 3jroEOtR65o4N+L32fJ8/e5Sr5NlEMlyMtHbQhKMevX+bMwEu0wu+Pj7wq4J8nMCAYGv QrfmAlgf/VPuqPxG+ojWGvasclRJLzGhnIAtequ5N23MSwb6JvU7kaUlZVWBCUmZQDzr I+0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7uAJRAvdTqzcpqqjK5tzDqg/rePnC+seodc9IPByu00=; b=LyAgfEmlzDxFst3cCH2Ob2D/tOfmeCyzLHDPK6/htzfvDfTHa6bPnSqzzjckEPR1K2 Nhg7KSt4b6VZPHvQRKINS1qv34gEszIa6cGKdmfRO6smx6fJKhS2dcqfHXifMGBW1s9S zYTx5oTzn+ljJ4tEYWr+6KRYUdNvDNNmoSzBTZU5kz4y0AWaa6P7NHJLgP9AMo02voAa drncEIb9OrtFNVYaWi1NBE5FRB6wqCtMa3rAfR6+HZ2OaUxC9oj8D6lC0v8ccTQiknAS fVkchMeWqIqk8RPN7jJ1Xr/809CHH520IYVKqudo0jI1QE4ziApPbEfXCzyavZdjwggJ ruaQ== X-Gm-Message-State: APzg51CyPrF347ogspWB7Sj+BaBzIIdNskUrSV5FbF5sDD1LimnC+oUU A+jeGrBfxNKkDZI0Mspi4f/KIjFJ X-Google-Smtp-Source: ANB0Vdb9myTURZoXqFquAqZsyos/o7S6Qr6wTdmjZEKLC+KG8zP08IwRTFrTKxV/1UXVeW5jyKmyVQ== X-Received: by 2002:a17:902:7c8c:: with SMTP id y12-v6mr28570270pll.283.1536029196519; Mon, 03 Sep 2018 19:46:36 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.46.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:46:36 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 21/25] staging: greybus: uart: Change return type to void Date: Tue, 4 Sep 2018 11:44:47 +0900 Message-Id: <1536029091-4426-22-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194647_336899_DA0A88F3 X-CRM114-Status: GOOD ( 12.99 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:644 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_standard_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/staging/greybus/uart.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index 8a00632..182155b 100644 --- a/drivers/staging/greybus/uart.c +++ b/drivers/staging/greybus/uart.c @@ -393,21 +393,15 @@ static void release_minor(struct gb_tty *gb_tty) static int gb_tty_install(struct tty_driver *driver, struct tty_struct *tty) { struct gb_tty *gb_tty; - int retval; gb_tty = get_gb_by_minor(tty->index); if (!gb_tty) return -ENODEV; - retval = tty_standard_install(driver, tty); - if (retval) - goto error; - + tty_standard_install(driver, tty); tty->driver_data = gb_tty; + return 0; -error: - tty_port_put(&gb_tty->port); - return retval; } static int gb_tty_open(struct tty_struct *tty, struct file *file) From patchwork Tue Sep 4 02:44:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965725 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nf/Yj+6K"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="H/H3Tkp3"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B7V6VbNz9s3l for ; Tue, 4 Sep 2018 12:47:02 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=lw8jkWymvujHbxwGDpl47RH2Edfn0wD/JVxPXy3LJl4=; b=nf/Yj+6KxibUtalhC4akz2mzd6 QUDsuf/G3P/hvl5jZ2Tlxvg7Pka2rVJmjJlGTjqXtGp7nxEz89n3iMA2kiCOZB1uOUvQj3mwQ68FK aId8CWEprV1+bnn5hvDN3BbM+Kak4s27yYQtJibihZt6nHgRESQXkdgpL9bGA3740KBTaGOGFZL7H 8tKWyFVgKEuXQsf85Fr4R/VaAbI2fHUo/KFuWyNkMMeSMCG9pZAX0mfqwLgFnYEk948HB0u9dlt6y +u6gXbP9IIHobYH+JLHXQXiuArYv2qJ1Va63IKwlk+CtLdXR3/dvIkFsumjUXMg8rK/LQLGnPiFd5 5NhkqSOA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Mm-0005ol-1d; Tue, 04 Sep 2018 02:46:56 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Mh-0005je-Nh for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:46:53 +0000 Received: by mail-pf1-x443.google.com with SMTP id k19-v6so921177pfi.1 for ; Mon, 03 Sep 2018 19:46:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tIm6EZtwcTj/6K07q+OAE3PS7sJKQ7sQ+h1iaHX1x3Y=; b=H/H3Tkp3uHiVEimPfiHOldaIHZ+9vgFJbNLaWIZwsJMXYQe3xgOiX9qvsHIJh96KSR 460oFGHEhBNxbZQB2gljH7ub1xrfGuoqfDIRTSO4/7UZLyZqPLo+i9PUor6MigvqfEJg mJyJr8lW8/SJMCtYUznXQ2C2/yD0gPJ4ANXyd7DOiOlRMicuGe1rGmxz113QkausZDjn JeN349FcTBx48VunsQMKZvhMKDi4qw/FQQ7k0pcmvIyjm5OsxcxveQY8l/xrRp2CxjtB AaKsf9LR7aBIjxYAKflDwvZiNXJUpA+Tfw5bvQerNV7RIA9i+4ymP99mK5I4ilVArHwW gUAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tIm6EZtwcTj/6K07q+OAE3PS7sJKQ7sQ+h1iaHX1x3Y=; b=CTmG+kb98gEiNT7P7lp1ZKOB+FO+qMhTSWAUYNURsSdcGc5Uy0h2/PlF6YIww4Sjap XW9rJR7S6rol3KSQd9IPpp8cnBOO0zi1rE4pLgkN+nYqcHZBYNjgUZlnHpfXc8sCvPkt 4VPWrkFDzMaiFDcvzlqSEswSZpkdLH4CDAt55UqIgh1hvWJE4B8jF3oNs7BWlGyGlaCO loCqdGiyhI3Mxj8Hh6qfcUIkYwzxb20ZdXOy5e55SGK/uxnN60K0gGTYWXuAuDxN47cI QYs/YagKEMVIshUmahZn3DmwJx+7cNK2Vvld2CqEokvrA6LKg11MOXvlvr1QRNBIWSxU vtoQ== X-Gm-Message-State: APzg51C/HoOEfmQKo6TQRUWrEDVNpjIR5olDRZHZd5AsNxkbxEAw9lZQ CwaFWm8j063uISZ1hTNfXxWLUkCi X-Google-Smtp-Source: ANB0VdZ6hJam4sJt4CsP1wMFFch33aXly5rOzu0Dy2V2g98FId2tgWLmFosIzGaFiEgoefPwpjcEWA== X-Received: by 2002:a63:9809:: with SMTP id q9-v6mr28648150pgd.58.1536029201118; Mon, 03 Sep 2018 19:46:41 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.46.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:46:40 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 22/25] tty: nozomi: Change return type to void Date: Tue, 4 Sep 2018 11:44:48 +0900 Message-Id: <1536029091-4426-23-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194651_800094_DB595E72 X-CRM114-Status: GOOD ( 13.32 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_standard_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/tty/nozomi.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c index fed820e..479583d 100644 --- a/drivers/tty/nozomi.c +++ b/drivers/tty/nozomi.c @@ -1555,13 +1555,11 @@ static int ntty_install(struct tty_driver *driver, struct tty_struct *tty) { struct port *port = get_port_by_tty(tty); struct nozomi *dc = get_dc_by_tty(tty); - int ret; if (!port || !dc || dc->state != NOZOMI_STATE_READY) return -ENODEV; - ret = tty_standard_install(driver, tty); - if (ret == 0) - tty->driver_data = port; - return ret; + tty_standard_install(driver, tty); + tty->driver_data = port; + return 0; } static void ntty_cleanup(struct tty_struct *tty) From patchwork Tue Sep 4 02:44:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965726 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S9S8+Qo8"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="D+huqxdj"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B7V6hTHz9s3x for ; Tue, 4 Sep 2018 12:47:02 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=xUztPCdLNyJ7y552mm0T66gceMon0q2TExdi+tHfN0Q=; b=S9S8+Qo8xlkwIvw7Z/Z6X36OfY kw7njFzKH+4xA5/qliioLoeB2E08X87RDPGyRYRp3RCYpaVut7aJkj1nsMccjRrspk8XuCeFdSDuZ 84pmZldGG5rOrrU2/iSU6ZxaTlj/QXxR27kM9zBMOTjxaulAWK/8o0nwzByx4D6WX9O4xFTTHzeeH MQDNyWlVoMHQiInxSm6czaDHeYuqa+0Bfwvj9RdVj+Z2nGp/9K4WGN+U2uyidciAPUxiZj00iYAkS JnZsA0KOiyFDgffDfnKHp7kkfsjFrQR7tIR1Pom5+ttl/Dtx4lqW6Hv5kl5Ic3jlX98/R1JXf4Ghb SnPWKxuQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Ml-0005oR-Ob; Tue, 04 Sep 2018 02:46:55 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Mh-0005ki-QP for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:46:53 +0000 Received: by mail-pf1-x443.google.com with SMTP id d4-v6so925208pfn.0 for ; Mon, 03 Sep 2018 19:46:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=K9WSdI4xIWm95WefIAgmlM2Cw4JjRPctJYgLLWJhf3w=; b=D+huqxdj0oLB5H6zpdMf3v6ziDrrSw7vKzugFiDWga6u43eI5eNN/AeuWIFSjMThV9 o+kwP6EcS1+2s4zSPclms+ESo7BcUX+xwM7XTXCiTMUhlXvBUqGdQphSmbym5oWRD8Vx ufgvcSMipW2mSpNiGcoJ9rSO8nQ2Z9NXG44kZ60XZmViRjD5s3rrHr2JvPYGHB0PYvrr FdZCUz/9fOc+BUUX/stpxBBG0qb0SohURfo3prJ7eDmcIxBVXy0g2U4k8HFyAxsbYN7x TAKYgQoLGJG4qUZG4igX5NrV8+v/Cpk31DoUhNJIeSdhMsqONJLWCMpQmWJ3JiGcBkW6 bjzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=K9WSdI4xIWm95WefIAgmlM2Cw4JjRPctJYgLLWJhf3w=; b=IixIlfxpY/fxz53hMZXDYh47T0yvrgarAXYDrloMakNfzC/cnugksXZ49ivBXJqA4m /9pCyRzvIY0a0w8hwn/UBZkCY7AGHY0HmmWhgLKYH0vJguc5boF/q/l58ofJO3n/xxMb coXAFbyP2jOuMOA7kvcnyoW5m1XjWUevQjW4jJA8yQh56ZMUfy6i/B1ymuJKmvJ5SL5O Z07KOjc2LtsICLj5V9KU2WaCc/G5QnDVlOWpjSd5AB+yXF2y00CnnGAa3nFcOXUQf+5v xAjPHX1ohd17krtaJU461s7yzhRhQmu6APVrxR+AztQV0VXS+U3cI+iu0xpm0LZpj4Fo gn1A== X-Gm-Message-State: APzg51A84xMoMz9s7md2HRWFO9Lr4I1cJriKgKL3ZaFumtTbQDa/hJ4s 3f1eMBJ4hl7FZzIJ9bJMLmmbUus9 X-Google-Smtp-Source: ANB0Vda9K++B22N8xLV0SZkONnEg8X/QNN1vt5G5oV0BkvA8DNalLdyDj9o6GaGtgd/VNljMAEqiZQ== X-Received: by 2002:a63:88c8:: with SMTP id l191-v6mr29118195pgd.340.1536029205367; Mon, 03 Sep 2018 19:46:45 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.46.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:46:44 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 23/25] tty: vcc: Change return type to void Date: Tue, 4 Sep 2018 11:44:49 +0900 Message-Id: <1536029091-4426-24-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194651_913837_41A38282 X-CRM114-Status: GOOD ( 12.09 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_standard_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/tty/vcc.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/tty/vcc.c b/drivers/tty/vcc.c index 58b454c..ce32631 100644 --- a/drivers/tty/vcc.c +++ b/drivers/tty/vcc.c @@ -987,7 +987,6 @@ static int vcc_install(struct tty_driver *driver, struct tty_struct *tty) { struct vcc_port *port_vcc; struct tty_port *port_tty; - int ret; if (unlikely(!tty)) { pr_err("VCC: install: Invalid TTY handle\n"); @@ -997,9 +996,7 @@ static int vcc_install(struct tty_driver *driver, struct tty_struct *tty) if (tty->index >= VCC_MAX_PORTS) return -EINVAL; - ret = tty_standard_install(driver, tty); - if (ret) - return ret; + tty_standard_install(driver, tty); port_tty = kzalloc(sizeof(struct tty_port), GFP_KERNEL); if (!port_tty) From patchwork Tue Sep 4 02:44:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965729 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sK66SNYM"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Bx65hI3S"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B7f5nVqz9s1x for ; Tue, 4 Sep 2018 12:47:10 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=QWiv06AGwQwYFEYvvZvHrPG/AfWF728DPUaRP6iqWnM=; b=sK66SNYMfX59O/d893/qiPDt5z D7GC+4FEXtg1Z+7NPW42XDToYfWNMjBh4DCYS2fkwO1fufPPYFka6o07S4+XtT9ncePRuMZVCQB0a Maqyej1EWZ/WOFJN4Q3ipUqYQpY1sowYSfysP9ai8SjpPIuBGNSgV74zB/2ZhLFzoOx2szp63Uy3w iIB/0q3FxVd0U7oQ93VdNquviYShZtYyajpqcAyvhtTNRudQTBKlsh78GqBTmOKlCk8mfU8GtDMNC UYhKWfe0NezP793t69mHUMCyzKgiWlba11eBCWa/wtnqfMu87GRxqck9XyV/TPI1QORlapSUWnigy 16gYUVWw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Mu-0005rq-I9; Tue, 04 Sep 2018 02:47:04 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Mq-0005mZ-Vv for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:47:02 +0000 Received: by mail-pl1-x643.google.com with SMTP id f6-v6so898159plo.1 for ; Mon, 03 Sep 2018 19:46:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RZT0NlqWPDVv3ZY8knEZ75oaH0KEYhTsNL+EUjOlpgk=; b=Bx65hI3SeSwju/CMQO3BmpKV5KW3A7z+7x59hC7W08nF3mou9O0IAO/i26QCK1SAav qpfO2abtOD1tOU1XvV39t4Q66+miH6hx+lYSF23Ln0nFrCHq6t8OIrZnakB5FyLMpQiH JJbcCQrzro3jr14467jxQwj+fnbPp3AgA6AxS4KK3OzwSFIx6TP3gru3F2vgX11T2QEM 1nLcSdwTN3OCx3Q5+P6ERKE2TPj2LnR7jH5tNKM10h+UoUDk19KW4qxVB9vlt8pOjJ49 y4INNwqDe5rIv/tQK3LyH/Y8Q7kVNPecJm2Do/86YjEud3mWKeOnzqtFVw73hq9OdWSV uINw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RZT0NlqWPDVv3ZY8knEZ75oaH0KEYhTsNL+EUjOlpgk=; b=r7M/znKogJadgA5Ouk1jZK275GhbfwSlAe5jdUT1wE6d0hP5PQ6Aee0WvAODFhoO5k NuWpMZoPZ4fhtX+d5KzTJOnTmIdhokxvBUBgl+aR9K9rb2gTFerGuOMFc3QskZ5XDFRG VEpDcmHsb9EU9FTosAS+uGJDIe54eUax2WLmKgdNrzQh4I5XInfzf2g67LN753DU2wzM Ge34L2BqWEX6hPylxy3wbTphzfV6VCg0lYeRErkzcZ1p2sSQAOC6n3e78JL2XUU1lXBY f6z3YMC+7GZGbhg4sZaAPRi/oIcqDILpR0mkCg7HHAsqwNVkmIcjXfF+ZF4V7/+Ubu/v 5TFg== X-Gm-Message-State: APzg51BAJhDI0UB5HLeN4VV57QNA5Y5ELmVpyM4i66C8KjEIbM39e4yS FxrIYMoTjirSSOuqPoiRm/7Y9PTX X-Google-Smtp-Source: ANB0VdZdWeaAIXAcMtwyECEthciNo7IoqHV1eYwdRbpGaJEZKNxxUYIv88HfBs7dyZgV+Zaswfxqaw== X-Received: by 2002:a17:902:2e83:: with SMTP id r3-v6mr31398676plb.80.1536029210221; Mon, 03 Sep 2018 19:46:50 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.46.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:46:49 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 24/25] usb: cdc-acm: Change return type to void Date: Tue, 4 Sep 2018 11:44:50 +0900 Message-Id: <1536029091-4426-25-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194701_035365_6F47DB85 X-CRM114-Status: GOOD ( 12.75 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:643 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_standard_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/usb/class/cdc-acm.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 27346d6..de6a27e 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -572,23 +572,15 @@ static void acm_softint(struct work_struct *work) static int acm_tty_install(struct tty_driver *driver, struct tty_struct *tty) { struct acm *acm; - int retval; acm = acm_get_by_minor(tty->index); if (!acm) return -ENODEV; - retval = tty_standard_install(driver, tty); - if (retval) - goto error_init_termios; - + tty_standard_install(driver, tty); tty->driver_data = acm; return 0; - -error_init_termios: - tty_port_put(&acm->port); - return retval; } static int acm_tty_open(struct tty_struct *tty, struct file *filp) From patchwork Tue Sep 4 02:44:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaejoong Kim X-Patchwork-Id: 965730 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SGUzoa6P"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="MtxqNB0W"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B7f74CZz9s3l for ; Tue, 4 Sep 2018 12:47:10 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=RJ++KzIO00m1UcO6Cq6C0THaxiCHJVPknQB6rTGCPco=; b=SGUzoa6Pstpi4pxEnOlF1cVuzC UZCBrjLdUCfCGg+98y0ulnBORi3S6PFGPHnFbUNWuoYHXL3BN9Q/9Q8yiUqk6um1TaTxF2eikb/MT /2HeyvzjUUt2/vfmb2mtKt9mRowmlweNsC7n79ApVavDbnzjjIQ7XjLRTOT4AwvY4tQ8Sh29Orqjl HDOjkrGfHrP4u1PSmES9WwviL0KcjNYjZB95hHTf8tBK8UQb5v2J5Vn/5XZfHad6N76KdQsnrPDmf A6haKZqy97EInoVI077hrOzXk9CTr8BMHXm9n+mK4ERLgYwMcQ0pF+zaQ95gBLqoX9y5PWHCazMYi 4GE9yPHA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Mu-0005re-BA; Tue, 04 Sep 2018 02:47:04 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Mq-0005oK-Vo for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:47:02 +0000 Received: by mail-pl1-x643.google.com with SMTP id g23-v6so879765plq.9 for ; Mon, 03 Sep 2018 19:46:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9fhtRSxRNlhSG2HakM/avAOwn2fzs7e/3lLxQzyJ82M=; b=MtxqNB0WA/xheF8oer5OfxpHH+cnB/mFS5n9FY2+qIngoXU2LN6P0ny5VhtK1xJhbi D8ATKUqQvESgCYvBa6wJ6P1rAN1s01M1QcKskSibu61DVOa0RoiUs83RTrNmu6/XM3NW bynC2ACo8vSZJxZUSDYPOxFnJiOcAGHWocCRm3KiTyJnbMpu3iXC9GrWS+ngdbYg/XnI GbBvce2BsHGIHsbrP2tub+g789NyfsB1vl3vkW2Z+pDQ0wOXDIgtgeK9WuRRzrjxrlWP fXusYtUOTBC/xkFSb4wmIPQ1bQQSy3UkX8Ww52YENeadayXKav0ZMV2ImRPxm5eDFmR5 8Nig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9fhtRSxRNlhSG2HakM/avAOwn2fzs7e/3lLxQzyJ82M=; b=YaWvAU5oXXlm28Wxc0jMZtI6lZOiEuKkoCdFcVJ0x1tf3dwu4KMF5mKmt9NT1Drcq6 DcxkcP0AMWCJR9qp52wll7s4ucfbApF1LbJczpiWWKSvIAkh0Ig1whhgfgzGL38JJq65 uw3rRJMgqtXxjCf/kBnDXzFLd1keFNoyOQ6SgidE6XK0e4SYMGJoF0xQLbZJI8VglLeA jWpNo7AVmjqPHBHRGbSPLXPLUfN/AiMGkSI4JdAu5lD7Bqyx0/a/XBx6HmI28VSvVpGd MNXanY292F0ZOYuG6hp84aEJ0Ir3Lsv7SdATA5g+yqE9OISzSJWKBFU//aBRrEKHQHC5 3yLg== X-Gm-Message-State: APzg51CfIyoDT03DlFFoEIw+Ue6xZnwO8mmIIp/3V6zrT4ThR2NbkZZX e2ExVqZWG3i8ovBWH+QMOSYBmJ5J X-Google-Smtp-Source: ANB0VdbGNWdoDZT7cp5uWkjz+NRP9RQkbF+dv0PEH/mUMC3Ps4V7vhtxolhlceX7nOpZVgYGv2eimA== X-Received: by 2002:a17:902:bf43:: with SMTP id u3-v6mr31343352pls.88.1536029214501; Mon, 03 Sep 2018 19:46:54 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.46.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:46:54 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 25/25] usb: usb-serial: Change return type to void Date: Tue, 4 Sep 2018 11:44:51 +0900 Message-Id: <1536029091-4426-26-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194701_030589_2A9F579F X-CRM114-Status: GOOD ( 12.15 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:643 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Jiri Slaby MIME-Version: 1.0 Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since tty_standard_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/usb/serial/usb-serial.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c index f7aaa7f..5cfc2ca 100644 --- a/drivers/usb/serial/usb-serial.c +++ b/drivers/usb/serial/usb-serial.c @@ -192,9 +192,7 @@ static int serial_install(struct tty_driver *driver, struct tty_struct *tty) if (retval) goto error_get_interface; - retval = tty_standard_install(driver, tty); - if (retval) - goto error_init_termios; + tty_standard_install(driver, tty); mutex_unlock(&serial->disc_mutex); @@ -206,8 +204,6 @@ static int serial_install(struct tty_driver *driver, struct tty_struct *tty) return retval; - error_init_termios: - usb_autopm_put_interface(serial->interface); error_get_interface: module_put(serial->type->driver.owner); error_module_get: