From patchwork Mon Aug 27 06:39:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: DJ Delorie X-Patchwork-Id: 962345 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-95505-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="LunPYYVd"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41zMg84NS4z9s1x for ; Mon, 27 Aug 2018 16:39:15 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:message-id:from:to:subject; q=dns; s= default; b=RXvX1INYIqdiXsNIwHdDr2IrH3IGLZt0sBlG+JkrDPg8VqtFOUYHm E7uMLWpFcL0+EBOmSM7UB9wCVnKMJt2vwx3qFWNh09LwGi05naNtETTT9KmPRw4u UyfKy74TOw8OEgCqW0fB7GqQo4s8Q1BId5SHO9XdkXNFyo9YZkyl40= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:message-id:from:to:subject; s=default; bh=tMxtw+TrsiK3dUcuG/UqCGLjpGA=; b=LunPYYVdkpcCAK2YYUcqTh8ZdGCh CvruHwrDHS427oI2v4KYhSXj2JLj0XD+GNnn/2I5FV0C5f2vPttN9tv6Ji2kidG6 1a97QsBGG62RaxoK+Jgt3YTMGjS+MQ+aiTLVjiD+v0rzVuO9LyHcOlb5Nrk4yZpT qmP8cOrU4wFQBRA= Received: (qmail 98579 invoked by alias); 27 Aug 2018 06:39:09 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 98246 invoked by uid 89); 27 Aug 2018 06:39:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1495, turns X-HELO: mx1.redhat.com Date: Mon, 27 Aug 2018 02:39:05 -0400 Message-Id: From: DJ Delorie To: libc-alpha@sourceware.org Subject: [patch] test-in-container: fix Arch Linux build-programs bug? Turns out Arch Linux uses the build-programs variable to build different parts of glibc with different flags; but setting build-programs to "no" also disables the default rules for programs, leading to makefile-related errors elsewhere. Since the "others:" target already depends on $(others) (or not) depending on build-programs - see : ifeq ($(build-programs),yes) others: $(addprefix $(objpfx),$(others) $(sysdep-others) $(extra-objs)) else others: $(addprefix $(objpfx),$(extra-objs)) endif Setting $(others) is sufficient, and dependencies on others: are redundant - or in this case, problematic. Is my understanding and description accurate? Tested via plain builds/tests with and without build-programs=no, plus build-many-glibcs for targets x86_64-linux-gnu, i686-gnu, and ia64-linux-gnu. Ok to install? * support/Makefile (others): Don't list programs explicitly as a dependency of "others". Reviewed-by: Carlos O'Donell diff --git a/support/Makefile b/support/Makefile index 0ed00212cb..b528f538a6 100644 --- a/support/Makefile +++ b/support/Makefile @@ -168,16 +168,6 @@ LINKS_DSO_PROGRAM = links-dso-program LDLIBS-links-dso-program = -lstdc++ -lgcc -lgcc_s $(libunwind) endif -others: \ - $(objpfx)test-container \ - $(objpfx)shell-container \ - $(objpfx)echo-container \ - $(objpfx)true-container \ - $(objpfx)$(LINKS_DSO_PROGRAM) - -ifeq ($(build-programs),yes) -endif - LDLIBS-test-container = $(libsupport) others += test-container