From patchwork Thu Aug 23 23:19:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cong Wang X-Patchwork-Id: 961635 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="dpq/enfI"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41xL3Y2c69z9s0n for ; Fri, 24 Aug 2018 09:19:53 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726282AbeHXCvq (ORCPT ); Thu, 23 Aug 2018 22:51:46 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:33980 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726137AbeHXCvq (ORCPT ); Thu, 23 Aug 2018 22:51:46 -0400 Received: by mail-pg1-f195.google.com with SMTP id u10-v6so1663660pgr.1 for ; Thu, 23 Aug 2018 16:19:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Tdj/n0vSncoo37s/HSPWOS4aYh5gwHp8JM/pv5XPFxs=; b=dpq/enfIWWgvvNDOxxvw2VIwUbMb6p4T7Xvd0IihH9chQ8XUMB4oW8Nttahnr+tetO Qj3+X0WSu6+ABx29Jr6LdEtoKLtcxTvfB8dCuizYaleCArQDJRfnBv63OsrjTEMglcqX IG4M5ZdSC9yOnRjsEQ7siYLjOc/M1xU1BgRy9W8hIcIx7IL3FjVhExKwbTKbsXLxo8y1 UHsOrzkID7oLTjmG+FI4Q1UA+Xak2XFR/x9v8RQYjjukwc0Bd71mVu8Lb77zDMCfq404 JDqFFsL5hP3QU6ZEKq+Y+OoUheGCSiZm64Svr3VIBsHjmtRCH+pj9rb1nKI7tVpOU2pT 4M1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Tdj/n0vSncoo37s/HSPWOS4aYh5gwHp8JM/pv5XPFxs=; b=CrFeRZ2LjJEqNOIXPasxs+UFZzRbmT3/uJrWGMDqhYMRNkY0SvRidvd0M+IeyKJjt1 aELwM4QOiKCtaBycZq73IhRfGGllcsyYGllm0X31iXLvVEnyCqM8wxhWShcIxuezIadI NEKbsMhVjE+V3x/tjjHrC46eiEkAZYMzX1dwU9Eql4BsodGNPyhEMMHJdyOtIYLbOC+2 OYK1xVJ54fUAzeHgTjzENekZaWvu57uALVbFqPrrnjC+6IN7MBe9mCJ34bKlu3BsPUKH S9Fda6JBPjKlKjSsK/SIWtZRyR/BQ6cd84FuhGQ1OYcQz3qUPx+yocj15vGTgHO+0bJz ta/w== X-Gm-Message-State: AOUpUlEw4oA0/5iGrbcI6O+w7TmKyXVObszvegtgirFoRBPuu+rpM6L9 Fm0ELZvy8hHFNYFQ/+oadRYcWuP8 X-Google-Smtp-Source: AA+uWPxmgxW7OmJmHBWiKMQWP2h8KkDh2xifeqPPnjsd6siNOV9/mwg6GM+FbQVwPbTnlarXXCF/bA== X-Received: by 2002:a62:63c2:: with SMTP id x185-v6mr64127247pfb.13.1535066390312; Thu, 23 Aug 2018 16:19:50 -0700 (PDT) Received: from tw-172-25-29-37.office.twttr.net ([8.25.197.25]) by smtp.gmail.com with ESMTPSA id t14-v6sm6054015pgu.0.2018.08.23.16.19.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Aug 2018 16:19:49 -0700 (PDT) From: Cong Wang To: netdev@vger.kernel.org Cc: Cong Wang , Herbert Xu , Ying Xue Subject: [Patch net] tipc: fix a missing rhashtable_walk_exit() Date: Thu, 23 Aug 2018 16:19:44 -0700 Message-Id: <20180823231944.4959-1-xiyou.wangcong@gmail.com> X-Mailer: git-send-email 2.14.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org rhashtable_walk_exit() must be paired with rhashtable_walk_enter(). Fixes: 40f9f4397060 ("tipc: Fix tipc_sk_reinit race conditions") Cc: Herbert Xu Cc: Ying Xue Signed-off-by: Cong Wang Acked-by: Ying Xue --- net/tipc/socket.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/tipc/socket.c b/net/tipc/socket.c index c1e93c9515bc..c9a50b62c738 100644 --- a/net/tipc/socket.c +++ b/net/tipc/socket.c @@ -2672,6 +2672,8 @@ void tipc_sk_reinit(struct net *net) rhashtable_walk_stop(&iter); } while (tsk == ERR_PTR(-EAGAIN)); + + rhashtable_walk_exit(&iter); } static struct tipc_sock *tipc_sk_lookup(struct net *net, u32 portid)