From patchwork Tue Aug 14 16:50:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leonard Crestez X-Patchwork-Id: 957593 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="YLG0Hxsg"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41qdt31sJFz9rxx for ; Wed, 15 Aug 2018 02:51:55 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732972AbeHNTjG (ORCPT ); Tue, 14 Aug 2018 15:39:06 -0400 Received: from mail-eopbgr60043.outbound.protection.outlook.com ([40.107.6.43]:35184 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731707AbeHNTjG (ORCPT ); Tue, 14 Aug 2018 15:39:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PoayyEj9MrYdu4FfAXmXeW97Ff6v2RNRgSCyX2EN1uw=; b=YLG0Hxsgt7IBTVfVTlOldit3loIS3Zfv/3gIFbOllfSNanYt5feTldbGdcJIp/un9KObPtRe/eE3S49K+4FQIHvb1yR5QR0kNxZThwXVxG1oyh+CpzDu/YI8c22SfU7n/NTRk6LTrvcMLHGlAjVh2V+16Q90uXpHCDSLj8ZnA0A= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=leonard.crestez@nxp.com; Received: from localhost.localdomain (95.76.156.53) by AM6PR04MB4293.eurprd04.prod.outlook.com (2603:10a6:209:4f::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1038.22; Tue, 14 Aug 2018 16:50:59 +0000 From: Leonard Crestez To: Shawn Guo , Lorenzo Pieralisi , Philipp Zabel , Lucas Stach Cc: Andrey Smirnov , Richard Zhu , Anson Huang , Bjorn Helgaas , Jingoo Han , Joao Pinto , linux-pci@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Mark Rutland Subject: [PATCH v4 1/6] Revert "ARM: dts: imx7d: Invert legacy PCI irq mapping" Date: Tue, 14 Aug 2018 19:50:15 +0300 Message-Id: <11c9de513fbbc39a07d9e9892e7172dacf49a8f9.1534264292.git.leonard.crestez@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [95.76.156.53] X-ClientProxiedBy: VI1PR0102CA0077.eurprd01.prod.exchangelabs.com (2603:10a6:803:15::18) To AM6PR04MB4293.eurprd04.prod.outlook.com (2603:10a6:209:4f::31) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5029996a-f78f-4d9c-2ec2-08d602061d37 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR04MB4293; X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4293; 3:hhquarKJKNAUrD7apJj2DyxWI5CDfI2cvMbLYnNFWzUq2c3Wu5DmvOGSkN+2SSZAbXe6+tGZKtoADkLMCD9yblrLezhpZsaeiqKgbRieFNzX6Uoc0ATAfGq7aWEni45hH4PUDHl8K/ciPf77ukx+OAImBrEkxIr8rfnh6v3VFvduO78eQLqmP+PNXWEIjmGi5TtGZc4ITpap57PEkWA6MbCVvHuKUTM6ZShAcpVmOpC/RnclcKcpJXTOkv7UwzUQ; 25:NCsun0SQenJkNH9B4QrufLzjiSlvY5XRmQjCH9C2qX2MkJOq62PimjCTv4d5Mht66hpel4FWGyyMJCYrCpXgqjpI3/c2tgTDxG3RYwgETDr9kFZg4II48BYKpfxKqnKAIMWeZxMbwGIectw3y6x20YTEAtOf+SdyhnWgeZ+7pXmfhs+XZ3mZ7j6LtkFq8efcKk/lWmKYnhU+dBdUmP4f2tDVHLhoPE9iYYL+ivlUSmUDm6KbkqtZwsu72v+U55F4eQEJc60xJiFX49FD1x5TPS/mmdhceSrYIkwkRoBSp0x0ViGpaXlKdO/zPDRpRPOz6GWAmqsp2+NrReoIon6kkg==; 31:qipQSYrblDYSbO4yo6eG3EjOPw0gEu60nwQdKviAzVBHVe7x506V7TwGlMaiRsxGIvFA9EvlTWhcrgbosvSRICdcuPBh2QDFJACssuwiGrzhzzSdMb9VGRE26/Tmc5gZL04p1ucXvkfX0Nq8yfqHVGjFhzwUz1XRokvYMANLzyKqiCAxYCTUxeHi2K01+eJZTGNJmQVCHdpIG/76j7U7hlSdyeiVV7kOCBpUS5st1kc= X-MS-TrafficTypeDiagnostic: AM6PR04MB4293: X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4293; 20:UtDqOCjAzGPmWYl4dKLxo8cjQizeTZAZEVcjsxvazLCptNm/VbgIw+fFzHRYzXzzYwSx4VFQRcHQqpzNbsMAklfsqFYe6JqPxyqhbpbuGbLM8QFwBvk3HZ9OHCM8lI2oqEO5ESNxqfk4joC/zG3+an3L8neQk6uhvQZM35Gm38dLqOC4E5JxY3MjQ9sTq4iNs27POAaxfnRBrVOVAvIKPiWw4qwtbdNMlk+M39XNGMBb7/dlcUqxxBNqE9rZ2JEKRjhSzvur+pCGLrnA2Z0/iUPLiT2ut92HxbY0NBsPG2BE3wa6HsLGlKvSVfRqPkQuq7PVgv4cve4A+PT1QoqnAwnPQKLyLwaTd+GZfLosr0nVxvwfmo4D3LvymlexMqvcFjY9tkuNKPxZTo6mK9YNoL/kbFpr5jFBNMyn0lDyganX+befpxF6XhDCw3j8VXoPQGi199wkq+bJYSw34j+/NxJZmZoXRXe9QaY6Or6NfDt/j+LcnHoyrl2+ukIi/RZS; 4:s0IBJt59g0h0Ddd/9rcYMBJ8M/2aRork+PEmB/1tCJwiUm/B9iQOIir6thGBo1Jj1Hzf4fM2Nar47BlgE6H7uuMWSkTXqZP7ntD+K47fO3hhiK4YC1X9Agfonw0iIOcELu91D1y17DBZ3NQuGzgc9aOihgcRsz+Dcn1hpkmMcnDCzxo2hvhczMQJPrAK2V3NzOZKwC/9dDDhZYVnb+saG/Lsj8+/g0jsy+FP9IWmkF/Y5mj99h9R80bx6q4E/Gqj4Q7xibqsAw2bUainvCl1tTWqE0VmyQgqWeoDfVk8zEpEsAh8podqydhPkuWkz8z0 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231311)(944501410)(52105095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM6PR04MB4293; BCL:0; PCL:0; RULEID:; SRVR:AM6PR04MB4293; X-Forefront-PRVS: 0764C4A8CD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(396003)(366004)(136003)(376002)(39860400002)(346002)(189003)(199004)(118296001)(16586007)(6116002)(3846002)(50226002)(478600001)(36756003)(16526019)(316002)(386003)(26005)(186003)(97736004)(6506007)(86362001)(2906002)(68736007)(76176011)(575784001)(54906003)(8676002)(81166006)(81156014)(8936002)(110136005)(66066001)(25786009)(50466002)(48376002)(446003)(11346002)(105586002)(106356001)(47776003)(486006)(44832011)(476003)(2616005)(6486002)(53936002)(51416003)(52116002)(7736002)(956004)(5660300001)(6666003)(4326008)(7416002)(305945005)(39060400002)(6512007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR04MB4293; H:localhost.localdomain; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4293; 23:4C1qIcpvQczTcYfSuxte3L1tE89YzjJwbvWUkniYb4i3jyLKivvS07+myyNfIioonw+cyKt1THOXRAsXapovHJNiE2GWHa9Q54yHaVfkFqgrwmi1hgO+VpVzvSM0fh7095W1ab1XFWb13Piyu+STMFIxzO3bSGIAqiOhl3wkODSWGpIAyI2bZAKxQNo/L9jKyd0nNnSzFY7QatWNjrLO5q3vzDtAsTElxyPvoj27dWceDPxbhlL8z//O6ZFcZ6TDTXIb7dB26SkvuRkBqt3tSW7yFQWX/WHFPjWKF2h25kBhkBsM5bJ5PScAKMkml3N2PUe39OlWTQRq/Yr4WidbByUaCIDoEhmecuLj0rK2U2mU8KKDdpYrFSJTf2HhNmliEKnokJOz/gdnZuWSIj2HshnFT19TpRt4I6fbMDCP6G4W8cKtIDI7kcM0V033p6HUJLIb1Er5AzFe6iRBEk6FLUJ0RXwMdVOTbvMouzFpOjY94iDU5iFcqZJnq4lytMVySX9Y/O0Oi2hld67nL+1Zv2TxwUO+8HTsXaWB6ZVfoWgmWPNe9ClBWKvJHBS9QHa3S0YUoyfvXgaGb+eM80Dy5nOEtzqMlDFruZ76j1Jvj24N6cluftb1ZmAS9OpssSYtlVLvcH4arQY2NBpoVZpQbEv6JXCvuGET5M8mdGsC6Te0dYuJUrQTiHe7Wh1mKWyMBOhJyE0bg53YYQSGDdIegn3fp4DSLj2APyizlaSFvKEjHM7aNGlQ32DaR7WxP6kcOeNJxKwQB6owSNEwiadQ7LwOCCqFteRaVh4xwd4gW8fQrlKXPAzpf0dgY8bBTTlSWTqomycOKrP5XVlzOoz54NLX6KRbgghBBo7KmCmUBir2PK/v9nZaEDMDpYw1GL6Xjul8X4EyOlZnE0cqrYnihsci/ig9Gp4mFDh3978wxLtPxWIKNmA58J1g9ZDpCxb8sqpXTsSVvKECN5PN618hT0auxr5NniJZljmvMZfvq4rFNU/qj4QfnRW/TLhUvZi6uRLtuusQwxDCd3hMOvSQ6Mcy2bjX3w8RESGlDzQhR/k8DZ101AnDLzphv151xIt3bBpFQcxNh2aRvXOSVK3rzNMlPjFp24Z2lPIwFOYV72OCreONYIjQTfpZWdhiURa5uxwx+rzi4JivpPfbbOirdn6UCZxvrkSxNXisycQQII0LCDoHFlu93JjiK60Lv0Ae3zxpuPTFcBVSeBc6UEn14SsUieacKiqp4CWAlA4IPJRtYULswIxSRlZY7g/+Tt+n+6YfXcTtePHLMS4+LewyqGEd2BC2PY/gJMCjwBYtxwE= X-Microsoft-Antispam-Message-Info: +Ma9FnOD+PBLUjXbiWSx4NZDoc5gFkTWGdCcuY7vg9xXA5AOC7wzQh7TE6OA+XkB69RYw+gk96xjL82URteRPP7RI10q4kpqGt4F9DBuTfUhhh2QLfxjrUTV3QYlk0sH8dE8rW4nlltO6AT/OiS0Zx7PjrpdfJOvCJMfeffyx3WwQt7h/uzwmkbVUeQX62VGIiGRyBXjrSB7T6Axc80QRiV16gmdsfzgiUoiADgUYRkMcWTZSEcdPtgByy07XkOIZMcgESKpBRG21zrBq+r8UPF6CMUrIGouK/yaW4qkchuA4AW6q+V+TEH66NROAzFu2oKpwW1AT5JDBUNcn0kzOq5BQYl12CSlXFhgMb+b9Xs= X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4293; 6:nm0bjwx7FwUD7CbTNUG7ls9oIkiAntCpyy6A7Xrs6i3SjUdDCUSoAiST2AdUZ20ucEr+j2QJEsYe5FY/JpLDzccG/I5bW1MweXgOj+nsTb6iarG0qM9MFuFWexAmLEJ+ZnmSCA761Bc5c/cfNVrQzOmYm5lddrOloH9LMVh51oOh4cc0L+A2eDQuZ4WSz7EOVjgWKOS6Gk693mGxRq7Vvp0wj8VjthVm9Yv0OGGq244DLUVM6e3TZziCJwYLa7OufdOty/KbzLnMdF4Dza27yOqyHQ965u/lqj2ftTf85U0eWGXMnL1UKaNHQPOFwpfFKNV5NFesDLY7goumvTeM51M/xHyWzIvOH+G0f5v5zmeObFdffhUWSF7RXW6hzMwTOOoRZfdyq9kvi2xMkxL3fIVASxEyCo0Px5ypgK125+jVq0VfLfrR69hucz7ogqaMVbcVr7Alb8+5X/sbJOGAgA==; 5:9XxmAXsftzp9NdOmeodjyi9/lxqIAD2wR1LhsvWwYAXu92FpF6N6RcINmFBBIIRpaeoJ+FCdbEslPArWvAJS+UxTtM8dxECwi453ZhKYWkl7P/RheeZMgLFusDeMawcu0DYG7p2/JlRtC+EFWMqYTKtmkdc8CatK79vMaX8LPZk=; 7:Qr6BeX87P91y587Rk9+/g0UngGmV2AheWpGD6L4XBCW+7l9b/ip0197LoNkACcTgfp7pXO/xsBg8d9mlCwJRrU+TNIoTtORGtrR3g3Md1LKpBQ4AqEjl+CPd7WTZ+wB8kx8a2WtLcFmltu1JVPBP9ldmFABKt0peTlEoJh+aqifBDheGftRGVf0nRM6DOzcEfDQAztH3+MrKfEIy91VXhl++4VVIGIYtWI4IWjeTlEzJdAybwAjrXuGt+jjxWI7D SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2018 16:50:59.1571 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5029996a-f78f-4d9c-2ec2-08d602061d37 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4293 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org This reverts commit 1c86c9dd82f859b474474a7fee0d5195da2c9c1d. That commit followed the reference manual but unfortunately the imx7d manual is incorrect. Tested with ath9k pcie card and confirmed internally. Signed-off-by: Leonard Crestez Acked-by: Lucas Stach --- arch/arm/boot/dts/imx7d.dtsi | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi index 7cbc2ffa4b3a..7234e8330a57 100644 --- a/arch/arm/boot/dts/imx7d.dtsi +++ b/arch/arm/boot/dts/imx7d.dtsi @@ -124,14 +124,18 @@ num-lanes = <1>; interrupts = ; interrupt-names = "msi"; #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0x7>; - interrupt-map = <0 0 0 1 &intc GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>, - <0 0 0 2 &intc GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>, - <0 0 0 3 &intc GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>, - <0 0 0 4 &intc GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>; + /* + * Reference manual lists pci irqs incorrectly + * Real hardware ordering is same as imx6: D+MSI, C, B, A + */ + interrupt-map = <0 0 0 1 &intc GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>, + <0 0 0 2 &intc GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>, + <0 0 0 3 &intc GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>, + <0 0 0 4 &intc GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clks IMX7D_PCIE_CTRL_ROOT_CLK>, <&clks IMX7D_PLL_ENET_MAIN_100M_CLK>, <&clks IMX7D_PCIE_PHY_ROOT_CLK>; clock-names = "pcie", "pcie_bus", "pcie_phy"; assigned-clocks = <&clks IMX7D_PCIE_CTRL_ROOT_SRC>, From patchwork Tue Aug 14 16:50:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leonard Crestez X-Patchwork-Id: 957592 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="s8yYfi4K"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41qdt13FBlz9rxx for ; Wed, 15 Aug 2018 02:51:53 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732988AbeHNTjI (ORCPT ); Tue, 14 Aug 2018 15:39:08 -0400 Received: from mail-eopbgr60088.outbound.protection.outlook.com ([40.107.6.88]:21050 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728458AbeHNTjH (ORCPT ); Tue, 14 Aug 2018 15:39:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xeAPlxJejbTEhRZ3mbDL7cvFdqYLwf0Bx6eDOcVL78w=; b=s8yYfi4KG5lK93TVlIQnJ2orb00mv+MCBjHNdc8hiI5DN2ofBE145tdACKLwU2Ly6sOKbr0wvS1bTkERcKtUJ2+9x/7F4Zn+pgCD9esEBKjaMvoDNQwf+9tGvomETDajH6hXG3eP4QB6AGaJtS+y0WWKoKzSp+2xOYv5aIEU48Y= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=leonard.crestez@nxp.com; Received: from localhost.localdomain (95.76.156.53) by AM6PR04MB4293.eurprd04.prod.outlook.com (2603:10a6:209:4f::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1038.22; Tue, 14 Aug 2018 16:51:00 +0000 From: Leonard Crestez To: Shawn Guo , Lorenzo Pieralisi , Philipp Zabel , Lucas Stach Cc: Andrey Smirnov , Richard Zhu , Anson Huang , Bjorn Helgaas , Jingoo Han , Joao Pinto , linux-pci@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Mark Rutland Subject: [PATCH v4 2/6] PCI: imx: Initial imx7d pm support Date: Tue, 14 Aug 2018 19:50:16 +0300 Message-Id: <4b786ba5d84a0ba90d2f04beacedb0de1e529fd8.1534264292.git.leonard.crestez@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [95.76.156.53] X-ClientProxiedBy: VI1PR0102CA0077.eurprd01.prod.exchangelabs.com (2603:10a6:803:15::18) To AM6PR04MB4293.eurprd04.prod.outlook.com (2603:10a6:209:4f::31) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3322c2ed-c278-4889-09f0-08d602061e0c X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR04MB4293; X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4293; 3:pE0ieR4/dAnmg1ZgB/3xLSvyodgwNdazKFzG/q7WRnplBQDH7aN22h7Dg6qP4MvBEcEL3L6EZB4ftAuqRjTfnrBtQpdeq9uDMCxgi7wkVnAJcOj/nPty4+8/L69t1EtKcCN9OVGvlLbI+iqlQ6uRF5T0+ndGZaLnIxkKwVAUphP0TiC6HY6klXhS8U+OmlCQNfcwquMQddZiLj/St6WmezSDQyV6gJRQfgzGkmJQT3j+DBgyhnC+7HP+2KtZDWlP; 25:cKrXMV5BCuzmi+NjAoweVOncs8TRtPNGDN+8lROlT9l7Ig34jjRS2TuRpLBT+kzwVJAokkMZrEXNDR7IZuvPeDeNP8ieetkfz3FfGZAUKCw27wX0EnGed9n45TmSoqjr+Q7NCQs9zDeBG52a1OkYmsWr9/pJlBzkcbrOUq+ws1/FrWPSRp3Src8yFDHJ/8ezd98HPIhW4NRxzTOv7ijmDk/L+kvJEuqfXrZEhiTQzauL/rojAMppAINThRCTi32jTsLAygWdNRXg3g1rTv2SUvZMbtklMQK4P6a4hvnmqQ3lDcK2f0jGZMtxMVyBeV0YSDFnIlRd3XGMoBQF1yK3Qg==; 31:3iV1V64zwArz9kxwa6vAZ/9K7lebXxWnTnGhZ5eOe6W8LucmAZRwnnIY+Mgk7cXuxBYU+ZgvWyYH/pPAipAIK3NVGKvXrrfADACSXAPklQxnmrclCGat+rhPSoMPcHP3D2p/J4e1g7wxwfo8mcYVDHTKSwIR+QxLMYM7trreR9Avbvg/NtM5oBkxecJ/HrNeiAX7zFbXXgI5aop932EVVXGpxdh2lhhugs0Urihjtj0= X-MS-TrafficTypeDiagnostic: AM6PR04MB4293: X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4293; 20:YAFB+fFRrvdcipJfmQkfPpBT5ArTNj9NhsrrlnEipxnim00a9bM7U1hD7QzGtcufZ6OwMkQSTI1Y4KoQNIkejsRZw5O69lStRGTDDXI9fJKyx4kI1fD8sQQpzSGCmcTP/1YLxd/De4moCAsr3doHoM5E1uR7UVOQIOBuQsbRwLuGLdZ/YMt6+9MpDreHW9+CB1Xj7/7GDWqVlh3oY9F8HmwNeFkEucxCtIGW3xi+Rkvqr7Eq0Dmpmw9ONzEcxAAoFoqUKEx6T1fDZg8EReEFzeQIo5GLqH5tSKpB0rQIMnv5Cn4WFfsdSViDPu88xjSB+wbvZkmdGrPmgGQvd0kTQlKfgTCxKT0eMQBegNma8Nc0GrYow1lxv0Yltt4vqrnK9EdXzSWdfCPuSQbskTycJfhlsmAIUaJ82X073hHvriQwEK87rQAj1U8WD9tVaLTpp8uMbzEKBubIUliqlFVkfo2J30eX5fYAm2yeiFM0wr0MUdjv6uFNOAXQgF/LZmx3; 4:vMSKKL1ZKOZkPXOAkM94S87ejULsivQLVF4mLcTznjmT95Wixz5KQXbvKFC3bjsrqIB9bq4WPruIp5+fFEpb3CjKkKOEgdXNPrlECtFQnE2vd/jET4chCZ7qm4xxte+l69qYZKnADBqQ96gKgBVUWwxuaIz4pBSW+4dgMtmfNZnvO6P1QJLxHiVhATOLEYlUgyv+Kmt6hFm7gzMVEI/o58az3DWcQmZL41p7CWIFXjXHVTit5JOeCWI/z80ZtEC7FaJrPS2dCzL8WUoZW0QI2nRG3CB40oiNfZRMUdzEY4NxqzkC/gIXwO3HpHY5UzwJ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231311)(944501410)(52105095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM6PR04MB4293; BCL:0; PCL:0; RULEID:; SRVR:AM6PR04MB4293; X-Forefront-PRVS: 0764C4A8CD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(396003)(366004)(136003)(376002)(39860400002)(346002)(189003)(199004)(118296001)(16586007)(6116002)(3846002)(50226002)(478600001)(36756003)(16526019)(316002)(386003)(26005)(186003)(97736004)(6506007)(86362001)(2906002)(68736007)(76176011)(575784001)(54906003)(8676002)(81166006)(81156014)(8936002)(110136005)(66066001)(25786009)(50466002)(48376002)(446003)(11346002)(105586002)(106356001)(47776003)(486006)(44832011)(476003)(2616005)(6486002)(53936002)(51416003)(52116002)(7736002)(14444005)(956004)(5660300001)(6666003)(4326008)(7416002)(305945005)(39060400002)(6512007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR04MB4293; H:localhost.localdomain; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4293; 23:xMRMBBTpYqWO/4fWXOWMx3xKAuKfOOfkCW0lQqeKYPu1h0bF1JK2b3UC/RC2D5mkO4dHYtMe6gzSSy0tvJaz64DQnoqduaESJcO63jRDStZLThW2d+au9LveJBKj297B179u61wmRAFy3e2IwICwY5h7YDyE4bRXm4MP5/P3FaBUUWShVb3dF6DhRC5yk6QSzIQD+cu/8A2BygwUus3nl6L39Hz4IL//prlTuEst5OEmi3PBj7NX7alwBHPWDuDkLJMOYN90BNLijWOThuI8I0RwPZ0sX0qecILI2t3jNpCCye7dJieKg+o72UJRFou/a1n4tG0LMPIKYza7ebBeqxsLeoeq+G1FUsocedzR7JQbee9GOLFoJ4ZZohS4X7fcbO6VQbSlaY6CSnJah0Pfc6+7/c5Q3jDTwEXDDeI7B1cUZRKvsnLDB5ZDbGicdxf20V1Df5kWMe3c1O2ogul05mucmCKwKLusfs/bgpEsH07DevuqcOk2Qhoa0BFCuAl8yA8O6j8fD9VI6ddWoHMu8TJEavs+NnV5MsH6NjXMl/l5JptYexxHQBZvKrJyKabkBdKgA0tFa6onBjGJzirz6dzynhUKeBihkVq+/SG4gSBYkxwrM+KS/ys4O7u0Szq0yc/9dchxEtulIC0m3ExfafGjcHKWn1qeUHB5PLFY5Mke3iTFkGlJKZ28w2MuM6p3otu2QHo7hLiqIMtg3kEzYp3BEiXcPmdhzwWjHHb9/su+KFkh7CNKXFHvR3empwm7VZhlEyH+r9lb0hfnO9ewG9QIO8ANYQNKqYfYpG1g10gRiBBeUq91VCstxb1v2dOVy3VABQWFgqLpuZLCRu65os742B0c5H59uoic3vz09/EwqHKSe/GyYng+98AnywMKH4HEI2zQIGfYNPjBrs/XcFG8KkRV9uEmMh80nk6EecQoN7da/v2KPXtmB4a8oMqY9se7kfGOrvyVbhNz4VGmpmw2zTUoeawNK5MFIPAobmZi7G/VOl0BnpBuVisOqCu4cLC1ip9OQOGS6bmdWmXRi8rannr1XB6Nm7B8q7wU9BklrBxcZi/aIkpouNKvNUcJOkESdjQqR+MxoBQ1dsVCOLTnqXnVxNtr1lZh2sRa3fHvQ4YZu2I9e4tC0ouY6+YDmZbO/TRQD2QI5vPQ0zBwmtOjB/l3O7srS2EdXB4hcS7hUvMyJX+nRM3b9JW6VyNRweIIxecCRpIsQTM/KUhg4uoBYDa3rqkD+CDJ2u2M3F6AeLBxQqcmOKRv5YCIFCz9Xh8hFG/X93JtlprEMLhwF+K9CflhKeUov6ZdH9OyLwrg3L64gHpGiCsWwZMjrUF2 X-Microsoft-Antispam-Message-Info: DNq9B3612BCMgWOujXBcaFlxBuyRLysecEsNEvJEaDMyghKR/VGNVjV6l7quCVyY3BdOEpbPH2InWhIJfdsza2LWD7i/qCZETCloD9NRan4ON3NP0tEzagQIECB3KNXyEFmUQC6oalBJFyIlGIGmGR8BrJ4z/LfTrE7v6sKiDr3PK2HPkSdZ7erFJNiNaGXGWeAwTN3LCGaXovKHavoBP0d3GYuLT5BJHkWih9brgU8jSm8EpHKC7orM+PAqsMrq1TBiRg/k2yuZDZlTw1zX9mRF3IZqkOmI5K80KTDpqYE3WCqj30yzwFiMRFInklbCTNoaZGxgF8R5VNMk7dKxb8AMtAFQ+kj4tsJCAGLDL1E= X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4293; 6:hysyMJ5pQzXexq7QG+cIV0W5WD4ox+45JAi//vu8WH4pavZ3+9hA0WmFLqesNfAH0irC8g2FDJ6ilhixnbiCxWlDxGl3h6U/9wWMxxOv4yGl8hGJddU7Olc+t1ALaQLXLxZl7CejOck1GFkwlx5Jwe1sSCcwGx1wV/rbhUCAJssScYqFzU4mn0ZcGbSbPFJTqBAkxvzB/s1+gOqzG0WKJylqDmsSj8+aKwVENAPGAp7lAeKynROHX6u8E/gia1lxB8/YwBhORsS9Yn+FYUOQhQk5f+b9DnOuUS6DCRAOry/m2sYfO1MOdmRTl3LK8XIBE9cYZSZHPdLzpNPHRIoMld3OVPI2FDVRvXtTgjeeJO95MeRaIt9tqyrkA9/oeSJcT62CpmFnxyAiAylaE49Ii4AfORahzaAi7FTVkCwUyqizrObZX6KH3knuzu9xM/DA70ODH8j2R+fjs/AqL4t8Tg==; 5:4+mVTB2bVUrNLUBj1cGQeAzXLeo1hmn0cmH78U5HlnG9SKP5smXr1+tSjDWYJccVcxj9oKVznqQcaPR92ifjSsmnp/7NpYQAENQTCa8aH47gsJtDnLX6m1MSBXBcw2f0kXSRtV+YlTtxGDtKZAhZrb71089x6unOOJVPwj1g8vY=; 7:nhTvNRQljMMWFy7jksS3VpnFUZvfuTfSfYsHvPDmbkuvslixDRON6ohy8U9U6Q6jwI7taZ9x4++5kf9h/RDUf5dHdlosSQicAgi6UNFyIE8wRfGLqP+KssPylIlpKJdiQPsL4fVcQbp3THsu0IfrtD1iCqK8ZrqaGO8rCeSyVyry4Yso8lSVFAE9ZSmBbIHxfmql69aa7srBXY9KHvi9qP0v2jhuo8CcoYCqlub2/kpF1beK1guA2wb97LGbXhgv SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2018 16:51:00.5520 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3322c2ed-c278-4889-09f0-08d602061e0c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4293 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On imx7d the pcie-phy power domain is turned off in suspend and this can make the system hang after resume when attempting any read from PCI. Fix this by adding minimal suspend/resume code from the nxp internal tree. This will prepare for powering down on suspend and reset the block on resume. Code is only for imx7d but a very similar sequence can be used for other socs. The original author is mostly Richard Zhu , this patch adjusts the code to the upstream imx7d implemention using reset controls and power domains. Signed-off-by: Leonard Crestez Reviewed-by: Lucas Stach --- drivers/pci/controller/dwc/pci-imx6.c | 97 +++++++++++++++++++++++++-- 1 file changed, 92 insertions(+), 5 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 84c33e0c049d..926858701726 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -584,10 +584,28 @@ static int imx6_pcie_wait_for_speed_change(struct imx6_pcie *imx6_pcie) dev_err(dev, "Speed change timeout\n"); return -EINVAL; } +static void imx6_pcie_ltssm_enable(struct device *dev) +{ + struct imx6_pcie *imx6_pcie = dev_get_drvdata(dev); + + switch (imx6_pcie->variant) { + case IMX6Q: + case IMX6SX: + case IMX6QP: + regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12, + IMX6Q_GPR12_PCIE_CTL_2, + IMX6Q_GPR12_PCIE_CTL_2); + break; + case IMX7D: + reset_control_deassert(imx6_pcie->apps_reset); + break; + } +} + static int imx6_pcie_establish_link(struct imx6_pcie *imx6_pcie) { struct dw_pcie *pci = imx6_pcie->pci; struct device *dev = pci->dev; u32 tmp; @@ -602,15 +620,11 @@ static int imx6_pcie_establish_link(struct imx6_pcie *imx6_pcie) tmp &= ~PCIE_RC_LCR_MAX_LINK_SPEEDS_MASK; tmp |= PCIE_RC_LCR_MAX_LINK_SPEEDS_GEN1; dw_pcie_writel_dbi(pci, PCIE_RC_LCR, tmp); /* Start LTSSM. */ - if (imx6_pcie->variant == IMX7D) - reset_control_deassert(imx6_pcie->apps_reset); - else - regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12, - IMX6Q_GPR12_PCIE_CTL_2, 1 << 10); + imx6_pcie_ltssm_enable(dev); ret = imx6_pcie_wait_for_link(imx6_pcie); if (ret) goto err_reset_phy; @@ -724,10 +738,82 @@ static int imx6_add_pcie_port(struct imx6_pcie *imx6_pcie, static const struct dw_pcie_ops dw_pcie_ops = { .link_up = imx6_pcie_link_up, }; +#ifdef CONFIG_PM_SLEEP +static void imx6_pcie_ltssm_disable(struct device *dev) +{ + struct imx6_pcie *imx6_pcie = dev_get_drvdata(dev); + + switch (imx6_pcie->variant) { + case IMX6SX: + case IMX6QP: + regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12, + IMX6Q_GPR12_PCIE_CTL_2, 0); + break; + case IMX7D: + reset_control_assert(imx6_pcie->apps_reset); + break; + default: + dev_err(dev, "ltssm_disable not supported\n"); + } +} + +static void imx6_pcie_clk_disable(struct imx6_pcie *imx6_pcie) +{ + clk_disable_unprepare(imx6_pcie->pcie); + clk_disable_unprepare(imx6_pcie->pcie_phy); + clk_disable_unprepare(imx6_pcie->pcie_bus); + + if (imx6_pcie->variant == IMX7D) { + regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12, + IMX7D_GPR12_PCIE_PHY_REFCLK_SEL, + IMX7D_GPR12_PCIE_PHY_REFCLK_SEL); + } +} + +static int imx6_pcie_suspend_noirq(struct device *dev) +{ + struct imx6_pcie *imx6_pcie = dev_get_drvdata(dev); + + if (imx6_pcie->variant != IMX7D) + return 0; + + imx6_pcie_clk_disable(imx6_pcie); + imx6_pcie_ltssm_disable(dev); + + return 0; +} + +static int imx6_pcie_resume_noirq(struct device *dev) +{ + int ret; + struct imx6_pcie *imx6_pcie = dev_get_drvdata(dev); + struct pcie_port *pp = &imx6_pcie->pci->pp; + + if (imx6_pcie->variant != IMX7D) + return 0; + + imx6_pcie_assert_core_reset(imx6_pcie); + imx6_pcie_init_phy(imx6_pcie); + imx6_pcie_deassert_core_reset(imx6_pcie); + dw_pcie_setup_rc(pp); + + ret = imx6_pcie_establish_link(imx6_pcie); + if (ret < 0) + dev_info(dev, "pcie link is down after resume.\n"); + + return 0; +} +#endif + +static const struct dev_pm_ops imx6_pcie_pm_ops = { + SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(imx6_pcie_suspend_noirq, + imx6_pcie_resume_noirq) +}; + static int imx6_pcie_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct dw_pcie *pci; struct imx6_pcie *imx6_pcie; @@ -894,10 +980,11 @@ static const struct of_device_id imx6_pcie_of_match[] = { static struct platform_driver imx6_pcie_driver = { .driver = { .name = "imx6q-pcie", .of_match_table = imx6_pcie_of_match, .suppress_bind_attrs = true, + .pm = &imx6_pcie_pm_ops, }, .probe = imx6_pcie_probe, .shutdown = imx6_pcie_shutdown, }; From patchwork Tue Aug 14 16:50:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leonard Crestez X-Patchwork-Id: 957590 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="K3n85g4S"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41qdsn0wBVz9rxx for ; Wed, 15 Aug 2018 02:51:41 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732956AbeHNTjJ (ORCPT ); Tue, 14 Aug 2018 15:39:09 -0400 Received: from mail-eopbgr60043.outbound.protection.outlook.com ([40.107.6.43]:35184 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730635AbeHNTjI (ORCPT ); Tue, 14 Aug 2018 15:39:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3VGMWyKaGbdJVhi0fowyNCTvV/S41e6KiarWsyVHILA=; b=K3n85g4S2xGdEueUfRVyhBhoyc+ILrXLfJmDAKdCBQdU7YI5vdcq1CXOlMI0dcoM/xjAEqHmWGlkrjfuxtlfboQuIC467GPxk1KUM7Qsxbsm0Yi73w5z2bs4vWEDu+FR4K9vdTyU1oYHigBFBKQlBHAGRm08x4ddxdktr1lgCrs= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=leonard.crestez@nxp.com; Received: from localhost.localdomain (95.76.156.53) by AM6PR04MB4293.eurprd04.prod.outlook.com (2603:10a6:209:4f::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1038.22; Tue, 14 Aug 2018 16:51:01 +0000 From: Leonard Crestez To: Shawn Guo , Lorenzo Pieralisi , Philipp Zabel , Lucas Stach Cc: Andrey Smirnov , Richard Zhu , Anson Huang , Bjorn Helgaas , Jingoo Han , Joao Pinto , linux-pci@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Mark Rutland Subject: [PATCH v4 3/6] reset: imx7: Add PCIE_CTRL_APPS_TURNOFF Date: Tue, 14 Aug 2018 19:50:17 +0300 Message-Id: <88a5997e37d048cfc2dabb44cc13dce89c93d5eb.1534264292.git.leonard.crestez@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [95.76.156.53] X-ClientProxiedBy: VI1PR0102CA0077.eurprd01.prod.exchangelabs.com (2603:10a6:803:15::18) To AM6PR04MB4293.eurprd04.prod.outlook.com (2603:10a6:209:4f::31) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c0e1fca8-f185-43a0-085f-08d602061ee3 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR04MB4293; X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4293; 3:JeIAyNL+kEuRLMgZ+LoFqgFooG968iMzF7G1iT6GoaOHS89TC2c03cK2c+Rpxk84ldt2Q7HLV6g7/21KcpTgrHjatZCKxItwgg3ZKdUIQ3uUguJBp3delS1rPbCVpAlG806+0LRXiKoKTm8Tn+hDko9VYRD6B1/IyI/V34qeyNKHWYReoHR91pcXqlKVtSS4xNU0W7Km3PVsEW/Dh6+k5QVtU5gCygfGPHFhacnj7D+781afp4O7ifIpfyEnuwdM; 25:NynLjRbEw3ngfaZhOmMvUTuOPSx+5KI0Ogc1bG/iYFbzNp/biCaR/vUnFKOucJkc3TNkj4nRhMVd9ntYL4oqogo2nF4yu94uVIobrLZeJbfBRfh0TWPbHdnKC9i4Se6cM+FyrlB1FwE9xwNKlxFcQq93OSUGaoY4BtjzsCuAJF93JjNfUSaGScBlFoSeQ+Vfks55SnU9rbLd6JdFeikxXHlXP9BLromNAkr7F5mU+gsR0Hoz9XE0kWaDRhtgWfGafPPUkudtKnjxG9EPGBNd+hl+T1m5Mi5fXWo4JuSRpVne80gcWu7dq3e0nvxjJ9xlJuV0hgfzGiza01tQ4PxbiQ==; 31:rEqvgVFyk19iS9vlz7kCaBQete5sdJVJKUrein/sF19gZjN6ty2XRGSgwTqqtUB57VqMugydi7AStG67YNf0iynN6XC/AhyEj8q6kE1x0ys7CwCR4wdnHvzl3t2aHx8hcWJ2W+Y0J1uq97jy3hGhCjeV+Afl9GLWbN7/g6YEzPFZXWMtrAZZUA2f/Emj3ADKlViiQTdE/WK5jA3gEiIP3S2hnCGaaIVBdr7bgqgVaLA= X-MS-TrafficTypeDiagnostic: AM6PR04MB4293: X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4293; 20:7vAHN6p34LP1eGI6+s5pPd9q8ziffuD0Pby6TkAwprNLycWmj2wdQ4vKjL9vy2rWn5POG6XaIXpgo3D4AN/oCpHelUmxb7lImHnDG6TTUu4L+e8qQhVSOLTSwP3UHXNbHHt23tANYaT6hlsNvnQR3b5cEHFELVOfdo1NZzGLHKQZzP1gwYbyI9/2dOkpNf7lt4N08hGtwZdF0FMKt1Lwor4HrfnDu4e+/0O22AdeZB74N7AvuTlcdHTZKxyZx+uKcS63+Te+nDTdycKZWfkWlOyWcK/80YcwoJjwKAR/3+kYHxwjyzDTdJdC34a0ZY35/6jTDm4fQeL8S3HDJdaci/hNng2OZub8dIUb5LMWj5jK5IBBcUAqEBotBYBTYYK1xbl9VgcgTwiuEXjFj3+V36nl5IkDuO+gHQ7LB44FLBQkrSpV/mc2sDnpIjDeQFKHcpxhmMW3Wx78VHNg5PRdmRdaJEiNUdYOr2bXl2ITIcAEG9nDToXYGlq7wsrJsxE1; 4:nATnb+Dv5wOL4P+4py9iT3yYaDuptlahzfOUULRc4obX7aIhWEh3r+mrq06ifYBRGOudVbGBHukBC8zBuOpSNhxe0cBza17zKTlzp9NXe8w/MMb7lNoyy1tP7I8bZbUaU8OITrl9yl2gCcaa3cpheUNXZn25k833n+8ixrp3zdnqEKoUgjBs4AKDzbiYDezKQEbo64T6Z5FOXPmnIf8nE7NnWz9gbnaBIUeBefLLtemfwYRbrxInc//ohm3BAWsDrGvTp5S0KUkIBHzu7pZNx+n62SFCXMKvW6U0Q6kzWNkMa3DxixvykM3/ku71n16/ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231311)(944501410)(52105095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM6PR04MB4293; BCL:0; PCL:0; RULEID:; SRVR:AM6PR04MB4293; X-Forefront-PRVS: 0764C4A8CD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(396003)(366004)(136003)(376002)(39860400002)(346002)(189003)(199004)(118296001)(16586007)(6116002)(3846002)(50226002)(478600001)(36756003)(16526019)(316002)(386003)(26005)(186003)(97736004)(6506007)(86362001)(2906002)(68736007)(76176011)(54906003)(8676002)(81166006)(81156014)(8936002)(110136005)(66066001)(25786009)(50466002)(48376002)(446003)(11346002)(105586002)(106356001)(47776003)(486006)(44832011)(476003)(2616005)(6486002)(53936002)(51416003)(52116002)(7736002)(14444005)(956004)(5660300001)(6666003)(4326008)(7416002)(305945005)(39060400002)(6512007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR04MB4293; H:localhost.localdomain; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4293; 23:zZiofB0kHEC2kqE2zDvN1j5vJl0hlKyH5PLFZPg5PwVIH5dSW4xjXXdFB4ycmNfa0P1hE86wpleyviFSa3S1sFELWczZBZLfOgWjC3ISpHcwHeOgL5jOourGijeUoXKczM8hZejBGtufJM9+dW1gtWbJPxpAJpDpthzIrbWWNlNJimmGPefxgdPMkH5NsWlJXxnpSRZl9bMoseqA8Io4hjHE3ifVYhjR3oDgqQZ0dXJgMfDCbRY1Jx90QfVn9R8BTi64pL08v7Jix4L7VwIKrc1gnUiGWB+KjHEHisJEWMUbG8zwuTCUnyoTyBroLgosFvLtsBba1ST0PUw82VCv9oz9jl0cpgjtKOtwH0+lqLpPBVwyaFwwrPY29bc2RU/HXTix9/gcuQlq0s7WzGoCMPcrK6zw3IaCxzZSfNQNf4ue7zo3QYJ/nME04n4D1m+nEV84oH0E/PvlD8uedT1s+DaqFRpXhlwIVhe1Z68FR4Oy85K0GMirnTXwJZTDocMvQWvGGesUtBSLbi7PRWK8veBl001KA9s5rUvm3Us2cSh+rty3k7lxI3ZaMx2oA6TnNbsRr0JcbstfrmYxun4GDmDbwvAHXWxAEk2X5xXsoXs5qhwf696hauXij8Uy9Gk3Tb8lXoEF+tLaeIbmP6qMvL7UhBmpyngwTaEPrXTC9KPAYpWe8KDOUx7ofrtfJeDOnGczMX10g5jRHX+FmLNZejXovHttrcKhrSfg7m3gscHD436po9Jye6czQah+v1296jLg05v+UNfroGORNrwXUbZKUXXd3nIPYxZSczzKGWVgrBWzDIMpDOJ8oMjLsET+43UQAEGQyu3hxDAmXSuaR76V33ZLxqVkFih5gcrnCYplfxeXLRltaaK+Rcd1qILMU7AwCrfhU/DSMr4AVnm5rLQUQyKKY6OMhJ7LNVvDy7ctRDCx+ThNfjAU/9svSMM0pDIMtp0G9U6W1zuz6kWVjnuh/oA/BEO7aE7Q5s2SHQ37BLzAu/IIJ0iu2VHPzDJ7RuAI7+kZ+SoYYIOgymP94rWp0BM1DxZbbFFXsgwAgsYEfrsFWIIK0S61mv3McTLH7TNNd83b72Bld2fpgGBAOcRs9hYn11pUjjRL3uimkG7ATL9VgoH4NE0sUEov8A0Sz2rDKqwjoDWx8bBU0uWKlqKiSToEK9hX7H2bmmRbkTeKWRo86nOKhlUuduk5HGX5n/XrijbSInljm3k5J+EMxkpQWJ1l0Uox5GQBjFd8v/cfUFYOjZoiDphTusmAxuvhAo3MccMGxJplEmK8p4YNiyPoUT4elg6FbtW/QAQOPD0= X-Microsoft-Antispam-Message-Info: TnlkXaKwiRxgNgkBZcAUQRNEn7o+21TPZUjNywFzeHsw7hJ5GOrai98NVFeScN2KjYdrwiEdXf/ZkL6WIDfMV5UhlQjv5q29TjnMtxa6ADnHMkyed6CaxI3H4hMc4Wq0NDbD8AaQiKvsPLpqIRkQkLt8SwMA3X48V9jwj9COwhyAlPGEfmjbuPH2kjZi3xbssmRMqWjgxkOlYixoL7LpNB9jp7fN1wG/0FjqjiktPx+4tzF9iPAlwPPSnjMLxFz7ajrbhNmYvGcqrZad1ZVyjIxx+hNcpPzoyo+8An0hlBk8FZvK47R45XmWHvsjKjAvVFpqrPYnagLhp6SSBoXD1spppx+cCvCziWpGI1tWOC0= X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4293; 6:CULcE+85jt+GX58VqCHZbxqERUdt4Wd5kMaQBEGK3PzdcWU8emsEas6ivgWp+BL60lr0rrhqrZScYKoMbeMxWl4vhECh7Gkr748/d/I8wWjHxlQBF1VQSzH07JxmzKu/c6ikCAV6Zmy3bOADuiiEsBv+Y4kOUqgfNkQ9LcuoKlS5jh32aIOxb3yUauJf2IugIy8/Orzo6UFUSwhcaSgg2s1pSyomF0udkUYCud8t0o2mZuQDwpE4kHy5b6412OPzqPpVKHTnvDuyP0+OphnMmEOKYtKCUjABy7jOBb0GjYq9Rgct7DxQuzJukw8rM5wwX58AKHAEIHA7BHH7sJ0F9EqeUxvEVwDf17ONgJgzSRjNn93Tb3zbYOfuccNkfcn76VSxmhanv+njez1NlAg7vmsXophC/D9/HGRbJle/5n3YMQRWGvIrzBSnVFtH4z9VqvFf30SgoB6Y1T5hGJg+5Q==; 5:zxfxrc/xyJzNO+IPaTn0yRsQwH6gPOzYJZTmuBTWtNPBPQyDFlMt2f29Q3z8prvUiMGYa4prEkvye0iWQ6XywTvPVRZANUrsDN2ftIeXDzFTBy7EyfNw7TTQtwO/NcEnWLeH/7OEJxj3FUshd0qrGO70NCbOV3d5BEv+j+zP5S4=; 7:yg9q0Y6XTDiPPo4bwxY0tmMfquN1F+5a7E7jFZOZLcIlPMrKTemUtDLXxPBYUM8TUDS9Ld5y6DsHEuAcB9cDvAha/LLW0qSiL770KcgbBkWB7vwZT+KLQI9GSQL7oprB81q+TbryK1R4kjl008t/2Alp7eL14hpBXz6z3baXEYVM5Kl+g6Ayc31euRx+sH7/9esBrWp+sBl+W+j5xBWG3LnSZH4m/IJCnnEwKXweL028VDL4UIWgOsudV8d8HLYU SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2018 16:51:01.9610 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c0e1fca8-f185-43a0-085f-08d602061ee3 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4293 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org This is required for the imx pci driver to send the PME_Turn_Off TLP. Signed-off-by: Leonard Crestez Acked-by: Rob Herring --- drivers/reset/reset-imx7.c | 1 + include/dt-bindings/reset/imx7-reset.h | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/reset/reset-imx7.c b/drivers/reset/reset-imx7.c index 97d9f08271c5..77911fa8f31d 100644 --- a/drivers/reset/reset-imx7.c +++ b/drivers/reset/reset-imx7.c @@ -65,10 +65,11 @@ static const struct imx7_src_signal imx7_src_signals[IMX7_RESET_NUM] = { [IMX7_RESET_MIPI_PHY_MRST] = { SRC_MIPIPHY_RCR, BIT(1) }, [IMX7_RESET_MIPI_PHY_SRST] = { SRC_MIPIPHY_RCR, BIT(2) }, [IMX7_RESET_PCIEPHY] = { SRC_PCIEPHY_RCR, BIT(2) | BIT(1) }, [IMX7_RESET_PCIEPHY_PERST] = { SRC_PCIEPHY_RCR, BIT(3) }, [IMX7_RESET_PCIE_CTRL_APPS_EN] = { SRC_PCIEPHY_RCR, BIT(6) }, + [IMX7_RESET_PCIE_CTRL_APPS_TURNOFF] = { SRC_PCIEPHY_RCR, BIT(11) }, [IMX7_RESET_DDRC_PRST] = { SRC_DDRC_RCR, BIT(0) }, [IMX7_RESET_DDRC_CORE_RST] = { SRC_DDRC_RCR, BIT(1) }, }; static struct imx7_src *to_imx7_src(struct reset_controller_dev *rcdev) diff --git a/include/dt-bindings/reset/imx7-reset.h b/include/dt-bindings/reset/imx7-reset.h index 63948170c7b2..31b3f87dde9a 100644 --- a/include/dt-bindings/reset/imx7-reset.h +++ b/include/dt-bindings/reset/imx7-reset.h @@ -54,9 +54,11 @@ */ #define IMX7_RESET_PCIE_CTRL_APPS_EN 22 #define IMX7_RESET_DDRC_PRST 23 #define IMX7_RESET_DDRC_CORE_RST 24 -#define IMX7_RESET_NUM 25 +#define IMX7_RESET_PCIE_CTRL_APPS_TURNOFF 25 + +#define IMX7_RESET_NUM 26 #endif From patchwork Tue Aug 14 16:50:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leonard Crestez X-Patchwork-Id: 957588 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="otZsUAS0"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41qdsg1gzQz9sC7 for ; Wed, 15 Aug 2018 02:51:35 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733052AbeHNTjM (ORCPT ); Tue, 14 Aug 2018 15:39:12 -0400 Received: from mail-eopbgr60088.outbound.protection.outlook.com ([40.107.6.88]:21050 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732984AbeHNTjK (ORCPT ); Tue, 14 Aug 2018 15:39:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+oLewsuNZT4YdYfTR0i5yd8o3+tWyyP96GNt/2JGS+k=; b=otZsUAS0ZmXC5NAjvIeyLL3AvZUwXvn4E3e4RENY6WmZDy27XlOd1PkJ87rTtpgu/TUC2GMm/l4YTMJOkvYOtn2tpIrlZsLnsAdH/nXRCQAtAJppDuXNVw1KWQJbwYx2Am8J9TM/UigHPjZCg8TVtU/jz60sk4qJ9fO09Jey71Y= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=leonard.crestez@nxp.com; Received: from localhost.localdomain (95.76.156.53) by AM6PR04MB4293.eurprd04.prod.outlook.com (2603:10a6:209:4f::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1038.22; Tue, 14 Aug 2018 16:51:03 +0000 From: Leonard Crestez To: Shawn Guo , Lorenzo Pieralisi , Philipp Zabel , Lucas Stach Cc: Andrey Smirnov , Richard Zhu , Anson Huang , Bjorn Helgaas , Jingoo Han , Joao Pinto , linux-pci@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Mark Rutland Subject: [PATCH v4 4/6] dt-bindings: imx6q-pcie: Add turnoff reset for imx7d Date: Tue, 14 Aug 2018 19:50:18 +0300 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [95.76.156.53] X-ClientProxiedBy: VI1PR0102CA0077.eurprd01.prod.exchangelabs.com (2603:10a6:803:15::18) To AM6PR04MB4293.eurprd04.prod.outlook.com (2603:10a6:209:4f::31) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cbe96e33-afda-4d52-a63e-08d602061fd7 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR04MB4293; X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4293; 3:vGmaPpdwcnNOxecIAS0K7HAOBQakg6bAK+Kr82EeoP+naRXoPiWxPqlpfuLfeH32C6cOcI/hr4W0n+dcoVXqyErf1yO2JBB7wKfKYcWUbqBnoF+K4EWRDOzME+gaO4PHsFHNvmeQCtqT2V9wsH6zE8Dr8QnBqfC7yzVHW+H5nl0z3yi88aVT+WlaOKKsaMlbQyyJPjSpk//WmfYH4P2Ehr5L7N/NEgqInAvDVR25yVlsj9n0GZiKgPgTmxRzSzt1; 25:UoD7oNCD7gb1TqlCcDMD0wtXk8wRj7i+sP/ona6NZLRmEDTtBaimfITMoMrS3FnFKVERo+QiJkVVQ/Vg9TO9FBggUF/xGyx7vPheHWklUiZU1TeitkcuC8pAqhoy5NHOVk9EKX2/RAeY4NIaNZdEKv8HVU2YeWxlrBGaMR1KvfzJtddS+y3w7jxYnA3yf+Pswuprl23CGezh2wZXwZMtWsQWT5BiOkGAUDHMTdReNCfN8IR0QuGFey/NZgOGruoIQuupGn2/IY5ECFE9390Cl8nai0Ova4raw4E/OaswWGpLYeCDdUAutSVMTN3iYCT1Bt6ZLXiWU+Kyelh/cLREZw==; 31:3ESLz3l9/lhjIdBf3lhDBTGgF44dccBSsIcq16TaCyvYCOdD4tuUGXyQXbTNSUcMZ0IAgGVcU7MnSP2Ui8U2xiot5d/DJ3sKxmiqoFQhqoltCKWproeRI/m+3X1o7tyuDlZ+xGQzlbW6NdSW5jjYVMAbp7r3qreC2p0mvC7QGT73YMqXBw3ay/Y6KQn/bjsyci6psQb0HaWzeea6cEuS5DabVwwvE2KJ7xEw2W2v6zw= X-MS-TrafficTypeDiagnostic: AM6PR04MB4293: X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4293; 20:LrxiQlfJKANQ4tG8wpJq6cfG07h/t4Yik8kPCUkxegixHjq80+qnHNF6NPyQJNxAGVKjHl9QH1uedG6tttZIPd+otlTxiMCuiHCMf22Re6l/i1UTSIJuUqdbVh+5iUIK5jotfmYPjKLafHMC5AdVT3EFaQdjMGpses+PLLYAlTj3p6uixHsTvmXbi+z27ES4o8f35P/RKj9sux/Pk2bbqLaj98c6NRmh6Bmt3UMrsRsPQ2a0PU6im8W7DsQ+nHKr3HzV3EZjxgUc16+ESrGS09i2Dt4Dc1CkxdIHTw3U6tRnjvfk5Wi1CkYJX/amGuXEkxieOAlBWMvSojq8U1HcinLot7M1bMVYvPjerT+6+DYsE1MuK54oo6fa0CAqu+ABQlBOElUlVH8ZxlKGpjNFpCw1QrkBI3y78XOCKMzEUGwYPjhsu5GJ2uUe28jJo8g/U7Y4h/DfB1c7bfdi6s7gYIIJqDl9MzZ/8EEdBt8B0VBcMoekW4qFsf6BIDCzLISq; 4:fda91goF1P31O+netDOaOc+nmwJpHv1NG/ZKTza3iK9qC0Ut7XwonyMrZ4gtBrxumz11hRSQ7wSLolZ3oOAbkS0Rw8BXoWhFm+rHEeW8sQabN/XqfvKX8XJB3X/o2ekMIj6mEhHQhkbATSfwuVQ8jkkIugtTS8csaFai4vond5h1fkm/zgSXS8+QzQP+NlXjqnTgfyBIKHONX9In6Zl3ewXboi+TpkD+hDkJQfqmuQEmWzPPFGMHflkYX5t9K0lP/g4S37ZNJqtvtxnWFOCn2cSdPN19oMRU+lXIEGJGly/WzGBtzx9KoFUP68W3scIb X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231311)(944501410)(52105095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM6PR04MB4293; BCL:0; PCL:0; RULEID:; SRVR:AM6PR04MB4293; X-Forefront-PRVS: 0764C4A8CD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(396003)(366004)(136003)(376002)(39860400002)(346002)(189003)(199004)(118296001)(16586007)(6116002)(3846002)(50226002)(478600001)(36756003)(16526019)(316002)(386003)(26005)(186003)(97736004)(6506007)(86362001)(2906002)(68736007)(76176011)(54906003)(8676002)(81166006)(81156014)(8936002)(110136005)(66066001)(25786009)(50466002)(48376002)(446003)(11346002)(105586002)(106356001)(47776003)(486006)(44832011)(476003)(2616005)(6486002)(53936002)(51416003)(52116002)(7736002)(956004)(5660300001)(6666003)(4326008)(7416002)(305945005)(39060400002)(6512007)(32563001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR04MB4293; H:localhost.localdomain; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4293; 23:KU1/jfJYKg3xUoHfUYhMxHan3ALObCsO4v26RZSTu3Pkxna9ogJDhkXLGNvzXX8ONhZv2zRSFlurfEbk2t7D2RTK/VPL+PjcQyHBFtltv8gHy3mnBkWaH5UDP9pPCE1ZjJzoU6pWcgxbiuIOfD7d4DawSCN1adZBusqlpU+CaV7PS4JasP9ksxH6Ga3kM9jKVbTyl25h55vXnf59U+hadWnUsOlwBrSlG30+NzNy3co+CMBB/tIqxY+WdesSxoYuqnobzvP6gXRm7F+Mnp9JA03R1iQK7opa405z8FKQttql5lL8q4JF0jDWOmH/Uq8jJOEClD7OPpGzaDETCbJ1FVmEAq1crP4WB1L2cHJnycK0fyrXe08BhfY0e+/zSQ0bZKHfyQqskL97EjWJyXYhyhn3fq/6L7rH+jy54i6EkNOyL8ajtbbpl+7Rp+4QaSovQNEkjrNCJ3Jzo+9nuzta34PWkfHcIvJkvaj0Glg9fnXMehDHM6MM4Ws282wtkY34g5+jO3KZtJUutnS1CONmQyeiuQj4NFj0cGNse1FZPDYxX/61X8v+UCxdfXdBL0Cm/NpT8IYrTNclBx0PLY4kRTJ9xevnwRCmh3oiqOoEY9S6qA0f6obK+mqEOo+onf2xjdLRE4v9+QRNgALAEvnyRpRIq3v+I+cwnJYz5vht+BDD4LWWaSrS7RzFxepgBnIADQP6GKPQNvfilifqHvM2UlZVb+c3vBbj+k1TOkn2nCGITo68oSongvJ30D6zZ3qxrj5zUS3jM1Pv8kxJUNyfR78AHJZdtm0Pcu2OCGbmhUjCF+fp7NzZtttIf5BhE6mRGyZHpybDn1iV0vkh6gqfciWQV34J7tpvrJYtfk2Z4CAXdEcJtNREzSy3QYCiL7OB6BSl3gjLiIVQlx+LGwUMp4M6pBtK0ls/DyQoU1/NN1lFj4YS6FcqUNCT/0C2QIQGbPD1tvShrhT/tQmkxTWy+4CJ9cz26Gjz3718c2GwmldZ8qiRVNMfDs3j6AGY4skHrJyXCPhcriTpZZ0hXPXdHt+K36C3auCPf95+Ig0GIOgqOfbg5EmqnwgTNkzvI3NY8VjzclBANyIksU82JWC91jatqjt2y4foazvXxBlQb2je23JJX+1DsMs11O60pCiITZ1S3EIHN9LK5i11pFuTHOzF0SNOepxGbzmdMLCT60Twu9bXDYjO4sB3pc+S/SqWOgs7/jtFzNlKahbVFPx/WOIAVdjJgdSyVdZaXlzJSnsZMwvms/hJy2jOpJJldS1PgWJrRIy1FUmRk1MJTeqZn6v06C5UcMFCcxhcwlUVHF8= X-Microsoft-Antispam-Message-Info: lwt3reYyyAkRM9iCQiqN40W9D+iKrJJq4a5UCGS9JpY9ULO4+nkgO1Sn/D8ByAwLsIdGUh5uByynISwuRTI5LOKegjqPV0rwAzEGO0KXF6Uj4cUcTSFl5TCX8D2oDsv6vrXntj0uQ8wpmm/5Woj20UDVwPzhDp4+GH9IGAQIwq/c3mLRE7kbQ7DfV0LK1Mgl72SbJeCln0pcqN2Dst+P36x5gE2x5d5TIS04jDtRwvK8j+I0ckzu8ytGLC+JEnAPZ19NymA/T0MyPUCb60bAkwD+DocEM2kPT9FkvEx2KYo8Yk8liIbmkNGRRMSLTNZDiCTKmVLAb45W0L5s2DAe9cVl+Cxl7eYO6jzhH854gfA= X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4293; 6:W8Al5ZkAfwX9ZFksTHs3MXgolIz50jbDsB959JSOa0mQB/iRCRoEpowd8s2IaV3kBg5f+MKP4Rt2IQ8jeykz7W8ICxNhsX8EhKv6XwJfemmKY9J1bn/83yP6Rk4tcqRPNcaEuwQiBrAAN5ngbZ0YDIf09BCbCmwFLbbpN1xoU5+I3SWNoH+dx6HhGp9IuQ5L/hNvonBnoy3BqXy7OxTNeI2MvlCe2dkH8uB2ElqXGI54vLOqB4K7iTsMe5cwtyimEUJeAlHBeg1BoQI9FbwqoiEsto5G7PTnoqy0XXwgW255yuNyqxrqmY2fAxgc+mzhKkZOWuSnDzGQBXuHtjSjTdEdMJp182fINjIUbgTat+6SXhclFGyoLVQ5epyzAbMYEYTEk4mmaJfQzwzsqqH4hR6W/YlR94nzYuvLpr4tX3m6ScR8/FsXX3o7r0LVUmee4o3kU8oncfF/6t2E7G3s2Q==; 5:RP3jer3pD5PPywlVBFgbU1bV5IvEdUxa2j5TXWp3YBEUsOfHdKJWNVCCk+eEEaXkKA9hSiRUfki6Nrrx3DiHcbItxjemoxTS8NxRP13MfRDJ/ZR/qF2sfKrog39TxUAYlWDjOsuoCno7o22D0ksqDvwtWVXNrdZItUEEW4Yw3Rw=; 7:zAfJRzSLQVQJA2mqiXOTGuS6sTz3wdLcrm1Thju3naXRtuiod8wXvrtnrDjoWHhncZJYc3jD0DGSm7XNrlZZ1B8RRwZpFgPOGvrjkX525Qn/AZ5VNzUQ9O4cz5tOSvo18CFcOawcQD3SWtMcA1IGqmYkOxsa4C/uTZ6/w3b3aGHVEgcPixX2G3N7ARAm9/Odbg8cE3cUHgECqiAI5e/vxSXfBmXTp4xEP+gUSKufoQW4E0gGn9wIgRCiyf4qq6v0 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2018 16:51:03.5641 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cbe96e33-afda-4d52-a63e-08d602061fd7 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4293 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org This is documented as "required" but won't be present in old dtbs. These resets are also present on other imx chips but right now only imx7d implements them through the reset controller subsystem. Signed-off-by: Leonard Crestez Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt index cb33421184a0..f37494d5a7be 100644 --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt @@ -48,10 +48,11 @@ Additional required properties for imx7d-pcie: - resets: Must contain phandles to PCIe-related reset lines exposed by SRC IP block - reset-names: Must contain the following entires: - "pciephy" - "apps" + - "turnoff" Example: pcie@01000000 { compatible = "fsl,imx6q-pcie", "snps,dw-pcie"; From patchwork Tue Aug 14 16:50:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leonard Crestez X-Patchwork-Id: 957585 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="HZkGl0o9"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41qdsT5CK3z9sCR for ; Wed, 15 Aug 2018 02:51:25 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733062AbeHNTjN (ORCPT ); Tue, 14 Aug 2018 15:39:13 -0400 Received: from mail-eopbgr60043.outbound.protection.outlook.com ([40.107.6.43]:35184 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732411AbeHNTjK (ORCPT ); Tue, 14 Aug 2018 15:39:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mH7aqyzZbWgcNnGArOFBNQgCsJORGQ/zmm6yBNgOv/I=; b=HZkGl0o9zCQ+zxYnM9aSealTF+MdcC3kz9eaumNWfKIXbQkZ5xOvtIQ6kvLNeQFNQYqGzoBfJzf27LP6xwAwCiNDO1fmQvd4+m6NJu/xTzFyflko/77ya9N72oLigewRIEsrrDyjsSN5Rl5hJp5Y5nwXcKhfC7qZLKxokcCdyvY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=leonard.crestez@nxp.com; Received: from localhost.localdomain (95.76.156.53) by AM6PR04MB4293.eurprd04.prod.outlook.com (2603:10a6:209:4f::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1038.22; Tue, 14 Aug 2018 16:51:04 +0000 From: Leonard Crestez To: Shawn Guo , Lorenzo Pieralisi , Philipp Zabel , Lucas Stach Cc: Andrey Smirnov , Richard Zhu , Anson Huang , Bjorn Helgaas , Jingoo Han , Joao Pinto , linux-pci@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Mark Rutland Subject: [PATCH v4 5/6] ARM: dts: imx7d: Add turnoff reset Date: Tue, 14 Aug 2018 19:50:19 +0300 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [95.76.156.53] X-ClientProxiedBy: VI1PR0102CA0077.eurprd01.prod.exchangelabs.com (2603:10a6:803:15::18) To AM6PR04MB4293.eurprd04.prod.outlook.com (2603:10a6:209:4f::31) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c0033a85-f55b-4d68-44dd-08d6020620ad X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR04MB4293; X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4293; 3:ZyEF6sr+IPyLihAaisFbMMFea3wxLU9Wevv0SFBLUEp04e5oIsTYcyXCpMC5Tzg2QE5GmGJcANTl2gRTqkRHoBXNO7ebGuUlmUEJCTFpJ0cxa2m3X6UvYH8UHT8x92khCSSwBxcH2+GL7br5oANiuzIccn2vKmYDJT10ihgkKcQ+dgZdLArw2i/rJPSgFOOyaktB457l+FVRVMeVTfN9OSVyaoyZiyUXSSWI+xCxjJd84LfeZKLV2OrjiK1G8GOs; 25:eMP5FF11j+eFtZoCGdbjs7bHDJBpwHSHkA96x8/vfMINDgi4Dzv35W1NATIjI+47xTwe6Dnwm+uWeMWuU262fZ0rltM9Ca3A7KkuHCJZZn/XV0YVo0qhlkqsK5vBZk82WUM13FnD97YQSwNH6UdFPkl5YKJfSFgFrzVnY4NCM5L3pyxTRJJQf8NarK8HwBqaawHwzv44ZYzwtHOY7utoaqT63tPjmdpNabChVmgsgHofGmOF2mx356+ohTCxx2DYsyougTaVtSg3ARtezu9oEQMkGk6LVEEu8btM3pxq1W1moVyjHLDyVHL1g/OoVadyqvBD9hYZV55cfwxSWP4Mfg==; 31:5ZXJAYWCmhxTAiI89xnnYav19j74IJueBF8iaGPp//BSuFu3piXWbzgg5M1IfB3lEEnkKtw0BMG12gEwNzVERqZD0hLJVN3jwxVkSkwEcfue/VxjceUYEIXq4/uckz8A17A/pe99fefLeENKrzq1+4vDIYqlKzsl3BcV18Tk7pYNn30ngGg6FP2djcABsdfJDxR7xws0qXi4iQSYIXEiIzd7AQz4MfDXApTsKL66+Lo= X-MS-TrafficTypeDiagnostic: AM6PR04MB4293: X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4293; 20:TdhwX43fwVfzZy3LWluLH6bySEDtZg8mSgrcDApGpn8huJPjMdNrFrCaVIJb8dYynhAuR/BmLcftSJn0yamI1Z/eWndSpFgG2GDCctXWm8DZzHxp/kDaSf+eDVTBEKN/zEgX8BWfkw6++1wQvNp2Nx2nQUshkjE3xbX+YDYE9i49q1qqgvCRjO1Zi54sjMnhQVlZiboJNVWl1K6JeZ4k/BMBi0lpW41eThO5Dxv5L4VqN9ilBfKDbQ65s8dZHnfmkfheo1iC85pz7rWtRfabP921WEWN1wBKl6uKQMqlI8bFe2iC2kHsZIavjY9uvfX6oXEF5hWqUqrs5Dqyx5rAfZhsNoLMALuCa6uk/qK+17KdEPSMv3/tYrbE03CjjvjlJjWPX+Mna0tGB6pCJT7GOoPiy5K8prSxXIvxWuscac96vK2X4AdDw4tXN3oPAWe1VpWAKkEaDjLO8WzinnG9nEGlKJRLCTx8IX5BSYBQXwLsTZljVUqeEICi+UWSKKAI; 4:izJOPc2MngfWEtlIwTeveNMB0WI9uHZsEmxvFJkrUGDu8BoRHilkhPwPeBHJ+rCSYcCUX4Vp/yPugYc9WAbFWChREf0azlG1THZnMqfMRzXw8TObni6ZjvYpUh5uOvn+RlqPiXAj1wTcUU9f020IhclVhjThNqGEDn1K4DSJJ135rFx3MtfS0qJmqjhG83KeuHxz2f0DcHJlS0d5MRF0PE27H9miJAK1sDQVmyDP8EerZGN0VaAu6W7j0fwb/JwrMv5UbYR2nJCG/Z594B+Gij3cqfD8U/KUULfOTvPRLdvgEWRNObqg03IHtn2y7Fek X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231311)(944501410)(52105095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM6PR04MB4293; BCL:0; PCL:0; RULEID:; SRVR:AM6PR04MB4293; X-Forefront-PRVS: 0764C4A8CD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(396003)(366004)(136003)(376002)(39860400002)(346002)(189003)(199004)(118296001)(16586007)(6116002)(3846002)(50226002)(478600001)(36756003)(16526019)(316002)(386003)(26005)(186003)(97736004)(6506007)(86362001)(2906002)(68736007)(76176011)(54906003)(8676002)(81166006)(81156014)(8936002)(110136005)(66066001)(25786009)(50466002)(48376002)(446003)(11346002)(105586002)(106356001)(47776003)(486006)(44832011)(476003)(2616005)(6486002)(53936002)(51416003)(52116002)(7736002)(14444005)(956004)(5660300001)(6666003)(4326008)(7416002)(305945005)(39060400002)(6512007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR04MB4293; H:localhost.localdomain; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4293; 23:rJz/JPrUR1UOdDKqf06oxtiWTxnAyfVh1h7hib/K+/21V4B3pr99GN3pohicvxaMVwKaQpjOXmwTeW7tozkg77ojAyrUhgVHE4Jc58A351NLF+uiPbwjnwXIeXbmVL3ePEZfYLang70SMTFpXrbSBN5qYFxqKTt78YvgThz6JYdl5tDMU0BdCC83awubpezDiO8QHynXtb/yPydpC/LIk0R8R7G5GkFjz2j9y7CTGeGWzHZvCRwYfq63bNg/vhDMToYl0UpC8ZWmN5l8L7B/Ss9Emulb0RvwVXtENh0VPIwNx3Wo816O8fu0JXnCYaXgT1Ux8fuRb2VX1hhpmx2GaVmJaTx9lNwGdXEkXT3z36irNmHNC94m9Na26X8JorsFdPlwA+R91kRYYxj9aqAVSNCGoxJzizOvW8jaoM+0k/c9/gfMolcFTp7wfg3uo8NmGv5Z0BrZKbJ9eJ9ubwpouakAdnVJgNAM6hPqjeuMkPR6l7gk/PeXDAPIeYy9padr5xTiKySJPkAAwzPwLTAq1l01pb/vAeI2YqpioyktYtyq1b5FxAPbm8uTGN2EJdDKGYDv3aC4KyAn9kOtKzzqaq1qsvMjWK2+ykDKTgEAty33fKguUsDE9zffiZwhSE78hanGUIY2TcakRovsGX5aofngpCDnscAVH+vtR1gMytB2/2RY1jRdxBjuL3J4C1JZ4gnkZ41ziPEADK5q5ZTs5zBwlznejGgu+uxv1d01Y7Fi8uEKiPv2dc8k7NVgNRRUq2GuXE8gELE8K4b8V73a1K5PxDRj9fs+9KMk+xpJeXhA0GCePyVFabQeOSsAvKjt2w2F68I9iws9oTUkCWSU4/ZyzPHg602kWuH+k4XMj3C2Hw1is8hUcOqph7ZXZgazKJICyNF1j4CHVo51/uiNwCC9/dWVpOCHWinNjxhhOnz52ywLyK/zHwkLXiCQB74VrZVOXys7f+w2UBzyX/uLf3Z2/NAeR87hzb+lyBPTHTcek4R4LB+4KXJoYOkYLLQ/Jol/VsBNqST3hZokPgy0I0WZ5grbD6SpV5mAMynlds9oRkzYDvukw+pmzi9SXaLK7D3E+IPcXUTLpHZFz11LB47P1ShggLTe8tJNcYI7St8QArxU/X89/96toPJHDygbQdEWyLKxWQ8N9dbEeWLw0zWp4XSIP9AntAJI+yMGOSZkxzmeX2Z3EFgVwH8zRNCv1n7dj+fmlZby8+W2iFEA50V4Zv6aGoYa9ZN/LPzyOI5dWEbljeGBmakgo7Uhh/xwr5Ur0PScfhwJMU4nvYndadNK0d21vcAtGVYt4z6dbBs= X-Microsoft-Antispam-Message-Info: Tc/qaDpQNWJUYufmdgTi8dejg9Qc2PDT9Z3ezwEC6pYzyJmXMO3RdKe7k8r7FxZYgqmXsdpQxQVpqKO2f1u8BLtNdHUKsBl54UKAWvVxwI8vLO+WiGH6hIcJXuIgO4u55c/Nod0qT1SoZRO/Ug4nzxag6vstKjJB4ucMvo5ewyNJbPX3dlXxStDD7iU6Ik4ryCZ0kJwxphe72u3h/Bc21kcHyRBurfq8Ry5I2Mh7SfSnjnW9EqcYKQo5hoLHnw4Sh5v65w5lEL2+HgesachioUCZQNY/ErX2VhQnYuTezjrnw6k6sldUWipsxM93SCXcbzZo+cVrnRPaaS1gHy/2fBct/h9wlysBTOHEs5dAnw0= X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4293; 6:do2GLVtpwZiNxABLlC0uBiUes/zQ0mdJhed41Eh84tGjlfHGEColymeQR+q1n3YcwdJm/GB1sRrDKkrKOr/CuLFmqOi1D6dBAvVp2JfeA0JL9rTY/IetuaRZEaD3luYvUErsplR5egSi+UMfkcqXjotdk7jpGiDDnQQtUmJ0bnZ7uJ7hdqpdoKIqsC8kCN397Puojc13WF5OVgPRmR0i3+XYdBADPC9yLBK+tt5kQDxGtI5eijMVKnVAcPfYgnGaITYP/3F2wG2nqkKHSs+wIZic8kgYpH8j3+wkn0eELP6syC7n0nv0gR7GVbDh77dgKwDuEkIZ9d9E/yvo+880XekKBXZ1AHbHJEHHLnfpiosG+cyuqkUoqzpoxHBAv/98R5VsefaE1a34MtMclJOu9Sk9IcUhswlxxbNeW9u4WF08ZThqJW9IMPpEfQgZ3WKHgiae0lPzPXfS5nXHozaiCw==; 5:4/RsDCd9fTMxGXZzvfR1QkxK8H/ATmedLp2fcDTZgZcFhNlpet6GADjdFIgnNiB0D4ykcLRatU5GpmF8FEinCK33h+PI8XKj6omn1+W+EWHwJbMUayfmn0aI4lk9RH9Zf3owU4VpTL6jiyUceu2q4fvyB++r8rTdTs0O2A+fML0=; 7:9GFzMSbqO56FLSUTeDR53phLVQXRrM180C3QIzs92Bub7+AfE1Tn2irTXktSnOTlbYT6Ae3H2Mfjdhpxi2vgUMsy3zxaj8g7Sh1M1pvgM1sEVinaTpLzY3YHO9rEm96/AgU+tXvwns0Aeu2mUqUd+sJsmITmNnyBCgAHhLCjfNhBJmprjs9SIKOv6eokiNlj48uuVuC6V+sRQYeYghB6wZ+Ih5PHO8gsl9PUjdKJIrPD746P1BMGd5jk4+VPKe/s SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2018 16:51:04.9631 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c0033a85-f55b-4d68-44dd-08d6020620ad X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4293 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org This is required for the imx pci driver to send the PME_Turn_Off TLP. Signed-off-by: Leonard Crestez Acked-by: Shawn Guo --- arch/arm/boot/dts/imx7d.dtsi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi index 7234e8330a57..efbdeaaa8dcd 100644 --- a/arch/arm/boot/dts/imx7d.dtsi +++ b/arch/arm/boot/dts/imx7d.dtsi @@ -144,12 +144,13 @@ <&clks IMX7D_PLL_ENET_MAIN_100M_CLK>; fsl,max-link-speed = <2>; power-domains = <&pgc_pcie_phy>; resets = <&src IMX7_RESET_PCIEPHY>, - <&src IMX7_RESET_PCIE_CTRL_APPS_EN>; - reset-names = "pciephy", "apps"; + <&src IMX7_RESET_PCIE_CTRL_APPS_EN>, + <&src IMX7_RESET_PCIE_CTRL_APPS_TURNOFF>; + reset-names = "pciephy", "apps", "turnoff"; status = "disabled"; }; }; &ca_funnel_ports { From patchwork Tue Aug 14 16:50:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leonard Crestez X-Patchwork-Id: 957587 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="fDRNMAl9"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41qdsc74ncz9rxx for ; Wed, 15 Aug 2018 02:51:32 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732716AbeHNTjU (ORCPT ); Tue, 14 Aug 2018 15:39:20 -0400 Received: from mail-eopbgr60043.outbound.protection.outlook.com ([40.107.6.43]:35184 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730635AbeHNTjN (ORCPT ); Tue, 14 Aug 2018 15:39:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tbakp1dOU7bUrEddsQf8AthdS8rMaFs4matwXeJTTBs=; b=fDRNMAl9YQ0lVxSilZoGrJ819Rs1kYIxNlwgxxoiDs9k50WPHEUnhxCXHCarIQaC+SwVEihYeh13iIuT3VbebiXwSHscAN+/WsW4fkgGa3HKSKztQTjx6sVg+ADvZyfF15gJSsA7VkioO+MG5xj+zRkgWwkeBpBgnE+ijk87vJ8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=leonard.crestez@nxp.com; Received: from localhost.localdomain (95.76.156.53) by AM6PR04MB4293.eurprd04.prod.outlook.com (2603:10a6:209:4f::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1038.22; Tue, 14 Aug 2018 16:51:06 +0000 From: Leonard Crestez To: Shawn Guo , Lorenzo Pieralisi , Philipp Zabel , Lucas Stach Cc: Andrey Smirnov , Richard Zhu , Anson Huang , Bjorn Helgaas , Jingoo Han , Joao Pinto , linux-pci@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Mark Rutland Subject: [PATCH v4 6/6] PCI: imx: Add PME_Turn_Off support Date: Tue, 14 Aug 2018 19:50:20 +0300 Message-Id: <7079253f4622c78a6c8a911dda1df60a3198a9a9.1534264292.git.leonard.crestez@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [95.76.156.53] X-ClientProxiedBy: VI1PR0102CA0077.eurprd01.prod.exchangelabs.com (2603:10a6:803:15::18) To AM6PR04MB4293.eurprd04.prod.outlook.com (2603:10a6:209:4f::31) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 69913165-7cb6-49d7-a6f0-08d602062183 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR04MB4293; X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4293; 3:y6eKM+AMuIG94qQIwqfVoams6guFLHhEl1CgqPP2fx7XBeBwL4Lwimjn6vGm99blxSq3A2VKcFQAV1T0dtrgjEah/HXhjEvBwuU5MBgau9XucLJZzjqLuP4aa/7LZFmZAEjlAhXlKqmg1ejFtpM8w4A3l8C1ekHvHErWLjTPvrU6lByyNXzC80ngulVrHH6DU8srymJxYhuvkWlgip+EfRhOCUYue6AuTcC0cWlFlTTcVpnavJM2K+uy5VrstDgy; 25:dQoVkd4opzXNO2M0fKALZRtshvbCFL3XvRuKwouPAg16V/nJcniWNja29Fdaw+ErYgB8QjGoAzLklIE1u0ec0UmCNV4B3mb2HmJ9CojQsjF9RKEoccT+joG70c59YkYoKkFFZ6cjp8V2AokO3afTju3ktY/q399YWyBQYHGdX04Zk6M7E6cQA7Er2V/ksxFhauXChMRO/gH8OnuFgcyITKAO2qGgU1NwEh92yqW6i6nVnxoMbZe+xlmpPx81xk2i+I7xbIJs/sbq6WvXCLKIgh9RE1t6ie1tNG3fV9VGsy7ykiN/D68mC+vFoOH9wyqwnHM7IhXKn/9daeBx8ZMJQA==; 31:klKgXHUBpVTWZjW3ARAv63A4pFUNAsA+Otoc2G90agiF2vREG+ETkX9pMLlO4tX5HmCFzDo4WsBmI68O9nIHglLFMsx8x1X+3JrUbMkkide1jmTKYY4y5SL2qcou/8sKQSA6ugkh6P7lEplXHIksF5Mk5cK6X4+3ys31q1S5++agwNEVNKZ/bxMbAB2QQGuD1s+6nXUjWKwIfG+hlDSKn8O0Wl4wee3Dy7fPpaaxqtA= X-MS-TrafficTypeDiagnostic: AM6PR04MB4293: X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4293; 20:e3x/TliQOPPJx/6Kdj1pqrsriUB01CoZAafJwuriKYJv85r/JLUQc3KsfuDcjK8pb0S7Q1nYs/+BfFV9uDWZAPM0pFnA6TUaG920ZuehlorYuTHjoSvodl+oMXKqEVPWOVZD18q8kb7QoLBao6NhmB3g9SFff4OExF+rrlwgFqqxg9cKnW9O98kkNSkZpIZeuBK6aVbba30olXjrxNOMB+hZM1by9PNGdpE5lnRYBqUWa8aK/AnisI/fSzyFBoLQKIxt7+IS9JK66pG5qmZ250w0BeEVCG5WOWnFxoWhmJcydWp5RAllnLFe1wKrK4XsTt3bWWB/R2zMKjVbO5M9JGBgQaj5fJRCeyWf3kzb8RiVIR/Ar/9I20gpjvTuoC7BBmfHWerIgWXrnqy3FQiZMgF4eh3Vy6d3IVTp82ZjcuYew0Nsf3UzMuxAcQBxuUe2NktrMHa9FKSZ6qgx+7ww66L0bVvsdzER1CaWXmz+Yo6qHP2vd6i7W7ZqaGrKcZkg; 4:Vq9C7bsud+TvS5Vy4SqsMbobu1nOfJC7iByxPn7KiwFVCbYFQTy8ZozWxLgC4H+986nvZYCEFL+FEEp6hJWcLpJ+/DqFGMH8Vsg0s+h4DTe9IuUMhfu81OUYqrLrBdKZQB4LC9aYqtddHGxdRQ6AvLYXeBflo+WcMjIgnrlM+K3Gx6F4eW+MbhNdyC/GegRRSRDmxZ3ptzXS5t3/5L9fjsaVZd+u2HMXGeJ59RhLiEY/MEwCAS3XFBc5pUf0fMePxYPnltvrxmdyroUKJOjxeLTL5+oN3mu5PvIUMdiCxp3X0xykYXYa1YihFd9Xe60R X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231311)(944501410)(52105095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM6PR04MB4293; BCL:0; PCL:0; RULEID:; SRVR:AM6PR04MB4293; X-Forefront-PRVS: 0764C4A8CD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(396003)(366004)(136003)(376002)(39860400002)(346002)(189003)(199004)(118296001)(16586007)(6116002)(3846002)(50226002)(478600001)(36756003)(16526019)(316002)(386003)(26005)(186003)(97736004)(6506007)(86362001)(2906002)(68736007)(76176011)(54906003)(8676002)(81166006)(81156014)(8936002)(110136005)(66066001)(25786009)(50466002)(48376002)(446003)(11346002)(105586002)(106356001)(47776003)(486006)(44832011)(476003)(2616005)(6486002)(53936002)(51416003)(52116002)(7736002)(14444005)(956004)(5660300001)(6666003)(4326008)(7416002)(305945005)(39060400002)(6512007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR04MB4293; H:localhost.localdomain; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4293; 23:hk6bCyPbbTw9XluI53AuRCmuQdXwdi2eOxijIV5t3g4SLiMucIOBk4/cJXt6ctbXBALZIRfI4IwitPjnhFAqRwXXUyR4M4KE5dbElAWQPgv5xVvBFDTP/wswiR83o3PYet0PUZfvTB8IdRDOIeVgMuhb7VcZsq/V5Qp3fQoc3VcTnfHLuWElJOXxu9OLPTcRg7B1OvXu3lzLC5AG4JErQjQkTyVwuEVC/IX+7MbqbfEpLHEVJeq7PN9AjSXJQ05bEofwtkQ0QvSxG1GGkAKtACZXnxtBtuajFDnhyMdFxJ6cflQxIE27X32ko7ezaYA9eIsSax/I+jThfmhBmnFvgThKA9GHQh2loHIoTN3YpyrlJMxOIiRd0Sbg+NJ3oCuf8flwvrbNUcnBE6RSE3rUpEtndq/8PdShOJm7BRdAzYVZKDuEAo9XTKixcY8ULSsHrtc7O+/wA2j7yEmqQPwH6hmspTpXdA14F0FloyMnTTjMKE2MXVDXvUkvndHrrKt8drKO/qBbJ0m1bZL9doR66YI05dof7PixGU4UoC7XpVruXtv2FwcpH/9gio8DjBUz67YmLX3bnxF7aeNMWSe+0nnIYs0gnnufeASGoRYXdy++9a6KFRuWIFlOQi3t5Yq7qytONxWmgB1BRy3ucscoJEWfPTonO1G4OaEkuYeQ2HzEnvVcoUU4P+/VEzBPj6QZ5BiM2Mr5DILAUWV1enBj1r4XU0oqMBmj6NQ7tMcT24wDZ8ZT90sJh7lZ8YhaV7p0Drjac7gyOHzCqxeauIvtvBb4/ZbKgdRM521iLRSWlKWMv40Jg3hfLb0pwiS7nUXmzSbJvxuF22vUww/TUKIAQLvNCj1F+ErU6VbuqlOinCj5WOQDceMpf8wPyhyjB0kmztNiqWNaGnOaN2sSXovO7oP+Ic9tYef3yrNe5DFvX1KRZ+Zr5yH217CQ0amC5zpk4IXmO7ds+qtXpur00Ay9LOKdT5L/gC03j2unby/L4Oap+5+KIwNSYeEBz+pe2xWmbb5TccxqySZ1fyAI2i+gPLMm9yOQPKmi79Pyq2b2FnEZlkqkBShtdDIxWH+8+2STVx/2Qx+YAR6NaUWwwtwXsLKgtC46t8DA/IRZ7MUBkQ2/IXlHuaACXkHcaG1yoqG42OxElPFwlyEy5/wCh2MGdGL+aJqSgm6KEnl3roUVkusl+GRyFclwLcoDYwmqfX+I9T9eLWrHoQDHCSRUJgpPNZ/aeTvCzlpOMOOhRw07l5oTDPxULsp78ryXZSO1E3SPo/cCzUEXy/Fs7ZjpNtsu15IU6wWkFUeqQ5N5hgytSus= X-Microsoft-Antispam-Message-Info: bvs7+rSsg/i0t2Ke9ciJUjuyKu8glz6ISX+EfWW6xB1JGlmkxj2mLupuBYynTnn82JaxjA+oeMjx7xQ+9sMmQxWYE7P5DRkFhKDZ5dsLjCbKtlqZGRn2DxvL5NKWBLHUax+JOTgI7RvgCuaINszQFZSOWbbjvcOb9+P+2rlQQXtZOzDIMiazuTEnoA3/ydbVSH61RCaEHZ7uHiTRt00+PxHcllxibSN1pb+sZKkCkHpSHCKHrFJyGJzPR/zTAmNxv/AFRxgQCQa9SSq+iiBDunKv/ww1Ij0Uo4Bv19WEdIRPx0JXcBuMmDIndt5pRCxtyAAgR59pBfVUMZo3DHZo41TumF3WQuTh61pi3S86gO8= X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4293; 6:ulCgvg5UFk1kIP7vhGgSIuB93sP1I/WvfdHPVrbupzir6Lqzd1gvrbckOLjslwk05BlBxCXsPRBtLjiH5vnhGWMXsPU6IdFhh2kek2KMal+9SKVyRd+ILQ/vvYxc2pTijSapwxD7VBVM2GiMRFZ+dG2Gn4xyDHUtfieGgmDdARqDBDd5Sbv9RaVdy72HeLwjiH1Brj//nHSpdfpPcqe0s3iOGhulnCR9wKARbcXNJPsUoDuNjsG5ds43NwxRg0C2T2nYGN3W63I/3j1KW9c92Ducd1caIPfPJ5X2lhTiTr22oum4FiGfriw6oFq6X9PpGYZRCetvEejc49/iZkQKRa1TNn4ZnW6nWZOa6Q4wWWlUr/2uF7+9aYlGYWa4Q8ROyYS+v8JPFq72kLgWmA8ahzYca/RgCThLo0ak9CRxblc7nu3oKnmMg8ypcp5iRS7T2kDaCZD3cvlosRkhni9QXQ==; 5:S4h3XUVw/TvIndaVtqm22hfAHPzvRckk12S+wdU7F5+MB9UFgMEq8tJbD+/LefpNjlPbQ9j3iPdwaZw0keiATM0L2W0GZM27F8TZeisJyEskWidXtrTdFxvPnsdTWWO2yxmPKPP1nZGI0h+kvUzYsqv4OFDkby4T+2Apow4LQhg=; 7:Y8/888liRqqurkmeEArOxBph8HNAZbo2C5VHxwWpefhH0ORLDZxysC7uwVsrPacS31/b8rNMb4IRz51WvJ1noc1GSK5fQ5DAwbM80WmtfxYLv0rsmhAGEOm1vcRR7dmZB3sWJgPth4PeVilyGxrr19T+cHi0ACDuj+GCSWLymMOB6bGbYuOx7zw3j27SM6A6KsFD4RPd2UvcbkuRGa42pWFtY6LaaRpc0h1eagDi0yOw2eh+CgU4xh+Y/ef0oIkN SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2018 16:51:06.3701 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 69913165-7cb6-49d7-a6f0-08d602062183 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4293 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org When the root complex suspends it must send a PME_Turn_Off TLP. Implement this by asserting the "turnoff" reset. On imx7d this is functionality is part of the SRC and exposed through the linux reset-controller subsystem. On imx6 equivalent bits are in the IOMUXC GPR area which the imx6-pcie driver accesses directly. This is only for imx7d right now but it's deliberately implemented as an optional reset, ignoring the chip variant: * Older dtbs won't have this reset so it will be ignored. * Future chips might also expose this as a reset controller. For example imx8m (not yet supported) has the exact same PCIE_CTRL_APPS_TURNOFF bit in the same location. Signed-off-by: Leonard Crestez --- drivers/pci/controller/dwc/pci-imx6.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 926858701726..eeba64392dba 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -50,10 +50,11 @@ struct imx6_pcie { struct clk *pcie_inbound_axi; struct clk *pcie; struct regmap *iomuxc_gpr; struct reset_control *pciephy_reset; struct reset_control *apps_reset; + struct reset_control *turnoff_reset; enum imx6_pcie_variants variant; u32 tx_deemph_gen1; u32 tx_deemph_gen2_3p5db; u32 tx_deemph_gen2_6db; u32 tx_swing_full; @@ -757,10 +758,16 @@ static void imx6_pcie_ltssm_disable(struct device *dev) default: dev_err(dev, "ltssm_disable not supported\n"); } } +static void imx6_pcie_pm_turnoff(struct imx6_pcie *imx6_pcie) +{ + reset_control_assert(imx6_pcie->turnoff_reset); + reset_control_deassert(imx6_pcie->turnoff_reset); +} + static void imx6_pcie_clk_disable(struct imx6_pcie *imx6_pcie) { clk_disable_unprepare(imx6_pcie->pcie); clk_disable_unprepare(imx6_pcie->pcie_phy); clk_disable_unprepare(imx6_pcie->pcie_bus); @@ -777,10 +784,11 @@ static int imx6_pcie_suspend_noirq(struct device *dev) struct imx6_pcie *imx6_pcie = dev_get_drvdata(dev); if (imx6_pcie->variant != IMX7D) return 0; + imx6_pcie_pm_turnoff(imx6_pcie); imx6_pcie_clk_disable(imx6_pcie); imx6_pcie_ltssm_disable(dev); return 0; } @@ -904,10 +912,17 @@ static int imx6_pcie_probe(struct platform_device *pdev) break; default: break; } + /* Grab turnoff reset */ + imx6_pcie->turnoff_reset = devm_reset_control_get_optional_exclusive(dev, "turnoff"); + if (IS_ERR(imx6_pcie->turnoff_reset)) { + dev_err(dev, "Failed to get TURNOFF reset control\n"); + return PTR_ERR(imx6_pcie->turnoff_reset); + } + /* Grab GPR config register range */ imx6_pcie->iomuxc_gpr = syscon_regmap_lookup_by_compatible("fsl,imx6q-iomuxc-gpr"); if (IS_ERR(imx6_pcie->iomuxc_gpr)) { dev_err(dev, "unable to find iomuxc registers\n");