From patchwork Tue Aug 14 14:16:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: cgxu519 X-Patchwork-Id: 957537 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-ext4-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41qZSM0dk0z9s8T for ; Wed, 15 Aug 2018 00:17:55 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732439AbeHNRFQ (ORCPT ); Tue, 14 Aug 2018 13:05:16 -0400 Received: from mout.gmx.net ([212.227.17.21]:39935 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728458AbeHNRFP (ORCPT ); Tue, 14 Aug 2018 13:05:15 -0400 Received: from localhost.localdomain ([113.116.48.118]) by mail.gmx.com (mrgmx101 [212.227.17.174]) with ESMTPSA (Nemesis) id 0MMoU7-1foEQ840Pn-008azB; Tue, 14 Aug 2018 16:17:24 +0200 From: Chengguang Xu To: jack@suse.com, tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org, yuchao0@huawei.com, shaggy@kernel.org, hubcap@omnibond.com, martin@omnibond.com Cc: devel@lists.orangefs.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, jfs-discussion@lists.sourceforge.net, Chengguang Xu Subject: [PATCH 1/5] ext2: cache NULL when both default_acl and acl are NULL Date: Tue, 14 Aug 2018 22:16:30 +0800 Message-Id: <20180814141634.5471-1-cgxu519@gmx.com> X-Mailer: git-send-email 2.17.1 X-Provags-ID: V03:K1:2WbEhHm/f5/YRIu+1B5GoBcF3lj65bsJ70kBq7dc/htuJR6XTcV xs6b/qR30/HU6zx8FmQqSb9jo4j19Xg0uARb/NMm61ZgwWhiFt1vGMYEkMKymm8jKd0kI9z nFA5jngE/wGRViFKH7a2XRkxqgrczP1iFGdhOtEKoYIfcKzVIFdfmEbAp2mPzqjYfXKCIf/ Y8JFJXBUxZldZDKa9qEhg== X-UI-Out-Filterresults: notjunk:1; V01:K0:P1E7NggGjNs=:/bE7EyY45yGU26R6LqHgPz YP9Zh4q8Ww0Uva/XCjSFwjH6im6BtDjy/bOPSvI9XR4SpNHaKGdCl3I3F2vJZaO1saiVhGNzC kbrJEqHPCYtm9t8U9yulA/qejiDtcKlZ8fkNQXzOmQ/kPNOdZs/qCxD7rt5HcdLLsssN03fBl TdZbibSG0sBan/8dQ5TmalTpXm0tWdTYpb68dxXs2wDNIydc/09FyOFsA9LyNxeqdZimJcYOZ X7a0dtMH8fZk4TlDtQr/JDeo2WmB0ce1aS9jpgXuNYcMdvqekJJPxFWROgvb4rHVnbAAPRRpf kiqoMtWnl9W3hPdXDO2aOkqgwgW7jLT1/wVakGw/AcC32DvLR+Ykq0CC1KH38ii1Eya0ulXGg liIro4OZE0vcXx3rjaaFiE+UIFueE5OwuywWg+kNWqMwS6kkGEkdHG3otwwQmUnA39tQyfOOa EluIj7mDeYVqsfYMuTornOKpiGmk5y5McCgxh3nL8hqXP8ZWFn/hCvFCbIGvRQSbZL6Z1WIS6 B2lcv/hHG7it5RRT1FClQwCzqOwvydAzhEqTZZZcr1y21Vrpj1d7OXHJQKC0nDHcB6YJA9MeU OhZxbeVOm0fC/J4M/J5Y5Tf5RToqUJEwZJd+qSn2lpAEdWlxUguLaYNu1R+ClQiRdDT+O/K3f RplrAa04imt8oiuNpzXAHU1eavyD28P7phTBCqLkPe6dLzGkGNvxOSrrk4OwAjnXDo4ht7Jc/ zprIDBvTeBW0DfjfFBuvxr3PhhMzMKozmvaMfxz0isMK/TmTx750AmibRR8= Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org default_acl and acl of newly created inode will be initiated as ACL_NOT_CACHED in vfs function inode_init_always() and later will be updated by calling xxx_init_acl() in specific filesystems. Howerver, when default_acl and acl are NULL then they keep the value of ACL_NOT_CACHED, this patch tries to cache NULL for acl/default_acl in this case. Signed-off-by: Chengguang Xu --- fs/ext2/acl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/ext2/acl.c b/fs/ext2/acl.c index 224c04abb2e5..74411e8ea507 100644 --- a/fs/ext2/acl.c +++ b/fs/ext2/acl.c @@ -262,5 +262,8 @@ ext2_init_acl(struct inode *inode, struct inode *dir) error = __ext2_set_acl(inode, acl, ACL_TYPE_ACCESS); posix_acl_release(acl); } + if (!default_acl && !acl) + cache_no_acl(inode); + return error; } From patchwork Tue Aug 14 14:16:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: cgxu519 X-Patchwork-Id: 957539 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-ext4-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41qZSZ4PxGz9sBZ for ; Wed, 15 Aug 2018 00:18:06 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732612AbeHNRFR (ORCPT ); Tue, 14 Aug 2018 13:05:17 -0400 Received: from mout.gmx.net ([212.227.17.20]:39377 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731724AbeHNRFQ (ORCPT ); Tue, 14 Aug 2018 13:05:16 -0400 Received: from localhost.localdomain ([113.116.48.118]) by mail.gmx.com (mrgmx101 [212.227.17.174]) with ESMTPSA (Nemesis) id 0Lusmr-1fyPuM0H2X-0104eF; Tue, 14 Aug 2018 16:17:31 +0200 From: Chengguang Xu To: jack@suse.com, tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org, yuchao0@huawei.com, shaggy@kernel.org, hubcap@omnibond.com, martin@omnibond.com Cc: devel@lists.orangefs.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, jfs-discussion@lists.sourceforge.net, Chengguang Xu Subject: [PATCH 2/5] ext4: cache NULL when both default_acl and acl are NULL Date: Tue, 14 Aug 2018 22:16:31 +0800 Message-Id: <20180814141634.5471-2-cgxu519@gmx.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180814141634.5471-1-cgxu519@gmx.com> References: <20180814141634.5471-1-cgxu519@gmx.com> X-Provags-ID: V03:K1:D0Oo4rCzcfWw6KdCUnd/Ln/zsvTraDWmZ8Mjca/sLBVdS0MqNBj 427NIlgz1sCovxz+/OeqLZxwjzN8DJwU8iXWiJLl48YNFPG1BBXw6ISv0WUpGgNUPr+4hGO nwXLTJtDdbpoF0uXgR7FzUGoRWcLMRXaGM5+RsynsZAZr8r9WoujeQQ4YqV1XtJwKAgjTnR rjGr8VNgK5JtFfvtAEQyA== X-UI-Out-Filterresults: notjunk:1; V01:K0:NHkn60ZSxK0=:gh2j5YGnuwU/n75flX5GfJ F7juCxsVuy/CiTT+tKX+g83BcpfVm7uBCthHbF29KXNq1d+o6tC/RRpIf6mzMIudumEzb7Zde QJsNDTsjMtI0ij9R67wGTz6bIOULbkoVWoLgL+cCBNQxtNsWjeD0Onr0O6aY+Ss/2+MWAZTjd gHhZrd0h37mMTNIsNt1Zqk7yi0bQxjWF2uaoS+ZDYoWk9Ppp04V4kZNubbqrGiAQUfVuNjbKJ we6PXbMQG0De2N7W6Cmqp8QhQtAWRVXtv5ORJY1tjldI0PPKKkdk6xsdUDfm0NsqenqYHDOg2 Vp9oNIcsEWhzAzVIVxptHvOGJWZnmWP8xb1d3mKwEG20GFm/q3cGbCE09QDPtckEWSokgXnrb p9kanj8H3WEERAAzJ9ZCMMMAsT/SrvhWPyXa5UkogDmIysQd2K1x3B87dp/0c66LFakbqzioL ZzebSHln64CkYCQqgMxvEH+JmB2Z1JYeaiQK9muyppru5vHiG37u51/INzCMgrsoMTT64AO5T 5DlHUG5FAM5v5eWzyTbbewXUKhlCMV459qry/Efb66/ECZSE2lFhIPSb4glV0lDHLrOyKNOB5 ZEZvkjs5i3Inwo1tLFJpjgkB2kbZQp7CdKLkO8UreBAuLe55EmGInPTu/jdc4xwlGVaLJgHLg qCoTbL446Q8KtZjG/Q0tYLcYuS3AO5NEPFQPSlc8itiCgtaidMShCyGVcgMWm0++HpB2efkjc gosulZe5t7ZN07LkPpJ40xw+GYKfKBjqWfI1H7qb9eRGjIjlcxz4ULTNktY= Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org default_acl and acl of newly created inode will be initiated as ACL_NOT_CACHED in vfs function inode_init_always() and later will be updated by calling xxx_init_acl() in specific filesystems. Howerver, when default_acl and acl are NULL then they keep the value of ACL_NOT_CACHED, this patch tries to cache NULL for acl/default_acl in this case. Signed-off-by: Chengguang Xu --- fs/ext4/acl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/ext4/acl.c b/fs/ext4/acl.c index fb50f9aa6ead..69a01d28356d 100644 --- a/fs/ext4/acl.c +++ b/fs/ext4/acl.c @@ -291,5 +291,8 @@ ext4_init_acl(handle_t *handle, struct inode *inode, struct inode *dir) acl, XATTR_CREATE); posix_acl_release(acl); } + if (!default_acl && !acl) + cache_no_acl(inode); + return error; } From patchwork Tue Aug 14 14:16:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: cgxu519 X-Patchwork-Id: 957538 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-ext4-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41qZSX71Svz9sBZ for ; Wed, 15 Aug 2018 00:18:04 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732644AbeHNRFU (ORCPT ); Tue, 14 Aug 2018 13:05:20 -0400 Received: from mout.gmx.net ([212.227.17.21]:44911 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731724AbeHNRFT (ORCPT ); Tue, 14 Aug 2018 13:05:19 -0400 Received: from localhost.localdomain ([113.116.48.118]) by mail.gmx.com (mrgmx101 [212.227.17.174]) with ESMTPSA (Nemesis) id 0Lfolq-1gD5P12yOA-00pORo; Tue, 14 Aug 2018 16:17:38 +0200 From: Chengguang Xu To: jack@suse.com, tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org, yuchao0@huawei.com, shaggy@kernel.org, hubcap@omnibond.com, martin@omnibond.com Cc: devel@lists.orangefs.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, jfs-discussion@lists.sourceforge.net, Chengguang Xu Subject: [PATCH 3/5] f2fs: cache NULL when both default_acl and acl are NULL Date: Tue, 14 Aug 2018 22:16:32 +0800 Message-Id: <20180814141634.5471-3-cgxu519@gmx.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180814141634.5471-1-cgxu519@gmx.com> References: <20180814141634.5471-1-cgxu519@gmx.com> X-Provags-ID: V03:K1:G3TyyYSSFZjaYzygNTTz2CQaqAUa9ExgEsKsyd8WN83uHyIPX6U muRccE1QzgF5jFUnYOm6pokyPuCCjzRPSlZFaCMk45DQ/lb3FgUmb+oTRzKPBUwFIaMEqTg REHvxsDBvJaAVMooTeU4K27av8etonj0b5HBB7rKaxOZ/3MjG3b2PPZs/gmvgvjW9QfYCKM B3GNwNTmmz16gruojFkLg== X-UI-Out-Filterresults: notjunk:1; V01:K0:Q6Sct/CfeIo=:0V2XWAxLXa2x3tgodSevNw 85fZf5ZaFx58dX0js5Rohw/2cz0k9EOYuoyCoGVZHjrrqx5dK6Bky1J4O3gEJa0anxYvB1Rl9 AqMiDJJNXhlU/TnyGfOVfQH1rFU9Zs9M9wVddQdPv83eTV/+ZFQGd6vYOJVvDu+re+8XTvIGa +8c1gKPv0NhRlj8Y+uWWcGKcI2KCTUyHbWnBGuzFPWvhH2+QPzfde6thHoIJwRAGKagnzXpaM mBqGHkkRo+4fvmMQuy7iVP28kt3FUgKL282FruhA51NWarb8JkEtD+Efk/QBBr8VIrUBrqWp/ sfGI6hgkSYtrlCebUKquKzfYxhk/F076xSmgEX3T0NoNdVkdkxfWzKYOh0J5/t7W9PdpHwPbh oQf0KGU+cgXRQTMn3968P71ffuHdVv6AJM+/U1LteJF3EJ+U3r3J7qnFjkYKBYqXrgq3v3JhI BoMUAegQaWjikTqq10KIT3vr/TrwO/yQqJnx98+r1+NZXEnscbFHI6dPb+dTpF9OdErjigfCH QzWs6fpMIwk2sWaC5UG/4NR+XPTUZTjcBO5upZfSwpMFmJPlwG68ULz9vP1Mv0pt0Miz+eqOJ 6F9vf4Dg+TVo1TPpXVH1MPBpnuEAjV8kYioAGV3QW3Uk/zUOzFmtZiZWaxqL+SiEHdo/ZW1m2 uqOFRBg48MBtu5EEevMPylVkWft7QRx9ufTlyy/fh2NOO/h6IgLI1jznlOkjDd8L0aToWTkZH 8NfZjo0cen/Uwxt2kSoJc5EADbecuLAGpsMc5o2K3uxM8Y5OKkko25KVyM8= Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org default_acl and acl of newly created inode will be initiated as ACL_NOT_CACHED in vfs function inode_init_always() and later will be updated by calling xxx_init_acl() in specific filesystems. Howerver, when default_acl and acl are NULL then they keep the value of ACL_NOT_CACHED, this patch tries to cache NULL for acl/default_acl in this case. Signed-off-by: Chengguang Xu --- fs/f2fs/acl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c index 111824199a88..97ed555316be 100644 --- a/fs/f2fs/acl.c +++ b/fs/f2fs/acl.c @@ -401,6 +401,8 @@ int f2fs_init_acl(struct inode *inode, struct inode *dir, struct page *ipage, ipage); posix_acl_release(acl); } + if (!default_acl && !acl) + cache_no_acl(inode); return error; } From patchwork Tue Aug 14 14:16:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: cgxu519 X-Patchwork-Id: 957540 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-ext4-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41qZSh0mz4z9s8T for ; Wed, 15 Aug 2018 00:18:12 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732693AbeHNRF1 (ORCPT ); Tue, 14 Aug 2018 13:05:27 -0400 Received: from mout.gmx.net ([212.227.17.21]:50249 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731724AbeHNRF1 (ORCPT ); Tue, 14 Aug 2018 13:05:27 -0400 Received: from localhost.localdomain ([113.116.48.118]) by mail.gmx.com (mrgmx101 [212.227.17.174]) with ESMTPSA (Nemesis) id 0MOBOi-1fmIMG0eQe-005Zmc; Tue, 14 Aug 2018 16:17:45 +0200 From: Chengguang Xu To: jack@suse.com, tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org, yuchao0@huawei.com, shaggy@kernel.org, hubcap@omnibond.com, martin@omnibond.com Cc: devel@lists.orangefs.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, jfs-discussion@lists.sourceforge.net, Chengguang Xu Subject: [PATCH 4/5] jfs: cache NULL when both default_acl and acl are NULL Date: Tue, 14 Aug 2018 22:16:33 +0800 Message-Id: <20180814141634.5471-4-cgxu519@gmx.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180814141634.5471-1-cgxu519@gmx.com> References: <20180814141634.5471-1-cgxu519@gmx.com> X-Provags-ID: V03:K1:rFT9OJLTD5YX3u8WgsumqfTElBTL6IWEdsGpYGKSnCTaTeUn12d 2VaHQwFRFSx0wGaCnH5vm644dlg+v74VbC4sZFjl42WETQzFiHgh4RkUd45rmAaefsvCcxs hvcnsyEERyv99M17p+5dJ0LudNhlYufLx//z5McIVz9sfK6fKwwVczDbtSyLz1pM2VirWR7 FD8QkJ17EgZtE7KTlvEQg== X-UI-Out-Filterresults: notjunk:1; V01:K0:faAfP3zc69I=:toXgGeQGVhQ8uFI51XScnF P8QQwv5vuTmeif+RMp2MiyL3CIgYQjQAZ2owBfZ0qxZGku8Z7oR+w//4YB/Zh2XzRys60FWPW zKh3a+LBoE2GFOP8TG1t9fGIVd6BekuwNUQODFjm1eTqQU7izxN2slTpT3VKCablmreOQ/Hoz fuNw0y0m5/lbpKMZo457fSFNBUheNft9ZhRqRIFB6E0fvAezH88/Y7DhvjB/WqXmpaMg2AhnJ /EkztpU0WDiXD9ImJQP6sndEs+q4IqsrEq9YGLSggahsG2md7QuB9g+gDY66MFHucLJUfBRSs XN+2AMMRK/mhW7gAJFFG6wd/QO/8FM7VttYnSs3A/0xPeg8/jz9zM7h4sWUeiPr1kTyuE0zfk 4Dbs+dN8BOHz5r9pq6HNhLq1yDkq0PfhpXi37aA8yfjpf9tej0xGtxfj9ugmPNdbCWH0D8KWc QToOAGJDzUzpAq+L2IIRw8wr1m3eFEkqkRHQ+/0k6Xu1JWto28EkOiv85dDdccHFT181bYHZm wDrB3Z5vDeF3ZY4PWKfSyhccgVHURuh3IPoLcN9XapttsK8gBmFh3pI1o2DROIKAE/z4a4eYD QkVKQdpqrlmvd2My6nvX83zNa/T/aK3Jmcl777RNrmx2I/qNerqB0CM+V6rc9qaVlHKhDUa0r q1cHnxVzzQd2NbCUBxUIqLV+2X2vW1+EdbtpA3GTS1fIEqztwQBAbTANa1VXwLh48DGf3nKkg NEA3DBzJF6Ll1f47ENfOppRhFglWvq+iBSw2vK6K60dKdWy0BjBq253dlbw= Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org default_acl and acl of newly created inode will be initiated as ACL_NOT_CACHED in vfs function inode_init_always() and later will be updated by calling xxx_init_acl() in specific filesystems. Howerver, when default_acl and acl are NULL then they keep the value of ACL_NOT_CACHED, this patch tries to cache NULL for acl/default_acl in this case. Signed-off-by: Chengguang Xu --- fs/jfs/acl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/jfs/acl.c b/fs/jfs/acl.c index 2e71b6e7e646..15b9a9b74d72 100644 --- a/fs/jfs/acl.c +++ b/fs/jfs/acl.c @@ -154,6 +154,9 @@ int jfs_init_acl(tid_t tid, struct inode *inode, struct inode *dir) posix_acl_release(acl); } + if (!default_acl && !acl) + cache_no_acl(inode); + JFS_IP(inode)->mode2 = (JFS_IP(inode)->mode2 & 0xffff0000) | inode->i_mode; From patchwork Tue Aug 14 14:16:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: cgxu519 X-Patchwork-Id: 957541 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-ext4-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41qZSp4c5qz9sBx for ; Wed, 15 Aug 2018 00:18:18 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732739AbeHNRFf (ORCPT ); Tue, 14 Aug 2018 13:05:35 -0400 Received: from mout.gmx.net ([212.227.17.22]:46955 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731724AbeHNRFf (ORCPT ); Tue, 14 Aug 2018 13:05:35 -0400 Received: from localhost.localdomain ([113.116.48.118]) by mail.gmx.com (mrgmx101 [212.227.17.174]) with ESMTPSA (Nemesis) id 0MfRnb-1fVT7t3fWF-00P1wT; Tue, 14 Aug 2018 16:17:51 +0200 From: Chengguang Xu To: jack@suse.com, tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org, yuchao0@huawei.com, shaggy@kernel.org, hubcap@omnibond.com, martin@omnibond.com Cc: devel@lists.orangefs.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, jfs-discussion@lists.sourceforge.net, Chengguang Xu Subject: [PATCH 5/5] orangefs: cache NULL when both default_acl and acl are NULL Date: Tue, 14 Aug 2018 22:16:34 +0800 Message-Id: <20180814141634.5471-5-cgxu519@gmx.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180814141634.5471-1-cgxu519@gmx.com> References: <20180814141634.5471-1-cgxu519@gmx.com> X-Provags-ID: V03:K1:BhOPBB45She6oJeWlmpCdGqDSbI8TyNuOHvnSC5HNcIIncvOzG/ JTK+S7R8iPNvQAxBvwGITz58MAlbBUxOxh22HKn6nIZvHYBBLXIf8WwCot63jAWjh0XiWXc gRGiQ/OddweveN6gn2aA9+4VM7y715GaxPlvn0SeffSIuC4GAMR6zvrJHmaXvS/ui9UD4HU 7ou4lwyyzT2JwGEIiEsnw== X-UI-Out-Filterresults: notjunk:1; V01:K0:9P1WXlxYrBs=:i6ckKiby2rugs80mUEcnZy SJJIQRflKSCSOGi8vK539y6WXEHfLrBuncUMFm2OhStQV5mNaMlUXWtvWUFyvYTzgXwgUZ2Pk AWhoC4poFZlqGubtBHMC/n2pQqM3Fx2MlqpZ2kmMuFOsq4yCzAJMGnOm3UFL4TrTQvtLDp5tX inC+vo0V4mQ5AfX8Zhd/hf8mpP4mjfUull5BYLamUVgED5/7x1WsTlBX1QIT7tTCARx88LxBU ZAZ5AA0bRIfWfKT3oYRSktG0A9/jV8QbHcuj+rBVlP82ctvVlE80NJIKawAoVIJCDiLoXxVm/ I1WhbPCkyXb1air/8A7i8o3ieRL03vW2j+fII55HOLDMv3x+d1ewE74OSmxSZ+XRUAYoPlDZi GyiOLugl3OtWrPOSgZywXi7rrLKdQCotBWaY0yaxIvAQOHa23zkh9Y3hCld7gu8u4xl2/bvmX nkG+l2zh5/TuZZaubuEbI5tedmLprcmTMIszotTf59VsaIax6uTE7IaXxRIatXtWGjESQXD9C 8SZUAmzOSmmEGGkv849f4/hUvXuWX4lc8SE0PrYx3GwuTZKewSZk3+TwSHvB8DnyRewF/wPGa Y/JkEfVu9UVyBsg7LpU+yzKQnnzPP3tUdyR+u53h0H2p7lY+zzEYXdWN+Myx6zyAcTqEQX09H rSWVJrwGlzwDEGbbpNCcjehThX3KgLWD9qbX3s82cvAf+WwMlKi5QgvfTceypou270VPSAxri M68CxdYijMVB5rUWItEPsoct9cFSJfdbDA9JFoNhW/X5QJv7EfJ6wm9GbzQ= Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org default_acl and acl of newly created inode will be initiated as ACL_NOT_CACHED in vfs function inode_init_always() and later will be updated by calling xxx_init_acl() in specific filesystems. Howerver, when default_acl and acl are NULL then they keep the value of ACL_NOT_CACHED, this patch tries to cache NULL for acl/default_acl in this case. Signed-off-by: Chengguang Xu --- fs/orangefs/acl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/orangefs/acl.c b/fs/orangefs/acl.c index 10587413b20e..e3b043a263bc 100644 --- a/fs/orangefs/acl.c +++ b/fs/orangefs/acl.c @@ -175,6 +175,9 @@ int orangefs_init_acl(struct inode *inode, struct inode *dir) posix_acl_release(acl); } + if (!default_acl && !acl) + cache_no_acl(inode); + /* If mode of the inode was changed, then do a forcible ->setattr */ if (mode != inode->i_mode) { memset(&iattr, 0, sizeof iattr);