From patchwork Wed Sep 2 11:41:39 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ernest Van Hoecke X-Patchwork-Id: 2296564 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=b82Tp/lX; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org; envelope-from=linux-gpio+bounces-42612-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from sea.lore.kernel.org (sea.lore.kernel.org [IPv6:2600:3c0a:e001:db::12fc:5321]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4hZh3J2C7wz1xwg for ; Wed, 02 Sep 2026 21:54:20 +1000 (AEST) Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 8C78A38B75 for ; Wed, 2 Sep 2026 11:42:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 306DC47D44B; Wed, 2 Sep 2026 11:42:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b82Tp/lX" X-Original-To: linux-gpio@vger.kernel.org Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0ABC446C85A for ; Wed, 2 Sep 2026 11:42:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788349351; cv=none; b=tw+pL/8xh+P82wIMh1PrSvrHmpgkKFOiZ8BjMB3v1ufKEtD4eYxR6KoOWVToyd337MQ4pAH2lWqj6qpXKkZIrs9BErO6/mlnCgaf3q3vL3kYcOxYum1cES73sYTwBB7gYRFHrP2WZ6C3/+5/L84mZCyp6OpoTL+t05PNeZCAiMY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788349351; c=relaxed/simple; bh=0YfZ6I8/xNI370aVrOszFzEznLcSoEqSHveLG9FC+Xk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ScFhzygfOiFGCL7yYJkpj3X/AHFNBSnytpN2/+/abFuYtCVa4ArqYbGEIIdkATS4kUq85c3pc+nhCjm+hmTb5TzRRJaJbynIuSzhgRvjTql8PXRF3P/II8t64bYq1T0r9YALySVaUbEg1GQfeGn6sx3lLPd/TWakgbBh7bRTSYE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b82Tp/lX; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-49cd77e0f95so9911425e9.3 for ; Wed, 02 Sep 2026 04:42:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788349347; x=1788954147; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tNaIMy3FNUffxv5Y47n7ZPK6WMtaZg+3IuJCsW/mzGY=; b=b82Tp/lXgLcznDS/HjsGDU9Ko3ygh7w+HD6ig7ZkW3bSxsxEC5an7kiqeMe5fCAuJk JDLO3Nc22yKib636FvVlsvCINHY21o9Lbgkjj2EvCdc6U6rnEEhbCoB881DotVDXQs9c vju5q+98sWloz6OnU7WdCdgfICUK5Mx89s7y1dERG3dt7JQCzMCt3ge/uoaRz0BJlhVw NINOyzqZRQbexTYKtVfzgqbFEBEAzJzQuNkg5IrfPMFPx2jGLil0h3H7KR9wbwYAjWtz 0+uEiXvz04WsF91rPrdCsG2JfdImmIWq4X82yf42sylNx1osT8hewEbbc0vHcc7qRZEi cq8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788349347; x=1788954147; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tNaIMy3FNUffxv5Y47n7ZPK6WMtaZg+3IuJCsW/mzGY=; b=I2jJVGgjK2O1Nl5reSKkBtfHwk/Sx9n+BZAfE++7k6gD+IRKb3Aw18HkAnBoJuWhEO Q8g0BdbrwU5K1H9i05G1LAjFIstNnqF91BG71NLjU9ftFD9ZTs9C0PDBj13SJaseIX0T kApc7jBFpRHpm3+P+1ugL+0ECtbHWphSOwL0dyS1OGNsVW298cjDkwHNJ0qTWnHGeHxJ uozdg1OFTAL6AKNDy+gMTgA6FaNMKlsBeaBPcTUpOibwyrLGcXzEEXCNI7/VFSF9Mi01 qgIjMHJmcqP5lNJB3uNfUMlriXcLcBUqRssBGVV1D/YG3Cn1YP1XgpR5Jl+ulPvU+lqT q5TQ== X-Forwarded-Encrypted: i=1; AHgh+Rr57k1QD+RSCR/7WwkA8bLqNfX0oWNIlESPjpGe9WfrsX6YzV6w0pavYDObf/kl7PtOS4McWU6YLZCS@vger.kernel.org X-Gm-Message-State: AFuF++nIYUhYld0ItlRlUJ+CD0i8LGzT9nx2QKOow1ArFcbG9rPJUA0/ PLeZOo6Osm4MFzabVGaQaasMibPj2uTWpS3ZGmg23nHoYU2e6bd42URX X-Gm-Gg: AR+sD12Bjti1wuT9M+xSKQxM0ghguDkngbB6zcQfbLRmN7VDroWrik8vM0LQy4wGfBk L3+pvB2qJwDditoXnecDcg4Dz0WljKeKIQrdU5bOJY5r2FtZe7TgwIMK75WUl8FD4p2+D7wxakP PpeSpErC44gU9APKqgKzfqjo7Lx/ybWOJrzjKFRF28piNn+fbwqP7eIK30pdhl4gxGW3XRv2Owu 51zvlH9U6tA+i39pTs+pltJ+BchJtlRw5ytVyqfH0rR/DUCxQf7GWV50MJ+edlDl43C+Ky6BBOd IywLsHM9bLaDWIcI+VsEjTdkvq6UpR/y5fWP0/oY3KHAoNkMRgIXTgoIAJIHETLKD+H5ppuyLBE 2rBuSVOVOI1HyBFKih7mz/71RPhDla10ZwIBcHewwnyvrsy5gkpNJi7xIZUgLrWt17l8n6al6CD +bb9iORMtCEnRDnkYx6nt7fqDtTXdddjHhOT/kzu80TRvLF7FYWg36lIbszTH3Q7iYb+9blp3fw 8l/DdTKfL849exUAdRaVsVqFX9i4lBjoz5bMS+ts4mLFr5/khdO4R0AhpIuWRY= X-Received: by 2002:a05:600c:3f08:b0:49c:e1ed:26b1 with SMTP id 5b1f17b1804b1-49ce5850cefmr77892325e9.16.1788349346888; Wed, 02 Sep 2026 04:42:26 -0700 (PDT) Received: from ernest.hoecke-nb (248.201.173.83.static.wline.lns.sme.cust.swisscom.ch. [83.173.201.248]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ce5952560sm40390935e9.3.2026.09.02.04.42.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 04:42:26 -0700 (PDT) From: Ernest Van Hoecke Date: Wed, 02 Sep 2026 13:41:39 +0200 Subject: [PATCH RFC 1/2] of: property: fw_devlink: Follow GPIO nexus maps Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20260902-fw-devlink-nexus-ready-v1-1-68fe1996e78a@toradex.com> References: <20260902-fw-devlink-nexus-ready-v1-0-68fe1996e78a@toradex.com> In-Reply-To: <20260902-fw-devlink-nexus-ready-v1-0-68fe1996e78a@toradex.com> To: Rob Herring , Saravana Kannan Cc: "Miquel Raynal (Schneider Electric)" , Frank Li , Kieran Bingham , Pengutronix Kernel Team , Stephen Boyd , Brian Masney , Linus Walleij , Bartosz Golaszewski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Herve Codina , Greg Kroah-Hartman , Geert Uytterhoeven , Leonardo Costa , devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, Ernest Van Hoecke , stable@vger.kernel.org X-Mailer: b4 0.13.0 From: Ernest Van Hoecke GPIO consumers use of_parse_phandle_with_args_map() to resolve specifiers through gpio-map properties. fw_devlink instead parses GPIO properties as direct phandle references, so it records the nexus node as the supplier rather than the mapped GPIO provider. A nexus is a translation node, not the GPIO provider, and need not be populated as a device. The resulting fwnode link can therefore remain unresolved and indefinitely defer the consumer while device_links_check_suppliers() waits for the nexus. Use the map-aware parser for all supported GPIO property spellings. This makes fw_devlink resolve the same provider as the GPIO consumer API. Direct GPIO references continue to work because the map-aware parser returns the original provider when no gpio-map property is present. Add OF unittest coverage for mapped and direct GPIO suppliers, including the deprecated singular and unprefixed property spellings. Fixes: 7f00be96f125 ("of: property: Add device link support for interrupt-parent, dmas and -gpio(s)") Reported-by: Leonardo Costa Link: https://lore.kernel.org/all/juuc4af7ndbajcl7gzf4tg5qz2q2j5tt3rvql4jbauradujrre@gc5nbdhhixaf/ Tested-by: Leonardo Costa Cc: stable@vger.kernel.org Signed-off-by: Ernest Van Hoecke Acked-by: Linus Walleij --- drivers/of/property.c | 38 +++++++++++----- drivers/of/unittest-data/tests-phandle.dtsi | 33 ++++++++++++++ drivers/of/unittest.c | 67 +++++++++++++++++++++++++++++ 3 files changed, 128 insertions(+), 10 deletions(-) diff --git a/drivers/of/property.c b/drivers/of/property.c index 72cf12907de0..380df0861ab9 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -1311,6 +1311,19 @@ static struct device_node *parse_prop_cells(struct device_node *np, return sup_args.np; } +static struct device_node *parse_nexus_prop(struct device_node *np, + const char *prop_name, int index, + const char *stem_name) +{ + struct of_phandle_args sup_args; + + if (of_parse_phandle_with_args_map(np, prop_name, stem_name, index, + &sup_args)) + return NULL; + + return sup_args.np; +} + #define DEFINE_SIMPLE_PROP(fname, name, cells) \ static struct device_node *parse_##fname(struct device_node *np, \ const char *prop_name, int index) \ @@ -1361,6 +1374,15 @@ static struct device_node *parse_##fname(struct device_node *np, \ return parse_suffix_prop_cells(np, prop_name, index, suffix, cells); \ } +#define DEFINE_SUFFIX_NEXUS_PROP(fname, suffix, stem) \ +static struct device_node *parse_##fname(struct device_node *np, \ + const char *prop_name, int index) \ +{ \ + if (!strends(prop_name, suffix)) \ + return NULL; \ + return parse_nexus_prop(np, prop_name, index, stem); \ +} + /** * struct supplier_bindings - Property parsing functions for suppliers * @@ -1416,7 +1438,7 @@ DEFINE_SIMPLE_PROP(pses, "pses", "#pse-cells") DEFINE_SIMPLE_PROP(power_supplies, "power-supplies", NULL) DEFINE_SIMPLE_PROP(mmc_pwrseq, "mmc-pwrseq", NULL) DEFINE_SUFFIX_PROP(regulators, "-supply", NULL) -DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells") +DEFINE_SUFFIX_NEXUS_PROP(gpio, "-gpio", "gpio") static struct device_node *parse_pinctrl_n(struct device_node *np, const char *prop_name, int index) @@ -1436,8 +1458,10 @@ static struct device_node *parse_gpios(struct device_node *np, if (strends(prop_name, ",nr-gpios")) return NULL; - return parse_suffix_prop_cells(np, prop_name, index, "-gpios", - "#gpio-cells"); + if (!strends(prop_name, "-gpios")) + return NULL; + + return parse_nexus_prop(np, prop_name, index, "gpio"); } static struct device_node *parse_iommu_maps(struct device_node *np, @@ -1452,8 +1476,6 @@ static struct device_node *parse_iommu_maps(struct device_node *np, static struct device_node *parse_gpio_compat(struct device_node *np, const char *prop_name, int index) { - struct of_phandle_args sup_args; - if (strcmp(prop_name, "gpio") && strcmp(prop_name, "gpios")) return NULL; @@ -1464,11 +1486,7 @@ static struct device_node *parse_gpio_compat(struct device_node *np, if (of_property_read_bool(np, "gpio-hog")) return NULL; - if (of_parse_phandle_with_args(np, prop_name, "#gpio-cells", index, - &sup_args)) - return NULL; - - return sup_args.np; + return parse_nexus_prop(np, prop_name, index, "gpio"); } static struct device_node *parse_interrupts(struct device_node *np, diff --git a/drivers/of/unittest-data/tests-phandle.dtsi b/drivers/of/unittest-data/tests-phandle.dtsi index 554a996b2ef1..163ef07be16d 100644 --- a/drivers/of/unittest-data/tests-phandle.dtsi +++ b/drivers/of/unittest-data/tests-phandle.dtsi @@ -79,6 +79,39 @@ consumer-b { phandle-list-bad-args = <&provider2 1 0>, <&provider4 0>; }; + + fw-devlink-tests { + gpio_provider: gpio-controller { + #gpio-cells = <2>; + }; + + test_nexus: nexus { + #gpio-cells = <2>; + gpio-map = <0 0 &gpio_provider 1 0>; + gpio-map-mask = <0xffffffff 0>; + gpio-map-pass-thru = <0 0xffffffff>; + }; + + gpio-compat-consumer { + gpios = <&test_nexus 0 0>; + }; + + gpio-compat-singular-consumer { + gpio = <&test_nexus 0 0>; + }; + + gpio-consumer { + test-gpios = <&test_nexus 0 0>; + }; + + gpio-direct-consumer { + test-gpios = <&gpio_provider 1 0>; + }; + + gpio-singular-consumer { + test-gpio = <&test_nexus 0 0>; + }; + }; }; }; }; diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index e255f54f4d76..487f3b629a73 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -10,6 +10,7 @@ #include /* to test phys_to_dma/dma_to_phys */ #include #include +#include #include #include #include @@ -710,6 +711,71 @@ static void __init of_unittest_parse_phandle_with_args_map(void) } } +static void __init of_unittest_fw_devlink_supplier(struct device_node *tests, + const char *consumer_name, + const char *supplier_name) +{ + struct device_node *consumer, *supplier; + struct fwnode_handle *consumer_fwnode; + struct fwnode_link *link; + unsigned int link_count = 0; + bool found = false; + int rc; + + consumer = of_get_child_by_name(tests, consumer_name); + supplier = of_get_child_by_name(tests, supplier_name); + if (!consumer || !supplier) { + pr_err("missing consumer %s or supplier %s\n", consumer_name, supplier_name); + goto put_nodes; + } + + consumer_fwnode = of_fwnode_handle(consumer); + fwnode_links_purge(consumer_fwnode); + rc = fwnode_call_int_op(consumer_fwnode, add_links); + if (unittest(!rc, "failed to add links for %pOF: %d\n", consumer, rc)) + goto purge_links; + + /* + * fwnode_link_lock is private to the driver core. These test nodes are + * isolated and no one should modify their links now, so it is safe to + * inspect the supplier list without the lock here. + */ + list_for_each_entry(link, &consumer_fwnode->suppliers, c_hook) { + link_count++; + if (link->supplier == of_fwnode_handle(supplier)) + found = true; + } + + unittest(link_count == 1, "%pOF has %u suppliers, expected 1\n", consumer, link_count); + unittest(found, "%pOF is not linked to supplier %pOF\n", consumer, supplier); + +purge_links: + fwnode_links_purge(consumer_fwnode); +put_nodes: + of_node_put(consumer); + of_node_put(supplier); +} + +static void __init of_unittest_fw_devlink(void) +{ + const char *gpio_supplier = "gpio-controller"; + struct device_node *tests; + + tests = of_find_node_by_path("/testcase-data/phandle-tests/fw-devlink-tests"); + if (!tests) { + pr_err("missing fw_devlink test data\n"); + return; + } + + of_unittest_fw_devlink_supplier(tests, "gpio-compat-consumer", gpio_supplier); + of_unittest_fw_devlink_supplier(tests, "gpio-compat-singular-consumer", gpio_supplier); + of_unittest_fw_devlink_supplier(tests, "gpio-consumer", gpio_supplier); + of_unittest_fw_devlink_supplier(tests, "gpio-direct-consumer", gpio_supplier); + of_unittest_fw_devlink_supplier(tests, "gpio-singular-consumer", gpio_supplier); + + of_node_put(tests); +} + static void __init of_unittest_property_string(void) { const char *strings[4]; @@ -4533,6 +4599,7 @@ static int __init of_unittest(void) of_unittest_dynamic(); of_unittest_parse_phandle_with_args(); of_unittest_parse_phandle_with_args_map(); + of_unittest_fw_devlink(); of_unittest_printf(); of_unittest_property_string(); of_unittest_property_copy(); From patchwork Wed Sep 2 11:41:40 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ernest Van Hoecke X-Patchwork-Id: 2296556 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=K5jz9n29; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org; envelope-from=linux-gpio+bounces-42613-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from sto.lore.kernel.org (sto.lore.kernel.org [IPv6:2600:3c09:e001:a7::12fc:5321]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4hZgpl57WFz1xwZ for ; Wed, 02 Sep 2026 21:43:27 +1000 (AEST) Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sto.lore.kernel.org (Postfix) with ESMTP id A3D70612339 for ; Wed, 2 Sep 2026 11:42:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D71EC47DD43; Wed, 2 Sep 2026 11:42:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K5jz9n29" X-Original-To: linux-gpio@vger.kernel.org Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F256A47B436 for ; Wed, 2 Sep 2026 11:42:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788349353; cv=none; b=MSO11iNdh3kyLYdNC0TcibdoaRQpOqrQ3HOkoaPxQ6QudeH1hLSIZRYbZdKi7wL//lu8sVj2P5D8OG3H7/MiL2TtbD9oKF2ejEqfyLUcgNUvJ3Mkeert3T9/dFmL0Tt27aJYS8PsQ0pH6aqIuwB4oDO4gopJN67uFhD9oPmuB/g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788349353; c=relaxed/simple; bh=NfyudVlM1yxKj5OTCD08HZwEQLKw64XdIbJ0S9NfQl4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iZJSpye1DAglWoUaYMdM/quUjLbe6n21ln/k6IkjGW8u9lKoP1NxB9kJixHY/WKPkhXiQ5e1mlBcrJF1WhmChoVmlI1TsSo4WE0Zhg+lHpWzBIz2FiLqWB9ippOH/8++Vj3pLadzqHOIsFwVReKcFxVtbMM44QL8LOYOMzosg6Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K5jz9n29; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-498028b3d5eso9881695e9.1 for ; Wed, 02 Sep 2026 04:42:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788349348; x=1788954148; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XyxU90qE2pDTOzsNo7+C4R6hGdb1tidiljFavckLhOQ=; b=K5jz9n29INtUEqSS97sa3DSNz0S+sH9cInbVshmil0CJISCe23pU1Bqa24wrEwqNMS 8Pqp3FGKaZDtBpeutCkOwwtKp1N3VTwi1ySWYyn0mkX5es8udaV342fh7XdknDV7AX+y pKhjGPf6/ZD7DlGtMoV0tkLdTl1XP0zd+fjfP5NKhpwG9jqnqGSzp6enD6qVCdMbGg7P SoyIqiaNT/65fHl2K1xH2m9+3s8+5lEZp3g4bOhkK3Qlnhgt2vNcblCfJE0tTOWmCoMQ 2ngms8q61LXHyVxaL+yAd5yAl16j5W28NLiBWm0iWQpMHspDb/Aoc63rWcyDbpYVVPhL Cxzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788349348; x=1788954148; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XyxU90qE2pDTOzsNo7+C4R6hGdb1tidiljFavckLhOQ=; b=B8uF4IkWSJ72+i5ZxKgSnXIXLbjX42FAiUZGoNt6sS3k2dvBoHnqgSr61mv21y+nyD 9AQXYfDn4Zlyzv32PDuv4GBKTKFHRkvfqsdCJDlrGgRfJZ/H1uy3V3QEubjHgJGy6gUY aoFeDnvdLxhj/vetucCfStFgkxvuCvgxZ6r4W9ss7Lahu7NGu16Mwzxz7/UL4Wq5I6rI hEFPK5ulWbaJGKrA9AvrvBsoKFO0j6XRTim9yAv+WgeBsDFSkQAq4DaDlGIikwFs6Nx0 4LOb2iie4BCApxRtDk7+Maz89IbiKwIp0eI/ioV/+Jcj9mRT9vKFNhNH2Dog+sel8TZr H5Bg== X-Forwarded-Encrypted: i=1; AHgh+RrrawdhsYtYcKCWhs6OezUgbIHyzI44XyqwppHtdgof7wFcM0bITL3FgjZxPo09uZXHkWaMbdWCue93@vger.kernel.org X-Gm-Message-State: AFuF++mSycNoMi95j/PNXhxjBBBzWNXnZISw8dT25OPm2H2lCRcqmtjD CsqTc8fSu4YyDRALP22tY3WKaaELdTjgWce46F+XEumDeOdPA0W8OThg X-Gm-Gg: AR+sD12Osw3TAmmhhXuEoDt8DWgYtQNwEl4tIXTteB+lXoKbP2tDdOzSWpaENLi/isd 7k7vtMlHTnJd4vBEa+VoYtFLf+pPsnbIZpz9r75h9zANYH957s4kxQwLnxl6TWtrOCqRQFqdf+w kLwmlUabXtbMQx0r9DwfMfCea3hw2vmobT3POKKsW4sb/wImgGgQ+MFr/ZNcTQZzPKSUi0DinRV 2d7HQIQ6tuFANorz1PDj0DmPLRUqBaWMu2LGDkAiChF50G04c7Ww3gb010Y15TNFAMka0paXKGP rBQjcXlhriYiMN8QJF4bL2IhwrEAnZxCgoa/UKLyswCcN35S9JPZaTdPuuSn1weZRSyQl+Leu+l IxDC+CSXDguJGuUuBc8AC58S2uJdvpWRmM1vfRwQWziZCOp/27LfPnsCQ+dPo73Eh9s2BthuBMb NBOd+cfXiHV9C7akpuhCqXvaD/kFwg1JUtF7ySjT2t/Ws8RGqRj0CH30l+ff562zZT5bqs5NAvA dUMln0GPK2FZ8Q6AUERPq8U7UX4/ex7BKiDzr6aYVMmENRAPwwohIl+wmLtaHw= X-Received: by 2002:a05:600c:4e86:b0:49a:77c1:d246 with SMTP id 5b1f17b1804b1-49ce5852589mr70729315e9.15.1788349347944; Wed, 02 Sep 2026 04:42:27 -0700 (PDT) Received: from ernest.hoecke-nb (248.201.173.83.static.wline.lns.sme.cust.swisscom.ch. [83.173.201.248]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ce5952560sm40390935e9.3.2026.09.02.04.42.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 04:42:27 -0700 (PDT) From: Ernest Van Hoecke Date: Wed, 02 Sep 2026 13:41:40 +0200 Subject: [PATCH RFC 2/2] of: property: fw_devlink: Follow PWM nexus maps Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20260902-fw-devlink-nexus-ready-v1-2-68fe1996e78a@toradex.com> References: <20260902-fw-devlink-nexus-ready-v1-0-68fe1996e78a@toradex.com> In-Reply-To: <20260902-fw-devlink-nexus-ready-v1-0-68fe1996e78a@toradex.com> To: Rob Herring , Saravana Kannan Cc: "Miquel Raynal (Schneider Electric)" , Frank Li , Kieran Bingham , Pengutronix Kernel Team , Stephen Boyd , Brian Masney , Linus Walleij , Bartosz Golaszewski , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Herve Codina , Greg Kroah-Hartman , Geert Uytterhoeven , Leonardo Costa , devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, Ernest Van Hoecke , stable@vger.kernel.org X-Mailer: b4 0.13.0 From: Ernest Van Hoecke PWM consumers use of_parse_phandle_with_args_map() to resolve specifiers through pwm-map properties. fw_devlink instead parses the pwms property as a direct phandle reference, so it records the nexus node as the supplier rather than the mapped PWM provider. A nexus is a translation node, not the PWM provider, and need not be populated as a device. The resulting fwnode link can therefore remain unresolved and indefinitely defer the consumer while device_links_check_suppliers() waits for the nexus. Use the map-aware parser for pwms so fw_devlink resolves the same provider as the PWM consumer API. Direct PWM references continue to work because the map-aware parser returns the original provider when no pwm-map property is present. Add OF unittest coverage for mapped and direct PWM suppliers. Fixes: e71e46a6f19c ("pwm: Add support for pwm nexus dt bindings") Reported-by: Leonardo Costa Link: https://lore.kernel.org/all/juuc4af7ndbajcl7gzf4tg5qz2q2j5tt3rvql4jbauradujrre@gc5nbdhhixaf/ Tested-by: Leonardo Costa Cc: stable@vger.kernel.org Signed-off-by: Ernest Van Hoecke --- drivers/of/property.c | 11 ++++++++++- drivers/of/unittest-data/tests-phandle.dtsi | 16 ++++++++++++++++ drivers/of/unittest.c | 4 ++++ 3 files changed, 30 insertions(+), 1 deletion(-) diff --git a/drivers/of/property.c b/drivers/of/property.c index 380df0861ab9..d5e89beb17f9 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -1331,6 +1331,15 @@ static struct device_node *parse_##fname(struct device_node *np, \ return parse_prop_cells(np, prop_name, index, name, cells); \ } +#define DEFINE_SIMPLE_NEXUS_PROP(fname, name, stem) \ +static struct device_node *parse_##fname(struct device_node *np, \ + const char *prop_name, int index) \ +{ \ + if (strcmp(prop_name, name)) \ + return NULL; \ + return parse_nexus_prop(np, prop_name, index, stem); \ +} + /** * parse_suffix_prop_cells - Suffix property parsing function for suppliers * @@ -1426,7 +1435,6 @@ DEFINE_SIMPLE_PROP(extcon, "extcon", NULL) DEFINE_SIMPLE_PROP(nvmem_cells, "nvmem-cells", "#nvmem-cell-cells") DEFINE_SIMPLE_PROP(phys, "phys", "#phy-cells") DEFINE_SIMPLE_PROP(wakeup_parent, "wakeup-parent", NULL) -DEFINE_SIMPLE_PROP(pwms, "pwms", "#pwm-cells") DEFINE_SIMPLE_PROP(resets, "resets", "#reset-cells") DEFINE_SIMPLE_PROP(leds, "leds", NULL) DEFINE_SIMPLE_PROP(backlight, "backlight", NULL) @@ -1438,6 +1446,7 @@ DEFINE_SIMPLE_PROP(pses, "pses", "#pse-cells") DEFINE_SIMPLE_PROP(power_supplies, "power-supplies", NULL) DEFINE_SIMPLE_PROP(mmc_pwrseq, "mmc-pwrseq", NULL) DEFINE_SUFFIX_PROP(regulators, "-supply", NULL) +DEFINE_SIMPLE_NEXUS_PROP(pwms, "pwms", "pwm") DEFINE_SUFFIX_NEXUS_PROP(gpio, "-gpio", "gpio") static struct device_node *parse_pinctrl_n(struct device_node *np, diff --git a/drivers/of/unittest-data/tests-phandle.dtsi b/drivers/of/unittest-data/tests-phandle.dtsi index 163ef07be16d..7cb3e19554b6 100644 --- a/drivers/of/unittest-data/tests-phandle.dtsi +++ b/drivers/of/unittest-data/tests-phandle.dtsi @@ -85,11 +85,19 @@ gpio_provider: gpio-controller { #gpio-cells = <2>; }; + pwm_provider: pwm-controller { + #pwm-cells = <3>; + }; + test_nexus: nexus { #gpio-cells = <2>; + #pwm-cells = <3>; gpio-map = <0 0 &gpio_provider 1 0>; gpio-map-mask = <0xffffffff 0>; gpio-map-pass-thru = <0 0xffffffff>; + pwm-map = <0 0 0 &pwm_provider 1 0 0>; + pwm-map-mask = <0xffffffff 0 0>; + pwm-map-pass-thru = <0 0xffffffff 0xffffffff>; }; gpio-compat-consumer { @@ -111,6 +119,14 @@ gpio-direct-consumer { gpio-singular-consumer { test-gpio = <&test_nexus 0 0>; }; + + pwm-consumer { + pwms = <&test_nexus 0 1000 0>; + }; + + pwm-direct-consumer { + pwms = <&pwm_provider 1 1000 0>; + }; }; }; }; diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 487f3b629a73..508ebc7581c8 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -759,6 +759,7 @@ static void __init of_unittest_fw_devlink_supplier(struct device_node *tests, static void __init of_unittest_fw_devlink(void) { const char *gpio_supplier = "gpio-controller"; + const char *pwm_supplier = "pwm-controller"; struct device_node *tests; tests = of_find_node_by_path("/testcase-data/phandle-tests/fw-devlink-tests"); @@ -773,6 +774,9 @@ static void __init of_unittest_fw_devlink(void) of_unittest_fw_devlink_supplier(tests, "gpio-direct-consumer", gpio_supplier); of_unittest_fw_devlink_supplier(tests, "gpio-singular-consumer", gpio_supplier); + of_unittest_fw_devlink_supplier(tests, "pwm-consumer", pwm_supplier); + of_unittest_fw_devlink_supplier(tests, "pwm-direct-consumer", pwm_supplier); + of_node_put(tests); }