From patchwork Thu May 14 08:34:17 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrei Otcheretianski X-Patchwork-Id: 2238143 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=JW9Yq7GM; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=AdcTMKW+; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4gGNyd0KbWz1yJ5 for ; Thu, 14 May 2026 18:38:33 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=VKFCSEJjB4solNI3j7P9UqZ9dHxAsGxR/P3DTTLlBks=; b=JW9Yq7GMKHZTcT 9VKAIlK8vUhLBE+5JWPUXdnuEI8QVszjlZIB4gEvFpqCnHgXKM/W2uQeTLkQUlFypSHTo13V0qfy3 o7121m156nxAJJd91YYYRKb/Ro6Xv7LJ/eUKjaBycvVY4J//KXXmfm+SdTTrr18FL2qVozOjE/190 zcy3qmx5q2AlUntjtNFGhcQgbgEldDn5RSbX2BkljOzHrw3C+hPxJ/v10E9uo5x1oJ2FZ80icH/ms ksHwKYa4wvKirE5QW/Jq86sVc8JWbZLayh46OhTYaDXSZ6I2TOBCcZ23CucpO1itgbPsuXJFPIW3Z X9xeh8ffVD7bwB2WkgLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wNRYj-00000004xvZ-2zFx; Thu, 14 May 2026 08:36:45 +0000 Received: from mgamail.intel.com ([192.198.163.8]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wNRYf-00000004xho-2MRh for hostap@lists.infradead.org; Thu, 14 May 2026 08:36:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778747802; x=1810283802; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=z4IAfp/zlop5W6AQfRkR4+AJdvWq2YykUxhE6iaLJHw=; b=AdcTMKW+3z1Fu52clyFzBQJUNgelifkVDvi07DsQ5eUsvishO93dL5Zj uUF9KU6bAu/2xXU1cPXcMDUKkGZs4jaEYqGRB2BoHNPeWb5pQeHA1D3xm Up3/kwitL4qHcuJO9/JaqZQMkXdGNyCY487Khfqi7DVVLo1VEpNO1TyzT nwT+48NqJvd9JFS301ivkXnMvQdDfMd1aiEAtL/bBQmyPMIXgAdLc01Pl BUw+HcbsuZRr16qLloUNslZuEITGulSP1OPMbs1/A/LaeEYrDG/Yph4ny zxzkALaDza5+hH+lW2FkxFZhCsOnDqqcsA4YsaIdFCOBFz8VHdguZIdLH g==; X-CSE-ConnectionGUID: mgYEyBGYReS2khelNclfjA== X-CSE-MsgGUID: /7U2M9adTiKl+2R5N5DIng== X-IronPort-AV: E=McAfee;i="6800,10657,11785"; a="97257743" X-IronPort-AV: E=Sophos;i="6.23,234,1770624000"; d="scan'208";a="97257743" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2026 01:34:38 -0700 X-CSE-ConnectionGUID: XY03/Ek2Qs6UNBYvgWbOqA== X-CSE-MsgGUID: NZ/zoiOGS7mXP0drvgX1Tw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,234,1770624000"; d="scan'208";a="243305542" Received: from iapp347.iil.intel.com (HELO 87c02287900a.iil.intel.com) ([10.167.28.6]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2026 01:34:36 -0700 From: Andrei Otcheretianski To: hostap@lists.infradead.org Cc: vamsin@qti.qualcomm.com, maheshkkv@google.com, Ilan Peer Subject: [PATCH] NAN: Fix setting PBM in NAN discovery event Date: Thu, 14 May 2026 11:34:17 +0300 Message-ID: <20260514083418.34498-1-andrei.otcheretianski@intel.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260514_013641_638203_C0254DF1 X-CRM114-Status: GOOD ( 10.71 ) X-Spam-Score: -4.8 (----) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Ilan Peer The pairing and bootstrapping value was set before the NAN discovery object was memset. Fix this by moving the memset() call earlier. Signed-off-by: Ilan Peer --- src/common/nan_de.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Content analysis details: (-4.8 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [192.198.163.8 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.4 DKIMWL_WL_HIGH DKIMwl.org - High trust sender -0.0 DMARC_PASS DMARC pass policy X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Ilan Peer The pairing and bootstrapping value was set before the NAN discovery object was memset. Fix this by moving the memset() call earlier. Signed-off-by: Ilan Peer --- src/common/nan_de.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/nan_de.c b/src/common/nan_de.c index c5b1022772..ba61412bd9 100644 --- a/src/common/nan_de.c +++ b/src/common/nan_de.c @@ -1529,6 +1529,7 @@ static bool nan_de_rx_publish(struct nan_de *de, struct nan_de_service *srv, } send_event: + os_memset(&res, 0, sizeof(res)); if (buf && buf_len > 0) { /* Parse Cipher Suite Information Attribute */ cipher_suite_count = nan_de_parse_csia( @@ -1552,7 +1553,6 @@ send_event: res.pbm = nan_de_get_advertise_pbm(buf, buf_len); } - os_memset(&res, 0, sizeof(res)); res.subscribe_id = srv->id; res.srv_proto_type = srv_proto_type; res.ssi = ssi;