From patchwork Fri Nov 21 18:50:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcos Paulo de Souza X-Patchwork-Id: 2167799 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=temperror header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=gLdyr7l8; dkim=pass (2048-bit key; unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=CIniQ0VW; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4dCknp5hjGz1yDM for ; Sat, 22 Nov 2025 05:51:06 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IKpU+JVEo8jImM4RsWriqSa3YyacHuZk4xRkxS0guks=; b=gLdyr7l8xC2e+4dvRJmfBeNSu+ bwyANJRNxfcaw5EV/HLiBdoyuALXeHBH9f1JQOQEnjwyCudPG8yzA4S/xHMpRiiM/PWkawannq4T6 6UPDs0hC2EoRf6fBu9b3ipz/dHts3lXXWEWlOdCPv0eFY00TQ5fBTWQle9xxZX2HJdFASbv9Rb3xE G+foyhddXr5B9sQBu2v92T1+Pwgjyw8M3qbePUYsDsSWZl14r3hKo/FqRmVZ2Orbn3J32kpIsFg5t vXga5XNdOk1Itu+D94fyPJHT94G5uKia4+1PB/2PiczHGKkbJxVfxBf2Q63qPkMMAic4mOuNBKYwK 1MCunNfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vMWDo-00000008s42-263U; Fri, 21 Nov 2025 18:51:04 +0000 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vMWDl-00000008s37-3IlP for linux-um@lists.infradead.org; Fri, 21 Nov 2025 18:51:02 +0000 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-42b3d4d9ca6so2035320f8f.2 for ; Fri, 21 Nov 2025 10:51:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763751060; x=1764355860; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IKpU+JVEo8jImM4RsWriqSa3YyacHuZk4xRkxS0guks=; b=CIniQ0VWwt7lxurzQVNAkOmmaL+oIH7WpnVd7s3LK8kbHXQyLtkeLlZX/tHRAbHg08 W1EYE1vHZAhuLPBqqAAwL1OpNxrKeH8l0pLkFmDA3otdDyfswZ7HSBF7YnAgRcKVhlJq 3BbAE7/HhV9PaftBYp+Da1zzZXCDEcrwvu1rv8DN178+TtTR88YDMjjUjkQygYi0szMv EgyDTNfLWx9ANcwkIxyMEmDenEvDE27pG9dtd8dSRM4renkz1O/070UN8OjrYEZkmEhf jHqD785++FoIJR6S0WvlkVYyW57hbNJTi/KPxUrKlRl3PZ4Rl4wWLbtvJZ54n5yvH1uB bNWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763751060; x=1764355860; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IKpU+JVEo8jImM4RsWriqSa3YyacHuZk4xRkxS0guks=; b=XKcxNFXBV6DDql9byK5kDdhRuv22+Y+8NvCZuMWO2mI5D+CYGey7XBKqNHSZ5doLeb fUc6ksL+nEj3Ih6dcVTiIHPplOIP+WHMPJ9pATsoz4ay+FUsWfFspxnR5tPuXPnkPnUf 6TBZCPDBjFAcPjSK1XzDp47+g/Qs3ceXyYQDvxPsIJnbrUbjbCgfUi5D4laOrHfSZJBv YC6IJ9mBaI0sP7rnoONcnvoWq47n3/+9A3ITBx5jCPL9g+rI6V/RBLPh/gDvH8CIzCUo 3N8gD0otB3bXZELntHbCbXd+gXzYJqux591JZysWdph6TDdyEHnMRFcWYVCAA6GbFXIY c8fw== X-Forwarded-Encrypted: i=1; AJvYcCUZeZlIhUVIPHkRKydQLrLt/Mq/pN2j+//k/jETio5oYQga04OtjMM9qyfOLjemFbfsCrHrXPLCXg==@lists.infradead.org X-Gm-Message-State: AOJu0YyEmlXUUcWvEJfT3ybVwuzt4wxyWC8WAvSg4ClPc3jO5jGdHF0F WInI2Lp6uKAevPrYu1RUMrk/OgrPR8cpX41FgupAfLOtpoA0ONGyBXZSV+/zAi4OYKlY4srBMzy yUaTwHUM= X-Gm-Gg: ASbGnctBnRSV/OuNb3RDjVbZbB28w+GmDyrar9jHgWXHN/ujMXkPjovZX09XVYiWEzf 3YCKLyeskshXV1zbDAKVne2epkH31IAKllFJexUse4Nlf9ebN8ja+UkvdWYSBmFjOGz8ib/0lj4 Acl3i4t71qBl03zguVRJFqya1Tc1lD7CvYR2lvdIAD6uoAT+JEOYJIiVR692T7+5gDFggSnineb EbvB5A4H5FAsV7XZ7cZ9ldSnxBoToJc647kFdJmiO5hlq2+XcK4+hPG0M7N01wAlTCTVv5gmGro j+LjNSaywEgMWT+ecBOJAYI4mD7VGw7/wIsPv4xicBQI9BJajTBCNC0355zr6/QBke1N3X9umYD DO48jxSxQc550F6c6AQCgFAtSPq/kTNxCOCCMmUFpNwH+Miu1UcPfIvBS7l3opUsFvPdxcNmn3+ YYa+goSgQMZ3drQgInXd8htGLUIeCkQJXLlVAI6wWSdhXlLg== X-Google-Smtp-Source: AGHT+IEp7w0ciNVkPyG6KJveUGftNTpGrWBeH1bxscHmBcc3IXgFsFDEhjsS1npeT4GimD56otbUpA== X-Received: by 2002:a05:6000:1a8f:b0:42b:3c25:cd06 with SMTP id ffacd0b85a97d-42cc1cee419mr3544639f8f.22.1763751059776; Fri, 21 Nov 2025 10:50:59 -0800 (PST) Received: from [127.0.0.1] (99.36.160.45.gramnet.com.br. [45.160.36.99]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fd8baesm12473639f8f.39.2025.11.21.10.50.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 10:50:59 -0800 (PST) From: Marcos Paulo de Souza Date: Fri, 21 Nov 2025 15:50:33 -0300 Subject: [PATCH v2 1/4] drivers: serial: kgdboc: Drop checks for CON_ENABLED and CON_BOOT MIME-Version: 1.0 Message-Id: <20251121-printk-cleanup-part2-v2-1-57b8b78647f4@suse.com> References: <20251121-printk-cleanup-part2-v2-0-57b8b78647f4@suse.com> In-Reply-To: <20251121-printk-cleanup-part2-v2-0-57b8b78647f4@suse.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Jason Wessel , Daniel Thompson , Douglas Anderson , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-um@lists.infradead.org, Marcos Paulo de Souza X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1763751050; l=1305; i=mpdesouza@suse.com; s=20231031; h=from:subject:message-id; bh=TNAGn41MV021H2aUeZwKlB7H00LNs29SUKDaNMAUfzg=; b=44EC1mGND1ysTRERb+Is2jw0ncg0VNA7gddxT3UyAFKxKAz8occNwGH/6zo30HTuKMjRMAhop twSzNFMCXkUByZW8HmxONIKjpn1N/Dp+wJcwjrr3eEm01IAp44DV16a X-Developer-Key: i=mpdesouza@suse.com; a=ed25519; pk=/Ni/TsKkr69EOmdZXkp1Q/BlzDonbOBRsfPa18ySIwU= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251121_105101_848639_616C1AAD X-CRM114-Status: GOOD ( 12.19 ) X-Spam-Score: -2.1 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The original code tried to find a console that has CON_BOOT _or_ CON_ENABLED flag set. The flag CON_ENABLED is set to all registered consoles, so in this case this check is always true, even for the C [...] Content analysis details: (-2.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:42f listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The original code tried to find a console that has CON_BOOT _or_ CON_ENABLED flag set. The flag CON_ENABLED is set to all registered consoles, so in this case this check is always true, even for the CON_BOOT consoles. The initial intent of the kgdboc_earlycon_init was to get a console early (CON_BOOT) or later on in the process (CON_ENABLED). The code was using for_each_console macro, meaning that all console structs were previously registered on the printk() machinery. At this point, any console found on for_each_console is safe for kgdboc_earlycon_init to use. Dropping the check makes the code cleaner, and avoids further confusion by future readers of the code. Signed-off-by: Marcos Paulo de Souza Reviewed-by: Petr Mladek --- drivers/tty/serial/kgdboc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/tty/serial/kgdboc.c b/drivers/tty/serial/kgdboc.c index 85f6c5a76e0f..5a955c80a853 100644 --- a/drivers/tty/serial/kgdboc.c +++ b/drivers/tty/serial/kgdboc.c @@ -577,7 +577,6 @@ static int __init kgdboc_earlycon_init(char *opt) console_list_lock(); for_each_console(con) { if (con->write && con->read && - (con->flags & (CON_BOOT | CON_ENABLED)) && (!opt || !opt[0] || strcmp(con->name, opt) == 0)) break; } From patchwork Fri Nov 21 18:50:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcos Paulo de Souza X-Patchwork-Id: 2167800 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=temperror header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=uMVju2se; dkim=pass (2048-bit key; unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=NVOYT7sV; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4dCknp6lYYz1yNP for ; Sat, 22 Nov 2025 05:51:10 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OLWRSgS8p73WSC4ZXf7/hoyNCz/96zbrBiHTXVpyk3k=; b=uMVju2sehFkh2ZM4zkORVyZe9o iOc2I1PeIkD34ED2qGGQ/u33Ld0u+9UkiGPVQRuyqlXp+iOg5TTJGbBmWhScSVn7xKYSwOgUzPSaE Gsi2XFt4R37JopRfpzxuriYsRPeTvemQWw0gpKdgI5BY8vJQqwX2WXYpOBTgpnSJ5eEIAuZO0iIpM I0hrN9apwiQj/rYfuVNafWSLFPt5HY8qASVibB6zMM7VrxQK6wpZnL99dUfJyCXV6VPfI+hF/+kcq jq6L/UTsQNK8CeRSaQw3MeHSY+8kKhSAgq7ucdawuTz3sOLkbWea9d6TINW19TjDyzo+ygff0YjHA o+R53m/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vMWDs-00000008s5o-3AHT; Fri, 21 Nov 2025 18:51:08 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vMWDq-00000008s4Q-2Chx for linux-um@lists.infradead.org; Fri, 21 Nov 2025 18:51:07 +0000 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-42b3ac40ae4so1378460f8f.0 for ; Fri, 21 Nov 2025 10:51:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763751064; x=1764355864; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=OLWRSgS8p73WSC4ZXf7/hoyNCz/96zbrBiHTXVpyk3k=; b=NVOYT7sVhAQM+JdcRdc0vXlcJ8z/5wom58lbYqWKYTv5MzXDvq40f5HywBOYarDDOZ CoVevkOPJP6KTtsefOaxpkiC88NhwaDQRd70kz/C1tlnXjG5JswHUohMd/YpUdvZPYus YiJpWNWM47V6gRBoQBZooggw8SlNu2m2vPr29PL8qnz9SULfq/sKqeTFm1tSo9L9Tfio 36rBE9FMiFFndFvfjE6RldBfm9UK11E7/0HWBUjXWEB3ycC2m5+vPXViWRafwkfJQ7Yd UL/9txMHGoNDR3CgdEMbNz142XnaBOz2UDAtD7cAaGIiIGbU2cI+SWqm3n9ZUJshgP4i kZMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763751064; x=1764355864; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=OLWRSgS8p73WSC4ZXf7/hoyNCz/96zbrBiHTXVpyk3k=; b=Br2cq78FN+FzcsfuRUJDaefJ7LShsHAGbGGau97rtTZC+PDKKsqNxO8cGYkkhO0Iyq JykUE1MKklCEQv14L3h/VsBgzUc45UXhy1pi2zsF7UNgSm8jrfjQjGLHd0S6mfQFCm8L j/zE2VRXOTIubrhM+svtfZRa5lylIpvrnpXmehLP1B/7rssSAvzzbdm7Sez63gJ0IOh7 gA7YotlIjrCukB82IhdEtJ7ZkqfxTmxBSWqrB9UeEpdDZYvzOfz30uQ2c4pE2uFZNAq1 6BotB4cUn0sBSW/RnsLdxAjEtfzcQ8YclrMvzBHcqEfNxhSiwzeVrpRDpAZ2z0XEDNEn mWmQ== X-Forwarded-Encrypted: i=1; AJvYcCViZHWYaiHL+b5wba/8z5Tsu/rX4aJMMVH3oKeguOAla1SLu71QudZS5bxoHtb28HgyVUCHoNV48A==@lists.infradead.org X-Gm-Message-State: AOJu0YyBjyJ4mvgBvTBkZUXm8itI2TQb63uR0mhYCKBNVyDwrbkFbfMp CkTRsPtb1E4kRmEE2qfetvNrShv8N6oA9R+fHgt+zNEljgIkYw13uIZxFObMaLFEVsYf8aNINaF AnyNUHYk= X-Gm-Gg: ASbGncvhaQpuJG2vYZJa30Kfb1Ckhs8asg0oHD9A7sd8P+aeyaiCr8BFJ09B6wSXObV XYYBXQqPNdZNt/BNaAD8cdW2JQIwoKUJSXDCk6gq8Buo/N2VqTjcxuO7iix3sEZDuA4cH3jaVz+ hvLLIElXMFEa8EPPbkh5jC0azu/UN4hq6GqAMMLQVj0dWmbhqkumb/mZjkOiTRB0KEm7C4PTIfX 0OhrJF8ThzykgMWngd+okYCnDSsPw8MWX5hNcm+bgLw+16fbH9irStceXYMd9zJnfWoMmqpELlr 4sMdcaa6k767EmQD0bayzfaBbUy10h4S55Qk5JK7oqbUh3E5GCEGudm82WAwNsw7rBoe1SmnCEQ 1BohLy0LogGVWMwIfEx3JWT4a62bOVhLgwlD11x87Qe1NXCCXdOrckNLLtXXvH05jRcu58RRxj6 JMVOeqfN7nx4QvnatJkpMb2ora2ja3fdjivts= X-Google-Smtp-Source: AGHT+IGFg2pBnIYtz+jUx29u1lZD8eVRjQQpeMqBKI00tlwv+iTZw9tV5Wu13Zv6ZTnAW9KrThP7uQ== X-Received: by 2002:a05:6000:230c:b0:429:dde3:659d with SMTP id ffacd0b85a97d-42cc1d0ce1dmr3746531f8f.47.1763751064299; Fri, 21 Nov 2025 10:51:04 -0800 (PST) Received: from [127.0.0.1] (99.36.160.45.gramnet.com.br. [45.160.36.99]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fd8baesm12473639f8f.39.2025.11.21.10.51.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 10:51:04 -0800 (PST) From: Marcos Paulo de Souza Date: Fri, 21 Nov 2025 15:50:34 -0300 Subject: [PATCH v2 2/4] arch: um: kmsg_dump: Use console_is_usable MIME-Version: 1.0 Message-Id: <20251121-printk-cleanup-part2-v2-2-57b8b78647f4@suse.com> References: <20251121-printk-cleanup-part2-v2-0-57b8b78647f4@suse.com> In-Reply-To: <20251121-printk-cleanup-part2-v2-0-57b8b78647f4@suse.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Jason Wessel , Daniel Thompson , Douglas Anderson , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-um@lists.infradead.org, Marcos Paulo de Souza X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1763751050; l=947; i=mpdesouza@suse.com; s=20231031; h=from:subject:message-id; bh=OUGnBzAKcXkW36Da9OkzDufBeFjxJOoOBfhwdvnkuOI=; b=NhgxbcLWcMIXgHoLmIkuyir16mphjDmcWSS+twRF1KgkvMiTNw7Q71Y6gddQptkBeT/ZV7ybA 7aK6FXimEBMB8iP+Lld4HVVYCnfUvIZlIMUIC+Vdjx4lrgmiiIWXdaA X-Developer-Key: i=mpdesouza@suse.com; a=ed25519; pk=/Ni/TsKkr69EOmdZXkp1Q/BlzDonbOBRsfPa18ySIwU= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251121_105106_587960_B2851AE6 X-CRM114-Status: GOOD ( 10.06 ) X-Spam-Score: -2.1 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: All consoles found on for_each_console are registered, meaning that all of them have the CON_ENABLED flag set. Since NBCON was introduced it's important to check if a given console also implements the [...] Content analysis details: (-2.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:434 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org All consoles found on for_each_console are registered, meaning that all of them have the CON_ENABLED flag set. Since NBCON was introduced it's important to check if a given console also implements the NBCON callbacks. The function console_is_usable does exactly that. Signed-off-by: Marcos Paulo de Souza Reviewed-by: Petr Mladek --- arch/um/kernel/kmsg_dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/um/kernel/kmsg_dump.c b/arch/um/kernel/kmsg_dump.c index 419021175272..fc0f543d1d8e 100644 --- a/arch/um/kernel/kmsg_dump.c +++ b/arch/um/kernel/kmsg_dump.c @@ -31,7 +31,7 @@ static void kmsg_dumper_stdout(struct kmsg_dumper *dumper, * expected to output the crash information. */ if (strcmp(con->name, "ttynull") != 0 && - (console_srcu_read_flags(con) & CON_ENABLED)) { + console_is_usable(con, console_srcu_read_flags(con), true)) { break; } } From patchwork Fri Nov 21 18:50:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcos Paulo de Souza X-Patchwork-Id: 2167802 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=temperror header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=1ekiw//1; dkim=pass (2048-bit key; unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=C1a6dNUt; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4dCknv5wrCz1yYw for ; Sat, 22 Nov 2025 05:51:15 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UFSdbuEHlkMgMI9LKgp25jd/vaPmbZhF8IKFWk4+qQQ=; b=1ekiw//1oYYWElYgDjH6mK0tZL f4tCioXtgW5RJeN+nOdAi2GlzwOUzWuPRW3bIat/Gk2pneLJ7rjGfYgDCQ+3mQPYQAelwPiE2uHq+ m8sT1cHOSZ84Z+dtbfU48YammtlxP7BThKJrw1WjYG80ltb3VaeffC+b0Xa4AuMjEI1UVHteqP5V7 /W+AvJ1MjJvsPALFeswe56omCGOY/AkGluOQhg0oVw2hq1HrHK82ptwgrRF4J4EdIgcI5azxASG8V ZUQvz9zdDefHWirCMCU5rUQt/e1VRXJtgnjyq5bjK4tYvqXejyJi1FF9DroTsc12XptsBMtKtT2J4 qknlUbsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vMWDy-00000008s7h-07IU; Fri, 21 Nov 2025 18:51:14 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vMWDv-00000008s6a-2JtN for linux-um@lists.infradead.org; Fri, 21 Nov 2025 18:51:12 +0000 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-42b3108f41fso1481255f8f.3 for ; Fri, 21 Nov 2025 10:51:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763751069; x=1764355869; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UFSdbuEHlkMgMI9LKgp25jd/vaPmbZhF8IKFWk4+qQQ=; b=C1a6dNUtV9UYsmAU/dF7wJQYXjnjoLQXj33YPgsbSwEOt+cecIevi2dzA8zbol3M9V i4vBUmA4Od9sSnoDHouO3aKyrqfgXaU8rONQ84W5yz56iaewhlgOINk+18EEUFF8CVx9 6IAXFijpn0uqYVnx4WZS4EZcOFIOp6VFzzMYnH5iiWg2+vV+UOy58Xqk2dIuCALnItXZ ZwfUEExygWXuIqGfwpzIe68ISRuSXl9mNgF47uVNpgpiGsjxjKPbVdS0JfsK8whujTWr ChJMuuyyLX2t9P84X5Pv2A6MgVJRiy30vCsbcfXwiY991YBxDjYyJhtJMhFM/0zxYw8W klKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763751069; x=1764355869; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=UFSdbuEHlkMgMI9LKgp25jd/vaPmbZhF8IKFWk4+qQQ=; b=U60Y2zwpCc10MatVKuLt2wqOf+BS0uAqazrTQCFACXQ80p2U7nHXe8zA2u3faRvWka /L4RQTJtB+SCBQpuKQmVk/l9VK33PbpQsDOpWBPnXcSaeQLDHM1apK1Fps657eQYPz3l p5lo1RkiF8zqq/UYDk2q1vAgi5ckJxh63GKhb2nOBQn1hF/ps5TGgHSxa9aqiOK6rXor 3V6+FRBzAijgD25rox5/O4JdN0d+7wsqTkqRzSElscleRgMkO4iMaN72tKFmZe9B84kL 5iQVylSfndxVDy/97T2poI6R2CZh6t+PTcCWMJpQUZFjfNu/0cp3OHndt8dMNWHXGLpH Liyg== X-Forwarded-Encrypted: i=1; AJvYcCVEzV14Aaj1RHLqlhLdYjwZJTXgtT80ADWfrYJ0ZI2ZnSwufuTT98fGvlYqtOpgvRbuPGkwBPREeg==@lists.infradead.org X-Gm-Message-State: AOJu0YzZSmclKMMneuamcizpRperoUsmWDNXfqHiislBmai+NS3N5VIy x2kJFPUsL8bpn1hf65GX7Nk2sbx8FM44wsIjiMeBXrpCEOcZW+IBQn4QI1tGdMzNCqs2dIu3kfO 029Dj9MM= X-Gm-Gg: ASbGnctKZcGdfAs5ITjX/urDFeiPSxSjzZfF7gZOR4vT7EwDhkEf9MA/oja++CUIRpk eM5CR0hItlf/HeGINWgktgZNu5mwOjrDXT3F+b3sIZAMp7/rOnlXQUZHW3khA1DHpVrrZ9YqNg/ PsnvZOI8nfSUN1YadgHIZYY4FvHOUQwREg3G+LCthMTwQmOsV35TWHk64TNDt1G0DLO6lTvJ1+F yod24dFZ8bKnYobleqCLhFXImO7KMxXEjk/mYsAKvAy0Noyq3vGhc0yuSwnCvvW/ib1MnU80Rf2 8FCd3lz3++IUyZ8BIPQsYdHxmNYhs9f/+eFMzntOdzHuBeuPGwBiKbj+UcEhfQODPy25x4BpjUj YfB8aYUdJ0Ps+AqlcMojmyiyZHGnhqFjaqrxnxplvRxhnTjvXzSaBKB/MIHcB1PC9fGCVAHIqfj ZKibSY1dMHQgFeQMApMRztQFdYeTbF0kyc2C0= X-Google-Smtp-Source: AGHT+IE3ueb1gfvZpdP1O8B6KsMhh0NreYclj90YAJqPRO3t3jMYj6PAYTHfKHARsU3VdjyGtVHkhA== X-Received: by 2002:a05:6000:601:b0:42b:4219:269 with SMTP id ffacd0b85a97d-42cc1d0cf4amr3499114f8f.41.1763751068837; Fri, 21 Nov 2025 10:51:08 -0800 (PST) Received: from [127.0.0.1] (99.36.160.45.gramnet.com.br. [45.160.36.99]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fd8baesm12473639f8f.39.2025.11.21.10.51.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 10:51:08 -0800 (PST) From: Marcos Paulo de Souza Date: Fri, 21 Nov 2025 15:50:35 -0300 Subject: [PATCH v2 3/4] printk: Use console_is_usable on console_unblank MIME-Version: 1.0 Message-Id: <20251121-printk-cleanup-part2-v2-3-57b8b78647f4@suse.com> References: <20251121-printk-cleanup-part2-v2-0-57b8b78647f4@suse.com> In-Reply-To: <20251121-printk-cleanup-part2-v2-0-57b8b78647f4@suse.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Jason Wessel , Daniel Thompson , Douglas Anderson , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-um@lists.infradead.org, Marcos Paulo de Souza X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1763751050; l=1461; i=mpdesouza@suse.com; s=20231031; h=from:subject:message-id; bh=NKFHmcfiCk2EwIkTHkKYjnx6rN1uKn1am+sBKF+oi8Q=; b=t+kTGkkizl6U6aR6PW2Gu87Sum27bEEzl8ibey1pJbKk6zu1jVjEcA/kU+oc6YLo7Px6+PkCp QGPAFvKM1ClA+rzBQGG0BnUK0kRud59IVkxx67TxhQX137mqpi913XJ X-Developer-Key: i=mpdesouza@suse.com; a=ed25519; pk=/Ni/TsKkr69EOmdZXkp1Q/BlzDonbOBRsfPa18ySIwU= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251121_105111_611385_0B390610 X-CRM114-Status: GOOD ( 10.05 ) X-Spam-Score: -2.1 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The macro for_each_console_srcu iterates over all registered consoles. It's implied that all registered consoles have CON_ENABLED flag set, making the check for the flag unnecessary. Call console_is_u [...] Content analysis details: (-2.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:436 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The macro for_each_console_srcu iterates over all registered consoles. It's implied that all registered consoles have CON_ENABLED flag set, making the check for the flag unnecessary. Call console_is_usable function to fully verify if the given console is usable before calling the ->unblank callback. Signed-off-by: Marcos Paulo de Souza Reviewed-by: Petr Mladek --- kernel/printk/printk.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index cb79d1d2e6e5..fed98a18e830 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -3374,12 +3374,10 @@ void console_unblank(void) */ cookie = console_srcu_read_lock(); for_each_console_srcu(c) { - short flags = console_srcu_read_flags(c); - - if (flags & CON_SUSPENDED) + if (!console_is_usable(c, console_srcu_read_flags(c), true)) continue; - if ((flags & CON_ENABLED) && c->unblank) { + if (c->unblank) { found_unblank = true; break; } @@ -3416,12 +3414,10 @@ void console_unblank(void) cookie = console_srcu_read_lock(); for_each_console_srcu(c) { - short flags = console_srcu_read_flags(c); - - if (flags & CON_SUSPENDED) + if (!console_is_usable(c, console_srcu_read_flags(c), true)) continue; - if ((flags & CON_ENABLED) && c->unblank) + if (c->unblank) c->unblank(); } console_srcu_read_unlock(cookie); From patchwork Fri Nov 21 18:50:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcos Paulo de Souza X-Patchwork-Id: 2167803 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=temperror header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=qWCIdsB+; dkim=pass (2048-bit key; unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=dmwoit4+; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4dCknz0SWGz1yDM for ; Sat, 22 Nov 2025 05:51:19 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zeiJZSVEGGN00WPtN6lgqyU6XWLEKHbZMZ9rjX+7HGY=; b=qWCIdsB+b0A5vjSR8Y5S8zlPGM NrBFJEQeu/LR5DYkRZTMMTirKCWhH8QN+Q9y4zywnAmA8JZT2JrmCEMJAiy/sGkHVacLLWnkxcjCZ 5JB7gy9UVF5hlgck0+/IrVMytj9vAHhwDsb4EYXUElbmTqvFeRV01nVeqYvXwI6zI9uZTGFqJ5/Au p79MeJR3eZ3FdMr4UaLhp2E+r5ZAz+MiXMqt/dGL1O3TQJNGWAlSsunIFhDlXc1WXYADyLN6N30BW BvI9BYZJHQfWTB8/N0nAgMFaDPR/cjAW0t8jvU8JBCOZjQacLSRCb30QJQ9u1mJV0Coh0u+Fo780+ FTYFqJTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vMWE1-00000008s9N-2Fqp; Fri, 21 Nov 2025 18:51:17 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vMWDz-00000008s83-1xt9 for linux-um@lists.infradead.org; Fri, 21 Nov 2025 18:51:16 +0000 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-42b3c965cc4so1296727f8f.0 for ; Fri, 21 Nov 2025 10:51:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763751073; x=1764355873; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=zeiJZSVEGGN00WPtN6lgqyU6XWLEKHbZMZ9rjX+7HGY=; b=dmwoit4+JS4lP7YwuRv7uKV4cpWzwQCr/Ap2G1RaW8I+G6sOyf1mjEmxIOwWqFRIJe bPs+lLjvtqIpzOLvieQ51hzV4dboaYgme1Vtzy1kqVELwBD11RaH6acjVYY1nULViJrB LP9+kQvwIOhYYkk79laPg2bkGHSywdLUU6CO/8zq8VoPzgABrPldgXqY5Q/MGN4CWcIR D0PCl3GUD4XBpEkJfeSFR9RlW0rVIPCX45dR2ZYTkXT2CThId3tZ1ZE6QMqGRzDPvAo+ Bp2+m0nTq4WZdkE62frFoObW5bMD5Kpk80CuGtlhtSsg9tuqW7FeXW4pg/nGE75wWOlI THIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763751073; x=1764355873; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=zeiJZSVEGGN00WPtN6lgqyU6XWLEKHbZMZ9rjX+7HGY=; b=NPGPr6ah+B4yjIB/6ZQ5QcOvM3Nu+l5eISUHr/5gMUrA4pLJrNqkHMzCNIdrIwXbNR /y/hchQ+wzzvwOs/4hMnuLgPYzrGo0+3Xj3Hv766JJZArtaLYxccbxhTt0Sx3Kbpr0hY +hkgJuaZoHSMVm6WAWKPn94w+us5xnguYtVz+AKFF6id0qdaD886uJ4kREvAdgp98s1I bFY2eBkDdwuRLYRWfu95fM7WS5sAFTLux+ZNIbzuDh++53ICyqRumjWZL2PF/QDMkk7j 8VK36XxkFQ9eIYhD6K2fkyxu6MgLJzABzm283smoBTBxhkBFyyEv4RqHwAawZ2SiGBnt mjFg== X-Forwarded-Encrypted: i=1; AJvYcCV+TUfKxB5s7abVQ1G5iHkSv+PsTHhTJHMU8ppgBy83d++AHAMLolq3cDaSoXOnqul2Db8/zRbsDA==@lists.infradead.org X-Gm-Message-State: AOJu0YxRojL4FFtv86rsJiCIyotwpfuBmSrvz7WxhoBl/idtAoREzRm8 SMsUfgzu08YOkLuoiIY9JlkYMXwNj6xUC6rRrtK3S6NDySR3kfhYauwo9oShEvTdLq+veNu76Sc 7p2n+IMc= X-Gm-Gg: ASbGnctr45SMdIhbFXgk8V5SaOkpwJvgEJuxhJmgyp82PXEWW/g/ClEGpwWpLYgTNLM Edj0E6RhL1JkdlRkrLNlRSUpH1/d3NFhrNa7t5kCB5L+JUFNxvzLeCwrLiEkshLYM21axJ7hMUx A5ieJi0etmFKV7S32rW8gePEo2V5K2KL8tha1JqsQlZUuKryootdFBQWhWOZo6dmIF8c4ou8MWg nUBbDMmeays7YHnzs6RDZyv3AYt4/aJQjJ8IKzlY7jUD6ReMedG3nyHYd/qN05aASJ4ct8i9XNE 8DrA1VPvammXtMzmBg5TCeya0VvvDNw9EBWNTQi9zArv8Fu3XmuTBMhCgIzBfoysVE60tdHkZZ0 pPGm5xPVLvUgOdimieiWqOhBHBQEVS2zELsLzyubUtAHfQlDEdfv3Yk/eOsK2gJb4IoP+yJCZcM /7JpRQjk9Gjc/CN6Dvmnad0sSup3Fk0x23k5s= X-Google-Smtp-Source: AGHT+IENN61/obhbDbsiWgswns0YOtLZMBMlnpiskqZW9+NCINqWoGwYz+8q1vTBc1WOclyJO+Metw== X-Received: by 2002:a05:6000:4210:b0:429:eb05:1c69 with SMTP id ffacd0b85a97d-42cba63b646mr8898226f8f.2.1763751073426; Fri, 21 Nov 2025 10:51:13 -0800 (PST) Received: from [127.0.0.1] (99.36.160.45.gramnet.com.br. [45.160.36.99]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fd8baesm12473639f8f.39.2025.11.21.10.51.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 10:51:13 -0800 (PST) From: Marcos Paulo de Souza Date: Fri, 21 Nov 2025 15:50:36 -0300 Subject: [PATCH v2 4/4] printk: Make console_{suspend,resume} handle CON_SUSPENDED MIME-Version: 1.0 Message-Id: <20251121-printk-cleanup-part2-v2-4-57b8b78647f4@suse.com> References: <20251121-printk-cleanup-part2-v2-0-57b8b78647f4@suse.com> In-Reply-To: <20251121-printk-cleanup-part2-v2-0-57b8b78647f4@suse.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Jason Wessel , Daniel Thompson , Douglas Anderson , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-um@lists.infradead.org, Marcos Paulo de Souza X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1763751050; l=1998; i=mpdesouza@suse.com; s=20231031; h=from:subject:message-id; bh=Me+FmgCVuipIeMGIOmW7VyWb0ioSCEd8yB49PjrkFbM=; b=1f1XQPksSyg2y3pXUnelAzKyzaedaVrzMjIzV4D5cPN+kduYUUNr7nIbIGu3SdlK+vY1dppDR WrcjcRwmPvCAZWS/IHHAlVNhq/wnrv4ph6Y5HplOAbeUOE6cjJPPdGD X-Developer-Key: i=mpdesouza@suse.com; a=ed25519; pk=/Ni/TsKkr69EOmdZXkp1Q/BlzDonbOBRsfPa18ySIwU= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251121_105115_526952_CCD61B19 X-CRM114-Status: GOOD ( 11.18 ) X-Spam-Score: -2.1 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Since commit 9e70a5e109a4 ("printk: Add per-console suspended state") the CON_SUSPENDED flag was introced, and this flag was being checked on console_is_usable function, which returns false if the con [...] Content analysis details: (-2.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:434 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since commit 9e70a5e109a4 ("printk: Add per-console suspended state") the CON_SUSPENDED flag was introced, and this flag was being checked on console_is_usable function, which returns false if the console is suspended. To make the behavior consistent, change show_cons_active to look for consoles that are not suspended, instead of checking CON_ENABLED. Signed-off-by: Marcos Paulo de Souza --- drivers/tty/tty_io.c | 2 +- kernel/printk/printk.c | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index e2d92cf70eb7..1b2ce0f36010 100644 --- a/drivers/tty/tty_io.c +++ b/drivers/tty/tty_io.c @@ -3554,7 +3554,7 @@ static ssize_t show_cons_active(struct device *dev, continue; if (!(c->flags & CON_NBCON) && !c->write) continue; - if ((c->flags & CON_ENABLED) == 0) + if (c->flags & CON_SUSPENDED) continue; cs[i++] = c; if (i >= ARRAY_SIZE(cs)) diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index fed98a18e830..fe7c956f73bd 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -3542,7 +3542,7 @@ void console_suspend(struct console *console) { __pr_flush(console, 1000, true); console_list_lock(); - console_srcu_write_flags(console, console->flags & ~CON_ENABLED); + console_srcu_write_flags(console, console->flags | CON_SUSPENDED); console_list_unlock(); /* @@ -3555,13 +3555,14 @@ void console_suspend(struct console *console) } EXPORT_SYMBOL(console_suspend); +/* Unset CON_SUSPENDED flag so the console can start printing again. */ void console_resume(struct console *console) { struct console_flush_type ft; bool is_nbcon; console_list_lock(); - console_srcu_write_flags(console, console->flags | CON_ENABLED); + console_srcu_write_flags(console, console->flags & ~CON_SUSPENDED); is_nbcon = console->flags & CON_NBCON; console_list_unlock();