From patchwork Thu Oct 9 09:21:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 2147523 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::133; helo=smtp2.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4cj4D35tHfz1yHF for ; Thu, 9 Oct 2025 20:22:59 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id F33DF40FAD; Thu, 9 Oct 2025 09:22:57 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id AQaTmY2BlHt7; Thu, 9 Oct 2025 09:22:57 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 037C340F98 Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id 037C340F98; Thu, 9 Oct 2025 09:22:57 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id E0A46C060E; Thu, 9 Oct 2025 09:22:56 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id A7676C060E for ; Thu, 9 Oct 2025 09:22:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 659CE40F8D for ; Thu, 9 Oct 2025 09:22:55 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id PvO2zCEZVs0C for ; Thu, 9 Oct 2025 09:22:54 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.221.68; helo=mail-wr1-f68.google.com; envelope-from=i.maximets.ovn@gmail.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 205EE4046A Authentication-Results: smtp2.osuosl.org; dmarc=none (p=none dis=none) header.from=ovn.org DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 205EE4046A Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by smtp2.osuosl.org (Postfix) with ESMTPS id 205EE4046A for ; Thu, 9 Oct 2025 09:22:53 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id ffacd0b85a97d-3ee1381b835so663083f8f.1 for ; Thu, 09 Oct 2025 02:22:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760001772; x=1760606572; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T6QBRybLT/fAEsWy1iVhJU2Vck/AOmK9lCVMgYGYZKA=; b=VeoUJhUhaSlIwJ8eAGR69Q39ZqzxqmfnMqC1NcfLeyShQvTHSZiiy8qs7Du+EBv8C9 LELGYiT8CzH+BKbnQC8ip8Z2mvy5R1SO6Cld/O+9wjKRvDSnRST9Vuon1fL0a2Se9qZK w4mEsD7BGzbPw7djdGcOAYohc7FQ8UVdjxOLhxoF5xY+gF6UOHeanIJbF5/Zw5QHusVA NT2CBtNiZftyK26ud4Yk7rGn6fWv9/0oGrNHAmUH/84HrqK9gtTCjRZBMTQvsx2euJ3F ZOYlf5PvSfSFtloQ5Dh/or8R8KgTbqDvJmLFnjUcb4qUhX/2xIrAbs6sAGG4c2SMCeWQ RSxg== X-Gm-Message-State: AOJu0YxOIm96wL7oHwOKncuZ2/iZV62ti5QyMFshWXrRWvmHcZz0TOeh U56CdZYGMPCnh68F4djKXnhJzlXKK20TrMuEU9ZS9Vg1IpmwO5V09h1TMDceSfqx X-Gm-Gg: ASbGncsorGI+e/HR2HeLUg2sxJJTuIXERNTxP0xZJXgq5xs1595rr2LgXsGZW52bSGt aexRBuC8+LE3XJ35zEgc49gzAjE7/v1wbD8F5acjOTt3k2Fig45MYdiCFlzHc48vkO1H/ER8lvq W7IxYnspPJyUhG853aAUk/HZuAf0zF9AXu5ibmm0QNA/8GeWBDfVwYV5VPQZyHJV4QKfbFIFkxa IArIYn76fLRfRqlSfjuO3jwQ7oCRSmZ7shFAziUDG4I8MWL85Iak/6FwulfjzYCNuW/QoSSomUN FkoZ3fRDCb+jZ6wtN+XVuQAuS8qndIRa4jNBh387UkGsRTVYUv+UxWHGzEIXlFu/JID21RZrNqU LMpOVZjgfRFCGlOWOM/SainWIKRSEIKcPtxWRdF5tnJNopjZ4gKjQw8WO9nYrEcBF/nuUA5s+Va XuSPS4KD5HZ+E= X-Google-Smtp-Source: AGHT+IHcaJk6CqHzHNEKdsliROU9JjBFjW6Y/M+7ojRGc1XnPyxPio/dzyToji7w/npYG/OuaXSUhA== X-Received: by 2002:a05:6000:2203:b0:425:57dd:58c4 with SMTP id ffacd0b85a97d-4266e7d7eb1mr4524086f8f.26.1760001771830; Thu, 09 Oct 2025 02:22:51 -0700 (PDT) Received: from im-t490s.redhat.com (37-48-48-237.nat.epc.tmcz.cz. [37.48.48.237]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4255d8f0392sm34313629f8f.42.2025.10.09.02.22.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Oct 2025 02:22:51 -0700 (PDT) From: Ilya Maximets To: ovs-dev@openvswitch.org Cc: Ilya Maximets Date: Thu, 9 Oct 2025 11:21:21 +0200 Message-ID: <20251009092228.382349-2-i.maximets@ovn.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251009092228.382349-1-i.maximets@ovn.org> References: <20251009092228.382349-1-i.maximets@ovn.org> MIME-Version: 1.0 Subject: [ovs-dev] [PATCH 1/6] m4: Don't add -mno-avx512f if compiler doesn't support it. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" When building using an older compiler that doesn't support avx512, we are adding '-mno-avx512f' into the command line, which results with a build failure: gcc: error: unrecognized command line option '-mno-avx512f' This is a case, for example, while trying to build OVS with GCC 4.8. Fix that by avoiding binutils check when compiler doesn't understand -mavx512f. Later in the call chain there is also an explicit check for -mavx512f support, but it will just use the cached result, so it's not a problem. Fixes: 930f135f5ddc ("configure: explicitly disable avx512 if bintuils check fails") Signed-off-by: Ilya Maximets Acked-by: Kevin Traynor Acked-by: Eelco Chaudron --- m4/openvswitch.m4 | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/m4/openvswitch.m4 b/m4/openvswitch.m4 index 6d41ffc44..060070475 100644 --- a/m4/openvswitch.m4 +++ b/m4/openvswitch.m4 @@ -475,7 +475,9 @@ dnl The checking of binutils funcationality instead of LD version is similar dnl to as how DPDK proposes to solve this issue: dnl http://patches.dpdk.org/patch/71723/ AC_DEFUN([OVS_CHECK_BINUTILS_AVX512], - [AC_CACHE_CHECK( + [OVS_CHECK_CC_OPTION( + [-mavx512f], + [AC_CACHE_CHECK( [binutils avx512 assembler checks passing], [ovs_cv_binutils_avx512_good], [dnl Assemble a short snippet to test for issue in "build-aux" dir: @@ -496,7 +498,8 @@ AC_DEFUN([OVS_CHECK_BINUTILS_AVX512], else dnl non x86_64 architectures don't have avx512, so not affected ovs_cv_binutils_avx512_good=no - fi]) + fi])], + [ovs_cv_binutils_avx512_good=no]) if test "$ovs_cv_binutils_avx512_good" = yes; then AC_DEFINE([HAVE_LD_AVX512_GOOD], [1], [Define to 1 if binutils correctly supports AVX512.]) From patchwork Thu Oct 9 09:21:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 2147524 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4cj4D56H5Gz1y1V for ; Thu, 9 Oct 2025 20:23:01 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 6E7D740FB1; Thu, 9 Oct 2025 09:23:00 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id dsmqjRl6fjOd; Thu, 9 Oct 2025 09:22:59 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org BC2FC40FA3 Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id BC2FC40FA3; Thu, 9 Oct 2025 09:22:58 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A224CC060E; Thu, 9 Oct 2025 09:22:58 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2FB6BC060E for ; Thu, 9 Oct 2025 09:22:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 20652611BF for ; Thu, 9 Oct 2025 09:22:57 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id dOCGDoeLD_y9 for ; Thu, 9 Oct 2025 09:22:56 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.221.65; helo=mail-wr1-f65.google.com; envelope-from=i.maximets.ovn@gmail.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org EA1F8611B8 Authentication-Results: smtp3.osuosl.org; dmarc=none (p=none dis=none) header.from=ovn.org DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org EA1F8611B8 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by smtp3.osuosl.org (Postfix) with ESMTPS id EA1F8611B8 for ; Thu, 9 Oct 2025 09:22:55 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id ffacd0b85a97d-3ee12a63af1so446581f8f.1 for ; Thu, 09 Oct 2025 02:22:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760001774; x=1760606574; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P4PAA7sRu7CCMCztvy9RTfPPlxWYUTvM3ZztNpfkIDc=; b=sijHXirpNhC2eIE75ShmwD9tolUVQckZz5wsWkZDSyd8qfcGmtqAR/ieRMsGbzHgNg v/FpyiR7cLq+MvW/jfz0zI752sbaNI4/+vBVRsN05r7tW9SvoYKDFFsrPp3g/EgmUiiQ 7SYKvSQ5Qebh253ZUPQnmgaevczFqB8gqQwrhGcg+FiK5Rc8MMoE5bO634gMwVjS+DQf Kn8MI2KunM9fPKTTIAZVKTMT10u5ovJv/04htoxKMKXtZUv3AB7Yrb38jRocFc4FBtlb 6F9lBUkHhEhic7dZs9vbXeueXnXX1l0YtY/k62sMYb9PEgzN4gsoYdn98sb9fAB7yuSI +NhQ== X-Gm-Message-State: AOJu0YwcrCQf+qex8qFXUVz4K+IFMGcRxetmo2H1MPcd5A+lhMOZVyeK sBViq2x4PWG0r5k1132gQTcimd+eXKsiDPJ6g169/GHb6YB/1ehk5CbNibOewhJN X-Gm-Gg: ASbGncv/tiAwWcDcfF9juglzpgv+6m03IIsHhZ/KrMGnB8e0GOJY3QbT1ichsBEeV5x F4yZqWimiN2zvt2YSSfOYCRk8Xg6d2I2UnzjQPDkOb85qz5zhrFMe6IYfWxNtnf6BMb/bu4QY4Q 6izHokDzoo7YW5iq3DrAewRn7yluRn7zWhOC6ojo6llpd78J2/mqNJn1gJOMvOOEt92exe2ARO8 bgrn1rogHFD5h8fXUY+Lj3Ri1b2bkocZLXNgDXjIk26+5+j3/WYXICl7ArfztUyah9ssEE0Oc7U zxpdYX0N9+bs3MkMJGUWln29cFKy4nKJHv3XJR53Vzxl8qBhw1kzfGCj0NGbR44zb4ui1P55tCq YL51/y0tM7S1dTIBYPdsRkKjo2MsltNxIPJf5lEv1XopbVgo0iwX4G0yuyU7XPcsVduNfyhHNAZ MHn6x8/DASW/Y= X-Google-Smtp-Source: AGHT+IFqn6+Gd1e4vCtlDxdO8CstXcn8zGLdWjYtmja976Xfa3NpV7sA/Qtp2ZKPyKww55IPkJE2pw== X-Received: by 2002:a05:6000:2c0e:b0:3ec:de3c:c56 with SMTP id ffacd0b85a97d-42667177c79mr4437759f8f.16.1760001773641; Thu, 09 Oct 2025 02:22:53 -0700 (PDT) Received: from im-t490s.redhat.com (37-48-48-237.nat.epc.tmcz.cz. [37.48.48.237]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4255d8f0392sm34313629f8f.42.2025.10.09.02.22.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Oct 2025 02:22:53 -0700 (PDT) From: Ilya Maximets To: ovs-dev@openvswitch.org Date: Thu, 9 Oct 2025 11:21:22 +0200 Message-ID: <20251009092228.382349-3-i.maximets@ovn.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251009092228.382349-1-i.maximets@ovn.org> References: <20251009092228.382349-1-i.maximets@ovn.org> MIME-Version: 1.0 Subject: [ovs-dev] [PATCH 2/6] netlink: Fix build on kernels < 4.1 due to missing RTA_VIA. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ilya Maximets Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Current code assumes that if the rtnetlink.h exists, then it must have definitions for RTA_VIA and 'struct rtvia'. This is causing build failures on older systems: lib/netlink.c: In function 'min_attr_len': lib/netlink.c:832:38: error: invalid application of 'sizeof' to incomplete type 'struct rtvia' case NL_A_RTA_VIA: return sizeof(struct rtvia) + sizeof(struct in_addr); ^ The code structure overall is not great, we should not include Linux specific headers in the common netlink.c. The only reason for the inclusion though is the structure size. We can just put a number instead, as it is already done for all other types. It should never change, as long as kernel uAPI is stable. Structure and the RTA_VIA should be defined in the Linux-specific route-table.c, in case rtnetlink.h doesn't have a definition for them. Fixes: 9d9a99d157f2 ("route-table: Support parsing RTA_VIA attribute.") Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2025-September/053800.html Reported-by: Brendan Doyle Signed-off-by: Ilya Maximets Acked-by: Kevin Traynor Acked-by: Eelco Chaudron --- acinclude.m4 | 7 +++++++ lib/netlink.c | 14 ++------------ lib/route-table.c | 9 +++++++++ 3 files changed, 18 insertions(+), 12 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index 8658bcfcb..369e37eae 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -155,6 +155,13 @@ AC_DEFUN([OVS_CHECK_LINUX_NETLINK], [ ])], [AC_DEFINE([HAVE_NLA_BITFIELD32], [1], [Define to 1 if struct nla_bitfield32 is available.])]) + + AC_COMPILE_IFELSE([ + AC_LANG_PROGRAM([#include ], [ + struct rtvia x = { 0 }; + ])], + [AC_DEFINE([HAVE_RTA_VIA], [1], + [Define to 1 if struct rtvia is available.])]) ]) dnl OVS_CHECK_LINUX_TC diff --git a/lib/netlink.c b/lib/netlink.c index 446a0679e..fbfc20e7c 100644 --- a/lib/netlink.c +++ b/lib/netlink.c @@ -29,16 +29,6 @@ #include "openvswitch/vlog.h" #include "util.h" -#ifdef HAVE_NETLINK -#include -#else -/* RTA_VIA */ -struct rtvia { - sa_family_t rtvia_family; - uint8_t rtvia_addr[]; -}; -#endif - VLOG_DEFINE_THIS_MODULE(netlink); /* A single (bad) Netlink message can in theory dump out many, many log @@ -829,7 +819,7 @@ min_attr_len(enum nl_attr_type type) case NL_A_IPV6: return 16; case NL_A_NESTED: return 0; case NL_A_LL_ADDR: return 6; /* ETH_ALEN */ - case NL_A_RTA_VIA: return sizeof(struct rtvia) + sizeof(struct in_addr); + case NL_A_RTA_VIA: return 2 + 4; /* struct rtvia + struct in_addr. */ case N_NL_ATTR_TYPES: default: OVS_NOT_REACHED(); } } @@ -851,7 +841,7 @@ max_attr_len(enum nl_attr_type type) case NL_A_IPV6: return 16; case NL_A_NESTED: return SIZE_MAX; case NL_A_LL_ADDR: return 20; /* INFINIBAND_ALEN */ - case NL_A_RTA_VIA: return sizeof(struct rtvia) + sizeof(struct in6_addr); + case NL_A_RTA_VIA: return 2 + 16; /* struct rtvia + struct in6_addr. */ case N_NL_ATTR_TYPES: default: OVS_NOT_REACHED(); } } diff --git a/lib/route-table.c b/lib/route-table.c index 2bbb51c08..ca87ff7db 100644 --- a/lib/route-table.c +++ b/lib/route-table.c @@ -44,6 +44,15 @@ * old headers. (We can't test for it with #ifdef because it's an enum.) */ #define RTA_MARK 16 +/* Linux 4.1 added RTA_VIA. */ +#ifndef HAVE_RTA_VIA +#define RTA_VIA 18 +struct rtvia { + sa_family_t rtvia_family; + uint8_t rtvia_addr[]; +}; +#endif + VLOG_DEFINE_THIS_MODULE(route_table); COVERAGE_DEFINE(route_table_dump); From patchwork Thu Oct 9 09:21:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 2147525 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.136; helo=smtp3.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4cj4D85HNyz1y1V for ; Thu, 9 Oct 2025 20:23:04 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 0F9AE611FC; Thu, 9 Oct 2025 09:23:03 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id JJWR_pfIaW65; Thu, 9 Oct 2025 09:23:01 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.9.56; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org B4BCD611EF Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id B4BCD611EF; Thu, 9 Oct 2025 09:23:01 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A4207C060E; Thu, 9 Oct 2025 09:23:01 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id DE7A8C060D for ; Thu, 9 Oct 2025 09:22:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id C091D83BDC for ; Thu, 9 Oct 2025 09:22:58 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id uxrASaF_hpR9 for ; Thu, 9 Oct 2025 09:22:57 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.221.65; helo=mail-wr1-f65.google.com; envelope-from=i.maximets.ovn@gmail.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 84B6483BCB Authentication-Results: smtp1.osuosl.org; dmarc=none (p=none dis=none) header.from=ovn.org DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 84B6483BCB Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by smtp1.osuosl.org (Postfix) with ESMTPS id 84B6483BCB for ; Thu, 9 Oct 2025 09:22:57 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id ffacd0b85a97d-42420c7de22so358851f8f.1 for ; Thu, 09 Oct 2025 02:22:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760001775; x=1760606575; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jGsvktoE/BEeBpPf5eQC/quHTZdtcwU9GnfB7uD00rs=; b=C0enZ6XX0hEN34OLPPEbRxOV11LGK981L9jnPs7UOIQZh0mw+Kb/QoF4uEDTSDRfTy LLWu35qctDprSzVjCL7ORbkQQpu3aEu60cnfaw/8/1CmRm1RAkc2B0HXvvArqdR0rAXx 5iysVNNUq6t1pKc3RxVQVSeFzW9P67iXRKlaxfA72n8NeP2DusBbbIzUJKfM/XXhM6JM zzZ9phI0yudRR4NbCjdzvjnEytjLZ86XpgHLChNIC5Qkw2wrFWebNOTlp552wDPHKo2R OT2qgktyg/RkvC34TZlWB4q124xPXFWC/jKRZok7Utb7Sgd/CCNZn/G6N9HwTKYFYxpD 155A== X-Gm-Message-State: AOJu0Yx9rhZn1URksLeRJ+4uOOkNZG15opvUaVyogNriRiiTQmACorP9 KrN2iWbMkyBr9OWhf64gOygI2s9ols9PFd/Alf4k7UZSoSjeH9Ku9VIvij/tQndp X-Gm-Gg: ASbGncuvaFxxqRhmm9Y+VFLggXX3hAZGAH17UKGeU14nlDED+G18Za/7w/dT9qhqLtc 1S/YdEFhaDRyGfO55F+2h94K7V46up+Mhx9hTmrgoKVM2aKziCDSEp8UyknSHfqVyRDtMvqYtbE MIuxVq0gVriHmhcpT1tuYAuqOPM6wSBzD2OVQ1u7NQwtgwk+pVQWyLdHXPve9+vbP+oz77Mo2JG 0HjqGukifrtIpW+DiNJAuo3z9WiXLuVVTNGqDU/8dFOAbMLlqcwXcvuMCvep+guhMvWZ06C94U0 b7PQu4eeroRcnDXckQpYKnmD0Op5kBXJjHDMeeCr/WLEVgKMmw7z002mQw9K5NdlmQFcXNNuvZ3 WI8gBjionk2yTtvAUFygH8yoQ55OcWTHaloQcJgTYqFyKI3A6nzaO0yoWvbIfATVYw3G9xBC3zy 4wLEYwODuHbO4= X-Google-Smtp-Source: AGHT+IH9Qo7qeqzoR5F+TiEi6I0QWr2/dYHZSuAoCyYuLPZh/9D0s3Y7dAZeM69WGKciLfuzyrvggA== X-Received: by 2002:a05:6000:4382:b0:424:21d8:de30 with SMTP id ffacd0b85a97d-4266e8e90eamr4404760f8f.62.1760001775324; Thu, 09 Oct 2025 02:22:55 -0700 (PDT) Received: from im-t490s.redhat.com (37-48-48-237.nat.epc.tmcz.cz. [37.48.48.237]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4255d8f0392sm34313629f8f.42.2025.10.09.02.22.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Oct 2025 02:22:55 -0700 (PDT) From: Ilya Maximets To: ovs-dev@openvswitch.org Cc: Ilya Maximets Date: Thu, 9 Oct 2025 11:21:23 +0200 Message-ID: <20251009092228.382349-4-i.maximets@ovn.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251009092228.382349-1-i.maximets@ovn.org> References: <20251009092228.382349-1-i.maximets@ovn.org> MIME-Version: 1.0 Subject: [ovs-dev] [PATCH 3/6] test-lib-route-table: Add missing RTPROT_BGP definition. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" RTPROT_BGP was added in Linux v4.18. We should define it if it's not available, otherwise build fails on older kernels. Fixes: 91fc51106cfe ("route-table: Support parsing multipath routes.") Signed-off-by: Ilya Maximets Acked-by: Kevin Traynor Acked-by: Eelco Chaudron --- tests/test-lib-route-table.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/test-lib-route-table.c b/tests/test-lib-route-table.c index 4d4fbe0d3..4ba17826e 100644 --- a/tests/test-lib-route-table.c +++ b/tests/test-lib-route-table.c @@ -33,6 +33,11 @@ #define RTPROT_OVN 84 #endif +/* Definition was added in Linux v4.18. */ +#ifndef RTPROT_BGP +#define RTPROT_BGP 186 +#endif + static char * rt_prot_name(unsigned char p) { From patchwork Thu Oct 9 09:21:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 2147526 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4cj4DL4qKkz1y1V for ; Thu, 9 Oct 2025 20:23:14 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 447F083C0A; Thu, 9 Oct 2025 09:23:13 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id i6aYPpdzvF58; Thu, 9 Oct 2025 09:23:10 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.9.56; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org A18E083BE0 Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id A18E083BE0; Thu, 9 Oct 2025 09:23:10 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 702E3C060E; Thu, 9 Oct 2025 09:23:10 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 15F63C060E for ; Thu, 9 Oct 2025 09:23:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id D1CFE40FE0 for ; Thu, 9 Oct 2025 09:23:00 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 875QwC0yDwwS for ; Thu, 9 Oct 2025 09:22:59 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.128.66; helo=mail-wm1-f66.google.com; envelope-from=i.maximets.ovn@gmail.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 73CC940FCD Authentication-Results: smtp2.osuosl.org; dmarc=none (p=none dis=none) header.from=ovn.org DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 73CC940FCD Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by smtp2.osuosl.org (Postfix) with ESMTPS id 73CC940FCD for ; Thu, 9 Oct 2025 09:22:59 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id 5b1f17b1804b1-46e48d6b95fso6506755e9.3 for ; Thu, 09 Oct 2025 02:22:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760001777; x=1760606577; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7DMjpEAp5BfDQ3o6NfPAPW9eepzmsHyWqC8boWZ8GdI=; b=SbHtF3QzDuVgg5y4GzJ6TYItjt508+qwAERxOx1ElUo5kdDuWLFyqBCA3kxyqf9lot rXPOa4LxgjeJjpTSZmT4hsaVzKnK/U4m8ICBkjCKZDXO/FZt6QBLbna3nNnPVPQeTn1g L7LHML38JbMUR6SfG31QI1BOKY4Ms6aU1xH2dA+X3OBb7L9D2WpI/vOUWmxR0/1L/KTG k8LXrRLKiL9lZkq8lzfJIL5TXeiPHRApP6Lc9EGGmUfe6jK5qtwHPYB+TelcKz6FAuZV xbWRHK2FiNscEkY23RZ3M5OOF4C9VFYw3m3UMzWcWmV1f8ZR/plI50ZrdWE+/Dp6Nqwn ZtcA== X-Gm-Message-State: AOJu0Yx0Qkm439OsMjNh1+ZQdhluoyVtQIm2Tn04Bz9Kj7vFgmfDNtCu E6q11yRKSS1g/Qx/jmdFjcojY4nPu9XRI4/Te4tnnS1e5QAgZuAomCSQUlN9mT22 X-Gm-Gg: ASbGnct2vxB26zf1rR8tXDBBqXe78dgMZ1BYDKrxxuM2rhDkeA0lCQtF8fOmI10j1Q5 6Go3iKzCV0Q35hifSiJP6CJLwOIVDMqgeGM5pYR51evKWpCE2RBqxtqQSR+86X/mPOnGMC8qd3G b43Z4I1rleRQI0Zm5UcjtGumzRHkBmaU1K5qzZyl+tLrYmvnzndqsFeSrUWUTZ3c4FuRZxBG3eB s/j/JbQxRIzghKCZRzJiVhO48pjp/lJtHon6kEZiDt2nJ2ghbN2lxu1CpKxIbsDM560ncBrLopa VoKMuW/ITaXwF3dMUrAI7C1iCLqfMBvkQ15IPtXRbgbDGMye/czPIXkRXjUxsRJFHExbJxCYSL4 5y6/WiB++lc1fVIa09ZXnRbK2BNmGloqkb4nITGnAqlRhUJ/g1pzFhfjet72miSwYyrIM5SCVWI ahDpha8gwwjkA= X-Google-Smtp-Source: AGHT+IGdbeM6GqDJ60ktJsUWfL/UfgwBljeok0Sksb6IiYm2mCysT0MGsLDQ/OWjPhPebMrAQIQzKA== X-Received: by 2002:a05:600c:64c4:b0:45d:d68c:2a36 with SMTP id 5b1f17b1804b1-46fa9b079camr45746745e9.27.1760001777287; Thu, 09 Oct 2025 02:22:57 -0700 (PDT) Received: from im-t490s.redhat.com (37-48-48-237.nat.epc.tmcz.cz. [37.48.48.237]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4255d8f0392sm34313629f8f.42.2025.10.09.02.22.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Oct 2025 02:22:56 -0700 (PDT) From: Ilya Maximets To: ovs-dev@openvswitch.org Cc: Ilya Maximets Date: Thu, 9 Oct 2025 11:21:24 +0200 Message-ID: <20251009092228.382349-5-i.maximets@ovn.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251009092228.382349-1-i.maximets@ovn.org> References: <20251009092228.382349-1-i.maximets@ovn.org> MIME-Version: 1.0 Subject: [ovs-dev] [PATCH 4/6] test-netlink-policy: Fix missing field initializer warnings on older GCC. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" For some reason GCC 4.8 doesn't like this style of initialization, complaining that nla_type is missing in the initializer: tests/test-netlink-policy.c: In function 'test_nl_policy_parse_ll_addr': tests/test-netlink-policy.c:60:9: error: missing initializer for field 'nla_type' of 'struct nlattr' [-Werror=missing-field-initializers] .nlattr.nla_type = TEST_POLICY_ATTR, ^ Let's use a normal designated initializer for the nested structure to avoid this issue. Fixes: 2f2ae5b6bdef ("tests: Fix endianness in netlink policy test fixtures.") Signed-off-by: Ilya Maximets Acked-by: Kevin Traynor Acked-by: Eelco Chaudron --- tests/test-netlink-policy.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/tests/test-netlink-policy.c b/tests/test-netlink-policy.c index 55083935a..fee65fc30 100644 --- a/tests/test-netlink-policy.c +++ b/tests/test-netlink-policy.c @@ -48,35 +48,30 @@ test_nl_policy_parse_ll_addr(struct ovs_cmdl_context *ctx OVS_UNUSED) { struct nlattr *attrs[ARRAY_SIZE(policy)]; struct nlattr_fixture fixture_nl_data_policy_short = { /* too short according to policy */ - .nlattr.nla_len = 5, - .nlattr.nla_type = TEST_POLICY_ATTR, + .nlattr = { .nla_len = 5, .nla_type = TEST_POLICY_ATTR }, .data = { 0x00 }, }; struct nlattr_fixture fixture_nl_data_policy_long = { /* too long according to policy */ - .nlattr.nla_len = 25, - .nlattr.nla_type = TEST_POLICY_ATTR, + .nlattr = { .nla_len = 25, .nla_type = TEST_POLICY_ATTR }, .data = { 0x00, 0x00, 0x67, 0xfe, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xe4, 0x1d, 0x2d, 0x03, 0x00, 0xa5, 0xf0, 0x2f, 0x00, 0x00 }, }; struct nlattr_fixture fixture_nl_data_eth = { /* valid policy and eth_addr length */ - .nlattr.nla_len = 10, - .nlattr.nla_type = TEST_POLICY_ATTR, + .nlattr = { .nla_len = 10, .nla_type = TEST_POLICY_ATTR }, .data = { 0x00, 0x53, 0x00, 0x00, 0x00, 0x2a }, }; struct nlattr_fixture fixture_nl_data_ib = { /* valid policy and ib_addr length */ - .nlattr.nla_len = 24, - .nlattr.nla_type = TEST_POLICY_ATTR, + .nlattr = { .nla_len = 24, .nla_type = TEST_POLICY_ATTR }, .data = { 0x00, 0x00, 0x00, 0x67, 0xfe, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xe4, 0x1d, 0x2d, 0x03, 0x00, 0xa5, 0xf0, 0x2f }, }; struct nlattr_fixture fixture_nl_data_invalid = { /* valid policy but data neither eth_addr nor ib_addr */ - .nlattr.nla_len = 11, - .nlattr.nla_type = TEST_POLICY_ATTR, + .nlattr = { .nla_len = 11, .nla_type = TEST_POLICY_ATTR }, .data = { 0x00, 0x53, 0x00, 0x00, 0x00, 0x2a, 0x00 }, }; struct ofpbuf *buf; From patchwork Thu Oct 9 09:21:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 2147527 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=smtp4.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4cj4DT4hzBz1y1V for ; Thu, 9 Oct 2025 20:23:21 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id D62B941012; Thu, 9 Oct 2025 09:23:19 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id qZaquvxzNcPZ; Thu, 9 Oct 2025 09:23:19 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.9.56; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org DC18B40F6A Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id DC18B40F6A; Thu, 9 Oct 2025 09:23:18 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id C631FC060E; Thu, 9 Oct 2025 09:23:18 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0CE9EC060D for ; Thu, 9 Oct 2025 09:23:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id CFADA611FA for ; Thu, 9 Oct 2025 09:23:02 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id m6mog-Quiw4b for ; Thu, 9 Oct 2025 09:23:01 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.128.66; helo=mail-wm1-f66.google.com; envelope-from=i.maximets.ovn@gmail.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 9A317611B2 Authentication-Results: smtp3.osuosl.org; dmarc=none (p=none dis=none) header.from=ovn.org DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 9A317611B2 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by smtp3.osuosl.org (Postfix) with ESMTPS id 9A317611B2 for ; Thu, 9 Oct 2025 09:23:01 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id 5b1f17b1804b1-46e491a5b96so3760405e9.2 for ; Thu, 09 Oct 2025 02:23:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760001779; x=1760606579; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iCfHejauwcFM7Mtwbxyg68Iopr8kT9rc72fqziOxDxA=; b=l5+YqbnNMGl7s3X+8snVhW+Px5xQgUFe/7KaXvWpIXGG0dtSY9lgzU6rj90XBzVuss Y//cWSrXh5Zl22/USnPKSpUNi4ahSpduKyxlws2PbEvie/1eq2MMwv3ciyuFLPdqDY/N t9ZrEriQ+UBQ7VgLflP/fOBZUwI6dTp0/2H9N7J9vRfftsQHD4bvwIRv+//QcxHb9TID oUZaxLHwMMxrHBA61N/ks2aIb4Yco1cr4WjkPR0BzGIFMEhLfC+PMsWqEL4cpNd38zez srSakpcT78KOQKGlXDhOXB9NJrD/GwOMQ/MseMysqyiF+9IKSXwwaLETE1atthxv4Z7s 8Gpw== X-Gm-Message-State: AOJu0Yy4kRXslZFcNd1VixhcJUezs2czNx8xSqdD6gwkv09cFhBFERmS AnJnTZfjaoXMFIip+HLuksiXIpg12UHcqD6I/mAKnNVv+W+PAKdTk7OylnXo9fRJ X-Gm-Gg: ASbGncuyfyTiPe3M3SLUwbrGtOFRjiHrFR918x48fb4X2Qy56yJgPIVH/tlsi3GNSFY hdtmba/HYXtdgHY5aVnHHUCFcVanNOMxb87vfYmxzGqClgSukgKFTCV1uz/edMUc8JIAKdf2Lwm 9Kr4Mur9aH2b7iNqIP9I86FI1mQBxlhw6YKv2GILSKBBqxSyzVic87vlLE/C4+ytGJaneAv5gBz h5ilzxvyvQg+KrTpO6iWlO0vO/eedVI3qSnKRtLgXpUnND/C2ci3ZQJXd0nUH9oBaz9K0FybhAh CXT9lE5P2jhjzyUVA8yhiLOkoUxNKzzEhsC8XySf+kKXRSzWkm7ByYYKkngBUGjqGELOqN7s/PB SXwDLwgbghYHaeGpQ501kUzW+5HWxbCAzS/iBze+eqd/T9K1+ZD6jqLikkz3DyUCFYSnGuM1kFL PF8OICrI1J50euGMs26LXvzw== X-Google-Smtp-Source: AGHT+IFd4oKsAoGYPpGqayJ2TSqLpcQiwpcda+7iVrS1tqCsn1ftyStfNC2X8yFBzMJLd8v8bUAccg== X-Received: by 2002:a05:600c:1395:b0:46e:1cc6:25f7 with SMTP id 5b1f17b1804b1-46fa9aa045dmr48397935e9.9.1760001779301; Thu, 09 Oct 2025 02:22:59 -0700 (PDT) Received: from im-t490s.redhat.com (37-48-48-237.nat.epc.tmcz.cz. [37.48.48.237]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4255d8f0392sm34313629f8f.42.2025.10.09.02.22.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Oct 2025 02:22:58 -0700 (PDT) From: Ilya Maximets To: ovs-dev@openvswitch.org Cc: Ilya Maximets Date: Thu, 9 Oct 2025 11:21:25 +0200 Message-ID: <20251009092228.382349-6-i.maximets@ovn.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251009092228.382349-1-i.maximets@ovn.org> References: <20251009092228.382349-1-i.maximets@ovn.org> MIME-Version: 1.0 Subject: [ovs-dev] [PATCH 5/6] test-psample: Fix missing field initializer warnings on older GCC. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" GCC 4.8 complains for some reason: tests/test-psample.c: In function 'run': tests/test-psample.c:217:12: error: missing initializer for field 'packet' of 'struct sample' [-Werror=missing-field-initializers] struct sample sample = {}; ^ While it is a little strange to complain, the {} initializer is a C++ thing and a GNU extension, so we should not be using it. It's only available in C23 standard. Also, the initialization is not even necessary here, all the fields will be initialized later with sample_clear(), as long as it covers all the fields (rate was missing). Fixes: 742de01a4a2e ("tests: Add test-psample testing utility.") Signed-off-by: Ilya Maximets Acked-by: Kevin Traynor Acked-by: Eelco Chaudron --- tests/test-psample.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/test-psample.c b/tests/test-psample.c index 1494dcc8d..9eaa11b00 100644 --- a/tests/test-psample.c +++ b/tests/test-psample.c @@ -160,6 +160,7 @@ static inline void sample_clear(struct sample *sample) { sample->group_id = 0; + sample->rate = 0; sample->obs_domain_id = 0; sample->obs_point_id = 0; sample->has_cookie = false; @@ -214,7 +215,7 @@ parse_psample(struct ofpbuf *buf, struct sample *sample) static void run(struct nl_sock *sock) { static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(10, 10); - struct sample sample = {}; + struct sample sample; int error; dp_packet_init(&sample.packet, 1500); From patchwork Thu Oct 9 09:21:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 2147528 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4cj4Dj6bM1z1y1V for ; Thu, 9 Oct 2025 20:23:33 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 81D47612A5; Thu, 9 Oct 2025 09:23:32 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id tDUS1X2Lex7O; Thu, 9 Oct 2025 09:23:31 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.9.56; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 9B2856121C Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 9B2856121C; Thu, 9 Oct 2025 09:23:31 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8F2C1C060E; Thu, 9 Oct 2025 09:23:31 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 05865C060D for ; Thu, 9 Oct 2025 09:23:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id F35456121A for ; Thu, 9 Oct 2025 09:23:04 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id yVSjyA7RfMDu for ; Thu, 9 Oct 2025 09:23:03 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.221.66; helo=mail-wr1-f66.google.com; envelope-from=i.maximets.ovn@gmail.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 6AB4B611D6 Authentication-Results: smtp3.osuosl.org; dmarc=none (p=none dis=none) header.from=ovn.org DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 6AB4B611D6 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by smtp3.osuosl.org (Postfix) with ESMTPS id 6AB4B611D6 for ; Thu, 9 Oct 2025 09:23:03 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id ffacd0b85a97d-3f99ac9acc4so640058f8f.3 for ; Thu, 09 Oct 2025 02:23:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760001781; x=1760606581; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YGuHu6Y2oFA//mcAgArAs5M1wIQOwAmwlv+XvNhrVSs=; b=qsd91S6ygsWXlotaxbs64IWqpUOEkyHmlDZstC7UGxLO32fRtMeyOwWOGbUI/bqkn4 BcsCTP4gmdqQVuq5wKapnVNnTFzz9WNtZv1KqeYYrZk7x06a67keJhv3ee9W9MWzlJYj jen/aNMo8QIN8xrvxnwrpm84USxft3ZupEHAEPJtbJ/R/OK1mVujqbjK6hVx7Cdo249X NHkO8MkkDggG7N7zT39LWmoePCH3OKAsatBc8IGQXcSAh5r/ajY8ZkBzVC6shQrZNAsV J2dvpzcQQeTD6Cg62MUXSfI7O37tg9+alj9Api4OxuDFZ7CPO5hD13w/TIleZZ8dk5sm QCFw== X-Gm-Message-State: AOJu0YyX+SKnXa+kebpdMc5ZDKRDfOp7xXOKAA+KGykyHhPHXA9mOW01 HdZSGcYZDl+uIjo76pUP8zPmWgswHJSksukOeyjAjUMxyl5OlbAhI+jMx2c682i4 X-Gm-Gg: ASbGncvtM1rN1HfU/9Y+ZtnjGl69MH+zjq6THakmmrAMcsIYcm9L2K1eHBznurmQihl 5o/5bL6qRFggijXyaDLXwVEDYhH/N0sj0dM5i8DutgOkyA4aMBIS3MMujDCQSg0L/ANG9qh0g2U BUklfdv9V+VK0vsPdCc5g8CO8cNuYxJVyXYgjbQlvBcKaubCj6dCBGq168XVkMbmUTY3HGRt1es fkMYPrmleHn/O5YRpYTWmCKNt1xUSSRTUZqkavxTNIvAuZBxpXkahOaSO50sxVlBljVG+8cAHRn t+S4JnMsqZ1hEXhiTLhaFCRFW4m137qwUqYrzhl9pQ3vMfMkRwSRGQpF8uCcsIuEmLKteXb2bzy BlOwI5yAYCJhh147OG1pHMykI/OChtCWFk9fL2pGwv1cZF3Y3Mrof/eMtZN8zcVMNiCGGfwuI/4 PYp3obyotxH9E= X-Google-Smtp-Source: AGHT+IEBgQ7tEe4YUce74bKW5we9YcU5Y2Px96AsnGr/tI+Z357SbgeXlgl3w08aiSogfvaHGhru0w== X-Received: by 2002:a05:6000:2681:b0:407:4928:ac82 with SMTP id ffacd0b85a97d-4266e8dd3fcmr4274119f8f.53.1760001781244; Thu, 09 Oct 2025 02:23:01 -0700 (PDT) Received: from im-t490s.redhat.com (37-48-48-237.nat.epc.tmcz.cz. [37.48.48.237]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4255d8f0392sm34313629f8f.42.2025.10.09.02.23.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Oct 2025 02:23:00 -0700 (PDT) From: Ilya Maximets To: ovs-dev@openvswitch.org Cc: Ilya Maximets Date: Thu, 9 Oct 2025 11:21:26 +0200 Message-ID: <20251009092228.382349-7-i.maximets@ovn.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251009092228.382349-1-i.maximets@ovn.org> References: <20251009092228.382349-1-i.maximets@ovn.org> MIME-Version: 1.0 Subject: [ovs-dev] [PATCH 6/6] github: Add a job to build on ubuntu-14.04. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" While adding new code we frequently miss that certain compiler features may be relatively new, or more often that some system headers are not available or do not have certain definitions in them. This results in builds failing on older systems. Adding a new CI job that runs inside Ubuntu 14.04 container, which is the oldest Ubuntu that is in the "legacy support" mode: https://ubuntu.com/about/release-cycle This image has GCC 4.8 that is missing a lot of modern features and it's based on Linux v3.13 kernel that also has a lot of definitions missing in uAPI headers, compared to modern ones. This makes this image a good candidate for a baseline "old distribution" testing. This job can't cover everything and there will be different configurations and distributions that may still fail, especially if they have custom backports or some packages much newer than others. But it should cover the vast majority of potential issues. Since we're running inside a very old container, we can't use any of the pre-defined GitHub workflows like 'checkout' or 'cache', as they are based on Node.js that is built for much newer version of Ubuntu and so requires much newer glibc to run. Hence doing everything manually. Need to disable SSL, as we require OpenSSL 1.1.1+, which can probably be built, but it seems like a bit of a waste of time to re-build so many large things from sources. Need to build a newer python though, as python >= 3.7 is required in order to build OVS. Building python 3.12 because it's the same as in other tests. We could also find and choose the latest 3.12.z release automatically, but it's much less code to just manually stick to the current latest 3.12.11. There should be no reason to update it frequently. Signed-off-by: Ilya Maximets Acked-by: Kevin Traynor Acked-by: Eelco Chaudron --- .github/workflows/build-and-test.yml | 39 ++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 1e70231f7..f7ca4d1f0 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -582,6 +582,45 @@ jobs: name: logs-osx-clang---disable-ssl path: config.log + build-old-linux-distribution: + env: + dependencies: git make automake libtool gcc libnuma-dev zlib1g-dev + python_version: 3.12.11 + + name: linux gcc (ubuntu-14.04) + runs-on: ubuntu-24.04 + container: ubuntu:14.04 + timeout-minutes: 30 + + strategy: + fail-fast: false + + steps: + - name: update APT cache + run: sudo apt update || true + + - name: install dependencies + run: sudo apt install -y ${{ env.dependencies }} + + - name: build python + run: | + git clone --branch v${{ env.python_version }} --depth 1 \ + https://github.com/python/cpython cpython + cd cpython && ./configure && sudo make -j4 install + python3 --version + + - name: checkout + run: | + SHA=${{ github.event.pull_request.head.sha || github.sha }} + git clone https://github.com/${{ github.repository }}.git ovs + cd ovs && git fetch origin $SHA && git checkout $SHA + + - name: prepare + run: cd ovs && ./boot.sh && ./configure --disable-ssl --enable-Werror + + - name: build + run: cd ovs && make -j4 + build-linux-deb: env: deb_dependencies: |