From patchwork Wed Jul 30 13:51:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pratik Manvar X-Patchwork-Id: 2117253 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20230601 header.b=Po+zb1ey; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=S861sOWQ; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2607:f8b0:4864:20::138; helo=mail-il1-x138.google.com; envelope-from=swupdate+bncbdjojtwc2ymrbfwhvdcamgqeg6653xi@googlegroups.com; receiver=patchwork.ozlabs.org) Received: from mail-il1-x138.google.com (mail-il1-x138.google.com [IPv6:2607:f8b0:4864:20::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4bsYYf1cK7z1xtH for ; Wed, 30 Jul 2025 23:52:20 +1000 (AEST) Received: by mail-il1-x138.google.com with SMTP id e9e14a558f8ab-3e3f6ae4d0fsf12559385ab.1 for ; Wed, 30 Jul 2025 06:52:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1753883544; cv=pass; d=google.com; s=arc-20240605; b=IEAwZtqTwEWcpVvr9weDC7k9IzlkGgUYSkLtSY8DZP2NDpjrWkVesqPUMQCE5UWHxK YEPQmNaB5ukMkGY4/x2RTgqcfspbLlxWD0MRaV+s3Euk2BJc8korkmnYuMoRIAWity+m ylcyb4MGLO+uJVyMUQ0FynhHCttgrHKTxM7XfKyeAQwbXx1fxxL1WyYTcR7cmpb6FdwJ +fux7d+kR4q41MlVX9kvZ9+rgTpl6KImd78JBztH2JzLcxjklAzGHRdFlBTmGxgfO97z lj+kT/pNppVrpp9jH9JBki+NRIYaOMVKOWBAPBWjK+FNRVKKCUyo2p/sPhPLWBZjfSvG WoVA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:message-id:date :subject:cc:to:from:sender:dkim-signature:dkim-signature; bh=hfBSAGYgRpfb7kGeBy9ObCDryr0avNmk7o3yLllfQxg=; fh=IapcAK+W4+GgUv1LA6ecVTDx30TGJbEq/I2bnYdgRQA=; b=CCyvrAetEuRQiNjBm8Ybv28e9WUZCKn1KIDp3y0j3sFccFl43Rlr098Srck1SMVrjX 52Q1lBT2txiNkIRaOzLQIqiAWtw7ZVcgrushqRMj8tiS+JrakqotmzcQ5UzNX1mNbpsZ 3pD1kdvB+5fE5twDMAUq4oUogByNzaj6++TKRS4NFYnItDcv240E+6xAgXLAjynvvX+p M7dSRMxQ3vwL5dLk0CeZ9TkDkOirj8Io9umtKeG+2xB3rHL81KcTw4CRDtBbN3Kl1Bu4 sMxCeDa/WJhin3sY1Dwkr+Bqw8+hrTO8qgrvBZYTncNhr+dk9CvLbcoSY7Fp/Fp1wRbi KpUA==; darn=patchwork.ozlabs.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=eh4AMuh8; spf=pass (google.com: domain of pratikmanvar09@gmail.com designates 2607:f8b0:4864:20::62c as permitted sender) smtp.mailfrom=pratikmanvar09@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=pass header.i=@googlegroups.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1753883544; x=1754488344; darn=patchwork.ozlabs.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :sender:from:to:cc:subject:date:message-id:reply-to; bh=hfBSAGYgRpfb7kGeBy9ObCDryr0avNmk7o3yLllfQxg=; b=Po+zb1eyGvY9uWxaPAguqOg07dXAkUARD/VAj4Tb1u4kGSNk9x94oE59GZwGDUDHVS SH4DU+5GKHXVO9vmrM6n+BgH9ZQn1sKcKk71fmQsNrWGzv6fsYenSwsNg031fqCJXOjG xJdVk21hVx6z+Q5ch6xTCrmsFBqo9okDg3+HtGl0204MWhA2HLBF8TmihtEBZP8GEws2 jfkXuvemZBodgrgxM6MJjZK2JDnTFClrMkKxh+k29etMMWxnh7Aj9cLRjqIddiOiA4fF pxUCJ3tsec/q6qO5T0X0oqrH/V8QNAXZQwqNbgACHEED0bga4hajnKTe9AMxkWgnvOF5 Q/yQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753883544; x=1754488344; darn=patchwork.ozlabs.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :from:to:cc:subject:date:message-id:reply-to; bh=hfBSAGYgRpfb7kGeBy9ObCDryr0avNmk7o3yLllfQxg=; b=S861sOWQ9Lq/ezk6nqNJQnD9AA+hCnrnm0do0vK2TIyTuIlq+8sy1nGp8LTk358dcm de1FA5+95RQkTASuNROJvQP4UXR5ZKrdRHussUgbQ6GdvUVmxkB9r3gEiJaMLjOICMo7 9BxsKrVNB5yvTFkPjpA3EamQ5EHBDd6FgJRAo8nsfvcqPUzS37c81Jw9fghESavH+2mC 9+tvYxE+QSWo2B4DjESozeL6ShA2FPKH3h+2t+qLZqUrNj4gbn5Qi4wIo0g+eXDFTxVq NIyDwWpPPtK64cjlzCutGjbZlXT+5j6OOkEM7ABJytnArNLLoS52gyxKLYCPy8bHvpER FiVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753883544; x=1754488344; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:x-beenthere:x-gm-message-state :sender:from:to:cc:subject:date:message-id:reply-to; bh=hfBSAGYgRpfb7kGeBy9ObCDryr0avNmk7o3yLllfQxg=; b=om+X3Ir4uhjl0JzW9Q3NU8a60mP7GOnpxknPUH1WhwtWGikt/KXAy/0sewioaTSBdg y/Q24Vmh36TjqZZTeVzCVMmU96apT/7Bx3/gDvO8cu+oMzZpO0E9dJQwoZpEc9lV/ayV NPv3dt+4YWROP1+ZhdTk19HlUPcXpJY9XDK4HPWnDEatFKq95fa2UX7nL58C99pAVu0B BsPvfyfgXvHy5A6d9lCeNGSwuFUgu+/R4o3FTB30ZSWsG+Mhrgtk0xie+DLhD8UW8Gwc GlTT+L1jTbwaYh7mUbESU4aIT53nLqIHrAXXwY4a1CLBtwvHXNxXMBwOnASDKJPaCBXw LONQ== Sender: swupdate@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCXmNTh5swe/Zqc1+XgOukC6KqddnEZSauwuSckS5ucPLUW4IkDa/KdTO+70G44XKe4Nxxojqp+cNg==@patchwork.ozlabs.org X-Gm-Message-State: AOJu0Yx5jclyBXKSP8sBdhQQjf9VUvgTQligvHuywZg6wwq6YJ7inMtF 6RcX9lB42voqKZi3sC4T4S+AlOF1mh/Q439eYlaLD2QHS87lMFSj8FxX X-Google-Smtp-Source: AGHT+IHPRPZZagZYTXlEWOxdjgpgujwSCvo544PZDvRkGTjZ0kdiVfrnBm8o/X+UR1WoKl6Tph/x/g== X-Received: by 2002:a05:6e02:338f:b0:3e3:f47e:815e with SMTP id e9e14a558f8ab-3e3f62a412cmr48946345ab.6.1753883543610; Wed, 30 Jul 2025 06:52:23 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com; h=AZMbMZdqTEZTekQsX8rcnIso4mMRmcOCDZC9vOPgvCKHxI34EA== Received: by 2002:a05:6e02:2608:b0:3e3:f152:6e28 with SMTP id e9e14a558f8ab-3e3f668ee2fls3877105ab.1.-pod-prod-00-us-canary; Wed, 30 Jul 2025 06:52:21 -0700 (PDT) X-Received: by 2002:a05:6602:6d16:b0:87c:1c2a:3cd2 with SMTP id ca18e2360f4ac-8813804c8ecmr600722939f.5.1753883541139; Wed, 30 Jul 2025 06:52:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1753883541; cv=none; d=google.com; s=arc-20240605; b=DDvw6FytJ3YZjC26QAcjZAfDN655d/u9caHt/Ou4dFAMSe/WzokywWsrKlIYTHLUkA U62+pO35AQUV7gRMLRTA1kU8A6QRVqlkzS3jiDYdI7gXrKUNAou140KMa+dLT9WkQESY bo0RySl1wVFDLE8D4OlW02rNeub4iiFB76URv8gMqfJoMKPp4x8G3Rc1BEiWczJMqUvs eJ4b50M/EPOGuxEr+hn4x0FpjdYiRdFsfHlzLmToqQpO3dnRccVuaP4a/77TTaE/prgd eriQ+XSDi4vt49f/3oEmfgLw7qNWU4PPnVADRVbgm+u/h8KcIbEnd8H2+oOPPyesze+C 9aWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=ZIOkqEKYc9/4mz1dikr4EXlMxaTGu1R2NkWBsdIT2XE=; fh=8fVwqyr842D4ja+s3p3TLqZs+XteIWJoflJf6u6shuw=; b=Sj8cYstG+l/AcZGz/FsHWdL8KjgDR6IsYSEfTD8QF5ku+e3vgxXIvBjSaXS9rojB9N lqsqsoNcvyuU7da+etgcbp6+0vmZ2jENkuA7ZDRx6l3/pCj5/l4+1R+pGx/WQI4RDEQj UXMJz2ZNV5K60RoUR9rLkokrpndZAiC+sSi45zskSeIC9OUefo10H8rfC7rbbEBhMLEm flRpH4pjBWY536Ao2tmQ30/rNAnxBWw13cmGNMLCBzEERZfAvPeAeRS9tR7vgCl1ydBp ms+SZMSAtrHXIcO4Fq3Ii8B/g4u+JK+e18dx2f2XhJEQUEPn3VEAu8V8tUHtwjHYfiT4 UFeA==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=eh4AMuh8; spf=pass (google.com: domain of pratikmanvar09@gmail.com designates 2607:f8b0:4864:20::62c as permitted sender) smtp.mailfrom=pratikmanvar09@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=pass header.i=@googlegroups.com Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com. [2607:f8b0:4864:20::62c]) by gmr-mx.google.com with ESMTPS id ca18e2360f4ac-880f7a0e5bbsi70404939f.2.2025.07.30.06.52.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Jul 2025 06:52:21 -0700 (PDT) Received-SPF: pass (google.com: domain of pratikmanvar09@gmail.com designates 2607:f8b0:4864:20::62c as permitted sender) client-ip=2607:f8b0:4864:20::62c; Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-24022261323so10125885ad.1 for ; Wed, 30 Jul 2025 06:52:21 -0700 (PDT) X-Gm-Gg: ASbGnct2p4lhieckc+Mlt+3Na0MRWCvpfU1N5aRpVKHf3c/6iDwN4D7r/oxYEGAZuDW LSu0laqnww3UpySZtJn9v4xWEO5dT5cxbu73q7vFoLQh6A4GuYeshMiFinK8ZWZvDOVjsTIqaQp 8ver2a7C6mJPJFKVaWCvS9gvha9NA05BXU5HLqPMR7/wkeBwzSt1aXYvt5CBt/De7PcYOXcxaNb 3a6sHZD0sB66dj8lBPHTttWRugzoEpMKFg2YTJQx6nZKNn2tCnIsQPzEjps77L15LrV1if10Ffs trq8scTsgERyudB1P3aIj5G5ej085D64F2yMG3PuiERgCSzeOoZkIwdAEO51Xu5YUjW8Ydj6Cjm cWYjZPVHDDpmVrfOagb41hT6tq8VU X-Received: by 2002:a17:902:e78e:b0:240:3245:6d40 with SMTP id d9443c01a7336-240964f533emr53310585ad.0.1753883540028; Wed, 30 Jul 2025 06:52:20 -0700 (PDT) Received: from bsp.intra.ifm ([137.59.64.99]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2403ed55780sm63327115ad.166.2025.07.30.06.52.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Jul 2025 06:52:19 -0700 (PDT) From: Pratik Manvar To: swupdate@googlegroups.com Cc: Pratik Manvar Subject: [swupdate] [swugenerator 1/3] fix: add missing `decrypted-size` entry Date: Wed, 30 Jul 2025 19:21:49 +0530 Message-ID: <20250730135151.4186-1-pratikmanvar09@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Original-Sender: pratikmanvar09@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=eh4AMuh8; spf=pass (google.com: domain of pratikmanvar09@gmail.com designates 2607:f8b0:4864:20::62c as permitted sender) smtp.mailfrom=pratikmanvar09@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=pass header.i=@googlegroups.com Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , From: Pratik Manvar The decrypted-size field is required when flashing encrypted images to the MTD partition on NOR flash. This attribute is also required to handle the UBI Volumes. Due to a limit in the Linux kernel API for UBI volumes, the size reserved to be written on disk should be declared before actually writing anything. Signed-off-by: Pratik Manvar Tested-by: Stefano Babic --- swugenerator/generator.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/swugenerator/generator.py b/swugenerator/generator.py index 628dffe..1721aef 100644 --- a/swugenerator/generator.py +++ b/swugenerator/generator.py @@ -201,6 +201,9 @@ class SWUGenerator: entry["ivt"] = iv new.ivt = iv + entry.setdefault("properties", {}) \ + .update({ "decrypted-size": str(new.getsize()) }) + self.artifacts.append(new) else: logging.debug("Artifact %s already stored", entry["filename"]) From patchwork Wed Jul 30 13:51:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pratik Manvar X-Patchwork-Id: 2117254 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20230601 header.b=iIDX2Qst; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=mNZBk4AC; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2607:f8b0:4864:20::439; helo=mail-pf1-x439.google.com; envelope-from=swupdate+bncbdjojtwc2ymrbmwhvdcamgqeprdqseq@googlegroups.com; receiver=patchwork.ozlabs.org) Received: from mail-pf1-x439.google.com (mail-pf1-x439.google.com [IPv6:2607:f8b0:4864:20::439]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4bsYZ54rJSz1xtH for ; Wed, 30 Jul 2025 23:52:45 +1000 (AEST) Received: by mail-pf1-x439.google.com with SMTP id d2e1a72fcca58-756a4884dfcsf6991567b3a.3 for ; Wed, 30 Jul 2025 06:52:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1753883572; cv=pass; d=google.com; s=arc-20240605; b=YmF7hy0kQ+3TPnFLi1FXh+q/Ze9jbh6UbJXoZbXlSmrbEkBVFMu8xC0Ih9p33WZ3VI QuLoRH9dB+ZF8bk3cJCuIui+71LZ9XhqNaJ2YeDT+oDHcC1qK7g/3P+mcT+g3vW8AF5L zF6NrrK7pUwc9YO3seamrzjy1igcue0kC5fhxsj0TJr9emW970Zmca9pTjwsGi14WLEu 1fodgTjDt+8qy94qxqIWyj7Uqc5MBPLwaKG8zvk5zlvbCWD2o+82FlFdfA51SvGXKC4J C5V2r95cZpyVAqT7fqwa0zDsFwdAuG5ML2JJFmvTUG7k5JbsoTM21BOxpVCPMmdZtMOC ZWyQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:dkim-signature :dkim-signature; bh=8u3bRXFs49mUGTzaCMAOmwlRTk+9Gv6JXffGLB5p5lY=; fh=ML1teLuZce4EupV3JupcKc4aIfftM8rGQsiDnoM38pA=; b=FSl8L9mjpQhVRQFUkoqHuKcpNurlldcJ6I5+rOXCaKhr2I4iZ8x95jTpBnPxVBGJCg 222BxTujs23CxfOrO7Bxebc1h2Y2oyF32+EIFXG7zhp2wrjg/MBuDjtg1FPa7V9wY9Ow 4luOeRm98QN32mB5KXC3GwxyLcQKAp6PdkBwVHsH1d7GxCHSvfjyrKeE8uC4PJxoW4If ugM69mBmCZK4De7UhNAAtQXkbTf5YVbNhXG6iDZ+KHwbkU6U63JlebBL3nPCSWy3r4FJ 7KymcZHUbKwyL76N9+tREuDnAEtV48OB3bvPQz2SXfwtkjWJLGR47pgeY8oU7bPRb9tZ upLQ==; darn=patchwork.ozlabs.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=haAY+cbe; spf=pass (google.com: domain of pratikmanvar09@gmail.com designates 2607:f8b0:4864:20::636 as permitted sender) smtp.mailfrom=pratikmanvar09@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=pass header.i=@googlegroups.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1753883572; x=1754488372; darn=patchwork.ozlabs.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:sender:from:to:cc:subject:date:message-id :reply-to; bh=8u3bRXFs49mUGTzaCMAOmwlRTk+9Gv6JXffGLB5p5lY=; b=iIDX2QstVZ1q/+oBFh1RgY5/NZ/DZXMi6iznFuj1XK0/kPlN/gIddCWXBFBqoBYTsw H4coR1cBu8iwEW6VvRzpx4GsSH7lu41pAy/hbhAY7KWIILrq3R5zIpPT1au7oOg87wUe WMK+hszYg9o1x+WhhrXqOB3GRJd02CKsyJcMMX9APef5NdPVJz8l1hH18D4hlR8qOtpZ Ysw8Zk+3ZCihcBi+5XMHUgJ3FaPImpe+0/lFHYBXoq1E75aEcaSxKefsxqGO0z6Di89e 5bz7ODrYhZq4llAmBxbDjPohRnR5cZML+A/puRkN/4S7+82iVSmwfF7xn153ZmR1BsWY 1y+A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753883572; x=1754488372; darn=patchwork.ozlabs.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=8u3bRXFs49mUGTzaCMAOmwlRTk+9Gv6JXffGLB5p5lY=; b=mNZBk4ACIt/QJ1JwYxMhTnmWk3Kx/LUnWMZJ0QTanpZ8pFNPJ3EDAmT0eJ9pA+4YR7 42Ni+an7XSz/E6TNgBBf4AX10tkjYptWHlNQD+RP2LDa4/+GyyTidrcZyYgWVdxBwQSR WWlQdG4q4xNisKFb1CXOBEVxa0gpxdrzgRdWD1TG3mSq5VNgO1d+m2BGPnbYsbth7tGU Go/XsTg6cbLInd5XrFwrXbTDHojVx7r3Rts38rPA5VUoumPHE2N10Z/W5169u89cOGcI Ws6JQRRuQ95ED06DzvWezzS3eSG/ODzD2DCgkC3h9JIBGzPOEvKiVDTaZffgb8CN2KLf yJiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753883572; x=1754488372; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:sender:from:to:cc:subject:date :message-id:reply-to; bh=8u3bRXFs49mUGTzaCMAOmwlRTk+9Gv6JXffGLB5p5lY=; b=tgoW1pvAgB9qpqhMKCwqR8kJ2N0DpznhlV49B+0ofRIwaU0irRFgOHUnnkapAcuG6H /iiwLmcjyHtx8fAQi0QSemVMgcgTyLKmuCuqumdjtffadoP4vVZtgAD5MHIxYTVARt/i YHvruTPGCLxxLJInIDqk52KcxcLrD73yCq30T240c+xASniVTx8tfiR3tGkWLCH2rQTW zo2YytCLmQwyUj6x00UwLO97whwUWiSNYtqc/sDQDx9TuPk8yV9mhODbciaoxC1tMtDy K9pc20cWq9GKtK3EjFVpVaao8b0kpFnLcHBISOIjfFusUe5x7Pee8OQm6v2Ik83dio2t iANg== Sender: swupdate@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCUEZOs9ZbB+07oe8oRhjOOu3cS8GuW9W8a0XRH9FRC1tc8r4fFT9nDSQGjIY5G0U+ila76cQ2B3KQ==@patchwork.ozlabs.org X-Gm-Message-State: AOJu0YzdHMC0FyAmy8vnirdUWC6pmih+LGeYoDO3XxKfD7TGYn85yXuK sPuhoXlviaDs1nhPT32S5YSGp+RkhBXphKiU/CaVumI+irjdTeCN+Yso X-Google-Smtp-Source: AGHT+IGBvFS3c6My37Bz2cy5kn316erxKSKTsFaXI0eyzx6LMKbRtVOpj10KYP/QGR/opvMCWIO0XQ== X-Received: by 2002:a05:6a20:1581:b0:21f:5c9d:498b with SMTP id adf61e73a8af0-23dc0e4370cmr5224165637.28.1753883572179; Wed, 30 Jul 2025 06:52:52 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com; h=AZMbMZeJT+iRweXN1D6QXMG0+X6D/BmkFiX3jbra6E5KQJ6mUw== Received: by 2002:a17:90b:35c1:b0:31f:27f:9170 with SMTP id 98e67ed59e1d1-31f027fa2ebls3127066a91.2.-pod-prod-09-us; Wed, 30 Jul 2025 06:52:49 -0700 (PDT) X-Received: by 2002:a17:90b:5103:b0:313:f6fa:5bb5 with SMTP id 98e67ed59e1d1-31f5de54a99mr5329717a91.18.1753883569528; Wed, 30 Jul 2025 06:52:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1753883569; cv=none; d=google.com; s=arc-20240605; b=ZygEPZYALCufJCJS5bY/GgvPNA1Fb+74XshOyFge8Oo93PwMLa6HK6CJ+64zVyDW9G LXJ8Ivo/bWtw/XWHiRxB8J0jlFW9Pm2IcK4Dhu0hWDGlCScst87BhPpmOWqXmNCGy87r lMubts9aBjFgqd1XdadFV8s/n8kjbOm82T1Jjc0UjGlN0WWAt6GmHpVYbYc2K0OeDCtu zYKmiMM4UsoAG2GSnzdG/vHqFBWLFDOg2ESJ3InGFR0kF0WKOdDZm5fP8oBVj+WTUiBc sykaX0Eq4ZTTQI6mubEgpOisSPDjUOSpEIPsIqjA9Du1n8FUC9gAOnCYfftEsI0NeqBy PLVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=4a326wsFpBSXmzXOz7MWNHjBL/kzGXeO/h9eFH5w87s=; fh=8fVwqyr842D4ja+s3p3TLqZs+XteIWJoflJf6u6shuw=; b=UlilfTUiQPEk2DNLfz2lq4DfSszseOi3quGl0NzwSWzZbzrhOBIWKP57457wNKkR5M gMukJC9E7tBTma1ewlq5fYeL+2CT/AXdJJiENLGf8LemjNKp1hehELXHMoMCudECKJ+Q wG5b25GLVdF3V/rgl/D8ZpOLrtSIMFjpQ9//dqoZRcaLJYFDn45JabnSQ63A04Hbfvwj SA1JkTOyK+qDQulIUTQuIHt9CAdfaHBvs3UsXjO3PU2Z39n8unIZldwauVGtCt0OdAw3 hfVo9+vnJNjSzVCgv6a2b/gDpnA5sFF0IUneUPtx4h9au26QMNO25sI8ZbiWk0y/RpMj qoyA==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=haAY+cbe; spf=pass (google.com: domain of pratikmanvar09@gmail.com designates 2607:f8b0:4864:20::636 as permitted sender) smtp.mailfrom=pratikmanvar09@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=pass header.i=@googlegroups.com Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com. [2607:f8b0:4864:20::636]) by gmr-mx.google.com with ESMTPS id 98e67ed59e1d1-31f63c0cd73si88195a91.0.2025.07.30.06.52.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Jul 2025 06:52:49 -0700 (PDT) Received-SPF: pass (google.com: domain of pratikmanvar09@gmail.com designates 2607:f8b0:4864:20::636 as permitted sender) client-ip=2607:f8b0:4864:20::636; Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-23ffdea3575so27367035ad.2 for ; Wed, 30 Jul 2025 06:52:49 -0700 (PDT) X-Gm-Gg: ASbGnctCwfX2P/Qw5HqJvYiWT0KA5aILdbHEccn87OZi0aKa+k8zf5wu3wFLTyeWTtu PlSuaRqH/VdJXD/Ja8v97i+7dw7uBuzjt6weLyZ7Jin2AwrT4E3hEpGRFj4+5vjual30DxeAbbv ox0+V6Mx0ecn1Z44+EdbiUNXwmRXd1RXJL3P/5hr0wk40FwUM9ozO/OL2dgGiJXN3LuWDfZz5pd WvN6l18qGkDRqXZs8UOsIr1qupBh9/F+TsFQwYUTgs4K49PTVZIi3ZB3rSKHzSzTL1q89MeseaK YMg7wuwSWSfGejf2iwBdLtvOpEIv+OuR5u6XrL73gtgmjWotd81YZVxx9yfpAi/f+7Kk4uYz8N0 vE7IrkYBXtX7DTNKOosC+/ng2FhJ3 X-Received: by 2002:a17:902:ce05:b0:240:8cb5:98b4 with SMTP id d9443c01a7336-24096abcf0emr42557405ad.23.1753883568566; Wed, 30 Jul 2025 06:52:48 -0700 (PDT) Received: from bsp.intra.ifm ([137.59.64.99]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2403ed55780sm63327115ad.166.2025.07.30.06.52.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Jul 2025 06:52:48 -0700 (PDT) From: Pratik Manvar To: swupdate@googlegroups.com Cc: Pratik Manvar Subject: [swupdate] [swugenerator 2/3] Extend PKCS#11 support to handle optional slot and id parameters Date: Wed, 30 Jul 2025 19:21:50 +0530 Message-ID: <20250730135151.4186-2-pratikmanvar09@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250730135151.4186-1-pratikmanvar09@gmail.com> References: <20250730135151.4186-1-pratikmanvar09@gmail.com> MIME-Version: 1.0 X-Original-Sender: pratikmanvar09@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=haAY+cbe; spf=pass (google.com: domain of pratikmanvar09@gmail.com designates 2607:f8b0:4864:20::636 as permitted sender) smtp.mailfrom=pratikmanvar09@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=pass header.i=@googlegroups.com Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , From: Pratik Manvar The PKCS11 signing option uses `pkcs11-tool` for archive signing. This tool supports additional argunments such as `--slot` and `--id` along with `--module` and `--pin`. This commit enhance the PKCS#11 signing to support up to five parameters: - PIN argument remains mandatory. - Add the slot and id as optional parameters along with module. The new format for the signing option is: `PKCS11,[,,,]` Signed-off-by: Pratik Manvar --- swugenerator/main.py | 17 ++++++++++------- swugenerator/swu_sign.py | 6 +++++- 2 files changed, 15 insertions(+), 8 deletions(-) diff --git a/swugenerator/main.py b/swugenerator/main.py index cf66a13..ed0c94f 100644 --- a/swugenerator/main.py +++ b/swugenerator/main.py @@ -102,7 +102,7 @@ def parse_signing_option( CMS,, RSA,, RSA, - PKCS11,[,] + PKCS11,[,,,] CUSTOM, Args: @@ -143,12 +143,15 @@ def parse_signing_option( # Format : RSA, return SWUSignRSA(sign_parms[1], None) if cmd == "PKCS11": - # Format : PKCS11,[,] - if len(sign_parms) not in (2, 3) or not all(sign_parms[0:2]): - raise InvalidSigningOption("PKCS11 requires pin and optional module path") + # Format : PKCS11,[,,,] + if len(sign_parms) not in range(2, 6) or not all(sign_parms[0:2]): + raise InvalidSigningOption("PKCS11 requires pin and optional parameters such as module path, slot or id") pin = sign_parms[1] - module = sign_parms[2] if len(sign_parms) == 3 else None - return SWUSignPKCS11(pin, module) + module = sign_parms[2] if len(sign_parms) > 2 else None + slot = sign_parms[3] if len(sign_parms) > 3 else None + obj_id = sign_parms[4] if len(sign_parms) > 4 else None + + return SWUSignPKCS11(pin, module, slot, obj_id) if cmd == "CUSTOM": # Format : CUSTOM, if len(sign_parms) < 2 or not all(sign_parms): @@ -271,7 +274,7 @@ def parse_args(args: List[str]) -> None: -g, --engine ENGINE OpenSSL engine to use for signing (e.g., pkcs11) -f, --keyform KEYFORM Key format to use for signing (e.g., engine) RSA,, - PKCS11,[,] + PKCS11,[,,,] CUSTOM, """ ), ) diff --git a/swugenerator/swu_sign.py b/swugenerator/swu_sign.py index 992c5fd..437a0a5 100644 --- a/swugenerator/swu_sign.py +++ b/swugenerator/swu_sign.py @@ -113,12 +113,16 @@ class SWUSignCustom(SWUSign): # Note: tested with Nitrokey HSM class SWUSignPKCS11(SWUSign): - def __init__(self, pin, module=None): + def __init__(self, pin, module=None, slot=None, obj_id=None): super().__init__() self.type = "PKCS11" self.custom = [] if module: self.custom.extend(["--module", module]) + if slot: + self.custom.extend(["--slot", slot]) + if obj_id: + self.custom.extend(["--id", obj_id]) self.custom.extend(["--pin", pin]) def prepare_cmd(self, sw_desc_in, sw_desc_sig): From patchwork Wed Jul 30 13:51:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pratik Manvar X-Patchwork-Id: 2117255 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20230601 header.b=wXr2JErK; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=LTC4rQzI; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2001:4860:4864:20::40; helo=mail-oa1-x40.google.com; envelope-from=swupdate+bncbdjojtwc2ymrbq6hvdcamgqe52g5z7q@googlegroups.com; receiver=patchwork.ozlabs.org) Received: from mail-oa1-x40.google.com (mail-oa1-x40.google.com [IPv6:2001:4860:4864:20::40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4bsYZV1XcTz1xtH for ; Wed, 30 Jul 2025 23:53:06 +1000 (AEST) Received: by mail-oa1-x40.google.com with SMTP id 586e51a60fabf-301ede1998asf1813321fac.3 for ; Wed, 30 Jul 2025 06:53:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1753883589; cv=pass; d=google.com; s=arc-20240605; b=FJHREN6odX20Msa3YswQfJnRPCsy9bp7MZ1++DhKdz/ueVf+J5fhnajGMDer4o63Jn HwkFKEJX1ChhNPUU/NGBx5wVHMBsLG/c05ocPIuX7hkF4ehtRM0d7z20PnJy+PWcjnir b9QpxuWmGPlgcqjo7HH9Ld8pWfLc+POS/+ydsW2JZjHHuEljDkHlK+gR9cB2K+8M7J/7 crcr/pW+03dsFUqwgOrb77GC5q3YhK+8dH3m7g2DLghWbYj7yFvXdTVj21dl2G6D9u8x 0gLW8DprL0UfgYYRwfoH2y0KTTfG9vFwLVwRdMv78a1zDAZ2dFth4r9VzaiLkuk5MlW2 lE4Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:dkim-signature :dkim-signature; bh=AlJ3u2H3NHJAHXNg0NCah25vI4I2zZjeTb5vHNyPiCY=; fh=LtW0GPkSGmeMH6Hn2EqP1SZxI2LChhaV4F61usjga0Q=; b=fYnIefhXidNpi8hgWCS3tpxt0zuo3oW94xo63zutrKKrw1ZiKvn6DeC9jS+zWAipK0 0wvd+tvoLQpWTJCEtLYM6eW69bliskt4rTVHTellEBi1AHPQfv4U82kaoYNRJH44HAui B2/5+YpJtJDSQOTbIIwYZ8pKxBvvERpln5KC+VDqtP7N0RLIcLYQfsq8obwzFngltd9O OUx59DqCNViQxYv7e/pa4nC6IqyGPBgSVzEJ0DKiSejEK3dRLrD4fpJhugD4DsOgBNpw Im0PXFnC/ShPLAtkueg/vRlNqAa77akhx4maDhKPQ5SI8JXnE4sJL0jnALsi+aY1iqA2 Xx1g==; darn=patchwork.ozlabs.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=g2Z18k6a; spf=pass (google.com: domain of pratikmanvar09@gmail.com designates 2607:f8b0:4864:20::62e as permitted sender) smtp.mailfrom=pratikmanvar09@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=pass header.i=@googlegroups.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1753883588; x=1754488388; darn=patchwork.ozlabs.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:sender:from:to:cc:subject:date:message-id :reply-to; bh=AlJ3u2H3NHJAHXNg0NCah25vI4I2zZjeTb5vHNyPiCY=; b=wXr2JErKPin7jKOcWbyx03EPJmimU6FjdVx4GIpV0IjYuqRL9DYsfkQ85s/atxFghz mt/HfwYfzjvvj2/9SNl3j5I0l7LZvP/vK9HkNoNQRMrf8nVLIJ7gT54sf1FlGVRbTkd/ CZG6fJLRhMUIhUkM08tgSNq0CNp73J+4z5P9VroUjztLHIZMpiPiz7pCmY4AAdtTLt+H LQ8wbeLA0AIfLlCJjPqWJCJzq05RUEbPI/zKUUNPEpNp2WhfNFCm4KAVWtlnwvKYmHwl TiiF8cUBR80Q8q3rfHjQZLa02kFSWIZZcwLdWUMCC0YHOp/GRHXUaNqF6+m5QtwT5R1O 25NA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753883588; x=1754488388; darn=patchwork.ozlabs.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=AlJ3u2H3NHJAHXNg0NCah25vI4I2zZjeTb5vHNyPiCY=; b=LTC4rQzIwuSM4Cj3kU4/HhTANqRXJYkMphgsmithbcj7AE9Kq06ZOinxQFpgzw80Os LWLfODAkC6QYwQQCQ1WUQQbIQteyKiDLhXEW3xaD7H7U2WJqD3E6jzXkHHzuvoAqoJrY fB4yOYQ5E9sbKDX30Jg4e8QaD3MJB1vI+f6QMGNzQHtSCYwmyniUSEioO2+LDpVVFQKS IIQcjNEPF4cB6wrgBpuAKCfOqFydGvlVk9EY6oi44zdvRiryXlzV0kpDfcqLVaDDW8BG cvL2bzcPjYJVlO9BHHdF9uNeL+I0w3Ea4Jvi11JmT/vGDDF6g5hHxqsywT6gpTHr+QiB UdhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753883589; x=1754488389; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:sender:from:to:cc:subject:date :message-id:reply-to; bh=AlJ3u2H3NHJAHXNg0NCah25vI4I2zZjeTb5vHNyPiCY=; b=LzeFzqqp63E/eRR+tssI54drOcmmfudl9cwQsjS1wAuo87GEjHgisiixhCpZcX6qrV RE8KpgVH01Dj8FORhm+8shhZl1VlU6TlaMfXcva/Q1SLxYGht17o9ZCVjR1yLKcOdTBc GNmDaNIDz91xe763vH3ha/+U7493eQDcD0hGN9nOg3LwVnkz/V5iNxqppKpyJJpU05gl /Mvq6uV+T3s0nUBlGnWNAovR9IrCVEvqxGdwL8azRfDMQFBQ5BAKDll20QnS+V7aG53q 9a4bEn99jcdKrC/MiKn+Jv6elPp42JNDcY0P8jZawkS6e11hm1hzsgxV2aW471KNtVpI LOZw== Sender: swupdate@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCXvjjGCzM34/FKUjRs67vH1H1HaTasRsQeFOHOMU0DgBL+SLH0DbbTX5G5ENVW6oZu3kH6YJCfzaQ==@patchwork.ozlabs.org X-Gm-Message-State: AOJu0Yy1jccEXfgITA4d8Kc8CZs87z9qXW8ee6TJuw5398aSLTTZEUqZ nsKb8mG3gQXRvlsXiYaikARcytCMac8NqFlNbr3BLaesXEwfU9bD/GdP X-Google-Smtp-Source: AGHT+IEW2VZs4zDl6tO3fGhjNNgcBZvlyT0ELSFbi729qYzu98VuU7VgxlPbHx6TFk631eZH2kjyzg== X-Received: by 2002:a05:6808:1b24:b0:415:969d:26f8 with SMTP id 5614622812f47-4319a083827mr1964662b6e.17.1753883588464; Wed, 30 Jul 2025 06:53:08 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com; h=AZMbMZeEWYOPBhC3pRWTv1KXb+heO75OjMbKajs+wn63R/YrPw== Received: by 2002:a05:6871:8114:b0:2e9:9a5a:7609 with SMTP id 586e51a60fabf-306ddbc34a5ls4179999fac.1.-pod-prod-01-us; Wed, 30 Jul 2025 06:53:06 -0700 (PDT) X-Received: by 2002:a05:6870:3c19:b0:2ff:a802:6885 with SMTP id 586e51a60fabf-30785a2abd6mr1902758fac.11.1753883586732; Wed, 30 Jul 2025 06:53:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1753883586; cv=none; d=google.com; s=arc-20240605; b=X88ncZ5eGMGo9N48vuaHhvW6pG/SdbcylMIZRPXewSU5uJQRi49SRP04braov6Z/HT IFnz+cCdcZwJJZkw1Zx8/7SH/t5rWyB8c+upb3x9LNr0VyH8VBEMU2ZeLhI8lLiH0N8f kTcXZE10BFom+OA4pW3jLWln3oQVVTQhwLtSOj8u+1qpgDglwsRmds+TrOYniYdpx4oN bPZl35nzKxacUOepKLiATSOwBG4XKO8NdoaVDWbXNXASOBaqbTchxdp3XTmzS+p/VByP Y5bFIgk0OK0eya3VZDt9Zr+LnQRGcHRLwN4CzYEx8Qoq5YNfNwy6pGJzPu9M6PSar+NB AGUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=jIqLjXL8JQZ0sfsRp0Rt/wAGzG4ZcjZSqOkPo+Am4RU=; fh=8fVwqyr842D4ja+s3p3TLqZs+XteIWJoflJf6u6shuw=; b=kxZoyCny60WVEL3ARYQC6EdsnbiOzD9CJ6Nnpslfy5Mnz5vr6FFWAzLHNI0g+kfGXJ zFdrVJOxC8KmcXkdEPLq3znPYnHafTTBWreah3WzIeg4DyibeC1yrtCgm1iaVLzlSeyp FVbk+Oh6v5rqtjY4pRlrcXmOpw74NHz8j2ByefEqEXgdKCPrqeNV6oNB5mNTOt0OF7W0 5xi8iwH/iJ8pbbhj6uO+ubW6NQEJU11TODgHqN0s+rGz/UVg/TcPs/rjxu7/HrU3UKHy fjdPEd03Sh9O44SYDzLxJwqnPpHrID1XXppNBbh9kQRpbXrc0oReBnNb5axg/P5n2sw2 8RDQ==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=g2Z18k6a; spf=pass (google.com: domain of pratikmanvar09@gmail.com designates 2607:f8b0:4864:20::62e as permitted sender) smtp.mailfrom=pratikmanvar09@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=pass header.i=@googlegroups.com Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com. [2607:f8b0:4864:20::62e]) by gmr-mx.google.com with ESMTPS id 586e51a60fabf-307134fda99si536954fac.5.2025.07.30.06.53.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Jul 2025 06:53:06 -0700 (PDT) Received-SPF: pass (google.com: domain of pratikmanvar09@gmail.com designates 2607:f8b0:4864:20::62e as permitted sender) client-ip=2607:f8b0:4864:20::62e; Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-23aeac7d77aso9308175ad.3 for ; Wed, 30 Jul 2025 06:53:06 -0700 (PDT) X-Gm-Gg: ASbGncup0ZhIEhIBRueaEcipw3vDZ23orRKCUpD8p+JU11Y867Aw8tviuGf7qCRFWPA MdHfnjIrivG0tAfQNczB3RrlAcsZED5bCWd4uYo0Qx7WTx2XSHh20XfysV5kWHZUznoBhV6Nb11 HfUekY+QrbaDTDQBJzGK2L2pQPb/avXOyqUC9MqtQJVyClrtwTJ8pPFstCHLZy9Ifn48hLRqLkv fO8sfN87AU1tR7pD5P8B4cF1Bxf8agnDRjUw1kKvEll/2z95CFm/AovhRjX2aXqNeZqVsXqrc4q 8ZLyOjytV4UeA1g+DZyJzm2A7XNxN5GmaqfSHFfCHEefziLp/L8mkmvBkj5Xa7rXpNW7KGZ6C9z BTcqMkXM2yTqbY4zRpNPVC57qO/jz X-Received: by 2002:a17:903:11d0:b0:234:8ef1:aa7b with SMTP id d9443c01a7336-24096a6fefdmr41855605ad.20.1753883585136; Wed, 30 Jul 2025 06:53:05 -0700 (PDT) Received: from bsp.intra.ifm ([137.59.64.99]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2403ed55780sm63327115ad.166.2025.07.30.06.53.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Jul 2025 06:53:04 -0700 (PDT) From: Pratik Manvar To: swupdate@googlegroups.com Cc: Pratik Manvar Subject: [swupdate] [swugenerator 3/3] fix: correct PKCS#11 mechanism usage in signing command Date: Wed, 30 Jul 2025 19:21:51 +0530 Message-ID: <20250730135151.4186-3-pratikmanvar09@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250730135151.4186-1-pratikmanvar09@gmail.com> References: <20250730135151.4186-1-pratikmanvar09@gmail.com> MIME-Version: 1.0 X-Original-Sender: pratikmanvar09@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=g2Z18k6a; spf=pass (google.com: domain of pratikmanvar09@gmail.com designates 2607:f8b0:4864:20::62e as permitted sender) smtp.mailfrom=pratikmanvar09@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=pass header.i=@googlegroups.com Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , From: Pratik Manvar Fix an issue where the pkcs11-tool was invoked with an empty mechanism due to a space after `-m ` flag. This caused signing to fail with the error "Unknown PKCS11 mechanism". So, remove space after `-m` to fix PKCS#11 mechanism error as below. ['-m ', 'SHA256-RSA-PKCS'] ['-m', 'SHA256-RSA-PKCS'] The mechanism should now correctly set to `SHA256-RSA-PKCS`. Signed-off-by: Pratik Manvar --- swugenerator/swu_sign.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/swugenerator/swu_sign.py b/swugenerator/swu_sign.py index 437a0a5..53b6727 100644 --- a/swugenerator/swu_sign.py +++ b/swugenerator/swu_sign.py @@ -129,7 +129,7 @@ class SWUSignPKCS11(SWUSign): self.signcmd = [ "pkcs11-tool", "-s", - "-m ", + "-m", "SHA256-RSA-PKCS", "-i", sw_desc_in,