From patchwork Tue Apr 22 13:10:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Madhavan Srinivasan X-Patchwork-Id: 2075367 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=jW7xB48E; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org; envelope-from=linuxppc-dev+bounces-7901-incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=patchwork.ozlabs.org) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4ZhjL05sQyz1yMy for ; Tue, 22 Apr 2025 23:11:20 +1000 (AEST) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4ZhjLL34Bgz3bx5; Tue, 22 Apr 2025 23:11:38 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1745327498; cv=none; b=niiQP2dOgE4Bvcq8A2wf6EoVEvQG47jgtZoXXHTGPCV/GEfOsWplQ2p3YfsfcixI+13wTsqcj4T3QBJFDkDMfTBWQXzv072w6DXS1YhBA2yjASap48WR8qWw1NdMiEWCSos8432/coHJUAqLph8BI6YLs+vvM8o2Ld4nUeA0eh2cuF+MSq7T0QjDgYpvQeh3n3kGFfp4F9fzFBqiIKxIW23zuWwLEitN1TT9uqvx7ytQ6ndhoGJ5sdeoDhUTMzF35aNXB4LM6JxX+cmryNNBc5HXL4G7NAr3z2QbwW2KII48jNR+BQgHkM6mR+YDL3+4g0B3axxFUCbkCgZxjUwx6g== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1745327498; c=relaxed/relaxed; bh=DZZ9hZEIHnIbwCRBOuoyvD1VFXNWmRzKcg/N3dnTCG8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TQg12Lb7mNukp6UqtJnwJF8CJdte09yayivoTP9+jUg3R5IiUfgdLskSpyWsUkeZSE+HRsF3QFHJ5yhgvmP1xuXEJAadBfb0oMmdFcVqYwkhWU3s38hAmeryBVKI6OU3Ee/zAEK8fJ4Ez5tLO2Wt7Ow01xo3SQaC9MF89Hfugb1OPsybu2NGwWL/BiiaFf66KRu0TrV6XYHS0TWEgXYqCCPNcQf7O0mJ5rLJ6FhezqiOrg/oNtblYpgXhA7LtlcMEzcnRt65m2ZE/fwsCQa+TXip8zk5gh49RA4H9R7f7OAxnv6MdtifXNDG0f3bd530y287kkeEcPh8oVWElCvSxw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=jW7xB48E; dkim-atps=neutral; spf=pass (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=maddy@linux.ibm.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=jW7xB48E; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=maddy@linux.ibm.com; receiver=lists.ozlabs.org) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4ZhjLK4WTXz304l for ; Tue, 22 Apr 2025 23:11:37 +1000 (AEST) Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53MCauFe005831; Tue, 22 Apr 2025 13:11:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=DZZ9hZEIHnIbwCRBO uoyvD1VFXNWmRzKcg/N3dnTCG8=; b=jW7xB48E4ry33zgxLdzF3t7L5DTTz3BIm CEFGNqNf0StOroo5X88guZWQGDMk6RMt+qh/URdSZJ9ia7U5Ms3+NaidUkfpdkzk UFxnhJhprj3WTPp+aBKnBZp7Z6XsDBSyqFoVcxV05L0HYrebJeI9unEAbZgHoszv PTbogW71ZZ3VMAIkkqtW3Sq7WLJootUPTQ9NUtJi19DdDB+tq+UW60Q2ZBQf5MzB khwCf8AkOhrnNv2a6eYOa85DLLsjLYkPmrMGs8MGcyVfuw2Cb5j9lejS7cWKA+R3 FDiVXeqsNq0YTzYI7te3BUKR434Q49g9nYT/ywm//ZOMMqichWsbQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 466b97g5df-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Apr 2025 13:11:24 +0000 (GMT) Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 53MD1SBk003298; Tue, 22 Apr 2025 13:11:23 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 466b97g5dc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Apr 2025 13:11:23 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 53MAcj5Q012501; Tue, 22 Apr 2025 13:11:22 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 464p5t361b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Apr 2025 13:11:22 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 53MDBLMO37814742 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 22 Apr 2025 13:11:21 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1496220067; Tue, 22 Apr 2025 13:11:21 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7C2842005A; Tue, 22 Apr 2025 13:11:10 +0000 (GMT) Received: from li-c439904c-24ed-11b2-a85c-b284a6847472.ibm.com.com (unknown [9.43.58.77]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 22 Apr 2025 13:11:09 +0000 (GMT) From: Madhavan Srinivasan To: mpe@ellerman.id.au, christophe.leroy@csgroup.eu Cc: npiggin@gmail.com, naveen@kernel.org, linuxppc-dev@lists.ozlabs.org, Madhavan Srinivasan Subject: [PATCH 1/6] powerpc/kvm: Fix sparse warning Date: Tue, 22 Apr 2025 18:40:35 +0530 Message-ID: <20250422131040.374427-2-maddy@linux.ibm.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250422131040.374427-1-maddy@linux.ibm.com> References: <20250422131040.374427-1-maddy@linux.ibm.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: G8eNbRtl40zmscJaA4FjOjr80NRpHbYl X-Proofpoint-ORIG-GUID: kj7YC4vI9Vo_xzxSIHRm8sDlsMmQHMN2 X-Authority-Analysis: v=2.4 cv=FIgbx/os c=1 sm=1 tr=0 ts=6807957c cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=XR8D0OoHHMoA:10 a=VnNF1IyMAAAA:8 a=vsNPJdNJzHsXnjP1ScgA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-22_06,2025-04-21_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 spamscore=0 phishscore=0 impostorscore=0 malwarescore=0 suspectscore=0 mlxscore=0 clxscore=1015 bulkscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504220098 X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1 OzLabs 8 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org When compiling for pseries or powernv defconfig with "make C=1", these warning were reported by sparse tool in powerpc/kernel/kvm.c arch/powerpc/kernel/kvm.c:635:9: warning: switch with no cases arch/powerpc/kernel/kvm.c:646:9: warning: switch with no cases Currently #ifdef were added after the switch case which are specific for BOOKE and PPC_BOOK3S_32. These are not enabled in pseries/powernv defconfig. Fix it by moving the #ifdef before switch(){} Signed-off-by: Madhavan Srinivasan --- arch/powerpc/kernel/kvm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/kernel/kvm.c b/arch/powerpc/kernel/kvm.c index 5b3c093611ba..7209d00a9c25 100644 --- a/arch/powerpc/kernel/kvm.c +++ b/arch/powerpc/kernel/kvm.c @@ -632,19 +632,19 @@ static void __init kvm_check_ins(u32 *inst, u32 features) #endif } - switch (inst_no_rt & ~KVM_MASK_RB) { #ifdef CONFIG_PPC_BOOK3S_32 + switch (inst_no_rt & ~KVM_MASK_RB) { case KVM_INST_MTSRIN: if (features & KVM_MAGIC_FEAT_SR) { u32 inst_rb = _inst & KVM_MASK_RB; kvm_patch_ins_mtsrin(inst, inst_rt, inst_rb); } break; -#endif } +#endif - switch (_inst) { #ifdef CONFIG_BOOKE + switch (_inst) { case KVM_INST_WRTEEI_0: kvm_patch_ins_wrteei_0(inst); break; @@ -652,8 +652,8 @@ static void __init kvm_check_ins(u32 *inst, u32 features) case KVM_INST_WRTEEI_1: kvm_patch_ins_wrtee(inst, 0, 1); break; -#endif } +#endif } extern u32 kvm_template_start[]; From patchwork Tue Apr 22 13:10:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Madhavan Srinivasan X-Patchwork-Id: 2075368 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=GmNzJTwp; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org; envelope-from=linuxppc-dev+bounces-7902-incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=patchwork.ozlabs.org) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4ZhjLJ36Vjz1yMy for ; Tue, 22 Apr 2025 23:11:36 +1000 (AEST) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4ZhjLd73m7z3bx1; Tue, 22 Apr 2025 23:11:53 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1745327513; cv=none; b=Vj86zkdYIp6iODXnT6CzcZCytObDG1x8A5PORz+MT8GTXg4afVXd3PPH71l5+DJQqSxbyXPecvDDtJnrxDkQNNVWBjclUVBXlJc/9rmk2rpv4WBHd5z88zwwbZSvQanoqewXnkRx+zoBdTBwupOefMgCWXucQizYYVSdwc2Wxe8Wpif0WKEJCxztNLPzCC5O3YnU8ZHqc5fCdTnYsdWdYDKhMi3gKzulp6n/4XfU5RLl4KKVcq22ZHzMQro0JQM1HeGvi8phBHm8yBNeNgnVuHQnoeJUE6B7dpDffjSlK9g5NVrfVRybhGJBBU1ft6n6Maoa+0THomnu3caAvoCSFA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1745327513; c=relaxed/relaxed; bh=ScOt4YcpS/wxQRSbcYFmEU2eo0k8ZR8ip++l6ZKMUaY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K9B0eTk+9aZr8CThALuu9o0B7gmcaB2kYZRkupeEewtmMfvJ+1M+J3jfceTI+yuNjRi5thOQ4a7M0Xa+wxdbYvTMrDC40kHAHkrtPENiYkK3+lYOTyaAv8xugeXfdRtoq0nEClDPK096uDnXNuz2kR4IEW91fdjrwuD7u1vVZI7Cxwoe32jyJO/BbD0PPAZAVV8BOSzxiWy8XacB4WSntBPvgj9tYonWrislvOHXkD8bcv3yV5Lh8ziw2gpF3BeFOEHb+LzWMywo4VR2BEhjqjMFZmWG1AodDlKYJFeWZkEbAIitSryIqzAWE/1Ed74XFegCoFs453ij1rVf5v+W9g== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=GmNzJTwp; dkim-atps=neutral; spf=pass (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=maddy@linux.ibm.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=GmNzJTwp; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=maddy@linux.ibm.com; receiver=lists.ozlabs.org) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4ZhjLd2Mpsz304l for ; Tue, 22 Apr 2025 23:11:53 +1000 (AEST) Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53MAbSev020741; Tue, 22 Apr 2025 13:11:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=ScOt4YcpS/wxQRSbc YFmEU2eo0k8ZR8ip++l6ZKMUaY=; b=GmNzJTwpUtcXB1H7VgeHKn+tQXlZmbd5o m1TZJuwMRSnVufeWeSG6ohpKniEAwt4vM+8kSi1KfH+NAhPZMQcNeVk+1OMl1nfi jZ3PzI7449mXCPV4yxwUYhH1jn/Kyb4UQkiurvuBUNIRjpQ0Sa4A4pUze+idWowz vm7/XI0n5wJ+sISTA3Ken/ZnnOtL2JYAfOnvaaksM828+hArPMH0f+cB4BgZNyEQ wdUa33NXu1f9739VapA7vnmGcYNIDM2N63GuobGrALS0VhO8f/0z364a74BGR80/ SJCgGUUV6mEk3wiuOUr7g9V65YdEtWxaOWZNENsmwuQ6M1in2KoPQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4669h1gquh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Apr 2025 13:11:42 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 53MD8NU4021598; Tue, 22 Apr 2025 13:11:41 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4669h1gque-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Apr 2025 13:11:41 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 53MBVFIR015384; Tue, 22 Apr 2025 13:11:40 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 464qnkjuh2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Apr 2025 13:11:34 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 53MDBV2X30933306 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 22 Apr 2025 13:11:31 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 60C1F20063; Tue, 22 Apr 2025 13:11:31 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E1BEE2005A; Tue, 22 Apr 2025 13:11:22 +0000 (GMT) Received: from li-c439904c-24ed-11b2-a85c-b284a6847472.ibm.com.com (unknown [9.43.58.77]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 22 Apr 2025 13:11:22 +0000 (GMT) From: Madhavan Srinivasan To: mpe@ellerman.id.au, christophe.leroy@csgroup.eu Cc: npiggin@gmail.com, naveen@kernel.org, linuxppc-dev@lists.ozlabs.org, Madhavan Srinivasan Subject: [PATCH 2/6] powerpc/xmon: fix sparse warning "Using plain integer as NULL pointer" Date: Tue, 22 Apr 2025 18:40:36 +0530 Message-ID: <20250422131040.374427-3-maddy@linux.ibm.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250422131040.374427-1-maddy@linux.ibm.com> References: <20250422131040.374427-1-maddy@linux.ibm.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=XvP6OUF9 c=1 sm=1 tr=0 ts=6807958e cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=XR8D0OoHHMoA:10 a=VnNF1IyMAAAA:8 a=UNBm9OSmSZM4mi4iOaMA:9 X-Proofpoint-GUID: uw37_B_TunWaBr8RWPKcMUGZnyOyCgoc X-Proofpoint-ORIG-GUID: sRMGyhe5q16wJSErP2YClIFwLb4rRKxV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-22_06,2025-04-21_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 suspectscore=0 spamscore=0 malwarescore=0 impostorscore=0 adultscore=0 mlxlogscore=444 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504220098 X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1 OzLabs 8 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org Fix passing of argument 0 to NULL to avoid sparse warning Cleans up sparse warning: arch/powerpc/xmon/ppc-opc.c:797:15: warning: Using plain integer as NULL pointer arch/powerpc/xmon/ppc-opc.c:797:18: warning: Using plain integer as NULL pointer arch/powerpc/xmon/ppc-opc.c:801:15: warning: Using plain integer as NULL pointer arch/powerpc/xmon/ppc-opc.c:801:18: warning: Using plain integer as NULL pointer arch/powerpc/xmon/ppc-opc.c:805:14: warning: Using plain integer as NULL pointer arch/powerpc/xmon/ppc-opc.c:805:17: warning: Using plain integer as NULL pointer arch/powerpc/xmon/ppc-opc.c:809:16: warning: Using plain integer as NULL pointer arch/powerpc/xmon/ppc-opc.c:809:19: warning: Using plain integer as NULL pointer arch/powerpc/xmon/ppc-opc.c:863:15: warning: Using plain integer as NULL pointer arch/powerpc/xmon/ppc-opc.c:863:18: warning: Using plain integer as NULL pointer arch/powerpc/xmon/ppc-opc.c:868:15: warning: Using plain integer as NULL pointer arch/powerpc/xmon/ppc-opc.c:868:18: warning: Using plain integer as NULL pointer arch/powerpc/xmon/ppc-opc.c:872:15: warning: Using plain integer as NULL pointer arch/powerpc/xmon/ppc-opc.c:872:18: warning: Using plain integer as NULL pointer arch/powerpc/xmon/ppc-opc.c:875:15: warning: Using plain integer as NULL pointer arch/powerpc/xmon/ppc-opc.c:875:18: warning: Using plain integer as NULL pointer arch/powerpc/xmon/ppc-opc.c:878:15: warning: Using plain integer as NULL pointer arch/powerpc/xmon/ppc-opc.c:878:18: warning: Using plain integer as NULL pointer arch/powerpc/xmon/ppc-opc.c:881:14: warning: Using plain integer as NULL pointer arch/powerpc/xmon/ppc-opc.c:881:17: warning: Using plain integer as NULL pointer Signed-off-by: Madhavan Srinivasan --- arch/powerpc/xmon/ppc-opc.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/arch/powerpc/xmon/ppc-opc.c b/arch/powerpc/xmon/ppc-opc.c index 0774d711453e..b4ca7eb8d765 100644 --- a/arch/powerpc/xmon/ppc-opc.c +++ b/arch/powerpc/xmon/ppc-opc.c @@ -794,19 +794,19 @@ const struct powerpc_operand powerpc_operands[] = #define PSWM WS + 1 /* The BO16 field in a BD8 form instruction. */ #define BO16 PSWM - { 0x1, 10, 0, 0, 0 }, + { 0x1, 10, NULL, NULL, 0 }, /* IDX bits for quantization in the pair singles instructions. */ #define PSQ PSWM + 1 - { 0x7, 12, 0, 0, 0 }, + { 0x7, 12, NULL, NULL, 0 }, /* IDX bits for quantization in the pair singles x-type instructions. */ #define PSQM PSQ + 1 - { 0x7, 7, 0, 0, 0 }, + { 0x7, 7, NULL, NULL, 0 }, /* Smaller D field for quantization in the pair singles instructions. */ #define PSD PSQM + 1 - { 0xfff, 0, 0, 0, PPC_OPERAND_PARENS | PPC_OPERAND_SIGNED }, + { 0xfff, 0, NULL, NULL, PPC_OPERAND_PARENS | PPC_OPERAND_SIGNED }, /* The L field in an mtmsrd or A form instruction or R or W in an X form. */ #define A_L PSD + 1 @@ -860,25 +860,25 @@ const struct powerpc_operand powerpc_operands[] = /* Xilinx APU related masks and macros */ #define FCRT XFL_L + 1 #define FCRT_MASK (0x1f << 21) - { 0x1f, 21, 0, 0, PPC_OPERAND_FCR }, + { 0x1f, 21, NULL, NULL, PPC_OPERAND_FCR }, /* Xilinx FSL related masks and macros */ #define FSL FCRT + 1 #define FSL_MASK (0x1f << 11) - { 0x1f, 11, 0, 0, PPC_OPERAND_FSL }, + { 0x1f, 11, NULL, NULL, PPC_OPERAND_FSL }, /* Xilinx UDI related masks and macros */ #define URT FSL + 1 - { 0x1f, 21, 0, 0, PPC_OPERAND_UDI }, + { 0x1f, 21, NULL, NULL, PPC_OPERAND_UDI }, #define URA URT + 1 - { 0x1f, 16, 0, 0, PPC_OPERAND_UDI }, + { 0x1f, 16, NULL, NULL, PPC_OPERAND_UDI }, #define URB URA + 1 - { 0x1f, 11, 0, 0, PPC_OPERAND_UDI }, + { 0x1f, 11, NULL, NULL, PPC_OPERAND_UDI }, #define URC URB + 1 - { 0x1f, 6, 0, 0, PPC_OPERAND_UDI }, + { 0x1f, 6, NULL, NULL, PPC_OPERAND_UDI }, /* The VLESIMM field in a D form instruction. */ #define VLESIMM URC + 1 From patchwork Tue Apr 22 13:10:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Madhavan Srinivasan X-Patchwork-Id: 2075369 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=rZLJWr65; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org; envelope-from=linuxppc-dev+bounces-7903-incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=patchwork.ozlabs.org) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4ZhjLQ0B0pz1yMy for ; Tue, 22 Apr 2025 23:11:42 +1000 (AEST) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4ZhjLg41S3z3c0n; Tue, 22 Apr 2025 23:11:55 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1745327515; cv=none; b=g2EC4ldrH8Anvds1QSXNnwDj2ccV4MSHYW81hgoXu3pO3DFkj32YC6rMkk/CobQoq5KVrnQjJb4jPdrrKvU4RC83qlO9NRYi3om9FjLBpVC77tRadVXL1Y3WWPlPDxM0sCEIN+xzYCJjWIgNMBsTx9xoXVw8TbhUAooE/qXyxq3QfnklFuMsm3XxEe6AgbA1Hg/XaUzMtkcl2tdSseOf1Z2teEK+w5jO60uzl6u1wdkZnwjC5hQZTp5EK9lcRZ4v1zAmNpEBRQFg45YMXn49DAao6tF6cYYpc2eg96o75/qL8+kYzP5FJzc2+WBTSUWnFjCBzkkAADXS/btJJnPEGQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1745327515; c=relaxed/relaxed; bh=YAJvx0cbiOoBz2Bbg2VR2VHgAKPnNinJBOSlulB7KS0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Fx86fT0/j3Zq5kGe0giUrV5FmsxLnB/KCFbWg3oFEU4dwvRbW/f2k7Qym+bLR5qrtoV1OBo9DG0KZr962L9iS/RxjUDFbPVI6pKjcRhtx4urwegG6/kOfYLMML9vHaeaL3kZebsAxldKZ6/2WmudMY+Iwc+1tcN9sdYZm03bPZnqxxijxV1R6Y+/vBK8Nw5LrUf004+3ft9bSAdW/SyAurtsYO9xKrb/ULaEfvGDiBM2OWgMZHUK2WhtfW7Vr6oGfXaZ3pNkFbLzW3XrzV4uiSO+8ibnd8WESSfMS1pzKgEXh9XuDPO9pQG5b8b4wD4PFQFzLCpZvQUO7SxrrEeDtw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=rZLJWr65; dkim-atps=neutral; spf=pass (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=maddy@linux.ibm.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=rZLJWr65; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=maddy@linux.ibm.com; receiver=lists.ozlabs.org) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4ZhjLf70Zhz304l for ; Tue, 22 Apr 2025 23:11:54 +1000 (AEST) Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53MD7OaI027680; Tue, 22 Apr 2025 13:11:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=YAJvx0cbiOoBz2Bbg 2VR2VHgAKPnNinJBOSlulB7KS0=; b=rZLJWr65syCS0ce568ynyzpIJII9ImQiX NCvO1P+PfloCrkMtUNfHu49xkHpYCzCLsjBxsgKggJR5e/4VuHwAulPk9mxHgZBY Obi2lce9c8KHgnQA5ErrOtmi96m+WcI8indh89ckJToPeUq6GGoJAqLadCRnBw55 ibfW4h7mkIK2s5JEFjypM81oVafLV/SpzN2FgVUg6Q0qVonE7vBHjq8KTJJhdk8Y mcoeIAmmuXMfweR1ofyEdFunMyC+fGsquBQ77D/JZvwih/vKprJ4PcmTrwsZ+lwA YJxlKTJtW1nbuxTKBPrLY7URcCRwfmNF2Oq3iAj2E0QpsIuzZjZsQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 466bq980kq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Apr 2025 13:11:42 +0000 (GMT) Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 53MDBg8O005837; Tue, 22 Apr 2025 13:11:42 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 466bq980kj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Apr 2025 13:11:42 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 53MAcj5X012501; Tue, 22 Apr 2025 13:11:41 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 464p5t362n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Apr 2025 13:11:41 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 53MDBdT151642718 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 22 Apr 2025 13:11:39 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 685BB20063; Tue, 22 Apr 2025 13:11:39 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5C6FB2004E; Tue, 22 Apr 2025 13:11:34 +0000 (GMT) Received: from li-c439904c-24ed-11b2-a85c-b284a6847472.ibm.com.com (unknown [9.43.58.77]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 22 Apr 2025 13:11:32 +0000 (GMT) From: Madhavan Srinivasan To: mpe@ellerman.id.au, christophe.leroy@csgroup.eu Cc: npiggin@gmail.com, naveen@kernel.org, linuxppc-dev@lists.ozlabs.org, Madhavan Srinivasan Subject: [PATCH 3/6] powerpc/perf:make isa207_pmu_format_group struct static Date: Tue, 22 Apr 2025 18:40:37 +0530 Message-ID: <20250422131040.374427-4-maddy@linux.ibm.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250422131040.374427-1-maddy@linux.ibm.com> References: <20250422131040.374427-1-maddy@linux.ibm.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: ARJxPHDwZZgtoRlVGZs91fKZ6r7pUzSm X-Proofpoint-GUID: C0VT57MTYKSaP1AWX0EG74YwKOj6PyaK X-Authority-Analysis: v=2.4 cv=cvabk04i c=1 sm=1 tr=0 ts=6807958e cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=XR8D0OoHHMoA:10 a=VnNF1IyMAAAA:8 a=vKaB1OlEhVtPGgZr2O4A:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-22_06,2025-04-21_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=836 priorityscore=1501 impostorscore=0 adultscore=0 suspectscore=0 spamscore=0 bulkscore=0 phishscore=0 mlxscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504220098 X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1 OzLabs 8 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org isa207_pmu_format_group struct is local to the source and does not need to be in global scope, so make it static Cleans up sparse warning: arch/powerpc/perf/isa207-common.c:40:30: warning: symbol 'isa207_pmu_format_group' was not declared. Should it be static? Signed-off-by: Madhavan Srinivasan --- arch/powerpc/perf/isa207-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/perf/isa207-common.c b/arch/powerpc/perf/isa207-common.c index 2b3547fdba4a..bbef51849f33 100644 --- a/arch/powerpc/perf/isa207-common.c +++ b/arch/powerpc/perf/isa207-common.c @@ -37,7 +37,7 @@ static struct attribute *isa207_pmu_format_attr[] = { NULL, }; -const struct attribute_group isa207_pmu_format_group = { +static const struct attribute_group isa207_pmu_format_group = { .name = "format", .attrs = isa207_pmu_format_attr, }; From patchwork Tue Apr 22 13:10:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Madhavan Srinivasan X-Patchwork-Id: 2075370 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=PCHACAQy; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=112.213.38.117; helo=lists.ozlabs.org; envelope-from=linuxppc-dev+bounces-7904-incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=patchwork.ozlabs.org) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4ZhjLW6Hl1z1yMy for ; Tue, 22 Apr 2025 23:11:47 +1000 (AEST) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4ZhjLs3F8Xz304l; Tue, 22 Apr 2025 23:12:05 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1745327525; cv=none; b=lZ5npBVVdi01DO8sdlShHeYJlIUzBHcvbwXfkYcTGyC85EVjdiXtM9cpZc1xnSx11zmwi0C3okORQw0B8rTVXVnTdGNIjzCJwq59eclzY5ofiaTWJv/Kx7QOuWoB+xHcuvlzPqbmEQT9IAISZyBJ228NJdp8UfatnWssNff8BOgug+VBBZitAkOVAtePbObxW8mTOZBSrXXKI9p0+mlg6zYXJnbPKJWg1TFsamtlKZj67IEyhs3HYSal7utUKfPrrqp5FdnATgbwJUcyEJoHinPNrDd+P18BULJbgPvYJbPFAslxyzGiWNfqkCf/WdCOLbpwE56fOWBniUDl77Tjlg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1745327525; c=relaxed/relaxed; bh=c1kNy0GSmEw/Ydk/Xd3fQyJ1OHmyG0uIQNET5zhgJ18=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cTViPxv4HbI/XZJXO6oXqbvIRCRt6wxOd32BRWEd6XZa4GkBYX1VGV1Sd9pRjAuDbhq/XGfzYaT+AE/1JTD+CpORRMKGNaq9pV+ujv3Em1S4h9VfLKOzBMxQE/7cjKV9xKYkEg0VDKFYJNyIRqIQgqyDgVLTWj0tIZwxsg6YzK3kpK5nwG59Jb5IsbP5QuXm7ZGXyjNvpM1B0Dme6GiGj8dDm/tPEL0GdvI2rU0frMXzhKBeJXXARUOlQel+x9JWTyTw6KkEUg4su90eyMNaTrJ+5XkBdFmNk5eRpjnm1/yct2ewXx1ne/Ia5Od+QpPrDsojMa2ZeS7sWnDxlBknwg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=PCHACAQy; dkim-atps=neutral; spf=pass (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=maddy@linux.ibm.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=PCHACAQy; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=maddy@linux.ibm.com; receiver=lists.ozlabs.org) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4ZhjLr4PKSz3bsT for ; Tue, 22 Apr 2025 23:12:04 +1000 (AEST) Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53MC63uY026863; Tue, 22 Apr 2025 13:11:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=c1kNy0GSmEw/Ydk/X d3fQyJ1OHmyG0uIQNET5zhgJ18=; b=PCHACAQydOEZe6Dn8V/bQ7wsT9D5wp3aq WqLDT6saeSt7aeJT8dqLMayViXBs4SMvAHwjuSq4j/iaE/Xn7ftN5yOXvMGCfh2T Cn1CiB3RrGM+Gz+9+2JtN2gZ/ijmxteSNf25jMXt4i9UR5RK8+kemxCH9EQ19g2G 44ImhVXHKz74mHNIsoRkqaqi4WC9RgRQKeSkDU1LUK18vC4TKcdvvrOvwoorSOgP 2LZooS4u7wWuiSy/YPnvJYvMBN1PMVl9ylIyqQ9xPXlW79gxXPtiOJxr33jXvsDO 1FoNdKCoTuICwEFQmPloCzzUU4TTZTBIZk2pfr8T+095GppQuBL+w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4669jrrp4b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Apr 2025 13:11:50 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 53MDA4Sg001876; Tue, 22 Apr 2025 13:11:50 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4669jrrp49-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Apr 2025 13:11:49 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 53MB6BoF002953; Tue, 22 Apr 2025 13:11:49 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 464q5njy3m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Apr 2025 13:11:49 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 53MDBloS59703722 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 22 Apr 2025 13:11:47 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 295A82004F; Tue, 22 Apr 2025 13:11:47 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 584FD20040; Tue, 22 Apr 2025 13:11:41 +0000 (GMT) Received: from li-c439904c-24ed-11b2-a85c-b284a6847472.ibm.com.com (unknown [9.43.58.77]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 22 Apr 2025 13:11:40 +0000 (GMT) From: Madhavan Srinivasan To: mpe@ellerman.id.au, christophe.leroy@csgroup.eu Cc: npiggin@gmail.com, naveen@kernel.org, linuxppc-dev@lists.ozlabs.org, Madhavan Srinivasan Subject: [PATCH 4/6] powerpc: fix sparse warnings Date: Tue, 22 Apr 2025 18:40:38 +0530 Message-ID: <20250422131040.374427-5-maddy@linux.ibm.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250422131040.374427-1-maddy@linux.ibm.com> References: <20250422131040.374427-1-maddy@linux.ibm.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 2RaJtv_KGYNgy_eOs0qcwtnho8YK8FBt X-Authority-Analysis: v=2.4 cv=f8RIBPyM c=1 sm=1 tr=0 ts=68079596 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=XR8D0OoHHMoA:10 a=VnNF1IyMAAAA:8 a=zO_7FImU_Rab3inkQ04A:9 X-Proofpoint-GUID: cN5hnu70KGGOdpCVJLTFmDuzKHyu6lVr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-22_06,2025-04-21_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 phishscore=0 clxscore=1015 mlxscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504220098 X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1 OzLabs 8 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org structs are local to the source and does not need to be in global scope, so make it static. Signed-off-by: Madhavan Srinivasan --- arch/powerpc/kernel/btext.c | 2 +- arch/powerpc/kernel/setup-common.c | 2 +- arch/powerpc/platforms/powernv/opal.c | 2 +- arch/powerpc/platforms/pseries/lparcfg.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/kernel/btext.c b/arch/powerpc/kernel/btext.c index 7f63f1cdc6c3..fc7f5a5b6d76 100644 --- a/arch/powerpc/kernel/btext.c +++ b/arch/powerpc/kernel/btext.c @@ -40,7 +40,7 @@ static int dispDeviceRect[4] __force_data; static unsigned char *dispDeviceBase __force_data; static unsigned char *logicalDisplayBase __force_data; -unsigned long disp_BAT[2] __initdata = {0, 0}; +static unsigned long disp_BAT[2] __initdata = {0, 0}; static int boot_text_mapped __force_data; diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c index 68d47c53876c..649e0cc31df7 100644 --- a/arch/powerpc/kernel/setup-common.c +++ b/arch/powerpc/kernel/setup-common.c @@ -350,7 +350,7 @@ static void c_stop(struct seq_file *m, void *v) { } -const struct seq_operations cpuinfo_op = { +static const struct seq_operations cpuinfo_op = { .start = c_start, .next = c_next, .stop = c_stop, diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c index 9ec265fcaff4..02af50a724bf 100644 --- a/arch/powerpc/platforms/powernv/opal.c +++ b/arch/powerpc/platforms/powernv/opal.c @@ -48,7 +48,7 @@ static LIST_HEAD(msg_list); /* /sys/firmware/opal */ struct kobject *opal_kobj; -struct opal { +static struct opal { u64 base; u64 entry; u64 size; diff --git a/arch/powerpc/platforms/pseries/lparcfg.c b/arch/powerpc/platforms/pseries/lparcfg.c index cc22924f159f..830af843ef40 100644 --- a/arch/powerpc/platforms/pseries/lparcfg.c +++ b/arch/powerpc/platforms/pseries/lparcfg.c @@ -185,7 +185,7 @@ static long h_pic(unsigned long *pool_idle_time, return rc; } -unsigned long boot_pool_idle_time; +static unsigned long boot_pool_idle_time; /* * parse_ppp_data From patchwork Tue Apr 22 13:10:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Madhavan Srinivasan X-Patchwork-Id: 2075371 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=rcXaxnAc; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org; envelope-from=linuxppc-dev+bounces-7905-incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=patchwork.ozlabs.org) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4ZhjLl3Kyfz1yMy for ; Tue, 22 Apr 2025 23:11:59 +1000 (AEST) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4ZhjM50HKXz3btX; Tue, 22 Apr 2025 23:12:17 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1745327536; cv=none; b=KyOT/uq6Rs/T8NTTTxY17FErEQ/kA+a1uLiFYUYM3vEWMVJIxHO7Ig6+iK4zWclJ6cE0+mjaPWLT26Tv4FU05tOUbz0PUsm5EeEAP3M0mMvWUvKM03VQKafx8CFI7cIjr/dORXSnwGtyFJ9TVTi97gdxoh5QYDv48Melvt4m7JIOy3uqQg3ZnvK5XQm798VHykKMFOv85lFW5Raj/FXZuiKgrs6Ln7/IJLSGO9Ap6Q8Fg+nVkYqdJOb1wYp8AGoF2UevkAHWptOaANyThoRv0bQHi8eiaHcq0B67ukP7r01MbcAqbSBBylJpMPnUdr1JFKWAuafxRONTvtvlP7HGzw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1745327536; c=relaxed/relaxed; bh=3ENofPg0Le02klO2BBkBWkjf+BlKtztwPU+SXxF2wrU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZiA1WO/9n/kcp8vCOJwWPn3Q6jfQ6fxaMV8GPbqh6Crfb3HghweqmbmVTHXhBV9UOg2KBME+kcVSA23ZfrU/CAPxPm31P+wMe26p9RKn6LWR/ZmRzZosKNihGvx77wl27WWj4mTYwBXVW3Yyre93YrlthjUAyGX6mXi8xRhW5IGYLF2I9KKCHnAephsU34dSqcYqrhCNtczMaDQcyjbBqoDrKJEeAxErTSLAHuiaOfJ8mQ+JNAC1eUKwDreuVIzW1lfhoDc6TBdHLf7QWWNxiyARePq6DHpXbL4XDj3rV0SdzEEo6XcRShm7I8ubBzqODA6qwooRjJDtDGLEhgqL2g== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=rcXaxnAc; dkim-atps=neutral; spf=pass (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=maddy@linux.ibm.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=rcXaxnAc; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=maddy@linux.ibm.com; receiver=lists.ozlabs.org) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4ZhjM41pJHz3bsT for ; Tue, 22 Apr 2025 23:12:16 +1000 (AEST) Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53MC63pt026790; Tue, 22 Apr 2025 13:12:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=3ENofPg0Le02klO2B BkBWkjf+BlKtztwPU+SXxF2wrU=; b=rcXaxnAc9VMhOwJk4AlzB5gEnXfi15jy0 raNunw/nhp3urCO58qE5R2ML9h2SFyD1t14XmExav21oZBsIJVw273iDXw8qUxcA Z4bJA2lVCQhQfJi5Cz6km9IF122WR4JkIS4tuR2o5Ne61+plz7/IqwFgoF/IMKAw R31fjVIUAWoy6FROtW/Y9/Or+zdMVI5g6qtUZdLWWudO4DaMP+rddvDKEVCnZQi7 ByJu8GU6hCXtnPgQYNjJRP4pz0HI2eaXAvG77/jsPuN2hDtGLArM4N6pcD+TZ9ZW RUbL7LuxTAzWZp5VD+YRPMnhX+zTGuXXEp0kUphXoavbySwaup/AQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4669jrrp5s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Apr 2025 13:12:05 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 53MDAMDe002227; Tue, 22 Apr 2025 13:12:04 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4669jrrp5n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Apr 2025 13:12:04 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 53MCOV0U001791; Tue, 22 Apr 2025 13:12:03 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 464rck2qvn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Apr 2025 13:12:03 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 53MDC2B332375472 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 22 Apr 2025 13:12:02 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 04B6F20067; Tue, 22 Apr 2025 13:12:02 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9AE0520040; Tue, 22 Apr 2025 13:11:51 +0000 (GMT) Received: from li-c439904c-24ed-11b2-a85c-b284a6847472.ibm.com.com (unknown [9.43.58.77]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 22 Apr 2025 13:11:51 +0000 (GMT) From: Madhavan Srinivasan To: mpe@ellerman.id.au, christophe.leroy@csgroup.eu Cc: npiggin@gmail.com, naveen@kernel.org, linuxppc-dev@lists.ozlabs.org, Madhavan Srinivasan Subject: [PATCH 5/6] powerpc/prom_init: Fix shellcheck warnings Date: Tue, 22 Apr 2025 18:40:39 +0530 Message-ID: <20250422131040.374427-6-maddy@linux.ibm.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250422131040.374427-1-maddy@linux.ibm.com> References: <20250422131040.374427-1-maddy@linux.ibm.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: -2pMI8VWi5f53vbjTJjocScPg0UZC8ZR X-Authority-Analysis: v=2.4 cv=f8RIBPyM c=1 sm=1 tr=0 ts=680795a5 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=XR8D0OoHHMoA:10 a=VnNF1IyMAAAA:8 a=ksR2oIC-PuAIPJEDuLAA:9 X-Proofpoint-GUID: orV2tOJ4bPljQC9T6wxqEf9Gq8lTmXWq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-22_06,2025-04-21_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 mlxlogscore=908 suspectscore=0 phishscore=0 clxscore=1015 mlxscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504220098 X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1 OzLabs 8 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org Fix "Double quote to prevent globbing and word splitting." warning from shellcheck Signed-off-by: Madhavan Srinivasan Reviewed-by: Stephen Rothwell --- arch/powerpc/kernel/prom_init_check.sh | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/powerpc/kernel/prom_init_check.sh b/arch/powerpc/kernel/prom_init_check.sh index 69623b9045d5..3090b97258ae 100644 --- a/arch/powerpc/kernel/prom_init_check.sh +++ b/arch/powerpc/kernel/prom_init_check.sh @@ -15,8 +15,8 @@ has_renamed_memintrinsics() { - grep -q "^CONFIG_KASAN=y$" ${KCONFIG_CONFIG} && \ - ! grep -q "^CONFIG_CC_HAS_KASAN_MEMINTRINSIC_PREFIX=y" ${KCONFIG_CONFIG} + grep -q "^CONFIG_KASAN=y$" "${KCONFIG_CONFIG}" && \ + ! grep -q "^CONFIG_CC_HAS_KASAN_MEMINTRINSIC_PREFIX=y" "${KCONFIG_CONFIG}" } if has_renamed_memintrinsics @@ -42,15 +42,15 @@ check_section() { file=$1 section=$2 - size=$(objdump -h -j $section $file 2>/dev/null | awk "\$2 == \"$section\" {print \$3}") + size=$(objdump -h -j "$section" "$file" 2>/dev/null | awk "\$2 == \"$section\" {print \$3}") size=${size:-0} - if [ $size -ne 0 ]; then + if [ "$size" -ne 0 ]; then ERROR=1 echo "Error: Section $section not empty in prom_init.c" >&2 fi } -for UNDEF in $($NM -u $OBJ | awk '{print $2}') +for UNDEF in $($NM -u "$OBJ" | awk '{print $2}') do # On 64-bit nm gives us the function descriptors, which have # a leading . on the name, so strip it off here. @@ -87,8 +87,8 @@ do fi done -check_section $OBJ .data -check_section $OBJ .bss -check_section $OBJ .init.data +check_section "$OBJ" .data +check_section "$OBJ" .bss +check_section "$OBJ" .init.data exit $ERROR From patchwork Tue Apr 22 13:10:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Madhavan Srinivasan X-Patchwork-Id: 2075372 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=dAoe6Bvl; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=112.213.38.117; helo=lists.ozlabs.org; envelope-from=linuxppc-dev+bounces-7906-incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=patchwork.ozlabs.org) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4ZhjLy0qQzz1yMy for ; Tue, 22 Apr 2025 23:12:09 +1000 (AEST) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4ZhjMH3Zxwz3bxL; Tue, 22 Apr 2025 23:12:27 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1745327547; cv=none; b=B3mGpYSFEEuKyJc6yJhIBi6OH5RTg+FWHoCSzWefJ65Cawx6M5P+mgh+V673FXjtCAZgeh6RoIxsWFoUAa+EN+rQFWcbQg67NrOS35fi7LLpxilPf9a4wjUg7qMsDQLEfsWRvULhDLHEkl/BXhZPNk/0PpJ1bTiGqkTBlf1/ovLVHmolv2GREMAZEGhMosWrOD+u9uBbgZ7k3Z8wLH2PGYmx1LRRo4m7VCRH80ZWe5It9HUzTiFKbTMKbI5flOiHVgAVYnAbr2vxkl8M8OuB5znulUxXb7hhBflJYH5HWQFSQnli0epxpQ99wvJ+LbB2ugwiaaXNG827cS+AoddD+A== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1745327547; c=relaxed/relaxed; bh=+4+wg2+6hIV1YuYSGh4g4k6eBwnWt6hvzeqg+9ZPuyA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TVdE+FD+45wEQmkbuWCq6uuHwHGMZqJw+FxuUXfgchp/dsOwhLiQ13NdkeGROFyFyndpWCDk6WUE3nOyuo7yMAVzBE85XGUm8J5nDGE5o6ibKPRfvqjBbTNGKr9q2w4MTwlJqm65AG2joqv4kgVnWO3/47N+XOZGxo2vxaQ9sk0q0j9glYlwNEvAy55iQBvxIsadxNp3jlAMv0GA+iVbEpfLIWC67vKlegX6YZfSI2UT5Y5+9suCdsKA9tQbe2+ld82KLFqExe8nrHFYl5YLuMc+ATOWc+s6Og9QoXEN5crE2vDROMW4AxcZbCHOd195V4i+FItSH77qdbt8WQP5+A== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=dAoe6Bvl; dkim-atps=neutral; spf=pass (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=maddy@linux.ibm.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=dAoe6Bvl; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=maddy@linux.ibm.com; receiver=lists.ozlabs.org) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4ZhjMG5jxLz3bsT for ; Tue, 22 Apr 2025 23:12:26 +1000 (AEST) Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53MA3rTF025939; Tue, 22 Apr 2025 13:12:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=+4+wg2+6hIV1YuYSG h4g4k6eBwnWt6hvzeqg+9ZPuyA=; b=dAoe6Bvl7/xqR1rvBuOunoqCkwlP1T3Xf QR6+xUsG3eiW83dlhlCYJQxPTVP4w1yxofX1/Macpd4WbAC3EqBqq6KlrF+jGCRG ZM4j/3iEenfoP7FtmgNRIm1XUIgtFe1M7rryK3QSuvx9d967mwfw15q4OePo5jCQ QzqQMML4qSU67Nr07ecBRjA9IQ4bW8nxoK+oM7NpknhHguHTBWNUW6p51Vh6FoPl DmV24ZyAVL9cuvsqJLxiHw3RSR7iVoPUn7oe9/P2OY/m72mzHhDJYjF4pQolUD1t ys1pf9ME56WkddtYH7L1p4sjSvoHZ7jZpxN7I5bsD0ocVUub56bCw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46691hgv11-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Apr 2025 13:12:14 +0000 (GMT) Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 53MD7hP2000360; Tue, 22 Apr 2025 13:12:13 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46691hgv0v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Apr 2025 13:12:13 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 53MB99kE002954; Tue, 22 Apr 2025 13:12:12 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 464q5njy4y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Apr 2025 13:12:12 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 53MDCAlU50659656 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 22 Apr 2025 13:12:10 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 656212006B; Tue, 22 Apr 2025 13:12:10 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 63C1520040; Tue, 22 Apr 2025 13:12:05 +0000 (GMT) Received: from li-c439904c-24ed-11b2-a85c-b284a6847472.ibm.com.com (unknown [9.43.58.77]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 22 Apr 2025 13:12:03 +0000 (GMT) From: Madhavan Srinivasan To: mpe@ellerman.id.au, christophe.leroy@csgroup.eu Cc: npiggin@gmail.com, naveen@kernel.org, linuxppc-dev@lists.ozlabs.org, Madhavan Srinivasan Subject: [PATCH 6/6] powerpc/boot/install.sh: Fix shellcheck warnings Date: Tue, 22 Apr 2025 18:40:40 +0530 Message-ID: <20250422131040.374427-7-maddy@linux.ibm.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250422131040.374427-1-maddy@linux.ibm.com> References: <20250422131040.374427-1-maddy@linux.ibm.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=V7h90fni c=1 sm=1 tr=0 ts=680795ae cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=XR8D0OoHHMoA:10 a=VnNF1IyMAAAA:8 a=3dc1HHkJaZI8_K3iZDcA:9 X-Proofpoint-ORIG-GUID: XLMMcrqaTx6GfUavkDv5G-i8xHlvbCXs X-Proofpoint-GUID: whZLM65DjEXfZlhIVP4JaQ9X5m2a7dHS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-22_06,2025-04-21_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 clxscore=1015 mlxlogscore=981 bulkscore=0 phishscore=0 lowpriorityscore=0 impostorscore=0 mlxscore=0 malwarescore=0 adultscore=0 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504220098 X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1 OzLabs 8 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org Fix shellcheck warning such as "Double quote to prevent globbing and word splitting." and Use $(...) notation instead of legacy backticks `...`. Signed-off-by: Madhavan Srinivasan --- arch/powerpc/boot/install.sh | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/boot/install.sh b/arch/powerpc/boot/install.sh index 101fcb397a0f..c3df6c27ce75 100755 --- a/arch/powerpc/boot/install.sh +++ b/arch/powerpc/boot/install.sh @@ -19,19 +19,19 @@ set -e # this should work for both the pSeries zImage and the iSeries vmlinux.sm -image_name=`basename $2` +image_name=$(basename "$2") echo "Warning: '${INSTALLKERNEL}' command not available... Copying" \ "directly to $4/$image_name-$1" >&2 -if [ -f $4/$image_name-$1 ]; then - mv $4/$image_name-$1 $4/$image_name-$1.old +if [ -f "$4"/"$image_name"-"$1" ]; then + mv "$4"/"$image_name"-"$1" "$4"/"$image_name"-"$1".old fi -if [ -f $4/System.map-$1 ]; then - mv $4/System.map-$1 $4/System-$1.old +if [ -f "$4"/System.map-"$1" ]; then + mv "$4"/System.map-"$1" "$4"/System-"$1".old fi -cat $2 > $4/$image_name-$1 -cp $3 $4/System.map-$1 +cat "$2" > "$4"/"$image_name"-"$1" +cp "$3" "$4"/System.map-"$1"