From patchwork Thu Apr 10 20:16:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 2071198 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4ZYWWm4nx0z1yHq for ; Fri, 11 Apr 2025 06:24:52 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1u2ySQ-0005Uq-C3; Thu, 10 Apr 2025 20:25:06 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1u2ySP-0005UW-7Y for fwts-devel@lists.ubuntu.com; Thu, 10 Apr 2025 20:25:05 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 8582DA4AA25; Thu, 10 Apr 2025 20:11:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A886C4CEDD; Thu, 10 Apr 2025 20:16:50 +0000 (UTC) From: Mario Limonciello To: fwts-devel@lists.ubuntu.com Subject: [PATCH 1/2] cpu/msr: Drop `VM_HSAVE_PA` from consistency checks Date: Thu, 10 Apr 2025 15:16:29 -0500 Message-ID: <20250410201630.2996785-1-superm1@kernel.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Received-SPF: pass client-ip=147.75.193.91; envelope-from=superm1@kernel.org; helo=nyc.source.kernel.org X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mario Limonciello Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" From: Mario Limonciello `VM_HSAVE_PA` is the physical address of the host save area which is written by the kernel not the BIOS. It is expected to be different for different CPUs. Signed-off-by: Mario Limonciello Acked-by: Ivan Hu --- src/cpu/msr/msr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/cpu/msr/msr.c b/src/cpu/msr/msr.c index 1d475aaf..15654eac 100644 --- a/src/cpu/msr/msr.c +++ b/src/cpu/msr/msr.c @@ -333,7 +333,6 @@ static const msr_info AMD_MSRs[] = { { "VM_CR", 0xc0010114, 0xffffffffffffffffULL, NULL }, { "IGNNE", 0xc0010115, 0xffffffffffffffffULL, NULL }, { "SMM_CTL", 0xc0010116, 0xffffffffffffffffULL, NULL }, - { "VM_HSAVE_PA", 0xc0010117, 0xffffffffffffffffULL, NULL }, { "SVM_KEY_MSR", 0xc0010118, 0xffffffffffffffffULL, NULL }, { "OSVW_ID_Length", 0xc0010140, 0xffffffffffffffffULL, NULL }, { NULL, 0x00000000, 0, NULL } From patchwork Thu Apr 10 20:16:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 2071197 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4ZYWWB3CBHz1yJV for ; Fri, 11 Apr 2025 06:24:21 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1u2yRr-0005MN-U8; Thu, 10 Apr 2025 20:24:31 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1u2yRq-0005MB-AA for fwts-devel@lists.ubuntu.com; Thu, 10 Apr 2025 20:24:30 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9F9B45C6231; Thu, 10 Apr 2025 20:14:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E953C4CEE9; Thu, 10 Apr 2025 20:16:50 +0000 (UTC) From: Mario Limonciello To: fwts-devel@lists.ubuntu.com Subject: [PATCH 2/2] cpu: virt: Downgrade message about virtualization disabled Date: Thu, 10 Apr 2025 15:16:30 -0500 Message-ID: <20250410201630.2996785-2-superm1@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250410201630.2996785-1-superm1@kernel.org> References: <20250410201630.2996785-1-superm1@kernel.org> MIME-Version: 1.0 Received-SPF: pass client-ip=139.178.84.217; envelope-from=superm1@kernel.org; helo=dfw.source.kernel.org X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mario Limonciello Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" From: Mario Limonciello Modern machines that ship with Microsoft Security Levels enabled will lock down SVM. This is by design, so decrease existing failure to 'advice' instead. Signed-off-by: Mario Limonciello --- src/cpu/virt/virt_svm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/cpu/virt/virt_svm.c b/src/cpu/virt/virt_svm.c index d86f54f4..8cee9aaf 100644 --- a/src/cpu/virt/virt_svm.c +++ b/src/cpu/virt/virt_svm.c @@ -77,9 +77,7 @@ void virt_check_svm(fwts_framework *fw) fwts_passed(fw, "Virtualization extensions supported and enabled by BIOS."); break; case 1: - fwts_failed(fw, LOG_LEVEL_MEDIUM, - "VirtDisabledByBIOS", - "Virtualization extensions supported but disabled by BIOS."); + fwts_advice(fw, "Virtualization extensions supported but disabled by BIOS."); break; default: fwts_log_error(fw, "Virtualization extensions check failed - cannot read msr.");