From patchwork Tue May 15 17:11:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: smtpuser X-Patchwork-Id: 913830 X-Patchwork-Delegate: boris.brezillon@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=allied-telesis.co.jp Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ArHQG/+4"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=atjp.onmicrosoft.com header.i=@atjp.onmicrosoft.com header.b="UWTVAei2"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40lkfG3NxBz9ryk for ; Wed, 16 May 2018 03:12:54 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NNiB5Yqh+H48lAlpePyy+LqFdok0QcMfulHLI5wKw0A=; b=ArHQG/+4GBw08M 0/5UqcLhP9lRGKJ+4ydiDZvXjDj/UYQmdgjOY2AWC+kLdDCn86ccwIauk2un6/GGHoKABDB3XMFt5 Y4MnvDNw8BhhaehKqIfgi9nxfGZZ6XJOTkfl5ZiCJjfpJBNr7GwApqrh+eguXJtIz1rdRUiwlcY7/ co21mq1eRGRVSobIkGnnrpQUnTvhRIRNJRpQ/FG0HaeWrwG2Hn9P6bZ5H0NazWeV47QCaOXmZA6KI I6488RGy0rAnJnzZPLOER2KpKnNeHCYwktts+W0SetkgyofrcUimqnbbTAjQGHbAJ18a9xKASiZrw i/NkOK+juJZOT7t8HH2A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fIdVD-0000z6-O5; Tue, 15 May 2018 17:12:43 +0000 Received: from mail1.bemta8.messagelabs.com ([216.82.243.201]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fIdUY-0000eL-Bi for linux-mtd@lists.infradead.org; Tue, 15 May 2018 17:12:04 +0000 Received: from [216.82.242.46] (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256 bits)) by server-9.bemta-8.messagelabs.com id 74/DC-15733-7D41BFA5; Tue, 15 May 2018 17:11:51 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA1WSa0hTYRjH9+6cuaPs2HEzfFpZOehmKVp9ECS wvmRBIBhdhqBnenKrbco5s1ZCMy9gZmiUpqKYJOINwrthWmrDZmZ4yRTzllKmJeiXYqtsZ2da ffs//P7P8/zfl4fA5GsSJcGYTQxrpPUqDy/86Is8Jui9r0MdMlIoC+tIr5JGoMimSksUUkt0R k2SOU6ibcq0eiSveJtnBwaxNDQky0FehJzKRvBrph3LQZ4EUKkw+jJbzAOgKsXwbjlbKrjaMf jybMBV4FQeBqvjnVK+BVGxMPOx2+1KF0Pxh3ZcKMoQrK80S4TCjiBjtRXnWzyoYBid++TSvlQ o1BRkujowqhuD2Sk74oGCugA9+fmuWDi1B6aLJjxyEEGQ1HGYs0ULaXdB79d0Ca89qRNQOlXm 0nKnZXkkQyJ4oiGn8pWY1yTlA7biBddejALoXlx0vzoAfmdNSAX9AMF4+XZB+4P1TSku/EYbg nnbc3dxSwrN9hEkuAKh0G51T3oqheHPewWth7auCrcnBnpbf7g9O6H/7qD7j2sxqH/SKM5HIS X/JCz5J+EjJK5F+zmGvcqwQYePBGtYXaLWZKB1+qDQkLBgA8NxdCKjpzVccHySoRE5b8EiEqF 2VNRxsgdtI8SqrWT4T7ta7q1JSriupTltLJuiZ7getIMgVEBOKhxquQ/LJDLmSzq986A2MBAy lS/ZymOSS6YNnC5RQP0oQOlH1vCA4oE2xbjZtnGKw8hfqSCRSCSSy5IZ1qAz/c+XkB+BVApyi p8i0xlNm9OXnIvFzsVs/3d+sYn+i5RpKPtxhfzcfFdqp0mdaVy8GRp/zNAz4mXtKx+6Me0pGV 1aa/6GsbnKSUvVxLT5fJ1XK37mSp2SO1To6GuofT2jqH5ruHwq3xIzlubA95WdjT6QZrwfb9+ tBsP6nerc+paisYaLqsHxuCyjLaI34fTte9agh1F0ZPgCebC25dqWAhXOaenQQIzl6D/fX4MY hQMAAA== X-Env-Sender: smtpuser@allied-telesis.co.jp X-Msg-Ref: server-4.tower-96.messagelabs.com!1526404308!102097408!2 X-Originating-IP: [52.192.143.101] X-SYMC-ESS-Client-Auth: outbound-route-from=pass X-StarScan-Received: X-StarScan-Version: 9.9.15; banners=-,-,- X-VirusChecked: Checked Received: (qmail 24986 invoked from network); 15 May 2018 17:11:50 -0000 Received: from mo.allied-telesis-co-jp.hdemail.jp (HELO mo.allied-telesis-co-jp.hdemail.jp) (52.192.143.101) by server-4.tower-96.messagelabs.com with SMTP; 15 May 2018 17:11:50 -0000 Received: by mo.allied-telesis-co-jp.hdemail.jp (hde-mf-postfix, from userid 504) id 4FA7F294005; Wed, 16 May 2018 02:11:50 +0900 (JST) X-Received: from unknown (HELO mo.allied-telesis-co-jp.hdemail.jp) (127.0.0.1) by 0 with SMTP; 16 May 2018 02:11:49 +0900 X-Received: from mo.allied-telesis-co-jp.hdemail.jp (localhost.localdomain [127.0.0.1]) by mo.allied-telesis-co-jp.hdemail.jp (hde-ma-postfix) with ESMTP id CC1601AC001 for ; Wed, 16 May 2018 02:11:49 +0900 (JST) (envelope-from smtpuser@allied-telesis.co.jp) Received: from JPN01-OS2-obe.outbound.protection.outlook.com (mail-os2jpn01lp0148.outbound.protection.outlook.com [23.103.139.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mo.allied-telesis-co-jp.hdemail.jp (hde-mf-postfix) with ESMTPS id A13FC294004 for ; Wed, 16 May 2018 02:11:49 +0900 (JST) (envelope-from smtpuser@allied-telesis.co.jp) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atjp.onmicrosoft.com; s=selector1-alliedtelesis-co-jp01e; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=t9S84URM1b6TL/lowQSSLtjtAoDtkRnIrxcvv32B6Ls=; b=UWTVAei2H9PrsaUbXUrdxmPcINGf8bw+llk+5mjRgc1yWklgvRC4ZvCvkFr+/hR2PTFZImEJMK1ZJJiuIAZi0QcVizl2pnGFJZxp7kX8jTg4+lguXJIAOljJWUuBXU7/sJYVGuMhfRVZj4PzD+ZZV8/6n4WTTFsrapUzTgR9SAo= Received: from TKY-DS01.at.lc (150.87.248.20) by TY1PR01MB1280.jpnprd01.prod.outlook.com (2603:1096:402:5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Tue, 15 May 2018 17:11:48 +0000 Received: from swim-manx.rd.allied-telesis.co.jp ([150.87.21.50]) by TKY-DS01.at.lc with Microsoft SMTPSVC(8.0.9200.16384); Wed, 16 May 2018 02:11:47 +0900 Received: from ikegami-pc.rd.allied-telesis.co.jp by swim-manx.rd.allied-telesis.co.jp (AlliedTelesis SMTPRS 1.3 pl 1 ++E6B86F8C687C6288D9B5559052954DC9) with ESMTP id ; Wed, 16 May 2018 02:11:47 +0900 From: smtpuser To: Boris Brezillon Subject: [PATCH v6 1/5] mtd: cfi_cmdset_0002: Change write buffer to check correct value Date: Wed, 16 May 2018 02:11:16 +0900 Message-Id: <20180515171120.5629-2-smtpuser@allied-telesis.co.jp> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180515171120.5629-1-smtpuser@allied-telesis.co.jp> References: <20180515171120.5629-1-smtpuser@allied-telesis.co.jp> X-OriginalArrivalTime: 15 May 2018 17:11:47.0323 (UTC) FILETIME=[CE75D4B0:01D3EC6F] MIME-Version: 1.0 X-Originating-IP: [150.87.248.20] X-ClientProxiedBy: TYAPR03CA0011.apcprd03.prod.outlook.com (2603:1096:404:14::23) To TY1PR01MB1280.jpnprd01.prod.outlook.com (2603:1096:402:5::19) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:TY1PR01MB1280; X-Microsoft-Exchange-Diagnostics: 1; TY1PR01MB1280; 3:EfqQNH2l8wWfwU8nFZ0NOk3TAxioDDDEkkFqjjtLCKsUsL+5m+i5+nFsOAk0AEXcVMc0ziPWMhILohcwPq1brbXCMyqKfVbQeSQvWWqnNIzhfdODUAC7rn54lailVcD8xfHckvs+LrscWsLfZFJfMOV+1XUcROkhIK97z0/eelNkCOKPzBcJ0bMUdleDqQn86443FvorvCAXEZO58EhmPS8ASydXJhNR/1tRZcFUgFZ/JUhHHztaqUk5X9JhY3Rd; 25:d2vdraKW4Pvd3+FNaEVYhFayCe8DkgXbzlie2eC1XrNsOtb6QYBhLYbMwQ3BhDvxaRFOBkNnD+1EUQVYQ7aX8u7JFwWSgAr2MK5XlNJx2bxX/ofVSF5iDz4kbfkLE6LtH+lIA7mNBKrVyXwcndHggsespEnYxDO4UW3NIOixldSLO6REBZrnE/zDwq9zcUF5xfQ6JiAdSazn5S3vowh02UoGfwzRqzbbu/w4eaq3ttuavFysEGsASOcofaNlWBdhZe40S2r+QE86poh0kfU2dv3gkPRtQa/kVgzn7CMt1ykl+rBy34WQxkfeHMGS38bcMrTBtLP2uypCJAlFPl9pjQ==; 31:1NRxBfLF1Go7hzCZPuGNm427ayaDhcscfpaU1AJSTN2xQ+q93EJ7ocXXt65BrGkEGiziiRzvXmLU23rsaHcTHcwxQMao1bMUEkAuBaqSq6mZlREKIkmzaJR2f9WX+eiCeh5Z+HoJNNvGtBSQ3Gq7wipRUrWdHbngaWYtoRko3e/AsrZmkLF+5Vn9eYfRB58/2amXlDF0lGD2E+lTzGsRHqQS5bLxHMIN6ukY++A4ZDM= X-MS-TrafficTypeDiagnostic: TY1PR01MB1280: X-Microsoft-Exchange-Diagnostics: 1; TY1PR01MB1280; 20:2HP6Xjb0YiHsd5xDpx4hrA94yiZN/+UU4bR6vGlq+eGPt9vZnkIgj+aI5hGaeZHPixJ/HZO1mYO85iuknBVAne4fnzlRsCR6s2aMyFldCN8r5gXF8q0fugpOVGcITV0EEBGz6+ZFMPrf7BlTUSKJgY+dWrrV1IXmlvcOSwYEH7v+UWPTqjjjPanbFEGEOJplDNmupKnN+up1WETLKVK8GB6UqoVT/CggTyxap5W/1joGY9o9DCFK4CqcqoU0unZHiD26z90sGbT9nVIxXMwwyL+o0yJ3C5Kcv2IoLqkfmE4+8BHomzaWh0pREq0tdjOOOpotwNbnUt69o2StGnU3S1MBPQClB+A5TaMtkPNrq6c44ufh+hAL7Sa6cTf42PSPNQIj9bDyQs5H3boviLOU5Jrqq5CPMosfN+83pTZu76aCaVIGsPQ5uVUqfSOXWGR0UHZeA6EMrW1/JdLfCALZtd9blw6qwwVgWqvGWhkpossHah+hDUMxTcrZQa/CYKxx; 4:61VEg33sHc8GXIneDy7F63WPz9+j0Er1VdD2tvH+kMCPQ+bG0t+V8E8h2WDkmVTwVv3vZJ9kfOZDhC2T6C8rQp7hyxREjOPuZ2is+XdQXlU5hopE4zqckJTGa/qDn8NuET6S53Cs5lGU29XXU1Of4asDGqTB4p8cMs+4QuW5Tw8+svPqV2EtR3Mk202IEpc578ukVVlabNh3NcaTJNgO2m6ulUQmraBkJqQPS2BUOTnZF0qWlN2U8nICzi7RERL2IzhG8bjeOCfhQBvAiALiCS1PA7KEUQ8xYAiBj01+uyP+wbFDeYlU3jHlTvATv6GiYh8e+H3aOl1i6FoCI0WbfXCSnd28ISdFIsTsANB5p3s+fRtpRlU3jWezamoiyGU1 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(85827821059158)(258649278758335)(58145275503218); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(3231254)(944501410)(52105095)(10201501046)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:TY1PR01MB1280; BCL:0; PCL:0; RULEID:; SRVR:TY1PR01MB1280; X-Forefront-PRVS: 0673F5BE31 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(346002)(39380400002)(39850400004)(396003)(376002)(366004)(199004)(54534003)(189003)(6666003)(122856001)(446003)(86362001)(81166006)(81156014)(66066001)(36756003)(16586007)(486006)(1076002)(97736004)(50466002)(68736007)(11346002)(316002)(8676002)(8936002)(7736002)(48376002)(2616005)(74482002)(3846002)(47776003)(54906003)(6116002)(69596002)(2906002)(476003)(186003)(426003)(105586002)(478600001)(386003)(50226002)(53936002)(52116002)(7696005)(86152003)(59450400001)(305945005)(4326008)(76176011)(6862004)(5660300001)(51416003)(106356001)(26005)(16060500001); DIR:OUT; SFP:1102; SCL:1; SRVR:TY1PR01MB1280; H:TKY-DS01.at.lc; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:0; MX:1; Received-SPF: None (protection.outlook.com: allied-telesis.co.jp does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; TY1PR01MB1280; 23:rd/eqrNJ/q5GrLt0VAxqLgLF3dI7uc959c6jHKHne?= EJDb+SDYsObmhayh8N+tfkSKNItjeEa9i+4yrigsUoohreRjXYBKyJWEoYkCXFYHqea3/araDqpsfHUmB1oFtZP9JoZ3oRDJ7myyFRz03uYT5sYH2GfyJUWJ23Q1j3BOMcHg4mz706Qxcg3O+wVcf6bB+4DY3dMTNpCEhs2s/DdKDc6fGkmerVcwKjFdE8w2utpnI2lq3/kIcQmnJk6FyPV0f967BwYAy8Kv90m4iYphW7uoPdUD1ZXDBtAkZNxg90QHdKcFS8BBZbobmUmSsnuff3/cUXi4x2ecBlYmYUGT8jU76s4C1WBrUm++Fw+Nl+p/tzeZfU/k9phEeP56YEIKR4EXh/R8B1RvdZiIsjFhJ85/ZvaKt+OlD0s3wuZ3NCNCnkg4s6qoEFKKqGEomtKpp1o05AP/nmr7smxc/2qelgjC9BnW3bks1MmlxPmrze3SllBpeGH0aYFrL5o2aKB7IiTD8wkxQ5jaZhje9xNzbZVSTbtmMuiKrtDY+trb9S4sKGDmNWtFLCAKhdozpb02uNLgN+W7zk+07iKNCo9J++P1DK5XcQsQ6ENOViTksedW/YnZft1+LMYClNGr3s48QVEy3PEN09WgN+F619KqgDYjS7RhRSNxLS6ohF9B13TSNOd+3VYjStiegVa5HmcoiaaaKpmVVsD1x50+XHy/xkgmGf0odhFEyCrEPHMQUSPTsLf6ZD2WtE8YaPwg4J80wOmxoUdCBfThaicTwZlnfbbbjUMcobB4X6pu3/FWAHIhxlrxtjJ0OFyBg4D1CqV3uWpxqc8GFeacPwuOhj9y2ilwHFl41w8dT6HQUiV0IGKwHOFTBda3EmifXh77TAJrB63ZQv2QsNd3DDpv0SS0Eq2TX4fBHPX7KuPzbWTB50gVFrBScer4XfvG4mNr00FLvMQtsLYOBXYUVPdz97ZQOOHZCCthlq0sqkLUPhUdju52x35fhR2jfeCBvzDXJcQOnkC1JYze4ZivF3o+I5wWDFyCmx6vAOlJJkgGWawy22NA9Zzr5UF5kTkkz1S+ULRvbxR6rDZFLSsTIOl+5rUepkX9QwOtkc4Lk48OacnLraW0MeScjUMRyDimrIcOXBGhPeL3Xy1t7H5NYP5YMJ1ojMnYhkSUubkuZpT8vgRN7KpQ85lIfu+3dKOIbJiG0Sm1iuP1Ks+PBpbx2Zi3dTGOTfh0GTWd0KhPFOqR8I+ksEwNLxQTfXxFHY01+85YxCrOvPDBPnD85jQgttMz7vKjA== X-Microsoft-Antispam-Message-Info: J5F8E35hcESaDe30p9eltVn6pSVyPVlrMkTeR6xP1wTjo4GOaPKtKeCf9LdpkEbAo3QevyzfBVsfC08tk33uXQdaLMIpXAe5+3jsTNil2wAJUjGRSJNV8iGU2QxSqxrXTmH7u6/4zKaSNDB7wIc1cLS8DSsreRdf7kjRoUUpnlReONXFxhYuXOoC12lRyGYk X-Microsoft-Exchange-Diagnostics: 1; TY1PR01MB1280; 6:KYzE4qVsmdccDFtmiWCzIpLibZd40N/5H/wug8K4mKSrrBzKBvoKFs4CZk1rzjkDtcQfxhTH0gbrY0/iGcV+XSw/RmU4W/ceyI8cOKi2QyqdS0Jh9s5SGNt/fFS0jAOJ/tC81SNcS77Y4T6X2ZERrR5QaP7TV+jHaNpkGIS1fkYbzd3LVn4vV9T6uuX63vWg+bJPf06t3oBYOas8QQskhWXKqE+csAJq9YsATtmQzuG13bxM6P2zOh43ReRUc/6YMmnD1CBMrO28IIB2ahVBIz8lNkgWFB0nQqUVmRWiMFHmThbSpvfuqHukXJ1K+KanUESyk7dMCTq+Xg0lDapv0txgtzhJu1nzq44eHeZJwiLDA7VPLkawaBOhWUfqorYBy5K5gfx/4lduvjc8ypjQiw1HKRyu9lqH6n4ofcd85f42p9AovQ0e0gR8r40A+y3d1LYh9Yq0QfS6ULNLzxErkg==; 5:DAVOKglZY0a0PXp9tMWUZpdhVU1+2Kz7wGTajw1qqNspmQ4Yqb/ZeydsXBU+Ih/yR0fIpKmljPquKOSJQiUL1nnEPnLjo2a8wBZKxKQdUliXPuJnZzWmmDGChoy1b0Iwi9D3JJXqZ1H5P93Z/Wb6UbRyGkAlz3zW/JOQrQHx68Q=; 24:3X4GUHBhihZ/h1x/nPziifIMCgA9AHwFrNA4xwaO4ehnZNvh++wpxCfMJMM/UAxx1pEx0+Z1Ep6zsUZp2GNy5EsIQrCmmMOSdhXS82FtxF8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; TY1PR01MB1280; 7:iQTjYxelcAleky0Xu9+/ronhDM6QV8duTJ1CTpn8UtcjLPwwUh+QqReSL85zbxwW/A2iI/QNfpj2LNeNPgaWYpV7INK2yc9GJ3RsJbzr30VzMREcIcjKgGbaU5eEJwp6j93jdrdcKeeUZNimAmwbcghotHAX0PkwrpawPxmO1OkBEczNPXpU//SCenoSfNurNeykRQeodJ/3BHyfmZpZEnwo5BqP9lOzPzl4SUEagP1d2f7xd0Wk/kX+kKmKlj09; 20:xSepnu5RK9wLA/6WQeiEap3lgeV9S63xUoCT3J1YCFif2Nv9leEvL4Jcu6i8zD3giaAfpZ321YX1DzeIMcjyiES668yawT3r2lq/VASxvzgPM/7C+tMyl+mS61Iu5+6iss0u2KRxGOzk7960aycDeDgS1O9D2Er1nVjengqtv7zRl5oTtfcM2H5gb7c9pbpsOKNfp9+XHMg2jIdbM2LFyCMiY3mCDNvIWGxnaLzBKxbJx/RAelFk8YHdqtxzlbej X-MS-Office365-Filtering-Correlation-Id: e9d67af1-2d67-4d0b-8599-08d5ba86f1bf X-OriginatorOrg: allied-telesis.co.jp X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2018 17:11:48.6857 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e9d67af1-2d67-4d0b-8599-08d5ba86f1bf X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 1a8a37cf-9ecc-4cef-abb0-1ab01a15a6ad X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR01MB1280 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180515_101202_544378_C957D051 X-CRM114-Status: GOOD ( 21.37 ) X-Spam-Score: -0.6 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [216.82.243.201 listed in list.dnswl.org] -0.6 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [216.82.243.201 listed in wl.mailspike.net] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.0 T_DKIMWL_WL_MED DKIMwl.org - Whitelisted Medium sender X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , Marek Vasut , Tokunori Ikegami , Richard Weinberger , Joakim Tjernlund , Chris Packham , linux-mtd@lists.infradead.org, Cyrille Pitchen , Brian Norris , David Woodhouse Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Tokunori Ikegami For the word write it is checked if the chip has the correct value. But it is not checked for the write buffer as only checked if ready. To make sure for the write buffer change to check the value. It is enough as this patch is only checking the last written word. Since it is described by data sheets to check the operation status. Signed-off-by: Tokunori Ikegami Cc: Joakim Tjernlund Cc: Chris Packham Cc: Brian Norris Cc: David Woodhouse Cc: Boris Brezillon Cc: Marek Vasut Cc: Richard Weinberger Cc: Cyrille Pitchen Cc: linux-mtd@lists.infradead.org --- Changes since v5: - None since the v4 change is just combined as same series by v6. Changes since v3: - Removed to check if chip ready. Changes since v2: - Just updated the patch to add v3 version into subject and desribe a changelog. Changes since v1: - Just changed to add Brian as Cc and the patch is sent to Boris-san as To Changes since v0: - Changed Split the part to change write buffer from the v1 patch drivers/mtd/chips/cfi_cmdset_0002.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c index e397b80e40cc..1d6be8c63d39 100644 --- a/drivers/mtd/chips/cfi_cmdset_0002.c +++ b/drivers/mtd/chips/cfi_cmdset_0002.c @@ -1879,7 +1879,7 @@ static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip, if (time_after(jiffies, timeo) && !chip_ready(map, adr)) break; - if (chip_ready(map, adr)) { + if (chip_good(map, adr, datum)) { xip_enable(map, chip, adr); goto op_done; } From patchwork Tue May 15 17:11:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: smtpuser X-Patchwork-Id: 913832 X-Patchwork-Delegate: boris.brezillon@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=allied-telesis.co.jp Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="B+nWgTP/"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=atjp.onmicrosoft.com header.i=@atjp.onmicrosoft.com header.b="B7XLlj/G"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40lkgJ5xvyz9ryk for ; Wed, 16 May 2018 03:13:48 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Fcr06jSfiLja/wvGbRrXPY6JHp/4xyizPJNPzkPchDs=; b=B+nWgTP/JMo19x aigbflST2+V9l4kMC2Qiv8pQvJ1dV26ozdldOKhKL+ldXQnvaEOsRzWKHSSIcayKB2bkexJzYUdBl Ys27ZrOEmt+tXq0p+OR7uSJkOprTMfhAuNCQA0sfRCvkKx0V/eylCD4RdTBv1ftuyDfOAkgJFGNrr F2xnDx1Jn4vdpICsmx4OCxGOv19jAilD2yyuhVQuREwfErcU3gU61p85xJVSQRh9nP9AEDwG+bR7J DqQ1mGC4Xdz9cQnwCqhpvvKyp+69uz88N6C+/uyzjLVUlx0ED6ccvuGvRjrPJA4ttyOZe7i+cQjTA +Xv3hdXMDHol7kYJQgcw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fIdW1-0001W1-Fl; Tue, 15 May 2018 17:13:33 +0000 Received: from mail1.bemta8.messagelabs.com ([216.82.243.201]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fIdUa-0000eL-Cf for linux-mtd@lists.infradead.org; Tue, 15 May 2018 17:12:06 +0000 Received: from [216.82.242.36] (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256 bits)) by server-9.bemta-8.messagelabs.com id 6F/1D-15733-CD41BFA5; Tue, 15 May 2018 17:11:56 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA1VSbUhTYRTu3b1zV3HyumkeRxYuIhEcWxRIQWg R+CtCk8A+7GrXbbEPuXfmoh/5jYlDDWdpih+YoIiCghpB6NY0JSNTK8mRZqiogdKPTEu7d3eZ vb+ec57nPOfh5VCEYkeqohi7jWEttEkdEESeHKxg4mbDttO0j7dx/POCNlkCSuptvX8JpUmNl gyr/abUsNj0msyex/ba+W6UhzpDylAQpcClCKo6RgPKUCAF+B5M9/ZIRNwqgbmuG6JogABHT4 1UKEhcQUDz+pZMUCGcDp+/DMlEVaEE1op2pWLRgKC9e85fbCFwTQz6RgKwBqbmF0kBh2EdtDu LSEFE4CEC5rxbSCCUvO/LrlpfEhIfg4JPq1IBy3EieFr6ZWLCI+BeK/D1A/E5qPc2+LCC16xO FvKY4jUpUL+SLI6GwmjtV99eAgMMLS8Tok007BTP+C2dCOrdIOIo8IzX+7IB7kfg2HiIxCJfB u/bX/m/LBZ2fzslIvFMBhstE35bE3R9+Ob/y2vg7tv09w/DmOONf6CDgMKZt2Ql0tbti1i3L2 ITknSgGI5h7zBsnO6EJoM16g02M200xem08Rozw3G0njHRGZwm02ruQfwtHODfAKqsO+9CkZR EHS4/82srTRGSYb1110BzhnQ2x8RwLnSIotQgr1ZupylCWUbP2LOMJv6g/tJABavD5H0CLeey aTNn1IvUGIqjZkvKywkFabFaGFWEvF0QYUFkyLHsWfw9y3coSqWUIz6UIjibYc1G2//8Coqgk FopbxBcgo0W296mFT6EhA/Bjv0QQtjof5QqD2ntm9Lb1HDLaOKD1v6ErKrqpcmwwNzM6L7AgP LG1KclI0dLT32cfbFwvW3pCeooTx6Z/pmvK0pJ1l22BmtXHnnaLtJJqqmUSAdyxbgt89rTLcd VnY4c10Gc6txVF69fQLaIK0Pfz1b2BHk31q8OhzQ3asK9sdpxD1ezMJUbqSY5A62LJViO/gOu v7W3kQMAAA== X-Env-Sender: smtpuser@allied-telesis.co.jp X-Msg-Ref: server-13.tower-94.messagelabs.com!1526404315!186079209!1 X-Originating-IP: [52.192.143.101] X-SYMC-ESS-Client-Auth: outbound-route-from=pass X-StarScan-Received: X-StarScan-Version: 9.9.15; banners=-,-,- X-VirusChecked: Checked Received: (qmail 51252 invoked from network); 15 May 2018 17:11:55 -0000 Received: from mo.allied-telesis-co-jp.hdemail.jp (HELO mo.allied-telesis-co-jp.hdemail.jp) (52.192.143.101) by server-13.tower-94.messagelabs.com with SMTP; 15 May 2018 17:11:55 -0000 Received: by mo.allied-telesis-co-jp.hdemail.jp (hde-mf-postfix, from userid 504) id 040A4294002; Wed, 16 May 2018 02:11:55 +0900 (JST) X-Received: from unknown (HELO mo.allied-telesis-co-jp.hdemail.jp) (127.0.0.1) by 0 with SMTP; 16 May 2018 02:11:53 +0900 X-Received: from mo.allied-telesis-co-jp.hdemail.jp (localhost.localdomain [127.0.0.1]) by mo.allied-telesis-co-jp.hdemail.jp (hde-ma-postfix) with ESMTP id 704451AC001 for ; Wed, 16 May 2018 02:11:53 +0900 (JST) (envelope-from smtpuser@allied-telesis.co.jp) Received: from JPN01-TY1-obe.outbound.protection.outlook.com (mail-ty1jpn01lp0180.outbound.protection.outlook.com [23.103.139.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mo.allied-telesis-co-jp.hdemail.jp (hde-mf-postfix) with ESMTPS id 6588E294001 for ; Wed, 16 May 2018 02:11:53 +0900 (JST) (envelope-from smtpuser@allied-telesis.co.jp) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atjp.onmicrosoft.com; s=selector1-alliedtelesis-co-jp01e; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=XcBe4/jj7994RR7a8uSxjrQTv36N+PwWYHVelhHGxOw=; b=B7XLlj/Gyd7zFakd4cy8mNBARYHbDeVrvr3VXnJI7Nl8Pis4DzftSFPmBHz1b2Geqg6qa15eP3kYscVCOtM3tuylNUSk1tBB74H4Vthrh9/khQBss8Ksi7ozr0WMcovpSLMdqrMW5EizlE0CBHFhT3RXubq9ShAVPBVz+j5LK6w= Received: from TKY-DS01.at.lc (150.87.248.20) by KAXPR01MB1269.jpnprd01.prod.outlook.com (2603:1096:402:1c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Tue, 15 May 2018 17:11:51 +0000 Received: from swim-manx.rd.allied-telesis.co.jp ([150.87.21.50]) by TKY-DS01.at.lc with Microsoft SMTPSVC(8.0.9200.16384); Wed, 16 May 2018 02:11:50 +0900 Received: from ikegami-pc.rd.allied-telesis.co.jp by swim-manx.rd.allied-telesis.co.jp (AlliedTelesis SMTPRS 1.3 pl 1 ++E6B86F8C687C6288D9B5559052954DC9) with ESMTP id ; Wed, 16 May 2018 02:11:50 +0900 From: smtpuser To: Boris Brezillon Subject: [PATCH v6 2/5] mtd: cfi_cmdset_0002: Change definition naming to retry write operation Date: Wed, 16 May 2018 02:11:17 +0900 Message-Id: <20180515171120.5629-3-smtpuser@allied-telesis.co.jp> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180515171120.5629-1-smtpuser@allied-telesis.co.jp> References: <20180515171120.5629-1-smtpuser@allied-telesis.co.jp> X-OriginalArrivalTime: 15 May 2018 17:11:50.0668 (UTC) FILETIME=[D0743CC0:01D3EC6F] MIME-Version: 1.0 X-Originating-IP: [150.87.248.20] X-ClientProxiedBy: TYAPR03CA0024.apcprd03.prod.outlook.com (2603:1096:404:14::36) To KAXPR01MB1269.jpnprd01.prod.outlook.com (2603:1096:402:1c::11) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:KAXPR01MB1269; X-Microsoft-Exchange-Diagnostics: 1; KAXPR01MB1269; 3:r+7bHn/hlBpsey37897wUhU+Ci7V6zGrbylgx4YMYp6cZ5BqXct/GnHTzHZkzO1ahlKEKLtpHS+GSyHrlLDL2ui8MOpYEj0/7Y0J2FfzkGsISkZr+YEv9h0YGqdyt6C2vHCaeht3t71CD/xnWa3CdiCEzTEIobAxrYyeYHZIf97+LHMun+hm3aiihG2BCYrhu7CoBO9LQs+Zs1hqDAFW1TUFjYa+5wPpentzZ5RDdXEmk1x0+QQodTBuF9W6SGs2; 25:1l0nvN283pWn7MGP0DW2Wj4HVbb+9NA+QoxBkV11Cdo79YBEtbw02ebpEK5MM3+h5lyXmZW+QMtTNWOuRUzaQg+peWByiLYgREr7QXrQ1UOQzgyFC/+iBw6BxqdK2PegLwCRZiRyVKbohn0KxFfQvu+fduVGXVZyFqBs8ny2fQ9dkjV/Di1WJOTupgQdNShu+aOOAFQv8ZWwvsQEVubnnbhZltn5wrfR/JWKU71Xevhi/I+fIsZwXQ3mS65zFL+mED0mbNrq34cFwO1umfOBtsrfPyX6y0OfN+uT3YfHPL71WhnN/A0gUuKjknRULqwIE7K7HzyNHZ4MyFFgLpcVyA==; 31:ysWUSg6A+uTB4LmOJ8ZoxmiI/FotpwZSIx1Z3EnjPaZJ8eZGobrwZwPGRGDetoywbX8iTJ69byxfKFlxif8zDcvrSn6b+mzRLqJcaeSPcWA7IaLSxVe5kBuyl2JrTtJEvDp5p5i5PmcNJLjL1sAnZeRo6X/yRwaTdOKPPqxBN2qi2x0Pe9Nt5syzWvoMl3zb3DSmKb83UaYsb8RXg5EDgOBdubMMDE3Nx+V8r8cNLcs= X-MS-TrafficTypeDiagnostic: KAXPR01MB1269: X-Microsoft-Exchange-Diagnostics: 1; KAXPR01MB1269; 20:mwHO+pPYwShHh4k/sgbbY6GFYfbdOL1kJwh2reLytrMqe/YZiRn0XQf8Z9mRFZxkqgswvjSWjHzpQ7OWjL8N68Ne+K5SjnuFma8qYT5VorPzeJqitSgqUb8l8zyhzlvIb58/anwfgpB1w0+krm9xhK8KlRa9uV6d2ENnUu/BXa2Lc47H0AgaYztDxbpy22b+YT2tHRkmdk4dm6NaNKXPostD/fT6uQMY74DrluPVJn8yuA0BxOhrdvcgzipElARQNSWRap5dWeFVEvmZVj5/8duAIN8Ld8iyUwOaNEA2POIPvhqd6xxbs/J6I0WiREUcaAAK7Ml0q33VcaKUW1HyaoYTmsT8WUPatXIwgBGEMJWahS54xPQGe9Z0PTIhVSvxFrbaks787okX7b4YHGTeQsKdwes7eAUEqJQc952GImXLsdZXECWwCgUyRc5s1skuEHObyKUi2LnjtDnf3YoMtQq28jVZjqRt6iQ274UqysmDWAy8Mkqxu0vo3rmyKV1c; 4:KUUHR0FEVDoRtmZf0eB2x8ry/vtGw/ULmQlnVfWgr7VV5FGz1/VcUWnfTmJxa0QYY6wiMIjSaTf5ULTkqgRAk/Fbkr+DJu4qCHdn7GkdTPYPz+wXdVwxxXUhI8h9yoIwBI7TH1UPckjA4FgO/GlX8M4qNrJfgHee/DMrz94oMEK2CzzSHhzf5/QpFttjkNHM8e8xwX4sluUHcAArBiuZodUd2LVotTQRHn794VfQWTAUPLYGnOKmvpG9KlcCIuJng6OfL7IdOyDsYGV3IAgdvCi9Mrz6uxN1JXKwY1QY8iuXg+nKSU3iOfBOeBBreH9vqgAoy1U5RP1MPsVnLhNBnb7R3nfepIkSiFHvu4PWS42KoZTcYqgKCr+d3BaogzLZ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(85827821059158)(258649278758335)(58145275503218); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:KAXPR01MB1269; BCL:0; PCL:0; RULEID:; SRVR:KAXPR01MB1269; X-Forefront-PRVS: 0673F5BE31 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(376002)(346002)(396003)(366004)(39850400004)(39380400002)(189003)(199004)(305945005)(1076002)(51416003)(426003)(3846002)(50226002)(122856001)(486006)(6116002)(478600001)(7696005)(186003)(26005)(81166006)(4326008)(81156014)(106356001)(105586002)(74482002)(8676002)(8936002)(6862004)(7736002)(86152003)(54906003)(52116002)(36756003)(316002)(11346002)(97736004)(446003)(86362001)(50466002)(2906002)(66066001)(6666003)(47776003)(53936002)(68736007)(76176011)(48376002)(69596002)(386003)(2616005)(476003)(5660300001)(16586007)(16060500001); DIR:OUT; SFP:1102; SCL:1; SRVR:KAXPR01MB1269; H:TKY-DS01.at.lc; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:0; Received-SPF: None (protection.outlook.com: allied-telesis.co.jp does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; KAXPR01MB1269; 23:ah9qtBgSALJP7NFSA6IEbufSu4xfQlQvUgFgzQ1hF?= H8oBOZ9STeLzGgzjaTcYnnkTeq/Hynko3KafAP1ctJEg1ZQiCkRgSnudV7QlLl1WGPK7+b0/vJVkEY09v7/jgEV9OakrSmQNql0H05XowZdeBA7ng9eHdcyJx/X1Sa0V8e2KnBnrFszqL5J9usDcgpo7QiBlOtjah06HpSqy6beTKwJa72Hb8OiIyj9/xHlWjEicZqyGCtrOYBmpzs/cExjXg8HmIHOAGuK8hLUXHK5tv/SeMpm7ox8BdgsdZcHmdNLSoWeb1ryC2Dmum/ftnKs2vDhI2YMyF/3jU8/rnl3qSBB+IOTC+5yHgw8rm9q2LqIvK/UzQ1m9OcYHJa38OYOAKcr64+Ddxf8OnTsdoEOuNBDRCtZ3g6qHT4tNUQG+EBPOh2sTn0WiMw7g2bio5NlnAOCIGpgZ54wBkK5PCTLkIx8x5xV6kWdrFs0wKRb7eYV7It9xWr+SA88yxitDDx6ZMYHJnFph0lA3QWbTNd1psTtbk7Df0lFLHg58mnbYK70TFngJY6vHahQlW6BPSu1tMlnRxl4kGJeXQVf7c7ipB0jR7rSZKeva5BCDDRfQVbRZilFWO6C4XdsEcWcMcYDnGk6MpgmRj18suFEb1u21Gk/6YEZlalTVJATTTth/VP73KH2JH3U6U8HTDXFX0LBRpX165d9LxIYW+HpPadChwJZHBPiGQNZ6nZ6/X1Mwz318pFSjvwNSUDaZWNbzwouYS3gx+r/qPRBcWXrH4S2uDSKCs93JitnqLww2u1YztdBR4NzTG2D90qLxmEXEmkH/uwu2EeA+zJw/sYfPnVpIcQubG48XkHpAwGyhp+pycjZyUwO4EvVSpluxwmyPDLA1BtWo0hYBEZVakSAAiYf+3vT5H7a2BWyokTwN34erkgAcvsXsb5CeQ3qhazQIIYXqt6FHnC5qoImYh1lGi1PIyyebecLFWXACg0qZ5kcec7bOMpGHFd1xgzSKca/ktX+4I81lGOvSvlpGvVpiGDHNiWY2g3X2sGdZxG2GLN8xide0htWlbBmdeZjDBKtSMO3NK1yXhYkA3Ysg4S1gZruH44AG50vXZVlPpb9xCJHrMvhR57EE4jZB9GaSP8HocvapUJdV+j+cejnY29fHJXuP2bYy6TKImnhye/EhceO14kro78/k7nLefiE/m/dbn5Yeu9+LHPh0XKOiIdALIEH4DxUy3q89l/wvBFUEx7Z+vY= X-Microsoft-Antispam-Message-Info: YxL3ZMXZQSwZwU0q+avcLWJK2XDdWXGNAAJOMNOd7Ur2mjkAuPUNLfvIc2CYpf6pNe8RwIof5Z5LbIMt48s4FR2mRYIsm6NL4U5guX9U9xX3fPhnfqiJBU8vrsXhOzqXUomu8naXuFLiiR8MLR0GOSn3wISW89LQaOg+Exnw64SPt6G1wypnhiCmdjZGnQlt X-Microsoft-Exchange-Diagnostics: 1; KAXPR01MB1269; 6:B6tX8VP9/1AtGh2GFec5fxxvvpe0CoVQ0ngfA4WXUfUsidnQxc51v4z32LnVTc718XDiDBqKz9FwKTKBfveK5jee5bM6vOjLBEjYRzKgS/4bgFb7Iq2hBCCBvzDZ2F7mw6Dd/t/BnVQowGWOWlPCu4NBiXDucajupIa71L0kx//tjaS/eQlqXxMRimX+qHWqLlg+DOCpW4YBnY0z2ZsoVNnK5gTtPyy22nylpTUjvQxHD3LAtrSFTGjY7dtTuD+CbUcFKCv+D8Xok41+ezdRX1BT7ygpsGipskZq3q8U97GEH6yn4z2nfomRct/SdWpCh5UoDdFhVsf7plHj1HcMRT8cil5frvBhGa9gc6RlWxC+AzM/lvsi2tU3IOj4gm6LCC2oCmPKtW0wXDYQ0KCin2hC+XuKzaVtNZqWEeWaYA3gyhPqBj7SKYG33+LG07GL+lHLGrkMPT7k9x/ZbtvJJQ==; 5:2kVPAb1PhPyRksbzk+3gNQfVAlJZQaSomdlEwx2ugzBHXljtKtn+/VrrvZfdKJA1S1G7jvNPNwMPFr0jKWkiCud0wEsw97YXrTr4B+j21KCRypvQJv1Bq5n8DfpABGfo+Zyt+jlM7wJXcfzRMwTnGVoYHTILcJCoXFDrVazRPFI=; 24:KCUYWr7aj/nGvi0TPFZ9fOcmQvZdg5/xahT6t0HYejF/+v4R7b1PEjbhye7P16JZiURxV6Se97UmmxF62LGHDu6Ty1TB8hoGT5ZmjBRlv6Y= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; KAXPR01MB1269; 7:DiBZ/tMVvmrITJnG8y99r9mKqyp0zFHBvGNkJCPzftESPE7KyWp3Ic0vu0GM0KaK4VZ3Fxa1yLUrdq5Z6m9REfK8gmZXrnztq/Dw2yntwTzMlcxLTVE82ufgwDScyZXjC37Qo0GyOqMcIqFH16ia/gPwn7NcAYwemGvdjMaOOlTjU5CxnODLGGIAot1m5tXS84j9QH2FEHFxFKcgPgiZKiCFzpFntUl6ePPHnMkapz9Hu3DaxoyK4/KYAUrJGeGm; 20:cSS2U9D+OCMjWT7Buu2xrYCGIogoLVRKXnRaMsgBt6wquLbBjBIBTUOMDoF4g4o/ACDMo9plMfRUONc5xBKnLDjl4GnccSVoenwq5ks+jY5XXmQgw1qNhC3RQUEvx93y1Kl+tLSYNqQGS5AaoxGWmJdcqhrrO0LGvXBY894yCQle9sC8O1evgnAR3iDepMTIU84PcLceMx6FznrNHGVqNPulyfG2UnpepWcXnHzzu1SQJwYak2DB/JVRwwU0Q8kh X-MS-Office365-Filtering-Correlation-Id: 441aeacd-da9a-48c9-8044-08d5ba86f3b2 X-OriginatorOrg: allied-telesis.co.jp X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2018 17:11:51.9582 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 441aeacd-da9a-48c9-8044-08d5ba86f3b2 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 1a8a37cf-9ecc-4cef-abb0-1ab01a15a6ad X-MS-Exchange-Transport-CrossTenantHeadersStamped: KAXPR01MB1269 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180515_101204_613857_8584A077 X-CRM114-Status: GOOD ( 18.84 ) X-Spam-Score: -0.6 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [216.82.243.201 listed in list.dnswl.org] -0.6 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [216.82.243.201 listed in wl.mailspike.net] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.0 T_DKIMWL_WL_MED DKIMwl.org - Whitelisted Medium sender X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , Marek Vasut , Tokunori Ikegami , Richard Weinberger , Joakim Tjernlund , Chris Packham , linux-mtd@lists.infradead.org, Cyrille Pitchen , Brian Norris , David Woodhouse Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Tokunori Ikegami The definition can be used for other program and erase operations also. So change the naming to MAX_RETRIES from MAX_WORD_RETRIES. Signed-off-by: Tokunori Ikegami Cc: Joakim Tjernlund Cc: Chris Packham Cc: Brian Norris Cc: David Woodhouse Cc: Boris Brezillon Cc: Marek Vasut Cc: Richard Weinberger Cc: Cyrille Pitchen Cc: linux-mtd@lists.infradead.org --- Changes since v5: - No change for this patch. Changes since v4: - No change for this patch. Changes since v3: - The patch series are just rebased since the coding style fix has been applied. Changes since v2: - Change the definition naming to MAX_RETRIES from MAX_WRITE_RETRIES. Changes since v1: - Just split the change from the v1 patch. drivers/mtd/chips/cfi_cmdset_0002.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c index 1d6be8c63d39..0b67f90415fd 100644 --- a/drivers/mtd/chips/cfi_cmdset_0002.c +++ b/drivers/mtd/chips/cfi_cmdset_0002.c @@ -42,7 +42,7 @@ #define AMD_BOOTLOC_BUG #define FORCE_WORD_WRITE 0 -#define MAX_WORD_RETRIES 3 +#define MAX_RETRIES 3 #define SST49LF004B 0x0060 #define SST49LF040B 0x0050 @@ -1646,7 +1646,7 @@ static int __xipram do_write_oneword(struct map_info *map, struct flchip *chip, map_write(map, CMD(0xF0), chip->start); /* FIXME - should have reset delay before continuing */ - if (++retry_cnt <= MAX_WORD_RETRIES) + if (++retry_cnt <= MAX_RETRIES) goto retry; ret = -EIO; @@ -2105,7 +2105,7 @@ static int do_panic_write_oneword(struct map_info *map, struct flchip *chip, map_write(map, CMD(0xF0), chip->start); /* FIXME - should have reset delay before continuing */ - if (++retry_cnt <= MAX_WORD_RETRIES) + if (++retry_cnt <= MAX_RETRIES) goto retry; ret = -EIO; From patchwork Tue May 15 17:11:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: smtpuser X-Patchwork-Id: 913833 X-Patchwork-Delegate: boris.brezillon@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=allied-telesis.co.jp Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ESSw2cd4"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=atjp.onmicrosoft.com header.i=@atjp.onmicrosoft.com header.b="luE0+bPf"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40lkhQ5NrCz9ryk for ; Wed, 16 May 2018 03:14:46 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VZix8ITxeOdtkcF/5AglQF3u3U64aTzxkYK/VueUObo=; b=ESSw2cd4DGNxmp IJJLQbydOm4QVyI/3LcjowkbAHYUorPd6GP9/SedA9DoxEMA2CCrskjuOD6cQWwkoffWHEBFk+6Qj sQoMqjyvTP6vGrJZ75tbQEmrXAS064Qa24ZsxJYzMFzvoBiyqSF+sqNeVEUcjqCz4dpRMg6kijoJs 5cpQTR0iZGN5F4KtA4QLgLHnLli8M8NIGK3sBlzPFvoNrbvcjuLj6F3Y3MMwoKHXP5dvTyB0RsBis INttq09ZVrrIVZG0kVwqRXxq6aTQztMsamk3o+/6Nj7lf/yRIqm/LM6ojGZA7my8SZpU5i0nvPgdk T9OOFZPuVK6kFnNsmbmQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fIdX0-0001sm-Sr; Tue, 15 May 2018 17:14:34 +0000 Received: from mail1.bemta8.messagelabs.com ([216.82.243.196]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fIdUh-0000fS-TH for linux-mtd@lists.infradead.org; Tue, 15 May 2018 17:12:14 +0000 Received: from [216.82.242.46] (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256 bits)) by server-4.bemta-8.messagelabs.com id B8/30-13997-1E41BFA5; Tue, 15 May 2018 17:12:01 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA1VSe0hTcRjdb/duu5qr66b4TTRxUJihODAwCtI QM+iPwECYgt7VzS02Z/dOW4X4NhXNgkkqWlE+UhIiofkg80Fqk6R8BKUrzUrTXhqlqUW7u9Ps v/P9zjnfOfz4CEy2KPIlaLOJZlIpvVLsjod3l9MhU15r6rCZ4qCIztwGSSSKba3LOo7UIl2qx mhOFmkvt1aK0+75mfuG+rFsZIES5E7IyCIEU7de4CWIIIC8CMtj20qQmwPWCaHRgvOaNgxm5i bF3ICT5Rg8/z6GOBUik+DN2x4Jr8oVQvdSpWuoRXB1Pc+pkpGrCBq+RHNYTIbC2PQHnMNepAq aKvKdGRjZg8GUfdVpkJPx8PDStJjDOLkLXv+akHBYSkaBNecG4gsGQN+nXBGH3cjDUGOvFfFh UbAwmifiNXHQOLuMeK8nPKl65wzGSICeuTmM1wTCn4KXztZAWhB0ffwp5gl/ePy0BucJK4LiT rtLlSOBovfriP+yYBi1I/69XQLWwnrXWj1MDvW4aiRC34MV1/tOsJUNC3lDMwZ3up4Jr6Cw6i 0Vq7dUvImEzSiIpZkMmglRhYdqGF2K1mSgdPoQVVhEqIFmWSqF1lMaNvSk0XAfOU4hSyBAbah gMLoXKQih0lt6YH1VLduuMZ46r6VYbRKTrqfZXuRHEEqQBsjX1DJPhk6hzad1esc9bdBAeCi9 pGaOlrJplIHVpfCUDQX6+kijOILkCG166qZt4xJHkL+vXIoEAoHMI41mDDrT//w88iGQUi61c 1s8dKmmze3zjmChI5ixLXPBJuof5ZuN6jO1e7wTFeIdIX1uopKB9t2Z3+LP7D2X92O2ZfGgIC tYYqsrVcQM9a4QTYGj3e7jimB9DDNcdU1edvZu2GesNDfcquk4MvE1dik58nr+4CPcx5gxZlw eqCvsUBTtWxhJKOovnVg6dGGc3m/5faI0QT0U9CpOfzSt4vax1Wyv+hYlzmopVTDGsNRfWg4i 0IQDAAA= X-Env-Sender: smtpuser@allied-telesis.co.jp X-Msg-Ref: server-10.tower-96.messagelabs.com!1526404316!92627916!3 X-Originating-IP: [52.192.143.101] X-SYMC-ESS-Client-Auth: outbound-route-from=pass X-StarScan-Received: X-StarScan-Version: 9.9.15; banners=-,-,- X-VirusChecked: Checked Received: (qmail 11431 invoked from network); 15 May 2018 17:12:00 -0000 Received: from mo.allied-telesis-co-jp.hdemail.jp (HELO mo.allied-telesis-co-jp.hdemail.jp) (52.192.143.101) by server-10.tower-96.messagelabs.com with SMTP; 15 May 2018 17:12:00 -0000 Received: by mo.allied-telesis-co-jp.hdemail.jp (hde-mf-postfix, from userid 504) id 9FEDC29400B; Wed, 16 May 2018 02:11:58 +0900 (JST) X-Received: from unknown (HELO mo.allied-telesis-co-jp.hdemail.jp) (127.0.0.1) by 0 with SMTP; 16 May 2018 02:11:54 +0900 X-Received: from mo.allied-telesis-co-jp.hdemail.jp (localhost.localdomain [127.0.0.1]) by mo.allied-telesis-co-jp.hdemail.jp (hde-ma-postfix) with ESMTP id 89F361AC005 for ; Wed, 16 May 2018 02:11:54 +0900 (JST) (envelope-from smtpuser@allied-telesis.co.jp) Received: from JPN01-OS2-obe.outbound.protection.outlook.com (mail-os2jpn01lp0144.outbound.protection.outlook.com [23.103.139.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mo.allied-telesis-co-jp.hdemail.jp (hde-mf-postfix) with ESMTPS id 6D32129400D for ; Wed, 16 May 2018 02:11:54 +0900 (JST) (envelope-from smtpuser@allied-telesis.co.jp) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atjp.onmicrosoft.com; s=selector1-alliedtelesis-co-jp01e; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=wYY3UuV2+pZV0TMqX+xvhEJilNYqgQ7BxQZieTiBkco=; b=luE0+bPfdnaTwM6FG5xGPB3bqy2VQGpobyjR5TyaPlriSp3ZVZ6fXMSJJdUBrS3sY51OihwaVO1y2gx2Kx2QBZ48YxRvwMDMgFHC6YDQ1hdFoRfvOCXJrtJ1QN2vfdC968Mz8y1F+Op4EDn2yByRZwU6mg9Dnzq6RX9Y8wI5ZAk= Received: from TKY-DS01.at.lc (150.87.248.20) by OS2PR01MB1275.jpnprd01.prod.outlook.com (2603:1096:602:5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Tue, 15 May 2018 17:11:53 +0000 Received: from swim-manx.rd.allied-telesis.co.jp ([150.87.21.50]) by TKY-DS01.at.lc with Microsoft SMTPSVC(8.0.9200.16384); Wed, 16 May 2018 02:11:52 +0900 Received: from ikegami-pc.rd.allied-telesis.co.jp by swim-manx.rd.allied-telesis.co.jp (AlliedTelesis SMTPRS 1.3 pl 1 ++E6B86F8C687C6288D9B5559052954DC9) with ESMTP id ; Wed, 16 May 2018 02:11:51 +0900 From: smtpuser To: Boris Brezillon Subject: [PATCH v6 3/5] mtd: cfi_cmdset_0002: Change erase functions to retry for error Date: Wed, 16 May 2018 02:11:18 +0900 Message-Id: <20180515171120.5629-4-smtpuser@allied-telesis.co.jp> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180515171120.5629-1-smtpuser@allied-telesis.co.jp> References: <20180515171120.5629-1-smtpuser@allied-telesis.co.jp> X-OriginalArrivalTime: 15 May 2018 17:11:52.0084 (UTC) FILETIME=[D14C4D40:01D3EC6F] MIME-Version: 1.0 X-Originating-IP: [150.87.248.20] X-ClientProxiedBy: TYAPR03CA0019.apcprd03.prod.outlook.com (2603:1096:404:14::31) To OS2PR01MB1275.jpnprd01.prod.outlook.com (2603:1096:602:5::18) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(2017052603328)(7153060)(7193020); SRVR:OS2PR01MB1275; X-Microsoft-Exchange-Diagnostics: 1; OS2PR01MB1275; 3:ITbV9HNhVpNB8OTIPC8vZp0mkUksfbeh4u4bn3xf9F9zA4mcJM9+3mAsjLmgyRbB1b3IJkfZeADvhKyco5UXD13DJsOLdTzEBLLoBS9gKAEuJbbe7DrwHOvKgUfRXQd1JV/pMyVvpi1LfRZ7QD7YeNPkJcCLige58+6Wb2C+OOvLJO/c/1fedZE0oi/BCkVOH4mlvXGANwltfpwZeRX11xNhpJwvFnQttUA4WDrcryIi4tkCWO0+/VG0piUHP/r+; 25:ptR8AwAb62B9Tj/J6jB/EFtNoqOXDvmYvIdjEvuU5g5jDk13pxoOGpo16mOxiiodb3RNCAmgX/WIboAZw5L9ozI8AAl12C4mzHkkMkCC8IXR6Pyk8+LZck4POJGYku6uv3xHIdVO5P1TKuYJV3p0impdkeunbfLEqV2cBI1NLmoLEQtrxKss8QFRDyMBd4ehUa7BRSSCFQ85qI7a5yDkUfZnjoy8HbLRHtt8AZBkKSUwv5S+QVH6z85XIT9Y96S1rZ5JGpY1EPh+VtYiO3YSr7qoiBvlMMW9AtdoLZsQpPVa6acyBoKgRznp7uVS6c8YamDd1UurrFLwp7mbkFkUbQ==; 31:PVoyZ7BAWaTufJ0VnLYAUIs8M1wiNjc8dSMblhs9V5ut3PyfBD7PTMruRaA2iq4n3QtSIzlC5kWFQx7uw88SlVYJO+9Dsr8hU0RF4cwQ38W8qFQklO1hEumr2aaIqzSTtx2UCa1SdQFV+RbuoRHGPDFLFYT7xi30xpUgOpJaW6gFjdxIr2wh6bAgUPuMjWnSLKEKzWRv5ikP6L/tVSnwdm5XcF+fzhTB+64dmeSRIeI= X-MS-TrafficTypeDiagnostic: OS2PR01MB1275: X-Microsoft-Exchange-Diagnostics: 1; OS2PR01MB1275; 20:IFHVGj5CrflJp3dlS+zLlTiL9EFX5a04v7nmtP2xdmj9rK0ktwgb6CZ1XxBcGD771y+Aq43zlwdjD0sv+c1kl5ebK++htj8HpXNvRlcQWNSvzoFzziMUIFSJZ6AYOhDNGrGXn1O1jHpkAQnUPwVlLr/mkA8nwxsQIq0MZsYtkTqNvFlSPKVsgduOuhUesM3ZAZJXG8GTUH7OyXJmB/TUTTm2UjMM5hKOWbW1ECqisiAC5xrFQZuPd5upZpRUiTA3ug/e0t5z0vatUVJ3K7IxznZyslAEcg3ydLaTzhZ9Fy6s3mNNJOv1G3rw4pV2qu/mnEq6ViEK4mBgo0fraUbwe6d1rwBQnpBj2uGp2LefKHGpf+WWUxyuny2k+eOZSjjFlVMX3uUQw0ZEUNFHF7kQQV/a35ebeFV9AcxpLmfxeIolgSuou0jCld5VUprpF0RBzEdX01aqjvL8uibq1d3qdD+CE1pMyccXrl53OSYOIvUFSjazQxOIXPw055ksk+PQ; 4:2sS16WI8HMszPB6iq6y+BtR2H0v9tsFgBqgTkFj+t7wlTkLhD5cchOCRX4bYEvb7Gultav3rfLxwyZJmD44PG58nKysfAKH+R2YuyicdYvMMUo8H43FcTZiDfIbhpB/d7OVNOBDKQiIOW8ix+emOI7stKFNJP6SPYEtXZgUyFhqjlGHZGWknOizPs+uEy0vF585NfDf6ulATLpwwDWhWxNGQ3UCYfx7eCuIrkbhz+a7R3aIsV+QmgWptOL26sUlhG3ylJeGb0JuB8bxA9aX3eDO3YDDnTPMfdq2WjrAb/PWviqf50jFe2u4FlqXCtBH0vLeU+XAEIF98HwZprsCGsagj9oo49EML0bLH7vdQbpEFz+FVSZqVTBGolBsAlHAc X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(85827821059158)(258649278758335)(58145275503218); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:OS2PR01MB1275; BCL:0; PCL:0; RULEID:; SRVR:OS2PR01MB1275; X-Forefront-PRVS: 0673F5BE31 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(376002)(39850400004)(346002)(396003)(39380400002)(366004)(199004)(189003)(6862004)(66066001)(97736004)(50226002)(305945005)(81156014)(81166006)(53936002)(86152003)(8676002)(105586002)(1076002)(106356001)(74482002)(186003)(7736002)(4326008)(6116002)(476003)(8936002)(3846002)(68736007)(386003)(50466002)(486006)(446003)(76176011)(52116002)(7696005)(11346002)(2616005)(51416003)(6666003)(5660300001)(26005)(86362001)(48376002)(47776003)(122856001)(478600001)(16586007)(54906003)(2906002)(316002)(426003)(36756003)(69596002)(16060500001); DIR:OUT; SFP:1102; SCL:1; SRVR:OS2PR01MB1275; H:TKY-DS01.at.lc; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:0; MX:1; Received-SPF: None (protection.outlook.com: allied-telesis.co.jp does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; OS2PR01MB1275; 23:qoIu1N+NggyyMfv5o+wJB3IC8y3FLGF8VHVPWpvIO?= GJycO8XKOMgO396TIbDQnKxzMDGm6P7ys/P+ouepnO3vHiEUjm2lZmAXMiT86hcy0ccmasctb9Z5bUxvNVndFoc+ob4J+4STgAP1xj8SVQaG16j/BjdWBjRXcmGL0PKIhCuP60JFF8XlGGTp4uKxdLyYOO23OY2NgbOp7j58r2mdqJvSO5c6U34gucj5OWSDlb5DngVuncnquo80Fvkr2woVgyoPjhr+W0Ce5ty+cqaFTm8lOyfOpgAszl4OLjBKTG28dSErAstcaxinw1VvIyzjxbL3nI7Wuxu5bcs4zZLbOOgWzstztzncj6b4oG9hOhbvZi4+6+u1uVmNIK2YZ1GrW8noCRjvNNOtbtg8D8oFJI++vMlXNDIQgvdux02/rPjma1zr1cJRp6Q0+bZ7OrwTSAj8dyyzrZLkfmS+iE/9drJnOXDDXt6wM32bb1A2d5BhLu79rvOBUky17IF48JRrbZQ10fYPOaGgMer3OKUoQ95EvMlLaPWocL6Pfm1G1suElL9NWife5EjM4MK/2Z0udq/0+/WGKldm/ahSHDARHchgKyXkd+HvFBFPg9+QOiHRNBBPRPOgNkekZTJBlDIHRjOwnc/wUF3adB82qP+CQ2yFmTfW3TeWSOM0P+5sjEecg4O6GM3aOcyLVRQCsLZhS089mDhzekWDTrWo4AzMz+SZmdYHw8e31C+jHlJ5xYFCBfQv8vFJpHFL9qPsIeFuLfVx7RBZBLfMAGCAgwo3inC++x3o9oaijg7Glb3zV3OpN1vg/lBhIgR0x03Ziu5twno/Umi8I7GeUpgLJVMaGTkeXJJD3W5evDIU+fVS4O4Rp7TBbcqQYiab6Uovah9R3HIOaUdsEAsuMf6lJozCM7KK3JKjB4VX6V4jWOlCLPrb8z+Q2ILr46oCjwlxghnErmAtXNVJcc4anCk/oX5tqyyuc9ieAzogPUMZlCP4YAe61rY55YXb9OF5TXt11w16NO74EF8b9CZc+U/t/QNuN4xTpz5kjgjNfvowOB/+kWwjlixI4Io4i8MlNDSB6tcsjD/YZwlY5Zr+sC37cxoYGqwuWNA3Kop/uFLQMcdYXOkuC5PdCstf63RMEhhzeeeLv7YaVGJMkkSlp3HqM/R0bEHgk6FcaaShezDBh1nMJamoi0TRO3ngt3sOd6Z8x9zTkqs+phpGqBUjKrunVaAwb++QoVkrSThbKFHdstFMp0= X-Microsoft-Antispam-Message-Info: Tt4nWguUKDgg3v/P+C76L/CxQ/TMP2084uqRJdhV/42/qRAqGAFH3keejEupsyVQSgozS+qoTjCvhBEml3KEUSuvpeQ4zoqLjzFV5whQGmHbsc572HESrcZ0wL/+pnNyuB8cuEG9XunlSrtJZK/eCEpGM1j8FimiifQw075RNL6nc+ya7aXxPyY86uzQgNWe X-Microsoft-Exchange-Diagnostics: 1; OS2PR01MB1275; 6:ykIavrSUopLCARjdU846tllKe94YOXgl7izfyV98s1SjzTBeffBjjhryRq63hFh33od/kckgeDYPdNRkZWjdogUFrGlT5t/1bTBCQW4GxpRZ6nYd7HUGSlvH9XH9p2GtYG206QpFwdr4EuE9cVIB16gac9iQBObwDRpuLvPPYtODLA/tpt0E9MA8xPlMi0aeIWjZ+zoDzn8JkrZx7WiAKIBETGX3YoRfLTUUrFD8nunm3dqGRBfYmZb6lKzdGRFucY0s2EJOue3D1nACu6aFigEA/j8bTootl0yEVOOblrwMhnUMdpSzzRcy25de7sH/+1XwxjbTXEsQchT+u+gdje0CDoEg3J82Pg7v5ny/XSvCAyWQ2LPonz8NTIQuyTGYkQMHGui/mDVkYOpaEE0Q3sfTVXfqG48gOlrKwIp5jh04mYCqPUIUGHuW21HR2clA/8XEceoOvgUgFf/0z33fTQ==; 5:SKqHjffAmayp8XEYDCvyINimIcDMrPWDQYc3LvAbXTpYjAAWMn/PiybAe0MOi7UU3jpO/v8/IVawCv/lVDcS7ONMn8lYUihdwQE7XwzCdtUChfLvf/JfK2P5hv5T51VYOhanmQWa1fuRFF10Ve1yTkRHvMk0fu5Zap2N9BovII4=; 24:0+Qa+22gtQEIdzkEtGonYbjfRkIQQpKV1q28mvb20FShumzncS77A5bXfi7z5agamlXfNUDfRZ4KLuLGn3zNADAqNIh3xJWdfZIGBl3aLcU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; OS2PR01MB1275; 7:gyf4N6jJcW9NQ1x2BTGoMgVD9b0YUqdaDNiqn7vqDdkALAx7T24CcT7kaVItpz22Zrhf4sGB+C1JuIr3goHxJ2LKnjKaynxWhMveihjrq2t+lsj5LV3jRJEYp20PcQE4xPr/1bay/0Bys2wE3tzQu789rHTwLeXVw5eEZ58iDu1Kw5Gl0OXwzbh3qrMNAHN1JDkef9/Lczn74N8p9lUbFjo+AKe0AWu5DdhLrFmtuG/Z8myzMBQomHvMPKLvt3Bq; 20:RfGxj29aBQZ+veqrjMTARsKjzyWNjHMAIPyz9liI6e1OG2fyA9zkZYraBridygP7GbnxZoETcmT77C7RVRE6sHhtnU5n8I1LRxEAaqu55AU6r2DHT/vAssYHemaiJ/1VZxeMG4x9ZjYgofC/ZUPFKgSaTlBRiiM2WI2QQZyyn0q0QPyb/OXbMjE2hqtc3rlxuCw6sZElIIORknp6FG5CoukOYHHgziH2M3s+LZvqt4TQez7bPcicDBwzApaL8rsG X-MS-Office365-Filtering-Correlation-Id: 0602d158-acac-4ea8-adc9-08d5ba86f46c X-OriginatorOrg: allied-telesis.co.jp X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2018 17:11:53.1471 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0602d158-acac-4ea8-adc9-08d5ba86f46c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 1a8a37cf-9ecc-4cef-abb0-1ab01a15a6ad X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS2PR01MB1275 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180515_101212_142817_5A2D826C X-CRM114-Status: GOOD ( 22.21 ) X-Spam-Score: -0.0 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [216.82.243.196 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.0 T_DKIMWL_WL_MED DKIMwl.org - Whitelisted Medium sender X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , Marek Vasut , Tokunori Ikegami , Richard Weinberger , Joakim Tjernlund , Chris Packham , linux-mtd@lists.infradead.org, Cyrille Pitchen , Brian Norris , David Woodhouse Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Tokunori Ikegami For the word write functions it is retried for error. But it is not implemented to retry for the erase functions. To make sure for the erase functions change to retry as same. This is needed to prevent the flash erase error caused only once. It was caused by the error case of chip_good() in the do_erase_oneblock(). Also it was confirmed on the MACRONIX flash device MX29GL512FHT2I-11G. But the error issue behavior is not able to reproduce at this moment. The flash controller is parallel Flash interface integrated on BCM53003. Signed-off-by: Tokunori Ikegami Cc: Joakim Tjernlund Cc: Chris Packham Cc: Brian Norris Cc: David Woodhouse Cc: Boris Brezillon Cc: Marek Vasut Cc: Richard Weinberger Cc: Cyrille Pitchen Cc: linux-mtd@lists.infradead.org --- Changes since v5: - No change for this patch. Changes since v4: - Just fixed the commit message. Changes since v3: - The patch series are just rebased since the coding style fix has been applied. Changes since v2: - Just fix the commit message of patch to retry the chip erase error. Changes since v1: - Just split the change from the v1 patch. drivers/mtd/chips/cfi_cmdset_0002.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c index 0b67f90415fd..e703900975d4 100644 --- a/drivers/mtd/chips/cfi_cmdset_0002.c +++ b/drivers/mtd/chips/cfi_cmdset_0002.c @@ -2240,6 +2240,7 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip) unsigned long int adr; DECLARE_WAITQUEUE(wait, current); int ret = 0; + int retry_cnt = 0; adr = cfi->addr_unlock1; @@ -2257,6 +2258,7 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip) ENABLE_VPP(map); xip_disable(map, chip, adr); + retry: cfi_send_gen_cmd(0xAA, cfi->addr_unlock1, chip->start, map, cfi, cfi->device_type, NULL); cfi_send_gen_cmd(0x55, cfi->addr_unlock2, chip->start, map, cfi, cfi->device_type, NULL); cfi_send_gen_cmd(0x80, cfi->addr_unlock1, chip->start, map, cfi, cfi->device_type, NULL); @@ -2310,6 +2312,9 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip) map_write(map, CMD(0xF0), chip->start); /* FIXME - should have reset delay before continuing */ + if (++retry_cnt <= MAX_RETRIES) + goto retry; + ret = -EIO; } @@ -2329,6 +2334,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip, unsigned long timeo = jiffies + HZ; DECLARE_WAITQUEUE(wait, current); int ret = 0; + int retry_cnt = 0; adr += chip->start; @@ -2346,6 +2352,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip, ENABLE_VPP(map); xip_disable(map, chip, adr); + retry: cfi_send_gen_cmd(0xAA, cfi->addr_unlock1, chip->start, map, cfi, cfi->device_type, NULL); cfi_send_gen_cmd(0x55, cfi->addr_unlock2, chip->start, map, cfi, cfi->device_type, NULL); cfi_send_gen_cmd(0x80, cfi->addr_unlock1, chip->start, map, cfi, cfi->device_type, NULL); @@ -2402,6 +2409,9 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip, map_write(map, CMD(0xF0), chip->start); /* FIXME - should have reset delay before continuing */ + if (++retry_cnt <= MAX_RETRIES) + goto retry; + ret = -EIO; } From patchwork Tue May 15 17:11:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: smtpuser X-Patchwork-Id: 913836 X-Patchwork-Delegate: boris.brezillon@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=allied-telesis.co.jp Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qhQT8sSe"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=atjp.onmicrosoft.com header.i=@atjp.onmicrosoft.com header.b="f4q9lKNh"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40lknZ5bzQz9ryk for ; Wed, 16 May 2018 03:19:14 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VK5+FmYDb8iNHAJErFqSge7yDhs0UlLP0zCt3lkKY64=; b=qhQT8sSenq8jY5 D5PKAlBEwluGakxY2E4GIFVEfZqKy9YVbaDbSGTyWoDU+yX3OBqC/hWxtezE8UtYPcF8d4oEBW5bd Bq4vL7ewQuccXsjMl0FJZ5143eL67AAHf5WQ4lEd88h0wOU/XHW5HNythyQjWif6nY7HxT8HwzQTZ XaMkMTOPSReB1DXZNdKUWxKfcA3PeGtNiGMkQvYzZriGW5hC0CgMlBr5XJ+MjMvsfJR0T4z1+KWGL gLXzH4EyUQboArUCNNaiUxnIjSblxLddrdTrT1SKytwmUzi6TobGbL60NvQ7ttmjaOx2+vG5wa0Cv 9Hl8jujsttaH9AdmeJWw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fIdbG-0004y7-0z; Tue, 15 May 2018 17:18:58 +0000 Received: from mail1.bemta8.messagelabs.com ([216.82.243.204]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fIdUj-0000fh-4N for linux-mtd@lists.infradead.org; Tue, 15 May 2018 17:12:16 +0000 Received: from [216.82.241.100] (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256 bits)) by server-12.bemta-8.messagelabs.com id 03/58-20771-2E41BFA5; Tue, 15 May 2018 17:12:02 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA1WSe0hTYRjG952zy1GcHDfDV8vChSGSMkeEEET 2V0UXYWQ0JDuz4zbYpp4zY11Qm5kXSIXUSCYWmOIwia6TojaXYYaBOjSjdTFz3shITZuRuZ1p 9t/78Xve93m+l5fAJfOCGII2m2jGSOllwlD+Lkc1nfQ5clklX5hMSH1iaRHtQwfuNxelI5VAZ 1Tnmk8LtNMetyCvB8yT/RPCYnQtshKFEhKyHIF3oQpVohACyAvw8m4/3w+AbMagZbkJ41R2HO yWkQDhk9U4vJ3/gPtbEJkFH0edIk5lwaDT2xkAErIRgasvCHwIxr1LfD8Qksng/jweqCPJFGi ruxwYi5NOHD55fIEkUjITWst6AiI+GQ/1ZRWBWkymQWWNRcCl3QauGa4OIfeD1dMo4JzTYHqw JKhRwoy7Vcj1RsCrG2OBOTgJ4JyYwDlNHPwpHRFxv65F4Hh4B+NALHT3WYPreIyg3d6GuMclE Xz31Ys4VSK0DzswDnSKwFo6F9ymHmzep8E6E1yPloJ+W6H36ptggw0Hd4tXWIPkDRsyNmzIeB NhNpTA0sxZmklS7E5WMzqN1mSgdPqkFHlqsoFmWUpD6yk1m5yda7iHVq+hiMdDdvRj7EgXiiY w2Sbxnt8+lSRcnXvmnJZitVlMgZ5mu9AWgpCBuFa6rJJEMLSGNufo9KsntYaBCJNFis1+LGbz KAOr03CoF8XFRInb/ID0A22Bcb1t7RgHUGyMVIx4PJ4kLI9mDDrT/3wKRRFIJhV7/FPCdEbT+ vSpVWNs1ZjpXfQbm6h/KKYYNe1cISpMhZuJweN60XNFVfdyVrPt1FH9ebc8w5qmGG597ay+mP /liq3OsvJrdu9UaHh+h3RePupQxrMNHbyDGd+srgHtYfX2r/Zy9Kzseu77xXfG6NtxU40vhor pmpPpi+65B0PKnmqJzZVzaGW2UHrrGCqpdf88ka1QTpt3yPislkpJxBmW+gtmTGNOhwMAAA== X-Env-Sender: smtpuser@allied-telesis.co.jp X-Msg-Ref: server-5.tower-220.messagelabs.com!1526404320!195749438!1 X-Originating-IP: [52.192.143.101] X-SYMC-ESS-Client-Auth: outbound-route-from=pass X-StarScan-Received: X-StarScan-Version: 9.9.15; banners=-,-,- X-VirusChecked: Checked Received: (qmail 32137 invoked from network); 15 May 2018 17:12:01 -0000 Received: from mo.allied-telesis-co-jp.hdemail.jp (HELO mo.allied-telesis-co-jp.hdemail.jp) (52.192.143.101) by server-5.tower-220.messagelabs.com with SMTP; 15 May 2018 17:12:01 -0000 Received: by mo.allied-telesis-co-jp.hdemail.jp (hde-mf-postfix, from userid 504) id 5A78F294006; Wed, 16 May 2018 02:11:58 +0900 (JST) X-Received: from unknown (HELO mo.allied-telesis-co-jp.hdemail.jp) (127.0.0.1) by 0 with SMTP; 16 May 2018 02:11:55 +0900 X-Received: from mo.allied-telesis-co-jp.hdemail.jp (localhost.localdomain [127.0.0.1]) by mo.allied-telesis-co-jp.hdemail.jp (hde-ma-postfix) with ESMTP id 95F101AC004 for ; Wed, 16 May 2018 02:11:55 +0900 (JST) (envelope-from smtpuser@allied-telesis.co.jp) Received: from JPN01-OS2-obe.outbound.protection.outlook.com (mail-os2jpn01lp0151.outbound.protection.outlook.com [23.103.139.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mo.allied-telesis-co-jp.hdemail.jp (hde-mf-postfix) with ESMTPS id 5AC7B29400D for ; Wed, 16 May 2018 02:11:55 +0900 (JST) (envelope-from smtpuser@allied-telesis.co.jp) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atjp.onmicrosoft.com; s=selector1-alliedtelesis-co-jp01e; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=To+M4ltK0Kz9F/Fb5Q42+DN+DtLU6f5Hq4d/7lfIjhI=; b=f4q9lKNhICHQ5hF4vJQL8LoRpcrYDocQVPjHmtKMfwK2kysZAdOPLeSJo1aZK0W9QsD5/h4FwwKkGM/f1myAAUwKk0oZdhnVXhHIN/Y7rTQkTRObLabyc2d/w9js+OCOtjsc2ibBURdHu9Uo/UDUwt10VOXnM1u0yQBA6HcEf8g= Received: from TKY-DS01.at.lc (150.87.248.20) by TY1PR01MB1277.jpnprd01.prod.outlook.com (2603:1096:402:5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Tue, 15 May 2018 17:11:54 +0000 Received: from swim-manx.rd.allied-telesis.co.jp ([150.87.21.50]) by TKY-DS01.at.lc with Microsoft SMTPSVC(8.0.9200.16384); Wed, 16 May 2018 02:11:53 +0900 Received: from ikegami-pc.rd.allied-telesis.co.jp by swim-manx.rd.allied-telesis.co.jp (AlliedTelesis SMTPRS 1.3 pl 1 ++E6B86F8C687C6288D9B5559052954DC9) with ESMTP id ; Wed, 16 May 2018 02:11:53 +0900 From: smtpuser To: Boris Brezillon Subject: [PATCH v6 4/5] mtd: cfi_cmdset_0002: Change erase functions to check chip good only Date: Wed, 16 May 2018 02:11:19 +0900 Message-Id: <20180515171120.5629-5-smtpuser@allied-telesis.co.jp> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180515171120.5629-1-smtpuser@allied-telesis.co.jp> References: <20180515171120.5629-1-smtpuser@allied-telesis.co.jp> X-OriginalArrivalTime: 15 May 2018 17:11:53.0335 (UTC) FILETIME=[D20B3070:01D3EC6F] MIME-Version: 1.0 X-Originating-IP: [150.87.248.20] X-ClientProxiedBy: TYAPR03CA0023.apcprd03.prod.outlook.com (2603:1096:404:14::35) To TY1PR01MB1277.jpnprd01.prod.outlook.com (2603:1096:402:5::16) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:TY1PR01MB1277; X-Microsoft-Exchange-Diagnostics: 1; TY1PR01MB1277; 3:/S8cAIbgvxXBFWEE7O7N0KmWccUD+aXanyysXCfioxAm+qBcqyXPdLS0iweV87ZpJJkmcON7vaQrWaB8+YrX3XHKWpsggrUvwZ08SVLZvDe4e4t2BccTubHIviS7noLgBcdS/TfbH5ujkFO809uv6z+Q8JJzyt/ozPCUHJv94vCMoDnq2pvgdr3+MJSUhF8WvoqmXQHDDryCbYzYB3N+IbapPmWhKbto4TlrTnG2s6AeQsFwnOSULYfuJ9xZvHk7; 25:i//h0LcIeCz5gNBOMnlreI7bHvmr3d3IkqcMY7BDN33M+dUj+C4YOT93ul293m35RN4uULhHiykplLVZPjtc7omHWOacer/bjJWaqHQAdLgg/r+txnHP25icYIkVAoZKfLia4k7O6rWVS0EcXqFQE7iLi8V4AK+snXiXQKBlrdec91f/VTFIL20mPU/ApWQvgXb6w8GdYnX8BwfLcZGUNzdF77iYpatLuYq4n2NbpJALe8n1u+oXG0VPg33R7gRijk+OngpYDOZ5iGNwz1/JKATp91JePiXWs1k/fot7bPZ08YwVc0qID3+gS+tsO5mxJOAlEhaY7KL7B8oM2U+J/Q==; 31:7iTl5Z9+vCtJIjFfzDu2uv0+L+m/8uSQuWWRezgvAHcW4hzE6vU0VUMbPqU8qG+6hg1qsSoc0fByadYi+0PrDZ6fNyhMx4HEJjjoJm+25g0lqV1ultJNzZeqfO0bOIB4agD22inN8XS3YJUUYE5tbx8Osp7EWToSSxS8P6NMYcMReBQKcD6zb5XryEW/B+pTM9DfysfHgtS/UyvMO1edgNqZdLJpCniatgd4TAgrP1o= X-MS-TrafficTypeDiagnostic: TY1PR01MB1277: X-Microsoft-Exchange-Diagnostics: 1; TY1PR01MB1277; 20:FoJuWJn6YH/LoBYePr9SzuZcCTzzoj1GKONbMmsrA+sdVk8saU48EDqifEulORFKA3Erw21J1Z9xhNeRfc+7ET3bU46iW3Oid3ck+z2fNA+9f12P9mnyJaa7EzEmyqHQaahHk4cJPq5GCixCWuZ7BhHuD5BX6UoxjWq5RnW8W/GPqVlTtlWRaOGdAHmWt5w0pND3gSAC6XFD1Jm8uOOdRpcH7oQZw8NybFNFOB0g5t61wSqSJ1qivWvf3/J2Fxr9a1UB3q2DSOplyvpbi67yafgfC4ixRfpIVR4qlfhXKhVNXL3gpbhZOoXrn/krNzIoncx7ORJasJDQx6I7jkHsH8qWtH/XjIW5/H9c0VIz/S4c7ay6lHSS9l50nXzkJcKUGeeziyd6NFx3GbYbNX4wqeueE8qkPRKiNRs6kqPctfYAnCAMYUqbRhV86+2fc6vTs02S/d2rUEDqOTnyLL+2Qh3abFaNdaXZ99BSV+x5BGJ+PV+iYgI/Ce5qwlanPqIs; 4:aOZQ1BbkyaHzTAO45tolvH1ESCGvlr8+QsCF4whSHjszJ7aX8ZDbOmoHHXqionscoO8SQ55jBrc6aCwBXXM1WGta3+gKX3/r3zpALx7rfVTjY3BnUz2dzfY4pRXyL0nKaTHocmiAe7i8gF2y1CFPGm1PBIjy+tRLqCRHakCSGuKveBWmJfetmnLaQ/RmkABx7kngGF/tbzQ6lJ49RrVU0qgBS7V5UGDavgeTLoQUhVqv1HCE/I5r8PiHqmVlXDysuT1OK8h90m1FuZIJ23lG3PD442wVTgBRqlknueMlPgvKTErqUrbRMHYZIoCt481NSOJQV/uvf9OVV/P1PSdpAzI5h8vPOgvb21JjrvZRSGGzByWcp6Kb1ufznLx4HECe X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(85827821059158)(258649278758335)(58145275503218); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(20161123560045)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:TY1PR01MB1277; BCL:0; PCL:0; RULEID:; SRVR:TY1PR01MB1277; X-Forefront-PRVS: 0673F5BE31 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(39850400004)(396003)(366004)(346002)(39380400002)(376002)(199004)(189003)(36756003)(66066001)(426003)(305945005)(122856001)(50466002)(53936002)(54906003)(68736007)(476003)(16586007)(6666003)(50226002)(316002)(486006)(2616005)(8936002)(81166006)(86362001)(59450400001)(446003)(105586002)(97736004)(186003)(478600001)(5660300001)(106356001)(26005)(7736002)(86152003)(74482002)(47776003)(11346002)(69596002)(4326008)(2906002)(52116002)(51416003)(81156014)(1076002)(6116002)(8676002)(6862004)(386003)(76176011)(7696005)(3846002)(48376002)(16060500001); DIR:OUT; SFP:1102; SCL:1; SRVR:TY1PR01MB1277; H:TKY-DS01.at.lc; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:0; MX:1; Received-SPF: None (protection.outlook.com: allied-telesis.co.jp does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; TY1PR01MB1277; 23:nGb1XVPKLSigfDYMoqzDvejHpRmRVtZQ5P2uBcBtR?= 3oNgf+o7GGC/4XupK7BeJhSGpGE7sFjwvl/ew5X5ReiTmLk6P/LYaLRPtAAtq6j2Z5DSNl+wxbh6G+rPHRAY2XxEC5PCDgfH+nwqi3diBMsrC8j4dzrHXJ3p7lrHxEeIJm03a1Lot//JrB4SE2uiTkTlIDytWWJLRf7MPqDbXnjG1Bnx946qhasKzcV1Bp0QpA55rIxHWTRNwY1ir88oyuK7UfSoFxDJXFJEZ8PpkgFmDFFa8SjFJxhop0VPg1JjjK+hUYrrqK+tiNElhE3r66AhklCBNp1ph4ar3CGwlCEeHRc9Hm1S8C1HJaoGbUwaK7k6WGdQ7HCMzNeftvW+Vp6Dn9g04TI6OzjmVxeI/heSKVqVf60GpGVkABNhXqdgN3h1qRHvpMpX1FtWEgh3kGXcDLJOvteSQbkVM2jJpSoczeG2qZB7fQSmadqYdLaY2fU6b9WRpU9kcF5R/wMNzLtG7g01kQOyoNHlkrv69HMCd6zwEW+WaD//03h0BfjkqfFC3Cuqzi4LayAGIydMizHMVon3/BsKP0JFj5zKeJUhjBeKbSAbB+puLyoiPKz6zRMCXevsnjWXgRrT0U8WxoFX1mQZdZKhQFWzNzmU1v2Gx/NnDZompAB1jeM9ZUwkuq17Sps4/MHK5EE8r8mo6reMzjqcrwayqfdC/U/yO6oDVrN/vX0OGNwStk2x56tan+5H4FFZEgEJY7VuRRExegnzGwBi9P2jTTIvOhc/eyFpI6Nni3VI/TiIcb2qjBYcuGf3GTifMXIsuZkhlx5ZNbuVW+D8qvTjUdALj9SwOqmvrx6nBKQKGGsSBgLEQ0EzZEucM6lDaupAzkey4bKsCGt5Th3qHAx8j60ogzS9DdcQDQIxzYOmw1gAyu5+8x9w7Er07rxYiXorTIhBU2HL25hyElfq3uhjYKpMIO2Px/ju8HGdo2Wma7spVkm4JvjSSFTcw3ietNDIbeoqwQ2LiBTXFtbqvT/v8PTDyCg/15uDiAQTs6wrnkCtx3eBh/AvdqnrN0TjGmEbuttS/An/DwgoOiwwrftPQl0wL8/ICHSlAPSfctAF+zngNJAFVwyG0K61VuEAaApOu8dXzaQ8n/xSGPj4MKlef4SwhDD8uln1zuZVeQWsu33Zyj/hRDcmmg4Z5673MNJ6e56pCJcIfkWYu3iLfKUwhySmx/srpMJvMxcKZOMVyC5VvGX84LLtco8FB8bHl4VP3bt2K5+Jt0W X-Microsoft-Antispam-Message-Info: a5R1UDgHvGQ4g97NKxY6zXoNA7IFbZzlY0CIVVtW2VlRgUBv3+Co5mp0X3V+jJOI31OqKk6mBJi/6AAJAK2XaMciSRZ36xDqvZ2hS7MKeyNUshu5e5/Cxj+SFWrhVFN7g7FZQQeSydM1MiILPafgL/Gn2H15j2YMf2wYQQfDo0bhzlFCjOQ57T56AE6yuCmF X-Microsoft-Exchange-Diagnostics: 1; TY1PR01MB1277; 6:p23oQiOkuSP2fra85EpNxW5tyShx1nsReQgRRgDHCHpWHBrtJznO8kJ5KeVdkLVIX/EPOZ0Mp224xRKwP9DpqrBxzU6xO81rpRfLufK91UsGbq8RxzZC9nEakktkVOS/79EK4apqAwbTtEIwd0oEjvbewmdao7l47Iek3gCwzrGvXOctjaT2ZiAQKdGu2q0Jr0EB1de5iF6dmT7BOZsZokiQ+Re3RqgJaSkXoKshAP/xxDOy9gIlyzV3P/6+MRtr+Snk5+/O9TxU4SZv1dx7Y3/zYC7LovWWfOCtLkLw7rETmOoevFQhGUUb7wUCm0qdVeXpE9SqtvEvcadaDx5U7ygFBew8hMbMa1dsScfI96Eo8uZv4Z+GtZ4rXG8XfobbqB9eeI0YtcjVRR3URI5pEtrn6Pu/EtO+w0Wb6wPv6oBrvyLIUdGmH/crak6go6ZGxEEz+C8AHvjKGH7kUsk/Tw==; 5:hkH0CB1046Wg7RSJEbIL+9mxjQL1ma2155RyD98/vHPgMgShDMJapl0VIfixSmD6FR6uQ781FOiBR08qCbIPzvh+kEGVHH1Lq42dIbCtYvCIQoDUfJMnGIV+DiNHizS2AH3uNZLUnadSm6N4wFuloNVI7PzwWG87MmvOM96O35k=; 24:jnzeClFD1RzL1BYGu/9StdmB7V8C78kn/XylS6Jk1iIR33kB5fJrK2NwYAUiiui//Aiyl1zWyiYte0/BqkM0Ax78+Ug3a/+UfSxZz6EKz9c= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; TY1PR01MB1277; 7:t3PupiJRYYBMi8Sc1KhluXmvR1s8Q1j8RN2yLchcfmDojv0CNvKegOE1Tvwcs7foXmGoGc7SnhBTXdjFAZY+2eeodT6hzX6wDuR5fIj39HivhFwyo1gG3fRCFu64Esy8HLYkz0oIkqmeoQf9TTKEYoQqWqVUuQ359h01lV0987FYVxR0q7N4V7Fuk5R7Km+zMXP6uvGefWc/K37OdL9wYqHvEoREuKQNm6/zRTOsL9E3YcdJxx2jo67stMWd6eGt; 20:g4aNumY5Qboa7ZcNfuM9pxyERNaQqxpKzMAnzfVlpkWF0IaRYMCDvuNeqkueqreabJfBUHDGR2FpQowTe1iE6OPgyyWeUD6aA65qf6jead8/In6yWRpXK7LG+Zme9GHYrcLjIETjQGBclZEXslYcNAFwlbsAcMRQwZCAFcInSg3SACM9LkH3jc8mNyN8yBRMRE+egjt0hvseEvw4CbFatdnoIkPjWVd0SxFKN9rVqKEG0ebyKCIcbcRIcy8tyd3H X-MS-Office365-Filtering-Correlation-Id: ee2101b7-0f87-49fc-57a0-08d5ba86f545 X-OriginatorOrg: allied-telesis.co.jp X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2018 17:11:54.5983 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ee2101b7-0f87-49fc-57a0-08d5ba86f545 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 1a8a37cf-9ecc-4cef-abb0-1ab01a15a6ad X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR01MB1277 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180515_101213_366801_E61A6489 X-CRM114-Status: GOOD ( 16.89 ) X-Spam-Score: -0.6 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [216.82.243.204 listed in list.dnswl.org] -0.6 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [216.82.243.204 listed in wl.mailspike.net] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.0 T_DKIMWL_WL_MED DKIMwl.org - Whitelisted Medium sender X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , Marek Vasut , Tokunori Ikegami , Richard Weinberger , Joakim Tjernlund , Chris Packham , linux-mtd@lists.infradead.org, Cyrille Pitchen , Brian Norris , David Woodhouse Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Tokunori Ikegami Currently the functions use to check both chip ready and good. But the chip ready is not enough to check the operation status. So change this to check the chip good instead of this. About the retry functions to make sure the error handling remain it. Signed-off-by: Tokunori Ikegami Cc: Joakim Tjernlund Cc: Chris Packham Cc: Brian Norris Cc: David Woodhouse Cc: Boris Brezillon Cc: Marek Vasut Cc: Richard Weinberger Cc: Cyrille Pitchen Cc: linux-mtd@lists.infradead.org --- Changes since v5: - None since this change is implemented by v6 patch series. drivers/mtd/chips/cfi_cmdset_0002.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c index e703900975d4..6adda4dc2007 100644 --- a/drivers/mtd/chips/cfi_cmdset_0002.c +++ b/drivers/mtd/chips/cfi_cmdset_0002.c @@ -2294,12 +2294,13 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip) chip->erase_suspended = 0; } - if (chip_ready(map, adr)) + if (chip_good(map, adr, map_word_ff(map))) break; if (time_after(jiffies, timeo)) { printk(KERN_WARNING "MTD %s(): software timeout\n", __func__); + ret = -EIO; break; } @@ -2307,15 +2308,15 @@ static int __xipram do_erase_chip(struct map_info *map, struct flchip *chip) UDELAY(map, chip, adr, 1000000/HZ); } /* Did we succeed? */ - if (!chip_good(map, adr, map_word_ff(map))) { + if (ret) { /* reset on all failures. */ map_write(map, CMD(0xF0), chip->start); /* FIXME - should have reset delay before continuing */ - if (++retry_cnt <= MAX_RETRIES) + if (++retry_cnt <= MAX_RETRIES) { + ret = 0; goto retry; - - ret = -EIO; + } } chip->state = FL_READY; @@ -2388,7 +2389,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip, chip->erase_suspended = 0; } - if (chip_ready(map, adr)) { + if (chip_good(map, adr, map_word_ff(map))) { xip_enable(map, chip, adr); break; } @@ -2397,6 +2398,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip, xip_enable(map, chip, adr); printk(KERN_WARNING "MTD %s(): software timeout\n", __func__); + ret = -EIO; break; } @@ -2404,15 +2406,15 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip, UDELAY(map, chip, adr, 1000000/HZ); } /* Did we succeed? */ - if (!chip_good(map, adr, map_word_ff(map))) { + if (ret) { /* reset on all failures. */ map_write(map, CMD(0xF0), chip->start); /* FIXME - should have reset delay before continuing */ - if (++retry_cnt <= MAX_RETRIES) + if (++retry_cnt <= MAX_RETRIES) { + ret = 0; goto retry; - - ret = -EIO; + } } chip->state = FL_READY; From patchwork Tue May 15 17:11:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: smtpuser X-Patchwork-Id: 913835 X-Patchwork-Delegate: boris.brezillon@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=allied-telesis.co.jp Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jzXCYs5y"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=atjp.onmicrosoft.com header.i=@atjp.onmicrosoft.com header.b="JifNGbxf"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40lkjN4Mg5z9ryk for ; Wed, 16 May 2018 03:15:36 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uaDkQNzR7fG+nFrIYwI1S9vKTKpNAHnt0uBx0PFXUPc=; b=jzXCYs5yocBFif LyKg1kXxB77i3uNIGjCR9ldDFKX5Do4KeSXOoKSBKS7y8PrUjRRIIkk8e+ot0Gmob64cWeXeEKgOw CFPBPBNGqIFk6/hVwn4uwSR/Y+zzYOnN5Qg9S00u1P10V8AVg9UTPIxIp+RjHv9t1VWJNH0k7LFnz oxNS4fyuhdtXZtFmbDzNpiBkhVdnqjnTQLrRipC35ePobgmgLGHU7NFvOudIENP4o+CeTocHk5NE6 h7tLORPuyw4kYnuBLbooudTBQzxTdZ9nPNXYH7bvLu4Y0cngOkvcBZ2S0cqHZQn6kiqk/lVRlGMGN VMzwRza5ivepUZT1YWFw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fIdXo-0002b5-Hx; Tue, 15 May 2018 17:15:24 +0000 Received: from mail1.bemta8.messagelabs.com ([216.82.243.198]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fIdUi-0000ff-TJ for linux-mtd@lists.infradead.org; Tue, 15 May 2018 17:12:15 +0000 Received: from [216.82.242.36] (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256 bits)) by server-6.bemta-8.messagelabs.com id 48/78-28268-2E41BFA5; Tue, 15 May 2018 17:12:02 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA1WSfUhTURjGd3bvtrvcreNUeh1+1KiMgWuKgSl BJkgUVtC3JXrN6zbYpty7wpJSl1E6IgdKH0yyD6JZUGiZFZGzhLbKUqMMlbIyPyqMjEwty+tV q/+ec37P+z7vObwUoR6SaSg2385yNsailc8h4xqPs9E9weNphpMTsfF3HBcVq9CauguFG1Gaz GzLys3PlJluvBsg87rp/GbnEFmEegPK0BxKjY8iOOd2EWWIogAXwJkSg3AP+IIUnOcvS0VTAw ETEw8J4UDi4wR4WjrlZUhJIZwBr996FYJWY4cUrrTIxYoqBG1jj2QiGEPw3btB0HKsh+c9H0h BB+MY8FSWkEIBgb0EvOkeQwIIwtvAO352ykTixeBsuEQK89E4CYYrs4VrwJFw/5Njqr8SrwZ3 d9V0VhJ8bD8kEz2bwNnYJRU0jQPBd+r9VEsCA3j7+wnRsxAmDr9SiG+uQNAzOkyKIByan7hJE dxEcNf1BYmgWAFu/yLxw3TQ70wQPbcU4OjzyEWPBdz3Pk8n7IL79T+mdQT4j7VIxYIaAjrKff JyZDj9z4Sn/5mwGklr0FKe5fayXHRsnD6LMxtNditjtkTHGOL1VpbnGSNrYbJ4/e5cay2aXIR CiQQ1oCcfdzShUEqqDaETf46lqedm5WbvMzG8KYPbY2H5JhRGUVqgO4PG09SBHGtk83PMlslt msFAqbTBdL2AaT6PsfJmo4j8aKFmPu0RABaAaY9ttmxmD9tQuCaIRhKJRK3KYzmr2f4/H0TzK aQNoquELiqzzT7bfXAyWDoZzPlHhGA78xdpipCxlUzdeFN227820aNmk3KWbA+LcquUITEBvk /tI6X9j7ODI5sf/Bp65n56bX/UzqTlW2pPBGZfLS6oW7FZXn55vKPXRVd/XZl5IFSZXFVRp/S 3luh8HSmmg1sHSud9Tll/JEG5rs+27tuLNZ7r3am63nc1o79fLnOlJxfHVi9I74rQkryJidER HM/8AccrHvyCAwAA X-Env-Sender: smtpuser@allied-telesis.co.jp X-Msg-Ref: server-4.tower-94.messagelabs.com!1526404320!47459234!1 X-Originating-IP: [52.192.143.101] X-SYMC-ESS-Client-Auth: outbound-route-from=pass X-StarScan-Received: X-StarScan-Version: 9.9.15; banners=-,-,- X-VirusChecked: Checked Received: (qmail 129736 invoked from network); 15 May 2018 17:12:01 -0000 Received: from mo.allied-telesis-co-jp.hdemail.jp (HELO mo.allied-telesis-co-jp.hdemail.jp) (52.192.143.101) by server-4.tower-94.messagelabs.com with SMTP; 15 May 2018 17:12:01 -0000 Received: by mo.allied-telesis-co-jp.hdemail.jp (hde-mf-postfix, from userid 504) id 65C23294008; Wed, 16 May 2018 02:11:59 +0900 (JST) X-Received: from unknown (HELO mo.allied-telesis-co-jp.hdemail.jp) (127.0.0.1) by 0 with SMTP; 16 May 2018 02:11:57 +0900 X-Received: from mo.allied-telesis-co-jp.hdemail.jp (localhost.localdomain [127.0.0.1]) by mo.allied-telesis-co-jp.hdemail.jp (hde-ma-postfix) with ESMTP id 611851AC005 for ; Wed, 16 May 2018 02:11:56 +0900 (JST) (envelope-from smtpuser@allied-telesis.co.jp) Received: from JPN01-TY1-obe.outbound.protection.outlook.com (mail-ty1jpn01lp0178.outbound.protection.outlook.com [23.103.139.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mo.allied-telesis-co-jp.hdemail.jp (hde-mf-postfix) with ESMTPS id 4EA1B294011 for ; Wed, 16 May 2018 02:11:56 +0900 (JST) (envelope-from smtpuser@allied-telesis.co.jp) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atjp.onmicrosoft.com; s=selector1-alliedtelesis-co-jp01e; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=PR/aPx+ICnTa1VlM29D68i7vmw/GYYw8pArURCwbTpg=; b=JifNGbxfjPDM0LPxQIF0sYiMQolIHAx+bFt20Hmm0RYpGX4GeHm8a1IcD1ImsZNWH15SQv3+hY9acMHF6a9T5/t7ge5DuWCFm7jYczbL3rK/UYptOQo31Ozzw7M5Z6mf2C/KvlKQ1vWKmdq27QnS9CW/CYHrWpqQMx66dK7cN+I= Received: from TKY-DS01.at.lc (150.87.248.20) by OS2PR01MB1274.jpnprd01.prod.outlook.com (2603:1096:602:5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Tue, 15 May 2018 17:11:55 +0000 Received: from swim-manx.rd.allied-telesis.co.jp ([150.87.21.50]) by TKY-DS01.at.lc with Microsoft SMTPSVC(8.0.9200.16384); Wed, 16 May 2018 02:11:54 +0900 Received: from ikegami-pc.rd.allied-telesis.co.jp by swim-manx.rd.allied-telesis.co.jp (AlliedTelesis SMTPRS 1.3 pl 1 ++E6B86F8C687C6288D9B5559052954DC9) with ESMTP id ; Wed, 16 May 2018 02:11:54 +0900 From: smtpuser To: Boris Brezillon Subject: [PATCH v6 5/5] mtd: cfi_cmdset_0002: Change erase one block to enable XIP once Date: Wed, 16 May 2018 02:11:20 +0900 Message-Id: <20180515171120.5629-6-smtpuser@allied-telesis.co.jp> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180515171120.5629-1-smtpuser@allied-telesis.co.jp> References: <20180515171120.5629-1-smtpuser@allied-telesis.co.jp> X-OriginalArrivalTime: 15 May 2018 17:11:54.0690 (UTC) FILETIME=[D2D9F220:01D3EC6F] MIME-Version: 1.0 X-Originating-IP: [150.87.248.20] X-ClientProxiedBy: TYAPR03CA0015.apcprd03.prod.outlook.com (2603:1096:404:14::27) To OS2PR01MB1274.jpnprd01.prod.outlook.com (2603:1096:602:5::17) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:OS2PR01MB1274; X-Microsoft-Exchange-Diagnostics: 1; OS2PR01MB1274; 3:yfY1iMIY4dK/1DUFRzKiHzmey9UeYmwRsgmJWbwHn2t+YJYho45Ohcw/WgfnKuZB1V/qu1vKV5ozJrh5WW/SYB3xKnEgl5x6zeBhjRUYSw44FVQng1mn4B2/T5xit/K8emr9MmAhvs538UrIywSCy2fuEsNJiQcFYbwKdQ83IgmS7H0coFNdeR67C+IHQj6O7fY5Kg8cuo9ltFYWO3wE2tK9IydqsaKX5uoXtcDcaDw3XxJOr5q2Q47FSYqCmBmZ; 25:6nGKuFQ4HnwOURReHK3itrWsx7/EQLKThZgSN4nnEmHSPUcm8jAWTLb/h8C3RqoBjCYPx+fkFgd07yI+cDgpAtTd/cp7zalRPaq8RlakeiJqSi4wNX2HHoHvr7eorw3yyj396CX/Y6MmKmnLTnqk3E92Q6eslQNNHMf50jV66htPMDhbgB5AOxrVlZJFiVleadZA33fDB+H47ESfeL3yVMS5TRBQQpQDu8vaEirRw1oZ8Hx8FCjIIh9yYALnbc2NlO0NYrVStxUBYAhR86qE0Yzw/IVOy1LAJslKFQU/gST2wwAswx1fv1Qd24pdsFcp5/p9kDU/uBZxvt+hlDcNKw==; 31:cmgtA3JO0OLiroGxkzLju7AZSHDNI7bftWgxx+7C0OCB3uPGXeq7L10W8eeX1Q9ptydXtKZFgEIkhh+rqXj9iN+Bo34XUT++l7Lh1MRxCgxOPjLlbFLa/38EcAh67QDqXOaJRqjU+fURpXSnwCTsc1ffEFEfA9+DUJ+1qRsSQQAdAjJY+czOwdprletexnjbIAUrYwSlkEJ7GKGJb2dd37DL9SaGnoPrI/FMY8bENIw= X-MS-TrafficTypeDiagnostic: OS2PR01MB1274: X-Microsoft-Exchange-Diagnostics: 1; OS2PR01MB1274; 20:QCyQZLmZc5P93u6OO5LBMh1BtEtC0WpV7EcMKVpK9ZnHPNG5g/xmKKxaeWExg46PtnrJ2aLkqTEzl26yHzEQGk+zZ8VEzECxdopn9LCR71EeKOoHBEsUNV4jR8KuXLsETRg8j7m5ljHr5jjTrz+nc9yDT/Ow57l2d0B0kuoBosX7kEtfYVotZl1OtDSAs9gzb79SLdiWRHEqrqLxFWmuA9d2xTw/PmS05pM1auEtXr1GarwsPNHs8OscNJiEaGD6sRYeB/VKJ2FqR8UKksurOCjeBL+HfSkPSP4gQh06qf4pSP2SbZmgAmT7QgRciVtfen0gRL34RaiOT8OE1z4UD6SHlKXSJkQpazv8Bd2iYHIdsnGrjSmirXg96PT8ejDKM/zADdZKBnQ2gM5VCboduE2fX8kvStHrV2I67oSl5jm6UWAA4WRgxrI5agMGIfKmMAVlJ1uAoypTJqV0DWOMp3Nh8XI+GdywbmmVZoVkiMs2sOp+yfwUfOLAQGzT0pcI; 4:9QmXgp8rynjyFzfMOmPlNJ3UqDy2kj19xshXW7OCvejiLjKc28Y952OyBc51hqWvmiV+bRdurjf5VIKlSQWvjjw5dovGeTmbqYNwBYBqjOyNDJR1kgianypILZpTthHk63eG9qqryEojnkrZ5ecpG3XKhl8F+rkzAw74K1djDMy7vlwrRRRlCqatFhFYArvtdZjPKCCKlbg6NU86GyBHXjUzslaU8z/wSWs0Z3Mv2YqyDA9a7v2JZARGpxN80XSEG8HIyHbvmqbQXeypUvvMga+QBDrk6Q2r6gj54dtEjHBbzrLBWTkhxYI2iFLNpArMCTI5aWO6/vOR6+zrqDkkl4Vy7uLWw55x44yuX528mG1HFnH+xJ89FyfDA/hrhAHY X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(85827821059158)(258649278758335)(58145275503218); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(3231254)(944501410)(52105095)(10201501046)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:OS2PR01MB1274; BCL:0; PCL:0; RULEID:; SRVR:OS2PR01MB1274; X-Forefront-PRVS: 0673F5BE31 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(346002)(39850400004)(396003)(376002)(39380400002)(366004)(199004)(189003)(48376002)(122856001)(97736004)(386003)(305945005)(86152003)(50466002)(1076002)(486006)(7736002)(6116002)(4326008)(81156014)(478600001)(81166006)(8676002)(59450400001)(6862004)(52116002)(86362001)(66066001)(7696005)(8936002)(3846002)(6666003)(69596002)(50226002)(36756003)(2906002)(16586007)(53936002)(47776003)(186003)(316002)(426003)(74482002)(105586002)(26005)(11346002)(51416003)(76176011)(476003)(68736007)(5660300001)(2616005)(54906003)(106356001)(446003)(16060500001); DIR:OUT; SFP:1102; SCL:1; SRVR:OS2PR01MB1274; H:TKY-DS01.at.lc; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:0; MX:1; Received-SPF: None (protection.outlook.com: allied-telesis.co.jp does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; OS2PR01MB1274; 23:xWGxTZ0O8TcJn9femtMP6R5daImkOBlDEAe7VyOUE?= ERu0oO/7HPU2bppmC52IbddvJeAkgU9H9uGrw9nNeM6RRXDN7SnohNwVIM5LQPeHo0/UBI0rQTl1WlfZCf5ywHhOBgNq3h5hTvFgK4Rtz+U4KEDauwXtCecGfeBq2UZMWb4yyYdvjC2l/M7fwf888yu1QyqnZRjeuhHZSZHhTI+8jSuRJ1zxDYfJ3zmq5ckwXBl9nbMrFYijz9z3il75iQZIQAEhGBq+lOHVqZG9BylNwDqyY/qmXvG+JaCSKevE5TJaz9t56FtBKAqaHV2ZcqgY9pzo3/hjLyVzYy3Ubf9PnfkE0iy1GHL9RYN8HTUElGdE2nbrMOZGYlIqSzNrEycCd6D/P52KSa++jgLhLawz3uurT1mm78iYojvYT65QR8KUbuQkhAXfnGSxJGHmNlCCGofiBu6y71eNn62KhW9RSNVttRZeFr5fxXC0TtS5H7Eu3p2pOnmWzmi5NSMKI1WKIG5yU2UsEzZ1dcRVeX5838cZVMtiUl49CJW+IErkD5r5eszLZhizyhBxwAfyn+YmTw5x5hmb/ue1+IGzFAiqEW4E13Of76YUtzESAGW1H8vN2OO5TdkWA9NLiZ3/nF+zeVtfegcM4H55tjB+3jDL/mOQxSeKGmLB+COx8kEj/2ILT71y1eyLWCD+uyQYmertra+JQnBZYLz3MuOMAUdtdP+b4CneJtEF0lQrNeM0ZMYbT0rG7SX5nLWm39m5JAP9J6vpUOO9YQ3BU0/PtyWsn2W4x6Snk/qW6tehKThI3pTByQHAc635ce5GRj3IlRy+NIecd29nFUBQ0AwbLZwHmC/K3qJrfxjUqSELr+t2HPtPtpORDlkbJ0egM/1eZ22eNa+TxkpFnyUkyNGZwpvAReG3WA58LGFG4gAP1/0w2wnpJ0HWogDWZrld0Gy4IetPxdQxjEiiGfD6E1IBleCjG7BC29zyU4wOSdfw+fBRwFMh6wW7N+UyMAH4cKBN7WkKntilns3dSZ7KYTyEEIuwnBP1h2gvg7Oi2BDD2LUkPXR2awvFJA/CfEICunigI/SJ4XBlqcEwPZfmmUNsbNlQv34+U7fVBiLNtNIOCY5/B8inHHxKWogjfFQodEWSc7UTs8M7OXWuXjNIwIli89hAKzxwT6Ozg7FeHPLiNg+ZDYzP4WfCucPw5paHKg5BGuu2ALr9tloFX3ubNx4jFspg2oaC6YKBoFMShB6fpAYQWRIQExhYnp2rS5WfN+fdWx9 X-Microsoft-Antispam-Message-Info: wMLUjZ5crl+zGkKeTsWactzVeALINGNQGA8owRj/Qhxw7tf6Cx5MREvo0vZcizaQaPhFaYoaAUHhxCxyzXRLirKtE0Dn0XEge/HqaES6cOb6XnuGJcSxG3+pgJCSwxSnRNMM55DnXbAv9nBsTvDSKocsJzOu/E7MRyfcsqQ3r7aPBWP90pnu4D4OFAGYDA9J X-Microsoft-Exchange-Diagnostics: 1; OS2PR01MB1274; 6:Qd91wtWjvOmOY2Gyx2tcKkltAw2kd1dBfkIVuOx5m+0Kcrlyu3qMLozZTOeeNWdP9MMh7vJBNEq92lbLT/rrAs1GeQcBUq2KYcqfMriwVjZGcNMZNA0Ghi9WUEmu8ZqRy19LepXN5sFHUcbF70KygVJviaksslF/SVhabdc5l1JzRktNboPXSmGatw0O4hB7FGPHg9TIqnBfi/4q1QCYumAhDvfWJamkoUAqrkiedPJ0XX4lUqP6aqSzEV0/YV1Zx1SrIv7KPBCZ8b+oWMf29qqtXW0Am+f8gkihjfrWp3v9JveHzDMlJ1cfw6owVe+6pBwKPLDrsP1N9DmooFtXX5VK6ijR6yWDcoIKpbjTCiWBLYGZ6kyGfGuXGcxlzq/N+UP9xW0reRn5JdCgJUFoTVwbGqWGSvwoIgYy+/niAwdPp/uj2xKNU+V3oqh6lkFjufN0txNvs7HO5oNvWem6oQ==; 5:pP4GsTjZJFqUO+vTFO/1biJSH6zHIcIngGrS+wsja229igxvdTuZdRBbHW+vEbna6LGaTug2f5R9S45Yrpe7Xun7HnZWEcjG30dMxEubwRljGKhhXY4YjgR3eQiLhSzOaOYXSbxaZ+JMbEIxR8avjTKpwidAzjNIY8EBbLD8BYo=; 24:G4UngcQHdat3teM5YLmpJpWifYKJI28DTRGollrX0ca129rxfQTgaZx392z2qWbVDIiXTCRWiu738w/67OhIqUt6SMeiPV4KhUlJanIeEDI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; OS2PR01MB1274; 7:uLyEeXhx2kAb6E9jxEknbCtI8ggaTr9zbazKckepdVn1QiCvcfB8Ao6pidFzBNcvwStKRNUcB+HyEDDclD7B0MX6tuDentaURu06vtXoMBzeaKHDWFsHCkClFxerPT86T7dvIoJENxbrZPwvH5r+n9FNEz8TYGszN4gdgsxH+ycq3/81SgQiiD8y3Ppi4BMY3qYGwI9evRXBNECI8+3lnW6AS7oE3+9ZeqTqLNTOMyHbLp+QxMjbt6EEsvlSlWWu; 20:+t+6DwSBGKR872u/vsZTzut99CBMBiFh4Dm5C+sHhRKDJKx1JBbzrBYDSWdY8rIjJnbMOaZqiNA8E+UsEtuLWD9iss2Zeph29TuYS27iNVYrjDRIcxzA5LtDoz9+sICTRvNco7LLNh3OAvUkM4fTRHGlWAPFynvsNxuB/qCcnaMqssGlSocNDXSnR8LQjJZQJkGTYULO7/jGTNgOnao/FQqLlCilg+p/GoYL8re6OrypaywdSusrPvMTL3AHSny0 X-MS-Office365-Filtering-Correlation-Id: 2198bc27-1dcd-446e-5e34-08d5ba86f5e7 X-OriginatorOrg: allied-telesis.co.jp X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2018 17:11:55.6445 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2198bc27-1dcd-446e-5e34-08d5ba86f5e7 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 1a8a37cf-9ecc-4cef-abb0-1ab01a15a6ad X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS2PR01MB1274 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180515_101213_107761_75EE4183 X-CRM114-Status: GOOD ( 15.43 ) X-Spam-Score: -0.6 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [216.82.243.198 listed in list.dnswl.org] -0.6 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [216.82.243.198 listed in wl.mailspike.net] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.0 T_DKIMWL_WL_MED DKIMwl.org - Whitelisted Medium sender X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , Marek Vasut , Tokunori Ikegami , Richard Weinberger , Joakim Tjernlund , Chris Packham , linux-mtd@lists.infradead.org, Cyrille Pitchen , Brian Norris , David Woodhouse Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Tokunori Ikegami To enable XIP it is executed both normal and error cases. This call can be moved after the for loop as same with erase chip. Signed-off-by: Tokunori Ikegami Cc: Joakim Tjernlund Cc: Chris Packham Cc: Brian Norris Cc: David Woodhouse Cc: Boris Brezillon Cc: Marek Vasut Cc: Richard Weinberger Cc: Cyrille Pitchen Cc: linux-mtd@lists.infradead.org --- Changes since v5: - None since this change is implemented by v6 patch series. drivers/mtd/chips/cfi_cmdset_0002.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c index 6adda4dc2007..6c681cbf2d37 100644 --- a/drivers/mtd/chips/cfi_cmdset_0002.c +++ b/drivers/mtd/chips/cfi_cmdset_0002.c @@ -2389,13 +2389,10 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip, chip->erase_suspended = 0; } - if (chip_good(map, adr, map_word_ff(map))) { - xip_enable(map, chip, adr); + if (chip_good(map, adr, map_word_ff(map))) break; - } if (time_after(jiffies, timeo)) { - xip_enable(map, chip, adr); printk(KERN_WARNING "MTD %s(): software timeout\n", __func__); ret = -EIO; @@ -2418,6 +2415,7 @@ static int __xipram do_erase_oneblock(struct map_info *map, struct flchip *chip, } chip->state = FL_READY; + xip_enable(map, chip, adr); DISABLE_VPP(map); put_chip(map, chip, adr); mutex_unlock(&chip->mutex);