From patchwork Tue Sep 17 07:05:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yann E. MORIN" X-Patchwork-Id: 1986302 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=buildroot.org (client-ip=140.211.166.137; helo=smtp4.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver=patchwork.ozlabs.org) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4X7CVM3R9Kz1y1t for ; Tue, 17 Sep 2024 17:05:47 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 7095D40D97; Tue, 17 Sep 2024 07:05:44 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id sp5MpqkszRLG; Tue, 17 Sep 2024 07:05:43 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 36B2441805 Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 36B2441805; Tue, 17 Sep 2024 07:05:43 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 441A71BF29A for ; Tue, 17 Sep 2024 07:05:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 3359341805 for ; Tue, 17 Sep 2024 07:05:41 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id nmj1Ez41XhaX for ; Tue, 17 Sep 2024 07:05:40 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=80.12.210.121; helo=smtp-out.orange.com; envelope-from=yann.morin@orange.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org A55EB40D97 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org A55EB40D97 Received: from smtp-out.orange.com (smtp-out.orange.com [80.12.210.121]) by smtp4.osuosl.org (Postfix) with ESMTPS id A55EB40D97 for ; Tue, 17 Sep 2024 07:05:38 +0000 (UTC) Received: from unknown (HELO opfedv1rlp0h.nor.fr.ftgroup) ([x.x.x.x]) by smtp-out.orange.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2024 09:05:36 +0200 Received: from unknown (HELO OPE16NORMBX305.corporate.adroot.infra.ftgroup) ([x.x.x.x]) by opfedv1rlp0h.nor.fr.ftgroup with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 17 Sep 2024 09:05:35 +0200 Received: from yd-6wlzhs3 [x.x.x.x] by OPE16NORMBX305.corporate.adroot.infra.ftgroup [x.x.x.x] with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 17 Sep 2024 09:05:34 +0200 Received: by yd-6wlzhs3 (sSMTP sendmail emulation); Tue, 17 Sep 2024 09:05:33 +0200 X-IronPort-AV: E=Sophos;i="6.10,234,1719871200"; d="scan'208";a="191942612" From: To: Date: Tue, 17 Sep 2024 09:05:33 +0200 Message-ID: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.115.27.51] X-ClientProxiedBy: OPE16NORMBX305.corporate.adroot.infra.ftgroup (10.115.27.10) To OPE16NORMBX305.corporate.adroot.infra.ftgroup (10.115.27.10) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.com; i=@orange.com; q=dns/txt; s=orange002; t=1726556740; x=1758092740; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=mRNu6UMsTPYYF9E09Eg8BV2r9Kel69Gto9hzwV8Y8Ig=; b=kHWxSZO1yLvUjdZHtU279rGTkuktJVNbIIwesHI+FeMjyjI5IL+k267m ijatdB2uQs2C8YDxCSuZ4NLEAOgX3lRcDTxuYWZbeLdUmOn7tfXbVwUwK 4u0AzGPrClzhvCXWPF9ATgswySuicEBGgwf20WC5g3IsM8CbVQUPm++8D QZkC9S364bBToc0mBndGBI8Vm7hX1H4BZqzqtPOz1IMZdr7/foCrU+aKy iq9wjZjcvwfgNUO+gbCjpcZzfkGFx5sGyFXU/HO1ZkfW0MYU8VtB5UngC GwPyTp9mziqlzV+NzNZ4YlM8QYN0GDzRinase7HI3Bd8n7QH/B45X0ReZ g==; X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=orange.com X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=orange.com header.i=@orange.com header.a=rsa-sha256 header.s=orange002 header.b=kHWxSZO1 Subject: [Buildroot] [PATCH] package/go: ensure there is a host-go provider, take 2 X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yann.morin@orange.com, "Yann E . MORIN" , Thomas Perale Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" From: "Yann E. MORIN" Commit 7b2a164b7460 (package/go/go-bin: new host-go provider) broke the case for prompt-less, host-only go packages, as the main host-go symbol would not be selected. This very same use-case was initially broken when the first go-src provider was introduced with fa2536ec9401 (package/go: make host package a virtual package), and subsequently fixed in 99a5d51c6e9f (package/go: ensure there is a host-go provider), so 7b2a164b7460 is causing a regression of a fixed regression. Fix that the very same way it was originally fixed. Signed-off-by: Yann E. MORIN Cc: Yann E. MORIN Cc: Thomas Perale --- package/go/Config.in.host | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/package/go/Config.in.host b/package/go/Config.in.host index 30260b573b..7e354b3298 100644 --- a/package/go/Config.in.host +++ b/package/go/Config.in.host @@ -78,13 +78,13 @@ config BR2_PACKAGE_HOST_GO_BIN endchoice +endif + config BR2_PACKAGE_PROVIDES_HOST_GO string - # Default to host-go-src + # Default to host-go-bin unless src explicitly requested default "host-go-src" if BR2_PACKAGE_HOST_GO_SRC - default "host-go-bin" if BR2_PACKAGE_HOST_GO_BIN - -endif + default "host-go-bin" source "package/go/go-bin/Config.in.host" source "package/go/go-bootstrap-stage1/Config.in.host"