From patchwork Sat Apr 28 11:29:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Kodanev X-Patchwork-Id: 906088 X-Patchwork-Delegate: jan.stancek@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.linux.it (client-ip=213.254.12.146; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=oracle.com header.i=@oracle.com header.b="K7uFW/O/"; dkim-atps=neutral Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40Y7dz63sCz9s08 for ; Sat, 28 Apr 2018 21:20:52 +1000 (AEST) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 0CE6D3E6338 for ; Sat, 28 Apr 2018 13:20:49 +0200 (CEST) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2]) by picard.linux.it (Postfix) with ESMTP id 27E9C3E6328 for ; Sat, 28 Apr 2018 13:20:47 +0200 (CEST) Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id 5F0256008DA for ; Sat, 28 Apr 2018 13:20:46 +0200 (CEST) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w3SBGZxM162663; Sat, 28 Apr 2018 11:20:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id; s=corp-2017-10-26; bh=ria6eMXP2n/FE+6LJMYdfWf/1wMbiGsA4e3X6sSo/w0=; b=K7uFW/O/uMQxEYlWAnJKO0MXrnORrMsVPdqBtWJiOj83GrmQ8V0zX8m+WkTNTjL/SJqv rMzUab9BBjGnZyLjW8URn0gKubVjDOcoMXYdccocNRvMLUyNNuDFhHXfVdb90laMhtCr a/b0TEufQ1xVhzdt2UDa2YqVejG8t0RouVwZfe27krk/f/vuqMLYIWbVZOntpHq+2lJA aJk4O8NHVJvpcEX7rmSGThX3EkXc1tL38NeP1I6FH907smBZ1gZPmKIdhUXv32Qy7CwM ubzDyF3Dc/+51aoyJKssu+oDUh7SrfROxIqrUAUO56RBGM1Gep0aXM6H7pw0HDWgffdD 1A== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2120.oracle.com with ESMTP id 2hmhmf8jjd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 28 Apr 2018 11:20:39 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w3SBKclO002499 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 28 Apr 2018 11:20:38 GMT Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w3SBKbIi004911; Sat, 28 Apr 2018 11:20:38 GMT Received: from ak.ru.oracle.com (/10.162.80.29) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 28 Apr 2018 04:20:37 -0700 From: Alexey Kodanev To: ltp@lists.linux.it Date: Sat, 28 Apr 2018 14:29:55 +0300 Message-Id: <1524914997-27080-1-git-send-email-alexey.kodanev@oracle.com> X-Mailer: git-send-email 1.7.1 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8876 signatures=668698 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1804280109 X-Virus-Scanned: clamav-milter 0.99.2 at in-2.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU, SPF_HELO_PASS, SPF_PASS autolearn=disabled version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on in-2.smtp.seeweb.it Subject: [LTP] [PATCH v3 1/3] lib/tst_checksum: add crc32c checksum X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.18 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" It will be used to make a SCTP packet in the test. Signed-off-by: Alexey Kodanev --- v3: use SPDX License-Identifier v2: As suggested by Cyril: * updated the docs, added section 2.2.25 * added 'tst_' prefix * changed type 'int' to 'size_t' for the buffer length doc/test-writing-guidelines.txt | 6 +++ include/tst_checksum.h | 16 ++++++++ lib/tst_checksum.c | 81 +++++++++++++++++++++++++++++++++++++++ 3 files changed, 103 insertions(+), 0 deletions(-) create mode 100644 include/tst_checksum.h create mode 100644 lib/tst_checksum.c diff --git a/doc/test-writing-guidelines.txt b/doc/test-writing-guidelines.txt index cbbfe6c..8e405a0 100644 --- a/doc/test-writing-guidelines.txt +++ b/doc/test-writing-guidelines.txt @@ -1366,6 +1366,12 @@ For reference to tainted kernels, see kernel documentation: Documentation/admin-guide/tainted-kernels.rst or https://www.kernel.org/doc/html/latest/admin-guide/tainted-kernels.html +2.2.25 Checksums +^^^^^^^^^^^^^^^^ + +CRC32c checksum generation is supported by LTP. In order to use it, the +test should include "tst_checksum.h" header, then can call tst_crc32c(). + 2.3 Writing a testcase in shell ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/include/tst_checksum.h b/include/tst_checksum.h new file mode 100644 index 0000000..4f43115 --- /dev/null +++ b/include/tst_checksum.h @@ -0,0 +1,16 @@ +/* SPDX-License-Identifier: GPL-2.0 + * Copyright (c) 2018 Oracle and/or its affiliates. All Rights Reserved. + */ + +#ifndef TST_CHECKSUM_H__ +#define TST_CHECKSUM_H__ + +#include +#include + +/* + * Generates CRC32c checksum. + */ +uint32_t tst_crc32c(uint8_t *buf, size_t buf_len); + +#endif diff --git a/lib/tst_checksum.c b/lib/tst_checksum.c new file mode 100644 index 0000000..9aaf9d4 --- /dev/null +++ b/lib/tst_checksum.c @@ -0,0 +1,81 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright (c) 2018 Oracle and/or its affiliates. All Rights Reserved. */ + +#include "tst_checksum.h" + +static const uint32_t crc32c_table[] = { + 0x00000000, 0xf26b8303, 0xe13b70f7, 0x1350f3f4, + 0xc79a971f, 0x35f1141c, 0x26a1e7e8, 0xd4ca64eb, + 0x8ad958cf, 0x78b2dbcc, 0x6be22838, 0x9989ab3b, + 0x4d43cfd0, 0xbf284cd3, 0xac78bf27, 0x5e133c24, + 0x105ec76f, 0xe235446c, 0xf165b798, 0x030e349b, + 0xd7c45070, 0x25afd373, 0x36ff2087, 0xc494a384, + 0x9a879fa0, 0x68ec1ca3, 0x7bbcef57, 0x89d76c54, + 0x5d1d08bf, 0xaf768bbc, 0xbc267848, 0x4e4dfb4b, + 0x20bd8ede, 0xd2d60ddd, 0xc186fe29, 0x33ed7d2a, + 0xe72719c1, 0x154c9ac2, 0x061c6936, 0xf477ea35, + 0xaa64d611, 0x580f5512, 0x4b5fa6e6, 0xb93425e5, + 0x6dfe410e, 0x9f95c20d, 0x8cc531f9, 0x7eaeb2fa, + 0x30e349b1, 0xc288cab2, 0xd1d83946, 0x23b3ba45, + 0xf779deae, 0x05125dad, 0x1642ae59, 0xe4292d5a, + 0xba3a117e, 0x4851927d, 0x5b016189, 0xa96ae28a, + 0x7da08661, 0x8fcb0562, 0x9c9bf696, 0x6ef07595, + 0x417b1dbc, 0xb3109ebf, 0xa0406d4b, 0x522bee48, + 0x86e18aa3, 0x748a09a0, 0x67dafa54, 0x95b17957, + 0xcba24573, 0x39c9c670, 0x2a993584, 0xd8f2b687, + 0x0c38d26c, 0xfe53516f, 0xed03a29b, 0x1f682198, + 0x5125dad3, 0xa34e59d0, 0xb01eaa24, 0x42752927, + 0x96bf4dcc, 0x64d4cecf, 0x77843d3b, 0x85efbe38, + 0xdbfc821c, 0x2997011f, 0x3ac7f2eb, 0xc8ac71e8, + 0x1c661503, 0xee0d9600, 0xfd5d65f4, 0x0f36e6f7, + 0x61c69362, 0x93ad1061, 0x80fde395, 0x72966096, + 0xa65c047d, 0x5437877e, 0x4767748a, 0xb50cf789, + 0xeb1fcbad, 0x197448ae, 0x0a24bb5a, 0xf84f3859, + 0x2c855cb2, 0xdeeedfb1, 0xcdbe2c45, 0x3fd5af46, + 0x7198540d, 0x83f3d70e, 0x90a324fa, 0x62c8a7f9, + 0xb602c312, 0x44694011, 0x5739b3e5, 0xa55230e6, + 0xfb410cc2, 0x092a8fc1, 0x1a7a7c35, 0xe811ff36, + 0x3cdb9bdd, 0xceb018de, 0xdde0eb2a, 0x2f8b6829, + 0x82f63b78, 0x709db87b, 0x63cd4b8f, 0x91a6c88c, + 0x456cac67, 0xb7072f64, 0xa457dc90, 0x563c5f93, + 0x082f63b7, 0xfa44e0b4, 0xe9141340, 0x1b7f9043, + 0xcfb5f4a8, 0x3dde77ab, 0x2e8e845f, 0xdce5075c, + 0x92a8fc17, 0x60c37f14, 0x73938ce0, 0x81f80fe3, + 0x55326b08, 0xa759e80b, 0xb4091bff, 0x466298fc, + 0x1871a4d8, 0xea1a27db, 0xf94ad42f, 0x0b21572c, + 0xdfeb33c7, 0x2d80b0c4, 0x3ed04330, 0xccbbc033, + 0xa24bb5a6, 0x502036a5, 0x4370c551, 0xb11b4652, + 0x65d122b9, 0x97baa1ba, 0x84ea524e, 0x7681d14d, + 0x2892ed69, 0xdaf96e6a, 0xc9a99d9e, 0x3bc21e9d, + 0xef087a76, 0x1d63f975, 0x0e330a81, 0xfc588982, + 0xb21572c9, 0x407ef1ca, 0x532e023e, 0xa145813d, + 0x758fe5d6, 0x87e466d5, 0x94b49521, 0x66df1622, + 0x38cc2a06, 0xcaa7a905, 0xd9f75af1, 0x2b9cd9f2, + 0xff56bd19, 0x0d3d3e1a, 0x1e6dcdee, 0xec064eed, + 0xc38d26c4, 0x31e6a5c7, 0x22b65633, 0xd0ddd530, + 0x0417b1db, 0xf67c32d8, 0xe52cc12c, 0x1747422f, + 0x49547e0b, 0xbb3ffd08, 0xa86f0efc, 0x5a048dff, + 0x8ecee914, 0x7ca56a17, 0x6ff599e3, 0x9d9e1ae0, + 0xd3d3e1ab, 0x21b862a8, 0x32e8915c, 0xc083125f, + 0x144976b4, 0xe622f5b7, 0xf5720643, 0x07198540, + 0x590ab964, 0xab613a67, 0xb831c993, 0x4a5a4a90, + 0x9e902e7b, 0x6cfbad78, 0x7fab5e8c, 0x8dc0dd8f, + 0xe330a81a, 0x115b2b19, 0x020bd8ed, 0xf0605bee, + 0x24aa3f05, 0xd6c1bc06, 0xc5914ff2, 0x37faccf1, + 0x69e9f0d5, 0x9b8273d6, 0x88d28022, 0x7ab90321, + 0xae7367ca, 0x5c18e4c9, 0x4f48173d, 0xbd23943e, + 0xf36e6f75, 0x0105ec76, 0x12551f82, 0xe03e9c81, + 0x34f4f86a, 0xc69f7b69, 0xd5cf889d, 0x27a40b9e, + 0x79b737ba, 0x8bdcb4b9, 0x988c474d, 0x6ae7c44e, + 0xbe2da0a5, 0x4c4623a6, 0x5f16d052, 0xad7d5351, +}; + +uint32_t tst_crc32c(uint8_t *buf, size_t buf_len) +{ + uint32_t crc = 0xffffffff; + + while (buf_len--) + crc = crc32c_table[(crc ^ (*buf++)) & 0xff] ^ (crc >> 8); + + return ~crc; +} From patchwork Sat Apr 28 11:29:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Kodanev X-Patchwork-Id: 906089 X-Patchwork-Delegate: jan.stancek@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.linux.it (client-ip=2001:1418:10:5::2; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=oracle.com header.i=@oracle.com header.b="XqRbMsle"; dkim-atps=neutral Received: from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40Y7f10RqHz9s0w for ; Sat, 28 Apr 2018 21:20:56 +1000 (AEST) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 1AFE53E634E for ; Sat, 28 Apr 2018 13:20:54 +0200 (CEST) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2]) by picard.linux.it (Postfix) with ESMTP id C34553E632C for ; Sat, 28 Apr 2018 13:20:52 +0200 (CEST) Received: from aserp2130.oracle.com (aserp2130.oracle.com [141.146.126.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id A7D4E6008C2 for ; Sat, 28 Apr 2018 13:20:51 +0200 (CEST) Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w3SBHxlr090178; Sat, 28 Apr 2018 11:20:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=corp-2017-10-26; bh=9fftr3zrcE5k8lmbnxh8Zl1BcYbDrsve2fgOorDtIkI=; b=XqRbMsle2SV9WWLdiOuKm3hXZtnV49YixDV7zxFfdLgbuLJqoD0oRmQ/PnwWLl6LX+8z 1/kVgMNmOiMvjYseLg9TbMTAJTpKbB3qECUgtAVDBxPAv0QV2g+LKb3ZelJwJCjZnBqx LPm9rLc0n6uDVjrx6vhgiMFsFnzl2XUakBJcFIPzcK6/fjpstN91edO1sF6A8r2Orht2 BBzeHRMP7N8aWyEXaHR/ODvVj1uIwrYDi+wv7PQLQ1FY0P4SdaEo6YSdWEV1Il4lmWAK UA8DQwbsRAALCYXFYq0QcYrjqeMxEQvDbQmTqydJIA28NNKKNmBQnU8z9vaR+LY4qU01 Jw== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp2130.oracle.com with ESMTP id 2hmeg5gqbq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 28 Apr 2018 11:20:40 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w3SBKdvU023725 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 28 Apr 2018 11:20:40 GMT Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w3SBKdTj004259; Sat, 28 Apr 2018 11:20:39 GMT Received: from ak.ru.oracle.com (/10.162.80.29) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 28 Apr 2018 04:20:38 -0700 From: Alexey Kodanev To: ltp@lists.linux.it Date: Sat, 28 Apr 2018 14:29:56 +0300 Message-Id: <1524914997-27080-2-git-send-email-alexey.kodanev@oracle.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1524914997-27080-1-git-send-email-alexey.kodanev@oracle.com> References: <1524914997-27080-1-git-send-email-alexey.kodanev@oracle.com> X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8876 signatures=668698 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1804280109 X-Virus-Scanned: clamav-milter 0.99.2 at in-2.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU, SPF_HELO_PASS, SPF_PASS autolearn=disabled version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on in-2.smtp.seeweb.it Subject: [LTP] [PATCH v3 2/3] sctp_big_chunk: make INIT packet in the test X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.18 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" Starting from 4.17-rc2 kernel or the kernels that don't have commit 40b4f0fd74e4 ("sctp: lack the check for ports in sctp_v6_cmp_addr"), the test can't bind equal IPv6 addresses to a socket: safe_net.c:160: BROK: sctp_big_chunk.c:77: setsockopt(4, 132, 100, 0x7ffc7f11e498, 91644) failed: EINVAL Since creating many different IP addresses and binding them to the same SCTP socket is a time consuming process, prepare SCTP INIT chunk in the test. That should fix EINVAL error returned by setsockopt() for the mentioned kernels. Signed-off-by: Alexey Kodanev Reviewed-by: Xiao Yang --- v3: * changed commit message v2: * the test doesn't support IPv6 fragmentation, TCONF in that case * add needs_root since we use a raw socket runtest/cve | 1 - testcases/network/sctp/sctp_big_chunk.c | 105 +++++++++++++++++++++++++++---- 2 files changed, 93 insertions(+), 13 deletions(-) diff --git a/runtest/cve b/runtest/cve index 1d9569a..2f4171c 100644 --- a/runtest/cve +++ b/runtest/cve @@ -33,4 +33,3 @@ cve-2017-17052 cve-2017-17052 cve-2017-16939 cve-2017-16939 cve-2017-17053 cve-2017-17053 cve-2018-5803 sctp_big_chunk -cve-2018-5803_2 sctp_big_chunk -a 10000 diff --git a/testcases/network/sctp/sctp_big_chunk.c b/testcases/network/sctp/sctp_big_chunk.c index 55a2969..89c5e0d 100644 --- a/testcases/network/sctp/sctp_big_chunk.c +++ b/testcases/network/sctp/sctp_big_chunk.c @@ -24,12 +24,14 @@ #include #include #include +#include +#include #include #include -#include #include "tst_test.h" #include "tst_safe_stdio.h" +#include "tst_checksum.h" #include "lapi/netinet_in.h" #include "lapi/socket.h" #include "lapi/sctp.h" @@ -38,6 +40,8 @@ static int port; static int sfd, cfd; static struct sockaddr_in6 rmt, loc; +static uint8_t packet[IP_MAXPACKET]; +static int pkt_len; static char *addr_param; static int addr_num = 3273; @@ -53,35 +57,108 @@ static void setup_server(void) tst_res(TINFO, "sctp server listen on %d", port); SAFE_LISTEN(sfd, 1); + + srand(port); +} + +static void update_packet_field(size_t *off, void *buf, size_t buf_len) +{ + memcpy(packet + *off, buf, buf_len); + *off += buf_len; } static void setup_client(void) { - struct sockaddr_in6 addr_buf[addr_num]; + struct ip6_hdr ip6; + const size_t ip6_hdr_len = sizeof(ip6); + size_t cmn_hdr_off; + size_t off; int i; - cfd = SAFE_SOCKET(AF_INET6, SOCK_STREAM, IPPROTO_SCTP); + memset(&ip6, 0, sizeof(ip6)); + ip6.ip6_flow = htonl(6 << 28 | 2 << 20); + ip6.ip6_hops = 64; + ip6.ip6_nxt = IPPROTO_SCTP; + ip6.ip6_src.s6_addr[15] = 1; + ip6.ip6_dst.s6_addr[15] = 1; rmt.sin6_family = AF_INET6; rmt.sin6_addr = in6addr_loopback; - rmt.sin6_port = htons(port); - tst_res(TINFO, "bind %d additional IP addresses", addr_num); + /* SCTP common header */ + off = ip6_hdr_len; + + uint16_t src_port = htons(port - 1); + uint16_t dst_port = htons(port); + uint32_t vtag = 0; + uint32_t checksum = 0; + + update_packet_field(&off, &src_port, 2); + update_packet_field(&off, &dst_port, 2); + update_packet_field(&off, &vtag, 4); + update_packet_field(&off, &checksum, 4); + cmn_hdr_off = off; + + /* SCTP INIT chunk */ + uint16_t chunk_len; + + packet[off++] = 1; + packet[off++] = 0; + off += 2; /* chunk length, will be set in the end */ + + uint32_t init_tag = rand(); + uint32_t rwnd = htonl(106496); + uint16_t outs = htons(10); + uint16_t ins = htons(65535); + uint32_t init_tsn = rand(); + + update_packet_field(&off, &init_tag, 4); + update_packet_field(&off, &rwnd, 4); + update_packet_field(&off, &outs, 2); + update_packet_field(&off, &ins, 2); + update_packet_field(&off, &init_tsn, 4); - memset(addr_buf, 0, sizeof(addr_buf)); + /* SCTP optional parameter for IPv6 addresses */ + uint16_t param_type = htons(6); + uint16_t param_len = htons(20); + + /* IPv6(40) + SCTP_COMMON(12) + SCTP_CHUNK(20) + SCTP_OPT(65460)) */ for (i = 0; i < addr_num; ++i) { - addr_buf[i].sin6_family = AF_INET6; - addr_buf[i].sin6_addr = in6addr_loopback; + update_packet_field(&off, ¶m_type, 2); + update_packet_field(&off, ¶m_len, 2); + packet[off + 15] = 1; + off += 16; } + pkt_len = off; + + tst_res(TINFO, "set chunk length %zu", pkt_len - cmn_hdr_off); + chunk_len = htons(pkt_len - cmn_hdr_off); + memcpy(packet + cmn_hdr_off + 2, &chunk_len, 2); + + /* set checksum for SCTP: common header + INIT chunk */ + uint32_t csum = tst_crc32c(packet + ip6_hdr_len, pkt_len - ip6_hdr_len); + + memcpy(packet + ip6_hdr_len + 8, &csum, 4); + + ip6.ip6_plen = htons(pkt_len - ip6_hdr_len); + memcpy(packet, &ip6, ip6_hdr_len); - SAFE_SETSOCKOPT(cfd, SOL_SCTP, SCTP_SOCKOPT_BINDX_ADD, addr_buf, - sizeof(addr_buf)); + cfd = SAFE_SOCKET(AF_INET6, SOCK_RAW, IPPROTO_RAW); } +static const char mtu_path[] = "/sys/class/net/lo/mtu"; +static const unsigned int max_mtu = 65535; +static unsigned int mtu; + static void setup(void) { if (tst_parse_int(addr_param, &addr_num, 1, INT_MAX)) tst_brk(TBROK, "wrong address number '%s'", addr_param); + /* We don't fragment IPv6 packet here yet, check that MTU is 65535 */ + SAFE_FILE_SCANF(mtu_path, "%d", &mtu); + if (mtu < max_mtu) + tst_brk(TCONF, "Test needs that 'lo' MTU has %d", max_mtu); + setup_server(); setup_client(); } @@ -89,6 +166,7 @@ static void setup(void) static void run(void) { int pid = SAFE_FORK(); + int i; if (!pid) { struct sockaddr_in6 addr6; @@ -99,8 +177,10 @@ static void run(void) exit(0); } - fcntl(cfd, F_SETFL, O_NONBLOCK); - connect(cfd, (struct sockaddr *)&rmt, sizeof(rmt)); + for (i = 0; i < 3; ++i) { + SAFE_SENDTO(1, cfd, packet, pkt_len, 0, + (struct sockaddr *)&rmt, sizeof(rmt)); + } SAFE_KILL(pid, SIGKILL); SAFE_WAITPID(pid, NULL, 0); @@ -114,6 +194,7 @@ static struct tst_option options[] = { }; static struct tst_test test = { + .needs_root = 1, .setup = setup, .forks_child = 1, .test_all = run, From patchwork Sat Apr 28 11:29:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Kodanev X-Patchwork-Id: 906090 X-Patchwork-Delegate: jan.stancek@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.linux.it (client-ip=213.254.12.146; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=oracle.com header.i=@oracle.com header.b="Bv8/x2cV"; dkim-atps=neutral Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40Y7f43mN5z9s08 for ; Sat, 28 Apr 2018 21:21:00 +1000 (AEST) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 0E7C53E6402 for ; Sat, 28 Apr 2018 13:20:58 +0200 (CEST) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [IPv6:2001:4b78:1:20::5]) by picard.linux.it (Postfix) with ESMTP id 781573E638A for ; Sat, 28 Apr 2018 13:20:55 +0200 (CEST) Received: from aserp2130.oracle.com (aserp2130.oracle.com [141.146.126.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 6236A600481 for ; Sat, 28 Apr 2018 13:20:54 +0200 (CEST) Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w3SBGt3M089826; Sat, 28 Apr 2018 11:20:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=corp-2017-10-26; bh=17cOE4ESmF90mbRhdoogu9B215qsZAA3fEW1At74XYY=; b=Bv8/x2cV9obZ7rfIXlDiqIAzWc97c9iNv2Iw3OnvjT1oiwdknwGJcDtFLdXLzUtb5DhY WVEFL+3fwORz8/GDQ49mG1dbrfuI0YzA+LW9UjJ6d7H0a1dxVHU0us5tacxEzV6yrVB8 W/YEr7Zco3SzZzEI3tVNZteXixKv86+wKoIEZXHTmj+xeQAzDMuOpOIqHbgrBHlZ3K6J 3Rh8xSzNTZj/enGuIxDireoI7Udsoq/iDbV9hKe/85Wa1+AlZJtSzSIarKWpRuMzq/Ed PbNtOb0xDHHwv1B597sMkca8I6pSWOU60D2GnOGsnbVULTQCl6AJCS8mkAGkarX7iblr QA== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2130.oracle.com with ESMTP id 2hmeg5gqbu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 28 Apr 2018 11:20:45 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w3SBKinZ002568 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 28 Apr 2018 11:20:44 GMT Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w3SBKfpb017477; Sat, 28 Apr 2018 11:20:42 GMT Received: from ak.ru.oracle.com (/10.162.80.29) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 28 Apr 2018 04:20:40 -0700 From: Alexey Kodanev To: ltp@lists.linux.it Date: Sat, 28 Apr 2018 14:29:57 +0300 Message-Id: <1524914997-27080-3-git-send-email-alexey.kodanev@oracle.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1524914997-27080-1-git-send-email-alexey.kodanev@oracle.com> References: <1524914997-27080-1-git-send-email-alexey.kodanev@oracle.com> X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8876 signatures=668698 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=766 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1804280109 X-Virus-Scanned: clamav-milter 0.99.2 at in-5.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU, SPF_HELO_PASS, SPF_PASS autolearn=disabled version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on in-5.smtp.seeweb.it Subject: [LTP] [PATCH v3 3/3] sctp_big_chunk: use SPDX-License-Identifier GPL-2.0 X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.18 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" Signed-off-by: Alexey Kodanev --- v3: new patch in v3 testcases/network/sctp/sctp_big_chunk.c | 17 ++--------------- 1 files changed, 2 insertions(+), 15 deletions(-) diff --git a/testcases/network/sctp/sctp_big_chunk.c b/testcases/network/sctp/sctp_big_chunk.c index 89c5e0d..333e502 100644 --- a/testcases/network/sctp/sctp_big_chunk.c +++ b/testcases/network/sctp/sctp_big_chunk.c @@ -1,18 +1,5 @@ -/* - * Copyright (c) 2018 Oracle and/or its affiliates. All Rights Reserved. - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; either version 2 of - * the License, or (at your option) any later version. - * - * This program is distributed in the hope that it would be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program. If not, see . +// SPDX-License-Identifier: GPL-2.0 +/* Copyright (c) 2018 Oracle and/or its affiliates. All Rights Reserved. * * Regression test-case for the crash caused by over-sized SCTP chunk, * fixed by upstream commit 07f2c7ab6f8d ("sctp: verify size of a new