From patchwork Wed Apr 25 14:56:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 904282 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=sparclinux-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="liyqfVC8"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40WNZJ3tNtz9ryk for ; Thu, 26 Apr 2018 00:56:40 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754300AbeDYO4j (ORCPT ); Wed, 25 Apr 2018 10:56:39 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:38838 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754534AbeDYO4X (ORCPT ); Wed, 25 Apr 2018 10:56:23 -0400 Received: by mail-pf0-f195.google.com with SMTP id o76so10734669pfi.5; Wed, 25 Apr 2018 07:56:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=SpDT0eD7ipBfSNoU2ChCB74GmDGzwiGTgCZyq0WNOUs=; b=liyqfVC8efwcdVR8sYXn9ZwaHwRrelPHaOLOVU09vuBzI603uTgrTMzhisMzY7CjTI D1Tlp/fwdf738BasTvh/Wtp5HEfDqWqC2O78UZLOJfW8xtFGJNeyRGFlDAc9F9/AL05I dlyYecAoBEbjxmODdhSeb3j1d46s1TCWW3aN2J/fwS+o6sb2C7uw6tvW+HpAChsBH+HM CzQZIZgNFTHHcYlj5WhOpPBNjtTNMYNDbhzuVP93zNIqCyna24v1i84vnQZUBeQ2cGQG Pn36TyyeWa7BpVEeYhjh1bcNf7EMPUXji345qWCKF9nk7CiS9D4NY57sPnpJ4Y7qo9Ke CoOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=SpDT0eD7ipBfSNoU2ChCB74GmDGzwiGTgCZyq0WNOUs=; b=BrxzwlVKti6gnlI2rWvZEqLHiQtJawLSATCq08Atli48L9VAAQ5XvMKfFRPUCclObP NsKRUVHa3+n22XL1ow6qz/EdyO4qz9APRyW+uuU6voHjekPtcJUBJwcQMvWXxHfCqG3v XhpaZdzXh8IRie1P/n55DvBcFmjOYo0f4iFnb/x+E7mFn7SWNuirVPkKDnNWQJCl9k0I yS/Ow8y0+N02vRx9q+RbU3ElEx1TssIqBclrY88Fe0z+2Q23y3GVyWeRYffky5+k75jo jl7eqvbGhC8Dmz19ffMMrahTajdqCEFkmnWEutHHIobMlCyzcxqB5CvW/fFlfF02orfk PTWQ== X-Gm-Message-State: ALQs6tDP4Os3CyuVW9X+f4cIvE6mbaGKcFv/BbLXKEW8qdVQwgs+laJy 01fK4q+bo3aiZIz4ibBVI7I= X-Google-Smtp-Source: AIpwx4/VWOQX050JgxBKOJYt9F/fJJbchfo4gt0RBfCXUy+l4PZ/+ZZ7JhRYHMKJNUYynirwgAFh5g== X-Received: by 2002:a17:902:2826:: with SMTP id e35-v6mr29543236plb.348.1524668183146; Wed, 25 Apr 2018 07:56:23 -0700 (PDT) Received: from localhost.localdomain ([106.51.29.61]) by smtp.gmail.com with ESMTPSA id l19sm24911495pgn.44.2018.04.25.07.56.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 25 Apr 2018 07:56:22 -0700 (PDT) From: Arvind Yadav To: davem@davemloft.net, shannon.nelson@oracle.com, jag.raman@oracle.com, liam.merwick@oracle.com Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org Subject: [PATCH] sparc: vio: use put_device() instead of kfree() Date: Wed, 25 Apr 2018 20:26:14 +0530 Message-Id: X-Mailer: git-send-email 2.7.4 Sender: sparclinux-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: sparclinux@vger.kernel.org Never directly free @dev after calling device_register(), even if it returned an error. Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- arch/sparc/kernel/vio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sparc/kernel/vio.c b/arch/sparc/kernel/vio.c index 1a0fa10..32bae68 100644 --- a/arch/sparc/kernel/vio.c +++ b/arch/sparc/kernel/vio.c @@ -403,7 +403,7 @@ static struct vio_dev *vio_create_one(struct mdesc_handle *hp, u64 mp, if (err) { printk(KERN_ERR "VIO: Could not register device %s, err=%d\n", dev_name(&vdev->dev), err); - kfree(vdev); + put_device(&vdev->dev); return NULL; } if (vdev->dp)