From patchwork Fri May 3 11:26:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1930996 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=YYeDgxqC; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=lxWR3kVV; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=YYeDgxqC; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=lxWR3kVV; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VW7nD1rpYz1ydX for ; Fri, 3 May 2024 21:27:11 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 65CA0384641E for ; Fri, 3 May 2024 11:27:09 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 17BC53858C66 for ; Fri, 3 May 2024 11:26:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 17BC53858C66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 17BC53858C66 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714735579; cv=none; b=kfo1yTwHed1ZqBjOgDH1L85e5qP7qz17sJ/rSM7Lh6JFPpdU+XjlHjsXyFOWmYFn0YzhPAh6RLPWV4D2SLBWLQQzyjmCnXGC7jhFNEMWpn7SkXhzMofGPQafKa7lXE4H7ELvZNEUN0BWJGjdjzyFonLVDMxRQZL1Yxieu6lhRUk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714735579; c=relaxed/simple; bh=L/wwhSJg7rHL2kWy24faBvsPTJ9hFztBmJezQ4UOUGk=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version:Message-Id; b=dla71njFgR+posMu72+DGkX+x8o1BHt6vzc+2SfSFgQOM/Ku8bhH15AUy3QGyvHd/4uULeq/yrec/J4ImXdm2X8+GlFAEjc6htsBy9knFfXCYASBw96V438mPt8xOcgsYmWCyqKv9YPw0cf3y5XOssQ20MADSioJQBTPq1NxceI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0B15222DC1 for ; Fri, 3 May 2024 11:26:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1714735577; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=Raa8eTcs+QlVzJ3ddGq8jfJIFUI6Q08wGuzMTX604zE=; b=YYeDgxqCN29lkM/Bo+L2SfoS5kKDvimnW/Ft2vO441R3biFw0JGSuw765Mh5JL1upwzbdj zXDI87RXB8jaUgq5Ab6CsaIo4XtwzajQH3YM1sGNf4VuKcctOESCtF8gMXqsx7h8nHb66u VreNjd0HpHSh/e1DYUsbnmvKKDnrFeM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1714735577; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=Raa8eTcs+QlVzJ3ddGq8jfJIFUI6Q08wGuzMTX604zE=; b=lxWR3kVVjbWAKyb+wt6zMZANqZ8LuP3bfwah8Lyf5IRjiaRj9xZL3JQkm2Hdx0zjjOwKVB nFZ29si4x2EEwZCQ== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1714735577; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=Raa8eTcs+QlVzJ3ddGq8jfJIFUI6Q08wGuzMTX604zE=; b=YYeDgxqCN29lkM/Bo+L2SfoS5kKDvimnW/Ft2vO441R3biFw0JGSuw765Mh5JL1upwzbdj zXDI87RXB8jaUgq5Ab6CsaIo4XtwzajQH3YM1sGNf4VuKcctOESCtF8gMXqsx7h8nHb66u VreNjd0HpHSh/e1DYUsbnmvKKDnrFeM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1714735577; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=Raa8eTcs+QlVzJ3ddGq8jfJIFUI6Q08wGuzMTX604zE=; b=lxWR3kVVjbWAKyb+wt6zMZANqZ8LuP3bfwah8Lyf5IRjiaRj9xZL3JQkm2Hdx0zjjOwKVB nFZ29si4x2EEwZCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D8A5E139CB for ; Fri, 3 May 2024 11:26:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id O7cCM9jJNGbcWAAAD6G6ig (envelope-from ) for ; Fri, 03 May 2024 11:26:16 +0000 Date: Fri, 3 May 2024 13:26:16 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] Add default bitmap obstack allocation check MIME-Version: 1.0 Message-Id: <20240503112616.D8A5E139CB@imap1.dmz-prg2.suse.org> X-Spam-Level: X-Spamd-Result: default: False [-1.62 / 50.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; BAYES_HAM(-0.32)[75.51%]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; PREVIOUSLY_DELIVERED(0.00)[gcc-patches@gcc.gnu.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns] X-Spam-Score: -1.62 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org The following adds a check that the global bitmap obstack is initialized when allocating a bitmap from it. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. * bitmap.cc (bitmap_alloc): When using the global bitmap obstack assert that is initialized. --- gcc/bitmap.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gcc/bitmap.cc b/gcc/bitmap.cc index 459e32c1ad1..0905cde696f 100644 --- a/gcc/bitmap.cc +++ b/gcc/bitmap.cc @@ -781,7 +781,10 @@ bitmap_alloc (bitmap_obstack *bit_obstack MEM_STAT_DECL) bitmap map; if (!bit_obstack) - bit_obstack = &bitmap_default_obstack; + { + gcc_assert (bitmap_default_obstack_depth > 0); + bit_obstack = &bitmap_default_obstack; + } map = bit_obstack->heads; if (map) bit_obstack->heads = (class bitmap_head *) map->first;