From patchwork Thu May 2 13:33:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Coplan X-Patchwork-Id: 1930625 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=ArIqlK9X; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=ArIqlK9X; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VVZfw4frNz20fb for ; Thu, 2 May 2024 23:34:48 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 95757385840A for ; Thu, 2 May 2024 13:34:46 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2052.outbound.protection.outlook.com [40.107.105.52]) by sourceware.org (Postfix) with ESMTPS id 8F99F3858D33 for ; Thu, 2 May 2024 13:34:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8F99F3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8F99F3858D33 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.105.52 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1714656860; cv=pass; b=XoVWnDkxTumrLAr5va0IJAm6BamPWiHxz89E6oAd2xKDrG0xtr9g/HQHXrPtsjdz+ZBiIYOYGnFYaBLweeGBUK4JmO3bh2gH0EahyxnMBhprKy1/dz9/hs5L680VHj56cfr+taFnWi7H5ezdZAYDxNaB2BIGxJnijDd0YoyLumY= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1714656860; c=relaxed/simple; bh=SKQIZzL0xkbTC1v8/pVvuwTxuKCa+8Arl10WanADV/M=; h=DKIM-Signature:DKIM-Signature:Date:From:To:Subject:Message-ID: MIME-Version; b=JgXK9nWOwVLtxvBfN+mueESL9l5f1l9BBKY08CH+d+pQWcy83NMxFu6onSwGyJly2p1DwueICVYfIDlV/Sbp4zvmNxp4Kas7tNqhXjAQLvCRZmZM/L967KmCHdbh9BiRt6TUPowy5++ecbcCdXR8+NhmoEs+FlqP7R3nbIx7pTc= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=gMWg7Xay/ZlZG3SGRMjXxtNfqxbCnZyEJFoHfWkaYDd3R+cqiazxwdiFhRmXwT1bz6unbjdGzgBtVL7IiDfGrMPDf8gQBFVq+bBs2Nz13lOoa33IQizabPTcC2joMwyXSMHoALtu0tbt+D2mVS9kTqkGpgF/l3Oc6u6+NODDwj6kyqKO1c56L4cC1Tttsez9LlZ27lIIORZs1tAVFYXV3gTzrHmyFZsDjFHfSc9wHGILp2psAbKvUCubNYza/Z8VQJhmjRvi6NvAvofJauZ/po50vweA6Q0HyVMaYVzWpvdr9c0JoC6Q3DBf8MjjkOhpnyFD0x5Xh8BD0TPvcxtLFw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=reQfKRZJ6a6/o3ji5rOc/gvz39emJcXDf6OnnijWWg4=; b=KpoJpLohyX0oYRfcWcSSS/Yhfcmw40qXUfbCH5ZDm4JyiZICVeatORORQ7Y7Xk2Dror8wFrG/zBYZtlHTLndYM9bqLZAnPAx0iLv3LG6J+hdbafHewAet7QzhXZXJBfil9i96C2T54Qle2OqXO90KaRrK9GmvB1UIBmLFDYUKxqsHcVCr8yLqu38zqtbX9zz2CjXikKj86uXqf8MxfYTMC44InubIdkD7MjbdnxMblLgtiTBD1WD4/Xv+SkC9cV5q7/vc7ynQjLL+WaB1HtxFxGUnzlqoqIZlAC9VpIdBHNO+1e0TM+JrLUYoeL/l9RndBlafCo5b8ct2GQrqobikw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=reQfKRZJ6a6/o3ji5rOc/gvz39emJcXDf6OnnijWWg4=; b=ArIqlK9XoSN1zcz7jDC2gmpYNrMgiSBPWU/FiSsjAFzhfFNLKGYHgnmFyI31BkHTMPNL5i6H3bL/ElsVAPGxoPyRriuFR2PJPfovUHc8U0WTGcZXm99uC1e/VxMbcygO0yPKWw/5B0LzPE8iWA7IqAQNTSXoVgaJezf8/O2GCvY= Received: from DU2PR04CA0309.eurprd04.prod.outlook.com (2603:10a6:10:2b5::14) by AM9PR08MB6065.eurprd08.prod.outlook.com (2603:10a6:20b:2dd::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.29; Thu, 2 May 2024 13:34:11 +0000 Received: from DU2PEPF00028D01.eurprd03.prod.outlook.com (2603:10a6:10:2b5:cafe::23) by DU2PR04CA0309.outlook.office365.com (2603:10a6:10:2b5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.29 via Frontend Transport; Thu, 2 May 2024 13:34:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DU2PEPF00028D01.mail.protection.outlook.com (10.167.242.185) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7544.18 via Frontend Transport; Thu, 2 May 2024 13:34:11 +0000 Received: ("Tessian outbound 082664cc04c1:v315"); Thu, 02 May 2024 13:34:11 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 8f191ef642bcf380 X-CR-MTA-TID: 64aa7808 Received: from 1732a1cf820b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6C5E746D-55D2-40FF-8C06-7899285BDE21.1; Thu, 02 May 2024 13:33:37 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1732a1cf820b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 02 May 2024 13:33:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IAuIiYp3ovzxv04sHiRp6DMA8wulAbz9pw2i87SnwtmsRqb086nkCXaUtUfiUeBtIO/oxQCSrA28tc2JfDgiMLknj44Ex+E1iNA4Ox2nw3ulv1HrO6g6WuXA+uuhuwoSIyRX0dSZAe23U6QohfmwmNX4ksLRUDQvLWy9LFsRhD9wvbx+c6OYeK/JU1uMfvunyb5wCFmmXY1g9MHebKzIqQ5LqSoQcoZVENMXgkRxPAe6nyCqi/pS+JLOjQ/j0LyZz7n2GKD7lLJtAdFh/0pSo06PylUhjgSQrnCsGMQzO4I5gx6tvojXIbiHxJBXJigirbc2/XYKFg0nBnzCim+gWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=reQfKRZJ6a6/o3ji5rOc/gvz39emJcXDf6OnnijWWg4=; b=hJTft4AxtyDOJPBQWfRhG2nANHl2UVZnO73UTkvV3j6Z7NjSf1csKB17+xYUoyIs09FyxHSXhnzh8uSy7NSJxr1JYuFSXgkd8QvadfA191bux9T39BkIMfYD1sHUXGLfMmBWU69Z3UZiKA7vpHPPd+oqmTBv5jM4p01WdxGxkz/y9txjOtFSmpdfhlG7iUCW+t8FxDZwVUAJPALG+8wVHW6bfvpNOdz/fQ9JjAkkvZa20ApktEzOB32FVWJ1UjKIGfYqJ/fRUrV2q9L2t6Kj58Lvtb88U8G+WJX+5pe+eeZrr+njy2kzOLXyHCAukbekNNFBxAuzP84glLzkH8vepw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=reQfKRZJ6a6/o3ji5rOc/gvz39emJcXDf6OnnijWWg4=; b=ArIqlK9XoSN1zcz7jDC2gmpYNrMgiSBPWU/FiSsjAFzhfFNLKGYHgnmFyI31BkHTMPNL5i6H3bL/ElsVAPGxoPyRriuFR2PJPfovUHc8U0WTGcZXm99uC1e/VxMbcygO0yPKWw/5B0LzPE8iWA7IqAQNTSXoVgaJezf8/O2GCvY= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from PAWPR08MB8958.eurprd08.prod.outlook.com (2603:10a6:102:33e::15) by GVXPR08MB11129.eurprd08.prod.outlook.com (2603:10a6:150:1fc::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.28; Thu, 2 May 2024 13:33:34 +0000 Received: from PAWPR08MB8958.eurprd08.prod.outlook.com ([fe80::9f32:dc2a:5bec:aeac]) by PAWPR08MB8958.eurprd08.prod.outlook.com ([fe80::9f32:dc2a:5bec:aeac%3]) with mapi id 15.20.7519.031; Thu, 2 May 2024 13:33:34 +0000 Date: Thu, 2 May 2024 14:33:32 +0100 From: Alex Coplan To: gcc-patches@gcc.gnu.org Cc: Richard Biener , Jeff Law Subject: cfgrtl: Fix MEM_EXPR update in duplicate_insn_chain [PR114924] Message-ID: Content-Disposition: inline X-ClientProxiedBy: LO4P123CA0558.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:33b::14) To PAWPR08MB8958.eurprd08.prod.outlook.com (2603:10a6:102:33e::15) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: PAWPR08MB8958:EE_|GVXPR08MB11129:EE_|DU2PEPF00028D01:EE_|AM9PR08MB6065:EE_ X-MS-Office365-Filtering-Correlation-Id: d196af3f-afdf-4178-1340-08dc6aac8d2f x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230031|366007|1800799015|376005; X-Microsoft-Antispam-Message-Info-Original: neEUAnBUn33Hq3e0Z3XXGxlSjW23bPER4ka/tr/cFCsQVfvt4D/QmLVLGUvNkZ9aIKu+7YjH8qMBw3O0mlYfcVJhMFDMebftLsbzCJex84G+BcdEMOGVR3eZCPvVmTCr2RLkZXoT+R++Zvshz+K4ZjGCMUmXKKoAe0IcHluROvtA+T2E7ifKP6QdwJRIpa4p4Ph/vmqmRQOGgWk2YtKBaSsC0vpoYccXVhyok2UhXI0rXCVmweFPUKcSDRPt5z7VSY0VHIdIi+dhLvav7N9uw/KHPG2j4KYpkEdzro2srdYPnU8y23b17IE0uU178xJHA5rx5zfXvra5phRuWxkGzzsURRBuBDWJcll8cKJlZuPOdZ6+ELrsE5uPdAOZ7FixAJm59toZwsinetu7I6sfK91bGzFg+TwtiWMcRZn2QybD81RLrVGE9BKrVzVqvW027OuMif110zxVdtTSU2g/DkhBq6mp3cnouJCX+gqfFTyABlmhDoV87WZsd7ehUXjCodrW1QKpC5RYsvPRSL9+SfmxTw9hQMeJpRNTZM+85qRX2LX9hOpEQvROQxVqeRdZIUtRwDExEAn1tE5fKjHOsgVpSH1GsvaGZAAYQN8wQf/+JK9vw7F0O37+RnutEFGd07iU+kP1HzdJ5SpZRuaXxKPsrG4B/G9JtLBubWdnQGaGf72ONI2AG1VBRxSr47fwM6NSjvVoTa63+sc/cenXDi10BNhVWIXqNJo5PCPbuq+iuVq3hnC9KuxUjJ4nRboUN+xskbc6xcHbnM/SB3MJstnaZ7ACT1UzH/sHM5XrfrFYbl3Iwb+EXcH9fP4Rl8V2nvQPBiA0XgUEw4Mg1ZKstYaZoqFvHpwptqteR8VaTIxE4GFokIQFoFib9Qtkv/CcXSW0cFN0o1eslkIapfWBC0BhploC5bCmugVW1JH18IbRN+oUJ2A6ZZH7Tcz8kdTwdgg/z+ticPExQ8ap1LcLnXuBEPjTHbSKMdmDHaKcHj9oI0FUMs/HyxoceQj6POvaH74C2UroALPcClXwneckdGJa0JTXetyPXEaCMZ2b39ZR1nciVC193DuSwmElfTsEnR/qyO4ppifKXI7JUKqElQhuJ+tsO6JJiY2e13J4mnWyvC86WhoOe4qsYkpBwHM6+n28V/JPPq4a3tNyeEq/dKHHmlJNq4NH3Ki2tj7tgoz57JLVJWLl0Hj/bcqSwtX4UboqgKzwQEYAbx7OMMyM3cErqKcT9pGRkZt9+mzR5ivZX+eKAgZkLwsEQzk+G8NEUTmYccDGrTKTDKCu5tbriA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAWPR08MB8958.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB11129 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU2PEPF00028D01.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5b00e1b9-1a59-4009-0b4e-08dc6aac76d6 X-Microsoft-Antispam: BCL:0; ARA:13230031|376005|1800799015|36860700004|35042699013; X-Microsoft-Antispam-Message-Info: =?utf-8?q?oF32omPT8oL/SSMcFsORb3Fan/68AN3?= =?utf-8?q?cYBnViVQhBqEf70HL8BZ1jiIiuiWY4C++497KPDaDZ5qYfOty+5qTx8KwWOKi4xVJ?= =?utf-8?q?G17Q57u5v0wohk1HSRhFazML4L+CI/53nDOJISCEmR0YmKH5I8poNT4Z6Onyb/5et?= =?utf-8?q?7ChEMfC61v09oswm/vKic78p+fWX9QwQ9PZ3qzu8GiqDhw3k025q+PBwrofiN1XVY?= =?utf-8?q?H+KUguvw137tQhPJAjWGWpyBALgFJIPAyjdxMc5voegrxoyG+Us2j6PtUnnA42Atz?= =?utf-8?q?IJjWnpQRYeK5BEME6i5nV8eF1/yqIKCmIBtNeErEKUjDjtCl8gbD1YjwtOLiWU6xJ?= =?utf-8?q?gA36J8UC0iw00LJgNM2k/2m9T66hCt17qWKc2rqDM0/PA9sEvow1avC4oG6lDjX/F?= =?utf-8?q?VqGKuoyq2vXuCuNzo9K8OoYPaASP0+VYIH4goHiZvMGmgymuJJZh6wMQx9aYMUNHX?= =?utf-8?q?vQrWc8StCRlz+hAchRffwfZIHbD17APk5OcPD8E66nwEgSD3AcIrpVkRB3heWmSta?= =?utf-8?q?qnnE0axodCrRsWhBJZs5FQvrFrU3iR6qI3aJ+ULFjQu3rdYTZlQMYxWqyiW2m8LuR?= =?utf-8?q?AeBu/o/3Oyo6nZIsqxCvBW7ZPAgTJ7g2vEhIelDHG4gDqoZnJBmUXcMd4mMLkiDK1?= =?utf-8?q?jy5qNDHuySLnk7y6uzkvqSJ6K1hZ6tYwxNHSmjFreVp4/B/hKhKXnskvyS6d4XbEy?= =?utf-8?q?WjboOoZAPlo62jsRboZLkewVHG4T+1QV9elMT7n22ZpzFCUr6UNqde1OyACWFoyvX?= =?utf-8?q?tmAbtnzz37kobJ3HEMb7ATlV0VZV+/QmR7LtefVRa8Ev+uHQrlRaE1N0p3zsh3uzh?= =?utf-8?q?O5TEWaARGyZIukqGqDUTSkO3hwTWOFDZuD/s7aeVWGIjyu6UcCRFWwpnUbjdlSiHd?= =?utf-8?q?VnENjRYJ1IY19RZ2DqLnL5LphBcRSqCgTS1fig0Q41618Wq/joKyjhYlyCDcQSaE5?= =?utf-8?q?mlI+K+v4AwskpDQdprK+omFTrE/7r9s0YdAgPboKdmJq9KW5NxKY9M6H/9BYTgJ3U?= =?utf-8?q?lo9M2mo1TM7JJQ6nAVFBtqkom3gdbacYSAt4ktxMO24djcbsGIgSA+W/qQ43vOkmB?= =?utf-8?q?jXBeRIdgDocFHh9SIGuJDAc6Z2CCSqtSQv2rJBj7YDnsVblIXdPlF8p8d8j844v7S?= =?utf-8?q?u0Zd7z6SzT3W8zguT1hNKL/qkefz5kdlT2wmzIV5xTkCo/BwfG4UBU+w0bNPE2+AL?= =?utf-8?q?OrU8p8Ol7qI+JMyHp00cLNBgUDdaejTPp7/JHX95XeN59qizWTD2/tyPt5Ku9ffdB?= =?utf-8?q?cGBf/dZu7BuBbZkzVCTEjquU6axRPnVSwyA7QWRRkusZpR6SpoOA+WtT7qLv+3PjQ?= =?utf-8?q?q4MxuBHDJwNd?= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230031)(376005)(1800799015)(36860700004)(35042699013); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2024 13:34:11.5359 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d196af3f-afdf-4178-1340-08dc6aac8d2f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF00028D01.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6065 X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, GIT_PATCH_0, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Hi, The PR shows that when cfgrtl.cc:duplicate_insn_chain attempts to update the MR_DEPENDENCE_CLIQUE information for a MEM_EXPR we can end up accidentally dropping (e.g.) an ARRAY_REF from the MEM_EXPR and end up replacing it with the underlying MEM_REF. This leads to an inconsistency in the MEM_EXPR information, and could lead to wrong code. While the walk down to the MEM_REF is necessary to update MR_DEPENDENCE_CLIQUE, we should use the outer tree expression for the MEM_EXPR. This patch does that. Bootstrapped/regtested on aarch64-linux-gnu, no regressions. OK for trunk? What about backports? Thanks, Alex gcc/ChangeLog: PR rtl-optimization/114924 * cfgrtl.cc (duplicate_insn_chain): When updating MEM_EXPRs, don't strip (e.g.) ARRAY_REFs from the final MEM_EXPR. diff --git a/gcc/cfgrtl.cc b/gcc/cfgrtl.cc index 304c429c99b..a5dc3512159 100644 --- a/gcc/cfgrtl.cc +++ b/gcc/cfgrtl.cc @@ -4432,12 +4432,13 @@ duplicate_insn_chain (rtx_insn *from, rtx_insn *to, since MEM_EXPR is shared so make a copy and walk to the subtree again. */ tree new_expr = unshare_expr (MEM_EXPR (*iter)); + tree orig_new_expr = new_expr; if (TREE_CODE (new_expr) == WITH_SIZE_EXPR) new_expr = TREE_OPERAND (new_expr, 0); while (handled_component_p (new_expr)) new_expr = TREE_OPERAND (new_expr, 0); MR_DEPENDENCE_CLIQUE (new_expr) = newc; - set_mem_expr (const_cast (*iter), new_expr); + set_mem_expr (const_cast (*iter), orig_new_expr); } } }