From patchwork Thu May 2 13:11:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1930614 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=2N6p4i4A; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=BYKUgRzX; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=2N6p4i4A; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=BYKUgRzX; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VVZ8X4lxFz1ydX for ; Thu, 2 May 2024 23:11:56 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D0AF23858429 for ; Thu, 2 May 2024 13:11:54 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 1F8FF385842D for ; Thu, 2 May 2024 13:11:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F8FF385842D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1F8FF385842D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714655496; cv=none; b=vExYgkVGO8wRFMyBFpt0D24sjIR2rU6gAEcoW0BB5dIqtZ4/K/5vuJ06ZVr1i7bCj3sdO21bbMl1HsG6m8C7sZYoxHta5oH9tnqucfDiUftKsP71ZU0U3fqDdnhyIS1MdF5cOVb9Ab5yDpVJKvu72h636aBedJUNwesdh2VDaGE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714655496; c=relaxed/simple; bh=gkRzNVFerI+UxzSS4YtMEQeNK+4w4AlBfGBrFpzD0oo=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=vTpuz/SbXGS5K9RLOVhrD0PuPA+8gaIqE6BGtXf2/WHsHf29DGoqjhu3cEl+QnIzAjxEQyZqub8mzNXbv+XPSxkgaudywQZEwiIFTn5Vj3D5FRC4U2rLNcqG3yJUufA4Uj/kVxUvST8Qrh0257tIO1DPSj0g26ssOc6y5/cIaSg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.5.241] (unknown [10.168.5.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1874D1FC06 for ; Thu, 2 May 2024 13:11:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1714655494; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=0tgeOKQyFRXbBOuDDTGrqVt2JaHbd52AATPm65TD6bE=; b=2N6p4i4Amwzvd5hXXoVZTitzyslzZGsNgBQ+Uu+rGJPFyd8zB5pJxcFJpzhRw2Af6kp9KH 0SqFI1mO2uIasmMICODIcfgiBmys6I79X2aMhKByD0ysuquuKptZ3PKoQDG6w+iu2PQQ4s u2jSly6r2Na3y6+szDtco1t85R68m/w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1714655494; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=0tgeOKQyFRXbBOuDDTGrqVt2JaHbd52AATPm65TD6bE=; b=BYKUgRzX7M2LzLFX4U0QJkUgnPBx4ct1MCCnBN/nJ6PG0D9UwOfdMfcsKzvCGegzJ1y5BW 9QalFnjHSB5sjmDg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1714655494; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=0tgeOKQyFRXbBOuDDTGrqVt2JaHbd52AATPm65TD6bE=; b=2N6p4i4Amwzvd5hXXoVZTitzyslzZGsNgBQ+Uu+rGJPFyd8zB5pJxcFJpzhRw2Af6kp9KH 0SqFI1mO2uIasmMICODIcfgiBmys6I79X2aMhKByD0ysuquuKptZ3PKoQDG6w+iu2PQQ4s u2jSly6r2Na3y6+szDtco1t85R68m/w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1714655494; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=0tgeOKQyFRXbBOuDDTGrqVt2JaHbd52AATPm65TD6bE=; b=BYKUgRzX7M2LzLFX4U0QJkUgnPBx4ct1MCCnBN/nJ6PG0D9UwOfdMfcsKzvCGegzJ1y5BW 9QalFnjHSB5sjmDg== Date: Thu, 2 May 2024 15:11:34 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH][v3] tree-optimization/114921 - _Float16 -> __bf16 isn't noop MIME-Version: 1.0 X-Spam-Level: X-Spamd-Result: default: False [-0.65 / 50.00]; MISSING_MID(2.50)[]; BAYES_HAM(-1.91)[94.51%]; NEURAL_HAM_LONG(-0.99)[-0.989]; NEURAL_HAM_SHORT(-0.15)[-0.742]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_ZERO(0.00)[0]; ARC_NA(0.00)[]; MISSING_XM_UA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_NONE(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[] X-Spam-Score: -0.65 X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Message-Id: <20240502131154.D0AF23858429@sourceware.org> The vectorizer handles a _Float16 to __bf16 conversion through vectorizable_assignment, thinking it's a noop. The following fixes this by requiring the same vector component mode when checking for CONVERT_EXPR_CODE_P, being stricter than for VIEW_CONVERT_EXPR. This variant splits the check for VIEW_CONVERT_EXPR and CONVERT_EXPR_CODE_P since it otherwise regresses gcc.dg/vect/vect-120.c. PR tree-optimization/114921 * tree-vect-stmts.cc (vectorizable_assignment): Require same vector component modes for input and output for CONVERT_EXPR_CODE_P. --- gcc/tree-vect-stmts.cc | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc index f8d8636b139..7e571968a59 100644 --- a/gcc/tree-vect-stmts.cc +++ b/gcc/tree-vect-stmts.cc @@ -5955,14 +5955,17 @@ vectorizable_assignment (vec_info *vinfo, if (!vectype_in) vectype_in = get_vectype_for_scalar_type (vinfo, TREE_TYPE (op), slp_node); - /* We can handle NOP_EXPR conversions that do not change the number - of elements or the vector size. */ - if ((CONVERT_EXPR_CODE_P (code) - || code == VIEW_CONVERT_EXPR) - && (!vectype_in - || maybe_ne (TYPE_VECTOR_SUBPARTS (vectype_in), nunits) - || maybe_ne (GET_MODE_SIZE (TYPE_MODE (vectype)), - GET_MODE_SIZE (TYPE_MODE (vectype_in))))) + /* We can handle VIEW_CONVERT conversions that do not change the number + of elements or the vector size or other conversions when the component + mode keeps the same. */ + if (!vectype_in + || maybe_ne (TYPE_VECTOR_SUBPARTS (vectype_in), nunits) + || (code == VIEW_CONVERT_EXPR + && maybe_ne (GET_MODE_SIZE (TYPE_MODE (vectype)), + GET_MODE_SIZE (TYPE_MODE (vectype_in)))) + || (CONVERT_EXPR_CODE_P (code) + && (TYPE_MODE (TREE_TYPE (vectype)) + != TYPE_MODE (TREE_TYPE (vectype_in))))) return false; if (VECTOR_BOOLEAN_TYPE_P (vectype) != VECTOR_BOOLEAN_TYPE_P (vectype_in))