From patchwork Thu May 2 13:10:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1930613 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=a4O1s72/; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=7VsTVxoX; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=a4O1s72/; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=7VsTVxoX; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VVZ7q5YQqz1ydX for ; Thu, 2 May 2024 23:11:19 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D201D385841C for ; Thu, 2 May 2024 13:11:17 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id DA7713858D20 for ; Thu, 2 May 2024 13:10:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DA7713858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DA7713858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714655459; cv=none; b=LoiWkDO2Spkz2lWQQ85z5wPt0mnkuE14MVbIVFudHDtq7RvrPA2G+URD4AyqGlCQZE1mbo6VedLdVOVHvykafouHMbDW8PPNPMbjXItSGYJHlNelKXotBE16rK8nKXwJhVXiife1tyP/NcUGtFQHlXR7/GPE3BZsUKd80oJ8Tns= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714655459; c=relaxed/simple; bh=fkoHqp653ZKZ36X85mOr4eQ3XOlpvRPzicH/yG+u9/U=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=kc8EOek3jOG3CFA8Xb6dz//nrmM7KAdwHcv6sxVvNDdr7O1lyadLL1sZNSzyW4WSShWulJBxgnQaq/ES4B4FWE1ZpTiqwvKxD/ko3M43tT2bY25VCfKU/Hh+AwIr/9+j500cq5qrNtN54oJkn4LwY3uJUDJHE2ItoCU2BNWkV6I= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.5.241] (unknown [10.168.5.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B452A1FC07 for ; Thu, 2 May 2024 13:10:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1714655456; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=1Gw8iqj8A88vt0yvmbOpd7rCTwxK270SA749nhVu6Tw=; b=a4O1s72/uFOYbUnLN/Lafz5hnEucNhWvgbaOtygL82h+Eu4o9D4TYvKBwe2vsUCiPtZXwM KNeB6d9Yy02OcHJ9cDP/3ny/3Cmg5PPjBQD9JigtYwYATR6z5F9tE/OG6p/FulSfHxfyKW +Pv++LXmZJbpm9VfWJ1fUks/yqJfQIg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1714655456; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=1Gw8iqj8A88vt0yvmbOpd7rCTwxK270SA749nhVu6Tw=; b=7VsTVxoXW/R+hEV7lg/mAyjJqWl9Mkpo1H1N9dj6NNNc+DG1puYhxfwzLQxn7CkF1qV4Km ue2b/FizJmj0izDQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1714655456; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=1Gw8iqj8A88vt0yvmbOpd7rCTwxK270SA749nhVu6Tw=; b=a4O1s72/uFOYbUnLN/Lafz5hnEucNhWvgbaOtygL82h+Eu4o9D4TYvKBwe2vsUCiPtZXwM KNeB6d9Yy02OcHJ9cDP/3ny/3Cmg5PPjBQD9JigtYwYATR6z5F9tE/OG6p/FulSfHxfyKW +Pv++LXmZJbpm9VfWJ1fUks/yqJfQIg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1714655456; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=1Gw8iqj8A88vt0yvmbOpd7rCTwxK270SA749nhVu6Tw=; b=7VsTVxoXW/R+hEV7lg/mAyjJqWl9Mkpo1H1N9dj6NNNc+DG1puYhxfwzLQxn7CkF1qV4Km ue2b/FizJmj0izDQ== Date: Thu, 2 May 2024 15:10:56 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] Improve SLP dump and graph MIME-Version: 1.0 X-Spam-Level: X-Spamd-Result: default: False [0.36 / 50.00]; MISSING_MID(2.50)[]; NEURAL_HAM_LONG(-0.99)[-0.988]; BAYES_HAM(-0.92)[86.23%]; NEURAL_HAM_SHORT(-0.14)[-0.697]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_ZERO(0.00)[0]; ARC_NA(0.00)[]; MISSING_XM_UA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_NONE(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[] X-Spam-Score: 0.36 X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Message-Id: <20240502131117.D201D385841C@sourceware.org> The following notes which lanes are considered live and adds an overload to produce a graphviz graph for multiple entries into an SLP graph. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. * tree-vect-slp.cc (vect_print_slp_tree): Mark live lanes. (dot_slp_tree): New overload for multiple entries. --- gcc/tree-vect-slp.cc | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc index 133606fa6f3..3eb326d20b5 100644 --- a/gcc/tree-vect-slp.cc +++ b/gcc/tree-vect-slp.cc @@ -2759,7 +2759,9 @@ vect_print_slp_tree (dump_flags_t dump_kind, dump_location_t loc, } if (SLP_TREE_SCALAR_STMTS (node).exists ()) FOR_EACH_VEC_ELT (SLP_TREE_SCALAR_STMTS (node), i, stmt_info) - dump_printf_loc (metadata, user_loc, "\tstmt %u %G", i, stmt_info->stmt); + dump_printf_loc (metadata, user_loc, "\t%sstmt %u %G", + STMT_VINFO_LIVE_P (stmt_info) ? "[l] " : "", + i, stmt_info->stmt); else { dump_printf_loc (metadata, user_loc, "\t{ "); @@ -2840,6 +2842,23 @@ dot_slp_tree (const char *fname, slp_tree node) fclose (f); } +DEBUG_FUNCTION void +dot_slp_tree (const char *fname, const vec &slp_instances) +{ + FILE *f = fopen (fname, "w"); + fprintf (f, "digraph {\n"); + fflush (f); + { + debug_dump_context ctx (f); + hash_set visited; + for (auto inst : slp_instances) + dot_slp_tree (f, SLP_INSTANCE_TREE (inst), visited); + } + fflush (f); + fprintf (f, "}\n"); + fclose (f); +} + /* Dump a slp tree NODE using flags specified in DUMP_KIND. */ static void