From patchwork Wed Apr 17 12:28:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrei Otcheretianski X-Patchwork-Id: 1924621 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=VCGctd1k; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=e4OVFRTc; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VKKxD3BqNz1yPv for ; Wed, 17 Apr 2024 22:30:05 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=5qfCpo0iLzwMzohaeg9eFmO/L65TmhjCcYOqDeOgZyc=; b=VCGctd1kFfS8a8 wDN+AAq7dpPKzIlzQszlmRUIj5TBRE2W+NtyjUigQJpwkW9BYg99kkF3j2rsuQ1SZgID+tz3JCqyA HiI7jfu6OpNvj1bQzzorn5CVxssqWByA4PDRMZvx8+xmkr8OysjQyKoXcgqCg8JaPJNRw4xmvrsUl FO1teN94OfHxudiy+OW68xzxCx/w3uZgsqpNUmk6hA7E68WF82D6sAfpIjhU00QXyA8mVCecRBOKk e4WOfr6A5Chm/ZzC8LkEJ8yTQRrF+1rINkE8JFShqTqKhzS4W8aVKv0SlwQSQiKZNGYkyyPbUevNQ IBD7rrt/KBshZN+wqGrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx4Pt-0000000Fw64-3j8e; Wed, 17 Apr 2024 12:29:33 +0000 Received: from mgamail.intel.com ([192.198.163.11]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx4Pq-0000000Fw4k-3aTB for hostap@lists.infradead.org; Wed, 17 Apr 2024 12:29:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713356971; x=1744892971; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=S4Pzic2KM+ls85lxCaBvcSUoQRVYw+YrbPrJmgthxdw=; b=e4OVFRTcG52u7J94HDItU9kv3dqaEDrYTEJUxl47VvPwAYuDFkyq0Gvy oxg9MJjSY2ynygUBbufatkJkh9nI94Mxhu+3C6xkj8o3CxcH/d7hQFVmo oqbV+1B/0+fjWcPkDc6sALASDux0BQLAnVGlsLHL1jUx38wTHt4WLlQIa hYLeAAROwQR06NrOI5L54yr1nlxYt7F0xm7SIrzErxL5ppIrt1Q54yFyj mzI6uQk6zQfvqHT8E/sIpemERm8wikoMLMNCNKtlMo9MPEvdoFi0953Ra /aCj+mqNL0S9yB89gOnkGQJDLyYAhBhrsamACrksFAaqXKTN85JDmbWuf g==; X-CSE-ConnectionGUID: 6a1iyqW5TO+xnkHyrT5cUA== X-CSE-MsgGUID: RNAfjliFRt2Q6TGHNdrqXg== X-IronPort-AV: E=McAfee;i="6600,9927,11046"; a="19449375" X-IronPort-AV: E=Sophos;i="6.07,209,1708416000"; d="scan'208";a="19449375" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2024 05:29:26 -0700 X-CSE-ConnectionGUID: IEqS/eg6Rwaee0GkriYeqw== X-CSE-MsgGUID: NrguT7ZtTNiR/3MG5HQwOw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,209,1708416000"; d="scan'208";a="22665982" Received: from unknown (HELO WEIS0042.iil.intel.com) ([10.12.217.211]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2024 05:29:24 -0700 From: Andrei Otcheretianski To: hostap@lists.infradead.org Cc: Andrei Otcheretianski , Benjamin Berg Subject: [PATCH] DBUS: Use correct values for persistent group Date: Wed, 17 Apr 2024 15:28:12 +0300 Message-ID: <20240417122812.2015822-1-andrei.otcheretianski@intel.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240417_052930_991733_BECBFD25 X-CRM114-Status: UNSURE ( 8.43 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.6 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: DBUS lib expects "persistent" to be bool (0/1) and crashes otherwise. Since persistent may also be 2 convert it to boolean. Signed-off-by: Andrei Otcheretianski Signed-off-by: Benjamin Berg --- wpa_supplicant/dbus/dbus_new.c | 2 +- 1 file changed, 1 insertion(+), [...] Content analysis details: (-2.6 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [192.198.163.11 listed in list.dnswl.org] 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.7 DKIMWL_WL_HIGH DKIMwl.org - High trust sender X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org DBUS lib expects "persistent" to be bool (0/1) and crashes otherwise. Since persistent may also be 2 convert it to boolean. Signed-off-by: Andrei Otcheretianski Signed-off-by: Benjamin Berg --- wpa_supplicant/dbus/dbus_new.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wpa_supplicant/dbus/dbus_new.c b/wpa_supplicant/dbus/dbus_new.c index 8bd6a9a43b..02107dc475 100644 --- a/wpa_supplicant/dbus/dbus_new.c +++ b/wpa_supplicant/dbus/dbus_new.c @@ -1663,7 +1663,7 @@ void wpas_dbus_signal_p2p_group_started(struct wpa_supplicant *wpa_s, wpa_s->dbus_new_path) || !wpa_dbus_dict_append_string(&dict_iter, "role", client ? "client" : "GO") || - !wpa_dbus_dict_append_bool(&dict_iter, "persistent", persistent) || + !wpa_dbus_dict_append_bool(&dict_iter, "persistent", !!persistent) || !wpa_dbus_dict_append_object_path(&dict_iter, "group_object", wpa_s->dbus_groupobj_path) || (ip &&