From patchwork Wed Apr 17 07:54:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roi Dayan X-Patchwork-Id: 1924527 X-Patchwork-Delegate: horms@verge.net.au Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=lsF52RVb; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=smtp4.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VKCqf2cDhz1yZ2 for ; Wed, 17 Apr 2024 17:54:54 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 996B940764; Wed, 17 Apr 2024 07:54:52 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id D3uOyUk_6eun; Wed, 17 Apr 2024 07:54:51 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.9.56; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 19936401A0 Authentication-Results: smtp4.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=lsF52RVb Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 19936401A0; Wed, 17 Apr 2024 07:54:51 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id D95CDC007C; Wed, 17 Apr 2024 07:54:50 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id A5E4BC0037 for ; Wed, 17 Apr 2024 07:54:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 813C881242 for ; Wed, 17 Apr 2024 07:54:49 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id McVnQrMb1zj5 for ; Wed, 17 Apr 2024 07:54:49 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a01:111:f403:2409::600; helo=nam04-dm6-obe.outbound.protection.outlook.com; envelope-from=roid@nvidia.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org A6BBF80E81 Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org A6BBF80E81 Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=lsF52RVb Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on20600.outbound.protection.outlook.com [IPv6:2a01:111:f403:2409::600]) by smtp1.osuosl.org (Postfix) with ESMTPS id A6BBF80E81 for ; Wed, 17 Apr 2024 07:54:48 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Af2Qaq92jCLroXsT0BFNMsj9egSsw/0MiuZ5rv4c36jZflsk/TkhKsWxeNfPqL2fpFsDfqZlsEF3gR6JwF3vWhJ5X1um96cXQLu1AemRBGfRiqHBpdRTnS2Q8EOjTY0N5iIz78txaqGWvzPyOUbrrWpEf11gvwkLpaoo2TMtMzJeeXl3GHHEjTz1sybvdghFIIgLWtCdPerKxd9PHFSY8coUOcVUkUks98wPB4H/oH7Me02xxZMO5D9qSY3KnzDjyJ7idHp4PHGxzzEy/j6/JX8rjGD2H0yQnBp7iwgbtn7ERzqRtNm5QiVY2xdYHVezz3AIU/WI6PD+pv5hkUeKdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zF7p6gLaHhznVajcipelRtkjFG4OZ0DzWMSWxqL6CuA=; b=BWw4kR3MnY4o4Kun/coWtin/zvljuhObviSuNJIyc01yNEVZTSKlF9cBj7t2Y+vS+ml2ffhRYFo23niSwp0JazOjU1n3c0ccxmYxe7w4C/3VpQMHmyOT+HfbUtnKAHn1EP+wBzrUsoO6iz+b/d5g5nyO1z3CWsyOfryyMvn2GOEaRi1tt1byTuqEB+Fz/pdgHycJSPrQ8MxaeZ6xyC0ar8ZMhoNCwIV+6/Tzn6WL4ta7sTgyP/koO5Bfiv1qsloniHZEjW4AwiMki1jYhg+vsM8GPsTXlBD1v8G8Wpi3rGE92hW1sSICtFaiuXgAlqd74qGCxwCLSFmk71SIqshUrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=openvswitch.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zF7p6gLaHhznVajcipelRtkjFG4OZ0DzWMSWxqL6CuA=; b=lsF52RVbNyQJSGb7ekVCyjYznFhtUF5x/fciGXTtPDSgT/szkxOm4U7tjGolYIaXTK4VWD7QdfUDW5OQktBNHkInVRsqdwSYeLynDUN0BbzZ7OHUEn1veobDEh5V1m4SvMemF+sA6p/7x3rC7BAR9Jsf0WkO3R70bQzv36kX4VLSNt2PeoK0u3uHtOdLgPpPpFUEqzUTvhUXvPXyz5hhfEY/tE7mKs9T5oQvqOeI201IjWK6lUfhroRZDBeEPQAh+cWBbjTDbN5JvDcM0EBXAbIDj8FxDclwt4ZookymuMu/hi4c9ofEtKar37c1k80rjjv6svPzdfgG8KDSp1pC/g== Received: from PR1P264CA0070.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:2cc::10) by PH0PR12MB7009.namprd12.prod.outlook.com (2603:10b6:510:21c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.50; Wed, 17 Apr 2024 07:54:45 +0000 Received: from SA2PEPF00001506.namprd04.prod.outlook.com (2603:10a6:102:2cc:cafe::68) by PR1P264CA0070.outlook.office365.com (2603:10a6:102:2cc::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7495.23 via Frontend Transport; Wed, 17 Apr 2024 07:54:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by SA2PEPF00001506.mail.protection.outlook.com (10.167.242.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Wed, 17 Apr 2024 07:54:42 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 17 Apr 2024 00:54:21 -0700 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 17 Apr 2024 00:54:21 -0700 Received: from c-237-115-40-045.mtl.labs.mlnx (10.127.8.14) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Wed, 17 Apr 2024 00:54:20 -0700 To: Date: Wed, 17 Apr 2024 10:54:14 +0300 Message-ID: <20240417075414.2283175-1-roid@nvidia.com> X-Mailer: git-send-email 2.18.2 MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00001506:EE_|PH0PR12MB7009:EE_ X-MS-Office365-Filtering-Correlation-Id: 20eb7b4f-cc9f-4fec-9752-08dc5eb3a408 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lmoSjhFfAKvfHGXZWDsBuehJ4uWpR2KTUcPB8xl4H/b8HsmfzN0nVZyjO7geNUqyLABY+woBU00sT6AAA74R9tjb3WSfC0WsqpOe6l0jGaJRM2D6YiRKkvMtcCNXQoN1gs7vb2ZaI7abEL99DL6kyM9NSmluas17BTIb7EGzkqqoogccpYFo+U9FFmxb4gArnCQYtnGjXDeAc4TFJI/E4fZhMdodIDmmS4sKPyOfQMx1ieAXahK4wQUS01rpz7HBL//TZIYXaoyAfUo+r778YzrAyVQqZBaFAzLErEaW/ssIu6+nEiGszQDeRVlM7pLzgh054vXum1EeCsahRW/lXmJ9AY5CSKOXAVsbuotMnD08RzZQVHZgnMvI1svH1PHw9qXIt57LqOs8/EOvqwtiEZKKnnka3KemAfghWyfTj04WspN2HICfmxPa26oCCsg2YUfD6Vdyb3IMrKyT8tA1srLnpXtk4v8xZQfsRSYwXAcOCqqm0I9eKJDI1Q8yu9P+a8r/uq3yOtg7dqT2s2JfN1CGXgu5ZRK4i2+l5TIW+pHyRoygWDvQ4A3cTpw/FVmzk890CyKEQWnEFTABuXrCHmfiD6ZdqzzKBK32pknduMt+AGdDuee+1x25i8UFkgvClq4vFnij+eUJTO72MHhA4Us+1uGo7EwY89k70yxKF+lKipItv6qqMaJbWwGip2LzlTKfJus87zLyI64aYUeNIWaacTlKZmikn91FVseElVj7b74ZikX6g6ABcY0cGV63 X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230031)(82310400014)(36860700004)(376005)(1800799015); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2024 07:54:42.2701 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 20eb7b4f-cc9f-4fec-9752-08dc5eb3a408 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00001506.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7009 Cc: Eli Britstein , Maor Dickman Subject: [ovs-dev] [PATCH 1/1] netdev-dpdk: Improve error print to the user for flow control error. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Roi Dayan via dev From: Roi Dayan Reply-To: Roi Dayan Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" When failing to get flow control parameters use VLOG_WARN_BUF() to expose the error string in ovs-vsctl show. Signed-off-by: Roi Dayan Suggested-by: Simon Horman Acked-by: Eli Britstein Acked-by: Simon Horman --- lib/netdev-dpdk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 2111f776810b..32d4193d24af 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -2426,8 +2426,8 @@ netdev_dpdk_set_config(struct netdev *netdev, const struct smap *args, } err = 0; /* Not fatal. */ } else { - VLOG_WARN("%s: Cannot get flow control parameters: %s", - netdev_get_name(netdev), rte_strerror(err)); + VLOG_WARN_BUF(errp, "%s: Cannot get flow control parameters: %s", + netdev_get_name(netdev), rte_strerror(err)); } goto out; }