From patchwork Mon Apr 15 18:20:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Michelson X-Patchwork-Id: 1923845 X-Patchwork-Delegate: dceara@redhat.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CaK6HJQ5; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VJFpv16MNz1yY4 for ; Tue, 16 Apr 2024 04:20:54 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 8F33C60638; Mon, 15 Apr 2024 18:20:52 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id BANbgcQvab67; Mon, 15 Apr 2024 18:20:51 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.9.56; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 4D154605FD Authentication-Results: smtp3.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CaK6HJQ5 Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 4D154605FD; Mon, 15 Apr 2024 18:20:51 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 20DF0C0077; Mon, 15 Apr 2024 18:20:51 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id E0455C0037 for ; Mon, 15 Apr 2024 18:20:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id BFD6481464 for ; Mon, 15 Apr 2024 18:20:49 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id ctUOH5JVb3nj for ; Mon, 15 Apr 2024 18:20:49 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=mmichels@redhat.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org B3D6781449 Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=none dis=none) header.from=redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org B3D6781449 Authentication-Results: smtp1.osuosl.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CaK6HJQ5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id B3D6781449 for ; Mon, 15 Apr 2024 18:20:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713205247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dvHSw7wt6jlIVqVcJAegLuZV3dzjC9BNewrrOl6pfo8=; b=CaK6HJQ5WfcMLTwm1I7QsJLw8+I0HAKYMbZd7ReSxwPCLj97yQM2aregMg/cTpg8UGp0pZ lnw8sfT7w6M92kyiabRSrNTI5v0BWiBCgtD4WTD6nBL31UyjroWjq/JIp6ZoUcGzPMFn0F KfGgLwkvslAEW0icy9DVP4rX+HdOPHs= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-217-BYcP6pRjNeSUVp0ThisB7w-1; Mon, 15 Apr 2024 14:20:40 -0400 X-MC-Unique: BYcP6pRjNeSUVp0ThisB7w-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 70B7D28B6AAE for ; Mon, 15 Apr 2024 18:20:40 +0000 (UTC) Received: from localhost.redhat.com (unknown [10.22.50.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 13A3D210FD23 for ; Mon, 15 Apr 2024 18:20:39 +0000 (UTC) From: Mark Michelson To: dev@openvswitch.org Date: Mon, 15 Apr 2024 14:20:34 -0400 Message-ID: <20240415182039.264280-1-mmichels@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [ovs-dev] [PATCH ovn] ovn-nbctl: Document "--portrange" in the manpage. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" The --portrange option was added in commit [0]. The option appears in the help text for ovn-nbctl, but it is not documented in the manpage at all. This commit adds documentation to the manpage for the --portrange option. Reported-at: https://issues.redhat.com/browse/FDP-537 Signed-off-by: Mark Michelson Acked-by: Ales Musil --- utilities/ovn-nbctl.8.xml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/utilities/ovn-nbctl.8.xml b/utilities/ovn-nbctl.8.xml index 39c352212..ea2b201a5 100644 --- a/utilities/ovn-nbctl.8.xml +++ b/utilities/ovn-nbctl.8.xml @@ -1175,7 +1175,7 @@

NAT Commands

-
[--may-exist] [--stateless] [--gateway-port=GATEWAY_PORT] lr-nat-add router type external_ip logical_ip [logical_port external_mac]
+
[--may-exist] [--stateless] [--gateway-port=GATEWAY_PORT] [--portrange] lr-nat-add router type external_ip logical_ip [logical_port external_mac] [external_port_range]

Adds the specified NAT to router. @@ -1212,6 +1212,18 @@ specify the GATEWAY_PORT.

+

+ If the --portrange option is specified, then a range of + ports may be specified in the external_port_range part + of the lr-nat-add command. If this option is omitted, + then an external port range may not be specified. The format of the + port range is port_low-port_high, where + port_low is a lower number than port_high. When + the packet is NATted, a random port from the range will be selected + as the source port. The range for the + external_port_range is 1-65535. +

+

When type is dnat, the externally visible IP address external_ip is DNATted to the