From patchwork Tue Apr 9 03:41:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Donald X-Patchwork-Id: 1921187 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=R2xuypSQ; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=XIcsWP9F; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VDBgd3zrmz1yYM for ; Tue, 9 Apr 2024 13:45:33 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=itYn6PRwCOu8FkTqBtp+5DSVJzCSSYsq4AdeZnA0tng=; b=R2xuypSQoFKpch czQMrP4A0ypLkiyMM9V3tVSU1P/N/anL86XjjFh0mif2/EMyUiH5SM4um99PHcBgNDXTsIAyt0Nvo SF/LgXRQuKxheW/7yV2cfmOWEcOT8o0A5+5jILcVPCieZ6x/vufan3jvRHjsTKqJ2jtWSX6K/qEba 2e/zi5Bt8FZOur9uWzx/FEQnoFh+tfyYxuKfQ9+gskuR7/si1K0MN67a92AN8+S8AxtGpPUT9b8cU YwMyTGAqkFBjgJd5wRFbmjvzHE5lj07okNebfWUFdu1NlursHPny3rOZAWMDrm4iD7HvlEvBUaiKR sqswHxvOcHrEQyrD6M4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru2P9-00000000CHh-2vKU; Tue, 09 Apr 2024 03:44:15 +0000 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru2P4-00000000CEQ-0a3H for openwrt-devel@lists.openwrt.org; Tue, 09 Apr 2024 03:44:11 +0000 Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2d700beb60bso83285621fa.1 for ; Mon, 08 Apr 2024 20:44:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712634246; x=1713239046; darn=lists.openwrt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=wGdF/5/ThPnkrWfi0TAL6OvRfWT/Us+zTsrezG6ZoEw=; b=XIcsWP9Fc3E18BmZIUljl4bf72j8sWhSV+8KuwIWEdddcOJ2NBPAHkyGUn6owtlVkN N9NX+tliFy9lv5y7Ubh5iHG4CHW8GQpSfkdjsFGDwoS96VT0FBPfYvpiYY/+1zuwl0rs shq10fo3U94G4dZf9ncWLSqmNGFn56DUiyRwE8W/GrSUdtupSO4LbKk4sgS4nmF0bvHh vGD+vSwTEEvkWReegc/AB/hyRLPDiuJ+JOGUTh2y6IzV8OrpACG0u8sND9cHvVMLz/N7 zBOESTBR54NntVcTUTb+egzIbRcvSGpKcGkXRcsAPjozQtc3BGZcjE5B24+A9PigUo60 WBQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712634246; x=1713239046; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=wGdF/5/ThPnkrWfi0TAL6OvRfWT/Us+zTsrezG6ZoEw=; b=Aal78ZYYLY12zP+d8cqiXzhstTOosf3lkWlEa+8uA/LKvcwRknfNUaWtKdfY5OgNt7 zGpkGnlGEgCzFvFX3Q3Of6mFuHhv0ClZjaT+3ROU8Gef7P/kMaI5hIXxHyzqJfze3cdv uJ7Qh5gGQTzdeZ6cjq4wkNNhlXboiwZ+rqA9e4lOkq8OxINqurV4siGodJiBKxcDblr5 PgVFwVJFRZNZe9uDFPxlog6y8fIjYM61PTd4lJeG9+1HJpzD+SGNJ4Nu0PPUAOcl0Rgi 4bd8x2D+DL9g7YucJdI3D3XGT0ceO8vhMMzBErLNdq4CQ00M/qlNFSbkcCEyyANh2qiz suWQ== X-Gm-Message-State: AOJu0Yx7bfNrjDnRaeSxsLhw6gdNag7WKWsy5OIIj1MbgICd6TTUTfNX hwJuGQGjkCAr/LnLM1GN+FwV/euGOGIayGDhjME9TWrxYpTDPHcjsPh7EpgA X-Google-Smtp-Source: AGHT+IGccl+DZjuy82thn3mc8H7YPJxKjtIw8LLxCKYPeIAF+eoiqJ+IE8IhcTw3aLoM4jtsiNqs6g== X-Received: by 2002:a2e:980a:0:b0:2d6:c749:17bc with SMTP id a10-20020a2e980a000000b002d6c74917bcmr8794911ljj.31.1712634246554; Mon, 08 Apr 2024 20:44:06 -0700 (PDT) Received: from blackhol3 ([2001:9b0:40::cae3:cb03]) by smtp.gmail.com with ESMTPSA id n9-20020a2e86c9000000b002d2191e20e1sm1374790ljj.92.2024.04.08.20.44.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 20:44:06 -0700 (PDT) From: Paul Donald To: OpenWrt Development List Subject: [PATCH v2 1/7] lldpd: fixed interface(s) parsing Date: Tue, 9 Apr 2024 05:41:01 +0200 Message-ID: <20240409034405.78194-2-newtwen+github@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240409034405.78194-1-newtwen+github@gmail.com> References: <20240402130221.58706-1-newtwen+github@gmail.com> <20240409034405.78194-1-newtwen+github@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240408_204410_205746_5667195D X-CRM114-Status: GOOD ( 12.85 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: For interface type parameters, the man page documents patterns: ``` *,!eth*,!!eth1 uses all interfaces, except interfaces starting with "eth", but including "eth1". ``` While we must check that interfaces exist, first strip any prefixed "!" then pass the original string (with `!` prefix) again, to command lines. Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:22a listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [newtwen+github(at)gmail.com] X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org For interface type parameters, the man page documents patterns: ``` *,!eth*,!!eth1 uses all interfaces, except interfaces starting with "eth", but including "eth1". ``` While we must check that interfaces exist, first strip any prefixed "!" then pass the original string (with `!` prefix) again, to command lines. * Renamed `_ifname` to `_l3dev`. * Glob pattern `*` is also valid - pass those verbatim. The net result is that now interface 'names' including globs '*' and '!' inversions are included in the generated lldpd configs. We must also `set -o noglob` and `set +o noglob` to disable and enable globbing respectively, because when we pass `*` as an interface choice everything goes to hell without them. Tested extensively on: 22.03.6 Signed-off-by: Paul Donald --- .../network/services/lldpd/files/lldpd.init | 20 ++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/package/network/services/lldpd/files/lldpd.init b/package/network/services/lldpd/files/lldpd.init index 67ee011ae2..fc53520c5b 100644 --- a/package/network/services/lldpd/files/lldpd.init +++ b/package/network/services/lldpd/files/lldpd.init @@ -76,18 +76,32 @@ get_config_restart_hash() { } get_config_cid_ifaces() { + set -o noglob local _ifaces config_get _ifaces 'config' "$2" local _iface _ifnames="" for _iface in $_ifaces; do - local _ifname="" - if network_get_device _ifname "$_iface" || [ -e "/sys/class/net/$_iface" ]; then - append _ifnames "${_ifname:-$_iface}" "," + local _l3dev="" + # save any "!" or "!!" prefix from the interface name + _suffix=${_iface##*"!"} + _prefix=${_iface%%"$_suffix"} + + if network_get_device _l3dev "$_suffix" || [ -e "/sys/class/net/$_suffix" ]; then + # prepend the stripped "!" or "!!" prefix here if we had one + append _ifnames "$_prefix${_l3dev:-$_suffix}" "," + else + case $_iface in + *"*"*) + # Append any interface names including a glob '*' pattern + append _ifnames "$_iface" "," + ;; + esac fi done export -n "${1}=$_ifnames" + set +o noglob } write_lldpd_conf() From patchwork Tue Apr 9 03:41:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Donald X-Patchwork-Id: 1921189 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=CHGq5zaE; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=az7RutAC; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VDBgf6hqGz1yYH for ; Tue, 9 Apr 2024 13:45:34 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H8TQBvg6a6HHpTmd9P2xDdwAMF7gwLb1/tiadVCMI3E=; b=CHGq5zaE8JaAml GW3lFgfAVS3SZ6msfgXRQr/5SkFaGKaSYZxt7umu3TJ7eMQEZoTy1lkvhSobALBTS75NItPc5tYiC 1pMz2TlZ7z/qG/ibpVsesHHmrSMqDjT4swi9MaYIj0Wilx1GKCAqIkBbxsyi8IFaYfjDb2gRO6G+Z 0KkjhuKDOM5PT5uXNy/Ed0I3g+kBKpKFHGEl/ODr09ahfpjm1Ibcy/lE4YCdmoxNQdoH2IoypW/xh i9Dyl9xKoge5Vm9oT+XSxJvtx8YkKAK6lBwWSCuIHtnnt4FNLEEcJw8hCccA2Crz8p5XRCWxULK91 MsSE6HZ1cIk0AdMJtScg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru2PH-00000000CKC-1ahy; Tue, 09 Apr 2024 03:44:23 +0000 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru2P4-00000000CEV-2fpS for openwrt-devel@lists.openwrt.org; Tue, 09 Apr 2024 03:44:12 +0000 Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2d886f17740so20405061fa.1 for ; Mon, 08 Apr 2024 20:44:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712634248; x=1713239048; darn=lists.openwrt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=1cPpNGRd3aQpDMj64WCShILYivWahJKI2FdD8yWr6e8=; b=az7RutACFfRqqVH7m+gBNcVt+e0eyyM0+Or5AlcwpoWNyEBPhPMrzmQ/UJnVk8MI6T O/jSGRBXKbyncjQKXVtS2NkngSOF8f9nX2xk+AakC4CwonluSvCJYg5NArZzp+QgTgAK VUogrHi8v0hwJisNfpBZc10AU/s8uKuTiJpdFyjodKLLm+CvpevUeiOJTMpA8wyWonvL fLbOMGfD91/mch6dFndentzl08vRA6GLW4ZH8iixS/A8H90SMJwNNKCPSEreOCx44iru jw9p/rdZuz0Hf+NIZC64uqqsySybCZBSwnDxjNGt2ycZVkjpKEMVZQmUSiOb/qFYZwNL rcdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712634248; x=1713239048; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=1cPpNGRd3aQpDMj64WCShILYivWahJKI2FdD8yWr6e8=; b=WCOjSTAVJ+EA9UrqsYEOCIS5durAqmFWx3DJ2I84cwS48eYeYLWKkd8ntQNupilcdS +zOcNXjyZike09d3dyRryso1WuHm+3oVRMx3B/tb4h7N7T58nzgQEufE1+t53KBOvqNQ mD4jhcZ4ujF62cUb/mD9SGsnwZrtNKbEkei9G+38gvRd90BujKPwMOf88nO0yDqwJ6Eu /aRmGivx+JY1CclsHrfNS8z/e5DqODmTDar799Gt1dVGt8EnsiX1uVOrQh5KkpMgs6sy tWHF1QEvL65pKoG88vwLKrqGK0qvxypxIg9TP5MfxFRbup/JkE9cDfw1ChBSuewl3MvI 085w== X-Gm-Message-State: AOJu0YzN5g73iPLLk+4SJcYqwnTJqmXZCMgmVNnDImSQIMFcIyk0M5D5 Hb9R/b4Rw1Cb1X0QANelZ08omHywnJh/RrYfpzU9UpHNNrVtjTmkj6FQbirQ X-Google-Smtp-Source: AGHT+IGlpd4ey4DYmCY2xil0i1eqNDYWkNM1P6TnR2X8mRISmQghPdqzeq9VkVnAZZGixse3ZOoCuQ== X-Received: by 2002:a2e:7c13:0:b0:2d6:f8d7:ab95 with SMTP id x19-20020a2e7c13000000b002d6f8d7ab95mr339283ljc.21.1712634247943; Mon, 08 Apr 2024 20:44:07 -0700 (PDT) Received: from blackhol3 ([2001:9b0:40::cae3:cb03]) by smtp.gmail.com with ESMTPSA id n9-20020a2e86c9000000b002d2191e20e1sm1374790ljj.92.2024.04.08.20.44.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 20:44:06 -0700 (PDT) From: Paul Donald To: OpenWrt Development List Subject: [PATCH v2 2/7] lldpd: get_config_cid_ifaces() -> get_interface_csv_pattern() Date: Tue, 9 Apr 2024 05:41:02 +0200 Message-ID: <20240409034405.78194-3-newtwen+github@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240409034405.78194-1-newtwen+github@gmail.com> References: <20240402130221.58706-1-newtwen+github@gmail.com> <20240409034405.78194-1-newtwen+github@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240408_204410_700056_D13D2C77 X-CRM114-Status: GOOD ( 10.74 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Make the function more generic. Can use it for not only 'config'. Now it can be used to parse interfaces for additional lldpd settings Tested on: 22.03.6 Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:234 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [newtwen+github(at)gmail.com] X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org Make the function more generic. Can use it for not only 'config'. Now it can be used to parse interfaces for additional lldpd settings Tested on: 22.03.6 Signed-off-by: Paul Donald --- package/network/services/lldpd/files/lldpd.init | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/package/network/services/lldpd/files/lldpd.init b/package/network/services/lldpd/files/lldpd.init index fc53520c5b..069c8fee80 100644 --- a/package/network/services/lldpd/files/lldpd.init +++ b/package/network/services/lldpd/files/lldpd.init @@ -75,10 +75,10 @@ get_config_restart_hash() { export -n "$var=$_hash" } -get_config_cid_ifaces() { +get_interface_csv_pattern() { set -o noglob local _ifaces - config_get _ifaces 'config' "$2" + config_get _ifaces "$2" "$3" local _iface _ifnames="" for _iface in $_ifaces; do @@ -115,7 +115,7 @@ write_lldpd_conf() config_get lldp_hostname 'config' 'lldp_hostname' "$(cat /proc/sys/kernel/hostname)" local ifnames - get_config_cid_ifaces ifnames "interface" + get_interface_csv_pattern ifnames 'config' "interface" local lldp_mgmt_ip config_get lldp_mgmt_ip 'config' 'lldp_mgmt_ip' @@ -327,7 +327,7 @@ start_service() { # ChassisID interfaces local ifnames - get_config_cid_ifaces ifnames "cid_interface" + get_interface_csv_pattern ifnames 'config' "cid_interface" [ -n "$ifnames" ] && procd_append_param command -C "$ifnames" From patchwork Tue Apr 9 03:41:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Donald X-Patchwork-Id: 1921186 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=KcghLYVg; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=fIlOJ/P2; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VDBgd1kCFz1yYH for ; Tue, 9 Apr 2024 13:45:33 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FLTzdpY1n8HtTg9UZCX/MtvxZIyvr174FN02ilzuFw4=; b=KcghLYVge46BYG N1LUNFI6SVjE3vEnRrvl/9csFjaS6MIcMv89rpoX1esdk/5qRVxW5zgHUh+TDA0zF4QtOQPHWqUsn Tvrsb4Ndef0mdPz9M3G6t2hQnRl1IXoIlMZivrQruXbUYDxtN5qtqOA9JLB9URS8ochUT4NNjJvj3 Vt1q19z7sjWRGc4j65/29+xPS8sikWYnvIlWXvPxYBtq+1ZZXsHwbPcWOPBF7WkKAa8LVnrt1Opog reY/llOwAqJk4P23sAZnyiZMx05VRhONG4TvzE6aWGZbB8oPBBe/NcPDefs5fmXz1LnVAJpsUYhDN 9CvNg7wzrstz9hydSH1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru2PE-00000000CJX-3lJb; Tue, 09 Apr 2024 03:44:20 +0000 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru2P4-00000000CEb-1zPI for openwrt-devel@lists.openwrt.org; Tue, 09 Apr 2024 03:44:12 +0000 Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2d82713f473so88179741fa.3 for ; Mon, 08 Apr 2024 20:44:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712634248; x=1713239048; darn=lists.openwrt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=svbBmpUnwB9Q5MUXctX7SMY6TVb1QTXJwF5tC5caJJs=; b=fIlOJ/P2nB1jp7WNY4+LQr7FZff8pFOG6KJlCkdI/q/W7ubhRILWA2ov8mEanKorgJ TtV9mYnjBDC2FWjflfh9r1syCCjVXJiX5AENaAdBOX6S1oJyY/GtFZNXrMGVdxZ9dScV s2au0sSbX6ZQiSsPDE0GSv+zN1um29ZwWrBGiTpwV+b2nTUgvAfLVXkjngYK4ZUNq2iX +hkfEcaHHusaF8u9iTDJjwSia/IzFUbnAxzX0xhrNJ19ZiMXDhYF+hIAfbwcI3rkVKLk 1xtLnfPfNIY4R5PJaw88Y6Yldq39mXN9W1Yzy/7AUO08nsih6VmigNcbYUQ8ZCBkjc6D YfhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712634248; x=1713239048; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=svbBmpUnwB9Q5MUXctX7SMY6TVb1QTXJwF5tC5caJJs=; b=weGU1+JdsIIff4PiFn6APXE0PDTR9d/zzcKC+XW2wbz8ROJps8G4M7Ifq2okY2WewJ dlPQY9OsfcOxJF3srO1n7TelleE/0wxmQyDyJvI0YVTN5TBwG82rwIH60qWpZmxUUdEz IAGmOwIhQrHIcmRbfyifHr0/D4ZMojaSMMTgLfT+5xtN1YlFAHCvLBZekIxqAK11ifq8 KZp2uIddBh+csqsJPYFsm1kb3ZGeV58QUxHZqQ4BHVsJGGBZx9v8lhWVxbio7bsJL65k abRW+iarZ2ggG23GME2ZEdmsT3x3l4xHcgicf6kZmBvUpp/RPeAdHCaj1ibJuj+DNzHK Ws9w== X-Gm-Message-State: AOJu0YwMOXjA0oglUmckVcvNlKmWq0zhuZvuzIdkLxwxxPUx+j1lbV8W U05oDUaPgKLWvBpFeFY8eZ+/fLx2mAVS6onKw0yTvnvfIL04REeksT5b8jdv X-Google-Smtp-Source: AGHT+IH34raZpDrEzrDbit/Z4cuv7MUdYuXBCFYvasV12Slp3FsDn2TaJgBzeeqkDLdqCG8JKjthPQ== X-Received: by 2002:a2e:918e:0:b0:2d6:87d7:601 with SMTP id f14-20020a2e918e000000b002d687d70601mr9018939ljg.9.1712634248314; Mon, 08 Apr 2024 20:44:08 -0700 (PDT) Received: from blackhol3 ([2001:9b0:40::cae3:cb03]) by smtp.gmail.com with ESMTPSA id n9-20020a2e86c9000000b002d2191e20e1sm1374790ljj.92.2024.04.08.20.44.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 20:44:08 -0700 (PDT) From: Paul Donald To: OpenWrt Development List Subject: [PATCH v2 3/7] lldpd: fix restart Date: Tue, 9 Apr 2024 05:41:03 +0200 Message-ID: <20240409034405.78194-4-newtwen+github@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240409034405.78194-1-newtwen+github@gmail.com> References: <20240402130221.58706-1-newtwen+github@gmail.com> <20240409034405.78194-1-newtwen+github@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240408_204410_554669_7A229F17 X-CRM114-Status: GOOD ( 11.49 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: redirection broke in 5364fe0f01ca11b47c55d78f756d3176748dd0c2 redirects to /dev/null shall be handled correctly (i.e. last). This fixes these errors on `/etc/init.d/lldpd reload`: Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:22a listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [newtwen+github(at)gmail.com] X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org redirection broke in 5364fe0f01ca11b47c55d78f756d3176748dd0c2 redirects to /dev/null shall be handled correctly (i.e. last). This fixes these errors on `/etc/init.d/lldpd reload`: 2024-03-16T20:39:00 [WARN/lldpctl] unknown command from argument 1: `/dev/null` 2024-03-16T20:39:00 [WARN/lldpctl] unknown command from argument 1: `/dev/null` 2024-03-16T20:39:00 [WARN/lldpctl] unknown command from argument 1: `/dev/null` 2024-03-16T20:39:00 [WARN/lldpctl] unknown command from argument 1: `/dev/null` Tested on: 22.03.6 Signed-off-by: Paul Donald --- package/network/services/lldpd/files/lldpd.init | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/package/network/services/lldpd/files/lldpd.init b/package/network/services/lldpd/files/lldpd.init index 069c8fee80..0334156fee 100644 --- a/package/network/services/lldpd/files/lldpd.init +++ b/package/network/services/lldpd/files/lldpd.init @@ -363,7 +363,7 @@ reload_service() { return 0 fi - $LLDPCLI -u "$LLDPSOCKET" 2>&1 /dev/null <<-EOF + $LLDPCLI -u "$LLDPSOCKET" >/dev/null 2>&1 <<-EOF pause unconfigure lldp custom-tlv unconfigure system interface pattern @@ -373,7 +373,7 @@ reload_service() { unconfigure system platform EOF if [ "$CONFIG_LLDPD_WITH_LLDPMED" = "y" ]; then - $LLDPCLI -u "$LLDPSOCKET" 2>&1 /dev/null <<-EOF + $LLDPCLI -u "$LLDPSOCKET" >/dev/null 2>&1 <<-EOF unconfigure med fast-start EOF @@ -381,9 +381,9 @@ reload_service() { # Rewrite lldpd.conf # If something changed it should be included by the lldpcli call write_lldpd_conf - $LLDPCLI -u "$LLDPSOCKET" -c "$LLDPD_CONF" -c "$LLDPD_CONFS_DIR" 2>&1 /dev/null + $LLDPCLI -u "$LLDPSOCKET" -c "$LLDPD_CONF" -c "$LLDPD_CONFS_DIR" >/dev/null 2>&1 # Broadcast update over the wire - $LLDPCLI -u "$LLDPSOCKET" 2>&1 /dev/null <<-EOF + $LLDPCLI -u "$LLDPSOCKET" >/dev/null 2>&1 <<-EOF resume update EOF @@ -391,6 +391,6 @@ reload_service() { } stop_service() { - rm -rf ${LLDPD_RUN} "$LLDPSOCKET" 2> /dev/null + rm -rf ${LLDPD_RUN} "$LLDPSOCKET" >/dev/null 2>&1 } From patchwork Tue Apr 9 03:41:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Donald X-Patchwork-Id: 1921188 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=xhddWf+h; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=lFoo849/; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VDBgd6ZQCz1yZ6 for ; Tue, 9 Apr 2024 13:45:33 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6AHWYifXGR+kC8eIq35MkzWL/ZO9BhdNoqgNcBcT2kw=; b=xhddWf+h7Su8Oi huu+XpY83qTMEOKRNIpVG1R7QdZzhLtBwdK3aJAsDbz0HodqDdf6KTMSD32o7X7F3NiTS0FfT4UG8 gLQgHDvqZSsI6tYiy6dsFgepwFfdQZsfop7MYwWOB7uJbTTBoWDDCvW8vh882w1e0OQLvS/dznWHS sk+jhvcwCdZ6zx2LNacrSHX9c1su7DAFL/pENEFqHdUzOsWhgPIAqwQfU5ljoAM5NGrdiTcibJwfP 1gbskI1n8PmuqTA9nw00w+oEZ+apbBCGR0z1QpeabbM4V5UdXak8JzssAOelg0cD+ohqunoH76/O3 Qvaq9D+spXSBre0wpjoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru2PK-00000000CLI-1ptC; Tue, 09 Apr 2024 03:44:26 +0000 Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru2P5-00000000CEc-1R1T for openwrt-devel@lists.openwrt.org; Tue, 09 Apr 2024 03:44:12 +0000 Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2d8a24f8a3cso5132371fa.1 for ; Mon, 08 Apr 2024 20:44:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712634249; x=1713239049; darn=lists.openwrt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=xS+2mPfOzC0KjgzHN539/3LeYkRub+lgN+2la9X8Sq8=; b=lFoo849/VCiVXCWjTU36C9bQ1LYgq52VriuyqPGxY0PuSZuQ7fKpyNd5Hw5nozajTg mJcJfdsxwrt5hNDQPkIUnZ+6P36Q/+mkiTZo3L+u6++qR6Ak0Afe9cwfXKTQ7CpaN4w2 FjpOpfBOi3MlhdsuWywjFBGi6BMXfTMM6vhGPo+qEsqzSYO7/CaUlyURb09VAkwG+Ma3 0/cHnQVfTLePpMOugEgi7TvJ+9VE0eKCbHBDLGlLNXmw2zP5ehF8BkzKr8IdjSytbI3L XcetoOJNZA7YdFRNxM7TNOavUixUcmTxXh8jwrRVfyPHBZzqiVhwgYb+YRMgfx9QdC12 DXHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712634249; x=1713239049; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=xS+2mPfOzC0KjgzHN539/3LeYkRub+lgN+2la9X8Sq8=; b=TO2shy0RFD8HzHqYjNJlq2Q2fm7Bf8L4xwZ3cKjUzseyeJqyFKe2pwG+bNMzNIOK5b gQ4aJD6IXROQUNH9Sg770bDKlTGLsmY0Gt6nCjpDIxNccnDvI9LqXLJAhUdpsxxn9oPW V7xkF+ZnRDzRiTRADQU7XgxjBdB5iiMW4p0o+kqfnD3nCkvKpl/EVYtgzXjOo2MzrsE9 wqSzYY24krZDhi5X3Jn/acz79RqsS3QBHZgQMIJHod9SKrmUSFIF1rSG3KCZ+ul5XsIY bi/6H4VCTksc/QN3tMidCe3tvhWbtMTXCOKqonotT3iLEw0aideKapFv8xmUCBxWaSMY HRzA== X-Gm-Message-State: AOJu0YwkIQ8wrw6O98cVZtXjyi3+bjh7gDqeZP8pxcBaqJrbDrUw6EVI u3JJ6wBHJmVd4mtjYhtt0sdZNzIs/PNiOFBwqd1sbxzgUXbO3gYa7a8D6ohA X-Google-Smtp-Source: AGHT+IHQl4zULHxbDtbBU6jccPOx3GOmFjnnDtyLdYDZWpyYzdpDZ4oLbWTp6M1vdUgbLnQ3515QJA== X-Received: by 2002:a2e:87ce:0:b0:2d4:54f2:c409 with SMTP id v14-20020a2e87ce000000b002d454f2c409mr7721193ljj.38.1712634248776; Mon, 08 Apr 2024 20:44:08 -0700 (PDT) Received: from blackhol3 ([2001:9b0:40::cae3:cb03]) by smtp.gmail.com with ESMTPSA id n9-20020a2e86c9000000b002d2191e20e1sm1374790ljj.92.2024.04.08.20.44.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 20:44:08 -0700 (PDT) From: Paul Donald To: OpenWrt Development List Subject: [PATCH v2 4/7] lldpd: note about capabilities Date: Tue, 9 Apr 2024 05:41:04 +0200 Message-ID: <20240409034405.78194-5-newtwen+github@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240409034405.78194-1-newtwen+github@gmail.com> References: <20240402130221.58706-1-newtwen+github@gmail.com> <20240409034405.78194-1-newtwen+github@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240408_204411_410232_B758BBA5 X-CRM114-Status: UNSURE ( 9.27 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: only available from >= 1.0.15 Comments are useful. Apparently this config parameter was committed when openwrt used an older version of lldpd which did not yet support it. Signed-off-by: Paul Donald --- package/network/services/lldpd/files/lldpd.init | 1 + 1 file changed, 1 insertion(+) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:233 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [newtwen+github(at)gmail.com] X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org only available from >= 1.0.15 Comments are useful. Apparently this config parameter was committed when openwrt used an older version of lldpd which did not yet support it. Signed-off-by: Paul Donald --- package/network/services/lldpd/files/lldpd.init | 1 + 1 file changed, 1 insertion(+) diff --git a/package/network/services/lldpd/files/lldpd.init b/package/network/services/lldpd/files/lldpd.init index 0334156fee..284c37c2ef 100644 --- a/package/network/services/lldpd/files/lldpd.init +++ b/package/network/services/lldpd/files/lldpd.init @@ -120,6 +120,7 @@ write_lldpd_conf() local lldp_mgmt_ip config_get lldp_mgmt_ip 'config' 'lldp_mgmt_ip' + # Configurable capabilities in lldpd >= v1.0.15 local lldp_syscapabilities config_get lldp_syscapabilities 'config' 'lldp_syscapabilities' From patchwork Tue Apr 9 03:41:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Donald X-Patchwork-Id: 1921191 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=nswWHrqZ; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=nlnLnzWp; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VDBgk2XWwz1yYH for ; Tue, 9 Apr 2024 13:45:38 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tSWXWEWCR6Ym8plqNO+PyI2w0EN9CxoTkJnWymEmrko=; b=nswWHrqZC89rjh gARktps+UhR8tV4G42WdWRsFGjaGHh5ZRwJ/LkmiV6fuI3pSXGf3WWNxa17jgMtnL7wzaCLL7xnmE 86pVE5RtBH7jGXQZqm6SnOyBS2FLpkis2k1HWNcpFhBWvUB2dEZKvwMHGMoLmyKUgrKZCJUg7g/H7 ZRZR7G/kNrdLdgCl1tXQA8+s/X94nv6dPb62ZnByq4hyWw4xOAhRWZda3adFZiKgr14B9N5ip/f6Y /FMk9spoVDX7fKGayQynCoLHIWwxG4CY0iTzLlTlNnb9kPkY+2CQdMGhcQFyda2AuNKpDJU/XEMm/ N/+Dol37dZckPHj9lFdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru2PO-00000000CMv-0hjz; Tue, 09 Apr 2024 03:44:30 +0000 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru2P6-00000000CFc-2EHY for openwrt-devel@lists.openwrt.org; Tue, 09 Apr 2024 03:44:13 +0000 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2d4515ec3aaso44177191fa.1 for ; Mon, 08 Apr 2024 20:44:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712634250; x=1713239050; darn=lists.openwrt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=jkjgtfiLJrrcEAFQaGh0ypjpD/71wrTftWTY6al96hs=; b=nlnLnzWpBO3j2EgrzX8Sg7LHhxNOScQG6xOTlPubthzljkimENktnnEkxoza/nimp7 MGir4JexzAhHhJD9B3uXeGjw5fm2I6xBCrbfRwCgJx9ZOgYrDUqBmVic52ym4yptSFcZ LlxCh+HqfkYh7b0zNJZDELhu4xPI+YWRYcGVW5tiRx7fD+5rVXZE7IR2Ji7nfKpGgXxa JQwN7F5XOf79I7vLr4mqVMsmSEt9ByBDwxndSkaLmYHjX2BfL0DiYNJKUTlqSku3pbRl jlXCXRLavFKRdXfJvkuo4FrYHrzmSVnRInzbb4KQb1e32p/onvUJ8xwbhqT/slmfAb3v Fq4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712634250; x=1713239050; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=jkjgtfiLJrrcEAFQaGh0ypjpD/71wrTftWTY6al96hs=; b=SL0kpUglIeXW0ALokaXOwCuZyCMgDJvaR06ce22PIEqNcXTjCFutyaa5uk8qcX0AR+ zK2kh04iSIxa0ljKe62VHbyuIgf1hbRp9jGzHmyOxYkrTXrVYP7zP9ONCxe4tTQuJPUK scXy1Ly2omjklhfRI+ZOqzXlxBRewHgSGhqtTZ/kggmSuPztMONy0PDZqcGUOqN9VTNJ pw0nrGgpahAzCWei9PqX9XskXO1TRq8kFXxHKWfubb+LGed5Vhjx5wJgZk5Jyg9f/Dtx mnllLdMYr9ImGCbuItXFX+nShg2+wNy6DS1OoPYJYbtSF5gFEG3KWiKqLd71rDVb74AK BqJA== X-Gm-Message-State: AOJu0YxKi3XLjYh/mgeUlcUYZ2pAel2p3ZAWeD/iYdxLRANt2uYhAiGf zgrb5wKhfv04wrpTrXYN4IBn0ZD03DVNJ+IynTR94dfDSzkjibvzJ7AMPxVv X-Google-Smtp-Source: AGHT+IEhmT/hK6b9uioL/iFhU5hKRfo5HZ6P+VaA6ZeMaL/cmSs+QmDXmaA52w12m9lb7CGV3NCC2g== X-Received: by 2002:a05:651c:10c4:b0:2d6:9054:5b5c with SMTP id l4-20020a05651c10c400b002d690545b5cmr324850ljn.26.1712634249616; Mon, 08 Apr 2024 20:44:09 -0700 (PDT) Received: from blackhol3 ([2001:9b0:40::cae3:cb03]) by smtp.gmail.com with ESMTPSA id n9-20020a2e86c9000000b002d2191e20e1sm1374790ljj.92.2024.04.08.20.44.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 20:44:08 -0700 (PDT) From: Paul Donald To: OpenWrt Development List Subject: [PATCH v2 5/7] lldpd: make capabilities advertisement controllable Date: Tue, 9 Apr 2024 05:41:05 +0200 Message-ID: <20240409034405.78194-6-newtwen+github@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240409034405.78194-1-newtwen+github@gmail.com> References: <20240402130221.58706-1-newtwen+github@gmail.com> <20240409034405.78194-1-newtwen+github@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240408_204412_590555_B050FFA2 X-CRM114-Status: UNSURE ( 9.30 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Defaults to off. Only available from >= 1.0.15 These capabilities are sent in TLV. Content analysis details: (1.6 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:229 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [newtwen+github(at)gmail.com] 1.8 LONGWORDS Long string of long words X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org Defaults to off. Only available from >= 1.0.15 These capabilities are sent in TLV. Signed-off-by: Paul Donald --- package/network/services/lldpd/files/lldpd.init | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/package/network/services/lldpd/files/lldpd.init b/package/network/services/lldpd/files/lldpd.init index 284c37c2ef..83af6649a9 100644 --- a/package/network/services/lldpd/files/lldpd.init +++ b/package/network/services/lldpd/files/lldpd.init @@ -124,6 +124,10 @@ write_lldpd_conf() local lldp_syscapabilities config_get lldp_syscapabilities 'config' 'lldp_syscapabilities' + # Configurable capabilities in lldpd >= v1.0.15 + local lldp_capability_advertisements + config_get_bool lldp_capability_advertisements 'config' 'lldp_capability_advertisements' 0 + if [ "$CONFIG_LLDPD_WITH_LLDPMED" = "y" ]; then local lldpmed_fast_start config_get_bool lldpmed_fast_start 'config' 'lldpmed_fast_start' 0 @@ -164,6 +168,7 @@ write_lldpd_conf() [ -n "$lldp_hostname" ] && echo "configure system hostname" "\"$lldp_hostname\"" >> "$LLDPD_CONF" [ -n "$lldp_mgmt_ip" ] && echo "configure system ip management pattern" "\"$lldp_mgmt_ip\"" >> "$LLDPD_CONF" [ -n "$lldp_syscapabilities" ] && echo "configure system capabilities enabled $lldp_syscapabilities" >> "$LLDPD_CONF" + if [ "$CONFIG_LLDPD_WITH_LLDPMED" = "y" ] && [ "$lldpmed_fast_start" -gt 0 ]; then if [ "$lldpmed_fast_start_tx_interval" -gt 0 ]; then echo "configure med fast-start tx-interval $lldpmed_fast_start_tx_interval" >> "$LLDPD_CONF" @@ -189,6 +194,7 @@ write_lldpd_conf() [ -n "$lldp_platform" ] && echo "configure system platform" "\"$lldp_platform\"" >> "$LLDPD_CONF" [ -n "$lldp_tx_interval" ] && echo "configure lldp tx-interval $lldp_tx_interval" >> "$LLDPD_CONF" [ "$lldp_tx_hold" -gt 0 ] && echo "configure lldp tx-hold $lldp_tx_hold" >> "$LLDPD_CONF" + [ "$lldp_capability_advertisements" -gt 0 ] && echo "configure lldp capabilities-advertisements" >> "$LLDPD_CONF" # Since lldpd's sysconfdir is /tmp, we'll symlink /etc/lldpd.d to /tmp/$LLDPD_CONFS_DIR [ -e "$LLDPD_CONFS_DIR" ] || ln -s /etc/lldpd.d "$LLDPD_CONFS_DIR" @@ -367,6 +373,7 @@ reload_service() { $LLDPCLI -u "$LLDPSOCKET" >/dev/null 2>&1 <<-EOF pause unconfigure lldp custom-tlv + unconfigure lldp capabilities-advertisements unconfigure system interface pattern unconfigure system description unconfigure system hostname From patchwork Tue Apr 9 03:41:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Donald X-Patchwork-Id: 1921190 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=lqADDDkt; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=S50nvtvt; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VDBgg5Rglz1yYM for ; Tue, 9 Apr 2024 13:45:35 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E5gVEX/ZSyt+Friv1w88ZCoO39MLSbJ+1KazDKnxVrM=; b=lqADDDkt4BBeca 125X5In//hgIcjqmWNADXS2HoYazCfvlIMWAwrYH2eqNUADa/rirfElN2JM4l8/Z6nhxRrxNdLXlI J65Dz8PlsIpSy3i2Xa3QoIJh3eHZ2wt1ENi5BA0TMSCPmdhAkko0j97UXrSv+Zdd3ru4bewE8AVBm e2x73zmKKEBVs3E1BcGRxlXvJYG3JJkEEEedNnPnBMaYK0gkpU2YThSl1lzF4LGJAsnxheNRW8sFs 8EryJmN15qA6xv2AOwnl6YgTMttemk8rVbtZzEABwQEzM2OBMqP+uORVJPu1P3keM0xuOf55iZcpl OPyjYQZjslLKFL4sDrjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru2PR-00000000COd-40MG; Tue, 09 Apr 2024 03:44:34 +0000 Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru2P6-00000000CFh-2o12 for openwrt-devel@lists.openwrt.org; Tue, 09 Apr 2024 03:44:14 +0000 Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2d895138ce6so21218101fa.0 for ; Mon, 08 Apr 2024 20:44:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712634250; x=1713239050; darn=lists.openwrt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=i9XZrHR/iE605+P7o64CoT2IqEnLMH/xQemkcadnxLY=; b=S50nvtvtajMwg5M07Fu4qPuxUA70JLenjT/2egR7X7/4MRVSYH6PbVXpYXRjr+Knmj Bcq9NMXTnOT+pxxwAz7DwX/IU1674kzU4bPUvg97h2H+4wYe3af09ajLoq5iTjQvCOkk Y8pRqWiW5d0qTKuvTuFaqrLsfr69rJfe58cqSRtDuaSQ0AgWJIJ3LEDO+Lxs5BoojM8S UZicAiGtOuo9InlGGTlUjOzC6Y2GGiaDgrNFyRp0lnfLGrHtX3vDEn2wTRSdS2/B4UYu YXPjj2kjtMuDZVw2cmcMt4ZEw3EKAE/sn40ahhBJU/lWpxiDT98SDPkE9KcRY/6CmiOX f/MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712634250; x=1713239050; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=i9XZrHR/iE605+P7o64CoT2IqEnLMH/xQemkcadnxLY=; b=AgwGxcTfC5pVJg8X5K3HNdtdbq0+Le03yRzyY0cNEuLEWlXZ3FJopE2dwHV3EI0/vK 7x0Wq29ZxwXbC6trco60SEjZZFplWs8nVg8mo0L9yrnztx3Ep6VrI9jFY8zDHwvGhsUD c4T6ApcYqMUfXUlgyw2I54ppUsKblduBXdeT2PtmspUFb8WoT5+k32Brzm9sg8v0McEg 2IBRDo3m7dC3IxhVDZzMlVJRmIPiJhkpvpk5P/kiKPId70P6W/D0Wo9IGOqJdd1S6EMs 8rUvfzgMNBLHd/o3v+oakdKPIxBmQfn9kj3F927oUWehYNs6UEoue8q9vwcj2CJngwh3 rY0Q== X-Gm-Message-State: AOJu0Yzya/8TIL8ysPDaMjaIpjSdsYx+GC7huRLwQRdpHTIt0Wxg7ADQ QRFJO6FFKdPQ0TJFSSdSf6uZEt8QoLw7CbvkqgEp2ex+vyBLwSPs0bTuFthr X-Google-Smtp-Source: AGHT+IEk/UXbRHei+4bJccO0tjjVbGIHxVIYqBPSl+ikCLYvZHarSIbrl3wnOdbpFso8ybKj0WK11Q== X-Received: by 2002:a2e:878d:0:b0:2d7:7c0:b077 with SMTP id n13-20020a2e878d000000b002d707c0b077mr6786797lji.43.1712634250016; Mon, 08 Apr 2024 20:44:10 -0700 (PDT) Received: from blackhol3 ([2001:9b0:40::cae3:cb03]) by smtp.gmail.com with ESMTPSA id n9-20020a2e86c9000000b002d2191e20e1sm1374790ljj.92.2024.04.08.20.44.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 20:44:09 -0700 (PDT) From: Paul Donald To: OpenWrt Development List Subject: [PATCH v2 6/7] lldpd: make management address advertisement controllable Date: Tue, 9 Apr 2024 05:41:06 +0200 Message-ID: <20240409034405.78194-7-newtwen+github@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240409034405.78194-1-newtwen+github@gmail.com> References: <20240402130221.58706-1-newtwen+github@gmail.com> <20240409034405.78194-1-newtwen+github@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240408_204412_789170_939D7B63 X-CRM114-Status: UNSURE ( 9.17 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Defaults to off. Available from >= 0.7.15 These are sent in TLV Content analysis details: (1.6 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:22c listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [newtwen+github(at)gmail.com] 1.8 LONGWORDS Long string of long words X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org Defaults to off. Available from >= 0.7.15 These are sent in TLV Signed-off-by: Paul Donald --- package/network/services/lldpd/files/lldpd.init | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/package/network/services/lldpd/files/lldpd.init b/package/network/services/lldpd/files/lldpd.init index 83af6649a9..54e7c76c4c 100644 --- a/package/network/services/lldpd/files/lldpd.init +++ b/package/network/services/lldpd/files/lldpd.init @@ -128,6 +128,10 @@ write_lldpd_conf() local lldp_capability_advertisements config_get_bool lldp_capability_advertisements 'config' 'lldp_capability_advertisements' 0 + # Broadcast management address in lldpd >= 0.7.15 + local lldp_mgmt_addr_advertisements + config_get_bool lldp_mgmt_addr_advertisements 'config' 'lldp_mgmt_addr_advertisements' 0 + if [ "$CONFIG_LLDPD_WITH_LLDPMED" = "y" ]; then local lldpmed_fast_start config_get_bool lldpmed_fast_start 'config' 'lldpmed_fast_start' 0 @@ -195,6 +199,7 @@ write_lldpd_conf() [ -n "$lldp_tx_interval" ] && echo "configure lldp tx-interval $lldp_tx_interval" >> "$LLDPD_CONF" [ "$lldp_tx_hold" -gt 0 ] && echo "configure lldp tx-hold $lldp_tx_hold" >> "$LLDPD_CONF" [ "$lldp_capability_advertisements" -gt 0 ] && echo "configure lldp capabilities-advertisements" >> "$LLDPD_CONF" + [ "$lldp_mgmt_addr_advertisements" -gt 0 ] && echo "configure lldp management-addresses-advertisements" >> "$LLDPD_CONF" # Since lldpd's sysconfdir is /tmp, we'll symlink /etc/lldpd.d to /tmp/$LLDPD_CONFS_DIR [ -e "$LLDPD_CONFS_DIR" ] || ln -s /etc/lldpd.d "$LLDPD_CONFS_DIR" @@ -374,6 +379,7 @@ reload_service() { pause unconfigure lldp custom-tlv unconfigure lldp capabilities-advertisements + unconfigure lldp management-addresses-advertisements unconfigure system interface pattern unconfigure system description unconfigure system hostname From patchwork Tue Apr 9 03:41:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Donald X-Patchwork-Id: 1921192 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=OIuGZDJr; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=RxdZUfzB; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VDBgl6wYdz1yYH for ; Tue, 9 Apr 2024 13:45:39 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NRrHRxd0AlVw6/EeRELiIcsNYcH/OQLJ4uA0LiCQE5g=; b=OIuGZDJrGGLmJ9 uADQZ8ougSkVH4UkQlKwbodygCujZ1hiT5f+607zYKySpTxy0jN623jx4lWA2w1KrhaEA+fDa4S5Z BYR9EcWq30/WOek9NERtU8J8SgOF1Y/L4rk+ejikMRh+fYlFGjm7LhOc5EliBy92xdYY+rJnOtCX/ gh//BBdRNCYW4u5iBznJIFlWBtPJogMlOVCYlbM+/z9tdoUaSNvKuTxMW61S+/rLD0ltXI8Wsv6+t jYinqfh8qr39covz/0bsMlavNGtKBMbmU9Np6xTBlvWAL/UQb1JbVvUVgoVkYnnmJ1LQuf2CKSEPc 90tk1iIW7YpWctFOhgeA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru2Pb-00000000CUv-3sId; Tue, 09 Apr 2024 03:44:44 +0000 Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru2P7-00000000CG6-1hdU for openwrt-devel@lists.openwrt.org; Tue, 09 Apr 2024 03:44:15 +0000 Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2d886f17740so20405221fa.1 for ; Mon, 08 Apr 2024 20:44:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712634251; x=1713239051; darn=lists.openwrt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=ichJccNIHkW4epvRC/+f2H/2Gi4hhVkdhOAn8TNMAQA=; b=RxdZUfzBvUrYjih+L1rI9qDTy35u5Hz8U2Amt8682ieEvmZmSG+6Fk0RqIwVyofNAG z52o/fj6lOHL89RFjA5ja9PuwfpbdMeNzRKC/Bw15NhX5TAo1drZWsx19c6Tx14lZa5P I8lgHG8NGk2n4mAg+mHk/sG7AxcjTL0lZMnaT+6Ck4mtuXznvBy80rSFSbh96LF91c1U PrycmzBL9oCl5t3dSIxde/gCwAB0tOFQTrvx7tza22Pyl4RM2/rvSet0mySd3ZSDdIAv mNae3c0qs6EHX0mNck8y2k6KS7WuP7+0Y9PaVdGyi1/FdhLP8fq8B0gcr6vxjEnP3BFo 8xgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712634251; x=1713239051; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ichJccNIHkW4epvRC/+f2H/2Gi4hhVkdhOAn8TNMAQA=; b=feu4vHRXe3SElYkJz57Y/7o7hRs6/w6TMqoMeKpyeDNw/I8iWNN2CPYpkuji8F1x0s c5uwHIiafWq5Ie9IWUTQSjYU9opPOs01v/yEWole2a2dtLSfCSI1+x8VhmwH//qo3LVk SFyzYybmoCgVNzDHbiWGZLG4QzdiiY7lnCyjRTXYZANzmm54eCa5OdfhbMPWyVI0hZvJ 7yYbOxUVQsKnGkrkoOYyaISgQYXkTz7Zdp3urdNmowpldIYxwMMJb3KED+qlei8KMUnw wuRuVgI++bAlc3RZq+VFTrjtdH0kieiVQNKoG35u6bPGgz1EPsKTQzMa7oY1kzDGp0lm bRlg== X-Gm-Message-State: AOJu0YwTpUQnUQHPBLHVVn3Z5YC31mPPQgaZUuisXu/AgOTQ28bO5wmw nb6X4BWWZLBVJaoPb915Z/i7zSVgna5A3KArCIg7JlTbEaLvHSipbOWozWD3 X-Google-Smtp-Source: AGHT+IFFbdjXu5r0H+CVNyf4ZfrMMseSLB10cSYZeiq+LGajg9iOEMb8og4g5QKW7Bn8RH7bRmEU4Q== X-Received: by 2002:a05:651c:1401:b0:2d8:6097:abf7 with SMTP id u1-20020a05651c140100b002d86097abf7mr309327lje.21.1712634251002; Mon, 08 Apr 2024 20:44:11 -0700 (PDT) Received: from blackhol3 ([2001:9b0:40::cae3:cb03]) by smtp.gmail.com with ESMTPSA id n9-20020a2e86c9000000b002d2191e20e1sm1374790ljj.92.2024.04.08.20.44.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 20:44:10 -0700 (PDT) From: Paul Donald To: OpenWrt Development List Subject: [PATCH v2 7/7] lldpd: bump version Date: Tue, 9 Apr 2024 05:41:07 +0200 Message-ID: <20240409034405.78194-8-newtwen+github@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240409034405.78194-1-newtwen+github@gmail.com> References: <20240402130221.58706-1-newtwen+github@gmail.com> <20240409034405.78194-1-newtwen+github@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240408_204413_489644_3AE34A97 X-CRM114-Status: UNSURE ( 9.58 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 3 -> 4 Signed-off-by: Paul Donald --- package/network/services/lldpd/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/network/services/lldpd/Makefile b/package/network/services/lldpd/Makefile index 18cdda33ce..5a9a9732d2 100644 --- a/package/network/services/lldpd/Makefile +++ b/package/network/s [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:236 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [newtwen+github(at)gmail.com] X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org 3 -> 4 Signed-off-by: Paul Donald --- package/network/services/lldpd/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/network/services/lldpd/Makefile b/package/network/services/lldpd/Makefile index 18cdda33ce..5a9a9732d2 100644 --- a/package/network/services/lldpd/Makefile +++ b/package/network/services/lldpd/Makefile @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=lldpd PKG_VERSION:=1.0.17 -PKG_RELEASE:=3 +PKG_RELEASE:=4 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz PKG_SOURCE_URL:=https://github.com/lldpd/lldpd/releases/download/$(PKG_VERSION)/