From patchwork Sat Apr 6 12:38:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 1920402 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=0qu1y4V+; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=HuBUqh02; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VBZfg08cfz1yYf for ; Sat, 6 Apr 2024 23:39:07 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vWe6uurmQGSphHTkyIxHP5N85bsRRNNbM3OrafEXYe0=; b=0qu1y4V+LMmNIM kq+od/DfhBB0Hapd8lJHqhfgjq275gU1jqsrzTI8X9fwi6i8W1pzhPsS8R3iBlQRDiQAEhpKX10LE XJ5D6WVEvOH/gtvbYCQVL+XAVDRBk8ds4RXsctX0CIv89vkMMvQZXrwagqcTVy9F2MkIBFchBzH94 G5eLcHmovVIIQxh4W/Skou8zTm1hmXq2qQqm2n6HIDqtSnZFmAQgPLqFmKySuqSYLvjay9Sr2J3Xx RFX6xNkBgtINYnrHZwfwgunThs4foktcWqRC/x2xlAU2YFQ9PFHavODEWBdG1prlTvuw8IiP/zu0c HDv3e0I1fkQeGDFtxFIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5K5-0000000AI32-2xYx; Sat, 06 Apr 2024 12:39:05 +0000 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5K2-0000000AI13-314q for kvm-riscv@lists.infradead.org; Sat, 06 Apr 2024 12:39:04 +0000 Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-2a226f8e44aso2054099a91.0 for ; Sat, 06 Apr 2024 05:39:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712407140; x=1713011940; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IbXS3mPbclefehTNkJZ/z/tUSWiPiMKoUzf34+kT7OI=; b=HuBUqh02RuK5Hgl0sSdN9r8nd38GdYEyo/V4V1Ej42fH7gmGWFoHOMUjsggOQ5ljpO BvDS0H0JR6gPJkRnX1tRrw5pCIjzTpx8SDHAACeRYz0DcViYr6HGVDE4XTRJVG77lmdP 7T4WyzSvOETSqZV63YIEbN8hPykSZYvkjD7IZmKvsbYRqRn3Twn4Amr5HY39sMRd6BrU gU5nQWhckip7dqgjVXyiDl28NJDsMCIdbqATKLbpW94MUElrrRJX57zBYb6RVw99KCF0 lsXMxirsOVJN63lFY/iVKZsWKmtNm8E3Lctl4FMeshzX4Nl9FXrkHVrXs1SUqxih1FdD zbHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712407140; x=1713011940; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IbXS3mPbclefehTNkJZ/z/tUSWiPiMKoUzf34+kT7OI=; b=PdjXFYizEOFnUmGV0a4UN8TYuc1hbPP8mUWxdnwtosxQzy6ahR5nsRsyjRrN8YEVIE FLjajRmUwbTeo+cUBya/LFUSSZ6xnTS8dhyHToZZ4saSP9Gzb+Qc39UyaLgEXXTMlmvE tOlxt6Qj4A3RJYqOuVngO1FDHTf8dnQe2e6Huhaa16pS7reRs8ERSD8olxPU6OXgkRX+ tHDTmhD7GkF/q7h0bwr0ca1bwcUHAkZUIYlObMgRM0RnvCwa85mpGZ4RTNkvMlN2VjYk Z0Rr7mvrvn4wdUr/OYk+Dw0pJ2BFMZ6VrIwzMsduYxblIgi88rpspdQYzZ8uQqCPhRoV 5M8w== X-Forwarded-Encrypted: i=1; AJvYcCV9qdNG2tBpSOaIZgMhZ8lhwfRIzmMpYLxaSofyVY9s4UdRVdLws4unCDOQnXzE8UUWUOPNpLrAOTQSuMPeAcjsOPn1NpVwsXjJrEuMUA== X-Gm-Message-State: AOJu0YwApdxJXU/I9PuTBhHKymsKYWP/JsTOIl0LKnEQfGQQF+MDtjdz 3w0SlTAR96Hvx3M3f6/okbFA5UREf3rsx4rnnOgGlBfD2fiXM6hH X-Google-Smtp-Source: AGHT+IGZuRmyUSURkYq7nO4hW7JRTEzJugpaiD6OSQX4jAsuLRrinwKGCqQjaKwfezP4e8hM/R6shA== X-Received: by 2002:a17:90b:3795:b0:2a2:53ee:bd08 with SMTP id mz21-20020a17090b379500b002a253eebd08mr3514004pjb.8.1712407140290; Sat, 06 Apr 2024 05:39:00 -0700 (PDT) Received: from wheely.local0.net (124-169-104-130.tpgi.com.au. [124.169.104.130]) by smtp.gmail.com with ESMTPSA id nt5-20020a17090b248500b002a279a86e7asm5050576pjb.7.2024.04.06.05.38.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 05:38:59 -0700 (PDT) From: Nicholas Piggin To: Andrew Jones Cc: Nicholas Piggin , Paolo Bonzini , Thomas Huth , Alexandru Elisei , Eric Auger , Janosch Frank , Claudio Imbrenda , =?utf-8?q?Nico_B=C3=B6hr?= , David Hildenbrand , Shaoqin Huang , Nikos Nikoleris , David Woodhouse , Ricardo Koller , rminmin , Gavin Shan , Nina Schoetterl-Glausch , Sean Christopherson , kvm@vger.kernel.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: [RFC kvm-unit-tests PATCH v2 01/14] Add initial shellcheck checking Date: Sat, 6 Apr 2024 22:38:10 +1000 Message-ID: <20240406123833.406488-2-npiggin@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240406123833.406488-1-npiggin@gmail.com> References: <20240406123833.406488-1-npiggin@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240406_053902_820615_AE6DDEE4 X-CRM114-Status: GOOD ( 18.37 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This adds a basic shellcheck sytle file, some directives to help find scripts, and a make shellcheck target. When changes settle down this could be made part of the standard build / CI flow. Suggested-by: Andrew Jones Reviewed-by: Andrew Jones Signed-off-by: Nicholas Piggin --- .shellcheckrc | 30 ++++++++++++++++++++++++++++++ Makefile | 4 ++++ README.md | 3 +++ scripts/common.bash [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:1033 listed in] [list.dnswl.org] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [npiggin(at)gmail.com] X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org This adds a basic shellcheck sytle file, some directives to help find scripts, and a make shellcheck target. When changes settle down this could be made part of the standard build / CI flow. Suggested-by: Andrew Jones Reviewed-by: Andrew Jones Signed-off-by: Nicholas Piggin --- .shellcheckrc | 30 ++++++++++++++++++++++++++++++ Makefile | 4 ++++ README.md | 3 +++ scripts/common.bash | 5 ++++- 4 files changed, 41 insertions(+), 1 deletion(-) create mode 100644 .shellcheckrc diff --git a/.shellcheckrc b/.shellcheckrc new file mode 100644 index 000000000..491af18bd --- /dev/null +++ b/.shellcheckrc @@ -0,0 +1,30 @@ +# shellcheck configuration file +external-sources=true + +# Optional extras -- https://www.shellcheck.net/wiki/Optional +# Possibilities, e.g., - +# quote‐safe‐variables +# require-double-brackets +# require-variable-braces +# add-default-case + +# Disable SC2004 style? I.e., +# In run_tests.sh line 67: +# if (( $unittest_run_queues <= 0 )); then +# ^------------------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. +disable=SC2004 + +# Disable SC2086 for now, double quote to prevent globbing and word +# splitting. There are lots of places that use it for word splitting +# (e.g., invoking commands with arguments) that break. Should have a +# more consistent approach for this (perhaps use arrays for such cases) +# but for now disable. +# SC2086 (info): Double quote to prevent globbing and word splitting. +disable=SC2086 + +# Disable SC2235. Most developers are used to seeing expressions +# like a || (b && c), not a || { b && c ; }. The subshell overhead in +# kvm-unit-tests is negligible as it's not shell-heavy in the first +# place (time is dominated by qemu startup/shutdown and test execution) +# SC2235 (style): Use { ..; } instead of (..) to avoid subshell overhead. +disable=SC2235 diff --git a/Makefile b/Makefile index 4e0f54543..4863cfdc6 100644 --- a/Makefile +++ b/Makefile @@ -141,6 +141,10 @@ cscope: -name '*.[chsS]' -exec realpath --relative-base=$(CURDIR) {} \; | sort -u > ./cscope.files cscope -bk +.PHONY: shellcheck +shellcheck: + shellcheck -a run_tests.sh */run */efi/run scripts/mkstandalone.sh + .PHONY: tags tags: ctags -R diff --git a/README.md b/README.md index 6e82dc225..03ff5994e 100644 --- a/README.md +++ b/README.md @@ -193,3 +193,6 @@ with `git config diff.orderFile scripts/git.difforder` enables it. We strive to follow the Linux kernels coding style so it's recommended to run the kernel's ./scripts/checkpatch.pl on new patches. + +Also run make shellcheck before submitting a patch which touches bash +scripts. diff --git a/scripts/common.bash b/scripts/common.bash index ee1dd8659..3aa557c8c 100644 --- a/scripts/common.bash +++ b/scripts/common.bash @@ -82,8 +82,11 @@ function arch_cmd() } # The current file has to be the only file sourcing the arch helper -# file +# file. Shellcheck can't follow this so help it out. There doesn't appear to be a +# way to specify multiple alternatives, so we will have to rethink this if things +# get more complicated. ARCH_FUNC=scripts/${ARCH}/func.bash if [ -f "${ARCH_FUNC}" ]; then +# shellcheck source=scripts/s390x/func.bash source "${ARCH_FUNC}" fi From patchwork Sat Apr 6 12:38:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 1920403 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=nOS7IS/W; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=MSVD8GW0; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VBZfn61h0z1yYf for ; Sat, 6 Apr 2024 23:39:13 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UNOFXUplrJsx8IzN7tH50d31K91xUsou0bnwhxArh5I=; b=nOS7IS/WbouSZ+ jahdiOemNwZj11Ry4Ty4t0MgZr6EHRaPHMHivhCM4BMOkiBNGzrjEzsN7tmjEGp7tY43g19cjGwst jNAKYFsqKmJacfaJpDzzQSEXZ/q4ITbSE69Yu/OIRrLzqu8xUKaJKUODgRcXJhtEoJZAHbSwly1UQ ZWFU3Xd2a4JPd5NkDZ7Li02muT8WuHgwx41zN7XB86Dvav8m6MAvVTd/O80soGa5YN778lLoAKZnk HvRjZbkPcsPzV9MfZ7aj1VuEAEmQwTBv3rUEk4ny6/2rdQgJ/5W/bhduYa3Y4ueCM2Jibmrf1Unj0 EDtQmL4ZeB2xXsDNvbAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5KC-0000000AI5x-2YVP; Sat, 06 Apr 2024 12:39:12 +0000 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5KA-0000000AI4j-1lR0 for kvm-riscv@lists.infradead.org; Sat, 06 Apr 2024 12:39:11 +0000 Received: by mail-pj1-x102a.google.com with SMTP id 98e67ed59e1d1-2a485169476so816815a91.1 for ; Sat, 06 Apr 2024 05:39:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712407149; x=1713011949; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=n6Ak2eXV9+uxmKDVMVAvdf5h+W+GwHpU0A4GvgnXZ/Y=; b=MSVD8GW0SZuvHuWJs2T7t8hKbaXI/OlgqUcA4ZI+O/5iH0UtGStK3D8NHRUrRdF4DM YzKUelxmbXVTwqp15F6AxK90skbaj5+0Gks+cGGknl/eRSbcFSQj9lBqPx0afgaIqHMv xyYQYY3Sl2i7R5tHKqYybHpURyYPagjy5YX6KuHIdnohO8RenZcsqhMfGLKyoDn6Xmtm RXig4ZYLQuVS+YG6MrETFl0mfdnl7P8JepbqLaA0ojD90mMzdqn2ojqDaq5yRwT7FjRX ZftYMym71VmndR7XdaJiRnZwwoTVWCmrSMx1KIQw9TXYZyzz9meYNUY9GJ5+iImMzQOf 2xWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712407149; x=1713011949; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n6Ak2eXV9+uxmKDVMVAvdf5h+W+GwHpU0A4GvgnXZ/Y=; b=M4iA2HFEXiK+fO6wohUZFj9200WH4zrSDklSCWiwsNNEXIHs9ggdiSTWcyNXyzb4ux 5MXIepTSQgY0VQ/PDUmhqaQfIZaugLrGi/Fi+YB4sR7k2lT/fKrg5McWMURDRQiIal7A BEjExXiAMyyS1X0R4PN9lOHrjjJxRwvyDXmfaHf/TJjSQjBdFRrMf7JbKqj63s3q8ZJ9 H3aw//fWLpwUminrwGrl2l936M+0RzdkoXHeSa6IuBKWtaVI+OLONEH3cgd4IKyEji3f n4GLNM3lhEJAcCqCzTCrrYGGuJn+N7baJKlS/oZp0IwFZUJ3RteZPGa7eTPPVQPjaiaE 8ibA== X-Forwarded-Encrypted: i=1; AJvYcCWB6IEF6zxKNp5Kxwiks3zhwrkuCjAoT4ljg9pPMqpGRpO5OpWuJxh0Wkini2CJ9yd07Z6WoGVhgpoBeZXDQRFj3lzh18eQRLhcB7lwVQ== X-Gm-Message-State: AOJu0YzB8yJQp167vdUWYeqj8yM6faiJfQjhafL0BlksLfxq/V2kSFu2 DZxrATNPsNKNAVhO1URd8pCU9gDsfx51Zz9zTMJSyi0uFowgsvJM X-Google-Smtp-Source: AGHT+IEYhDuK2nSdoxNUh6rlvyThWG0NnDzHTSnNytiX2YBBGS47j7JwgJow8VWW5Xms5PawMFdZFg== X-Received: by 2002:a17:90a:f413:b0:2a2:8250:b5d5 with SMTP id ch19-20020a17090af41300b002a28250b5d5mr3527170pjb.18.1712407149116; Sat, 06 Apr 2024 05:39:09 -0700 (PDT) Received: from wheely.local0.net (124-169-104-130.tpgi.com.au. [124.169.104.130]) by smtp.gmail.com with ESMTPSA id nt5-20020a17090b248500b002a279a86e7asm5050576pjb.7.2024.04.06.05.39.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 05:39:08 -0700 (PDT) From: Nicholas Piggin To: Andrew Jones Cc: Nicholas Piggin , Paolo Bonzini , Thomas Huth , Alexandru Elisei , Eric Auger , Janosch Frank , Claudio Imbrenda , =?utf-8?q?Nico_B=C3=B6hr?= , David Hildenbrand , Shaoqin Huang , Nikos Nikoleris , David Woodhouse , Ricardo Koller , rminmin , Gavin Shan , Nina Schoetterl-Glausch , Sean Christopherson , kvm@vger.kernel.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: [RFC kvm-unit-tests PATCH v2 02/14] shellcheck: Fix SC2223 Date: Sat, 6 Apr 2024 22:38:11 +1000 Message-ID: <20240406123833.406488-3-npiggin@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240406123833.406488-1-npiggin@gmail.com> References: <20240406123833.406488-1-npiggin@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240406_053910_492115_22C50DB6 X-CRM114-Status: UNSURE ( 8.40 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: SC2223 (info): This default assignment may cause DoS due to globbing. Quote it. Reviewed-by: Andrew Jones Signed-off-by: Nicholas Piggin --- run_tests.sh | 4 ++-- scripts/runtime.bash | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:102a listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [npiggin(at)gmail.com] X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org SC2223 (info): This default assignment may cause DoS due to globbing. Quote it. Reviewed-by: Andrew Jones Signed-off-by: Nicholas Piggin --- run_tests.sh | 4 ++-- scripts/runtime.bash | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/run_tests.sh b/run_tests.sh index bb3024ff9..9067e529e 100755 --- a/run_tests.sh +++ b/run_tests.sh @@ -158,8 +158,8 @@ function run_task() fi } -: ${unittest_log_dir:=logs} -: ${unittest_run_queues:=1} +: "${unittest_log_dir:=logs}" +: "${unittest_run_queues:=1}" config=$TEST_DIR/unittests.cfg print_testname() diff --git a/scripts/runtime.bash b/scripts/runtime.bash index e4ad1962f..2d7ff5baa 100644 --- a/scripts/runtime.bash +++ b/scripts/runtime.bash @@ -1,6 +1,6 @@ : "${RUNTIME_arch_run?}" -: ${MAX_SMP:=$(getconf _NPROCESSORS_ONLN)} -: ${TIMEOUT:=90s} +: "${MAX_SMP:=$(getconf _NPROCESSORS_ONLN)}" +: "${TIMEOUT:=90s}" PASS() { echo -ne "\e[32mPASS\e[0m"; } SKIP() { echo -ne "\e[33mSKIP\e[0m"; } From patchwork Sat Apr 6 12:38:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 1920404 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=YSA2KaB1; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=KuiQVmoe; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VBZfz3kd4z1yYf for ; Sat, 6 Apr 2024 23:39:23 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8x6gySGldqz5Y/rtcNgnNjFpsh6+0yP0lOcuyXu37Ok=; b=YSA2KaB1h9BhSO Mo963kazxLZEzeq3sXP0XfNVAVS8gxuOCOMGUFrCIm4z0Nzft02nzQJ2lNdY8kfkcf/TShL7VPBh3 hl38R5BsEAx+ZF+FmNqZjUYGQdOkdeqCMAhuTc/KbOJ7nJ3Lk3bLZGOvAWyjMxXky8QxeUQuiJ+iq 773GgeP6NQtP8djxaEHLcNKNlHgUjJX7FN6H8G6Yj+obSCdTENEfxHQo6bt3OgZg0vSu3g1PzneHJ Dp6aOlBc2nA2wWeX2XSf1VeX/EGU8RkCmF0oul4u8CnRUl4zQNT9lF3lckzzACdWv3CRK0mGM+bxt YdGjcRd7OMhkpSBd7ehg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5KM-0000000AI9G-11RZ; Sat, 06 Apr 2024 12:39:22 +0000 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5KJ-0000000AI7Z-11x7 for kvm-riscv@lists.infradead.org; Sat, 06 Apr 2024 12:39:20 +0000 Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-5d8b887bb0cso2501282a12.2 for ; Sat, 06 Apr 2024 05:39:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712407158; x=1713011958; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4JXiqEZUiNUnXuxmqi+ca5TsUVImKZg5r/shld6kwl0=; b=KuiQVmoe59EaDt7qnhsIccPywthCF5obTJTXMmcdYAXCH8QiL5jB7GGC691jJVJrFT 7jYYIocNhTIeYvNoSfwRyflW+KSgUlTquRNBjWqve7AFayJb9G+8YYhYTJIVlE9oiwIW nJJQPuv07TNX8IwSxW2dOPKXoeR19e/qAdJtFnXnuns38RF6Teis5JfXMGcm5uuLuNdp VMbA4ngWiSgspPIEOVU4QWs2r6kASr3cVRqpAkskCwpvh7QiDAnw2kIfjsa4cL+oN/oD /pK8h4pQJ4/1F7h5JQnMMt2X277kHx5FCh/fKCgBlumb2BqogRzDGd7CzdLohiGhZGNJ VhKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712407158; x=1713011958; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4JXiqEZUiNUnXuxmqi+ca5TsUVImKZg5r/shld6kwl0=; b=cCkovU5viRUiKuW/biC18zbtEDFZ6KoLFxSVo33q8vnMEqXcIfCu+h4sN/R5o5dcQL 7IanLp/HNWiSNbGJctEpWCAEKotcuhBjA5AL7AUm/8pWngWpQpGEYrfhGGo5tkwthG5U 5KMOcq+VNsmm9XUS6+wh7ryKfX9qqLBtHKKMXXRZ35S12hIwnzj+dvd7gS8J4vGaGyFP 20NqoYQhT1zrHEk8mfAjabkRwCIDqSvcpMSY/QSzLrc+HnFfoeBGrUaI8EpY0cM9AgNa zHaxitpybLsDKPLQ5fs2t3PhR8Sv7Ll6uoP1WtbwOvsFtE6n9LViS3E4Wzx2kSap2YwN 2axQ== X-Forwarded-Encrypted: i=1; AJvYcCV1IJXWQuhq1akLZiA7VbOTNxRbXjh3w/wS1K74K7yaKuOZzaYhk0Xkcp2566oJtIf8LGZmtvCY5IJsFV/WI1ndrrgPm3QXuuQtxfazhw== X-Gm-Message-State: AOJu0Yy8z25YFv6kSnJ52cl10nl+ZsYwhWKsgWZV6M2f6pjVBd8FgV4Y AdLXr3BsKLDWsYh7LGBB1PQREobVcEuOn2udHTcH5bGFG98PgCAuWEz7FbTf X-Google-Smtp-Source: AGHT+IG333LDkbX9VhVWof9DtloUszYhWmLouAuBT0iCtpIluUHJkcW3r50xGy82vnO7oaHc8GPVug== X-Received: by 2002:a05:6a21:7889:b0:1a7:5509:a603 with SMTP id bf9-20020a056a21788900b001a75509a603mr591062pzc.27.1712407158090; Sat, 06 Apr 2024 05:39:18 -0700 (PDT) Received: from wheely.local0.net (124-169-104-130.tpgi.com.au. [124.169.104.130]) by smtp.gmail.com with ESMTPSA id nt5-20020a17090b248500b002a279a86e7asm5050576pjb.7.2024.04.06.05.39.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 05:39:17 -0700 (PDT) From: Nicholas Piggin To: Andrew Jones Cc: Nicholas Piggin , Paolo Bonzini , Thomas Huth , Alexandru Elisei , Eric Auger , Janosch Frank , Claudio Imbrenda , =?utf-8?q?Nico_B=C3=B6hr?= , David Hildenbrand , Shaoqin Huang , Nikos Nikoleris , David Woodhouse , Ricardo Koller , rminmin , Gavin Shan , Nina Schoetterl-Glausch , Sean Christopherson , kvm@vger.kernel.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: [RFC kvm-unit-tests PATCH v2 03/14] shellcheck: Fix SC2295 Date: Sat, 6 Apr 2024 22:38:12 +1000 Message-ID: <20240406123833.406488-4-npiggin@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240406123833.406488-1-npiggin@gmail.com> References: <20240406123833.406488-1-npiggin@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240406_053919_305808_B4DD1F91 X-CRM114-Status: GOOD ( 10.08 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: SC2295 (info): Expansions inside ${..} need to be quoted separately, otherwise they match as patterns. Doesn't appear to be a bug since the match string does not include patterns. Reviewed-by: Andrew Jones Signed-off-by: Nicholas Piggin --- run_tests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:52a listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [npiggin(at)gmail.com] X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org SC2295 (info): Expansions inside ${..} need to be quoted separately, otherwise they match as patterns. Doesn't appear to be a bug since the match string does not include patterns. Reviewed-by: Andrew Jones Signed-off-by: Nicholas Piggin --- run_tests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/run_tests.sh b/run_tests.sh index 9067e529e..116188e92 100755 --- a/run_tests.sh +++ b/run_tests.sh @@ -99,7 +99,7 @@ else local testname="$1" CR=$'\r' while read -r line; do - line="${line%$CR}" + line="${line%"$CR"}" case "${line:0:4}" in PASS) echo "ok TEST_NUMBER - ${testname}: ${line#??????}" >&3 From patchwork Sat Apr 6 12:38:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 1920405 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=myXQRCaQ; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=HpWOaFSn; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VBZgC4zcPz1yYf for ; Sat, 6 Apr 2024 23:39:35 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3HP723FTsoyyQneO8L2MLIFpbh3ahGKTSj5LyLj/m1s=; b=myXQRCaQ4cv9dY 2veYNWXmdQCnjkGFrvD9GUQ66L4HzbE5qBxERRqP1rls9tfFluQwuHLlxHK5OuJfqD4iPH4fKhnlC +idfaGBqQusKK5KszGNFMG8BkYYFgXfBCCetA5aonIYHoH1r3xNTAzdGft1hbuM6nMa/D0Kkc16yr YNnGzSHGy56Wad639DxLuvmdLLBMf6US5b90C2jWmzlXLxgz70iR8soj5AtqwK1OS5CLwczyLuZ26 zrAqgNrO/4bgrVTW8/Kta+WSnL2lJND1xJyd6zvkva0M8SkRYJGF8CmkSjhkFmXk99O8KiHbndWR0 1IBky7lfPs0+1vSNR3Hw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5KY-0000000AIBx-0s3D; Sat, 06 Apr 2024 12:39:34 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5KU-0000000AIBM-3PcM for kvm-riscv@lists.infradead.org; Sat, 06 Apr 2024 12:39:32 +0000 Received: by mail-pj1-x1031.google.com with SMTP id 98e67ed59e1d1-29ddfada0d0so2184242a91.3 for ; Sat, 06 Apr 2024 05:39:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712407167; x=1713011967; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sB3ENgv8+Bm1tRLghaKazWKQeuX0gBEHcWKY2qfgh1Q=; b=HpWOaFSnHZLAjJXu+JxHt+3sCD78e2Xza601vHqgGW1bOnJPJKsTeo+r7q28SKc+ai eFUZDyRt3tBEbEZJNTq84OfRC9DqXPNLjSwBZLJdOOO8IXHXyqn7nffPNRgXPqKdx7L6 FZSnmvFBrLhAuUb7KkVTUBgr+GpNy+lLbKfv7ZZ8oP2z/xK3daJiwnEIFNvFDkNZsG/y xBrC+F8TLXz46mUyGZDp5ec0oW+FUPf8F7ZvL4JgwjUqQd4ItXW5XBQv1aSx9EHl4TN8 pP91VtEkNSpvzrwySVk6+iPQ1UtpitAor2ZqJDZo8dpIiWR2Selu1W9Gi2/kms8D5aks X4+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712407167; x=1713011967; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sB3ENgv8+Bm1tRLghaKazWKQeuX0gBEHcWKY2qfgh1Q=; b=MY7m/TkWZ5g+AlhZhuDuj6KrsM21TsP3V1lac5Dv1LnDSC5X98eUYcjqlb1oAZ6x5P rIPlpFFBm3nDFOQMXQ131sGkKihFXaMjUwEVXdk8nqTGTrB7ddIBPn8jC5cDEWA4r/Np ywQ1djlNvOMOYidYxPpgE6IQAhhYxyf8rV0m8MmCAF5tAxOKyBV6M3Du9aBHpIFn3N7G nvHu+HDDXv1wPHSs7I7hb5sHFA1WHiiXxC/mSNKpuRWYq8u2Z0bkN4C+fAQXKX8mHp9Z SeyJFoAJnLYiuQQ+1p5Bs1XcYy9rPv+7c+pk8J43Qe0/4wI2c8iHs6cXdQXlexWZsv1V Im7w== X-Forwarded-Encrypted: i=1; AJvYcCWeLt6U/tf5INYuiB3//7JyJ6N71qyYS4LwG+06i5SffCy08gIFHxR8O2SX1toDzEb4F0cJD3YRnfuI+eySBpnb4m1kbOzrV8FGEQro0A== X-Gm-Message-State: AOJu0Yy9h2CAvNzcPm+DpsFKkw4Ke8q4SYNBQsegvrsBlIMwwNLVovSz MTAlunwqGrr1pRR4QegPsPy4ygBM3bDVr6ezMFTWVQxR+5L+1mmu X-Google-Smtp-Source: AGHT+IFsGkW61gbRnUwX+F4+qiUlZL7gQ1ZtjFZ3/rMtUrfy5XWV8+BO9FE9c5M3Fd0JMQ+twYXJKQ== X-Received: by 2002:a17:90a:1fc9:b0:2a2:1900:493 with SMTP id z9-20020a17090a1fc900b002a219000493mr3185800pjz.40.1712407167008; Sat, 06 Apr 2024 05:39:27 -0700 (PDT) Received: from wheely.local0.net (124-169-104-130.tpgi.com.au. [124.169.104.130]) by smtp.gmail.com with ESMTPSA id nt5-20020a17090b248500b002a279a86e7asm5050576pjb.7.2024.04.06.05.39.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 05:39:26 -0700 (PDT) From: Nicholas Piggin To: Andrew Jones Cc: Nicholas Piggin , Paolo Bonzini , Thomas Huth , Alexandru Elisei , Eric Auger , Janosch Frank , Claudio Imbrenda , =?utf-8?q?Nico_B=C3=B6hr?= , David Hildenbrand , Shaoqin Huang , Nikos Nikoleris , David Woodhouse , Ricardo Koller , rminmin , Gavin Shan , Nina Schoetterl-Glausch , Sean Christopherson , kvm@vger.kernel.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: [RFC kvm-unit-tests PATCH v2 04/14] shellcheck: Fix SC2094 Date: Sat, 6 Apr 2024 22:38:13 +1000 Message-ID: <20240406123833.406488-5-npiggin@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240406123833.406488-1-npiggin@gmail.com> References: <20240406123833.406488-1-npiggin@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240406_053930_871600_44304716 X-CRM114-Status: GOOD ( 11.20 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: SC2094 (info): Make sure not to read and write the same file in the same pipeline. This is not as clearly bad as overwriting an input file with >, but could appended characters possibly be read in from the input redirection? Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:1031 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [npiggin(at)gmail.com] X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org SC2094 (info): Make sure not to read and write the same file in the same pipeline. This is not as clearly bad as overwriting an input file with >, but could appended characters possibly be read in from the input redirection? Reviewed-by: Andrew Jones Signed-off-by: Nicholas Piggin --- scripts/arch-run.bash | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash index 1901a929f..472c31b08 100644 --- a/scripts/arch-run.bash +++ b/scripts/arch-run.bash @@ -492,6 +492,8 @@ env_file () env_errata () { + local new_env + if [ "$ACCEL" = "tcg" ]; then export "ERRATA_FORCE=y" elif [ "$ERRATATXT" ] && [ ! -f "$ERRATATXT" ]; then @@ -500,7 +502,8 @@ env_errata () elif [ "$ERRATATXT" ]; then env_generate_errata fi - sort <(env | grep '^ERRATA_') <(grep '^ERRATA_' $KVM_UNIT_TESTS_ENV) | uniq -u >>$KVM_UNIT_TESTS_ENV + new_env=$(sort <(env | grep '^ERRATA_') <(grep '^ERRATA_' $KVM_UNIT_TESTS_ENV) | uniq -u) + echo "$new_env" >>$KVM_UNIT_TESTS_ENV } env_generate_errata () From patchwork Sat Apr 6 12:38:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 1920406 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=mDNuEXPL; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=NNVFhLcj; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VBZgK1Ydyz1yYf for ; Sat, 6 Apr 2024 23:39:41 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hqtla3DFp0sNeQYxH/PQL82CMdHlvliegXFLD/lpBU8=; b=mDNuEXPLjrSKlc vvbrR2jIJx/yXI4j1cOXegiGR7QIFoBh3wvBdJpW5RTL7bIY0W38YA7oL/ZCZxjqHz6fhBx+qCEap laNw0UPMKvPQ+fgKJeFUwJHaf9KmbuREqkcCuJ70IQjqdhJM7uuEUG0ijD5HeSoRV75LMjHo5uKGP 3u1tsct1uNRFburN9N6/HDT0kBsasW4xnyN5R0ezB2So80SPzxVPN4dBumZhFkt0PEDiwsa6IERDM 0GeK2MQV28ei+sWlzbYArYD7gtTB+LoDmVFM0dv5l+NNvTeuc43mM4UtPKAO+OrAEh9nY/7ZVm7t+ tpAFqdCnvbq1fisSAqvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5Kd-0000000AIEJ-4Bkq; Sat, 06 Apr 2024 12:39:40 +0000 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5Ka-0000000AICx-1hny for kvm-riscv@lists.infradead.org; Sat, 06 Apr 2024 12:39:38 +0000 Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-5dcc4076c13so2103474a12.0 for ; Sat, 06 Apr 2024 05:39:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712407176; x=1713011976; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ctDYQgLStioQbOFeEtouOSGyQc9IUR3PlFjjsp3HZ2Q=; b=NNVFhLcjtwIQRlZ0jv8WMdPzPJc2pPssDLKEc7bi7KCHRBRt0u0S5uZ6nP+Rz63t1z TY/9NgI2ObtMFfKWHgHo7PNRZ3hiLEjaOSFDmIzYND59Fs/2bGSdRtYC4E4E/azZnJMx /Dd3BH+57a7PQA1QzAX1bkOW3GNT5Qt8yMuxzuHdAz4l2APXvsnJxbIdAlp9g+5uzM9u aSaoj/Kl9Rz7Spi0Hw8OeQ9iuKDfFAc98TTZnkgm30gnNY+3VFruB2dio8ULLp/QAyIM bv5rWYLAZ0jGyfHGMKT3cyyZb/rtRm0JMVI7f9mavexQZ03JGP9Fu1DDSAAhXtq2cTY6 YMdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712407176; x=1713011976; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ctDYQgLStioQbOFeEtouOSGyQc9IUR3PlFjjsp3HZ2Q=; b=OIgAe90pZwQyDazvAMC2BPtDkd7F7ymFCZ0myYN66mwE3jmHZREZY6raG01w4Lyicl 6Afx/uwnkhQrjxP2sE3ZwqxhMZeRr3A183JRqXS17ikA+8nfSihuTCjsU2fNTwgXaWtU jQb9FFO4Rk5PTP5npAspek1IIJ6893a5DjcI9dvZL68u1lytUApjUHIC+P+p4UW98h3b i8zbsUpocTqMsBvWzwOjqt2i7yl/ryCdU79UkqwxRVPlds1D/tSXrf+elU1WUKpCvMyU TI+/ilk5WCQ7U4Vf8dH/tcUWzalbRxo4F9Kvl2s2XCVvIvlWNOJQsY9BTj9se8YZ0yz2 VndA== X-Forwarded-Encrypted: i=1; AJvYcCW+leyT2C9Otjg1TDDqIT/5aE7atwWw6SUNSfecr+kOfKm3jxhUUi3DQScTfvbXXoXvfDdk9LSYQ2mi5ZGV8O1VHFGjQhgKZ8Kq+KMi0w== X-Gm-Message-State: AOJu0YzZSL7Js8T6IrCt/cu1ZpNbgjuvnvqNtJypyUlDRs9dwarICqT4 f1ezF76aslL8EqCtMnzP+tqDv6kiIhpaz4hQm4YRtI2W/+dB/xmu X-Google-Smtp-Source: AGHT+IFubLHuw+tn9P2k0qkE0L7n1y54S4hs/qXXktspKqdJ/DtIjqspW0ZznPjBc8pACbaNSoegBA== X-Received: by 2002:a17:90a:1109:b0:2a3:846:6a45 with SMTP id d9-20020a17090a110900b002a308466a45mr6611290pja.5.1712407175820; Sat, 06 Apr 2024 05:39:35 -0700 (PDT) Received: from wheely.local0.net (124-169-104-130.tpgi.com.au. [124.169.104.130]) by smtp.gmail.com with ESMTPSA id nt5-20020a17090b248500b002a279a86e7asm5050576pjb.7.2024.04.06.05.39.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 05:39:35 -0700 (PDT) From: Nicholas Piggin To: Andrew Jones Cc: Nicholas Piggin , Paolo Bonzini , Thomas Huth , Alexandru Elisei , Eric Auger , Janosch Frank , Claudio Imbrenda , =?utf-8?q?Nico_B=C3=B6hr?= , David Hildenbrand , Shaoqin Huang , Nikos Nikoleris , David Woodhouse , Ricardo Koller , rminmin , Gavin Shan , Nina Schoetterl-Glausch , Sean Christopherson , kvm@vger.kernel.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: [RFC kvm-unit-tests PATCH v2 05/14] shellcheck: Fix SC2006 Date: Sat, 6 Apr 2024 22:38:14 +1000 Message-ID: <20240406123833.406488-6-npiggin@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240406123833.406488-1-npiggin@gmail.com> References: <20240406123833.406488-1-npiggin@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240406_053936_470859_E7426025 X-CRM114-Status: GOOD ( 10.24 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: SC2006 (style): Use $(...) notation instead of legacy backticks `...`. No bug identified. Reviewed-by: Andrew Jones Signed-off-by: Nicholas Piggin --- scripts/arch-run.bash | 6 +++--- scripts/runtime.bash | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:536 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [npiggin(at)gmail.com] X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org SC2006 (style): Use $(...) notation instead of legacy backticks `...`. No bug identified. Reviewed-by: Andrew Jones Signed-off-by: Nicholas Piggin --- scripts/arch-run.bash | 6 +++--- scripts/runtime.bash | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash index 472c31b08..f9d1fade9 100644 --- a/scripts/arch-run.bash +++ b/scripts/arch-run.bash @@ -271,16 +271,16 @@ do_migration () qmp ${src_qmp} '"migrate", "arguments": { "uri": "unix:'${dst_incoming}'" }' > ${src_qmpout} # Wait for the migration to complete - migstatus=`qmp ${src_qmp} '"query-migrate"' | grep return` + migstatus=$(qmp ${src_qmp} '"query-migrate"' | grep return) while ! grep -q '"completed"' <<<"$migstatus" ; do sleep 0.1 - if ! migstatus=`qmp ${src_qmp} '"query-migrate"'`; then + if ! migstatus=$(qmp ${src_qmp} '"query-migrate"'); then echo "ERROR: Querying migration state failed." >&2 echo > ${dst_infifo} qmp ${dst_qmp} '"quit"'> ${dst_qmpout} 2>/dev/null return 2 fi - migstatus=`grep return <<<"$migstatus"` + migstatus=$(grep return <<<"$migstatus") if grep -q '"failed"' <<<"$migstatus"; then echo "ERROR: Migration failed." >&2 echo > ${dst_infifo} diff --git a/scripts/runtime.bash b/scripts/runtime.bash index 2d7ff5baa..f79c4e281 100644 --- a/scripts/runtime.bash +++ b/scripts/runtime.bash @@ -61,9 +61,9 @@ function print_result() local reason="$4" if [ -z "$reason" ]; then - echo "`$status` $testname $summary" + echo "$($status) $testname $summary" else - echo "`$status` $testname ($reason)" + echo "$($status) $testname ($reason)" fi } From patchwork Sat Apr 6 12:38:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 1920407 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=feYgupvT; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=EKvEg/6Z; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VBZgT10xqz1yYf for ; Sat, 6 Apr 2024 23:39:49 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b6mrKJ7X9ehLYD0jL9umHaxzvw+8hcIncCG4RJRP1zI=; b=feYgupvTv1c2xb KCLMNgnPTSVrJAOtD8AWGJcqkYed1gTz8g71CtUfZ2BvCeECt1H0wFSaPx9LhqbU0ujPzgpjjUqzn YMccVWgXQCFLcpmmg0wYHGrjK2jo9sC9is5V72Fpmnpop+khbJz+U+f7K/CozXnWPTEr3j7SAJdWc zlEnSDOAOkdYdXmJGIVCyGUOWWd48c1O102ay7XFlmtQreknzmMkQLEQT519weqME4LM70wxPZnTv QRyU4OAuBsQIrEIgdeWd3bVrOYJ+2ECV6SupBr8JPttDoMI2iMTJ0JB127hEuJdlv3IuhsWXgWTFQ H2a7xnGvqovuh6ZNijlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5Kl-0000000AIGi-2tgR; Sat, 06 Apr 2024 12:39:47 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5Kj-0000000AIGL-3uMc for kvm-riscv@lists.infradead.org; Sat, 06 Apr 2024 12:39:47 +0000 Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-2a3095907ffso1177114a91.0 for ; Sat, 06 Apr 2024 05:39:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712407185; x=1713011985; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Qaba2L6x2dAj5DcBCo5KTsqOGBkhqsWqRrfdlHR5ju4=; b=EKvEg/6ZU8c4REk5kjqJOOQI/Jz/tNLqqVLAWJRofXqOG9Lh1+mMBcd0chn3izHfQ3 8BE6RpPQR4m8l4x9fSdCNvS5rLrR3OdlIikn8M8TQ51i1mr7HFeBwKU3wwuMra1V/RKb ZAui5dYUsiC1wDj/eXw7rw1HEZssruZ54aNq1VgrJm0h/HX/EicKd73q3lNobm1Mbx1H coPv8DIiBi4XGdZb/p1Jl/39jvv989mE8K/aJs/mXvKzUHg5970Pdd3iSnrOFcM2U5D7 mn3Bsa9aOEPmh0enZFqNrfQSe0Ql4CymqTkDrU2ZUM3UizCaPecKxN4oH3sk6CcmUZAu GmIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712407185; x=1713011985; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qaba2L6x2dAj5DcBCo5KTsqOGBkhqsWqRrfdlHR5ju4=; b=YTTaY2r4u+Mz9NukR8Nzy6v5MbnXnXGvBmpcowYdyJ2WauLaJPixoYL0xqzX0oVba5 HSq74Omc3nLcTl1aKEGeVXMaYojHXjbXyP/y/l7lGHpXsL1uEaKtQ36hNL0krbotYv9w cojRd82deAZO2p5O6bFokgxb24FGW5DROLCB8hJBOxF3rasdP5zQfMKhVxp2UsZNLkI2 JS9m1vvkUWwExGAveiznZLzd+e991A3JA/6UykvKfvw9+wcJvi3vHg4rdYMvrO83Irrd T3KBHuhN6JQOg38+k/hH6lnMapfRVX4yLKIbv8zwut411zZevGzFEoaAzsfBzcaAkRXo UXAQ== X-Forwarded-Encrypted: i=1; AJvYcCUSg8B04DKizknW7Vp1ufo5zIAZV7g/9nKDlTUMxbsXyL8hnh5Cec2mT4kEqM9GXHf3nYcSdTexqZos+qZ4V27S1rRxtGrtxei32C/VhQ== X-Gm-Message-State: AOJu0YzbsQaLPERQAFEyLy6doyANqqXrMxf5eaXY/rRYj2PPJzuAHlxV HQngaRZZ9IouLI/BmhdV6SB1h1PIUKTBzsbw4zN0DBmTJ++iguCY X-Google-Smtp-Source: AGHT+IHtQqbCWjek/Kw7U/EWKBnTW/ETkzN7lWi05EYkEgh8HEshJ8MsbtIGm3+uuLIyM0NGEw3xzQ== X-Received: by 2002:a17:90b:1254:b0:2a2:d4bd:d5db with SMTP id gx20-20020a17090b125400b002a2d4bdd5dbmr2957629pjb.49.1712407184811; Sat, 06 Apr 2024 05:39:44 -0700 (PDT) Received: from wheely.local0.net (124-169-104-130.tpgi.com.au. [124.169.104.130]) by smtp.gmail.com with ESMTPSA id nt5-20020a17090b248500b002a279a86e7asm5050576pjb.7.2024.04.06.05.39.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 05:39:44 -0700 (PDT) From: Nicholas Piggin To: Andrew Jones Cc: Nicholas Piggin , Paolo Bonzini , Thomas Huth , Alexandru Elisei , Eric Auger , Janosch Frank , Claudio Imbrenda , =?utf-8?q?Nico_B=C3=B6hr?= , David Hildenbrand , Shaoqin Huang , Nikos Nikoleris , David Woodhouse , Ricardo Koller , rminmin , Gavin Shan , Nina Schoetterl-Glausch , Sean Christopherson , kvm@vger.kernel.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: [RFC kvm-unit-tests PATCH v2 06/14] shellcheck: Fix SC2155 Date: Sat, 6 Apr 2024 22:38:15 +1000 Message-ID: <20240406123833.406488-7-npiggin@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240406123833.406488-1-npiggin@gmail.com> References: <20240406123833.406488-1-npiggin@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240406_053945_988785_7378B847 X-CRM114-Status: UNSURE ( 9.97 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: SC2155 (warning): Declare and assign separately to avoid masking return values. No bug identified. Reviewed-by: Andrew Jones Signed-off-by: Nicholas Piggin --- scripts/arch-run.bash | 10 +++++++--- scripts/runtime.bash | 4 +++- 2 files changed, 10 insertions(+), 4 deletions(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:102b listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [npiggin(at)gmail.com] X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org SC2155 (warning): Declare and assign separately to avoid masking return values. No bug identified. Reviewed-by: Andrew Jones Signed-off-by: Nicholas Piggin --- scripts/arch-run.bash | 10 +++++++--- scripts/runtime.bash | 4 +++- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash index f9d1fade9..ae4b06679 100644 --- a/scripts/arch-run.bash +++ b/scripts/arch-run.bash @@ -411,7 +411,8 @@ initrd_cleanup () { rm -f $KVM_UNIT_TESTS_ENV if [ "$KVM_UNIT_TESTS_ENV_OLD" ]; then - export KVM_UNIT_TESTS_ENV="$KVM_UNIT_TESTS_ENV_OLD" + export KVM_UNIT_TESTS_ENV + KVM_UNIT_TESTS_ENV="$KVM_UNIT_TESTS_ENV_OLD" else unset KVM_UNIT_TESTS_ENV fi @@ -423,7 +424,8 @@ initrd_create () if [ "$ENVIRON_DEFAULT" = "yes" ]; then trap_exit_push 'initrd_cleanup' [ -f "$KVM_UNIT_TESTS_ENV" ] && export KVM_UNIT_TESTS_ENV_OLD="$KVM_UNIT_TESTS_ENV" - export KVM_UNIT_TESTS_ENV=$(mktemp) + export KVM_UNIT_TESTS_ENV + KVM_UNIT_TESTS_ENV=$(mktemp) env_params env_file env_errata || return $? @@ -566,7 +568,9 @@ env_generate_errata () trap_exit_push () { - local old_exit=$(trap -p EXIT | sed "s/^[^']*'//;s/'[^']*$//") + local old_exit + + old_exit=$(trap -p EXIT | sed "s/^[^']*'//;s/'[^']*$//") trap -- "$1; $old_exit" EXIT } diff --git a/scripts/runtime.bash b/scripts/runtime.bash index f79c4e281..3b76aec9e 100644 --- a/scripts/runtime.bash +++ b/scripts/runtime.bash @@ -15,7 +15,9 @@ extract_summary() # We assume that QEMU is going to work if it tried to load the kernel premature_failure() { - local log="$(eval "$(get_cmdline _NO_FILE_4Uhere_)" 2>&1)" + local log + + log="$(eval "$(get_cmdline _NO_FILE_4Uhere_)" 2>&1)" echo "$log" | grep "_NO_FILE_4Uhere_" | grep -q -e "[Cc]ould not \(load\|open\) kernel" \ From patchwork Sat Apr 6 12:38:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 1920408 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=me9e+EQ1; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=Xa6IjZzn; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VBZgg0QBGz1yYf for ; Sat, 6 Apr 2024 23:39:59 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=97u4q4VCfyiRT0Gm6isOLePpWk3MtuNHrs0wK7D3uQU=; b=me9e+EQ1PnX55n Cl1En6b8k/CvCwXhQ0nfhb5M1faOBfIzVRlbYEUsaer5yYZMY7Z7Mo8y9EYYvICuodPbNA5tO44NH v0L17GiarZxSh8Fc5p5F1lYaFaRdEp1Rfv5qRrxg9wUD1OThF5dG93ZJmfiL81fWaDIhQU2SIfA5f 5qXu77e0wQzuayla2iaP3m9Fem2UpRuQkRH9bLT1hJF56YMJL6wj6aim10BBjz/1wdgh61zKPpg9y NZ+J2HNvGMbFWunutqqd6w2WEs4zHm9oOzbfI9uXWINZWRnorL+sivrSTAfYAxdeIiK3m5fF6ylOo /PYZ75jINyK3IsgBO48g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5Kv-0000000AIJw-3ADd; Sat, 06 Apr 2024 12:39:57 +0000 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5Kt-0000000AII1-10wr for kvm-riscv@lists.infradead.org; Sat, 06 Apr 2024 12:39:56 +0000 Received: by mail-pg1-x531.google.com with SMTP id 41be03b00d2f7-5cddc5455aeso2240622a12.1 for ; Sat, 06 Apr 2024 05:39:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712407194; x=1713011994; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8Amd09WCoNGafmrfuk2tT2hw4+gKyq5hmdDwUgtaokg=; b=Xa6IjZzn4hMjxwDWJAH22NMXVriivzLuBareeyeTVSCWGsO9bE4vKcCFQctSW57wLg +JlqgDGHE8KBARL1yGimEV/ZhSs4dKc/jyK2at+asz+IswA4y/CR8wLQosUrbCIyjPgK MyHaSiHdpIRgsTm3D6Xgsio6btQeN4GgC2lWPtfOaqq1Wwn/NuW7oR03e/BUq+0LZtkh 0ckjfHIS/KqqulHjx+uD4xEUx5qzA4fKhyxhUXbbpLbvzc8XUgj0OchXsvWunExe2U1k IF+TXk5ws4k4tuGn7uwE+8HeyKXRNlZyqv1ilWO1dy8EL9I7BzZFMuLbCs6skWz7HZSC VHBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712407194; x=1713011994; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8Amd09WCoNGafmrfuk2tT2hw4+gKyq5hmdDwUgtaokg=; b=hJlSed0LRJWS9WeTvjk4eHM6S4cocQWVKV2Oq9/iCInruR9CramXSxVsjjv6jze9xy bxAABBUd/eghpDRkbJcPniqFNacPQiCE1EuDpuT8ipsFhxM9reYazlKVMx1MMPoxKiEG 0/jnvugp59w8bbc+Yb3Ka2pFFQkfcn3VOepMC4C3d5UHyIsirPhlHYTzbKN/qTeRiuFg aXYi7G1XasYMG7s7Ro1p0X8XTAaXRomiPu6+a7FkmCuvwtZ+dUaA0MELUVHnQXtREbKT 3c1hjPcVJUYpbKsywiAGJ7pYxV1G159WbiMPZ4o1IY7k8ILy8g4PD8c/bY7E6PxmOFX3 0Xaw== X-Forwarded-Encrypted: i=1; AJvYcCXqT+YB8WrSSyyuruZoJ/pwHegTkgYlm++yyvWYS9dx5FE30HA+FM9mnIcetZjrW/vuMI3EZwP8MGntx/9IbhwQtfUzkicHev0peRUGyg== X-Gm-Message-State: AOJu0YwhxK0ynh5f51SCsr4cCNpou4kUU1Kzzh37jcw9Tq9F17jDxuK/ IBhA9ByriXvaM1RIW8sKQKjhwzTIbTVUsxWoBkr9crHJPe0MVdBc X-Google-Smtp-Source: AGHT+IGZi4czmCZZqDl75or3p6dCfsMOJaFJfy8Q9bSre2VzGKWSZ+VsWeTYQuMIiFbE4hVRMt9PTQ== X-Received: by 2002:a05:6a20:c90c:b0:1a3:ae18:f1e4 with SMTP id gx12-20020a056a20c90c00b001a3ae18f1e4mr3511345pzb.34.1712407193831; Sat, 06 Apr 2024 05:39:53 -0700 (PDT) Received: from wheely.local0.net (124-169-104-130.tpgi.com.au. [124.169.104.130]) by smtp.gmail.com with ESMTPSA id nt5-20020a17090b248500b002a279a86e7asm5050576pjb.7.2024.04.06.05.39.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 05:39:53 -0700 (PDT) From: Nicholas Piggin To: Andrew Jones Cc: Nicholas Piggin , Paolo Bonzini , Thomas Huth , Alexandru Elisei , Eric Auger , Janosch Frank , Claudio Imbrenda , =?utf-8?q?Nico_B=C3=B6hr?= , David Hildenbrand , Shaoqin Huang , Nikos Nikoleris , David Woodhouse , Ricardo Koller , rminmin , Gavin Shan , Nina Schoetterl-Glausch , Sean Christopherson , kvm@vger.kernel.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: [RFC kvm-unit-tests PATCH v2 07/14] shellcheck: Fix SC2143 Date: Sat, 6 Apr 2024 22:38:16 +1000 Message-ID: <20240406123833.406488-8-npiggin@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240406123833.406488-1-npiggin@gmail.com> References: <20240406123833.406488-1-npiggin@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240406_053955_322772_298D9C00 X-CRM114-Status: UNSURE ( 8.26 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: SC2143 (style): Use ! grep -q instead of comparing output with [ -z .. ]. Not a bug. Reviewed-by: Andrew Jones Signed-off-by: Nicholas Piggin --- scripts/arch-run.bash | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:531 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [npiggin(at)gmail.com] X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org SC2143 (style): Use ! grep -q instead of comparing output with [ -z .. ]. Not a bug. Reviewed-by: Andrew Jones Signed-off-by: Nicholas Piggin --- scripts/arch-run.bash | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash index ae4b06679..cd75405c8 100644 --- a/scripts/arch-run.bash +++ b/scripts/arch-run.bash @@ -61,7 +61,11 @@ run_qemu () # Even when ret==1 (unittest success) if we also got stderr # logs, then we assume a QEMU failure. Otherwise we translate # status of 1 to 0 (SUCCESS) - if [ -z "$(echo "$errors" | grep -vi warning)" ]; then + if [ "$errors" ]; then + if ! grep -qvi warning <<<"$errors" ; then + ret=0 + fi + else ret=0 fi fi From patchwork Sat Apr 6 12:38:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 1920409 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=G0MUNoQb; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=aZx7b1W3; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VBZgp66L3z1yYt for ; Sat, 6 Apr 2024 23:40:06 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Gn+JJkcmBaO43UMqMIo4XUDfp5YERXcOldi4TzuGXKc=; b=G0MUNoQbCqNkpp wZHk1HJEDDejdvo+q2EdYVHo5iJeEtwS2++VqC5f78sGZVDVhjdkonosc+LpdrFNvok4aC5YgKKid rWT8Tty1Z+ugeR8rm/UaISavHwUFfAfeFCwF1Xz1TKoGY3RV6bXPH5z9gZ/CpNjEEf/+8jlWRIfVf +L5en4EfXvoiAnwDW26mLWatIKD2KKjv72vW64LqyLvONXasCedloBpZYTjwno2mUNw7CQQPG0Rdi 5TmGuel/KzdILavHpau56y4OqkB/s4EuIc41+qyGTM8nAaCG2Gtvubw5ouCMuXzkC86R4vOBGkJiu d03QdV1UGfUnM/7Drm5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5L3-0000000AIN0-2dMh; Sat, 06 Apr 2024 12:40:05 +0000 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5L1-0000000AIMT-2PB0 for kvm-riscv@lists.infradead.org; Sat, 06 Apr 2024 12:40:04 +0000 Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-6ecee1f325bso2540940b3a.2 for ; Sat, 06 Apr 2024 05:40:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712407202; x=1713012002; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jc9Ns5Gs4d6EQrXAeFAipEGyYWBXJXNznus1Vgd5gEY=; b=aZx7b1W3U6GV65Gs5WQZcmPn8r8EkV+UHWjk6FUQ7mOYIXu3KTVBMxClqdNrCM+xoE pJtzBhvNG8JBosuHGyjJW1w0kI2yeQgmWeQc+P7HwAvOlRtUOmt4hi+QmJjYJECVx0O5 r9mmJSRIYUtmqfrgo96HfmDo+Cf7ICacEH6ZeqRVJgVBgOZNYhJHtVeuBN1lWQG0Qity gHe8Pav02zoNYr96cwxPPojpMpTFKspDWDEsa0O4PcCe1xZZ7XeBVAAJQCCWa0WjI2AM xIH447guHXzIwCuIWMJwUtQ72jiS3XuHkM8YW30XzqqZ/GRWXJb5lWtBsNmOcVbYgec6 rpJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712407202; x=1713012002; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jc9Ns5Gs4d6EQrXAeFAipEGyYWBXJXNznus1Vgd5gEY=; b=uK8NZER120IR3RgRo3sQVmWCwEKd765TzqAAUW3ybqohek4stPx6b1bPVgL0KERFOs xUni7oeRg9BewtwXbQ5eXoAWuiuj0dQW61obVjDVO8MYEv/C1gwiuGPO3FYGiQMWx3GQ Msew8lKNJ5e65Jo+ELfDZ4z0xq8+Om5ERWQhWY4jpJu+g2fKKP+OlrGVgBe49040HKk/ XcHOBWFxrxzNJAr5Y6VNyb6nrNWNjJHmiNIg/Th+p7yfWbH/J7dwY5mhXYEdsS0MKOoY qGeEvWTqwbwzhgcjC9nK63JgvBQp7r0HVR1nPEY4oukWzBXtnPzj5U8CXNVe4M5Zhc+x M8sg== X-Forwarded-Encrypted: i=1; AJvYcCXP+yh/2xr9UwKHQxtNTRDPSecPt5ram3Ffi74nuGi+RE14hfRBN0s68IQ0OaTo1N7mp55bNcBkCd1MY8KPAXfeUPFJ5V0LKYxQ71T1oA== X-Gm-Message-State: AOJu0YzbT/cMCTj9SEYKAUPbpHcDT9QoghNcPlXOJ/OD3Xb2daMzinfR TakLv1WtANyVPePIZGhGsKVBh1Qdhov9DSdgG+MEjkSrghbh0sIK X-Google-Smtp-Source: AGHT+IGFqwzSPVPQ9YT3jplB+7wqnHfvH8TCbOoaXrxURWMaPygGn8PVC/qsnNpJzSZ+kKAlRUuDBA== X-Received: by 2002:a05:6a20:12ca:b0:1a7:c63:add2 with SMTP id v10-20020a056a2012ca00b001a70c63add2mr5190444pzg.10.1712407202215; Sat, 06 Apr 2024 05:40:02 -0700 (PDT) Received: from wheely.local0.net (124-169-104-130.tpgi.com.au. [124.169.104.130]) by smtp.gmail.com with ESMTPSA id nt5-20020a17090b248500b002a279a86e7asm5050576pjb.7.2024.04.06.05.39.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 05:40:01 -0700 (PDT) From: Nicholas Piggin To: Andrew Jones Cc: Nicholas Piggin , Paolo Bonzini , Thomas Huth , Alexandru Elisei , Eric Auger , Janosch Frank , Claudio Imbrenda , =?utf-8?q?Nico_B=C3=B6hr?= , David Hildenbrand , Shaoqin Huang , Nikos Nikoleris , David Woodhouse , Ricardo Koller , rminmin , Gavin Shan , Nina Schoetterl-Glausch , Sean Christopherson , kvm@vger.kernel.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: [RFC kvm-unit-tests PATCH v2 08/14] shellcheck: Fix SC2013 Date: Sat, 6 Apr 2024 22:38:17 +1000 Message-ID: <20240406123833.406488-9-npiggin@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240406123833.406488-1-npiggin@gmail.com> References: <20240406123833.406488-1-npiggin@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240406_054003_636889_1073A9C7 X-CRM114-Status: UNSURE ( 9.56 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: SC2013 (info): To read lines rather than words, pipe/redirect to a 'while read' loop. Not a bug. Signed-off-by: Nicholas Piggin --- scripts/arch-run.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:433 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [npiggin(at)gmail.com] X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org SC2013 (info): To read lines rather than words, pipe/redirect to a 'while read' loop. Not a bug. Signed-off-by: Nicholas Piggin Reviewed-by: Andrew Jones --- scripts/arch-run.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash index cd75405c8..45ec8f57d 100644 --- a/scripts/arch-run.bash +++ b/scripts/arch-run.bash @@ -487,7 +487,7 @@ env_file () [ ! -f "$KVM_UNIT_TESTS_ENV_OLD" ] && return - for line in $(grep -E '^[[:blank:]]*[[:alpha:]_][[:alnum:]_]*=' "$KVM_UNIT_TESTS_ENV_OLD"); do + grep -E '^[[:blank:]]*[[:alpha:]_][[:alnum:]_]*=' "$KVM_UNIT_TESTS_ENV_OLD" | while IFS= read -r line ; do var=${line%%=*} if ! grep -q "^$var=" $KVM_UNIT_TESTS_ENV; then eval export "$line" From patchwork Sat Apr 6 12:38:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 1920410 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=DJP0C6S9; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=GYLECG9Y; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VBZh24zYLz1yYt for ; Sat, 6 Apr 2024 23:40:18 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b+J7ZSpfmtjKfRxFTNZ/sH7xmR0lyuT/gJFB7FdDEK0=; b=DJP0C6S93MEXps 2h/2Dp1Hzr1iWmvgWyzESWrzDqdBVHHNttipEXdzD+u60nqIcw3KRVUDelMmb2R5qGtkozLXxpTGZ 4nf09KYUPiE9Q9IwbUuOG9lFvongWoXroeNcx46Hbl7d6DnLGWFgaFD1CYwK4qKN0Xmt/BQInK9wE CssBfo22dC4RUMsnIzxkDz8ExZlhVZVX14BHPdLC3LLxa/WJ5tQuH6h1/fc2V12OF+Ygdk6sN7O8v 7Ohijnsdq8G/cCWvVBcdonmKahEXKc/gIosmNfLuD5yX8Iaw1obzjjuqxnfdbK1nMrsDca2/A3zp2 IYPiQUvkzgQDZcG76v0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5LF-0000000AIRF-1hin; Sat, 06 Apr 2024 12:40:17 +0000 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5LB-0000000AIPG-49fl for kvm-riscv@lists.infradead.org; Sat, 06 Apr 2024 12:40:15 +0000 Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-5cf2d73a183so2923895a12.1 for ; Sat, 06 Apr 2024 05:40:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712407211; x=1713012011; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+DuXv8jLymFAc3dj84mPa+u6v5joW+GUy7CVoN0Mom8=; b=GYLECG9Y0xZvsYgx7rK4gV2tlOOu+SSZ3JCrkP8bSpfUMScXja4R91euKiCx1yqF54 tE7d9dwg7C+b+Ojw5wUU//7jDyiDVag7bzcuSCDHy3Ml+Yy/CPoHVQEdH1Ho+vsycTwC IEGCTv3dSYDi8fLqQlZw9u2fVjOsvMOoiRAmSeuWon8A8QleOtvlZUAaZTlg+3g2mT/1 +hyMS/9xdtDLFbuLSKf9j7wI7mC+OHxENCFL2BUkvj1TU0kUG/RaHs05PZKqTiCHhRKS /ggKEdgPPkua2M3apw2oiTn9asCHDRoI1QMrgGnwUxKEB0A7C9baJBbJl37rdsebRAxm E1AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712407211; x=1713012011; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+DuXv8jLymFAc3dj84mPa+u6v5joW+GUy7CVoN0Mom8=; b=E7FyFAmX5yILohtgphGLhExis00Qdky8imKSzQuNFbh8OCE5PMpa0vJehlfFJeCzb1 cIamXzDmvSVM13yD2xsLKmVoRnonN4d/CD6yTfcvgbOZ/8fgREScf0XCuwSzr5elDK12 V1CUMix6SJsFjZ6fSAHPVxhdiExJBUTjvQK9mAhyEqvTN6Ds90iA1h9bbKDrtS1qqQXq 9Hh756pdVeS5HsGAuCUmOBtudWT/fzFhpdIZLqYZXVuGC9yEzcCI1nSqPSKfYYG+XRS6 xXIKfz8isLeGSZsh7F6uJ9eexYzEevf3W/Y+bsl46mqWHSUyfEPdJFNJrf/UKvqaJvKE spdQ== X-Forwarded-Encrypted: i=1; AJvYcCXDK9mX/ptK0F9XZ2Nn4dyTL9yDOpZx3tWvqW4411YdN7SVbTgT7ohvTpd04sl2zdeoydSAsPVS5k3u4p3Ykhm7Zvm2hlFAAbGzFwEwCA== X-Gm-Message-State: AOJu0YyFo2996vBHrnF54wFySsbsZ0BOtdobCSJyGmHPEkU2jd8O/mJL dVQ49ij7CamRNdJaBFDzidkPkBpH2ZQY0BxieFTV8ivaafU1rkaa X-Google-Smtp-Source: AGHT+IEG5DwuJ6rWhrJoMat7kd4rj//Ns4BzAmacd0b/2q33I7gOlOkW3W7COJMdw+lJbq3lxrimmg== X-Received: by 2002:a17:90b:1b04:b0:2a0:4a82:5b05 with SMTP id nu4-20020a17090b1b0400b002a04a825b05mr7263902pjb.19.1712407210832; Sat, 06 Apr 2024 05:40:10 -0700 (PDT) Received: from wheely.local0.net (124-169-104-130.tpgi.com.au. [124.169.104.130]) by smtp.gmail.com with ESMTPSA id nt5-20020a17090b248500b002a279a86e7asm5050576pjb.7.2024.04.06.05.40.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 05:40:10 -0700 (PDT) From: Nicholas Piggin To: Andrew Jones Cc: Nicholas Piggin , Paolo Bonzini , Thomas Huth , Alexandru Elisei , Eric Auger , Janosch Frank , Claudio Imbrenda , =?utf-8?q?Nico_B=C3=B6hr?= , David Hildenbrand , Shaoqin Huang , Nikos Nikoleris , David Woodhouse , Ricardo Koller , rminmin , Gavin Shan , Nina Schoetterl-Glausch , Sean Christopherson , kvm@vger.kernel.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: [RFC kvm-unit-tests PATCH v2 09/14] shellcheck: Fix SC2145 Date: Sat, 6 Apr 2024 22:38:18 +1000 Message-ID: <20240406123833.406488-10-npiggin@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240406123833.406488-1-npiggin@gmail.com> References: <20240406123833.406488-1-npiggin@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240406_054014_121680_693250DF X-CRM114-Status: UNSURE ( 9.34 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: SC2145 (error): Argument mixes string and array. Use * or separate argument. Shouldn't be a bug, since the preceding string ends with a space and there aren't any succeeding strings. Reviewed-by: Andrew Jones Signed-off-by: Nicholas Piggin --- arm/efi/run | 2 +- riscv/efi/run | 2 +- scripts/mkstandalone.sh | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:52b listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [npiggin(at)gmail.com] X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org SC2145 (error): Argument mixes string and array. Use * or separate argument. Shouldn't be a bug, since the preceding string ends with a space and there aren't any succeeding strings. Reviewed-by: Andrew Jones Signed-off-by: Nicholas Piggin --- arm/efi/run | 2 +- riscv/efi/run | 2 +- scripts/mkstandalone.sh | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arm/efi/run b/arm/efi/run index f07a6e55c..cf6d34b0b 100755 --- a/arm/efi/run +++ b/arm/efi/run @@ -87,7 +87,7 @@ uefi_shell_run() if [ "$EFI_DIRECT" = "y" ]; then $TEST_DIR/run \ $KERNEL_NAME \ - -append "$(basename $KERNEL_NAME) ${cmd_args[@]}" \ + -append "$(basename $KERNEL_NAME) ${cmd_args[*]}" \ -bios "$EFI_UEFI" \ "${qemu_args[@]}" else diff --git a/riscv/efi/run b/riscv/efi/run index 982b8b9c4..cce068694 100755 --- a/riscv/efi/run +++ b/riscv/efi/run @@ -97,7 +97,7 @@ if [ "$EFI_DIRECT" = "y" ]; then fi $TEST_DIR/run \ $KERNEL_NAME \ - -append "$(basename $KERNEL_NAME) ${cmd_args[@]}" \ + -append "$(basename $KERNEL_NAME) ${cmd_args[*]}" \ -machine pflash0=pflash0 \ -blockdev node-name=pflash0,driver=file,read-only=on,filename="$EFI_UEFI" \ "${qemu_args[@]}" diff --git a/scripts/mkstandalone.sh b/scripts/mkstandalone.sh index 86c7e5498..756647f29 100755 --- a/scripts/mkstandalone.sh +++ b/scripts/mkstandalone.sh @@ -76,7 +76,7 @@ generate_test () cat scripts/runtime.bash - echo "run ${args[@]}" + echo "run ${args[*]}" } function mkstandalone() From patchwork Sat Apr 6 12:38:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 1920411 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=hjBlX85k; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=dpQZxpUi; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VBZh84WRtz1yYt for ; Sat, 6 Apr 2024 23:40:24 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M+94PNC7N2N2NgR0KqnipK59Yhmh7uIL+O0ctwQuQnU=; b=hjBlX85kNvxru8 3nxDNDRb5PAVOlBDJIgEcxEuZJq0hU2ICv0+NHqcs+S4E/04LS+1NKU116WvdguwU0Wf9FJqSZa2L 5rdSV54kF8wGDpiHYCgP9ZM9fnZ1wH02MnKPsa+EknBJogO/0DD1cz6pYiTennT/tktAEVjgXUEbL bDvG7+Nrvik/5XYxoCGCV9BPCd0r3iegiNplwDrxw7QiMyt6iGk1Qqbb4VfBing8pHwAjR3gat8Yr jiverlmWFi9TPXw0Uu+Dvtsi0yAra0w/ZpsjgN0Hh5N5zlyJMLXpl0DZ2kJTO09qIbVkUb5aEaiOZ aAr7AjZYCSjKTnGVVcVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5LL-0000000AITw-0UJZ; Sat, 06 Apr 2024 12:40:23 +0000 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5LJ-0000000AISW-05Oo for kvm-riscv@lists.infradead.org; Sat, 06 Apr 2024 12:40:22 +0000 Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-2a476fd8d21so971488a91.2 for ; Sat, 06 Apr 2024 05:40:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712407220; x=1713012020; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CWoWbY1l8dnEVRR/nSiK5WHJ8+U9imW08rrrMnGNnqQ=; b=dpQZxpUi582u/E5S8qmgrmampBdk7i0d7fANSdZtzAMGcITVjjOmrg6m7ZIP300/Z/ k1bKPVYzsjsPzruleVpXhroHh1pRmMzYMk+eKf/pAg9xsLDEdIRT0kkT7aBsVWUgbD2g d+glwyKpcd+/c3vI9GU7dDEb5t97SQm5Y9DjAbSO2kak7mJPiG7zeNexEIie/otfka1E 48xRWoHJYTNTC7lp1aq0yBmIcM8pYzd0KRa3fiYex0cNwFNkUZpn+GLNpLUoFc1BGUXx dS+GcwtHVyeRp48YvTlzSoDqOrpmP43s8QAhLzWl5UIgBL77RQIeI4ZLluwxp+iiYSgo rY+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712407220; x=1713012020; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CWoWbY1l8dnEVRR/nSiK5WHJ8+U9imW08rrrMnGNnqQ=; b=Qxunlg+HtwpKrouEvi4MpBH+el4AuvOF2pXnMhPCiW9kk3rK2PpeZQzgEYncp9v2Rf 6xMK0FS5NBw4M1z8oEOxY06ZAz+NfDSBzDhenZtKITKHWg2qmNEO0McHGBASsuC33VDw cKKU32l0yqv2StTkk6vn+JpO8qZUJpokvsysIZvTxv+mE4evAJNljF3M1AMRT68XykMC nQsWS2GWNi/qcmT8KxpzG8PWz2CDnfchm+BkJc7BUlrRWZyJzVy2oWbV8egix1XMIYm3 BCS4pnASvwN85gvvqz/k37MnOWgtqa2WD5cvsp16s8Uor5XhKl1e8ur1OpQkT96FuJmZ S4rg== X-Forwarded-Encrypted: i=1; AJvYcCWV3ZtdCQDGacuWOvxev+zh7m+THmGSB7y705wvXZA18X9CyGZFW3b88KCXXIaD0jf4Nie8KU73bKKy829RroZKOjcJ4VfVBZfBmUFK6w== X-Gm-Message-State: AOJu0YwNTblqMCPY0qnIqtlkaw/BN6vCnTkLD7waH5WkyvHjGNv6lIFr xskmLNiu1TSxelhciunpbgGQ8OHHYI/9dE91JitTbQV3AnfxDPNC X-Google-Smtp-Source: AGHT+IFHZE4Fp2p4OLXDHn3qLZhQ0/SVNeTRqByuHLNxp4zQxBJuEy3e052DXS99usoJooGncv3JtA== X-Received: by 2002:a17:90a:c797:b0:29c:761e:3955 with SMTP id gn23-20020a17090ac79700b0029c761e3955mr3301807pjb.17.1712407219870; Sat, 06 Apr 2024 05:40:19 -0700 (PDT) Received: from wheely.local0.net (124-169-104-130.tpgi.com.au. [124.169.104.130]) by smtp.gmail.com with ESMTPSA id nt5-20020a17090b248500b002a279a86e7asm5050576pjb.7.2024.04.06.05.40.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 05:40:19 -0700 (PDT) From: Nicholas Piggin To: Andrew Jones Cc: Nicholas Piggin , Paolo Bonzini , Thomas Huth , Alexandru Elisei , Eric Auger , Janosch Frank , Claudio Imbrenda , =?utf-8?q?Nico_B=C3=B6hr?= , David Hildenbrand , Shaoqin Huang , Nikos Nikoleris , David Woodhouse , Ricardo Koller , rminmin , Gavin Shan , Nina Schoetterl-Glausch , Sean Christopherson , kvm@vger.kernel.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: [RFC kvm-unit-tests PATCH v2 10/14] shellcheck: Fix SC2124 Date: Sat, 6 Apr 2024 22:38:19 +1000 Message-ID: <20240406123833.406488-11-npiggin@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240406123833.406488-1-npiggin@gmail.com> References: <20240406123833.406488-1-npiggin@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240406_054021_098562_8AC04111 X-CRM114-Status: UNSURE ( 9.81 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: SC2124 (warning): Assigning an array to a string! Assign as array, or use * instead of @ to concatenate. Shouldn't be a bug since bash concatenates with space and eval is used on the result. Reviewed-by: Andrew Jones Signed-off-by: Nicholas Piggin --- scripts/arch-run.bash | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:1032 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [npiggin(at)gmail.com] X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org SC2124 (warning): Assigning an array to a string! Assign as array, or use * instead of @ to concatenate. Shouldn't be a bug since bash concatenates with space and eval is used on the result. Reviewed-by: Andrew Jones Signed-off-by: Nicholas Piggin --- scripts/arch-run.bash | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash index 45ec8f57d..95b6fa64d 100644 --- a/scripts/arch-run.bash +++ b/scripts/arch-run.bash @@ -150,7 +150,7 @@ run_migration () return 77 fi - migcmdline=$@ + migcmdline=("$@") trap 'trap - TERM ; kill 0 ; exit 2' INT TERM trap 'rm -f ${src_out} ${dst_out} ${src_outfifo} ${dst_outfifo} ${dst_incoming} ${src_qmp} ${dst_qmp} ${src_infifo} ${dst_infifo}' RETURN EXIT @@ -179,7 +179,7 @@ run_migration () exec {src_infifo_fd}<>${src_infifo} exec {dst_infifo_fd}<>${dst_infifo} - eval "$migcmdline" \ + eval "${migcmdline[@]}" \ -chardev socket,id=mon,path=${src_qmp},server=on,wait=off \ -mon chardev=mon,mode=control \ < ${src_infifo} > ${src_outfifo} & @@ -219,7 +219,7 @@ run_migration () do_migration () { - eval "$migcmdline" \ + eval "${migcmdline[@]}" \ -chardev socket,id=mon,path=${dst_qmp},server=on,wait=off \ -mon chardev=mon,mode=control -incoming unix:${dst_incoming} \ < ${dst_infifo} > ${dst_outfifo} & From patchwork Sat Apr 6 12:38:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 1920412 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=fPwHk98y; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=KQGFFlNg; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VBZhK17Qbz1yYt for ; Sat, 6 Apr 2024 23:40:33 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0yApG7pZCF0AUBguW2YmMrBNgrcL36WyHa1366NF6Xo=; b=fPwHk98y6zfv6P PIZH3mmSyNfCFvn5XbdFl9lR9kfZarJwjpV7L12c+OEFLDcfjC5ObwDCn5nupq0dlOxCxtUIPBfSN pCN9DxirC3O8ON23t0tU7om2q9qy0xJQ9fwRUGm5tN3T9hFdLgCXhvmg1Uw+EY8FENhfH3CCbTWnm A3pP1R8pq3a00MOFA4DZYOj8mA6S27iqbsmGGzG+Zup4GAjTktD7lJT0U2z1GJTy/TCFsDFcAyMw7 BT/5OsI3jx7VD7VRFeZzBJCkyLw8/+tapSY4wkNW9Efnel+BVQRazD0ZadeeAozoR9Pj5Pm5OvX1d Ptb+PPNKV1qs/y4OcnCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5LT-0000000AIWn-3kg5; Sat, 06 Apr 2024 12:40:31 +0000 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5LQ-0000000AIW6-3djt for kvm-riscv@lists.infradead.org; Sat, 06 Apr 2024 12:40:30 +0000 Received: by mail-pj1-x102a.google.com with SMTP id 98e67ed59e1d1-2a2d248a2e1so1921988a91.0 for ; Sat, 06 Apr 2024 05:40:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712407228; x=1713012028; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DtN3qRr/BJ5ghrfuBVmkjt4OGFVHY6H/GotGGIKP5Pw=; b=KQGFFlNgYrWOyoLfCVLCEcNNveChVxvjpVBsDlj67LR802SlThrHydMUMGJYxz6Zhb AMES5SED+YAm2FrjPfxQ1X0rhA6Y3IMfZsQRZxPQwZ0e5vQzKwvRRIMo+EG3nIW7eqhR UQdtsY70UQV0zZxuaOozkLXXfFMj5JYJ6fkjfSOpieg4F9+2sY5sIKKPtkTVYq3Av91I s7NQz4sWlQpZF61t3R0bA3KLJQXTgiaolFgecPtpC9ZHnfuX/B59yIJ3yTyJLke+P33+ 6xhnOyGGupBvHV6IyVNZZa46mT+Zc4sDIohC9hXKw5pC7cCq0gKBGB0555DMRmzEDf/V KJ+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712407228; x=1713012028; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DtN3qRr/BJ5ghrfuBVmkjt4OGFVHY6H/GotGGIKP5Pw=; b=XUoJy/nYObP1C0xjFD+jy/6qpybyuah8CfbExeAOl6g0kzJ4/bF894UDH9yHHKJWEZ Xk5gz6KxcJAWmkl10PMT06ZYM1RNHti0QY+TBLp7Eu4YW7KHRciVZvFPwJgx8FIVfeJz O7TPgqVeWcJaDQltHEezjtru5I9N2nt2p2C9F3I7PXox3+VvrjvapKYQTGROxfY8EIQV f8NVVXxQPONY/IuH97CqTNrqypVKHRn6gL0P0KeiqjjIoEXniwurVO2CG0FZBh66SZxz jxhiJhMfZSk5wkIoUrhMV226g6HsAK9B9y+7vddQUX1tMN/TMeJDMIV26zid+oRg5Thl FM+g== X-Forwarded-Encrypted: i=1; AJvYcCVG9h3Ag6itwcjByVZTC9OrtMKJYR8AVVapValpfTYLoa9enmsQxtAJzV+ZxIephF1KhmMsrW8OFREBdonydMWrkmfn4b8SvhbPxI+Z2Q== X-Gm-Message-State: AOJu0YxRyD/Un++e8KMQ5y7zd/jnBIlItyvmvXoEDXawdSt9Snde3nVx J3lIcWMHcLBHAF4A5tglD/Fr8EgBOVswq/tLYI91y/cMLcChqT8S X-Google-Smtp-Source: AGHT+IE7xfGD09MIaUCfQ0PlF2nHZILjJWkZ4PfKwm4uXDYYCAtdwhtHcBBozUYIc7FVTGi7mIF6mw== X-Received: by 2002:a17:90a:4e06:b0:2a2:c812:9648 with SMTP id n6-20020a17090a4e0600b002a2c8129648mr6948766pjh.9.1712407228261; Sat, 06 Apr 2024 05:40:28 -0700 (PDT) Received: from wheely.local0.net (124-169-104-130.tpgi.com.au. [124.169.104.130]) by smtp.gmail.com with ESMTPSA id nt5-20020a17090b248500b002a279a86e7asm5050576pjb.7.2024.04.06.05.40.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 05:40:28 -0700 (PDT) From: Nicholas Piggin To: Andrew Jones Cc: Nicholas Piggin , Paolo Bonzini , Thomas Huth , Alexandru Elisei , Eric Auger , Janosch Frank , Claudio Imbrenda , =?utf-8?q?Nico_B=C3=B6hr?= , David Hildenbrand , Shaoqin Huang , Nikos Nikoleris , David Woodhouse , Ricardo Koller , rminmin , Gavin Shan , Nina Schoetterl-Glausch , Sean Christopherson , kvm@vger.kernel.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: [RFC kvm-unit-tests PATCH v2 11/14] shellcheck: Fix SC2294 Date: Sat, 6 Apr 2024 22:38:20 +1000 Message-ID: <20240406123833.406488-12-npiggin@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240406123833.406488-1-npiggin@gmail.com> References: <20240406123833.406488-1-npiggin@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240406_054028_935373_81EA681C X-CRM114-Status: UNSURE ( 8.46 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: SC2294 (warning): eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string). No bug identified. Reviewed-by: Andrew Jones Signed-off-by: Nicholas Piggin --- scripts/arch-run.bash | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:102a listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [npiggin(at)gmail.com] X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org SC2294 (warning): eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string). No bug identified. Reviewed-by: Andrew Jones Signed-off-by: Nicholas Piggin --- scripts/arch-run.bash | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash index 95b6fa64d..98d29b671 100644 --- a/scripts/arch-run.bash +++ b/scripts/arch-run.bash @@ -179,7 +179,7 @@ run_migration () exec {src_infifo_fd}<>${src_infifo} exec {dst_infifo_fd}<>${dst_infifo} - eval "${migcmdline[@]}" \ + "${migcmdline[@]}" \ -chardev socket,id=mon,path=${src_qmp},server=on,wait=off \ -mon chardev=mon,mode=control \ < ${src_infifo} > ${src_outfifo} & @@ -219,7 +219,7 @@ run_migration () do_migration () { - eval "${migcmdline[@]}" \ + "${migcmdline[@]}" \ -chardev socket,id=mon,path=${dst_qmp},server=on,wait=off \ -mon chardev=mon,mode=control -incoming unix:${dst_incoming} \ < ${dst_infifo} > ${dst_outfifo} & @@ -357,7 +357,7 @@ run_panic () qmp=$(mktemp -u -t panic-qmp.XXXXXXXXXX) # start VM stopped so we don't miss any events - eval "$@" -chardev socket,id=mon,path=${qmp},server=on,wait=off \ + "$@" -chardev socket,id=mon,path=${qmp},server=on,wait=off \ -mon chardev=mon,mode=control -S & panic_event_count=$(qmp_events ${qmp} | jq -c 'select(.event == "GUEST_PANICKED")' | wc -l) From patchwork Sat Apr 6 12:38:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 1920413 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=EaDGIe1+; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=LHG5mBUO; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VBZhV100nz1yYt for ; Sat, 6 Apr 2024 23:40:42 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QJqJRM62cFbLFXdywYzt3KR9c/xazA6P5K1P09VIP20=; b=EaDGIe1+H0F5ov N8BRkqWYyzasDOvzOsSepmuhb0nNX7GCT4fcrLXKgBqm9eiioepWOBWjR0HaHU9L3ifbNrPrigXAb Ihnqo6geZXOeaP0bjySKeFMHRFS663+JD37nZmYGz0Sp6oTPldTlzlEkgxIvMBPU0TAHE3KYU3LaB y5mZLBZMkHWKaferT4PijFiNZWVq2FmVLCWk5235rvb9+iDmlxEDnT/xSsv8tVlYzhypHg2waa8Qg QgLUlW+a6bOvneu/7kjyh03nN1AukOlo9GHpcx3voAOK9TWpR/HV4jW0VR1VwjFBmY/QP/pMvf15r 3TNfxPzikVvenA55ZKGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5Lc-0000000AIZn-3TCL; Sat, 06 Apr 2024 12:40:40 +0000 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5La-0000000AIYj-25k7 for kvm-riscv@lists.infradead.org; Sat, 06 Apr 2024 12:40:39 +0000 Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-5cedfc32250so2416960a12.0 for ; Sat, 06 Apr 2024 05:40:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712407238; x=1713012038; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2eRtFguiVvn3b4AxH0QU+OXVRgeLtifhqAQZ/pJYpnQ=; b=LHG5mBUOn1Mjut3bPhK7+s7PgH6lGWQYGXciM5hdtcKN0nK+HrCXt2fDhQ/1YzzU3W 0TOu0BacqY3Vv3HBbxSK2QPkU87S2gC14V1SnGqwYb0PAMtMuqIi6XSKAjK9fczCfAhB taekdbH0HF+SwvY7jkFqRa7kG7sKc054whmZCfGCythWtLdwaa2fvjCCncUdG8ZzMVjT ISOraCFBl7h9YZTdzAu8yFlEmwWQbprs/GA+DV+xn9pC8XLxZdJGh7naLcj7aWta90Y9 wF16AQLfyXNNotVOFKatCRKTupe9dla62QKgTVqjlbysAqwGJvXmKMTb29PhhueirgPW FURA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712407238; x=1713012038; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2eRtFguiVvn3b4AxH0QU+OXVRgeLtifhqAQZ/pJYpnQ=; b=e6GGaLcM7YCaAS8IR/Nph7PZI3nechYdRp1/5NrzK0+TkOgg5TLVEQYo1uuRBCrRC+ i5BwqFzNrB6+n2E6iELqlNxvBxIlK8IzPXr8TjNzXRU8llcuU7Cj8GdLjyCQW0yNrdbk OBjIneUGW4Iq4VX0p/hU4+b/vSS1yIkgV9M4bzgP911hVgJ0vqG4fCoR8mm14MhlVaLV 7qBuTHyJGcdklWn9FB+2ItBcoHX3ovlThZgsrkZTzYI3Fl8uHSRy79l3ORlwHsaCpEsO Xs4+VA3NmHmpYIcCvaSXFNN/VJBBzNiSlaLSDwoTNeOdS6XnMctsHUr16b3mkw0lh8Op 30jg== X-Forwarded-Encrypted: i=1; AJvYcCUmtPOk7bZhNw4VQNUxxcZcuLbQVIAkcYArneEiFqOSkg1htc5obNzZZNRdq4llCXCbB26lgwsw/6ps06AM7+x/8GPenejZnnRIWEJojw== X-Gm-Message-State: AOJu0YzHUYM3l/Wk3zOtB4OSWQ/VWgWvf2HepA7AblxBqvbpxpPp9jSr KLbzgBtGqGW0yZ+K72pVL8W+jMbDLqG2fV5pUQGL74GYpSHpFhF7 X-Google-Smtp-Source: AGHT+IFRwkbTF8lHFVWUWdHITKOoyi+cM/zQNImgd0YNfpYQL2AebNpOitSBxxkyLMi56+NDz70TCQ== X-Received: by 2002:a05:6a20:1587:b0:1a3:9fa6:74f6 with SMTP id h7-20020a056a20158700b001a39fa674f6mr4468400pzj.58.1712407237671; Sat, 06 Apr 2024 05:40:37 -0700 (PDT) Received: from wheely.local0.net (124-169-104-130.tpgi.com.au. [124.169.104.130]) by smtp.gmail.com with ESMTPSA id nt5-20020a17090b248500b002a279a86e7asm5050576pjb.7.2024.04.06.05.40.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 05:40:37 -0700 (PDT) From: Nicholas Piggin To: Andrew Jones Cc: Nicholas Piggin , Paolo Bonzini , Thomas Huth , Alexandru Elisei , Eric Auger , Janosch Frank , Claudio Imbrenda , =?utf-8?q?Nico_B=C3=B6hr?= , David Hildenbrand , Shaoqin Huang , Nikos Nikoleris , David Woodhouse , Ricardo Koller , rminmin , Gavin Shan , Nina Schoetterl-Glausch , Sean Christopherson , kvm@vger.kernel.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: [RFC kvm-unit-tests PATCH v2 12/14] shellcheck: Fix SC2178 Date: Sat, 6 Apr 2024 22:38:21 +1000 Message-ID: <20240406123833.406488-13-npiggin@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240406123833.406488-1-npiggin@gmail.com> References: <20240406123833.406488-1-npiggin@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240406_054038_583467_55770E25 X-CRM114-Status: UNSURE ( 9.52 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: SC2178 (warning): Variable was used as an array but is now assigned a string. No bug identified. Reviewed-by: Andrew Jones Signed-off-by: Nicholas Piggin --- arm/efi/run | 2 +- riscv/efi/run | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:52b listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [npiggin(at)gmail.com] X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org SC2178 (warning): Variable was used as an array but is now assigned a string. No bug identified. Reviewed-by: Andrew Jones Signed-off-by: Nicholas Piggin --- arm/efi/run | 2 +- riscv/efi/run | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arm/efi/run b/arm/efi/run index cf6d34b0b..8f41fc02d 100755 --- a/arm/efi/run +++ b/arm/efi/run @@ -44,7 +44,7 @@ qemu_args=() cmd_args=() while (( "$#" )); do if [ "$1" = "-append" ]; then - cmd_args=$2 + cmd_args=("$2") shift 2 else qemu_args+=("$1") diff --git a/riscv/efi/run b/riscv/efi/run index cce068694..5a72683a6 100755 --- a/riscv/efi/run +++ b/riscv/efi/run @@ -47,7 +47,7 @@ qemu_args=() cmd_args=() while (( "$#" )); do if [ "$1" = "-append" ]; then - cmd_args=$2 + cmd_args=("$2") shift 2 else qemu_args+=("$1") From patchwork Sat Apr 6 12:38:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 1920414 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=BA/6vm2Z; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=NVftls/b; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VBZhg5j2fz1yYt for ; Sat, 6 Apr 2024 23:40:51 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UpUYbaNW46+GcojF5oRQxDyX+76Ev9Cs9sc///osgP0=; b=BA/6vm2ZYq0j34 jpUYRnCB2VkfBX1Rwh2vYEJujoDQKj01fRT7pmULpFwpUBdZ9LG9k6cNIqM5+h6+raIyNGh6AID0d iSa+94kgp9AxFVOj+/Gj1Pt7r6COe2faJwu92SSYYMhWuNqEXTct8GINCa6hx146Mh3Y8yE6kZTse 5H8E16SaZu6AFNmDktivyBvbMezlhEdQP6e8QLbrPWbbOfy5DQgFezz/06NkemW8ier27dljL5GDu NmqVhzfp5yZKE9mH6YCCPIXr6b5G5ctZfbvU/DyMShiuwAgmoYWHQ3VTPXzjELYXxE5di8df7ZFA3 dpfhy5yATyXFTIeElqOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5Lm-0000000AIbw-2AlQ; Sat, 06 Apr 2024 12:40:50 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5Lj-0000000AIbO-2e6Y for kvm-riscv@lists.infradead.org; Sat, 06 Apr 2024 12:40:48 +0000 Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-2a2474f2595so2433454a91.1 for ; Sat, 06 Apr 2024 05:40:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712407246; x=1713012046; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=74FZsPss0kwxe9NqMeWaPReIQrTUACvwkEx+kD2VIoc=; b=NVftls/bhZM7NhI7Pgs8qE0vTvKIyLNEpJgNc6lJS3DyEL8kH1vWO+KgapqCt0IsPk 8oZXwOZUQlOeC6+M8ulLg5WUqAhMF0AjmcctkrgAM2UEFPeACxbxCcXjoLpqyNoS2Pwy sz2g5V8T8+zhnkA5+RavZ6ISCyyPy+GoAf0BDmJCdYiw3jSnpwpuVSyK1D7EgGYc23GW K89Gl6zsSR5efyE9gz/spcUg1r6eMb0lhh3fDpyMw6hsnqsCO7vf0Dmf1BB+xu1+icqR 9foyjTASIJX6rmPzylob/MJdPvtH/Do7QydExzB9GeqafrDpgDzVt+MVTnq43zC5rTkY g8pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712407246; x=1713012046; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=74FZsPss0kwxe9NqMeWaPReIQrTUACvwkEx+kD2VIoc=; b=Tg3UZb9a9Ygs3OAwUBfNDapr894T66RVnL9GxZ4HAYTCqDytgYx6tiN8Xo3n8mZXm7 NuYyaeXD3F8iSVyi7RgOaakHWPxRPou1RGMXMl6hhglXPCWr/UbM9958w7moox4V9t8T vabvSzpVtxY31RRJ8faAv6JPkImIqkZVt/uT8Wt0aRb+ojSAu54FDRa3XWKE97CKlkqP 6wm1cK8zgDxl8he5OUwirqiPqKJ5NKhBtL3bjS1D/bfqbC+1Ppm1wnAXg9wYzqrysvpM cUe3+DKElsfwj1/txg3VdhlEI1h8oOq+jXpfvl/H9IRNFrNFhW4XM0ZooCX6h5u3btLw k7og== X-Forwarded-Encrypted: i=1; AJvYcCV0nQjl7TQ7Qp49fk8JrJHKZcc0+aP+W9q6Gp3VHSfn4nx0a1J5PoQjRVtIoo3rhL2h2+4ZtKZThII1SI23/OpDgG06bi0TswPrwFH5gA== X-Gm-Message-State: AOJu0YxC3udWaiEs9+f/dn2y7ezVuKaE2noiMZ2otqCPxalbamCFuXVI LasaO7iZ9WgVC4pDcZ+L+Ta+U6uPf6YvYMU99pW+Z88C+Kg32CGy X-Google-Smtp-Source: AGHT+IFgZyVM/wV4gHHTUtKzy2GaH8FYxLa20w79AVDB9o0mSig7OeFOhEaU4CW5c0EVv67nDh4oMA== X-Received: by 2002:a17:90a:eb0f:b0:2a2:53a5:7559 with SMTP id j15-20020a17090aeb0f00b002a253a57559mr3815747pjz.38.1712407246165; Sat, 06 Apr 2024 05:40:46 -0700 (PDT) Received: from wheely.local0.net (124-169-104-130.tpgi.com.au. [124.169.104.130]) by smtp.gmail.com with ESMTPSA id nt5-20020a17090b248500b002a279a86e7asm5050576pjb.7.2024.04.06.05.40.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 05:40:45 -0700 (PDT) From: Nicholas Piggin To: Andrew Jones Cc: Nicholas Piggin , Paolo Bonzini , Thomas Huth , Alexandru Elisei , Eric Auger , Janosch Frank , Claudio Imbrenda , =?utf-8?q?Nico_B=C3=B6hr?= , David Hildenbrand , Shaoqin Huang , Nikos Nikoleris , David Woodhouse , Ricardo Koller , rminmin , Gavin Shan , Nina Schoetterl-Glausch , Sean Christopherson , kvm@vger.kernel.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: [RFC kvm-unit-tests PATCH v2 13/14] shellcheck: Fix SC2048 Date: Sat, 6 Apr 2024 22:38:22 +1000 Message-ID: <20240406123833.406488-14-npiggin@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240406123833.406488-1-npiggin@gmail.com> References: <20240406123833.406488-1-npiggin@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240406_054047_696567_0253D8B7 X-CRM114-Status: UNSURE ( 8.68 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: SC2048 (warning): Use "$@" (with quotes) to prevent whitespace problems. No bug identified. Reviewed-by: Andrew Jones Signed-off-by: Nicholas Piggin --- run_tests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:1029 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [npiggin(at)gmail.com] X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org SC2048 (warning): Use "$@" (with quotes) to prevent whitespace problems. No bug identified. Reviewed-by: Andrew Jones Signed-off-by: Nicholas Piggin --- run_tests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/run_tests.sh b/run_tests.sh index 116188e92..938bb8edf 100755 --- a/run_tests.sh +++ b/run_tests.sh @@ -44,7 +44,7 @@ fi only_tests="" list_tests="" -args=$(getopt -u -o ag:htj:vl -l all,group:,help,tap13,parallel:,verbose,list,probe-maxsmp -- $*) +args=$(getopt -u -o ag:htj:vl -l all,group:,help,tap13,parallel:,verbose,list,probe-maxsmp -- "$@") [ $? -ne 0 ] && exit 2; set -- $args; while [ $# -gt 0 ]; do From patchwork Sat Apr 6 12:38:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 1920415 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=G2tjYYvs; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=Ic/eZPDr; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VBZhq1w0Pz1yYt for ; Sat, 6 Apr 2024 23:40:59 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Yrw+bKxym/NzogV441RqmR7nRidtUhw2JSaFTCd3aZg=; b=G2tjYYvsVE/e3t rvvhtYBKPsQw69mCoZ1ber0ESiK0QoYCqtYcktS8gMDiug7m3MQiM6FHLkXzQBi5oz9jLhF8vj43l xQUy2Bc8FpHfFeT2JaunVoYOKiSFsoqVJ1mGqY0ZE/OQgSFwfqcFdN4Mtb5wXA3w3NAINlwWm/Qjm S8hb1XcXRCqgwPFTFnw7JQqanJ2Qh4m2iva4pRM43jrsCJgUWvBcgiW9FAu6eDcQKJ+8gvqKSu92+ MNOZajIDqvP0v8OKRG3KkooperMjx2lGrce46EAyNBzAxBlpf5JvmeByS6ffoNG7H13vBjQ3CyIMs uAvWs5IFpbw7D2SveiaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5Lu-0000000AIed-0Cbl; Sat, 06 Apr 2024 12:40:58 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5Lr-0000000AIdS-1Cgj for kvm-riscv@lists.infradead.org; Sat, 06 Apr 2024 12:40:56 +0000 Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-29ddfada0d0so2184780a91.3 for ; Sat, 06 Apr 2024 05:40:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712407255; x=1713012055; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TKbzy8znHr26CvO7hMQVAmzLED6LumWRP6wamBTxOWo=; b=Ic/eZPDrVG5QWcG6AfevzOHtzJrKh1UlgOoH3j+J5BWYMvSqQpRFQf7uWrOJN6/wuR UlrN0TK8yPJWFxE7b4R+WdWMcXNggS2C66yw+txvLOSZWORYhs3HXZG5UCj4V01j4UIU C7VPde+9czk6VDwoxPtLfEUvIM5bs+pIGnvXWvQx4VfLhAPwvSdxmGDYh6BWC/b2BF9P KdUqVW1MP6z+XId3KJeYzxKerOyWQYdFftL3xPzKjuwtHAkggdjQxZezN3aZvjHIWlG8 R12q7mXawYs86TPpBHOpfOXxo9e8qXnbsCZd+Elj/SCBXLrKCm7eqtkLXr2cVFr7KMjP OAaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712407255; x=1713012055; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TKbzy8znHr26CvO7hMQVAmzLED6LumWRP6wamBTxOWo=; b=PE3/BEtlXnZS4Q0jHKUcvbvQnkoYNrn3wp/YTIdKVPIdoyJhaS/sWfOMWm+HljOErI 0wJn+pMLGQcdQJfmF28PXkl0XuarNkVXMXxqa/CaB0u1V6wZV/5KMAdunCwRy6wFImBs 1P/bpYoeJjmGtJxdRtZIpF9t9/DuHlwJPKwXdoLKZHHyK8jZesXqPPQ2lDG1LaMyGV6V P4QTtXafL5rA6eFJer1hqDd1BveD9TSnBd7gamKe06vS+7OFOONg0QNxXFNz0CXsvpmj UEhn0xmtp7dk9e4mFnvRoHeB3Snyp0iflDL3Jd6Cil7helcsx8JUSX8ICOWJnyaMz03U LS8g== X-Forwarded-Encrypted: i=1; AJvYcCX8Z3D9EnxtYh0vNEDeav32XMClcutfEr6rVZlLdZAYp5eApNsnrSUJRRxdyLkp9XSoRVZQGq1XlBwZEvOekWeeVswmwFZzPGe/AJQlEw== X-Gm-Message-State: AOJu0YxusLEa1wirf/hbwyHv0vT7joJYDsiV6nWQITFfCmzicNzfH7CE cvPmWzobwj6ct9scnTK+ft7QBEZABOOwCtdeaVVP+j9x8vCz5I+X X-Google-Smtp-Source: AGHT+IGH923lILkg6k1D5LY3F7XHuUJem0umJ9lfWz87O3KBdX4fIyH0Pvbo4QqzZ+EqQUgQggrzMQ== X-Received: by 2002:a17:90b:118e:b0:29b:b6eb:3c0d with SMTP id gk14-20020a17090b118e00b0029bb6eb3c0dmr3754945pjb.36.1712407254690; Sat, 06 Apr 2024 05:40:54 -0700 (PDT) Received: from wheely.local0.net (124-169-104-130.tpgi.com.au. [124.169.104.130]) by smtp.gmail.com with ESMTPSA id nt5-20020a17090b248500b002a279a86e7asm5050576pjb.7.2024.04.06.05.40.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 05:40:54 -0700 (PDT) From: Nicholas Piggin To: Andrew Jones Cc: Nicholas Piggin , Paolo Bonzini , Thomas Huth , Alexandru Elisei , Eric Auger , Janosch Frank , Claudio Imbrenda , =?utf-8?q?Nico_B=C3=B6hr?= , David Hildenbrand , Shaoqin Huang , Nikos Nikoleris , David Woodhouse , Ricardo Koller , rminmin , Gavin Shan , Nina Schoetterl-Glausch , Sean Christopherson , kvm@vger.kernel.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: [RFC kvm-unit-tests PATCH v2 14/14] shellcheck: Suppress various messages Date: Sat, 6 Apr 2024 22:38:23 +1000 Message-ID: <20240406123833.406488-15-npiggin@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240406123833.406488-1-npiggin@gmail.com> References: <20240406123833.406488-1-npiggin@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240406_054055_350561_F40025B2 X-CRM114-Status: GOOD ( 13.64 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Various info and warnings are suppressed here, where circumstances (commented) warrant. Signed-off-by: Nicholas Piggin --- configure | 2 ++ run_tests.sh | 3 +++ scripts/arch-run.bash | 15 +++++++++++++++ scripts/mkstandalone.sh | 2 ++ scripts/runtime.bash | 2 ++ 5 files changed, 24 ins [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:1029 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [npiggin(at)gmail.com] X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Various info and warnings are suppressed here, where circumstances (commented) warrant. Signed-off-by: Nicholas Piggin Reviewed-by: Andrew Jones --- configure | 2 ++ run_tests.sh | 3 +++ scripts/arch-run.bash | 15 +++++++++++++++ scripts/mkstandalone.sh | 2 ++ scripts/runtime.bash | 2 ++ 5 files changed, 24 insertions(+) diff --git a/configure b/configure index 8508396af..6ebac7e0a 100755 --- a/configure +++ b/configure @@ -437,6 +437,8 @@ ln -sf "$asm" lib/asm # create the config cat < config.mak +# Shellcheck does not see these are used +# shellcheck disable=SC2034 SRCDIR=$srcdir PREFIX=$prefix HOST=$host diff --git a/run_tests.sh b/run_tests.sh index 938bb8edf..152323ffc 100755 --- a/run_tests.sh +++ b/run_tests.sh @@ -45,6 +45,9 @@ fi only_tests="" list_tests="" args=$(getopt -u -o ag:htj:vl -l all,group:,help,tap13,parallel:,verbose,list,probe-maxsmp -- "$@") +# Shellcheck likes to test commands directly rather than with $? but sometimes they +# are too long to put in the same test. +# shellcheck disable=SC2181 [ $? -ne 0 ] && exit 2; set -- $args; while [ $# -gt 0 ]; do diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash index 98d29b671..7e5b2bdf1 100644 --- a/scripts/arch-run.bash +++ b/scripts/arch-run.bash @@ -44,6 +44,8 @@ run_qemu () if [ "$errors" ]; then sig=$(grep 'terminating on signal' <<<"$errors") if [ "$sig" ]; then + # This is too complex for ${var/search/replace} + # shellcheck disable=SC2001 sig=$(sed 's/.*terminating on signal \([0-9][0-9]*\).*/\1/' <<<"$sig") fi fi @@ -174,9 +176,12 @@ run_migration () # Holding both ends of the input fifo open prevents opens from # blocking and readers getting EOF when a writer closes it. + # These fds appear to be unused to shellcheck so quieten the warning. mkfifo ${src_infifo} mkfifo ${dst_infifo} + # shellcheck disable=SC2034 exec {src_infifo_fd}<>${src_infifo} + # shellcheck disable=SC2034 exec {dst_infifo_fd}<>${dst_infifo} "${migcmdline[@]}" \ @@ -184,6 +189,9 @@ run_migration () -mon chardev=mon,mode=control \ < ${src_infifo} > ${src_outfifo} & live_pid=$! + # Shellcheck complains about useless cat but it is clearer than a + # redirect in this case. + # shellcheck disable=SC2002 cat ${src_outfifo} | tee ${src_out} | filter_quiet_msgs & # Start the first destination QEMU machine in advance of the test @@ -224,6 +232,9 @@ do_migration () -mon chardev=mon,mode=control -incoming unix:${dst_incoming} \ < ${dst_infifo} > ${dst_outfifo} & incoming_pid=$! + # Shellcheck complains about useless cat but it is clearer than a + # redirect in this case. + # shellcheck disable=SC2002 cat ${dst_outfifo} | tee ${dst_out} | filter_quiet_msgs & # The test must prompt the user to migrate, so wait for the @@ -467,6 +478,8 @@ env_params () [ -n "$ACCEL" ] && QEMU_ACCEL=$ACCEL fi QEMU_VERSION_STRING="$($qemu -h | head -1)" + # SC does not seee QEMU_MAJOR|MINOR|MICRO are used + # shellcheck disable=SC2034 IFS='[ .]' read -r _ _ _ QEMU_MAJOR QEMU_MINOR QEMU_MICRO rest <<<"$QEMU_VERSION_STRING" fi env_add_params QEMU_ACCEL QEMU_VERSION_STRING QEMU_MAJOR QEMU_MINOR QEMU_MICRO @@ -597,6 +610,8 @@ hvf_available () set_qemu_accelerator () { + # Shellcheck does not seee ACCEL_PROPS is used + # shellcheck disable=SC2034 ACCEL_PROPS=${ACCEL#"${ACCEL%%,*}"} ACCEL=${ACCEL%%,*} diff --git a/scripts/mkstandalone.sh b/scripts/mkstandalone.sh index 756647f29..2318a85f0 100755 --- a/scripts/mkstandalone.sh +++ b/scripts/mkstandalone.sh @@ -65,6 +65,8 @@ generate_test () fi temp_file bin "$kernel" + # Don't want to expand $bin but print it as-is. + # shellcheck disable=SC2016 args[3]='$bin' (echo "#!/usr/bin/env bash" diff --git a/scripts/runtime.bash b/scripts/runtime.bash index 3b76aec9e..6e712214d 100644 --- a/scripts/runtime.bash +++ b/scripts/runtime.bash @@ -137,6 +137,8 @@ function run() # the check line can contain multiple files to check separated by a space # but each check parameter needs to be of the form = if [ "$check" ]; then + # There is no globbing or whitespace allowed in check parameters. + # shellcheck disable=SC2206 check=($check) for check_param in "${check[@]}"; do path=${check_param%%=*}