From patchwork Thu Apr 4 08:05:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1919661 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=MOuDtsCJ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=aBZnacAn; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V9Dhh03j0z1yZH for ; Thu, 4 Apr 2024 19:06:12 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DD3C9385840A for ; Thu, 4 Apr 2024 08:06:09 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id ECD813858D34 for ; Thu, 4 Apr 2024 08:05:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ECD813858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ECD813858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712217948; cv=none; b=R00UrbCUxRzcbsQJQBSdizG1IOhLocMDo8QWdMzuIzT72EDA7/lJaokQJejRFyeBUhRUyByShpcfjvQvObA5JoaoHF6DngkbrfdydIHI2F3jzL9RRlImhoPjgd261OOaD8btVrkzgy8dSuwD4K40EKpHMSbuttaG9jQ5h3R5968= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712217948; c=relaxed/simple; bh=teGhM4Rcu6SVs4oqQtx5+wXHhzF1nAeMeQ3Knf2uSrs=; h=DKIM-Signature:DKIM-Signature:Date:From:To:Subject:MIME-Version; b=HYK1Q3vBZk/BEcQHyViPytQeGmMAuZrMgSJ+8kpiBmkkHdHpfAqU0RFEg14AeZi6ckKpi7lD73EcBEBbb0eiiFxY549TgNZjkUT2YIBbHSJb+4GaIexv2XtMUxzwuUc/mqvkFcpCkwrvhZxE9+9F4VlN+Tx4+lO/NV7RaxHTrSo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.5.241] (unknown [10.168.5.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E70E222BBF for ; Thu, 4 Apr 2024 08:05:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712217945; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=GUOLFFFRaZ6l4qohjL+WX4dZlR0gXAvWglhMDKtyMZg=; b=MOuDtsCJIIEkd/BCUic7qmvlaNkPjcJ2BqQ+XsGNyccgME7zP6s+dXi395mURPS5si5xFg gAhEwbN0Uj2rQpK9FK8TP1Kf+212HJqCKZx755SKFnYnlIuNsEX+KhfLi+hXOM1NFR0xNl 1ApgMg7B6IRywwUh1skVJRwlrhSpydc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712217945; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=GUOLFFFRaZ6l4qohjL+WX4dZlR0gXAvWglhMDKtyMZg=; b=aBZnacAnLKdY8l2NgVcXV1nTwvIfooZeJEzfy3O7IPtjWxOJMzEe12dP6QNTew+jRhW6+k KubVXy36658EzcDQ== Authentication-Results: smtp-out1.suse.de; none Date: Thu, 4 Apr 2024 10:05:45 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/114485 - neg induction with partial vectors MIME-Version: 1.0 X-Spam-Score: 5.09 X-Spamd-Result: default: False [5.09 / 50.00]; TO_DN_NONE(0.00)[]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-3.00)[100.00%]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_SPAM_SHORT(3.00)[1.000]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_ONE(0.00)[1]; MISSING_MID(2.50)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_SPAM_LONG(2.69)[0.768]; FUZZY_BLOCKED(0.00)[rspamd.com] X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Message-Id: <20240404080609.DD3C9385840A@sourceware.org> We can't use vect_update_ivs_after_vectorizer for partial vectors, the following fixes vect_can_peel_nonlinear_iv_p accordingly. Bootstrap and regtest running on x86_64-unknown-linux-gnu. We could handle this case by vectorizing the live lane but that's a different thing and might be tackled next stage1. PR tree-optimization/114485 * tree-vect-loop-manip.cc (vect_can_peel_nonlinear_iv_p): vect_step_op_neg isn't OK for partial vectors but only for unknown niter. * gcc.dg/vect/pr114485.c: New testcase. --- gcc/testsuite/gcc.dg/vect/pr114485.c | 18 ++++++++++++++++++ gcc/tree-vect-loop-manip.cc | 14 +++++++------- 2 files changed, 25 insertions(+), 7 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/vect/pr114485.c diff --git a/gcc/testsuite/gcc.dg/vect/pr114485.c b/gcc/testsuite/gcc.dg/vect/pr114485.c new file mode 100644 index 00000000000..6536806e350 --- /dev/null +++ b/gcc/testsuite/gcc.dg/vect/pr114485.c @@ -0,0 +1,18 @@ +#include "tree-vect.h" + +int b, c = 8, d; +int e[23]; +int main() +{ + check_vect (); + + int *h = e; + for (int i = 1; i < b + 21; i += 2) + { + c *= -1; + d = h[i] ? i : 0; + } + if (c != 8) + abort (); + return 0; +} diff --git a/gcc/tree-vect-loop-manip.cc b/gcc/tree-vect-loop-manip.cc index 56a6d8e4a8d..8d9b533d50f 100644 --- a/gcc/tree-vect-loop-manip.cc +++ b/gcc/tree-vect-loop-manip.cc @@ -2128,18 +2128,18 @@ vect_can_peel_nonlinear_iv_p (loop_vec_info loop_vinfo, For shift, when shift mount >= precision, there would be UD. For mult, don't known how to generate init_expr * pow (step, niters) for variable niters. - For neg, it should be ok, since niters of vectorized main loop + For neg unknown niters are ok, since niters of vectorized main loop will always be multiple of 2. - See also PR113163 and PR114196. */ - if ((!LOOP_VINFO_VECT_FACTOR (loop_vinfo).is_constant () - || LOOP_VINFO_USING_PARTIAL_VECTORS_P (loop_vinfo) - || !LOOP_VINFO_NITERS_KNOWN_P (loop_vinfo)) - && induction_type != vect_step_op_neg) + See also PR113163, PR114196 and PR114485. */ + if (!LOOP_VINFO_VECT_FACTOR (loop_vinfo).is_constant () + || LOOP_VINFO_USING_PARTIAL_VECTORS_P (loop_vinfo) + || (!LOOP_VINFO_NITERS_KNOWN_P (loop_vinfo) + && induction_type != vect_step_op_neg)) { if (dump_enabled_p ()) dump_printf_loc (MSG_MISSED_OPTIMIZATION, vect_location, "Peeling for epilogue is not supported" - " for nonlinear induction except neg" + " for this nonlinear induction" " when iteration count is unknown or" " when using partial vectorization.\n"); return false;