From patchwork Wed Mar 20 16:08:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 1914160 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=VG0XL2qQ; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V0D6K0zzkz1yWy for ; Thu, 21 Mar 2024 03:08:41 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2B0FE385803E for ; Wed, 20 Mar 2024 16:08:39 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A9E433858D1E for ; Wed, 20 Mar 2024 16:08:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A9E433858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A9E433858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710950899; cv=none; b=qIHo7XS6dVsRtcJyR0YANnWbGyKRuuPOUcI+uBeUmisgBStCEkTjT0TD0/YdTB4WJU3m5gwOb71rM8F68QFnEl30SJfIMmpaL+ci+QxyF36bawQFxWnL5PvxPb74QEr8527r1YgMlfUkuSLwD/n1RszdkdnsjSdw+mjSOK+3aLw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710950899; c=relaxed/simple; bh=a2lnAuKMwtKcN4kiAGhTjbhmfdjUsmSuyDA5I6moamg=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=lMv1lWd/JS/jpmtR7xjMa5Yd5FwJEgU7SThHWM4n1iyDx4X5p7E+SUuIxnmi1EM/NaCckasYtESAG06WagPSNmF2/bWvj5QnlLfqYnDh+Qhf/bZds2m+Mjcg7iDU+lSCZEnE1PQYAbFOpKHr5XrknnwmJu2hxWiCrUt/bCU8cFc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710950898; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type; bh=9P+rAOUoT/QS/QISkeA/cEA/k80RnHf2CocKtGb46cs=; b=VG0XL2qQz/J0F+zwN4F9evQnaUlKJ1S494TA1+zKtDF6yibWiyZeLJSBiYiXnj9epZndcT SyjGoyjhvDRqXaZe21HCYQPUgnn7ftQ4cLM6OP2zgKkU7Px8cjeBlqUQssFzZh8KHE3krw 28jj0fqUprpwNz/wWwF6g6OlzO7KkY4= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-113-2ZADbAv8PuOR60e8P8QIpQ-1; Wed, 20 Mar 2024 12:08:16 -0400 X-MC-Unique: 2ZADbAv8PuOR60e8P8QIpQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9F0B42802266 for ; Wed, 20 Mar 2024 16:08:16 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 620F210E47 for ; Wed, 20 Mar 2024 16:08:16 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 42KG8Ap71166369 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT) for ; Wed, 20 Mar 2024 17:08:10 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 42KG89kT1166368 for gcc-patches@gcc.gnu.org; Wed, 20 Mar 2024 17:08:09 +0100 Date: Wed, 20 Mar 2024 17:08:09 +0100 From: Jakub Jelinek To: gcc-patches@gcc.gnu.org Subject: [committed] visium: Fix up visium_setup_incoming_varargs [PR114175] Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Jakub Jelinek Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Hi! Like for x86-64, alpha or rs6000, visium seems to be affected too. Just visually checked differences in c23-stdarg-9.c assembly in a cross without/with the patch, committed to trunk. 2024-03-20 Jakub Jelinek PR target/114175 * config/visium/visium.cc (visium_setup_incoming_varargs): Only skip TARGET_FUNCTION_ARG_ADVANCE for TYPE_NO_NAMED_ARGS_STDARG_P functions if arg.type is NULL. Jakub --- gcc/config/visium/visium.cc.jj 2024-01-03 11:51:47.166514192 +0100 +++ gcc/config/visium/visium.cc 2024-03-20 16:14:51.613422079 +0100 @@ -1482,7 +1482,8 @@ visium_setup_incoming_varargs (cumulativ /* The caller has advanced ARGS_SO_FAR up to, but not beyond, the last named argument. Advance a local copy of ARGS_SO_FAR past the last "real" named argument, to find out how many registers are left over. */ - if (!TYPE_NO_NAMED_ARGS_STDARG_P (TREE_TYPE (current_function_decl))) + if (!TYPE_NO_NAMED_ARGS_STDARG_P (TREE_TYPE (current_function_decl)) + || arg.type != NULL_TREE) TARGET_FUNCTION_ARG_ADVANCE (local_args_so_far, arg); /* Find how many registers we need to save. */