From patchwork Mon Mar 11 22:25:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring (Arm)" X-Patchwork-Id: 1910760 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=AC32lBz1; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=147.75.199.223; helo=ny.mirrors.kernel.org; envelope-from=devicetree+bounces-49923-incoming-dt=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org [147.75.199.223]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TtrvW06SRz1yWn for ; Tue, 12 Mar 2024 09:25:42 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id CAE5B1C20D33 for ; Mon, 11 Mar 2024 22:25:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C61975786B; Mon, 11 Mar 2024 22:25:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AC32lBz1" X-Original-To: devicetree@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BA2D52F61; Mon, 11 Mar 2024 22:25:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710195933; cv=none; b=pyTRLUp/35zVrtmYtaOlJYnklcGARmokPCQYvt+Fm4NCQeXyRya67OEpSJNvni26DeG/qjFE5SM6liY6MxIkNWh7nkfYj3DPQJIWsFyE5AFFRO7b4UHBi7kINrnE9cf4/BQNuaxWqdNLFvtXqGjBiLwkwzxQWu6HqwDTI/w7k0k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710195933; c=relaxed/simple; bh=l0/IQ23QUrCfGWUZ/tXclmNM1YnM2HDLEAk057qvzkY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=OhTvHvK/PBczw9GSD/7CA3AIloOx+3PrARoB/FH6h11YkcE9Swc6UXzpjqXRRBEjRl9ADWcSgx3RSxy6BmATkIqDaK7VdcWAqeXofXDyCirA5ZQWAKrf9ZYlm7/ClrvcjurJn2rBx0+h/J8ecpRw3Y9/yXPCrZg70tnIVLBUsAE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AC32lBz1; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id D88B3C433C7; Mon, 11 Mar 2024 22:25:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710195933; bh=l0/IQ23QUrCfGWUZ/tXclmNM1YnM2HDLEAk057qvzkY=; h=From:To:Cc:Subject:Date:From; b=AC32lBz1enrvDOlWUdu4x8Sj92fX3lrFP/eEg4C0B6vE40bYfFWvIkBHHtFxmf1u7 ry06MtikeGL6PsNo6ZDyrun3wlZlRiPn3h8BmYuUsilBLqhJnFuVEAD3mWcLuZM1Y+ 57PyE+EJ0f1pfXVXgNjEKM6FQHYDXdw3ZqNV5GYV+nbeEzHIXLQJFv0K/YupiBm0HX DQY2RscCrehP4u68UgCX7mnNv9UQrhMvotY7ltZIL4eouZum+yYoHud/QIUJon0Rck JRhcJy3y4fQMNPgW94ojROzsUyehxG96c32gFs2zbBm1AOQAMbB+McS5QeLsHjbaGh BFT1BYwO9teOg== From: Rob Herring To: Viresh Kumar , Andy Shevchenko , Vinod Koul , Krzysztof Kozlowski , Conor Dooley Cc: dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] dt-bindings: dma: snps,dma-spear1340: Fix data{-,_}width schema Date: Mon, 11 Mar 2024 16:25:22 -0600 Message-ID: <20240311222522.1939951-1-robh@kernel.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 'data-width' and 'data_width' properties are defined as arrays, but the schema is defined as a matrix. That works currently since everything gets decoded in to matrices, but that is internal to dtschema and could change. Signed-off-by: Rob Herring Acked-by: Viresh Kumar Reviewed-by: Serge Semin --- .../bindings/dma/snps,dma-spear1340.yaml | 38 +++++++++---------- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/Documentation/devicetree/bindings/dma/snps,dma-spear1340.yaml b/Documentation/devicetree/bindings/dma/snps,dma-spear1340.yaml index 5da8291a7de0..7b0ff4afcaa1 100644 --- a/Documentation/devicetree/bindings/dma/snps,dma-spear1340.yaml +++ b/Documentation/devicetree/bindings/dma/snps,dma-spear1340.yaml @@ -93,10 +93,9 @@ properties: data-width: $ref: /schemas/types.yaml#/definitions/uint32-array description: Data bus width per each DMA master in bytes. + maxItems: 4 items: - maxItems: 4 - items: - enum: [4, 8, 16, 32] + enum: [4, 8, 16, 32] data_width: $ref: /schemas/types.yaml#/definitions/uint32-array @@ -106,28 +105,26 @@ properties: deprecated. It' usage is discouraged in favor of data-width one. Moreover the property incorrectly permits to define data-bus width of 8 and 16 bits, which is impossible in accordance with DW DMAC IP-core data book. + maxItems: 4 items: - maxItems: 4 - items: - enum: - - 0 # 8 bits - - 1 # 16 bits - - 2 # 32 bits - - 3 # 64 bits - - 4 # 128 bits - - 5 # 256 bits - default: 0 + enum: + - 0 # 8 bits + - 1 # 16 bits + - 2 # 32 bits + - 3 # 64 bits + - 4 # 128 bits + - 5 # 256 bits + default: 0 multi-block: $ref: /schemas/types.yaml#/definitions/uint32-array description: | LLP-based multi-block transfer supported by hardware per each DMA channel. + maxItems: 8 items: - maxItems: 8 - items: - enum: [0, 1] - default: 1 + enum: [0, 1] + default: 1 snps,max-burst-len: $ref: /schemas/types.yaml#/definitions/uint32-array @@ -138,11 +135,10 @@ properties: will be from 1 to max-burst-len words. It's an array property with one cell per channel in the units determined by the value set in the CTLx.SRC_TR_WIDTH/CTLx.DST_TR_WIDTH fields (data width). + maxItems: 8 items: - maxItems: 8 - items: - enum: [4, 8, 16, 32, 64, 128, 256] - default: 256 + enum: [4, 8, 16, 32, 64, 128, 256] + default: 256 snps,dma-protection-control: $ref: /schemas/types.yaml#/definitions/uint32