From patchwork Mon Mar 11 10:22:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1910374 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=iBEoGKcF; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=sBMXGyjl; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=iBEoGKcF; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=sBMXGyjl; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TtXs75SVsz1yWy for ; Mon, 11 Mar 2024 21:22:35 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 24B6E385842A for ; Mon, 11 Mar 2024 10:22:33 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id A2B1E3858D20 for ; Mon, 11 Mar 2024 10:22:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A2B1E3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A2B1E3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710152530; cv=none; b=uBW/I1NoyL6qaxwiSPlBnLFerPniSXE8g4IGCOjyzoQ6gyS9ov7dWhyHH5zEp3AyVxn9Gd7lb9cqhko2HFuEYr/nBdQiSXDDxHWB5I39ucQmKU9ipS4kauE7Ir+oKrK2QHYhjheMaR2C/844RSxX63RqjERlCZTsvGKzzkTidqw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710152530; c=relaxed/simple; bh=jCN5lsrTviDZSekzrU0WvFGLWrMtKxFLStnjHW1/X0Y=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=LIkDa2IYx+M9SLqOgWmRtwFBR0KhX1W2L+qou0TMw3djRNuck75ihH9aTbukp6XhdYIBZyB19Bkblht7n0c4xkq5bSNxFYKTGy/W99BsmwcjFopOR88yz9KHsIXFcd1u1RkK+83VTkmcJtpsVgr9Qjhm3mvFM/Hkn9IS7aZd7TU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 55AD834AFE for ; Mon, 11 Mar 2024 10:22:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1710152527; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=RRQhFRs9LREygWkOSPTQYN+HrSPvGxaIJuP2uAZIElI=; b=iBEoGKcFUMvDqYsF0FQQwSR1/jdlMPWcrs7YsGomWLkWo9uCos7WiUSwzKw8QZHCdHWpnE Jawg19OYq9qoUt4fJzJHLNxu3OvIEY+huYTdmZ0WYyeXDRQhEZcnCLFa/4d+LcMO7fwERT p+AJBRr1fYKYv0d0g2sJQ6r2t5ea3Yw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1710152527; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=RRQhFRs9LREygWkOSPTQYN+HrSPvGxaIJuP2uAZIElI=; b=sBMXGyjl0BcSPjsWEzno0GID/f9VlO6TAcLF8YMmuoR8U/Ne6EMzK0TuneDpGEbv3EWZ7d Lzn0Wwoitx7bZnCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1710152527; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=RRQhFRs9LREygWkOSPTQYN+HrSPvGxaIJuP2uAZIElI=; b=iBEoGKcFUMvDqYsF0FQQwSR1/jdlMPWcrs7YsGomWLkWo9uCos7WiUSwzKw8QZHCdHWpnE Jawg19OYq9qoUt4fJzJHLNxu3OvIEY+huYTdmZ0WYyeXDRQhEZcnCLFa/4d+LcMO7fwERT p+AJBRr1fYKYv0d0g2sJQ6r2t5ea3Yw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1710152527; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=RRQhFRs9LREygWkOSPTQYN+HrSPvGxaIJuP2uAZIElI=; b=sBMXGyjl0BcSPjsWEzno0GID/f9VlO6TAcLF8YMmuoR8U/Ne6EMzK0TuneDpGEbv3EWZ7d Lzn0Wwoitx7bZnCQ== Date: Mon, 11 Mar 2024 11:22:07 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] middle-end/114299 - missing error recovery from gimplify failure MIME-Version: 1.0 Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: 0.73 X-Spamd-Result: default: False [0.73 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.99)[-0.993]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; MISSING_MID(2.50)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.15)[-0.728]; DBL_BLOCKED_OPENRESOLVER(0.00)[gcc.target:url]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-0.53)[80.52%] X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Message-Id: <20240311102233.24B6E385842A@sourceware.org> When internal_get_tmp_var fails to gimplify the value the temporary SSA name is supposed to be initialized with we can leak SSA names with a NULL SSA_NAME_DEF_STMT into the IL. That's bad, so recover from this by instead returning a decl in that case. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR middle-end/114299 * gimplify.cc (internal_get_tmp_var): When gimplification of VAL failed, return a decl. * gcc.target/i386/pr114299.c: New testcase. --- gcc/gimplify.cc | 5 +++++ gcc/testsuite/gcc.target/i386/pr114299.c | 14 ++++++++++++++ 2 files changed, 19 insertions(+) create mode 100644 gcc/testsuite/gcc.target/i386/pr114299.c diff --git a/gcc/gimplify.cc b/gcc/gimplify.cc index 81f06ad91bd..f6078386cdf 100644 --- a/gcc/gimplify.cc +++ b/gcc/gimplify.cc @@ -656,6 +656,11 @@ internal_get_tmp_var (tree val, gimple_seq *pre_p, gimple_seq *post_p, gimplify_and_add (mod, pre_p); ggc_free (mod); + /* If we failed to gimplify VAL then we can end up with the temporary + SSA name not having a definition. In this case return a decl. */ + if (TREE_CODE (t) == SSA_NAME && ! SSA_NAME_DEF_STMT (t)) + return lookup_tmp_var (val, is_formal, not_gimple_reg); + return t; } diff --git a/gcc/testsuite/gcc.target/i386/pr114299.c b/gcc/testsuite/gcc.target/i386/pr114299.c new file mode 100644 index 00000000000..b4f30b7a95f --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr114299.c @@ -0,0 +1,14 @@ +/* { dg-do compile { target lp64 } } */ +/* { dg-options "-mgeneral-regs-only" } */ + +typedef __attribute__((__vector_size__(8))) __bf16 V; +typedef __attribute__((__vector_size__(16))) __bf16 W; + +V v; +_Atomic V a; + +W +foo(void) /* { dg-error "SSE" } */ +{ + return __builtin_shufflevector(v, a, 1, 2, 5, 0, 1, 6, 6, 4); /* { dg-error "invalid" } */ +}