From patchwork Mon Mar 4 10:29:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dong Aisheng X-Patchwork-Id: 1907485 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=RaGRMThS; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:45e3:2400::1; helo=sv.mirrors.kernel.org; envelope-from=linux-pwm+bounces-1686-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org [IPv6:2604:1380:45e3:2400::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TpFCp1Qdyz23fC for ; Mon, 4 Mar 2024 21:23:50 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 8DF4D280F95 for ; Mon, 4 Mar 2024 10:23:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6AB7C2577E; Mon, 4 Mar 2024 10:21:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="RaGRMThS" X-Original-To: linux-pwm@vger.kernel.org Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2054.outbound.protection.outlook.com [40.107.104.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3787B24B29 for ; Mon, 4 Mar 2024 10:21:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.104.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709547706; cv=fail; b=cCwHmmDMIi+mfjUPduDx//juWpba6NFU65MFxwI/5hX8OVqyAP1UYYhQIZ1U0cy35EuBEvM1lkiTAAg4y4LMK2ZCBfb9ScYMmHECK2YbOarh96cvQnWBKYnH+qPEeRsnwJdlYLMdJinOBRdCT+g29NZV35UPsR0jKBf2OZ6tRCQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709547706; c=relaxed/simple; bh=6XRGR0i5+n1I0HLhg9Xpt8lVpvxq1lwm+lHW7kbYIX8=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=oGXw5n0cxJ6N1Q1tbeEifKawHWL5Wr9bzXa9uDCWvmNTGjNEbSmbqK0EA/l5Kztc2kvypHEd8RDF++XUt60mqE8h8v+ai8A+lnXAzor59X/FyBxpvG/vdouAOEjiyXI9zwyG90oX+6peG1XRx210lH2rY+pFkakXu7SDL6T5nMs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=RaGRMThS; arc=fail smtp.client-ip=40.107.104.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B+7NZAWmPDfsSMZmo3/x6N2GrRXTJwbFkuN4K2El3Y2Iu7hjEgCBGqr1m55MMj5N/GYY1cih0D6CvrmLglSymChWYefCGGTpprSPeaZfNK047V2S1EoZDt/YVywhWdd3OiSHfE542e1Q0fhWEtxGN5hwRXp01YNGRYwr4vsZkZaX9bmo7oXagS1pYVnZoLrHQdNFkJ8b6sShQXB1yeHNnx6dtlVNqoZi/f6BHPmO+qQFiTXAsEMaJdMqI5r56iacdBAN41ub7ZWunavRO5LoBV+Zois+3sx7u4Lq7vfKDSq+vYBWSGQ6Jrer9XxXEoyayZXlV/6d0JsLHxHvNXJ2eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7pl7PYdnflq+71bZUFtfemQaBFvaHsd6WwA0ec8oRhM=; b=SfMpTuBLPkxSFgJYRCXobHg3hXZPFVUz8xpKuRBqLhW3v+zDebPPPtIUchR5FGxN2C1SKVLs7iHqaZEYujcifvZ6UnHvDxxVDn5X2YnhxGxsRgvcSa/YIbg6YuidHEHfHOTsOU7Ek/QIkvaABTmCPntvscujH6vmggavGti1CjMSqcIxseqqOQotNxOgierZi+2w5bLr5lIIXguTaE/DUiY9Vrp5ocKebHYRSUz2haacSfMKzCFzXvDAkIFGlqP2a5UJF+x8xTjFng+PBH0al2wygr2LICiXdAwA8bguKEoeJ60BHXRRrFHFlZ5BEq5yJMn2DauKzO34w2FmqeVSsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7pl7PYdnflq+71bZUFtfemQaBFvaHsd6WwA0ec8oRhM=; b=RaGRMThSV7lQWCcsZtuQyOQh6pMNS1CMb2kBBqtss2bIrodX34NPsxInPKLz2naUQRN5XSyhHKXari2H0ZXNU9GVsGFDXyUNycRd1TvtzZhI2qXeTLCruEHfE5MX77xYI4Jwp5VG1Uc9q68AgGZRBLeTySC9qLCAmyTDA0D+Q+4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU0PR04MB9299.eurprd04.prod.outlook.com (2603:10a6:10:356::7) by DB8PR04MB7017.eurprd04.prod.outlook.com (2603:10a6:10:123::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.38; Mon, 4 Mar 2024 10:21:37 +0000 Received: from DU0PR04MB9299.eurprd04.prod.outlook.com ([fe80::57dc:31d2:381a:df71]) by DU0PR04MB9299.eurprd04.prod.outlook.com ([fe80::57dc:31d2:381a:df71%4]) with mapi id 15.20.7339.031; Mon, 4 Mar 2024 10:21:37 +0000 From: Dong Aisheng To: linux-pwm@vger.kernel.org Cc: u.kleine-koenig@pengutronix.de, shawnguo@kernel.org, kernel@pengutronix.de, festevam@gmail.com, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, dongas86@gmail.com, Dong Aisheng Subject: [PATCH 1/1] pwm: imx-tpm: fix probe crash due to access registers without clock Date: Mon, 4 Mar 2024 18:29:29 +0800 Message-Id: <20240304102929.893542-1-aisheng.dong@nxp.com> X-Mailer: git-send-email 2.37.1 X-ClientProxiedBy: SG2PR06CA0199.apcprd06.prod.outlook.com (2603:1096:4:1::31) To DU0PR04MB9299.eurprd04.prod.outlook.com (2603:10a6:10:356::7) Precedence: bulk X-Mailing-List: linux-pwm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9299:EE_|DB8PR04MB7017:EE_ X-MS-Office365-Filtering-Correlation-Id: da636d46-dcfc-485f-bf6e-08dc3c34df77 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BtgJXqdUOx2/hDED5PyPN9VjHZH59FROnJce/DVfx+9xEmGxlvBCRr9u7AO1r3Nh5bCaUmqIzzt+AxDvg6OGBZeZGxgu7SiwGqsRij4vNFvyuZHi/CzIjI/4IV6XarasGKee/Ir4xPnlAGAm/2kCAnxiJybVGsUo9hHBEE+lq0El1NL8nTeyN5tUlMmJjB3V9j2zX+0cWSjgDkRnwxvvJdwupbjmLMY093yot5udQM1XEPH6+ZrtznNC+b1IhjIWn71pKe9EHqQm1QZWjaSkl1Hk+F+KRQYoAjVWJNZg3kyUQe/tEi0q7B/Vypl3FcbaUvDeliL/vkA0Lk83jZIp/ourPEihfEDriIaFwwAdE1IpCBVFUnG7vs0+wsNCdAt2Izo8U4sdPcti6M3l5AdCeTmVuD6xfkwr2y+FO2z2mYi/LaSf5JY/Kjj9HZ90n6Q7FCK3xxxAZBdzPHL4Xi4sTDK1LNHJhPFBOmZoeFUcIxWDaUiKhoK/7ZZNvbTGAsnmUw1len31WZLvcIMwm6kFLW4jYEZQGoDxtwQjoll3u/KJYxHVQyaZsyI4kM7EJqF9LCAWeQbjEzu+qfVgOpv/ASiippuHalHTvFtejDnaFi31Sdc9Uo415rQP86UgLre3viPyrnuTAXqzlaPEIEsRrXSMeVrjfzZJ/8mJloUSoJH1lyj3VuR0T1FGfHAjb+L7aL0MgNyN0Qynrapr7iowqA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9299.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(38350700005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?URA1xH5rBrMHSunAPjGtIkwYMcmz?= =?utf-8?q?Cjj5E4YYAu43jOC2a8sP0emhCaODhF42z8wl6kY8jyYn9fsTo+nZh3TWmWPdkBkX3?= =?utf-8?q?QUZAshA9xcC8rXe5/Nh6NWLGtYH4GdhldaRvkAVNCZwMnpkLpZT1JvCWcycCwCKY8?= =?utf-8?q?SG+v0NMywpw+UaBOOiKJmDDQjxXT5Il9CwRNBrSMayHAqQomPNYBP4M9hldj+Dv4R?= =?utf-8?q?P4oogO2FSk4rMNGBajhOVC7Lp4JvGuG6cQeTXQo5hOyj84fCHYs+cdtKwWB6giyX/?= =?utf-8?q?Nb9R7y1h9xd6XH3z8447i4iVn7hMKUP1h8o1aRbjSn0SYm/mNn66chsbvcIHjHCvl?= =?utf-8?q?w9he6zIUs2NAIFBmcVPAZTFZnTRG3EBgwNIiqNZLnGcFuRUHzcYSQmeyoYEIeo9Nn?= =?utf-8?q?AK0Wo7h786SjPxI5wih9jgmkYLjYXqn+50aIpW+GbXT0/5b0jVhsyuNpmheswsDpS?= =?utf-8?q?mjC5ivOc4hbQvarddrZoUQx3zgaPipFWJpY+4pbDJQSb7/1eNidb/scAPWQ2sLp8V?= =?utf-8?q?nY9aAb+SGG0B7pTXzkcA5/GX49WkySUAL468ZQHes7PCu6PqALlFnt1tfgX4e2gcD?= =?utf-8?q?0mQlsW9aPyZb6T/Cqg6d4CqInsbNvBDZIcY+v2YArtjx6nx2Qlt04HTKCBE++4q0t?= =?utf-8?q?5SAYKywhz+z/rYB9ENQwwmuKjySZA1FvLYlcd6KyUjkQbwQtv2WC4hIUXB306bE7X?= =?utf-8?q?iJd2J9g5vmJYWDKEWCSuxuFu+5yydRe085hmSCFkYGRyCBE4j48XUN1gzD61BX2PI?= =?utf-8?q?+p/TFvj5Rk/cx9jRNr1pcsSw9uuZckyu31u3F1nUsJw8zvsAlvrRXvNk46MFz5f33?= =?utf-8?q?3jonj3xSyWULlDiEc/yAayvdcV7vmt7swIp71pEKVY5cg5GawzldWQEwBS8oetv5P?= =?utf-8?q?22+BRM9d7PPbWFCWVN+CPd/oYkVWB4VWruV3f07nBNVKPHfLhZEpHwO26MDi/A6CO?= =?utf-8?q?P97V7nkicNyGf5T6PI09Cox+VKoLIAVNMV93IZEJIX+86rG8X1t9eLXoGSxspWIfs?= =?utf-8?q?8VYAWiJ1Vycu9sWlUtkzV49kvpsoEXPqD2umJiBU4XbAUbLDbLTKVJEH0HJ94zZGn?= =?utf-8?q?NrnStik33h9jzhke488BnLZUg6IVINv7kYDOlvBVyuZG3NpwY/wJ735s3z6NbG2CY?= =?utf-8?q?8S/Vj1wBrz7uPxYJq9jgd/zAWFdsMKwXXEX+Ohf5zWV2OFgM7agLw+GJZMKKG7XKa?= =?utf-8?q?XkORYIHVF89uL42u38zF7kGLzLqc+/LEDCm2GjXLg4twaeYOnLQvOM+KWmu0JmsGh?= =?utf-8?q?iC5KmIBI9veHooxXDHerpDrxRfYo+EkbHfhvCO1pr1KJSumahH6UC4gSFA3lMhS1D?= =?utf-8?q?qEw12+IaqvLZY2M/J0d38Mx903GWZEBvGAf5s+8NSWbG8nTTG/SAnPwkDC6z80FI6?= =?utf-8?q?zyZS36LpLWJcd9n9SmqKo1ep8lWe5lXT/QGwsj7kq+nhLDLBgIDoxR7T5oa5zYsOH?= =?utf-8?q?szkRcqvIIV+3Sd1GatjsaGyQ0HnMtlDX2qRzgMVoFE7R5mToiiypuJ9vKKlLdU7QK?= =?utf-8?q?6ZE3uGZ23q22?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: da636d46-dcfc-485f-bf6e-08dc3c34df77 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9299.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 10:21:36.8057 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1mjV/QMn9qE0rSlU0/9oVM+i2txQWWAh4SuPAIcbYDs2sOgj6ke3sjSCBIpIKmtx0KdqEZEKGXMv2Q9a0Ywijw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7017 The following commit abf6569d6482 ("pwm: imx-tpm: Make use of devm_pwmchip_alloc() function") introduced an issue that accessing registers without clock which results in the following boot crash on MX7ULP platform. Fixed it by enabling clock properly. Unhandled fault: external abort on non-linefetch (0x1008) at 0xf0978004 [f0978004] *pgd=64009811, *pte=40250653, *ppte=40250453 Internal error: : 1008 [#1] SMP ARM Modules linked in: CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.8.0-rc6-next-20240301 #18 Hardware name: Freescale i.MX7ULP (Device Tree) PC is at pwm_imx_tpm_probe+0x1c/0xd8 LR is at __devm_ioremap_resource+0xf8/0x1dc pc : [] lr : [] psr: 80000053 sp : f0825e10 ip : 00000000 fp : 00000000 r10: c148f8c0 r9 : c41fc338 r8 : c164b000 r7 : 00000000 r6 : c406b400 r5 : c406b410 r4 : f0978000 r3 : 00000005 r2 : 00000000 r1 : a0000053 r0 : f0978000 Flags: Nzcv IRQs on FIQs off Mode SVC_32 ISA ARM Segment none Control: 10c5387d Table: 6000406a DAC: 00000051 ... Call trace: pwm_imx_tpm_probe from platform_probe+0x58/0xb0 platform_probe from really_probe+0xc4/0x2e0 really_probe from __driver_probe_device+0x84/0x19c __driver_probe_device from driver_probe_device+0x2c/0x104 driver_probe_device from __driver_attach+0x90/0x170 __driver_attach from bus_for_each_dev+0x7c/0xd0 bus_for_each_dev from bus_add_driver+0xc4/0x1cc bus_add_driver from driver_register+0x7c/0x114 driver_register from do_one_initcall+0x58/0x270 do_one_initcall from kernel_init_freeable+0x170/0x218 kernel_init_freeable from kernel_init+0x14/0x140 kernel_init from ret_from_fork+0x14/0x20 Cc: Uwe Kleine-König Fixes: abf6569d6482 ("pwm: imx-tpm: Make use of devm_pwmchip_alloc() function") Signed-off-by: Dong Aisheng --- drivers/pwm/pwm-imx-tpm.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/pwm/pwm-imx-tpm.c b/drivers/pwm/pwm-imx-tpm.c index b04b974c5f32..c50ddbac43c8 100644 --- a/drivers/pwm/pwm-imx-tpm.c +++ b/drivers/pwm/pwm-imx-tpm.c @@ -337,6 +337,7 @@ static int pwm_imx_tpm_probe(struct platform_device *pdev) { struct pwm_chip *chip; struct imx_tpm_pwm_chip *tpm; + struct clk *clk; void __iomem *base; int ret; unsigned int npwm; @@ -346,6 +347,11 @@ static int pwm_imx_tpm_probe(struct platform_device *pdev) if (IS_ERR(base)) return PTR_ERR(base); + clk = devm_clk_get_enabled(&pdev->dev, NULL); + if (IS_ERR(clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(clk), + "failed to get PWM clock\n"); + /* get number of channels */ val = readl(base + PWM_IMX_TPM_PARAM); npwm = FIELD_GET(PWM_IMX_TPM_PARAM_CHAN, val); @@ -358,11 +364,7 @@ static int pwm_imx_tpm_probe(struct platform_device *pdev) platform_set_drvdata(pdev, tpm); tpm->base = base; - - tpm->clk = devm_clk_get_enabled(&pdev->dev, NULL); - if (IS_ERR(tpm->clk)) - return dev_err_probe(&pdev->dev, PTR_ERR(tpm->clk), - "failed to get PWM clock\n"); + tpm->clk = clk; chip->ops = &imx_tpm_pwm_ops;