From patchwork Tue Feb 13 05:02:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 1898051 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=y2UuGXq7; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:4601:e00::3; helo=am.mirrors.kernel.org; envelope-from=linux-rtc+bounces-649-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from am.mirrors.kernel.org (am.mirrors.kernel.org [IPv6:2604:1380:4601:e00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TYq3B6tk8z23hT for ; Tue, 13 Feb 2024 16:03:18 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6B65A1F24116 for ; Tue, 13 Feb 2024 05:03:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9EF251171C; Tue, 13 Feb 2024 05:03:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="y2UuGXq7" X-Original-To: linux-rtc@vger.kernel.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5630911711; Tue, 13 Feb 2024 05:03:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707800588; cv=none; b=u/+goJl4PDu2pQMLM8jJPFtghNqnw/COOTZPLfPlGgscty+i7LsXs+FtnbmehiVLh1qeDXIx0ZQwNrTw/S+hNXgyI52mx73ulH4Jt762/q7LXt6jdTFV9G7o3X5FKqQx6VqepAt98n8JfnccbUzwbFQiHwwYJdJcWNFdWBixTow= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707800588; c=relaxed/simple; bh=7gBurt55rmqnev0iYzt5sjeYAJF23VKQewkN/k7zrfk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pYxwYU1u2Ogcv2SkFvAgWs0iDZqPiKTwypT74a1YIMseVK63dlR5ib/u0FpFQWlJQXZYeGycQfDPM9yaNTWlUSp20vT6fxK/sOJ81h72uoDT17AYTM49gXHOzIF7M2mjO26aaVr7dcww5AY5IyOA4loqlkUA6ErMF/+Khwfi4Dg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=y2UuGXq7; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=TtWttyee/5Vn7DkruIaUNFtX0dg5UyJYT71WtS68lvQ=; b=y2UuGXq7TVGkgDfbVqKyK6qZI0 SzB9u73KS37xUZQNvk05H+/v1P90LfvWrA7Bf8fA1OncBax31UlMvFXTdeDTTpawE5ESXJh39j8gU QUow+QElY8Esw1Gb+l8UdNgLZW9l99ptUgQrk/JXPapsg/oSZljj+986pnmdUnDcjRSXcfLlTiPvL CT6AzLnpWX9DOBO+0aMoN2nfR+nxCtejpQhJtTI+aUHUT8HMH9hAY9b/gnRcLDLXHewA1t5XacgX7 0t/QcHfUCnss3DoKpuNvXeMoHN4G5280CoJU6+nf05lEzPtMQWWLvBGNhQP/tknH28T/cippxKxwK YozeUPFA==; Received: from [50.53.50.0] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZkwg-00000007xyA-0pHe; Tue, 13 Feb 2024 05:03:02 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Arnd Bergmann , Eddie Huang , Sean Wang , Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org, Marc Zyngier , Philipp Zabel , Peter Rosin , AngeloGioacchino Del Regno Subject: [PATCH v2] rtc: mt6397: select IRQ_DOMAIN instead of depending on it Date: Mon, 12 Feb 2024 21:02:58 -0800 Message-ID: <20240213050258.6167-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set it directly thru "make *config", so drivers should select it instead of depending on it if they need it. Relying on it being set for a dependency is risky. Consistently using "select" or "depends on" can also help reduce Kconfig circular dependency issues. Therefore, change the use of "depends on" for IRQ_DOMAIN to "select" for RTC_DRV_MT6397. Fixes: 04d3ba70a3c9 ("rtc: mt6397: add IRQ domain dependency") Cc: Arnd Bergmann Cc: Eddie Huang Cc: Sean Wang Cc: Matthias Brugger Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Cc: Alessandro Zummo Cc: Alexandre Belloni Cc: linux-rtc@vger.kernel.org Cc: Marc Zyngier Cc: Philipp Zabel Cc: Peter Rosin Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Randy Dunlap --- v2: add Rev-by: from AngeloGioacchino drivers/rtc/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -- a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -1858,7 +1858,8 @@ config RTC_DRV_MT2712 config RTC_DRV_MT6397 tristate "MediaTek PMIC based RTC" - depends on MFD_MT6397 || (COMPILE_TEST && IRQ_DOMAIN) + depends on MFD_MT6397 || COMPILE_TEST + select IRQ_DOMAIN help This selects the MediaTek(R) RTC driver. RTC is part of MediaTek MT6397 PMIC. You should enable MT6397 PMIC MFD before select