From patchwork Fri Feb 2 16:04:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 1894693 X-Patchwork-Delegate: festevam@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=SsFO0mf+; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TRLDz4zfbz1yhq for ; Sat, 3 Feb 2024 03:04:19 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1F71187BD6; Fri, 2 Feb 2024 17:04:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="SsFO0mf+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3454487BDC; Fri, 2 Feb 2024 17:04:16 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E7BA78791E for ; Fri, 2 Feb 2024 17:04:13 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=festevam@gmail.com Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1d748f1320aso2682475ad.0 for ; Fri, 02 Feb 2024 08:04:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706889852; x=1707494652; darn=lists.denx.de; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=t1FsDmAF2QPYijV9s842Wj9EyfI5HO+HEqpX8JqtCMw=; b=SsFO0mf+9fR/WKuGY5rvcGSweg6u4wxb21oki8m/whCmw4Hc18XWsbOnDVBzZr3Qez WK9Dg0PSxrNJeQpfFcHEWrZAbwRKh+MQWyTt3DvybIsqC5PmSxyIYUAg2QJu4BLJy1t5 Vgv7Mec0ZP14ID/0bhY7A1cgdmCpujGxGi2eMRDaL21GND/fnWCEzZH1o5VmdMc8IbMX ipsvpcy2FvwucYZsJ2dv21s6AA+L9RlmMXvCGkxg5WasMPrO74YikI/mRo7mgKDtgNCG D50CepWIndQey/HSbx1YqdRGb1AUbEzN76ZhYDd5s1jFoXOTNQDQeBtM3OdXd2nmRuqG Gztg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706889852; x=1707494652; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=t1FsDmAF2QPYijV9s842Wj9EyfI5HO+HEqpX8JqtCMw=; b=jTJACPN16cK+2+XafMyw+OTDL3YGy2X64u9anaOofIC7nPE82lzVEVgwMKwAb8ED9g I92IIvB2MlvtXT6+5rEit3h78GT43aVz0wkCivsKK5jMZLebrqZP9VimDQmIpomxckMR LKyE3vjPHxCdVRtaLh/c80sw+Ppud6ukmbuL2REcS3MtMn2KdsWTmWvVr1SGxwLpO69n zrjMXpowKqnMsZSt+DMp96TasLIENTRFTqIrBmG4wR9RSIlY9HvFCxUh0DG6jzV+45ae JFBBwa7mjHR/wl8gCU4nhGxYTB73Ni7hdj7OclRmTfWgcFxjD5QqCGeo4sQB0MKR9AVb oiwg== X-Forwarded-Encrypted: i=0; AJvYcCWdB1vAkx3UxmocI/bnRD7ydYsBOXHffB8DO2g6S1VSFP0ZQ3wr0Prkf5m7bnPRCjMC8fQUrwsQtCnN8k2ynj6HBayDfg== X-Gm-Message-State: AOJu0Yze2P6qPb+heSDEG9AfTB83KDcF0U9Ps/Uxm+6XyOPjGgbooMb3 qAXFPKd/rHvG0R363lgtA7XdA9sBxcBNbGrsiRAdOIuGH1ggpUKHpKWx6ZwP X-Google-Smtp-Source: AGHT+IHHolLFdFlZ4TLoF78iG+XxGUHK2Tjx3IHyaDKlmWpYqyOAnJskbTOa1ZE0g4pbrGEajKBXKQ== X-Received: by 2002:a17:902:ea82:b0:1d9:61ef:1876 with SMTP id x2-20020a170902ea8200b001d961ef1876mr4032282plb.1.1706889851945; Fri, 02 Feb 2024 08:04:11 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVH6zhWMzryxGFP9GZpb+4JrAuXdWsvlyw3l8dHSA/OyW/rZqoAsdG56yYfBs7BhGoobICtkeJz6zIiwMVM9cpxJivp0hJn1SmZLGaqRAh+tPHt5nN+Tat/Ib6eMNCuGoIbi3AlPEWdcS63 Received: from fabio-Precision-3551.. ([2804:14c:485:4b61:fa09:d56a:f130:f280]) by smtp.gmail.com with ESMTPSA id v4-20020a170902b7c400b001d8b8bf8e44sm1780086plz.92.2024.02.02.08.04.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 08:04:11 -0800 (PST) From: Fabio Estevam To: sbabic@denx.de, trini@konsulko.com Cc: uboot-imx@nxp.com, u-boot@lists.denx.de, Fabio Estevam Subject: [PATCH v2 1/3] mx6sabresd: Fix U-Boot corruption after saving the environment Date: Fri, 2 Feb 2024 13:04:03 -0300 Message-Id: <20240202160405.4126192-1-festevam@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean From: Fabio Estevam U-Boot binary has grown in such a way that it goes beyond the reserved area for the environment variables. Running "saveenv" and rebooting the board causes U-Boot to hang because of this overlap. Fix this problem by selecting CONFIG_LTO so that the U-Boot proper size can be reduced. Also, to prevent this same problem to happen in the future, use CONFIG_BOARD_SIZE_LIMIT, which can detect the overlap in build-time. CONFIG_BOARD_SIZE_LIMIT is calculated as follows: CONFIG_BOARD_SIZE_LIMIT = CONFIG_ENV_OFFSET - u-boot-img.dtb offset CONFIG_BOARD_SIZE_LIMIT = 0xc000 - 69 * 1024 CONFIG_BOARD_SIZE_LIMIT = 715766 Signed-off-by: Fabio Estevam Reviewed-by: Tom Rini Reviewed-by: Igor Opaniuk --- Changes since v1: - Select LTO. (Tom) configs/mx6sabresd_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/mx6sabresd_defconfig b/configs/mx6sabresd_defconfig index a90efe4a7786..d4fb55622cf1 100644 --- a/configs/mx6sabresd_defconfig +++ b/configs/mx6sabresd_defconfig @@ -21,6 +21,9 @@ CONFIG_SPL_SERIAL=y CONFIG_SPL=y CONFIG_SPL_LIBDISK_SUPPORT=y CONFIG_PCI=y +CONFIG_LTO=y +CONFIG_HAS_BOARD_SIZE_LIMIT=y +CONFIG_BOARD_SIZE_LIMIT=715766 CONFIG_FIT=y CONFIG_SPL_FIT_PRINT=y CONFIG_SPL_LOAD_FIT=y From patchwork Fri Feb 2 16:04:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 1894694 X-Patchwork-Delegate: festevam@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=StkhgVmB; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TRLFB1DL3z1yhq for ; Sat, 3 Feb 2024 03:04:30 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7DE0D87BF2; Fri, 2 Feb 2024 17:04:19 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="StkhgVmB"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 60F2287BF2; Fri, 2 Feb 2024 17:04:18 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2A65C87186 for ; Fri, 2 Feb 2024 17:04:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=festevam@gmail.com Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1d722740622so4049775ad.0 for ; Fri, 02 Feb 2024 08:04:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706889854; x=1707494654; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FTvyaINkirJySMHirPeZLKqUxFNBlnKeiZ2Cggxua8E=; b=StkhgVmBq3ekSk6ueXyn+V1jlBXmN1ma+Q223fDcRhLsuPA/LBkltGPnJBgp8SXXxJ PLjnVQnNCnv5iZZNgAcyH1vzGh+g2HAjJGHeUkZpemtOBzTTc2TN74hLeFaHSZywYM6d 9pMRsO2JRDhrlQ56vX7Ob6UmX1DrLnClXOPf2aSD+gnLDmlljQG3erFhBOZ1bSPNsK+3 aLghdgLfpoelVBGd121zv8tVIPD8lSdTaVwrSuHZhRxEn+enYAGFm+qDe6lbyckT0SYU aJlG98A69oxKvXbGhwb6+wXSplDvmmERBWbvX3IuBhdmL58nJk/2Wfj1yoTIDS9R+4CM chQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706889854; x=1707494654; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FTvyaINkirJySMHirPeZLKqUxFNBlnKeiZ2Cggxua8E=; b=LHi9mur6bU/SxyNpNHilZAyuwnGVWr8NuUbQjtzrg7lYEBX+KyRPzwfaxmMSWDacLb MYm4XqpxvQ0QDU1/LROwrHi8N7qzg8M0Qgyz2foqGrvV59uXyr2eq2OKL3homMaVCrXT JJodniUaRpR5D9GkkukcIrTpFhqL0FBc1Q6V92hqoLrR2PcF5n9bBUjFnavb0Oax/lYy xn2qaPcMD84nTD7ptpHWQuzZL/veYQ7mO7wfg5RAwd4Ebgnn9FVxIV9NicEtPqhEpqYX 8dSkAt1u2SwA9QOT4rOn/1SE1dp8CtNpDZZtaF9UUdvky7V2vHINtvALoaIehFTBzdL4 9rog== X-Gm-Message-State: AOJu0Yy7Na8elCjd2Ii1+O6kBzOORT41adxzTIFQ2yPeRTZt113C1VW2 yvqfM4R19TRV8uMHA3yfsQnVTObaWnIVDSt3IqUqK6GgF0eKy+II X-Google-Smtp-Source: AGHT+IEUbl8RkiP8sw2KHJN0S/eBBD7gT12TYv2wwu1qCM3oJN10IujMqQVLAqUOqlD9yFgmPC7EMA== X-Received: by 2002:a17:902:ee85:b0:1d8:f06a:9b6f with SMTP id a5-20020a170902ee8500b001d8f06a9b6fmr6446267pld.1.1706889854376; Fri, 02 Feb 2024 08:04:14 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCU0W4xk/E+OS5aqMawteFrw9ih7Sxa4kulCpZTPEqn/uAhOWNF0J5bYnR5nvOSSpGW7YnpclK38yO+sFtQfVux+ucc9EYJ9d015ZhA5UiDi+8qxFfnbG1+pYItTuhMlczX/ThDBWigEVZyn Received: from fabio-Precision-3551.. ([2804:14c:485:4b61:fa09:d56a:f130:f280]) by smtp.gmail.com with ESMTPSA id v4-20020a170902b7c400b001d8b8bf8e44sm1780086plz.92.2024.02.02.08.04.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 08:04:14 -0800 (PST) From: Fabio Estevam To: sbabic@denx.de, trini@konsulko.com Cc: uboot-imx@nxp.com, u-boot@lists.denx.de, Fabio Estevam Subject: [PATCH v2 2/3] mx6sabresd: Convert to watchdog driver model Date: Fri, 2 Feb 2024 13:04:04 -0300 Message-Id: <20240202160405.4126192-2-festevam@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240202160405.4126192-1-festevam@gmail.com> References: <20240202160405.4126192-1-festevam@gmail.com> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean From: Fabio Estevam Commit 68dcbdd594d4 ("ARM: imx: Add weak default reset_cpu()") caused the 'reset' command in U-Boot to not cause a board reset. Fix it by switching to the watchdog driver model via sysreset, which is the preferred method for implementing the watchdog reset. Signed-off-by: Fabio Estevam --- Changes since v1: - None. arch/arm/dts/imx6qdl-sabresd-u-boot.dtsi | 9 +++++++++ configs/mx6sabresd_defconfig | 3 +++ 2 files changed, 12 insertions(+) diff --git a/arch/arm/dts/imx6qdl-sabresd-u-boot.dtsi b/arch/arm/dts/imx6qdl-sabresd-u-boot.dtsi index 5c4101b76da2..9e9c4422f00e 100644 --- a/arch/arm/dts/imx6qdl-sabresd-u-boot.dtsi +++ b/arch/arm/dts/imx6qdl-sabresd-u-boot.dtsi @@ -9,6 +9,11 @@ aliases { mmc1 = &usdhc3; }; + wdt-reboot { + compatible = "wdt-reboot"; + wdt = <&wdog2>; + bootph-pre-ram; + }; }; &usdhc3 { @@ -18,3 +23,7 @@ &pinctrl_usdhc3 { bootph-pre-ram; }; + +&wdog2 { + bootph-pre-ram; +}; diff --git a/configs/mx6sabresd_defconfig b/configs/mx6sabresd_defconfig index f19df607e7ae..69685f12eb10 100644 --- a/configs/mx6sabresd_defconfig +++ b/configs/mx6sabresd_defconfig @@ -103,6 +103,8 @@ CONFIG_DM_REGULATOR_FIXED=y CONFIG_DM_REGULATOR_GPIO=y CONFIG_DM_SERIAL=y CONFIG_MXC_UART=y +CONFIG_SYSRESET=y +CONFIG_SYSRESET_WATCHDOG=y CONFIG_SPI=y CONFIG_DM_SPI=y CONFIG_MXC_SPI=y @@ -129,3 +131,4 @@ CONFIG_IMX_HDMI=y CONFIG_SPLASH_SCREEN=y CONFIG_SPLASH_SCREEN_ALIGN=y CONFIG_BMP_16BPP=y +CONFIG_IMX_WATCHDOG=y From patchwork Fri Feb 2 16:04:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 1894695 X-Patchwork-Delegate: festevam@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=Q/0ByGB4; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TRLFP6PLjz1yhq for ; Sat, 3 Feb 2024 03:04:41 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DFDE687C3D; Fri, 2 Feb 2024 17:04:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Q/0ByGB4"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7B72887C15; Fri, 2 Feb 2024 17:04:20 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3D8A187BF1 for ; Fri, 2 Feb 2024 17:04:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=festevam@gmail.com Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1d97d086756so662575ad.1 for ; Fri, 02 Feb 2024 08:04:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706889856; x=1707494656; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OGbaT51S6dZ/iUgH4jNh2ugjc/NvPEGM9rEU36lf/8A=; b=Q/0ByGB4u7D+VMeFqw2+x752dpp9ayCkBAFy5DfSsl1+Su05Q2B0/4vqIHcW4qUYv5 pvW0A4K9B0TY7ShvBgazLvwLas9AvztziSnsxJmcep58lw5448gWbjFnPxLXe7XCl+zF wGB/D0GmIdhg0zxG1NgTIzthOoG3gGOjbrMNYiKvbu9dbAXS6YM0MVJuNFLih5K5+52t ATXC8MHJkbk9IhNKHJKh1Ou8adgbC7se07SVpq28+T62cuzIJSS8+C+rABxY74v638EH qVs3+corpNeWs/WeqDC9n5/wVqY6ufbflUcGWIZobngTUeAEsQxD/P38bQayXrlONAaD bSOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706889856; x=1707494656; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OGbaT51S6dZ/iUgH4jNh2ugjc/NvPEGM9rEU36lf/8A=; b=Q+jXXV0AqnoEHVjkimUWzTTlzIKALQdfZJk6FprIfDf9BtLYQ3GTM/3FeXi6fCRuHC e1f0orzVxB7A9eCHr1PUrE/xnCXHX6O64lKam2DBY61SXrPPM5m6MdIMylOeM9YADyx7 mCLnuFQAG34NakSlNFV37NMEZw5UOP/2fnXhjLyL8jxEI6M05VAmjKPD2odvpJxoaYrD djUjuRAIjoXNCG3HSOAhGZfAFBn1Yzw2OtxqUx/YhR9JyHuzOsCodUEYKR8MSRFEKrSO VRYdERi2TPHjIpyoIYwH6WW+C/ES5OlGWGuHmD9siQd4wOTfxst0n+BleEeh7zgXTBLS ec+A== X-Gm-Message-State: AOJu0YzmG8pNDdR1D558wXziIo7Ca6+hmfHLEEaqfQQCL3u2nqmG0kZ6 nZTnp3aY31xU5sY7CBej+Osx3/lmWcUkD++hdBEB/BBH20BFs13j X-Google-Smtp-Source: AGHT+IE3Am5h/+ljLNWYfN+GN8R4nM55RVG3vPEm9yIihZ3zVflx2iSiSWAFjvSOfMtr5WUOpvOosw== X-Received: by 2002:a17:902:ec89:b0:1d8:eac8:5e00 with SMTP id x9-20020a170902ec8900b001d8eac85e00mr6400593plg.4.1706889856446; Fri, 02 Feb 2024 08:04:16 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXJbJq6XSafWgOhOp7lHBgyoTtLBmVz2nrrKpc0FF+YeKj3IbjOj9HrbwKAB+S6LcycGL4D4CNbWShps3OZghFTTlysrlsCSzePQ8dt2pTB+emoQxKLnnInO9lJDmuEKm0go/Rf9xPqv2zV Received: from fabio-Precision-3551.. ([2804:14c:485:4b61:fa09:d56a:f130:f280]) by smtp.gmail.com with ESMTPSA id v4-20020a170902b7c400b001d8b8bf8e44sm1780086plz.92.2024.02.02.08.04.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 08:04:16 -0800 (PST) From: Fabio Estevam To: sbabic@denx.de, trini@konsulko.com Cc: uboot-imx@nxp.com, u-boot@lists.denx.de, Fabio Estevam Subject: [PATCH v2 3/3] mx6sabresd: Remove board_phy_config() Date: Fri, 2 Feb 2024 13:04:05 -0300 Message-Id: <20240202160405.4126192-3-festevam@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240202160405.4126192-1-festevam@gmail.com> References: <20240202160405.4126192-1-festevam@gmail.com> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean From: Fabio Estevam With Ethernet DM in place, there is no longer the need for having the board_phy_config() anymore. Remove it. Confirmed that TFTP transfer still works fine without board_phy_config(). Signed-off-by: Fabio Estevam Reviewed-by: Igor Opaniuk --- Changes since v1: - Newly introduced. board/freescale/mx6sabresd/mx6sabresd.c | 34 ------------------------- 1 file changed, 34 deletions(-) diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c index b558a596dff8..bb066a5d36c3 100644 --- a/board/freescale/mx6sabresd/mx6sabresd.c +++ b/board/freescale/mx6sabresd/mx6sabresd.c @@ -7,7 +7,6 @@ #include #include -#include #include #include #include @@ -254,39 +253,6 @@ int board_mmc_init(struct bd_info *bis) } #endif -static int ar8031_phy_fixup(struct phy_device *phydev) -{ - unsigned short val; - - /* To enable AR8031 ouput a 125MHz clk from CLK_25M */ - phy_write(phydev, MDIO_DEVAD_NONE, 0xd, 0x7); - phy_write(phydev, MDIO_DEVAD_NONE, 0xe, 0x8016); - phy_write(phydev, MDIO_DEVAD_NONE, 0xd, 0x4007); - - val = phy_read(phydev, MDIO_DEVAD_NONE, 0xe); - val &= 0xffe3; - val |= 0x18; - phy_write(phydev, MDIO_DEVAD_NONE, 0xe, val); - - /* introduce tx clock delay */ - phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x5); - val = phy_read(phydev, MDIO_DEVAD_NONE, 0x1e); - val |= 0x0100; - phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, val); - - return 0; -} - -int board_phy_config(struct phy_device *phydev) -{ - ar8031_phy_fixup(phydev); - - if (phydev->drv->config) - phydev->drv->config(phydev); - - return 0; -} - #if defined(CONFIG_VIDEO_IPUV3) static void disable_lvds(struct display_info_t const *dev) {