From patchwork Wed Jan 17 21:20:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 1887624 X-Patchwork-Delegate: zajec5@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=wY+VXtKo; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=R81UtwND; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TFf4J6xPkz23f1 for ; Thu, 18 Jan 2024 08:23:11 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=qvBPKVaGl/k1IER847c6hEaDwDDRKQ3vA6OvHFXorls=; b=wY+VXtKoWe4O8e ujkxWheDhkh8BR18srUlIdVlzZCZkK+h29xCjLoQsk0GhE1upBTayuxL6L3M7D8du3YuUP7MlmZTz tX6oWAub51dlLcA/OoVBGHPGscY3nLt4EM7VpVxzYSqIL4QEywNLNFxYRpTGceT+gvwIrN/0GkpFV mr/Df0eCC2CsH/9rjcnVBM9MLhN9fRe6j6OvvLJVA5eVyLW19uIeH+m+TNipC38gBRrs2WKF5jzDh iie23L8tTgRYnP5l3kFA93/xGls42k2Ifta9xyKHCi6lmRvfB1V9nUe52lvKVlMMXlbMTP3jFFP86 PuwiuCXcVH2lvHtxEsMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rQDKm-000m7F-2M; Wed, 17 Jan 2024 21:20:28 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rQDKj-000m3F-03 for openwrt-devel@lists.openwrt.org; Wed, 17 Jan 2024 21:20:26 +0000 Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-a2dc7827a97so449558866b.2 for ; Wed, 17 Jan 2024 13:20:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705526421; x=1706131221; darn=lists.openwrt.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=m7tmVjTVMViIt3nQbdgB+qhzt+U+GjMerRMqtsedBYg=; b=R81UtwND1m+MmgAIkzQadSL+N5lmuu1wMOU2TR21dxayWcgHB8mV08r8eKTcB0gbVT QIilp4QJsKi992LspnfQzroMsU7P91SJYvfWY0NAy/OctVdVNYse0IjLE66Od+Qeb43F O5M7cOlH3CDlCD2ddqxWJXY5uvcJ+TgkIi2ClIvNjMmxBgOXk9meKmTb/MLeMH9QEYmM mDk90SSMxTv6vH2SgjEgk3cL6lEzr6yobX4sH+scmGLtaGOajrvJJw060cBE8gne+k41 XpZnDZfrU3lW54NS9fGdRuC7i/zcIc9qBBk1kuLojSERJd4/CrWi9gqQ28yahlsNox/j UpFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705526421; x=1706131221; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=m7tmVjTVMViIt3nQbdgB+qhzt+U+GjMerRMqtsedBYg=; b=DE7OzrqyddbAKXzQQbaho/FzIpWrR/7GuHquwSHS6OEzTC0BCUZOcf9uRKHu0nKD1Y KsXiR5oibKPucHWN2nSrgVGyEUU2RNb1+wdSsx+qy6pAtkJa20P91beFtqCYzbDdzvi+ 1Ox0SlRQUC7KH4sYTles3CcgoyMg6IHo774jo5QwChOuuUH+FR4jX6D3WZ929RlCOtjm FlV13TXwBAjxsUX+OAxcIH0BPSC68T4PHLeJ6xvTfYDaiE1IfzoYJ1XiLCThvva9WhCd rKhscITShEf/QbUlcjRyTIWuKjyfPE/Kg9SOMjg6kMTMt3THNfSjGN7OMT/Eo+CdZU4H cdSg== X-Gm-Message-State: AOJu0Ywdj4XKMSMRyM65zcyC77fGyu4e8zQn40FqNPa7GZkZ+m+h/Wf/ hnVNydPNsRaaduJx1Naxnf9Kw6KpLJo= X-Google-Smtp-Source: AGHT+IHw8zohaglLr5s/mv+Hlh6kV5ts8ZA4vfdUGfV8PKfLsqvBvTfo1HG7SRQGsoeTpZsrevVnPg== X-Received: by 2002:a17:906:da04:b0:a28:125:8133 with SMTP id fi4-20020a170906da0400b00a2801258133mr4737511ejb.134.1705526421054; Wed, 17 Jan 2024 13:20:21 -0800 (PST) Received: from localhost.lan (031011218106.poznan.vectranet.pl. [31.11.218.106]) by smtp.gmail.com with ESMTPSA id ot8-20020a170906ccc800b00a28a8a7de10sm8247345ejb.159.2024.01.17.13.20.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jan 2024 13:20:20 -0800 (PST) From: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= To: openwrt-devel@lists.openwrt.org, Felix Fietkau , Daniel Golle , Robert Marko Cc: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Subject: [PATCH] mediatek: filogic: replace built-in Aquantia driver with module Date: Wed, 17 Jan 2024 22:20:15 +0100 Message-Id: <20240117212015.16177-1-zajec5@gmail.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240117_132025_101485_BC210610 X-CRM114-Status: GOOD ( 10.91 ) X-Spam-Score: 0.1 (/) X-Spam-Report: =?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?= =?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?= =?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?= =?unknown-8bit?q?ginal?= =?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?= =?unknown-8bit?q?bel?= =?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?= =?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_preview=3A__From=3A_Rafa=C5=82_Mi=C5=82ecki_Some_A?= =?unknown-8bit?q?quantia_PHYs_=28e=2Eg=2E_AQR113C=29_require?= =?unknown-8bit?q?_firmware_to_be_uploaded_by_host_system=2E_With_built-in_dr?= =?unknown-8bit?q?ivers_this_doesn=27t?= =?unknown-8bit?q?_work_in_OpenWrt_/_embeddded_as_filesystem_isn=27t_availabl?= =?unknown-8bit?q?e_during_PHY_probe=2E?= =?unknown-8bit?b?IFRoYXQgcmUgWy4uLl0g?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_analysis_details=3A___=280=2E1_points=2C_5=2E0_req?= =?unknown-8bit?q?uired=29?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_pts_rule_name______________description?= =?unknown-8bit?q?_----_----------------------_------------------------------?= =?unknown-8bit?q?--------------------?= =?unknown-8bit?q?_-0=2E0_RCVD=5FIN=5FDNSWL=5FNONE_____RBL=3A_Sender_listed_a?= =?unknown-8bit?q?t_https=3A//www=2Ednswl=2Eorg/=2C?= =?unknown-8bit?q?_no_trust?= =?unknown-8bit?b?IFsyYTAwOjE0NTA6NDg2NDoyMDowOjA6MDo2MmUgbGlzdGVkIGluXQ==?= =?unknown-8bit?b?IFtsaXN0LmRuc3dsLm9yZ10=?= =?unknown-8bit?q?_-0=2E0_SPF=5FPASS_______________SPF=3A_sender_matches_SPF_?= =?unknown-8bit?q?record?= =?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?= =?unknown-8bit?q?ish_an_SPF_Record?= =?unknown-8bit?q?_0=2E0_FREEMAIL=5FFROM__________Sender_email_is_commonly_ab?= =?unknown-8bit?q?used_enduser_mail?= =?unknown-8bit?q?_provider?= =?unknown-8bit?q?_=5Bzajec5=5Bat=5Dgmail=2Ecom=5D?= =?unknown-8bit?q?_0=2E2_FREEMAIL=5FENVFROM=5FEND=5FDIGIT_Envelope-from_freem?= =?unknown-8bit?q?ail_username_ends?= =?unknown-8bit?q?_in_digit?= =?unknown-8bit?q?_=5Bzajec5=5Bat=5Dgmail=2Ecom=5D?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FAU__________Message_has_a_valid_DKIM?= =?unknown-8bit?q?_or_DK_signature_from?= =?unknown-8bit?q?_author=27s_domain?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?= =?unknown-8bit?q?alid_DKIM_or_DK_signature?= =?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?= =?unknown-8bit?q?gnature=2C_not_necessarily?= =?unknown-8bit?q?_valid?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FEF__________Message_has_a_valid_DKIM?= =?unknown-8bit?q?_or_DK_signature_from?= =?unknown-8bit?q?_envelope-from_domain?= X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org From: Rafał Miłecki Some Aquantia PHYs (e.g. AQR113C) require firmware to be uploaded by host system. With built-in drivers this doesn't work in OpenWrt / embeddded as filesystem isn't available during PHY probe. That results in delays like: [ 1.588068] Aquantia AQR113C mdio-bus:00: Falling back to sysfs fallback for: Rhe-05.06-Candidate9-AQR_Mediatek_23B_P5_ID45824_LCLVER1.cld [ 64.526387] Aquantia AQR113C mdio-bus:00: failed to find FW file Rhe-05.06-Candidate9-AQR_Mediatek_23B_P5_ID45824_LCLVER1.cld (-110) Switch to module to postpone PHY probe to init state. Signed-off-by: Rafał Miłecki --- target/linux/mediatek/filogic/config-5.15 | 1 - target/linux/mediatek/filogic/config-6.1 | 1 - target/linux/mediatek/filogic/target.mk | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/target/linux/mediatek/filogic/config-5.15 b/target/linux/mediatek/filogic/config-5.15 index 8ba0b0efe8..783447ac9c 100644 --- a/target/linux/mediatek/filogic/config-5.15 +++ b/target/linux/mediatek/filogic/config-5.15 @@ -1,6 +1,5 @@ CONFIG_64BIT=y # CONFIG_AHCI_MTK is not set -CONFIG_AQUANTIA_PHY=y CONFIG_ARCH_DMA_ADDR_T_64BIT=y CONFIG_ARCH_KEEP_MEMBLOCK=y CONFIG_ARCH_MEDIATEK=y diff --git a/target/linux/mediatek/filogic/config-6.1 b/target/linux/mediatek/filogic/config-6.1 index 1687aadbc1..1eaf57b06e 100644 --- a/target/linux/mediatek/filogic/config-6.1 +++ b/target/linux/mediatek/filogic/config-6.1 @@ -1,6 +1,5 @@ CONFIG_64BIT=y # CONFIG_AHCI_MTK is not set -CONFIG_AQUANTIA_PHY=y CONFIG_ARCH_BINFMT_ELF_EXTRA_PHDRS=y CONFIG_ARCH_CORRECT_STACKTRACE_ON_KRETPROBE=y CONFIG_ARCH_DMA_ADDR_T_64BIT=y diff --git a/target/linux/mediatek/filogic/target.mk b/target/linux/mediatek/filogic/target.mk index dd4c4c1448..182b229db2 100644 --- a/target/linux/mediatek/filogic/target.mk +++ b/target/linux/mediatek/filogic/target.mk @@ -2,7 +2,7 @@ ARCH:=aarch64 SUBTARGET:=filogic BOARDNAME:=Filogic 8x0 (MT798x) CPU_TYPE:=cortex-a53 -DEFAULT_PACKAGES += kmod-crypto-hw-safexcel kmod-mt7915e wpad-basic-mbedtls uboot-envtools +DEFAULT_PACKAGES += kmod-phy-aquantia kmod-crypto-hw-safexcel kmod-mt7915e wpad-basic-mbedtls uboot-envtools KERNELNAME:=Image dtbs define Target/Description