From patchwork Mon Apr 16 12:30:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 898614 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IlYvgaKq"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="nJM/qpGw"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40PnmZ48btz9s1R for ; Mon, 16 Apr 2018 22:31:10 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:MIME-Version:Message-Id:Date:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=hx9YQaRO6+50xYuaCIzLcp0e764dCkzPkNJkozmWdlA=; b=IlYvgaKq+nlTgz Hx45ovE36rJK9cuEyHecIL+8SQzKwI4l56JiIJQF4EmGNDJCveiTefjWdfiqI4ynGozKaz4ZOkbh6 twm2SNf9z7fCpsfT+B0KilzCtymy3TFoGePKqDcmHwEFD3DM+TZQpx7dynQ7VA69sNEBwl6x2HID0 DeTZCmEk8V4BZ8wvEgNI7LED2sHjKxy/wg1XKk4M/D5aKQfXeudGYK8PMjWILC3U/73XvGuytJDkV qKahsROYzaM7E5vQ2+hF0UeCjUcm/OUyz8D/HcEKlgW4wdbIe+RIoAofu/RGXrWKPUdb9T0r/17Y8 xAJgGz/nT3kZSYClbpJQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1f83Hj-0001ov-F3; Mon, 16 Apr 2018 12:31:03 +0000 Received: from mail-lf0-x241.google.com ([2a00:1450:4010:c07::241]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f83Hd-0001f3-S6 for lede-dev@lists.infradead.org; Mon, 16 Apr 2018 12:31:00 +0000 Received: by mail-lf0-x241.google.com with SMTP id i18-v6so6755400lfc.7 for ; Mon, 16 Apr 2018 05:30:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=RLqIupRHb0CH7NaZ08uI+k5nizQwCujNIckE2Dtq8Cw=; b=nJM/qpGwm7rPfllz11PDHzodkIr+o8sENJR9cSLf1liPujL4DJrT5PYalAhyr94XM5 F5cRahAeht1bxV0lYPNN+oyw6BFDjOgV11Pjf/ms7e6ZzSJ6WVs6JdAPs/VRU9xJOjcY fihQ6pwy6P3idJmzb4pYXFDvFQNcZXcwYmpEfpvpm22c953QvEQhotuyYqYkorPEdwD0 Ij8vo/s7DU2TiXp39TLV5sMJ/MqY7sUxvUhF2bknHhUgfawUbiproZrK+p+SmoN4rGyv p0YrexouAIwlwck3XoAD0G9LtdtG70UgAM0QzWbsKymUJ1/FxseNXeQG6RwL90gjeEML Megg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=RLqIupRHb0CH7NaZ08uI+k5nizQwCujNIckE2Dtq8Cw=; b=c1y+xdIJSijmhKvbTS10+hcEyH++nR0STQod9/sYIsyw3RB73D70u/Mrb/Q+nuWQ01 hCYmEqqa66V//Jz7lnWCyHzYpEzSNzEkJpw/9GGbFGUyKfx0gRWKqYeoG3HnC9YDk3k0 N+dz+aEr/ylGM3SXZRrqtsTtcPgtZy4NxDBweZmhPQ/4NAGTJMlzPovF9+15SAGTlSAr L3MLxu0WfeVrWb2Kn052nCwUBLSxqW+8LEMVR6WEhCWPToJ9MaKft/IbHI6Ama2c9rTX ZV2hfIO069fAr9fruONJH/BaDbfTzbFfPjVG/G2zl12CEtHG5aQu6FulCnDIsbhA16Fy M7HQ== X-Gm-Message-State: ALQs6tBR36EWotd3dMxzHWQWJkLnYwppo2cayO74IG18tJC/C73xXIXD yWfy6W+ts+tHvOzeeP9zOQM= X-Google-Smtp-Source: AIpwx48JxG8FnHnfO9onVq9GhDC9qOsxvYs4xwGKZL5OGAnnovpf+xdeu5EKvVcTzcsturn1WrXhkA== X-Received: by 2002:a19:4847:: with SMTP id v68-v6mr606254lfa.63.1523881844328; Mon, 16 Apr 2018 05:30:44 -0700 (PDT) Received: from linux-795u.lan (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.gmail.com with ESMTPSA id v17-v6sm2844070lfa.11.2018.04.16.05.30.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 16 Apr 2018 05:30:43 -0700 (PDT) From: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= To: John Crispin , lede-dev@lists.infradead.org Date: Mon, 16 Apr 2018 14:30:12 +0200 Message-Id: <20180416123012.16778-1-zajec5@gmail.com> X-Mailer: git-send-email 2.12.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180416_053057_957646_54108F78 X-CRM114-Status: GOOD ( 12.51 ) X-Spam-Score: 0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2a00:1450:4010:c07:0:0:0:241 listed in] [list.dnswl.org] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (zajec5[at]gmail.com) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (zajec5[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Subject: [LEDE-DEV] [PATCH fstools] libfstools: add "const" to char pointer arguments in mount_move() X-BeenThere: lede-dev@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Sender: "Lede-dev" Errors-To: lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Rafał Miłecki That function never modifies these strings so it can/should use consts. It makes it a bit more flexible as now callers can also pass consts. Signed-off-by: Rafał Miłecki Acked-by: John Crispin --- libfstools/libfstools.h | 2 +- libfstools/mount.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libfstools/libfstools.h b/libfstools/libfstools.h index 0398c96..f27307a 100644 --- a/libfstools/libfstools.h +++ b/libfstools/libfstools.h @@ -43,7 +43,7 @@ extern int mount_extroot(void); extern int mount_snapshot(struct volume *v); extern int mount_overlay(struct volume *v); -extern int mount_move(char *oldroot, char *newroot, char *dir); +extern int mount_move(const char *oldroot, const char *newroot, const char *dir); extern int pivot(char *new, char *old); extern int fopivot(char *rw_root, char *ro_root); extern int ramoverlay(void); diff --git a/libfstools/mount.c b/libfstools/mount.c index 4dc6e3a..c7f2789 100644 --- a/libfstools/mount.c +++ b/libfstools/mount.c @@ -32,7 +32,7 @@ extern int pivot_root(const char *new_root, const char *put_old); * @newroot: new directory for the mount point */ int -mount_move(char *oldroot, char *newroot, char *dir) +mount_move(const char *oldroot, const char *newroot, const char *dir) { #ifndef MS_MOVE #define MS_MOVE (1 << 13)