From patchwork Wed Jan 10 12:33:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrei Otcheretianski X-Patchwork-Id: 1884967 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=ByCszVPC; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=QplWpisU; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4T96j137HXz1xqk for ; Wed, 10 Jan 2024 23:35:47 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=opeFEnFcTJiX/zLexyEntlCP33rTJ2kbY488v3pgA/I=; b=ByCszVPC7Ex7d4 5V5qNpvoOlUvmSgIct3TVss64OHx3kJz6EikGd4Jn4Y047jsqaiO1TtCRe1DAPYVwaukqU3tcRoSU CA+nOKhRgHTWlnPM36fIfgqnLXvNibMLdI3n+77rUqgQ11VK7tF7AeFXz9WBn6/KSAticqKqj7+xS B8w+8Mc2TG66YlBbVcTH24l9D22WfMCdMsyRenvXzB7640YiTqWfK1msczQZQOuRuKVJePaTDZQ4B n+NV1V+I+AMgkkf8uqtIyJkjt1hdy2nK1A4ID4FeMqrPS5mEu83gQ5izValFWzlsao9JfJ5OLR1jo /xz4ryqjMWkLbhdWFnsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNXnM-00Bjai-0L; Wed, 10 Jan 2024 12:34:56 +0000 Received: from mgamail.intel.com ([192.55.52.88]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNXnG-00BjZK-0U for hostap@lists.infradead.org; Wed, 10 Jan 2024 12:34:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704890090; x=1736426090; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=sh5oRNYzceYhsu2pqoarKweXr9+69fH4CjejS02RmV4=; b=QplWpisUecxVa4UuD3c5qc+0jqpk9R7cKtQGLQo6BNLBOXfR8gPf1+pR e4YRiPeZBZEIoqp9NrsZ0UoZgwn10KCb70Qcuc6YexPxR66SPksCjurEb sVOE7H5qg7NL6qZmJXZ8zTew594USWcQiOzmdFbe+QW5D7DX1zu+e2FSq PJ9xGZVFA1ueHuPvBWUSj9SnCzyH+Dsp01jBErBjf31jZx2aqrZqc0zxo y1z9n4z001uXse7DA8uaSo68bPEo7C2e6Mwk9UBPSAs3Ni1wHn+GyjMWh KgrwGRG6CoAkgDlBR7STaOD0tlGPZ9IS2FzJnmxvbqW5DNx104I5kE+D4 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10948"; a="429685782" X-IronPort-AV: E=Sophos;i="6.04,184,1695711600"; d="scan'208";a="429685782" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2024 04:34:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,184,1695711600"; d="scan'208";a="24256756" Received: from unknown (HELO WEIS0042.iil.intel.com) ([10.12.217.211]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2024 04:34:48 -0800 From: Andrei Otcheretianski To: hostap@lists.infradead.org Cc: Andrei Otcheretianski Subject: [PATCH] wpa_supplicant: Don't assign pointer to bool Date: Wed, 10 Jan 2024 14:33:59 +0200 Message-ID: <20240110123359.2312702-1-andrei.otcheretianski@intel.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240110_043450_973296_54A8F648 X-CRM114-Status: GOOD ( 10.94 ) X-Spam-Score: -2.7 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: As it may result in compilation error. Signed-off-by: Andrei Otcheretianski --- wpa_supplicant/wpa_supplicant.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wpa_supplicant/wpa_supplicant.c b/wpa_supplicant/wpa_supplicant.c index 134ba39c53..f988925c62 100644 --- a/wpa_supplicant/wpa_supplicant.c +++ b/wpa_supplicant/wpa_supplicant.c @@ -2014, [...] Content analysis details: (-2.7 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [192.55.52.88 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [192.55.52.88 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.2 DKIMWL_WL_HIGH DKIMwl.org - High trust sender X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org As it may result in compilation error. Signed-off-by: Andrei Otcheretianski --- wpa_supplicant/wpa_supplicant.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wpa_supplicant/wpa_supplicant.c b/wpa_supplicant/wpa_supplicant.c index 134ba39c53..f988925c62 100644 --- a/wpa_supplicant/wpa_supplicant.c +++ b/wpa_supplicant/wpa_supplicant.c @@ -2014,7 +2014,7 @@ int wpa_supplicant_set_suites(struct wpa_supplicant *wpa_s, (wpa_s->connection_ht || wpa_s->connection_vht || wpa_s->connection_he || wpa_s->connection_eht); if (!wmm && bss) - wmm = wpa_bss_get_vendor_ie(bss, WMM_IE_VENDOR_TYPE); + wmm = !!wpa_bss_get_vendor_ie(bss, WMM_IE_VENDOR_TYPE); wpa_sm_set_param(wpa_s->wpa, WPA_PARAM_WMM_ENABLED, wmm); if (!skip_default_rsne) {