From patchwork Wed Dec 27 14:45:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Elfring X-Patchwork-Id: 1880530 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=pZw2tuNS; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=web.de header.i=markus.elfring@web.de header.a=rsa-sha256 header.s=s29768273 header.b=H/m2q2Kb; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4T0ZFh2P0Mz23dG for ; Thu, 28 Dec 2023 01:46:00 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o41liZsEz8NPLioTTQnUwHy4Qm5fzy5c13R0Z39W+34=; b=pZw2tuNSd9C24U 1RgnYueluhNYZ+qIkA2LynirozMOqtC/URcyCP78hMSHnewkb2wJ0/xJvHuIVIgck+W+HxLLhCE1s 3+YAI0ibnfGdrdo3TnjdlSqiJvxH4Wkb+ZL7a6EaQzuCdgyH3pOJdkIlAHAOjeVwgx7G40L0jjXSM oT7wpTFgjFhgC+wmk5/PaHl15OBV1AO7sd7Ux1DY0UjIPtfEqFN8HfMQ0y67U79KztQGZx7dB2c57 RWLlKU22QyPpIzB0Sb0CxLNvhS78XunX62L6WL9nkBmnGtCzoIwmXaDGhSR13VCJv7tjVOUjFCdJs LziUnhWZ7v/SmeSJ/DsA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rIVA5-00Eqlu-1d; Wed, 27 Dec 2023 14:45:33 +0000 Received: from mout.web.de ([212.227.15.14]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rIVA2-00Eql0-2N for linux-mtd@lists.infradead.org; Wed, 27 Dec 2023 14:45:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1703688317; x=1704293117; i=markus.elfring@web.de; bh=t84TSl+EluuPPFuJEer5T9HrQmpz9O6xB+/yns+xpbg=; h=X-UI-Sender-Class:Date:Subject:From:To:Cc:References: In-Reply-To; b=H/m2q2Kb4PMC5SWfgWh4y4kWC1MkytkybccUGoogQu06U4j8fAwIBnZ2sg28HD28 Rry7HheBp8jVcB8aTAfBgqAlYxIFLOjEil5Jyn4jynQJWHjWZ5D7mzjvypV3Zbeb2 muVERTBMDAtTQ9CtIuWNCcBXbJxtBAZFJrQCp8Z6svtTKI3+cmRptxaWjEqK6sBot AVdbVW+T0lWyUDntX9U2rVd3mNrYD9O86cB8oSn76sfUfsai1LaxxCmvBz1JwNv4s sgmJb7nrkD8phbu8Fxg0n4xN5Zi8Y3hMBiLBDoK9akN5GaY1ZY0mlOsCmzc0Rgdes CrSAV/zXrqnPYeNs7Q== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.85.95]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MDe2F-1rR0020xc7-00AbzV; Wed, 27 Dec 2023 15:45:17 +0100 Message-ID: <56d92e42-db9e-4767-bcb1-9686bdf34a03@web.de> Date: Wed, 27 Dec 2023 15:45:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 1/3] mtd: ssfdc: One function call less in ssfdcr_add_mtd() after error detection Content-Language: en-GB From: Markus Elfring To: linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org, Miquel Raynal , Richard Weinberger , Vignesh Raghavendra Cc: LKML , cocci@inria.fr References: <74183091-4c8d-4c92-b3f9-cebaacb41efd@web.de> In-Reply-To: <74183091-4c8d-4c92-b3f9-cebaacb41efd@web.de> X-Provags-ID: V03:K1:DsSL0eMHaC2Rk2bw2q1D0zcazt2/fVc+/haL7c/aRJkCieBC1tt 0AXAwa47Os+poIspl2AHdEo5Z2KI+HFZ8C+kWvuMOXzmUi04y27MTHCaZ4S63IVf3/kQf3Z ae89RkE7EPfLGSuhxATXgiCcaIb7MRxaSo2mNdZwiFjvT9gfysj/3ZTtLca3OMFUHxbJkBE 0DH7shC3T+uLv9aVTo7Dw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:43YQzShyX3A=;Ym3MFRhSF+BgUSwIX1xJPMjb5eg OrUoJO8pr+zYBSTiBAAl7M1mwf/bpo/+kf4cCjuVBVsl/YRMGD9TNV0W4T776DTorY4brh61U KYwd6aAmS8KQ6N02Ucm4EXPyAX4qprD66QosY55lm/+2S6Yo464UbbDVYPrtDWxqUDUJ39Q57 bc66AUAd+5hHxQaaqoKhfO2zXFJjtUAoiIDNnVzvkz3Ip+eomd3i9vvKW6kGY8Uy9Gb6x49qy MYQS8cN/4ShzTEJ2+GAVbrE/y/caS6k/5+mWH3JobIXgJRy0zhCSnu0ugZmRiZhiXSapFv144 gvF2thSS4OiixNpQjohoLsCBC/mbjKUwuODFmhUuRIg99GU1rQFCR0rj4WwdoGTdJqW37lcVZ MmP2uhpY9YMS0K6ifMVQAEOMS+LThmtvMZJLzQM9vwiAEcIBLo+cg0pqUJIsqu2lVj3o6NbHY BED9msOL9wWM21z4YBe8QV1RrOXlKAgUidWGjFLG1u5nfCKa2xkxjQozsXWIxLMlCNiZZgI7J yg55oNgrWQwEvLI1AjX3svQ5dYFxK1uFQD8FwcsK17HX4WEIpBD4d9U8lAtPflEgVwx0ltuJW gznDq6fOUGvIRQ1gOfhLH0F04ZQSXmHGlFrRpoflaO9d6XAb1aQGPARd+diDnTko8kFeTbOZO IVwoLEvvuy2dW0DYQm+G8rAJYEXiGXnAWY+PtGBROxQcVlIPEqo1R4Kko2PjP7hZrU12FsrAK X6iTVqHqbRM900sJZBork0oNaiktsUPFW8ct62gnKrMU7/XSTB5UYZhmDScxQyl2Oe95csP+u bsduiDeYiwJZvOCTKqWSHpKLfzuAM7DzxBEpMBYJTkKBLz16ibxjz2b+n7IvERUF4EycU1B+2 kSkzyfVRW+M0GNoF12PsGlEtLixSxOW0gXe+SRa3G35q9BNoCvEVRy/V/y8tWCBRivhR4u3tB 2TuarK8cb68v5enFWHzhNPEB5oc= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231227_064531_056001_E9FC7C35 X-CRM114-Status: UNSURE ( 8.65 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.9 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Markus Elfring Date: Wed, 27 Dec 2023 13:21:52 +0100 The kfree() function was called in one case by the ssfdcr_add_mtd() function during error handling even if the passed data structure member contained a null pointer. This issue was detected by using t [...] Content analysis details: (-0.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.14 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [markus.elfring[at]web.de] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 RCVD_IN_MSPIKE_H5 RBL: Excellent reputation (+5) [212.227.15.14 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Markus Elfring Date: Wed, 27 Dec 2023 13:21:52 +0100 The kfree() function was called in one case by the ssfdcr_add_mtd() function during error handling even if the passed data structure member contained a null pointer. This issue was detected by using the Coccinelle software. Thus use another label. Signed-off-by: Markus Elfring --- drivers/mtd/ssfdc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.43.0 diff --git a/drivers/mtd/ssfdc.c b/drivers/mtd/ssfdc.c index 211f279a33a9..3ee8535d4515 100644 --- a/drivers/mtd/ssfdc.c +++ b/drivers/mtd/ssfdc.c @@ -332,7 +332,7 @@ static void ssfdcr_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd) kmalloc_array(ssfdc->map_len, sizeof(ssfdc->logic_block_map[0]), GFP_KERNEL); if (!ssfdc->logic_block_map) - goto out_err; + goto out_free_ssfdc; memset(ssfdc->logic_block_map, 0xff, sizeof(ssfdc->logic_block_map[0]) * ssfdc->map_len); @@ -350,6 +350,7 @@ static void ssfdcr_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd) out_err: kfree(ssfdc->logic_block_map); +out_free_ssfdc: kfree(ssfdc); } From patchwork Wed Dec 27 14:47:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Elfring X-Patchwork-Id: 1880531 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=zR5ht7W/; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=web.de header.i=markus.elfring@web.de header.a=rsa-sha256 header.s=s29768273 header.b=jb6FhMk8; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4T0ZHq1xThz23dG for ; Thu, 28 Dec 2023 01:47:51 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JWhGHVOgBczB2z7vixE2yX7KgaPgbDhx0xthwaHDTqQ=; b=zR5ht7W/69HkSj OZud0EoexxJXvXKvI/DWWvBLqNW99YpPvaJdUvw0bBg5IaZ3sThDlLjO/fdPHA7ig0h8/PFCuhLcT I5DsXFw/WMuJRkF7jSuByQ8UiS+2HzE9U0mXozGNTVSdNFRyQOlpTXhrW0/leWAj53p1yQ0GNlMtS JkWsUeZrHGlrKoX/yh4zpfb0cpsW06YHdWXHniig26PLFLxXkfP2821F7P2iBTPcUbNi808M+hhdv xss7+5BYxTyFvQOwzozGc4gpSfp5DuGItJ7Vpfei/cuh6SW5hhuWE4N33Czu1aYZSHf00kCwYIbfz TyM6icid6Pc6B5J3dnhQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rIVBt-00Er6X-3D; Wed, 27 Dec 2023 14:47:26 +0000 Received: from mout.web.de ([212.227.15.14]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rIVBq-00Er5c-1T for linux-mtd@lists.infradead.org; Wed, 27 Dec 2023 14:47:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1703688438; x=1704293238; i=markus.elfring@web.de; bh=ENo4hclmxFGh3SyuMn74xYfR6nPiZ/yVfNyShc6CWic=; h=X-UI-Sender-Class:Date:Subject:From:To:Cc:References: In-Reply-To; b=jb6FhMk8ncrUT/GPmfbCWFPh1XKG5v12rU5Yc3PvGZ4PRdtEYCbvFdKmgzlC3wTO GyxDflLMqLov0mle4NbmnDuOvKJB/M2LIxi+LxJFtZPoGCM67T+0TqoJFQDT/kzbL /P6N2vMjAwTXbZN0jD1506ss6uZFmP6TDF80FdAy3zaDdUKF/zedEH3KmmuiqV9yU b74B1JyHqelRQXLyk7WKXXHv98roR3Y5hRUF/ftrzysPsNmJWLrOElYdstfEs2adI aIAmLdogIKobhpVLtDRyyygEEPrezLFVbl/JyhLbwjhOyx5vy4MnWG9Hge+OH5LFu lIPYAtUUcatoIcRQ2w== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.85.95]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MActo-1rP3gz3l6G-00BSnE; Wed, 27 Dec 2023 15:47:17 +0100 Message-ID: <4045abdd-fb88-4c1f-a947-cdb3d4e59aa6@web.de> Date: Wed, 27 Dec 2023 15:47:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 2/3] mtd: ssfdc: Fix indentation in ssfdcr_add_mtd() Content-Language: en-GB From: Markus Elfring To: linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org, Miquel Raynal , Richard Weinberger , Vignesh Raghavendra Cc: LKML , cocci@inria.fr References: <74183091-4c8d-4c92-b3f9-cebaacb41efd@web.de> In-Reply-To: <74183091-4c8d-4c92-b3f9-cebaacb41efd@web.de> X-Provags-ID: V03:K1:OYIJmlZiVv3gMIO0Joo/qfFTlG1BRQ6vZQXJAYujZsR+yqMSQlg YUQ1u0jm8hFI7QwcNmMqIOGC1Yw+g5VgIXV0uFEhbxC11wtnsBvPNZj1dHfxUPdwAjJeLk2 YhOciknrWm6X7bCdFPLimteTNxlUTv/xalPSJTKhbzBq4Dg0GZAbecvv6x3Hk+9JbMU7IiH 0/VIEyuZ7Woycz3SOt/jw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:nTbrXtVW0Ek=;9SXT7VBtC7psLaI3e5DfbupJ4Xk RCauIZbHor2BgN+90TjGkfgolk1x3MF/bVcJwL1qziklyA+m21E4Aj2YM+YaMS1kYI1blUyhF Yaww5laVRJaJiSCHqahF6uhzpPGFZ+qg5BmPeVVJendUtGfZSr7F+vTVEdSEk3RoVqGP/dsqN t8Caq9vVu703baEUjFXaRTIyjNRP4djyJeaU4dxTPyA+D8YGkRrWdiJ5TNZ/sN6U6hInNMj/g psV+E5g5WUa02vmiNFBEaxL0s/nf45y/hKeQQq5FcNfA7gpZWRnwzqMbZG6x62yYw6/9cSAPg 0jIknk9zEyKSk+lcQ/Nz5JvUV035PSv27TPwTcw365zJpARJ3puJpANcyggg//tA4dnZQmV93 /OdwZ9M+8tB46fKGkR8P9XW59L2uYtWolYmQ5gFstKtYns2qBwJvGOEmw88Ug18rUbWgOvE8F O18q0kKwF+xSN0FdIgWcApb8Uv8BzW9RHDJQEdUVzDWAkofn2o+b3l0hkrVFnhzxzZ1WFUdxy z4HpN4/076xAjoRUjBuNGgUYyMAHudg6aysb8a98egU03qZLqNUZ2s4O3emW3qylLZvmPol7H bQBO7bdaEI0Mli+Fz88C6D1OQgOSk/UaBLmft160Ljeo9wnzA01Bz3tH2IwzsQhcN2AHs1zSB rOpyjMV2gXVpKvPF+j4KgRDAxyGISDZlu9q5ZJiqrcoD2IhV6K196SBK3I2WX/eQ83PQfjnQr VHCXQvrkl2rOOawe6AXcBbQMWy9Q4iRHIMaPSykrTfHBRoV3G20Y6IA3lfTpy61odxpopJd/4 u7ba2JmoBlOudkDe1x1h8X8emp8XrAUF9gpIJdKqzB/dv/oCl/pSTy2mcgj6qbcGUcgZxfqgW 1DKBHlgjCH7neJQvKjIXKBxOYQWWLEdMvRIap6uVnz1Hjrh/34T0vTGfrmRgQbJvp0vLjEwby vP0xtAIRKkTKmxR2pv7zSqF6ywQ= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231227_064722_798146_D41A2DC2 X-CRM114-Status: UNSURE ( 7.88 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.9 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Markus Elfring Date: Wed, 27 Dec 2023 15:17:58 +0100 Replace eight space characters by one tab. Signed-off-by: Markus Elfring --- drivers/mtd/ssfdc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Content analysis details: (-0.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.14 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [markus.elfring[at]web.de] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 RCVD_IN_MSPIKE_H5 RBL: Excellent reputation (+5) [212.227.15.14 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Markus Elfring Date: Wed, 27 Dec 2023 15:17:58 +0100 Replace eight space characters by one tab. Signed-off-by: Markus Elfring --- drivers/mtd/ssfdc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.43.0 diff --git a/drivers/mtd/ssfdc.c b/drivers/mtd/ssfdc.c index 3ee8535d4515..e6de25087647 100644 --- a/drivers/mtd/ssfdc.c +++ b/drivers/mtd/ssfdc.c @@ -351,7 +351,7 @@ static void ssfdcr_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd) out_err: kfree(ssfdc->logic_block_map); out_free_ssfdc: - kfree(ssfdc); + kfree(ssfdc); } static void ssfdcr_remove_dev(struct mtd_blktrans_dev *dev) From patchwork Wed Dec 27 14:49:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Elfring X-Patchwork-Id: 1880532 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=SYkVykdS; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=web.de header.i=markus.elfring@web.de header.a=rsa-sha256 header.s=s29768273 header.b=B+BAbipe; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4T0ZKw0PT4z23dG for ; Thu, 28 Dec 2023 01:49:40 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:From:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XOp5lCHozvOQvwx9Rzqhnq29dXiD3NN1KyT/t2NbU8Q=; b=SYkVykdSalf1jc 0Eg3TtGiCkCHN9kBQG+w8gt3KZ4c4eA1Rw2SVbBCaejAgEposa8FXn2fQix43l645/hh5BNAZbYdk gSAKqvkIHIdLZ8LiCBgiDPkIrJ02GzYTpQwd24roF25s4C3iFUYXU6ZXsNAV/31zck+SN8FD2xmWm BS/4z+/OaoKSInzs5Q/3wTlQ46sINr3v8TMMCKMDx2QPtT6OWNP4keTKwL5jBGGcKpg5mse+ULe00 twYjxpnrr+E7o4gKXb+MRKgzJol0pXqHw0/xVkYnei2VgYVl/AxlAGbq6rzXBeFPvY4kyhZsVEWkU uPRtKeh8IeiuTlMihLbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rIVDe-00ErKu-1a; Wed, 27 Dec 2023 14:49:14 +0000 Received: from mout.web.de ([212.227.15.14]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rIVDc-00ErKT-17 for linux-mtd@lists.infradead.org; Wed, 27 Dec 2023 14:49:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1703688548; x=1704293348; i=markus.elfring@web.de; bh=IYQuEfayrUaxsfx/Jht5MY0p8docH+bqlNNlyCEIxyE=; h=X-UI-Sender-Class:Date:Subject:From:To:References:In-Reply-To; b=B+BAbipeP3KqINA7LfE2N8dYMBZhYSXCLNfpEZBSeWcwAwn3E70QkJTZVye4RHwA LlNtzog6M/rH7TpsaARxjMRPf6zEhOFWmE/REWFJhwm0l7REkHswEAeeVbT7TtP88 9+9Qbqj39RnbtUfTNvSc9I5aa87VoADWiYs6dBpiGjw6I8xvg+TzpjLP88fvqB6ak 292GKHQ6CUVLinJSSITcafrSD0Qhiu50HhWUXEEQAe121BigwuQ+MAo8OhtjhG+KK BnLB1cTpw17P+OqWFqr/NzngHNGt7+XUXCXLr3FXWvF/TjWYPW/YJ29McTFZRPcLL zGt4ReFjlvTnmUzfNw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.85.95]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MXXND-1rkq6N0OPH-00Ytas; Wed, 27 Dec 2023 15:49:08 +0100 Message-ID: Date: Wed, 27 Dec 2023 15:49:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 3/3] mtd: ssfdc: Improve a size determination in ssfdcr_add_mtd() Content-Language: en-GB From: Markus Elfring To: linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org, Miquel Raynal , Richard Weinberger , Vignesh Raghavendra References: <74183091-4c8d-4c92-b3f9-cebaacb41efd@web.de> In-Reply-To: <74183091-4c8d-4c92-b3f9-cebaacb41efd@web.de> X-Provags-ID: V03:K1:8zji5qAAe4LlZRke0P8vuGVQD1GEZcvLMVstcHnKSL9+IC5mgZP ycBVYSZGO2wxFhfFo690DMK1AghOhBKC1a5WAdSxQ5XxrzNo+WGtaP6SdUmsPnhA4nxl7Zg t22zyHSgm9VugNHesdLoQLSkTDy8+bZ1LV2AqP0Dm9Q3tI71hiiFNqBAuWYLnb8qIYHY1J8 42BIvwpyv5qFEcXCAZ8+Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:qc2cGMeCaNY=;Kg8y9r64w9GnWCG2j/y2tgEmmCG n2ca4F0FCHJl7udoLTAbxgmKI4+Jy6fwTixt09F1OUqCdim90FuQxx6+HmNoDsPMLF5J8JbX9 MxNP4YluwxAHizivU+Iqcv2C1dw5eP1prOPOn1UQ9g+nN82WYU08P+9cRVkTbzRhgWh7XsKaT vvgdDsqAw9bPSiRTwauE5vm3KQgMmWaQZSC3dm6XsdbNlsnGmp4w2CTrFW6p+wbq3kUROk/l9 C+5YuVdJMRA5pzd/c75VxDm7RiA86ccKUhjyv7XKeW1Ba6Al+U3rwzZ6mobGm6ah9DVh/gwuu vaONvm3NL2PBm6O9eEkOf4iBnv4sU56YL9hSX64hRb10MNFbyTEBwXed2tS20GqI1hHmFkE+m RBsjnkEnpX+pQVb+4oIsjtBxXGhXCof9yLqoYBKfsAFDreOvhOUI3OSk1E9Y4Nxd3MOPZL8AF 5frOekBsKpNz8nFCGFcHNaUnJH57q4zTU8XLH1NzjvYUayeCDgqMfJwn3LJ5Ns/Jclgdj7jjd jVRFgss+2RCm63+xSN/4VMICXb2BqZghFwJWWlvpL7NmZq55botFn0DdBECgfECagO9npjvK7 IZl0yaXygiP0hAyIRbLzMgxK3jZRo5LSVabkulACO8c8orKOyywra7qUCSN1OIfWxiynHp6GG jZHsekzzMLhqHPtp+moZMYQRW45XnR+rg1UkcVf81tr7nYZXQbNliEoiOlgmQ10mK77DAtzwl 0R3Y3t143Q883AJSQmxrdq1UgDPPle7Lmsg37BEq9+zwK6o9Mx6XjQfFKRUjeaCuXgPtZD5uV /XzXR/OTtJ+IGwm2d1o/Zy4UZ3j4TxpfhTt1H36DSJP05gDOVjWQBljkSUNddtOhLPNw6TuMO lN7Y3X1QiC6oyClIBbIbXv4AhRo4eX/Det8uFfJe5fD60tbwltaEwtKfgduh8Xg4vgB+aNtjg X40p8A== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231227_064912_666002_ECBEF13A X-CRM114-Status: UNSURE ( 9.62 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.9 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Markus Elfring Date: Wed, 27 Dec 2023 15:30:06 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding [...] Content analysis details: (-0.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.14 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [markus.elfring[at]web.de] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 RCVD_IN_MSPIKE_H5 RBL: Excellent reputation (+5) [212.227.15.14 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Markus Elfring Date: Wed, 27 Dec 2023 15:30:06 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/mtd/ssfdc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.43.0 diff --git a/drivers/mtd/ssfdc.c b/drivers/mtd/ssfdc.c index e6de25087647..46c01fa2ec46 100644 --- a/drivers/mtd/ssfdc.c +++ b/drivers/mtd/ssfdc.c @@ -295,7 +295,7 @@ static void ssfdcr_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd) if (cis_sector == -1) return; - ssfdc = kzalloc(sizeof(struct ssfdcr_record), GFP_KERNEL); + ssfdc = kzalloc(sizeof(*ssfdc), GFP_KERNEL); if (!ssfdc) return;