From patchwork Tue Dec 12 16:39:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrei Otcheretianski X-Patchwork-Id: 1875299 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=HVhEwOkS; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=EnUbSJh8; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SqPVx6R0Tz20H3 for ; Wed, 13 Dec 2023 03:40:41 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=91Fbn0y6lUFhtI9TVK5nMzkT30j2tSQxG5wR7NfZn74=; b=HVhEwOkSd9s9B5 BBJlHIor/xjL/1EbW9HaYdZ7JOI3B1MjqSJvb8P8hhUwL9Ozz2hDfiHwE7OBkta56018cnqRmqHqh BJnsEvk97jUprNr7/MqdUhsimHNtLTkX6k3/CA0X6OWixe13+AJ9PtgxgUJpd08zewBnTfRHPX5+E a7NApI2Y/ijkpxietco26y4WK1VCwb/X3/lCTD6R0tHdYG7VhtBJSOFw81CpoHf3Lil9xt3qV4rBA WQAi3MKZy6pB+7VpOWnz6l3c3juSSGDwnw6uSK5E66pK79DH6WGJy+6lL7OoPiDpGKc2zts1z4lxQ OKeen85eapT4m12eesSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rD5nG-00CFoF-2Q; Tue, 12 Dec 2023 16:39:38 +0000 Received: from mgamail.intel.com ([192.55.52.93]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rD5nD-00CFmu-2K for hostap@lists.infradead.org; Tue, 12 Dec 2023 16:39:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702399175; x=1733935175; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=uvg78hrshutYK3J1qxf//989ohgquB3shwMbx3bL9VU=; b=EnUbSJh82lJYIFquHpeHPNWttEtQ7aWnz4fknQIa1mzEiqA13dyngwGq wATmn4R8BfyT8RguDc5CphGZMAW7XZAWI55pH/2AyKTEBmZ/UklUkmmOH wWioOR5TPj8lMjQbSVcuKl8wCQjlqbfmEeMNMmMlzcocKGNi0iC5W6MXm 25T9ZH43BgYLoPUFNhopjStDptcceEm3x0uQGlnH40iBrdJs3VSbwXvtu mgzYbdoz1S5AJFlqMxpmpv9sHYqRXclWWyU4zDTFUSqIsg6MZruq8qvEI DnUleiVggeFhVBU0/RGAU/l/xPWp2TEOC9W/wjxLQDHI54e/J4Q7WWbYM A==; X-IronPort-AV: E=McAfee;i="6600,9927,10922"; a="392006365" X-IronPort-AV: E=Sophos;i="6.04,270,1695711600"; d="scan'208";a="392006365" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2023 08:39:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10922"; a="839509421" X-IronPort-AV: E=Sophos;i="6.04,270,1695711600"; d="scan'208";a="839509421" Received: from rwisenst-mobl.ger.corp.intel.com (HELO localhost.localdomain) ([10.255.203.161]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2023 08:39:29 -0800 From: Andrei Otcheretianski To: hostap@lists.infradead.org Cc: Benjamin Berg Subject: [PATCH] AP: Do not include ML element inside per-STA profile Date: Tue, 12 Dec 2023 18:39:13 +0200 Message-Id: <20231212163913.230763-1-andrei.otcheretianski@intel.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231212_083935_798395_5E2ADFB5 X-CRM114-Status: GOOD ( 13.42 ) X-Spam-Score: -2.7 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Benjamin Berg The Basic Multi-Link element should not be included in the per-STA profile. We do need it on the client for a BSS that was discovered using an ML Probe, but we rely on the kernel to ensure the appropr [...] Content analysis details: (-2.7 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [192.55.52.93 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.2 DKIMWL_WL_HIGH DKIMwl.org - High trust sender X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Benjamin Berg The Basic Multi-Link element should not be included in the per-STA profile. We do need it on the client for a BSS that was discovered using an ML Probe, but we rely on the kernel to ensure the appropriate element is included. Signed-off-by: Benjamin Berg --- Note that this requires the following kernel change: "wifi: cfg80211: generate an ML element for per-STA profiles" https://patchwork.kernel.org/project/linux-wireless/patch/20231211085121.abde63d9cc6d.I3d346be0f84f51dccf4f4f92a3e997e6102b9456@changeid/ --- src/ap/beacon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ap/beacon.c b/src/ap/beacon.c index 935ffd25ef..b19be6bad4 100644 --- a/src/ap/beacon.c +++ b/src/ap/beacon.c @@ -799,7 +799,7 @@ static u8 * hostapd_probe_resp_fill_elems(struct hostapd_data *hapd, struct hostapd_data *ml_elem_ap = params->mld_ap ? params->mld_ap : hapd; - if (ml_elem_ap->conf->mld_ap) + if (ml_elem_ap->conf->mld_ap && !params->is_ml_sta_info) pos = hostapd_eid_eht_ml_beacon( ml_elem_ap, params->mld_info, pos, !!params->mld_ap);