From patchwork Mon Dec 11 13:29:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiang W X-Patchwork-Id: 1874501 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=HAbc+HUl; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=126.com header.i=@126.com header.a=rsa-sha256 header.s=s110527 header.b=jHqUTuHh; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SpjLC3pvTz20Gs for ; Tue, 12 Dec 2023 00:30:41 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=31m403tEWat/hMnaAMW5HHMhmii7PREs+tcTHlVRooY=; b=HAbc+HUlq53qjN GNTVctXwX2Om8rcE7jjxD0XT08TV3bSUoZraBHwxSGspKzdWg9U/lBGiPTjKkkARk1FsmllbD81zf Gp992H8WoS/0ZmOLDGKdfC+d8+oxJpE1vXGj3OUjZ2LhQdzkRfdpSe5EEHxMnCJ3XxhK/hdzbjwOp NpBStuLmAqE1QQ8o2iW1fH6w1whSR054ECr1WKV9i3NJ0cAWR0xAqJ0iTPMI2RUScVbPfpLuYma3N yNRNpFvarUc+qX/HRsXTcoGd5curNn9SYw0Dp5iWibB7vQRnQvgqss98cZbTMAF0pfYIqpUuvlEUA StHNJB+F7algiA64muaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rCgMW-004yEr-2J; Mon, 11 Dec 2023 13:30:20 +0000 Received: from m15.mail.126.com ([45.254.50.223]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rCgMS-004yDp-0r for opensbi@lists.infradead.org; Mon, 11 Dec 2023 13:30:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=OCKc6 /P6i7QtZ8rBHWh+Nb676j7JZ84wwU3l3HhpxPo=; b=jHqUTuHhNzYuMP2y1nsLy EWqwZPzlalkNPcaV752wzznCTiyWpmFE7TsRaXtSwC98PQ8TS6JdaDlKoZnOUND8 3XvfdapWnNzSmqEQ7LC6ooUPtR1bmcHv1ipE3Lyrc1ZGs6AAjntGqjg49b7FtTCh xwYMJo1Lxpzs74UhJ2MWJw= Received: from T490.lan (unknown [112.83.182.199]) by zwqz-smtp-mta-g1-0 (Coremail) with SMTP id _____wCHjtbgDndlsWkbDw--.16491S2; Mon, 11 Dec 2023 21:30:08 +0800 (CST) From: Xiang W To: opensbi@lists.infradead.org Cc: Xiang W Subject: [PATCH] lib: sbi: Simplify the initialization of root_hmask in sbi_domain_init Date: Mon, 11 Dec 2023 21:29:50 +0800 Message-ID: <20231211133003.1243458-1-wxjstz@126.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-CM-TRANSID: _____wCHjtbgDndlsWkbDw--.16491S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7JFW5AFyDCr4Dury8AFy3twb_yoW3twc_Ar y8Zw1kKFsxArnrtw1Fkr4rurs29w4DGwnrKF17KayUKw17Kw45Gr1rKrn3Zrn8u39Fkr9a kF47Gr95Cry3ujkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7VUjYhF7UUUUU== X-Originating-IP: [112.83.182.199] X-CM-SenderInfo: pz0m23b26rjloofrz/xtbBcwJDOmSQAcw1agAAsu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231211_053016_786565_5178989C X-CRM114-Status: UNSURE ( 6.61 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The original code has multiple conversions between hartid and hartindex. Can call sbi_hartmask_set_hartindex directly to avoid conversion. Signed-off-by: Xiang W --- lib/sbi/sbi_domain.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [45.254.50.223 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [wxjstz[at]126.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [45.254.50.223 listed in wl.mailspike.net] X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The original code has multiple conversions between hartid and hartindex. Can call sbi_hartmask_set_hartindex directly to avoid conversion. Signed-off-by: Xiang W Reviewed-by: Anup Patel --- lib/sbi/sbi_domain.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/sbi/sbi_domain.c b/lib/sbi/sbi_domain.c index 88d25de..4e9f742 100644 --- a/lib/sbi/sbi_domain.c +++ b/lib/sbi/sbi_domain.c @@ -815,8 +815,7 @@ int sbi_domain_init(struct sbi_scratch *scratch, u32 cold_hartid) /* Root domain possible and assigned HARTs */ for (i = 0; i < plat->hart_count; i++) - sbi_hartmask_set_hartid(sbi_hartindex_to_hartid(i), - root_hmask); + sbi_hartmask_set_hartindex(i, root_hmask); /* Finally register the root domain */ rc = sbi_domain_register(&root, root_hmask);