From patchwork Sun Nov 26 02:57:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Andrew Pinski (QUIC)" X-Patchwork-Id: 1868513 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=quicinc.com header.i=@quicinc.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=GXNh8AwN; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SdD1h6D2Gz24DC for ; Sun, 26 Nov 2023 13:58:27 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B74233858430 for ; Sun, 26 Nov 2023 02:58:23 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by sourceware.org (Postfix) with ESMTPS id 27ECB3858D20 for ; Sun, 26 Nov 2023 02:58:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 27ECB3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=quicinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 27ECB3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700967492; cv=none; b=IsxiliQF7C35wWJ+OQEhFmwRv5gz2T9BL+3mJ0DSpmKMKromMObDmZopMPpXckFiJVIU1qLWCKqtXl0ju7DT8u8ANj7v64h3HqbK/Z1SQsT53IQanMnlAH4w0wkABKq6sjRRApuFIt2w5cxIB6h3+4iUg3MG/1m6ezOpVFuyN6c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700967492; c=relaxed/simple; bh=XG8HKNe/qCWuzg+7lbu743YCfz6xTC/z8nE5hFcbYr4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=GfboHPhA2/rYRs2/mH7PrNu2+RAzJWg1wGK5fw2aF7McHZK1DFAi9//sIVI03mjJZtnZhdzzCxKJYY7nfr96M7BVXoeV1bS+BnqDx6TnU2NoD305AX4gwJGVKGPvyBx/aAdwf67nnJV4yKMs4HdztL9RXPXGexDdGKu7b6yoRnA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AQ2r1IO002113 for ; Sun, 26 Nov 2023 02:58:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=qcppdkim1; bh=asSLd5OBVcjdmVvK/8aGt6jEwtoankbjy8Hh0HAhlSE=; b=GXNh8AwNdiYh+/WKk2VjG9zOJSvTQ9unx+xUTQun6KqFlaSvC/p+Bm0DlsCclDwQkDG+ rOgYNvorxueX3fKrecJZyt6EG97JkAr0JqkZqLqlSzXMn/cBUlOwoLfCdYl0ne5HNX/t lRPsPVksuDjsP1XX69g4uJM2JHLLQZQJqch0clsEs6i3DZKvbsknH95bN00yZGahwqhb 4b3iW5Jh/xvBczIYypH/2Q1VR8A09GBxwSH63/CLuZhES6/2bw2ocnJFyL6HF2ru/1TS cErySCFRkghvoy1IWXSJ5+r/xFZenJOAHd6RXh9RUus6/dGNjjqv0eIii9+jI0fWSnFJ XA== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3uk88rhmw2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 26 Nov 2023 02:58:10 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3AQ2w9nm026763 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 26 Nov 2023 02:58:09 GMT Received: from hu-apinski-lv.qualcomm.com (10.49.16.6) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Sat, 25 Nov 2023 18:58:09 -0800 From: Andrew Pinski To: Subject: [PATCH 1/2] Fix contracts-tmpl-spec2.C on targets where plain char is unsigned by default Date: Sat, 25 Nov 2023 18:57:59 -0800 Message-ID: <20231126025800.1381015-1-quic_apinski@quicinc.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01b.na.qualcomm.com (10.47.209.197) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: KxHH5bz7P_U6Y1YXUWrp5SzlpFgFvzyS X-Proofpoint-ORIG-GUID: KxHH5bz7P_U6Y1YXUWrp5SzlpFgFvzyS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-26_01,2023-11-22_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 adultscore=0 impostorscore=0 mlxlogscore=838 malwarescore=0 mlxscore=0 clxscore=1015 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311260018 X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Since contracts-tmpl-spec2.C is just testing contracts, I thought it would be better to just add `-fsigned-char` to the options rather than change the testcase to support both cases. Committed after testing on aarch64-linux-gnu. gcc/testsuite/ChangeLog: PR testsuite/108321 * g++.dg/contracts/contracts-tmpl-spec2.C: Add -fsigned-char to options. --- gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C b/gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C index 82117671b2d..fd3a25bd051 100644 --- a/gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C +++ b/gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C @@ -1,6 +1,6 @@ // basic test to ensure contracts work for class and member specializations // { dg-do run } -// { dg-options "-std=c++2a -fcontracts -fcontract-continuation-mode=on" } +// { dg-options "-std=c++2a -fcontracts -fcontract-continuation-mode=on -fsigned-char" } #include // template specializations can have differing contracts From patchwork Sun Nov 26 02:58:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Andrew Pinski (QUIC)" X-Patchwork-Id: 1868514 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=quicinc.com header.i=@quicinc.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=NN3f71GO; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SdD1h6CFSz1yRy for ; Sun, 26 Nov 2023 13:58:27 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9EF3E385735A for ; Sun, 26 Nov 2023 02:58:24 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by sourceware.org (Postfix) with ESMTPS id 4CA493858C29 for ; Sun, 26 Nov 2023 02:58:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4CA493858C29 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=quicinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4CA493858C29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700967492; cv=none; b=kuBXDdCFrWSVGj4dqH2NhEhOF9Ws/SikmV80wfKxt1UjkGbtWqGo/h4qBTYNhXx3s+kjWWD3AGGgj/d2lYHaBtx+q30q4YGcO2ugRGFY/3djzpA/46UT+CewktSNYyocW5qTz5U9bHEP7Ugzc79yv2AlGWTp0K5pHr6XRzJiBDc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700967492; c=relaxed/simple; bh=OucEhTQxOoMdda44ctXGoKOSAkvEk5eTmUoJkzei9+0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=EbT+0nPi7TIGzNESs2xJj7aGO5sNC3Q7WcPmVzB6qJvKleHGEUpCcNziUq+wSoc6rW0ivKjlOJUJtca/RR6YecnwIYWOGTqY82P9T6OnT6UWfJB9haEEmVLEIxhUvn2p+FKrC3phfjdJFLsOCxTu0xd+SdZNSDliUrjptcVjYUk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AQ2ubLK019623 for ; Sun, 26 Nov 2023 02:58:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=qcppdkim1; bh=AWwpqJRFInnvM6dU3rwuPePm8Zi1x18RGxTySaEYH8g=; b=NN3f71GOj+ggPjrXWY/tuH/00EloLS+JKPfs3DrJQ/VTzmRV5leHD39Pd+ernzx5rPFV pUiFnxbEUA23gK5+5Fatnbcbq0Wop1n2v0csDXGl+sgSfEpi7GxOaX59dZ1cZ7rQnH3A wSQhFVPoEbyfcz2EQIDW9JJVnV9btX7c6hvWTIgsML085nUGMve/hz6iZXA0tjd3HuBs 1hE97Ro2hQLlcBMT9wEDSrtOt8VNMNfPfcAKYl6N6AuWcKo7BH++8MV0eDCUQcGmevlI TorR20RCYWg79xQb/r5hPEpj+Iob8pYprhGVECyyutVog4T9fXhFRVEAr63PiGJh217b XQ== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3uk69u9tf1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 26 Nov 2023 02:58:10 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3AQ2w9Nk021552 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 26 Nov 2023 02:58:09 GMT Received: from hu-apinski-lv.qualcomm.com (10.49.16.6) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Sat, 25 Nov 2023 18:58:09 -0800 From: Andrew Pinski To: Subject: [PATCH 2/2] Fix gcc.target/aarch64/simd/vmulxd_{f64, f32}_2.c after after IPA-VRP improvement for return values Date: Sat, 25 Nov 2023 18:58:00 -0800 Message-ID: <20231126025800.1381015-2-quic_apinski@quicinc.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231126025800.1381015-1-quic_apinski@quicinc.com> References: <20231126025800.1381015-1-quic_apinski@quicinc.com> MIME-Version: 1.0 X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01b.na.qualcomm.com (10.47.209.197) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: yWswLFx551qiFyBt6bdW023_WUAAZInH X-Proofpoint-GUID: yWswLFx551qiFyBt6bdW023_WUAAZInH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-26_01,2023-11-22_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 adultscore=0 spamscore=0 mlxlogscore=628 mlxscore=0 phishscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 impostorscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311260018 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Just like the patch against gcc.target/aarch64/movk.c, the issue here is the two functions, foo32 and foo64 needed to mark as noipa so that IPA-VRP cannot propagate the return value. gcc/testsuite/ChangeLog: * gcc.target/aarch64/simd/vmulx.x (foo32): Mark as noipa rather than noinline. (foo4): Likewise. --- gcc/testsuite/gcc.target/aarch64/simd/vmulx.x | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/gcc.target/aarch64/simd/vmulx.x b/gcc/testsuite/gcc.target/aarch64/simd/vmulx.x index 8968a64a95c..869e7485646 100644 --- a/gcc/testsuite/gcc.target/aarch64/simd/vmulx.x +++ b/gcc/testsuite/gcc.target/aarch64/simd/vmulx.x @@ -33,13 +33,13 @@ while (0) \ /* Functions used to return values that won't be optimised away. */ -float32_t __attribute__ ((noinline)) +float32_t __attribute__ ((noipa)) foo32 () { return 1.0; } -float64_t __attribute__ ((noinline)) +float64_t __attribute__ ((noipa)) foo64 () { return 1.0;