From patchwork Thu Aug 17 00:01:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antonin Bas X-Patchwork-Id: 1822085 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=YOcamLFM; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RR4tW6Xkqz1yNm for ; Thu, 17 Aug 2023 10:01:55 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 8352D61426; Thu, 17 Aug 2023 00:01:53 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 8352D61426 Authentication-Results: smtp3.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=YOcamLFM X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CAvJg1Wz-WZ9; Thu, 17 Aug 2023 00:01:52 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 8C8B461318; Thu, 17 Aug 2023 00:01:51 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 8C8B461318 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 607BAC0072; Thu, 17 Aug 2023 00:01:51 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id E8FA0C0032 for ; Thu, 17 Aug 2023 00:01:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id AFDC441774 for ; Thu, 17 Aug 2023 00:01:50 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org AFDC441774 Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=YOcamLFM X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 20YSRjefqXwH for ; Thu, 17 Aug 2023 00:01:50 +0000 (UTC) Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by smtp2.osuosl.org (Postfix) with ESMTPS id ECECD401C9 for ; Thu, 17 Aug 2023 00:01:49 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org ECECD401C9 Received: by mail-pj1-x102c.google.com with SMTP id 98e67ed59e1d1-26d12558d63so290033a91.2 for ; Wed, 16 Aug 2023 17:01:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692230509; x=1692835309; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=OazWHg6PPdF0yF+lsKU+mhLBL/zzseKbcnajJeOHYKc=; b=YOcamLFMuIsZKIn6xETWqnhisASNqD4QciRj0UKTKPG5494bILfVoaKKm3cvG4Ay2W LUBbaPXUCEIvz04mEKfv5iZ6lBGZUeHFZ4CRjnMPgkIaWnP7C/C1wtvb+0Zh/56eLjEz 3xTi0P03fFikuK5sGQFiaNeP7aPp0BUKqoeYMdsELJpcqse8CaUTxpwnVVRnLz9D3ehQ uKtq7v9xx5NViJUgMtM9IHw0Z9E0LvZdGm+to8DZf56UH++Z1TRUspqXMfgHatI8G0VC z7Q/yaUMeg+Zn65bURhIMkCTwT9OPVphyCmmt50CxFpQTYp2bH2T+6+AfuoILfYIHEKs yM3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692230509; x=1692835309; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OazWHg6PPdF0yF+lsKU+mhLBL/zzseKbcnajJeOHYKc=; b=DwNU2zCB4ZaaNxVjFtH+2qgP6fUXEBCUyVNhlkQrIaUzY16e/aIf90oeGGcLJtznyB iG4aV5wjt62c7xuKyrRJOKQHqAIHiYY3NEhEEef7W7Rly/mi1xeneHlqPHJnWwcPJdSW tGwvN8oYjYcX/yAVnYc6u/W/WeAhvCmUcChZ3QBgPogdfHlDWqacjnBLVBQ8oI17DqTN Q9LCe8SJ3qDDsCRTVioA2Dz4TtzAZBcJIV5LMdXWYzkNsQcWPwgKC3BnG5oNohuqi4W5 zniFTsPihNCaTQvyA8hazk2zzk7J/58Bm0oCi28dnmGVqzGXnNQQv7f4aLdcNI1FOzug RhvA== X-Gm-Message-State: AOJu0YxS0jbY1MXfWESpESA0YwqHQdM0mfEUl/+rG4Ib6Ujh5U1/UDi4 e7tKqVvr2M6SWWY3l/SVhmS68jKY0lg4uA== X-Google-Smtp-Source: AGHT+IFtzK8sloAZCjt4K4VtdPAdTvDAXtU2Hft8mhhy/BmJVZ3arNzZEtetcYhp2JYxsuXG93WpTQ== X-Received: by 2002:a17:90a:4b4f:b0:268:37b:a10e with SMTP id o15-20020a17090a4b4f00b00268037ba10emr2778856pjl.11.1692230508898; Wed, 16 Aug 2023 17:01:48 -0700 (PDT) Received: from abasYLVDQ.vmware.com.com ([135.180.227.212]) by smtp.gmail.com with ESMTPSA id o14-20020a17090ac08e00b00268238583acsm286281pjs.32.2023.08.16.17.01.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Aug 2023 17:01:48 -0700 (PDT) From: Antonin Bas X-Google-Original-From: Antonin Bas To: dev@openvswitch.org Date: Wed, 16 Aug 2023 17:01:44 -0700 Message-ID: <20230817000144.78177-1-abas@vmware.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Cc: Antonin Bas Subject: [ovs-dev] [PATCH] doc: Fix description of max_len for controller action. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Since Open vSwitch 2.7, thge max_len option has no effect, and the full packet is always sent to controllers. This was confirmed with both the kernel and netdev datapath. Reported-by: Antonin Bas Reported-at: https://github.com/openvswitch/ovs-issues/issues/295 Signed-off-by: Antonin Bas --- Documentation/ref/ovs-actions.7.rst | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/Documentation/ref/ovs-actions.7.rst b/Documentation/ref/ovs-actions.7.rst index d13895655..36adcc5db 100644 --- a/Documentation/ref/ovs-actions.7.rst +++ b/Documentation/ref/ovs-actions.7.rst @@ -694,7 +694,8 @@ encapsulated in an OpenFlow ``packet-in`` message. The supported options are: Limit to *max_len* the number of bytes of the packet to send in the ``packet-in.`` A *max_len* of 0 prevents any of the packet from being sent (thus, only metadata is included). By default, the entire packet is - sent, equivalent to a *max_len* of 65535. + sent, equivalent to a *max_len* of 65535. This option has no effect in + Open vSwith 2.7 and later: the entire packet will always be sent. ``reason=``\ *reason* Specify *reason* as the reason for sending the message in the @@ -733,6 +734,12 @@ encapsulated in an OpenFlow ``packet-in`` message. The supported options are: options require the Open vSwitch ``NXAST_CONTROLLER`` extension action added in Open vSwitch 1.6. + Open vSwitch 2.7 and later is configured to not buffer packets for the + packet-in event. As a result, the full packet is always sent to + controllers. This means that the ``max_len`` option has no effect on the + ``controller`` action, and all values (even 0) are equivalent to the default + value of 65535. + The ``enqueue`` action ----------------------