From patchwork Wed Aug 16 09:24:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Adler X-Patchwork-Id: 1821741 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::33d; helo=mail-wm1-x33d.google.com; envelope-from=swupdate+bncbclp7i7wwmhrbevm6ktamgqej4vyv7y@googlegroups.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20221208 header.b=m2FYhFIO; dkim-atps=neutral Received: from mail-wm1-x33d.google.com (mail-wm1-x33d.google.com [IPv6:2a00:1450:4864:20::33d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RQjRZ0L2rz1ygr for ; Wed, 16 Aug 2023 19:25:44 +1000 (AEST) Received: by mail-wm1-x33d.google.com with SMTP id 5b1f17b1804b1-3fe73990c03sf38845445e9.1 for ; Wed, 16 Aug 2023 02:25:44 -0700 (PDT) ARC-Seal: i=3; a=rsa-sha256; t=1692177940; cv=pass; d=google.com; s=arc-20160816; b=s9wpKsWiMWg2vCevORnLxBkasrjjOZQb4B2ITtfvw5Mn/bvyyzCBgdKfnwjdZU3hYJ NUjV9abP08xJPCSaUWC7PuTVTDQVVjJFtxFo3SqzZ1gCwlYuaEiADfujN1L4/NyiE43c dcncoWSg28Cg225X/QL5FpTwdx6rx6P109XeSQHf2ERdtob8+ROxv5DcXuWZSBPpFAMD REyIGqVlblsGH1NpDYNeJ01AppaXfVUUnbCzliWtZCBi0Z9scR8Vc5qZPZLVFspOfRrs vnt70K5kGShcXF/e78ALkovXQNNlFRSJmhHvZGXUf/qBY2M0Ko4b2K8H13xgDPvkzvso Q42Q== ARC-Message-Signature: i=3; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=k4AjQCixWGMmgEN3WWVewTc4IKdSY38qH+egbUx87UA=; fh=Kx/qaUBQq4aIkY1SoIKMx6P8QmNdACfl4f1zQHU0BKI=; b=EiTZBpGJTreq8onnL7UUp0zGkeRYiEEAZgS9GfX7noPJxiGg3nef/6zU0FOG5A4cdy +w9PwlhUFIR53oVm3WjOJl7xnROtAZxuY3QJIrN5jyklBdyBjrBXr/F5SP92wICyG1Ff 0N5zOb1FdzYwshwjp2ZslmU7Q3NV3Nu9xMD9Ua9gNgUMlCr/TbAp+M0iU9Gdo4elj9Ps cAc/WYETG4AHa4HT5wMe+uglwUOxDHEECTW83VvQymETTAEfouFoUP1NQEbnwGVsrnQK z1fWzoItoCopH5NozpUwxJb8xLoLrWeyLGrFoyQFAYieriXJ4SZYmTGz8dQyI85cEsVA 7cCw== ARC-Authentication-Results: i=3; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=z9MUd1FO; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of michael.adler@siemens.com designates 2a01:111:f400:fe1f::62a as permitted sender) smtp.mailfrom=michael.adler@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20221208; t=1692177940; x=1692782740; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=k4AjQCixWGMmgEN3WWVewTc4IKdSY38qH+egbUx87UA=; b=m2FYhFIOVdpOrILm+2nwlQ34mvSz4hZavApPPditv8yqTG2Bp9LEaTn8eeRFS/5OYq Cm3+8NiE8VHNa/AwRXAFUMQSReJ8Sbd1KpLRN+X/D9B01qLJn+uMIaAN2fF38IWgiyEk f/QyX+nyw8LUwgf8UsswBnoh67XRy+Rfy+VZDIKMM5UlD3Zw9sv6Hz3jZUpKChtvxyWW 05FjURI4z00nWXWdGxAiZU9gjBPGgc1xJehDfBZj/9JwZi1nTEVVCwcg0qge0lGufdBx maCqi/XX9MhLRa7czIKhJj2rziuMIKZKDwcp9ABWrjBakuDlZAC9mpCsb3koaNBtcmcy HQsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692177940; x=1692782740; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=k4AjQCixWGMmgEN3WWVewTc4IKdSY38qH+egbUx87UA=; b=AppdV/vPtjmkKEqTT5yqCi5VvbvNy2cnTil2U1ezSgEYI1/unvfZI0bHEK3xNIG/3i X5hp3Qk2j8QSwryU0Zpj3mJxRxcMlTGgcdLlFRPDaxYhpfDCUJ3f/0JKcMGNk81vh+Gh w3ZmNBqqUkUVekyKS5FWHmRZ0I0EfpqZCzOo3n0WQAvHJ8iNKe4YQNuysXkCv0rUuz4d MlWJ7Wd136nJYVgZPRkQU7WeGVJiIeVBuFDJ7DalWASBM6Z2O6fQJyfPloIwhdrZQpS+ tnThQ5Du4pswtM0fBeW0loy2qhUwEfZKT8HCiFAcSyXfQJ/M4A+5GZ01a4Ltf0hDeZvR 94uQ== X-Gm-Message-State: AOJu0Yz1aeThTCYop+4hrkOd6DO8o0Cf6gN4MVls4ITV9PNpiP3kBaVB mheIGWvJcghY4ogAKELcA0g= X-Google-Smtp-Source: AGHT+IHuGsscN8KKaUawmFf6jPWE2T42ggAcP4dR/zsMmIHWDwXYlBLzd/bgkiTil4RZiBGKnOmCBw== X-Received: by 2002:a05:600c:2252:b0:3fe:2102:8083 with SMTP id a18-20020a05600c225200b003fe21028083mr975397wmm.26.1692177938871; Wed, 16 Aug 2023 02:25:38 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a05:600c:46d2:b0:3fe:2d78:8028 with SMTP id q18-20020a05600c46d200b003fe2d788028ls2885178wmo.1.-pod-prod-08-eu; Wed, 16 Aug 2023 02:25:37 -0700 (PDT) X-Received: by 2002:a05:600c:3784:b0:3fb:dbd0:a7ea with SMTP id o4-20020a05600c378400b003fbdbd0a7eamr976564wmr.37.1692177937248; Wed, 16 Aug 2023 02:25:37 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1692177937; cv=pass; d=google.com; s=arc-20160816; b=e5m2S9Ge3sxdBbXpuD3HYAF+Aq4uzWGnsRQ1rFQueCHDgMqdLV9I5ZskoyZTlIEfwK 8KoM/c4Ons5doQi904+jlH1SBz/jSVLoFFUXciu6bnofpP3TrPddzKGfNiMwvNjx7Sa+ nJALd4c+rQ3+7zlsMEAc9nc9gy1VsJqIQuJ3QV8NOMbI7Nm+ceonww/Ej0mUGDzG7HbE zF//DMC5IMZCd0oWeeXNifTjWrQsNQz4Obu4SXL/w/Fo6BDKMaZXBr/06zX0qkZzIBQe eW6KH+VD0s0E1iJfF+mPmDrbn6UToe6Wzxc4iJaQViV1iOjJyDc5dnFwJy4HooR/K6Uo OUew== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=7ZC59mbYppToGuRRvLlI2H96BnvfyR88L6El+UseHgA=; fh=zDoa3cv2e04B0TI/AH7KhrV3mbhKigutYs4hkUXT9HQ=; b=tVdOQABeMSwaPcqNIONvBg4k7khhcgS9/OvKdogmQXsn3U39HTdLCuTF4q4B4INc4O TfJlG6D1X5DQsQGh8f60j9QhJdLO4PVJJIr79KybQAFx7iPzG5IEf15ZFBhFl2Z+YP73 LDkc6EguACJWUAvBMZOzBcJSiIZC2hIS2X88CgEVkBoPWEFaklyZwHHTgpAJioTFqxE6 owI+1WrCUnrybByMIs3pFHbk7Sd+l1b99YiIe8yr1X6v5qnllkxAMgv8atL2jMnehKnL DYnKA/GHKifW1129F2zpGnmJM2djBIes/v9PyEU0NijnbZ741Sv4HPOIEevzE7PG5rGa T3vA== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=z9MUd1FO; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of michael.adler@siemens.com designates 2a01:111:f400:fe1f::62a as permitted sender) smtp.mailfrom=michael.adler@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on062a.outbound.protection.outlook.com. [2a01:111:f400:fe1f::62a]) by gmr-mx.google.com with ESMTPS id d16-20020a05600c34d000b003fbf22a6ddcsi1390411wmq.1.2023.08.16.02.25.37 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Aug 2023 02:25:37 -0700 (PDT) Received-SPF: pass (google.com: domain of michael.adler@siemens.com designates 2a01:111:f400:fe1f::62a as permitted sender) client-ip=2a01:111:f400:fe1f::62a; ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H9GyHS1M+Dz5XdzOk6qypHMgBTHqV6iFreM7Fki2wwBx99AHeQOPnVAUV6Oz4X7FYZjH5rGmH6NEUDYZDtY00zEkN7dMHHftsMIQvTLTqaUaNU1E8ihJ9U02o3QeECkNz+9HiehcKiVXMnz3u9/KKblxKP2ZeUNhrLAIHnhA2xomrCU1jyE2azSjduRa9sTGIjoMylhyZB/yBVqFlJnqDSR9pYeM/OSN+0AKP8sLyS/YzRTrfmz+0C8j3DVVp9nK4Kl/1K0/ed+6oI2GQ5r1CSLsUbdXHW97MScMcVhCtF4C3i6uik8QxTpaFg4kTLwABQqgP/MuFW8TuDB3nCFPmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7ZC59mbYppToGuRRvLlI2H96BnvfyR88L6El+UseHgA=; b=SPys9eV766W4ytyLvNetvdDECxlNxHwQz43IOtO7oWzKg90hDQO9bNZJykmR5YgRepP/5D9eYCyddUJEAGpb6PLI2PphGe696fZEfN5QGWxDzKJ5yYUdlevPRg1IppbGTiO3ddaJHWpgrzrIblSlEYVFM3oIFi4XbXlaQYffasl5rXR4hbLNs+svQCn1nTXqjUZYGIBCLFaLU4goBZ+y0h3Uy04/Qk8EW45djRW2TjwDvIy5KZcHg/O4Tra/MAqbnBVGFB0plOeYsMF41SJbuE1MM9QreZ9b7w9G6TngKUz0/U0EmCK5+gBgqQwM/VH0wCVsIDQiS0ypASx8cwciDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none Received: from PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:12e::15) by DB4PR10MB7422.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:3f1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.26; Wed, 16 Aug 2023 09:25:36 +0000 Received: from PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM ([fe80::9505:a6cb:9759:b1df]) by PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM ([fe80::9505:a6cb:9759:b1df%3]) with mapi id 15.20.6678.025; Wed, 16 Aug 2023 09:25:36 +0000 X-Patchwork-Original-From: "'Michael Adler' via swupdate" From: Michael Adler To: swupdate@googlegroups.com Cc: Michael Adler , Christian Storm Subject: [swupdate] [PATCH 1/3] ebg: ensure env_get returns valid strings Date: Wed, 16 Aug 2023 11:24:22 +0200 Message-ID: <20230816092424.203252-2-michael.adler@siemens.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230816092424.203252-1-michael.adler@siemens.com> References: <20230816092424.203252-1-michael.adler@siemens.com> X-ClientProxiedBy: FR0P281CA0232.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b2::16) To PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:12e::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR10MB4734:EE_|DB4PR10MB7422:EE_ X-MS-Office365-Filtering-Correlation-Id: b87f0ed1-7f49-449b-a556-08db9e3abf79 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cC+fvIaQUhcj6qhv8bhtuoDCetxw4Oi2Nq0rHZ/GYTlGNM96X2tcEipVgR8cCKSbIndPhN0i+HEhG4ReRO/SCiujvKCfinTjUQriGWt3uyQMimGJM5QpnxGNcPsBkUoouGXtEv6vC2x46KEGcNfqJIpsPifE4Uu/kxMwmUAc3ApW5MHEI3cszk5nntg9AK2AEO87ooO7lwj6VVdwfCAmjw5sLEqLGBIyKVXeB3Nnud0s8YWjRS2dMjRA34oS10uJ3pdc8JC0JtvJG9hiDuFkkXKhzmJtEKgz8p/vFpEwb9Xsjc1GcZiwoJw6V1b3xRkRqMPKHgug7nu+j1f6x94StMDEdCGpU1Tr9aEkQGTY3A5eFoVjqmps28KhCipa/6ZNvIEWl/j/iIdR16Qg19kJm9VfSO21JiDy/l2ZOCFd652VdR3XiSxaBgSRiD9lpDYej2aDqMQeiOOWQMRnukSx12eIzwXm/iuOe+DSeAKcI/t0zkxbkNz0G/SpgujbZcZkjXEw3BSOMiLth8dWVtikYhqWIi0PL9YWjT8u1hMxhWjUV3sykN/jSx/VMPf7W/qL X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(346002)(366004)(396003)(136003)(376002)(39860400002)(1800799009)(451199024)(186009)(2906002)(83380400001)(4744005)(86362001)(478600001)(36756003)(2616005)(6486002)(6506007)(6666004)(1076003)(107886003)(6512007)(26005)(5660300002)(44832011)(41300700001)(6916009)(316002)(54906003)(66946007)(66556008)(66476007)(4326008)(8676002)(8936002)(82960400001)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: z12tzVgwVGbmAJT/akxxkvQ0x/l/EFMftYUl1t7zwpshTH2YESijN1ExHhF4bWhaeC8yRfkncYAJDOAqeAoF7V49kS05cFam/PRkFW5oaFfLT1+wl7793GI479cyRC4GYcm7cya2vCnMTkf4vpjYdo8Xend5zFObZ6jlqwqLfO6+YGhGcFkLVFsb+xJ4bRo0MoeJDQcepqlHbABQunrHragxbEs7LjgljbssV/TuYwZktJ++WWgPx6/AqDAwpl/yGCO11BDlUpqJ1a/OjxTNEnX2W+aoupgB/34eFMEswtnaQQtl6xw/U/gPK2XBYxqHzxG+bsSGGQ/mIEzdh4VG9HDz3IIub/r3G2h1yKYM1HzyhNFZauM3XDr07u1xrIeaSUcSk+vz6DfmFVPPYNcSJxneHBvvaxGDJv8inN5foOtwCuPgQTStDixJNZhGKO6INL3zF/AMFZ5M08ngfma5X8x4Nu867MXs+hlA4qbP61h7MbVSqK9XF8u+qQ0F7xgwe9GPueOvx8eYafnNtFovR74Zv9M0vFAsgVOIkMyYWI/ygSSYZV3wNkmmQnkMmDKSjIaD+lgsUmrS7qYMJP14hyBRGJu0RT6tG0gH8JVdZOMcCuPK29q5ytyreQJyzhL3XVEV7ISL+2bWBzK+SF1U8TViUqrpY/b4x8D+22LiRQTPKGTgFmn1c3Za4u8rmMQgIyVrW4zUlJayXEJeS788dUgJDwpzhTB+MmI0qqnkEnHokkAaao+vbJqf1augdtxp1SDRGzbtHSafrUOjCwwV67uLAe3MgPSPR5WzBzocwZoytJNb4YtAilsTi2+NrdNe7RXjTPpjTzpHkt9NYJKfjWPOHTaM5HCGG7ll9nU9V/g01zCEU4zmtm6vkxwACFa6WayZf3c4WXz36G3Gzc+wGyWbqA0TpB8LffiZErB0vsDAl0PaaX5ayzVDpbw0vUUpzULbp8RdDEb0PpcEyLKsDRZ0OML61dm6LyJtTv4/RoNoXE22/nUmk0ni+5MCDMRaLxoZWNC1W+e6pbnVZQvlJiQXLuwm6kwEzzEQ72y5m7T2KMj568IskXu3VBTuevegGIeL5OcxskGyw44YARyVNGa8jpnfPPyrjbVDRNHNauH6wibIt+sIG82wyTVJ1E6tkTBRYj1qPaZQHzY0hghiAuCHsJgwksTlULP9Hncch8dNGzrCb/Of3G9k9bVbwh/Qd6BkF48fUTOxjGCYh7IQ4yOSg0jZFbNwUhVtn9dRjvwa3KCnuVcrAGckpgBtNiEbn+ViFhkCu8MABwc+iMPT+fvbArGGSxBH3Cyjtn0qN7csO/grNGdy+X0Xvxw8lvB2Jp2lbeVsLrl5B0xVWEMfCPuOzeSLKF5IlcmWxp2zzLhAC2eXihJR8YUBB4RRlPidUK8Z8MbXyv5RGJA/OR3ME5DI9Yf77GKk3exRxZeoL/iLr8G4h67D/huLLkNUaqaXRgMhX1dPs0MfFLo4StPTl5So/uVLaCfvODAJ8dizR0TEiTC7BbmrJa2Da7Umql+xh054OegZpPSlPAbCwoVLQZGp6uiAaPvhgWrXKQcIJBPWm4nyFzDjCD1Qf+ddUibntT0ke3CaLElq94zYH83xRg== X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: b87f0ed1-7f49-449b-a556-08db9e3abf79 X-MS-Exchange-CrossTenant-AuthSource: PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2023 09:25:36.1411 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kDtl/wNTDYij4x3pv1OOifLYBeBokkPPcTC05vP1t5pXPKMsQrlztawQ2VdKPlbwUwF5ijV78F9qHCrBfovhu39WSNkWo3lsImHInn3O9lU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR10MB7422 X-Original-Sender: Michael.Adler@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=z9MUd1FO; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of michael.adler@siemens.com designates 2a01:111:f400:fe1f::62a as permitted sender) smtp.mailfrom=michael.adler@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Michael Adler Reply-To: Michael Adler Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , In the case of efibootguard, env_get might return a value which is not null-terminated because this is allowed for user-defined variables. However, SWUpdate assumes the returned value is a string, i.e. is null-terminated. For example, the Lua function get_bootenv allows to retrieve user-defined values. This commit adds a check to ensure the returned value is indeed null-terminated. Signed-off-by: Michael Adler Signed-off-by: Christian Storm --- bootloader/ebg.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/bootloader/ebg.c b/bootloader/ebg.c index 4064f07..ce7e03a 100644 --- a/bootloader/ebg.c +++ b/bootloader/ebg.c @@ -131,6 +131,12 @@ static char *_env_get(const char *name) free(value); return NULL; } + /* ensure value is null-terminated (string) */ + if (value[size - 1] != '\0') { + ERROR("Cannot handle value of key %s", name); + free(value); + return NULL; + } return value; } From patchwork Wed Aug 16 09:24:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Adler X-Patchwork-Id: 1821740 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::13d; helo=mail-lf1-x13d.google.com; envelope-from=swupdate+bncbclp7i7wwmhrbe5m6ktamgqerdozqua@googlegroups.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20221208 header.b=EY22/BAY; dkim-atps=neutral Received: from mail-lf1-x13d.google.com (mail-lf1-x13d.google.com [IPv6:2a00:1450:4864:20::13d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RQjRY6zzCz1yff for ; Wed, 16 Aug 2023 19:25:44 +1000 (AEST) Received: by mail-lf1-x13d.google.com with SMTP id 2adb3069b0e04-4fe356c71d6sf6225875e87.1 for ; Wed, 16 Aug 2023 02:25:44 -0700 (PDT) ARC-Seal: i=3; a=rsa-sha256; t=1692177941; cv=pass; d=google.com; s=arc-20160816; b=lhin1xtvZ+0g/qxBXEN+K//yvdNHDfT8/ezbsLL5pKorga8ISMVxgAjRIsTYAzzDo/ OuL0W/Z+F6IkbvTZnCnLCu3169PnatXiDv598g6ac3Tq3qKkP6zGVUYZ9VUe8uZl8PYy e/ZhmcqER6LkZmyzVIj8q6V5cgsXG2ijvI360FVZUJf6juxGIV1g/YCaMUzcOJ1P3d/3 Vi2U6uPr4j4n29woRqBlqq1tnRJo7+BWF+7JMIpWkmCI0BE2C3gshOpM7F08Idi30obk 3WLuvNVxH4j8bwFtA1pBVUnCySZe++Yakak6etTMv/CAF7k1R3X4V6Py/v0J4Ox+NZ2r kRJQ== ARC-Message-Signature: i=3; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=vTip8EIw31x5Rn0t/xhzRGJVaWgFJqRjAzHmk7/21Ts=; fh=Kx/qaUBQq4aIkY1SoIKMx6P8QmNdACfl4f1zQHU0BKI=; b=GxmWOauZWA1Xasr5pCfK1Y8OmKCGnwcPmutlTj1ewpNLdY2LUK9kuDzFfHSlFVdaKX 1ZStYxUATzV6Y1d5qm1VfX/qdRp89Wo/yvW/ExR38oTk4eDfjF44VdAZP4y8fVp+3Y7Z +YWTZPjWJjNcpiSZbHPabwUYmxdMhoztJhAhs8aEWLa9sKd5sNq/zS9VWuZ5GUuG9FuK CBhbQJcNgO4lnb/omrSD2RzxEuZstU89cOFoJj3z5mUWTQlqTO+QOCwiGDIN0a47TBTx EIYezUVDKktGMvR7WCDnK1t1wb46z5ham6RvdMKcEXerAlEsoj4R/WNFDSD8UqV6gQxG rLmw== ARC-Authentication-Results: i=3; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=z30S70C5; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of michael.adler@siemens.com designates 2a01:111:f400:fe1f::62b as permitted sender) smtp.mailfrom=michael.adler@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20221208; t=1692177941; x=1692782741; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=vTip8EIw31x5Rn0t/xhzRGJVaWgFJqRjAzHmk7/21Ts=; b=EY22/BAYh/gyUil1yP6t8+jsNFs0m9+imwDcLROWpFzxwsYusvxVV/UIhrPk/cXrbn MARQz3yyXXaPlMG6ZMznQC7pkY7qSlXovCLD0I6AsdbQUHDeJsn+iMhhBBrB1Es2sMS3 xs27kKs1wiVQrbjnHgNDNThbiPThY3a2MgsRNbOZNHAMoJ43pMTLRnZlMcjgPkWxG61V xdbsSoecY+NyAfmUWEhfJW7ykDVXGU4Pc9o3KCEc0Y+yx8SY3u5wKGV5poJnw3Fda6rG eA1Yh4zkZWRmkYnc0feCQu2Yq2f17jYiGCdlzW4E2LPli1D2WApFLcKxndysX61N3RbY BJJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692177941; x=1692782741; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vTip8EIw31x5Rn0t/xhzRGJVaWgFJqRjAzHmk7/21Ts=; b=FI4dAolmWEEHXY3rwWHnf/HshzAuXtPvoiLrQASAjXHDjCyUe2J7PWNT2D8VhjWm+2 op1GzS3lDAzsPhitQl6EZUT+2u24sZEpt0R8gxNnqZpmo9qTtxgomLQCm41nIf6EZSh9 0dcM871YQ0YZFZJJir/+GnoZf0glmkxLhMxsz1V7PRFSYNbeoEX0jWpCqACLMUfp4tsh q8FC0x8KdoEDUxyD1Oh+okF23oLIBElTgGP5dxafpxRg8zob388MyRhspDp0Ie069IQx Qx1sVX7OcReiCpAavwCvlYl5fAiEKKHBqP7wu0aMCyJ5Nqs3KTZyUbL5jQbobzkt3LQH 3pEA== X-Gm-Message-State: AOJu0Yws1A5JPp6f9WXxGAZkKpMQ1Wv4OfTYg8PdFqf8Kbfk+yn8YVAu f4CcM7wtj1PX1QuzjM42BFk= X-Google-Smtp-Source: AGHT+IF/cmKdUpfcc+EvviChtaakaQXuygFgc4G5VIfmhl7oX6z7SJZYLrjXjTrTcMin8eLAkfjt3A== X-Received: by 2002:a19:5042:0:b0:4f4:dbcc:54da with SMTP id z2-20020a195042000000b004f4dbcc54damr1013630lfj.27.1692177940140; Wed, 16 Aug 2023 02:25:40 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:aa7:de84:0:b0:523:2211:d12f with SMTP id j4-20020aa7de84000000b005232211d12fls477753edv.2.-pod-prod-07-eu; Wed, 16 Aug 2023 02:25:38 -0700 (PDT) X-Received: by 2002:aa7:c2d1:0:b0:523:4b92:9cf8 with SMTP id m17-20020aa7c2d1000000b005234b929cf8mr947325edp.29.1692177938289; Wed, 16 Aug 2023 02:25:38 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1692177938; cv=pass; d=google.com; s=arc-20160816; b=AxwVPjloTcw+bBE6IU+blv/c5LqxjRFne8Su+sD6ghzjNxQFhlGlWxYT+hoPuQqRjx BWP8Bjvn67kEpH0KUW2twqc5SXPpsYhXaRjl8UGALiUqtIoD8sEWvpRUIDFQrr+fRHIL RRhRYWFd6ue+yvUrVQ+JVDtNQTYpZGgXGMd7E0AlWUyQqMS4k+wEPtXNX3DljT6obl2d 6yUEt2/3qxQHTGz7CcIPU1XNAshSxNm2EiD2jqJIOhBODfXBE24gl9mIc+0YEhSab/XY N2hQJxPSQuyDnKfJR66E79qhR6pwk0OJWmz1XlAZxFbfUA/paQYAfmtNbPh3sLfIq29Q tsfQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=LAUtYUe8xZXmU6WdgtR5sdnSvkUHdfH8R2sql1L8RNQ=; fh=zDoa3cv2e04B0TI/AH7KhrV3mbhKigutYs4hkUXT9HQ=; b=ZwnqBKpYfY2c2eZdIS0WPZ9y9PtJ+mzS26N0jBSmnkso+2JhCyHO+PrXnVcBhqsZxQ QzyC5Xq5eceHai0YoBkS1NwEnSJUaiid0bJgU2hq/enh5NKkaUiRyU5p8A16aunlDJOZ Xw9TuAOm1KuVjp/qM9ATdVgr2sK4QtOB37zC/OfFhSorPfOoWfQ4Hf9AUK19TTi47hht nuHrMUltcUAkyxsYKb/4GS2wOf+13Voxbuyd3rcDNLO4fxKCgvbVrHDb+BPiACIhPMVn ojd1SnUCMPS9VqFYwIn6t/5aPTJTKwanLk9QoBWK/MWZrelQJE3KtoE1+V06miPSNAu/ YeXg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=z30S70C5; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of michael.adler@siemens.com designates 2a01:111:f400:fe1f::62b as permitted sender) smtp.mailfrom=michael.adler@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on062b.outbound.protection.outlook.com. [2a01:111:f400:fe1f::62b]) by gmr-mx.google.com with ESMTPS id i25-20020a0564020f1900b0052174fd486fsi1264571eda.1.2023.08.16.02.25.38 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Aug 2023 02:25:38 -0700 (PDT) Received-SPF: pass (google.com: domain of michael.adler@siemens.com designates 2a01:111:f400:fe1f::62b as permitted sender) client-ip=2a01:111:f400:fe1f::62b; ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fwC/J3NQAKEznf1yg2RDO9lLSjC9ZXkA+eJxGtyhXkUXlhjVAI/v3e0I0g3Dvuq9HfN0uA71mMDznOzwKW+X6qoPGuUX4/qrw49Ekptuj8dRVEwCeaz/QjWJeCYc6+PWYShYOEh1yIbM5LV8nU3XC1di8lG7TRwFOzcAMOOIxv+2K/NIs/KbwgWR9F5s+B1GZP1JFotAqyNSwMuqV4gUu3vfPgcrC3ApC5S5hecCZW7nN6CIvzt/qRhAc8XXvifX6haXRI19mI+qcjRha1maYTnF32uHroodFjxDv3V9uRnKhrsyVqyBOELJFLGNk6rDl2woFyCcYI/IuHMux4PUuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LAUtYUe8xZXmU6WdgtR5sdnSvkUHdfH8R2sql1L8RNQ=; b=calJDsXhISAS0+/DRjI2/a0fIJ9Qz5BzqzXtvZsHgH4EiA+iyAZxIJ/bwMzqXPe5TzmOsRbmEPi7MCbmeWNKEkuYkD4IJ0XShL21roQ3ubvhC8bCCZ9CZ4aKSAePuDnmIKaIrgWRnxCVMIzPnzJja9IR8YljMLik43u9QiYKfRiRAW6LOvK/kiQ9uxodEdcTahXXzRFPJB9gFa1jkHnMYd1v3uaYSnpthhtF7PF4QjYI81/q3/w5lvO0ilef10XddvVBUwO3Yf4lkZdaOaYOOkckj7nGXEQcCoMdYXWkb/H/CYajrpI6O+91TabvdDw/+Un85tvwdNtigIDGgxZVxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none Received: from PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:12e::15) by DB4PR10MB7422.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:3f1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.26; Wed, 16 Aug 2023 09:25:37 +0000 Received: from PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM ([fe80::9505:a6cb:9759:b1df]) by PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM ([fe80::9505:a6cb:9759:b1df%3]) with mapi id 15.20.6678.025; Wed, 16 Aug 2023 09:25:36 +0000 X-Patchwork-Original-From: "'Michael Adler' via swupdate" From: Michael Adler To: swupdate@googlegroups.com Cc: Michael Adler , Christian Storm Subject: [swupdate] [PATCH 2/3] ebg: detailed logging if malloc fails Date: Wed, 16 Aug 2023 11:24:23 +0200 Message-ID: <20230816092424.203252-3-michael.adler@siemens.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230816092424.203252-1-michael.adler@siemens.com> References: <20230816092424.203252-1-michael.adler@siemens.com> X-ClientProxiedBy: FR3P281CA0177.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::14) To PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:12e::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR10MB4734:EE_|DB4PR10MB7422:EE_ X-MS-Office365-Filtering-Correlation-Id: c7cc9de8-bc30-485b-380c-08db9e3abff3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bWZP1Bqro/L9a0F+BFL5AmhQHEwhC/z1uZqmXStdNxlx4YD3QpbQBtDgGfQwMl1aWHOQg0KxvxDPfuFUfay5VN0xBFLjMLj3RKfq1lPAfQRnz/STdTA7/ntWZ0BGmgdpH5Q2KrhoY9nDIN8eLgU0TBIrbFiglLiVQP5YFP8kK7AB6Lr+UXQiZCufBE9YRG1zBBKu2hi6HYq+iNQY6zA8W4Q3P5Q/NkdRQYJIyxDHsghVgUvfUB6bFtLWJT8lIKalp3yjaoyG42fI0qCoUkD2JCV4zAGNvBfiwnmC02n5UlAb2ALgTNriUPffee6/XfmRMhDt7fwM1SohIP5/kg+lfETSs7v5hj+FUy9RgiCgsAJ/AhlHMNeC4Txfn0MgNbihRnXc+wF7u1U7sxcjucw/mb/PU1EDSR1iiCyFomYXkxG/gozcRchAK8PQzlKYcxLAG1wwom8dphhvsAVvWPMNzwBLdHAXq9a4J0S6va+vI+XrHtLPs7W3Rw03G5xs/8vuDj9bvv6cCTljBe5bPzKaRPquH9fRZTnjoOIqKf/1mcW3GgIQllSLd8FH9oq6VnIp X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(346002)(366004)(396003)(136003)(376002)(39860400002)(1800799009)(451199024)(186009)(2906002)(83380400001)(4744005)(86362001)(478600001)(36756003)(2616005)(6486002)(6506007)(6666004)(1076003)(107886003)(6512007)(26005)(5660300002)(44832011)(41300700001)(6916009)(316002)(54906003)(66946007)(66556008)(66476007)(4326008)(8676002)(8936002)(82960400001)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 8/9aTjLQ/owxoXLEvQzApy8VRwBm+nX/FvMpUP8uqmR7MHz+jZ5BZzTubq08uj8qi3BF/LTWtJGZj4mrDrZ9ZgseNRAzSI/K8tuEI4tzBFcrCKCTM+KbybnlZmXJbmkvCJ6JnDymxigMT844+OrSaw3j6jzmLcZX6nizaEJLgKC5Fq/vKgA+VaBXUdFI0dx3j7yBbiRPzPAz5B2E0OxL9/WUoUrmfW2aWntLvBvKO3DDW+KzLMgYlr+jUyti2RFfg2UU5A/xONAYlyZCYzrgZFgAW+NFiAjd0JBIIHf7wmKs6RV6PGas/Ryq3J5efyWKJuO4jiMhc0afIvlOYW6cVJVE/gJh65xhsvjHel+R71eqV4bKYSTOma8RjgLwfwgS15YuMin8dEBKYOy11HXXs0/Ukv25CwwlUjgkSHFnNMC9CyCRCcON9jhSQAywlAXlrtkm+Kt2YCn7aN9EaJzD2gdYx+kLUMBH+36TD173qz9WffJ+/BO7+LEsg8bPZW+LepJxr/C9fJs+ogi6Z8pqNlZxDQvNhvWPlfle/Zm2xgk8tDJtedNCBmgCdLYt/vUq/AboZ7qGwLOTq1JorkkuAxnnCJDKxwZgOh0RMv5J/yCcmgiJ7v/oH/R1YQ7lB2blbev9i+JirPgrf2W0vsntxWR9TFSFlM1eByhyckdOH1bF+5hPZAejF23R2V0jJrrTov/i7BvxP4CjjGf2FYge5sUIVj6OWt/4ftY64j7Pf94l17WEkIxPCICrRam0tr/X2Ts2xsL9OsbT29Xs3BGl6cZpzbZd6XgNJg0VF6MjyjTGghyKqZwKYuwYaWRCoEy9Q4oH+xJlNE1GzkqT/B9rLXZn07q+dX6OkOIvgtX1us1jn1CIGuiKRXnrgQuyN2k9uV589fE9u8DmEHesasPc/33nn22oPBjuKJeauKZO6/1bqsIoW8TtZ2xBcVMk+0CoDLDNbMB3QjUl9V0d/1qhOiqa+A790w1sPyd3b9rnorEJALHrI5qhobkU2eYD9TXzp8/QU/NoXC9hW/KGX74JmAL9AyP78eiMOMRc/ys5APdENPdsFmVntG/9OErYaU5Q7sEB50Q4RjNmPSXIgN3dsngp7Zo+eXkTCFtBzgDXyNm6+pp98A6RwJYNYLayTqAmRc55wBS0nHyI2Y5fkoSdBHQuKztlYpliLZ/RMlNtS9ixjgCo+CnorvXkrhZFSngyjyqDobiU8tFStR3C2RzECalEm2yIT5Oz+KuwIU2pqa2vxsqNNOwILLBlbxa572XBpq5PjTyTdp5p80eMhXnLwtFnj+JPMuZFiazgACuC1nbdgPUSxdhPsIr1VKbc2T0RQjZdm1X+SuAIhxUYxvHQzuyLZMcOTyb2jsGCjoOje9X03sj8FI1Ru8f3jgUyY0mlS5McdWnaKl8I3wT2WFiuVBDIHuHHx8OEYD9TY9/GCvlzfLcevbfhewlM7Hg9J/TGIqC2U3GtkC5XYoXJiFhms49QXqXYKkIxgFmpYvcrKxRHY1X27HyX6idVmsTHshEl4zIphHXXms5n1c8DjW7CLOVrtF/HaemlIiwT3JB8WCEeqYluxyUbgXRb/X8Pr4/WVxUesq97cZp5zMAOlYK0cQ== X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: c7cc9de8-bc30-485b-380c-08db9e3abff3 X-MS-Exchange-CrossTenant-AuthSource: PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2023 09:25:36.9506 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fUzHShZfQj1gv+UPjneYYLC8G6TtvWsXMLytDWBC6j/n8ZLENvg0ZQUD17rdLxMa+GeRrCFkrMqYGuT0Qugb09FnaxJc76An4i8CTBT+EqA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR10MB7422 X-Original-Sender: Michael.Adler@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=z30S70C5; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of michael.adler@siemens.com designates 2a01:111:f400:fe1f::62b as permitted sender) smtp.mailfrom=michael.adler@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Michael Adler Reply-To: Michael Adler Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , If allocating memory fails, log the requested memory size and the key name. This helps in diagnosing problems. Signed-off-by: Michael Adler Signed-off-by: Christian Storm --- bootloader/ebg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bootloader/ebg.c b/bootloader/ebg.c index ce7e03a..76a1e28 100644 --- a/bootloader/ebg.c +++ b/bootloader/ebg.c @@ -121,7 +121,7 @@ static char *_env_get(const char *name) char *value = malloc(size); if (value == NULL) { - ERROR("Error allocating memory"); + ERROR("Error allocating %d bytes of memory to get '%s'", size, name); return NULL; } From patchwork Wed Aug 16 09:24:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Adler X-Patchwork-Id: 1821742 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::23a; helo=mail-lj1-x23a.google.com; envelope-from=swupdate+bncbclp7i7wwmhrbfnm6ktamgqeitxszia@googlegroups.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20221208 header.b=TXljUr5J; dkim-atps=neutral Received: from mail-lj1-x23a.google.com (mail-lj1-x23a.google.com [IPv6:2a00:1450:4864:20::23a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RQjRZ2VlKz20GK for ; Wed, 16 Aug 2023 19:25:46 +1000 (AEST) Received: by mail-lj1-x23a.google.com with SMTP id 38308e7fff4ca-2b9ba719605sf67353061fa.0 for ; Wed, 16 Aug 2023 02:25:45 -0700 (PDT) ARC-Seal: i=3; a=rsa-sha256; t=1692177942; cv=pass; d=google.com; s=arc-20160816; b=x+ZikacMOLTYWp0n5cw6O1woT4gWESOLRI5wacHAUEUD4x3PV8CM2fC4kY8/+SGcnw bpyHmO5vA6n328u72INRZ6XK71KHihxRyFunAnp6+N0i2WhvhMTkF3vsUGAbFGTEl6Nw 0sNcwMd81BR20u8hG4PtGp1iskKDzPQ7sfP4A7r2ZQ5U3IvpqsJE0P4kD7ptcZsCvyfc raioJNRbm04Oa/QZMgm8BNJmD0ycsAb8DhgcPjWRhrdiedgXo8ky9hB74P9T1zvBvOCe BZyycE2yPeZCHLhvXNY9jSgxhsGaM+Y099TYFxXlzlbj5v8Ql+aXWNXTeWiZSE95FDEj 4WGw== ARC-Message-Signature: i=3; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=Ycp/RdbGuImoUMYtPMtjYVdmec6QKdrHTiPvkGEq90E=; fh=Kx/qaUBQq4aIkY1SoIKMx6P8QmNdACfl4f1zQHU0BKI=; b=asXriE2H5OI4NMB1VsBo5rd9N/ovMDSNC/yyda2DctyNhW7AEWza0ABHSZqd5J1pX9 Bp6BAaFTYfKoRuCiiRlshgZiq2ePf7jjYQv9VeoPexdjIGzjIbvameV92zbNz/VR4D8U vItUd7Xb6/Bs86n4/oN0q1ZbYyhj6oag8cd9xGxm0SLY9Ig8CBqwgtEQKGZZm18WgrWk cXUoLBUaoUSVFSp3Qnvyp64LcwGBfp+hp1xAYA38ej4ObUYMardoNsvxELPQ1Ve6sBks se/vhH2wVk44rfHXzIVRYoItkjcoLVAU6QsWYwHYSza1tWWbyrpMZmIQ3XszqYNjanV0 ErGw== ARC-Authentication-Results: i=3; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=ggVtDZkl; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of michael.adler@siemens.com designates 2a01:111:f400:fe1f::615 as permitted sender) smtp.mailfrom=michael.adler@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20221208; t=1692177942; x=1692782742; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=Ycp/RdbGuImoUMYtPMtjYVdmec6QKdrHTiPvkGEq90E=; b=TXljUr5JHM8cbteQ9LBNcBAoIV2G/bSYeK8hXq6ELhNrwBBmz72/WvpSM9GiD+/SIJ Bv47UEiXvP+KD/kU2xnr8bYcSrDvcsbOT+8P114VoZHtJqxjaQUO+zXjq0uNnhJFc4Pw qIK1yw49oaqtbUFP33Tgh0OE/K0+arcmJRqUshIVMQSuqf+DJXDZBn6DbpDfyTIeJh+O 95nze9s4z9KqgKbpsGwWbhDky8+BoVobKElUKFGlX8ZKVNMOD7BDOqPg8gYjTPQ/PJ4D VWi5mQvLhTo1yuQfoyEECXI6h6MG2A6Pc2Ie0G7T2obXfGlS2S2GSiZ4H7QXsesBTJS1 ftEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692177942; x=1692782742; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ycp/RdbGuImoUMYtPMtjYVdmec6QKdrHTiPvkGEq90E=; b=dlezLN0iH4NomF/9jyFMLHdO1bsbVmtL16dRIEWVUvuu4e0QLqNB30ceGn78dIb4QY 73V2EvzH+GmYGYPFtAlTMLN7k3rWahgjQOVsib3TY4FGcShi9doooYiE7ZycNXussH0j Dx6WInc/IKeT5Q1yDqEepJISENadk/g9mgX+ZD3WdcQ5BrsX2D/Kav7YTNx4BbrzyA1I Jv8rAj3W4J9z5pxBV3GPPrDzm+wwQYSnp9ktGbcxihiOrf4UsBOmN85FyGxA+XRq4CQL aM5CLPDA3U5kyaa3IWDJ7wmWphP+CbY8js2RdOevvTTtErVttO1LfDysweedfF270Za5 y7Ow== X-Gm-Message-State: AOJu0Yzg08Vrh3vLnagKRjrIOvhA3O++fX5VYCjKx4X0ufGhAlKmh+f2 uy3O2SsVdNNldolLPctQ2KI= X-Google-Smtp-Source: AGHT+IE3+kxQ59S4CUH/l7mMvASDvy2lQ9uNj7vzr1KacvFu+LRPzgdTYW9aRVk0PlUSslkO0SDrCw== X-Received: by 2002:a2e:8884:0:b0:2bb:99fa:175f with SMTP id k4-20020a2e8884000000b002bb99fa175fmr763342lji.24.1692177941554; Wed, 16 Aug 2023 02:25:41 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a2e:a7c3:0:b0:2b9:722f:8f69 with SMTP id x3-20020a2ea7c3000000b002b9722f8f69ls83997ljp.1.-pod-prod-03-eu; Wed, 16 Aug 2023 02:25:39 -0700 (PDT) X-Received: by 2002:a05:6512:250b:b0:4fd:d18f:2d93 with SMTP id be11-20020a056512250b00b004fdd18f2d93mr1189765lfb.6.1692177939537; Wed, 16 Aug 2023 02:25:39 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1692177939; cv=pass; d=google.com; s=arc-20160816; b=OEWcMC+YpmV/CFFPwQea8dw1eoCKcgusde3+/efmQWps0i7/KsA1uAj0g94k8Kaffb SfQyWOEg3KwyhIxX/IFVRcgVrFSjDbIs3Bq3YF49GLirgdT3eIAO2NqenSD1t+c7zf/q sbmVkeBqivAoXQ/4epwmVDCiM/0S/YHwoRhNb7iKgOn6mHIK9Xb74M7gIYBHECaprihp pmsuvKzWqkUrIHLwD5DMCs3aDTCBJoO8sL79xL3+rAdVnG9Pw/3oDefSpV5DWy1mQg5o nlNICl/TJ15cXGpw4NSZEzPb9iIAzRfjqyoUHy0FH4q3V2v4Y8ObaFHvkQUOsiaTeGh2 xYTA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=x6G09QWwoxvAXekSJ8mfCkLDu12UwN7X+PLQnrUkRDA=; fh=zDoa3cv2e04B0TI/AH7KhrV3mbhKigutYs4hkUXT9HQ=; b=Fi+4DmQcy5bWB2mzX+SFsJiVa0Ei/RH08ayqgENbEhKbY3PiOuzdxRM0GG5D/5kHIy tlGDUy0l+qgI2nPBrZ4DtnC+j3vhy7awtJU0sYyuEOhkhb8OXXFOooIAPRKeyjVrmYzJ Pi07vPe6A8EN3C6Lz+FDJz4LhAUmNAwPdOxzBXB2gOWrJ150UQXPwCi61J93VeCvwtMZ pjxT2//6ouTZT59XG07LLzk/VX7hYBUwsqgETqSLa+cWnWODoaYaicD4w6UOwfwFwB/k 3g/6GXnpTuz2x25xzPIEVqVhYPUL5ZVmT2lwNGbw/5N75JD0IDm8y7qJHDzg00MOB5w0 D4fQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=ggVtDZkl; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of michael.adler@siemens.com designates 2a01:111:f400:fe1f::615 as permitted sender) smtp.mailfrom=michael.adler@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0615.outbound.protection.outlook.com. [2a01:111:f400:fe1f::615]) by gmr-mx.google.com with ESMTPS id n26-20020a05651203fa00b004ff76606e55si442962lfq.9.2023.08.16.02.25.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Aug 2023 02:25:39 -0700 (PDT) Received-SPF: pass (google.com: domain of michael.adler@siemens.com designates 2a01:111:f400:fe1f::615 as permitted sender) client-ip=2a01:111:f400:fe1f::615; ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OE8HG1eM5F9ehAS8UL4Bs/9HfZsSE68SyUhj8/RG6wWwpKctIjnM1u2vDLO/blSHWUkGWWLZsYBf9HSOtJTaNjQDKSjPJ7aIF22Msp7o3eZiJv9Ix5HV0rmKG69U2I6w26Xb2rFlfC2qlV1kgRmR4+zFHDFXQKZMOuq9MisQfsHePnPAVp+GNTZgHFpSbP9EbH3uRMn/jzIIte6h4xSiOc5Q13pz13jWLeFP00V0fpnoy3bZEB7K4Yggcwgae3aPRY0ddhf31jXG/C81FiLY8g2+xJ2kkSqB5oE1cfyh90rLYIqBuwecuANI8UB1PHJBb/w7IPuaLlA7JAqYxBp58Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x6G09QWwoxvAXekSJ8mfCkLDu12UwN7X+PLQnrUkRDA=; b=k09BH/K6fczTO8kQWayS3cmmxFzH2Pin75EKQVv+0D/QuuNDST+W5exdNgkt/MwIA9q7OLUjQjDny3Mxq/XbMo9lmelqxslE9TQ/ydQhgg3aW/S1uRy9StM0EpqWFJk7f3SBfrk/edYUYSzijHdUBgcIyrwiejGHZNaSdVoXwNExJkZt29GxlA6cW+vvKyVuV+Gorh+0e/0rwupFUx5sZ4mUHWu70fMa3H9hRfO3S27T3o5MSVRlvWE3R2vD5gAFt/RVxweGoSpFq2MALQ6sL4fEIEmsX3MsZ7kSrgmCvuDYRoD0PT86JEZE5a26ZNXNkpopWRszjnH0I/iVOY9+sQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none Received: from PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:12e::15) by DB4PR10MB7422.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:3f1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.26; Wed, 16 Aug 2023 09:25:38 +0000 Received: from PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM ([fe80::9505:a6cb:9759:b1df]) by PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM ([fe80::9505:a6cb:9759:b1df%3]) with mapi id 15.20.6678.025; Wed, 16 Aug 2023 09:25:37 +0000 X-Patchwork-Original-From: "'Michael Adler' via swupdate" From: Michael Adler To: swupdate@googlegroups.com Cc: Michael Adler , Christian Storm Subject: [swupdate] [PATCH 3/3] ebg: fix integer underflow Date: Wed, 16 Aug 2023 11:24:24 +0200 Message-ID: <20230816092424.203252-4-michael.adler@siemens.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230816092424.203252-1-michael.adler@siemens.com> References: <20230816092424.203252-1-michael.adler@siemens.com> X-ClientProxiedBy: FR0P281CA0141.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::12) To PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:12e::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR10MB4734:EE_|DB4PR10MB7422:EE_ X-MS-Office365-Filtering-Correlation-Id: c4c4a741-0de3-4373-012f-08db9e3ac087 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TH2YrrchlGNHSTEO7NGCxqg9QXaMUqztm5xUoezP0Qme+r8LynTkVFNzjcdrTt7oSVwqSSlRQJ3wqWWbN5HU21jVFekQQevU3Z19pgr6VsgHsIy2fBigvz77ta1aWAi61UY+cc4cmXQsnbB5kZZx4E1BYqSIyE87tHUA9681G6X4Pl2r1czE7sAP0X+jWAu6BLxAOj4i8pfi0GGOEJagiFbXnfRdMGULY8RBJE9c+W1PkQQY+ke0ihflwJxngqd7geEJSttTLMlbX+mzjJp6FNpEpdtxzNazq5tuceJ9TkdQ3Cw3bZmKqFclX/5dWDPVOuMnn4+kpGQ5JdN660jc9QV6t+6eHc6VMNlSIzto2d+lEW6yyoKJ1sbz3T/hqbrvyBh7LFISQJpuBjKSLZg5NAQUzYD62sC3lwksCsZ69tP4oWTwMORTeiZ42PIwVptAiiPf94XdlegjXsDIy4lsF/EqgHJyXoCrrDolXA5NgkD5Q5ADOvMjHvXWZ8wePU2SxMFkRk98mfeuKspjsjXjzYAKRJotaCIQNgGhMiSBLHYWb0roSEvQwLZIJwJYLaMe X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(346002)(366004)(396003)(136003)(376002)(39860400002)(1800799009)(451199024)(186009)(2906002)(83380400001)(86362001)(478600001)(36756003)(2616005)(6486002)(6506007)(6666004)(1076003)(107886003)(6512007)(26005)(5660300002)(44832011)(41300700001)(6916009)(316002)(54906003)(66946007)(66556008)(66476007)(4326008)(8676002)(8936002)(82960400001)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: RYfUzL9372aUQGYJDlKGiX8Hft9Ka9/jcbPbTHYjDacXTdLUUR4JXzGYqZe8kmenOCkt57qsYZ8gKiCgC/2SBU+XdIqttw2OjivoqsmkVq6r8voiL0LAwMLN32WRpipUP4Hohxcwvx9JVM08ytq2Qdbm7YGkJFabooSNrK5fV/NujTnJk7SBHfRC87fxWKs/okLr6+Uv+5rqLacDabY5LVsfaEt9FqlRkx/RexB0ozw7hOcS+AElGLvMafefzefCflu1o1Gth5XbjtHP+aIxQr21R3oDdDfst1xza/A3ebBon5dArPHUfQZNf/Xae8/2nMgiXTobUpSUmdjH6IM8NnnC9b4411zAKCiM/XXDY4AxQlMa//O+SZ5MprnEpWhH8kbUUoLtt93nHft43hroidBBapsPnUC1UH7Dbl7pDQFYpPlOx1/0CWUMOKfSP+MHIfJWeqRw+Pto86Hyl12hHz7ZitayUXG+w7BZ9TsZ0pmsqf4E7GcZKt+svvrnNEWnxjxaz0MKp2nfRkpIN3DJzkiVjxggbgqJL/jTie8tpQGQvtE+4uSLK9/P4/kup/O2CcDzY193LDc6ztjQNKtIHedSwAGWjjB0AIoCuARS5zxJSuyOTVdl+E4QNSOMfvI1aASec0oc2GLzUTO8p5HtyGmhiYR1XdJatGWPOgCxDfwzN9N33DLdM5wji0iMdA4YpzwhwtrV/+07Yrf4zTNc1VzrGO2fXIjs4zWbUn65/aj1BfkAN3F4ErpDoQrn4r7XCxANbyr3hg2rpyH99iNwRbit9HLAk7z0TJoDRVkRhoW4oBEyAUliOSjQhAmlWgqmsB/jqzOgKlAnVbz86to7TZh1wdOm83VdBnYficX2KyS6YisVEXH18bQ/FM9b7f37aJ0JY2g9QWojucyJeMrimdkD1KS1tcEQJSW1+GlUOJnmRmT+d4CkdAyaD4vS8DQG6IA6/prGxWbsL8tlhaY4hld3HoQXKJtMXUJe7N3aYuP8ar+qyt8n6DAJnVRn0e0rFtMj7gM/beZ1mirxVsKY8X2p7vDBpCvnkJYV8S6DmJhAeJofKY/yyFbOpPzgNtHfJodgomBt46U7/o55ogtjOiP35TEmAxL14dyNbsI0soxPGHR+fqJ87CGDrg0tUDroC1Mu5I9G+qmIDtAPQ2m8KbAtV7nMLqm0GujSJOIrMjRfyb8IBaPLaGlq25Jnvdjd93xTUDgDw7AiNkl09V7DosBGgf+VdJK211lsBgd7pEEfBhjx67Pay2H0DSFh2YHqDkHgHBZjz3kLI6NwcDJi5GxT8SFE3l218+UIfoK8wmYhF8nUHS7ORON9oJE/Xq1p3614K8IH4r7KvVpCm0ShCAFnMDmnqDM1BXtaIHhBTQbSmP9acG6snfHPqM6cNzVmt2dbUZjm/+qinAoYR3nTI6DZ0E5chsEcfLfj2s5NI2ziZ0OIWH+c6VN+NudvY8azc+bR7yDGogr+Gh0enemFavbEVAmQ/5ctsDRP/iuIJNFFvibMj+Yp6APyYmcJuX6pJjBeJtuggQHXCIZCPp2p8lwO5ZPP+vPLat6gCOuQ8F13/d7KZ0kWLDo6VcnZloVbBM1d/dwaHeQ4AbhRztwcYA== X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4c4a741-0de3-4373-012f-08db9e3ac087 X-MS-Exchange-CrossTenant-AuthSource: PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2023 09:25:37.9093 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HVl8zwypJ5/FdeUxwhWYPQ1uRvm3nDDLfaMqpnGtzsBfMHmbnO92VTnDmnYyLJ81Z/4R9+3UajGMwTcE0W1ll4O7zAK54lzLNR2E0UINT3U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR10MB7422 X-Original-Sender: Michael.Adler@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=ggVtDZkl; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of michael.adler@siemens.com designates 2a01:111:f400:fe1f::615 as permitted sender) smtp.mailfrom=michael.adler@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Michael Adler Reply-To: Michael Adler Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , bgenv_get returns a negative value (-ENOENT) if the variable does not exist, which results in an integer underflow if the variable `size` is unsigned. Currently, this results in an attempt to malloc approx. 16 exabytes, which luckily fails on most systems. The solution is to check for a valid (i.e. positive) size before trying to malloc it. Signed-off-by: Michael Adler Signed-off-by: Christian Storm --- bootloader/ebg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bootloader/ebg.c b/bootloader/ebg.c index 76a1e28..d10e1c4 100644 --- a/bootloader/ebg.c +++ b/bootloader/ebg.c @@ -113,8 +113,8 @@ static char *_env_get(const char *name) * value's size in bytes, the second call, with an accordingly * sized buffer, yields the actual value. */ - size_t size = libebg.env_get(&ebgenv, (char *)name, NULL); - if (size == 0) { + int size = libebg.env_get(&ebgenv, (char *)name, NULL); + if (size <= 0) { WARN("Cannot find key %s", name); return NULL; }