From patchwork Wed Jul 26 17:33:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prathamesh Kulkarni X-Patchwork-Id: 1813360 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=WkjAMWb9; dkim-atps=neutral Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RB1Gs6QzDz1yY5 for ; Thu, 27 Jul 2023 03:34:11 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C69633857437 for ; Wed, 26 Jul 2023 17:34:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C69633857437 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1690392849; bh=mfiRGzomjoJ68JuQniNuqSRxZyQoqVgtAcL5Ylhefd8=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=WkjAMWb993N1vp9D7Dkc/DUvWZFYT/Jwj3u1+cGkcX9qVkp4WV9XnXWF19Vjp6GGo YWRF7+OXJCedzK3aZY5UZe1WzDlTX0XdnoD9L6Is86ROB/LqQhTDdCzbRpNYJ1ChTr OUzCiKjE9UlKQj2rGojiXjZ9sRbki8NlqXdmNGKk= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id 25FA53858C52 for ; Wed, 26 Jul 2023 17:33:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 25FA53858C52 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-3fbd33a57dcso70990605e9.0 for ; Wed, 26 Jul 2023 10:33:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690392825; x=1690997625; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=mfiRGzomjoJ68JuQniNuqSRxZyQoqVgtAcL5Ylhefd8=; b=itx4fKmnLPH+6tR0aicc+nrWywjinDYlAbQmUsHsF3gTqXciGGwXRSIqfyH8SJW7YF E9u0zJXOzUQtU/8n9jmgLkst+d3iA2F+4CYgfIWwVGU+9VQWQM9RM/2gsVcxShVdrRGT A5zltBw8su3osxFHKU+DiXfIehannACWkEKR1vy14ctx0V3OfP04JK/G3RnrJ+mE3ucJ vQEF3R21OykBYjhsjOoFheLYC4GdC0Sum2yU/QPzVOzI43vEa/reU+hBwzCSW99gmHO8 tXJiWt8y0bwvnIY3+uyaM3vglr+O3PFGGYwc5N3f1pl7BHP0NMdZOh2etNNM3il7i19O 16tA== X-Gm-Message-State: ABy/qLZwmiFXNu6bzj8Gmr0sDPHZEfo0KNTDO2TxIohs7dhXJPjrludc Vy17t6F0QSGxgks5t4s9LdZaGoDtsDmO5GWRXXzp1XwtrqFMT3oH X-Google-Smtp-Source: APBJJlFC5fKC4IM15UB0AIm2yicdsfpn6F/Ux6SNhOR6wlG/noMK0GoIv5Bk5KG2FHPMMlFVEG0fYRU3u664rClvtRM= X-Received: by 2002:a5d:6a09:0:b0:314:1483:d8ad with SMTP id m9-20020a5d6a09000000b003141483d8admr2214480wru.44.1690392824803; Wed, 26 Jul 2023 10:33:44 -0700 (PDT) MIME-Version: 1.0 Date: Wed, 26 Jul 2023 23:03:10 +0530 Message-ID: Subject: [gcc-13] Backport PR10280 fix To: gcc Patches , Richard Biener X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Prathamesh Kulkarni via Gcc-patches From: Prathamesh Kulkarni Reply-To: Prathamesh Kulkarni Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Hi Richard, Sorry for the delay in backport to gcc-13. The attached patch (cherry picked from master) is bootstrapped+tested on aarch64-linux-gnu with SVE enabled on gcc-13 branch. OK to commit to gcc-13 branch ? Thanks, Prathamesh [aarch64/match.pd] Fix ICE observed in PR110280. gcc/ChangeLog: PR tree-optimization/110280 * match.pd (vec_perm_expr(v, v, mask) -> v): Explicitly build vector using build_vector_from_val with the element of input operand, and mask's type if operand and mask's types don't match. gcc/testsuite/ChangeLog: PR tree-optimization/110280 * gcc.target/aarch64/sve/pr110280.c: New test. (cherry picked from commit 85d8e0d8d5342ec8b4e6a54e22741c30b33c6f04) diff --git a/gcc/match.pd b/gcc/match.pd index 91182448250..c3bb4fbc0a7 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -8292,7 +8292,14 @@ and, (simplify (vec_perm vec_same_elem_p@0 @0 @1) - @0) + (if (types_match (type, TREE_TYPE (@0))) + @0 + (with + { + tree elem = uniform_vector_p (@0); + } + (if (elem) + { build_vector_from_val (type, elem); })))) /* Push VEC_PERM earlier if that may help FMA perception (PR101895). */ (simplify diff --git a/gcc/testsuite/gcc.target/aarch64/sve/pr110280.c b/gcc/testsuite/gcc.target/aarch64/sve/pr110280.c new file mode 100644 index 00000000000..d3279f38362 --- /dev/null +++ b/gcc/testsuite/gcc.target/aarch64/sve/pr110280.c @@ -0,0 +1,12 @@ +/* { dg-do compile } */ +/* { dg-options "-O3 -fdump-tree-optimized" } */ + +#include "arm_sve.h" + +svuint32_t l() +{ + _Alignas(16) const unsigned int lanes[4] = {0, 0, 0, 0}; + return svld1rq_u32(svptrue_b8(), lanes); +} + +/* { dg-final { scan-tree-dump-not "VEC_PERM_EXPR" "optimized" } } */