From patchwork Wed Jun 21 10:24:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Romanov X-Patchwork-Id: 1797881 X-Patchwork-Delegate: narmstrong@baylibre.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=sberdevices.ru header.i=@sberdevices.ru header.a=rsa-sha256 header.s=mail header.b=MfSibZ02; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QmMsK58fZz20WT for ; Wed, 21 Jun 2023 22:15:33 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 44E2D86351; Wed, 21 Jun 2023 14:15:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=sberdevices.ru Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=sberdevices.ru header.i=@sberdevices.ru header.b="MfSibZ02"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0309E86351; Wed, 21 Jun 2023 12:24:23 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4A17386343 for ; Wed, 21 Jun 2023 12:24:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=sberdevices.ru Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=AVRomanov@sberdevices.ru Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id 7F72F5FD74; Wed, 21 Jun 2023 13:24:18 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1687343058; bh=1qwBUQ4aCheelkPYm4DMSKRyqJaRKYCxGlJ+mzWFaWU=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=MfSibZ02oA6x398fGr/a8FJ00V8R4Q5gPYqOtdg4EgjE8nUMqmpRQJ4Qdty3i1XXE HbT+r+LObESGkOdzcu/15lgoEdV/SjVvISaf54+GQsX5GiSScFs3dGWehzZRCdABQ1 YUtP3gk9Uqj/rYK94HGVSMYaqj7s4U8FoR7G0841s2fi/dbSWioB5ZWEnGB9cB4IWu FbwUueEFTUQezmxr+5NG2lvfi+6//Mce+BwRdOlZ/QvW9ZCFSP0OR4DHkwNLGDQUEO RFH/dEaE8FiVXmYky7fxL0IgI9q5QR9tZGvJ5ecjKAM1QLo8yIlvdY1jIp7sLStK3B a+X1doSqcfgrw== Received: from p-i-exch-sc-m01.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru [172.16.192.107]) by mx.sberdevices.ru (Postfix) with ESMTP; Wed, 21 Jun 2023 13:24:16 +0300 (MSK) From: Alexey Romanov To: , , , CC: , , , Alexey Romanov Subject: [PATCH v1] drivers: rng: add check status bit feature Date: Wed, 21 Jun 2023 13:24:01 +0300 Message-ID: <20230621102401.76646-1-avromanov@sberdevices.ru> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 X-Originating-IP: [100.64.160.123] X-ClientProxiedBy: p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) To p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2023/06/21 06:08:00 #21543483 X-KSMG-AntiVirus-Status: Clean, skipped X-Mailman-Approved-At: Wed, 21 Jun 2023 14:15:03 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean For some Amlogic SOC's, the mechanism for obtain a random number has been changed. For example, S4 now uses a status bit wait algo. Signed-off-by: Alexey Romanov --- drivers/rng/meson-rng.c | 73 +++++++++++++++++++++++++++++++++++++---- 1 file changed, 67 insertions(+), 6 deletions(-) diff --git a/drivers/rng/meson-rng.c b/drivers/rng/meson-rng.c index e0a1e8c7e04..3bf2eb9cf87 100644 --- a/drivers/rng/meson-rng.c +++ b/drivers/rng/meson-rng.c @@ -11,36 +11,82 @@ #include #include +struct meson_rng_data { + bool check_status_bit; +}; + struct meson_rng_plat { fdt_addr_t base; struct clk clk; + struct meson_rng_data *data; }; +#define RETRY_CNT 100 +#define RNG_OUT_OFFSET 0x08 + +#define SEED_READY_STS_BIT 0 +#define RUN_BIT 31 + +static int meson_rng_wait_status(struct meson_rng_plat *pdata, int bit) +{ + u32 status; + u32 cnt = 0; + + pr_debug("Poll status of bit: %d\n", bit); + + do { + status = readl(pdata->base) & BIT(bit); + } while (status && (cnt++ < RETRY_CNT)); + + if (cnt == RETRY_CNT) { + pr_err("Can't get random number, try again"); + return -EBUSY; + } + + return 0; +} + /** * meson_rng_read() - fill buffer with random bytes * * @buffer: buffer to receive data * @size: size of buffer * - * Return: 0 + * Return: 0 on success or -errno in failure */ static int meson_rng_read(struct udevice *dev, void *data, size_t len) { struct meson_rng_plat *pdata = dev_get_plat(dev); + struct meson_rng_data *rng_data = pdata->data; char *buffer = (char *)data; + int err; while (len) { - u32 rand = readl(pdata->base); + u32 rand; size_t step; - if (len >= 4) - step = 4; - else - step = len; + if (rng_data->check_status_bit) { + writel(readl(pdata->base) | BIT(SEED_READY_STS_BIT), pdata->base); + + err = meson_rng_wait_status(pdata, SEED_READY_STS_BIT); + if (err) + return err; + + err = meson_rng_wait_status(pdata, RUN_BIT); + if (err) + return err; + + rand = readl(pdata->base + RNG_OUT_OFFSET); + } else { + rand = readl(pdata->base); + } + + step = min_t(u32, len, 4); memcpy(buffer, &rand, step); buffer += step; len -= step; } + return 0; } @@ -90,6 +136,8 @@ static int meson_rng_of_to_plat(struct udevice *dev) if (!pdata->base) return -ENODEV; + pdata->data = (struct meson_rng_data *)dev_get_driver_data(dev); + /* Get optional "core" clock */ err = clk_get_by_name_optional(dev, "core", &pdata->clk); if (err) @@ -102,9 +150,22 @@ static const struct dm_rng_ops meson_rng_ops = { .read = meson_rng_read, }; +static const struct meson_rng_data meson_rng_data = { + .check_status_bit = false, +}; + +static const struct meson_rng_data meson_rng_data_s4 = { + .check_status_bit = true, +}; + static const struct udevice_id meson_rng_match[] = { { .compatible = "amlogic,meson-rng", + .data = (ulong)&meson_rng_data, + }, + { + .compatible = "amlogic,meson-rng-s4", + .data = (ulong)&meson_rng_data_s4, }, {}, };