From patchwork Sat Jun 3 22:52:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takayuki 'January June' Suwa X-Patchwork-Id: 1790008 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=jhAQDtvQ; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QYZrt3wT0z20Tj for ; Sun, 4 Jun 2023 08:52:46 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7DCDD3858C2B for ; Sat, 3 Jun 2023 22:52:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7DCDD3858C2B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1685832763; bh=1qBcPpnL7nXRGqFCuZ4t5uLOY//dRpmK4vsXOaWX11U=; h=Date:To:Cc:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=jhAQDtvQNjG95eL6qKIEWBl7iidhrcRCBQwluuTzOhxIm1gg/luJGqlRXDvvWODu/ hFnBtRzEL1Nario0Sn8fYG1o3bi0hMV246dMZC5gGfFGKNbuXB7UL0+9EjbqIfrM+r QiZgwF9g4m29z+gQd3EfuKWQuLlvVwzl8b6F/P5M= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from omggw0005-vm0.mail.otm.yahoo.co.jp (omggw0005-vm0.mail.otm.yahoo.co.jp [182.22.18.106]) by sourceware.org (Postfix) with ESMTPS id EDD123858D1E for ; Sat, 3 Jun 2023 22:52:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EDD123858D1E X-YMail-OSG: ZeuASrIVM1kbVOpIGLRWskiDyh.1IYCVB44mej8IKprFv2Z3hqekh8zef8reuFx zAQMXjOCLJM2zxAB9H.kXzaGa9T2avocvKAL4w_X7Swe5fPUmrwYZpZmuM0Hu7.Rf0jgH1MTzZaJ mb9npd4Wu6.GohLBSNMB_ONv5GPmFdx6SdMsubeQRWpiJt1m0Aja3fXNiY5OLe6zFsoa96YroZkr QQqhTgac4yyLrKizzCYXveOsCKupX.SZ_DgCZmEErZcGth2fpSHOa8DE8zjNRxelUYZFlfASo2N9 W21jsLDVj87u3KdX5uHFlNpJD__.QSnURJPCe3gkYXNUkSEtD9HSkD1uWu0VyRIjb1kBEqq0BZCb ksb.gdEsCMHOi.DpmRTjYJ5yYey7fWFndvBCUFsULiqPAkUlQQPshoyhE3YHRShKYP4qXXI.aCW6 eOpXEpXy1YDFKoFO2o0YjiJA10Iaj8yEFt3WJfKjdbCYQY2aFrYrnOwJWROu4aZvBl2oMstmdUnS JG9iL6ZeLI.9f9GrwAGFjuLOwuTAt.4xGNIFhFj0xW4P3pC1CWCUVvswuzT8lyP6b.NWTFZoYvIr xb_dRU0Evffn04RpJ1FzwOId0X6Cdevglvo_rmEAfZ624MA9mfC_1XbZpSyNLzolLB_2ET8hvjVi wzbJb8PH06VfLVo2C7PLCY8KzCPyFrA5o.OgI2BG4bNES7u6A5F1OIuY.FYK_pPEDvj6gN4j.blA atwm3dMNzrunRUFWwbFpNsM3JQzwQG7LnvqacPy5.apjKkdQh7Gh_ouFHhzv5gkNTUmrS2Tzkp3. MQ8tEUymhPEtUlbJtNEpxKESpeAkH511h9XEIaYiA33ww.YlISw_Ejc7Jk5ZVGQ25lNsOzmn3d._ eRXYrDPjwTjKvb0J4w.Jfq4Au0PJioxN3eO3ISCEk_Lb.g1EahhZvqb6M5WnObHOpQL7xOLCEi3A .yoH3tWNSIUJ4S8NWoqwpETWFGxb2Jv2XUplOePVkFmi851p7665rcV.73RloJ6y6INQ- Received: from sonicgw.mail.yahoo.co.jp by sonicconh6003.mail.ssk.yahoo.co.jp with HTTP; Sat, 3 Jun 2023 22:52:19 +0000 Received: by smtphe6007.mail.ssk.ynwp.yahoo.co.jp (YJ Hermes SMTP Server) with ESMTPA ID 6d24ea962711b0d046c88ed95cc4a3a4; Sun, 04 Jun 2023 07:52:17 +0900 (JST) Message-ID: Date: Sun, 4 Jun 2023 07:52:16 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 To: GCC Patches Cc: Max Filippov Subject: [PATCH] xtensa: Optimize boolean evaluation or branching when EQ/NE to INT_MIN References: X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Takayuki 'January June' Suwa via Gcc-patches From: Takayuki 'January June' Suwa Reply-To: Takayuki 'January June' Suwa Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" This patch optimizes both the boolean evaluation of and the branching of EQ/NE against INT_MIN (-2147483648), by taking advantage of the specifi- cation the ABS machine instruction on Xtensa returns INT_MIN iff INT_MIN, otherwise non-negative value. /* example */ int test0(int x) { return (x == -2147483648); } int test1(int x) { return (x != -2147483648); } extern void foo(void); void test2(int x) { if(x == -2147483648) foo(); } void test3(int x) { if(x != -2147483648) foo(); } ;; before test0: movi.n a9, -1 slli a9, a9, 31 add.n a2, a2, a9 nsau a2, a2 srli a2, a2, 5 ret.n test1: movi.n a9, -1 slli a9, a9, 31 add.n a9, a2, a9 movi.n a2, 1 moveqz a2, a9, a9 ret.n test2: movi.n a9, -1 slli a9, a9, 31 bne a2, a9, .L3 j.l foo, a9 .L3: ret.n test3: movi.n a9, -1 slli a9, a9, 31 beq a2, a9, .L5 j.l foo, a9 .L5: ret.n ;; after test0: abs a2, a2 extui a2, a2, 31, 1 ret.n test1: abs a2, a2 srai a2, a2, 31 addi.n a2, a2, 1 ret.n test2: abs a2, a2 bbci a2, 31, .L3 j.l foo, a9 .L3: ret.n test3: abs a2, a2 bbsi a2, 31, .L5 j.l foo, a9 .L5: ret.n gcc/ChangeLog: * config/xtensa/xtensa.md (*btrue_INT_MIN, *eqne_INT_MIN): New insn_and_split patterns. --- gcc/config/xtensa/xtensa.md | 64 +++++++++++++++++++++++++++++++++++++ 1 file changed, 64 insertions(+) diff --git a/gcc/config/xtensa/xtensa.md b/gcc/config/xtensa/xtensa.md index 87620934bbe..c9790babf75 100644 --- a/gcc/config/xtensa/xtensa.md +++ b/gcc/config/xtensa/xtensa.md @@ -1940,6 +1940,37 @@ (const_int 2) (const_int 3)))]) +(define_insn_and_split "*btrue_INT_MIN" + [(set (pc) + (if_then_else (match_operator 2 "boolean_operator" + [(match_operand:SI 0 "register_operand" "r") + (const_int -2147483648)]) + (label_ref (match_operand 1 "")) + (pc)))] + "TARGET_ABS" + "#" + "&& can_create_pseudo_p ()" + [(set (match_dup 3) + (abs:SI (match_dup 0))) + (set (pc) + (if_then_else (match_op_dup 2 + [(zero_extract:SI (match_dup 3) + (const_int 1) + (match_dup 4)) + (const_int 0)]) + (label_ref (match_dup 1)) + (pc)))] +{ + operands[3] = gen_reg_rtx (SImode); + operands[4] = GEN_INT (BITS_BIG_ENDIAN ? 0 : 31); + operands[2] = gen_rtx_fmt_ee (reverse_condition (GET_CODE (operands[2])), + VOIDmode, XEXP (operands[2], 0), + const0_rtx); +} + [(set_attr "type" "jump") + (set_attr "mode" "none") + (set_attr "length" "6")]) + (define_insn "*ubtrue" [(set (pc) (if_then_else (match_operator 3 "ubranch_operator" @@ -3198,6 +3229,39 @@ (set_attr "mode" "SI") (set_attr "length" "6")]) +(define_insn_and_split "*eqne_INT_MIN" + [(set (match_operand:SI 0 "register_operand" "=a") + (match_operator 2 "boolean_operator" + [(match_operand:SI 1 "register_operand" "r") + (const_int -2147483648)]))] + "TARGET_ABS" + "#" + "&& 1" + [(set (match_dup 0) + (abs:SI (match_dup 1))) + (set (match_dup 0) + (match_op_dup:SI 2 + [(match_dup 0) + (const_int 31)])) + (match_dup 3)] +{ + enum rtx_code code = GET_CODE (operands[2]); + operands[2] = gen_rtx_fmt_ee ((code == EQ) ? LSHIFTRT : ASHIFTRT, + SImode, XEXP (operands[2], 0), + XEXP (operands[2], 1)); + operands[3] = (code != EQ) ? gen_addsi3 (operands[0], + operands[0], const1_rtx) + : const0_rtx; +} + [(set_attr "type" "move") + (set_attr "mode" "SI") + (set (attr "length") + (if_then_else (match_test "GET_CODE (operands[2]) == EQ") + (const_int 3) + (if_then_else (match_test "TARGET_DENSITY") + (const_int 5) + (const_int 6))))]) + (define_peephole2 [(set (match_operand:SI 0 "register_operand") (match_operand:SI 6 "reload_operand"))